[RESULT][VOTE] Release Apache Polaris 0.9.0-incubating (rc6)

Hi folks, This vote passed with the following result: +1 (binding): Robert Stupp, JB Onofré, Russell Spitzer, Ryan Blue +1 (non binding): Dmitri Bourlatchkov I'm now moving the vote to gene...@incubator.apache.org mailing list. Thanks everyone for your vote! Regards JB On Mon, Feb 17, 2025 at

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc6)

Hi Ryan I agree, and I thought it's what I did, but it's not: my bad. I propose to move forward with the release to the IPMC and we will cleanup NOTICE for the next release. Thanks ! Regards JB On Thu, Feb 20, 2025 at 7:22 PM rdb...@gmail.com wrote: > > +1 > > The update to DISCLAIMER and NOTI

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc6)

+1 (nb) Verified: * checksum * signature * ./gradlew build Cheers, Dmitri. On Mon, Feb 17, 2025 at 3:28 PM Jean-Baptiste Onofré wrote: > Hi folks, > > After the vote on the incubator general mailing list, we fixed the > DISCLAIMER content and cleaned up the NOTICE file. > > This is the vote fo

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc6)

+1 The update to DISCLAIMER and NOTICE look okay to me, although I don't think that the Nessie NOTICE content is necessary. That information, which is just the copyright, is already in LICENSE to document the parts that are licensed. On Thu, Feb 20, 2025 at 6:58 AM Russell Spitzer wrote: > +1 >

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc6)

+1 On Thu, Feb 20, 2025 at 6:06 AM Jean-Baptiste Onofré wrote: > +1 (binding) > > Regards > JB > > Le lun. 17 févr. 2025 à 21:27, Jean-Baptiste Onofré a > écrit : > > > Hi folks, > > > > After the vote on the incubator general mailing list, we fixed the > > DISCLAIMER content and cleaned up the

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc6)

+1 (binding) Regards JB Le lun. 17 févr. 2025 à 21:27, Jean-Baptiste Onofré a écrit : > Hi folks, > > After the vote on the incubator general mailing list, we fixed the > DISCLAIMER content and cleaned up the NOTICE file. > > This is the vote for Apache Polaris 0.9.0-incubating rc6. > > * This

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc6)

+1 (binding) On 17.02.25 21:27, Jean-Baptiste Onofré wrote: Hi folks, After the vote on the incubator general mailing list, we fixed the DISCLAIMER content and cleaned up the NOTICE file. This is the vote for Apache Polaris 0.9.0-incubating rc6. * This corresponds to the tag: apache-polaris-0

[VOTE] Release Apache Polaris 0.9.0-incubating (rc6)

Hi folks, After the vote on the incubator general mailing list, we fixed the DISCLAIMER content and cleaned up the NOTICE file. This is the vote for Apache Polaris 0.9.0-incubating rc6. * This corresponds to the tag: apache-polaris-0.9.0-incubating-rc6 * https://github.com/apache/polaris/tree/ap

[RESULT][VOTE] Release Apache Polaris 0.9.0-incubating (rc5)

Hi folks This vote passed with the following result: +1 (binding): Ryan Blue, JB Onofré, Tyler Akidau, Robert Stupp +1 (non binding): Yufei Gu, Dmitri Bourlatchkov I'm now starting a new vote on gene...@incubator.apache.org for IPMC. Thanks everyone for your vote! Regards JB On Thu, Feb 6, 20

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc5)

+1 (binding) > On 7. Feb 2025, at 20:36, Tyler Akidau wrote: > > +1 (binding) > > Verified: > • Checksum and signature > • ./gradlew clean build > • java -jar > .//dropwizard/service/build/libs/polaris-dropwizard-service-0.9.0-incubating.jar > -v > > One observation is that running the dropwiz

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc5)

+1 (binding) Verified: • Checksum and signature • ./gradlew clean build • java -jar .//dropwizard/service/build/libs/polaris-dropwizard-service-0.9.0-incubating.jar -v One observation is that running the dropwizard service with -v doesn't produce a version. I don't feel like we should block 0.9.0

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc5)

+1 (nb) Verified: * Checksum * Signatures * ./gradlew clean build Cheers, Dmitri. On Thu, Feb 6, 2025 at 11:55 AM Jean-Baptiste Onofré wrote: > Hi folks, > > We did new fixes on NOTICE and LICENSE fix in the source distribution. > > This is the vote for Apache Polaris 0.9.0-incubating rc5. > >

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc5)

+1(non-binding) - Verified signature, checksum. - Build passed. - Started the Polaris server locally, and the sample Spark commands ran well. Thanks a lot JB for working on this. Thanks a lot, Ryan for the helping! Yufei On Thu, Feb 6, 2025 at 11:05 PM Jean-Baptiste Onofré wrote: > +1 (bindi

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc5)

+1 (binding) NB: - I created https://github.com/apache/polaris/issues/960 to not exclude md files from Rat scan - I created https://github.com/apache/polaris/issues/961 to cleanup the NOTICE Thanks ! Regards JB On Thu, Feb 6, 2025 at 5:54 PM Jean-Baptiste Onofré wrote: > > Hi folks, > > We did

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc5)

+1 It’s great to see the progress! I did find a couple of minor things: - RAT checks exclude all **.md files, which I don’t think is correct. Luckily, commenting out that line and running RAT shows that all of the markdown files have good license headers. Because the markdown has header

[VOTE] Release Apache Polaris 0.9.0-incubating (rc5)

Hi folks, We did new fixes on NOTICE and LICENSE fix in the source distribution. This is the vote for Apache Polaris 0.9.0-incubating rc5. * This corresponds to the tag: apache-polaris-0.9.0-incubating-rc5 * https://github.com/apache/polaris/tree/apache-polaris-0.9.0-incubating-rc5 * https://gi

[CANCEL][VOTE] Release Apache Polaris 0.9.0-incubating (rc4)

Hi folks, Due to missing parts on the LICENSE, I cancel this rc4 to fix that. I will propose a new rc5 asap. Thanks ! Regards JB On Wed, Jan 22, 2025 at 9:50 AM Jean-Baptiste Onofré wrote: > > Hi folks, > > Following the NOTICE/LICENSE fix and the issue found on > TestPolarisVersion in rc3, we

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc4)

Hi Ryan Good catch ! I missed that one ! I also found that PolarisRestCatalogIntegrationTest is copied from Iceberg TestRESTCatalog.java, it should be mentioned in the LICENSE file (I mentioned that in a previous message). About the Hugo site, that's a good point. I propose to create an issue ab

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc4)

Mustache templates for server and client code are copied and modified from https://github.com/OpenAPITools/openapi-generator/tree/master/modules/openapi-generator/src/main/resources/JavaJaxRS/resteasy Mike On Mon, Jan 27, 2025 at 2:36 PM rdb...@gmail.com wrote: > -1 because I think I’ve found c

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc4)

-1 because I think I’ve found copied source code that is not documented in the LICENSE file. I grepped for [Cc]opied and found that there are several mustache files that were copied from openapi-generator that are not documented in LICENSE. The openapi-generator project has an ALv2 LICENSE file wit

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc4)

+1 (binding) Verified Checksum Signatures - Note that me and JB need to verify each other's keys next time we meet in person :) Build and Test Used runApp and poked to make sure nothing was broken On Thu, Jan 23, 2025 at 6:41 PM Dmitri Bourlatchkov wrote: > +1 (ns) > > Verified: > * Checksum >

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc4)

+1 (ns) Verified: * Checksum * Signarures * ./gradlew clean assemble * ./gradlew test * Start with in-memory MetaStore * Create catalog via ./polaris CLI with FILE storage * Basic create table / select in Spark Cheers, Dmitri. On Wed, Jan 22, 2025 at 3:51 AM Jean-Baptiste Onofré wrote: > Hi f

[VOTE] Release Apache Polaris 0.9.0-incubating (rc4)

Hi folks, Following the NOTICE/LICENSE fix and the issue found on TestPolarisVersion in rc3, we fixed the test compilation issue. This is the vote for Apache Polaris 0.9.0-incubating rc4. * This corresponds to the tag: apache-polaris-0.9.0-incubating-rc4 * https://github.com/apache/polaris/tree/

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc3)

Hi Russ Locally on the tag: tags/apache-polaris-0.9.0-incubating-rc3) $ ./gradlew build -x test Starting a Gradle Daemon (subsequent builds will be faster) Configuration on demand is an incubating feature. BUILD SUCCESSFUL in 1m 11s 132 actionable tasks: 62 executed, 42 from cache, 28 up-to-date

[CANCEL][VOTE] Release Apache Polaris 0.9.0-incubating (rc3)

Hi folks, due to PolarisVersionTest compile issue, I cancel this vote to fix it. I will submit RC4 to vote with the fix asap. Sorry about that. Regards JB On Mon, Jan 20, 2025 at 8:32 AM Jean-Baptiste Onofré wrote: > > Hi folks, > > Following the rc2 vote, we fixed NOTICE/LICENSE for the sour

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc3)

Hi Russ thanks for the review. Let me do a pass, the cherry-pick on the branch is not maybe fully correct. I'm checking, thanks ! Regards JB On Tue, Jan 21, 2025 at 9:01 PM Russell Spitzer wrote: > > Let me actually link things properly, > > RC3 - aaf5d42 >

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc3)

Let me actually link things properly, RC3 - aaf5d42 Main - 4187721 Looks like the RC3 Commit is just missing the fix to the list

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc3)

Looks like this is fixed, but not in the RC Candidate? Commit on RC is aaf5d42b1959fd8d2bf617fdbe6dcf7e5b9a1eca But commit on main is 4187721e24717dd266fb147f0ca167e1a108a995 On Tue, Jan 21, 2025 at 1:52 PM Russell Spitzer wrote: > -1 > > > Task :polaris-version:compileJarTestJava FAILED > /Use

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc3)

Hmmm, for reference I only compiled production code in my tests. On Tue, Jan 21, 2025 at 2:52 PM Russell Spitzer wrote: > -1 > > > Task :polaris-version:compileJarTestJava FAILED > /Users/rspitzer/ValidateRelease/apache-polaris-0.9.0-incubating/tools/version/src/jarTest/java/org/apache/polaris/v

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc3)

-1 > Task :polaris-version:compileJarTestJava FAILED /Users/rspitzer/ValidateRelease/apache-polaris-0.9.0-incubating/tools/version/src/jarTest/java/org/apache/polaris/version/TestPolarisVersion.java:113: error: illegal start of expression } ^ Patch attached On Tue, Jan 21, 2025 at 1:19 PM D

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc3)

+1 (nb) Validated checksum, signature and local build with JDK 21. Ran and smoke-tested by creating a catalog via ./polaris CLI. Note: I did observe some WARN log messages from HK2, but I do not think those are blockers for this release. Cheers, Dmitri. On Mon, Jan 20, 2025 at 2:32 AM Jean-Bapt

[VOTE] Release Apache Polaris 0.9.0-incubating (rc3)

Hi folks, Following the rc2 vote, we fixed NOTICE/LICENSE for the source distribution. This is the vote for Apache Polaris 0.9.0-incubating rc3. * This corresponds to the tag: apache-polaris-0.9.0-incubating-rc3 * https://github.com/apache/polaris/tree/apache-polaris-0.9.0-incubating-rc3 * http

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc2)

Hi Ryan Thanks for the details. I will do a PR to address your comments, I will gently ask you to review before I merge it :) Thanks again, Regards JB On Wed, Jan 15, 2025 at 1:20 AM rdb...@gmail.com wrote: > > Hey JB, I just sent a reply to the list with additional details. I don't > think tha

[CANCEL][VOTE] Release Apache Polaris 0.9.0-incubating (rc2)

Hi folks I cancel this vote to fix concerns expressed by Ryan. I will have a PR later today and I will cut rc3 asap. Thanks Regards JB Le mer. 8 janv. 2025 à 17:00, Jean-Baptiste Onofré a écrit : > Hi folks, > > As mentioned in another thread, I submit Apache Polaris > 0.9.0-incubating rc2 t

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc2)

Ok. I disagree but I don’t want to argue. I will cancel the vote and do the changes. Regards JB Le mer. 15 janv. 2025 à 01:20, rdb...@gmail.com a écrit : > Hey JB, I just sent a reply to the list with additional details. I don't > think that this release applies license policy correctly even in

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc2)

The “blanket” is not a blanket: it’s just the note about gradle. I do read it as a blanket statement because it is not clearly associated with the next lines about gradle and refers to “various third-party components”. Here’s the text: This product bundles various third-party components also unde

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc2)

Hey JB, I just sent a reply to the list with additional details. I don't think that this release applies license policy correctly even in the other files, so my vote is still -1. On Tue, Jan 14, 2025 at 11:05 AM Jean-Baptiste Onofré wrote: > Hi Ryan > > As you can see in my previous email, I tot

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc2)

Hi Ryan As you can see in my previous email, I totally agree with you about the issues on the LICENSE_BINARY_DIST. As this release only includes source distribution (no jar files, no binary packages), and I checked LICENSE/NOTICE for this distribution (see my vote email for details), I think we ar

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc2)

+1 (non-binding). The source distro looks good to me. There is a lot of work to do before we're ready for the binary distribution, but I don't think that should block this first source distro. Mike On Tue, Jan 14, 2025 at 1:19 AM Jean-Baptiste Onofré wrote: > +1 (binding) > > As this release in

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc2)

+1 (binding) As this release includes only source distribution, it's fine because: - hash and signature are OK - incubating is in the name/version - DISCLAIMER_WIP is there - LICENSE is OK, including note about Apache licensed third-party components (e.g. gradle). We can optionally mention Polaris

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc2)

Hi Ryan Thanks for the review. Here's my comment: 1. The "blanket" is not a blanket: it's just the note about gradle. 2. For DropWizard LICENSE is unmodified LICENSE file (https://www.apache.org/licenses/LICENSE-2.0) without change, so no need to copy into the LICENSE file 3. DropWizard NOTICE is

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc2)

I’m still -1 on this release due to licensing concerns. The LICENSE file includes a blanket statement that there are third-party components that are licensed under the Apache Software License 2.0, but doesn’t list what they are. I think this needs to be specific. The NOTICE file has a copyright n

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc2)

Hi Dmitri That's right: https://github.com/apache/polaris/issues/648 I will open a PR soon. Regards JB On Sat, Jan 11, 2025 at 12:44 AM Dmitri Bourlatchkov wrote: > > +1 (nb) > > Verified signature, checksum. > > JB: I believe you mentioned in the community sync call that you were going > to s

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc2)

+1(non-binding) Verified signature, checksum. Build passed. Yufei On Fri, Jan 10, 2025 at 3:45 PM Dmitri Bourlatchkov wrote: > +1 (nb) > > Verified signature, checksum. > > JB: I believe you mentioned in the community sync call that you were going > to share some info on how releases are supp

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc2)

+1 (nb) Verified signature, checksum. JB: I believe you mentioned in the community sync call that you were going to share some info on how releases are supposed to be verified :) Cheers, Dmitri. On Wed, Jan 8, 2025 at 11:01 AM Jean-Baptiste Onofré wrote: > Hi folks, > > As mentioned in anothe

Re: [VOTE] Release Apache Polaris 0.9.0-incubating (rc2)

+1 (nb) Verified signatures, checksums, licenses. Checked that no binary files were present. Building the sources with Gradle works. Alex On Wed, Jan 8, 2025 at 5:01 PM Jean-Baptiste Onofré wrote: > > Hi folks, > > As mentioned in another thread, I submit Apache Polaris > 0.9.0-incubating rc2 t

[VOTE] Release Apache Polaris 0.9.0-incubating (rc2)

Hi folks, As mentioned in another thread, I submit Apache Polaris 0.9.0-incubating rc2 to your vote. * This corresponds to the tag: apache-polaris-0.9.0-incubating-rc2 * https://github.com/apache/polaris/commits/apache-polaris-0.9.0-incubating-rc2 * https://github.com/apache/polaris/tree/8289d4e

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Hi folks, With the new year comes 0.9.0 rc2 :) I'm preparing the release, it will be on vote today. Stay tuned ! Regards JB On Sat, Dec 28, 2024 at 7:22 AM Jean-Baptiste Onofré wrote: > > Hi > > Thanks Alex, I tested and merged it (FYI, as said, I was about to > submit the PR). > > I will resu

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Hi Thanks Alex, I tested and merged it (FYI, as said, I was about to submit the PR). I will resume rc2 preparation. Regards JB On Fri, Dec 27, 2024 at 5:38 PM Alex Dutra wrote: > > Hi all, > > FYI I opened a PR with a fix for #542: > > https://github.com/apache/polaris/pull/593 > > Thanks, > >

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Hi all, FYI I opened a PR with a fix for #542: https://github.com/apache/polaris/pull/593 Thanks, Alex On Fri, Dec 20, 2024 at 6:09 AM Jean-Baptiste Onofré wrote: > Hi Yufei > > Yes there is still one issue I’m working on (about the binary > distribution). > > We discussed rc2 with some comm

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Hi Yufei Yes there is still one issue I’m working on (about the binary distribution). We discussed rc2 with some community members. We can do just a release with source distribution now but including binary distribution would not be a good idea as it doesn’t work fine. So what I proposed: I’m fi

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Hi JB, Thanks for working on the licence fix(PR 495). Let's know if there are other blockers. I'm OK with releasing source distribution for 0.9.0. Yufei On Sun, Dec 15, 2024 at 10:40 PM Jean-Baptiste Onofré wrote: > Hi folks, > > I plan to merge https://github.com/apache/polaris/pull/495 toda

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Hi folks, I plan to merge https://github.com/apache/polaris/pull/495 today. As we found several issues in the binary distribution: - https://github.com/apache/polaris/issues/542 (https://github.com/apache/polaris/issues/561) - and generally speaking https://github.com/apache/polaris/issues?q=is%3

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Hi guys I’m now back from travel. I’m resuming work on Polaris especially the rc2 preparation. The goal is to submit rc2 to vote this week. Regards JB Le mar. 3 déc. 2024 à 16:31, Jean-Baptiste Onofré a écrit : > Hi Yufei > > I have a couple of PRs that have to be merged before cutting the rc

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Hi Yufei I have a couple of PRs that have to be merged before cutting the rc2. Especially this one: https://github.com/apache/polaris/pull/495 I already fixed the NOTICE file and the LICENSE for source distribution, LICENSE.bin is for binary distribution. Regards JB On Mon, Dec 2, 2024 at 5:45

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Hi JB, Do we have a new RC to vote? Yufei On Thu, Nov 21, 2024 at 10:21 PM Jean-Baptiste Onofré wrote: > Hi Ryan > > 1. For the LICENSE file, I agree with you: the LICENSE should only > contain 3rd party *code* included in the *source* > release (dependencies don't matter here). > 2. For the

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Hi Ryan 1. For the LICENSE file, I agree with you: the LICENSE should only contain 3rd party *code* included in the *source* release (dependencies don't matter here). 2. For the NOTICE file, I don't think it should be so "simple" for two reasons: 2.1 According to the section 4.d of the ALv2, the N

Re: [CANCEL][VOTE] Release Apache Polaris 0.9.0-incubating

Hi, I did a new pass on NOTICE and LICENSE file. For context and reminder: 1. NOTICE file should be minimal, and not list license information, so it's not correct in RC1. The NOTICE file should also contain NOTICE files from ALv2 software used by Polaris. 2. LICENSE file is also not correct in RC

[CANCEL][VOTE] Release Apache Polaris 0.9.0-incubating

I cancel this vote to fix the different issues identified in RC1. Regards JB On Sun, Nov 17, 2024 at 7:00 AM Jean-Baptiste Onofré wrote: > > Hi everyone, > > I propose that we release the following RC as the official Apache > Polaris 0.9.0-incubating release. > > * This corresponds to the tag: a

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

I agree for NOTICE. The problem is that the gradle part generating LICENSE scan the transitive (jersey-json coming from dropwizard), whereas it should not, especially for source distribution. I made changes a while ago but it has not been included (it was when landed at ASF, it has been probably

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

-1 (binding) I don't think that the license documentation is sufficient. It looks like the LICENSE file for the source tarball was auto-generated from dependencies and doesn't document the difference between dependencies and sources that are included. There is at least one library, jersey-json, th

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Good call Dmitri. I agree with this plan. Is everyone happy with that ? Regards JB On Thu, Nov 21, 2024 at 12:46 AM Dmitri Bourlatchkov wrote: > > I believe the 0.9.0 release was meant to be a trial release to test the > process. With that in mind, in-memory polaris still works fine in 0.9.0.

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

I've just noticed that RC1 includes https://github.com/apache/polaris/pull/438, which, I think, makes bootstrapping on EclispeLink effectively impossible, because there's no user-level way to discover the generated root secret. >From my personal point of view it is not a release blocker, so I'm ke

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

I believe the 0.9.0 release was meant to be a trial release to test the process. With that in mind, in-memory polaris still works fine in 0.9.0. I suppose we can finish the release and fix issues on main for 0.9.1. This way we get to test how smoothly patch releases work too. ... just my 2 cents :

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Just to be clear, my preference would be to revert #438 on 0.9 branch. Regards JB On Wed, Nov 20, 2024 at 10:51 PM Jean-Baptiste Onofré wrote: > > Hi Dmitri > > Good catch. > > I think it's severe enough to cancel rc1 and prepare a new one > including eclipselink fix. > > Thoughts ? > > Regards

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Hi Dmitri Good catch. I think it's severe enough to cancel rc1 and prepare a new one including eclipselink fix. Thoughts ? Regards JB On Wed, Nov 20, 2024 at 9:21 PM Dmitri Bourlatchkov wrote: > > I've just noticed that RC1 includes > https://github.com/apache/polaris/pull/438, which, I think

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Thanks for flagging this Dmitri. In fact I think this could be a release blocker as the EclipseLink workflow is quite fundamentally broken. I commented on #422 with some thoughts. If we decide this is a release blocker, I would suggest we consider a rev

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Yes, it was what I pointed out (several binary files in the source distribution). It's totally acceptable because it's for site/documentation, and it's not executable. Regards JB On Wed, Nov 20, 2024 at 12:23 PM Alex Dutra wrote: > > Hi all, > > +1 (nb), but with some caveats: I tested signatur

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Actually, reverting my vote to +1 (binding) NB - .keep and .typed are actually empty files (even if flagged as binary), so not a problem - I will fix all gradle related issue during release process and documentation (already working on fix about digest sourceTarball and Maven publication) Regards

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Hi all, +1 (nb), but with some caveats: I tested signatures, checksums, and ran tests and license checks. All OK. But I found some non-empty binary files: > find . -type f ! -size 0 | perl -lne 'print if -B' ./site/static/favicons/favicon.ico ./site/static/favicons/android-chrome-192x192.png ./s

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

NB: gradlew is not a binary file, but I think it would be great to address .keep and *.typed. Regards JB On Tue, Nov 19, 2024 at 7:04 AM Jean-Baptiste Onofré wrote: > > -1 (binding) > > I found that the source distribution includes binaries, especially > gradlew, .keep, *.typed, it has to exclud

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

+1 On Sat, Nov 16, 2024 at 10:00 PM Jean-Baptiste Onofré wrote: > Hi everyone, > > I propose that we release the following RC as the official Apache > Polaris 0.9.0-incubating release. > > * This corresponds to the tag: apache-polaris-0.9.0-incubating-rc1 > * > https://github.com/apache/polaris/

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

-1 (binding) I found that the source distribution includes binaries, especially gradlew, .keep, *.typed, it has to excluded from the source distribution I will cancel this vote to fix that in rc2. Regards JB On Sun, Nov 17, 2024 at 7:00 AM Jean-Baptiste Onofré wrote: > > Hi everyone, > > I pro

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

NB: rat is executed via gradle. The excludes are defined in the gradle configuration. You should use the same excludes if you run rat standalone. The files you are mentioning are actually part of the excludes. Regards JB Le lun. 18 nov. 2024 à 23:02, Kevin Liu a écrit : > +1 non-binding. > > Do

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

OK, in that case :) +1 I also built and ran all tests, checked checksums and worried about licensing issues On Mon, Nov 18, 2024 at 5:10 PM Kevin Liu wrote: > I don't think there's a license issue. Looks like there's already a RAT > check in the build steps. > > https://github.com/apache/polari

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

I don't think there's a license issue. Looks like there's already a RAT check in the build steps. https://github.com/apache/polaris/blob/e46c6cbb61e69dcb12775fa262c09437f8ee8a28/build.gradle.kts#L59-L124 And the files listed above are excluded. Best, Kevin Liu On Mon, Nov 18, 2024 at 3:03 PM Rus

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Shouldn't we fix the license issues before the release? Seems like an important and easy thing to do. I also think we should be excluding the "site" directory from the release? On Mon, Nov 18, 2024 at 4:56 PM Dmitri Bourlatchkov wrote: > +1 (non-binding) > > Validated sha512 and signature. > >

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

+1 (non-binding) Validated sha512 and signature. Cheers, Dmitri. On Mon, Nov 18, 2024 at 3:16 PM Jean-Baptiste Onofré wrote: > Hi Dmitri > > I updated dist with the correct sha512. > > I noticed several gradle issues during the release (in signature, > maven publication, etc). I will create th

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

+1 non-binding. Downloaded artifacts, verified signatures, checksums, and licenses (see below). Ran tests successfully. ``` curl https://dist.apache.org/repos/dist/release/incubator/polaris/KEYS -o KEYS gpg --import KEYS svn checkout https://dist.apache.org/repos/dist/dev/incubator/polaris/0.9.0

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Hi Dmitri I updated dist with the correct sha512. I noticed several gradle issues during the release (in signature, maven publication, etc). I will create the issues/PRs to fix that with the release process documentation. Regards JB On Mon, Nov 18, 2024 at 3:03 PM Dmitri Bourlatchkov wrote: >

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Hi Dmitri Yes, it's normal: the KEYS file contains the keys of the release manager. As I'm the first release manager, it contains my key. Release managers will add their key in the KEYS file. Regards JB On Mon, Nov 18, 2024 at 2:53 PM Dmitri Bourlatchkov wrote: > > Hi JB, > > I can see only you

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Hi That’s cause of the gradle plugin. I will update the file on dist. Le lun. 18 nov. 2024 à 15:03, Dmitri Bourlatchkov a écrit : > I noticed that the apache-polaris-0.9.0-incubating.sha512 file contains the > right hash, but it's format does not match the output of `sha512sum > apache-polaris

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

I noticed that the apache-polaris-0.9.0-incubating.sha512 file contains the right hash, but it's format does not match the output of `sha512sum apache-polaris-0.9.0-incubating.tar.gz` -- files names are not listed after hashes... As a result, sha512sum -c apache-polaris-0.9.0-incubating.sha512 ret

Re: [VOTE] Release Apache Polaris 0.9.0-incubating

Hi JB, I can see only your key (one) in the KEYS file... Is that normal? Thanks, Dmitri. On Sun, Nov 17, 2024 at 1:00 AM Jean-Baptiste Onofré wrote: > Hi everyone, > > I propose that we release the following RC as the official Apache > Polaris 0.9.0-incubating release. > > * This corresponds t

[VOTE] Release Apache Polaris 0.9.0-incubating

Hi everyone, I propose that we release the following RC as the official Apache Polaris 0.9.0-incubating release. * This corresponds to the tag: apache-polaris-0.9.0-incubating-rc1 * https://github.com/apache/polaris/commits/apache-polaris-0.9.0-incubating-rc1 * https://github.com/apache/polaris/