NB: rat is executed via gradle. The excludes are defined in the gradle configuration. You should use the same excludes if you run rat standalone. The files you are mentioning are actually part of the excludes.
Regards JB Le lun. 18 nov. 2024 à 23:02, Kevin Liu <kevin.jq....@gmail.com> a écrit : > +1 non-binding. > > Downloaded artifacts, verified signatures, checksums, and licenses (see > below). > Ran tests successfully. > > ``` > curl https://dist.apache.org/repos/dist/release/incubator/polaris/KEYS -o > KEYS > gpg --import KEYS > > svn checkout > https://dist.apache.org/repos/dist/dev/incubator/polaris/0.9.0-incubating/ > /tmp/polaris/ > <https://dist.apache.org/repos/dist/dev/incubator/polaris/0.9.0-incubating//tmp/polaris/> > cd /tmp/polaris/ > > for name in $(ls *.tar.gz) > do > gpg --verify ${name}.asc ${name} > done > > for name in $(ls *.tar.gz.sha512) > do > shasum -a 512 --check ${name} > done > > tar -xzvf apache-polaris-0.9.0-incubating.tar.gz > cd apache-polaris-0.9.0-incubating > > sdk use java 21.0.4-amzn > ./gradlew test > ``` > > I tried to run the RAT jar to verify the license, similar to the > instructions in > > https://py.iceberg.apache.org/verify-release/#verifying-license-documentation > and found some files without license headers. > > ``` > > mkdir dev > cp ~/repos/iceberg-python/dev/check-license dev/ > cp ~/repos/iceberg-python/dev/.rat-excludes dev/ > ./dev/check-license > > ➜ apache-polaris-0.9.0-incubating ./dev/check-license > Ignored 0 lines in your exclusion files as comments or empty lines. > Could not find Apache license headers in the following files: > !????? /tmp/polaris/apache-polaris-0.9.0-incubating/DISCLAIMER_WIP > !????? /tmp/polaris/apache-polaris-0.9.0-incubating/ide-name.txt > !????? /tmp/polaris/apache-polaris-0.9.0-incubating/version.txt > !????? > > /tmp/polaris/apache-polaris-0.9.0-incubating/getting-started/spark/notebooks/SparkPolaris.ipynb > !????? > > /tmp/polaris/apache-polaris-0.9.0-incubating/polaris-service/src/main/resources/org/apache/polaris/service/banner.txt > !????? > > /tmp/polaris/apache-polaris-0.9.0-incubating/regtests/client/python/polaris/catalog/py.typed > !????? > > /tmp/polaris/apache-polaris-0.9.0-incubating/regtests/client/python/polaris/management/py.typed > !????? > /tmp/polaris/apache-polaris-0.9.0-incubating/regtests/credentials/.keep > !????? > > /tmp/polaris/apache-polaris-0.9.0-incubating/regtests/t_hello_world/ref/hello_world.sh.ref > !????? > > /tmp/polaris/apache-polaris-0.9.0-incubating/regtests/t_spark_sql/ref/spark_sql_azure_blob.sh.ref > !????? > > /tmp/polaris/apache-polaris-0.9.0-incubating/regtests/t_spark_sql/ref/spark_sql_azure_dfs.sh.ref > !????? > > /tmp/polaris/apache-polaris-0.9.0-incubating/regtests/t_spark_sql/ref/spark_sql_basic.sh.ref > !????? > > /tmp/polaris/apache-polaris-0.9.0-incubating/regtests/t_spark_sql/ref/spark_sql_gcp.sh.ref > !????? > > /tmp/polaris/apache-polaris-0.9.0-incubating/regtests/t_spark_sql/ref/spark_sql_s3.sh.ref > !????? > > /tmp/polaris/apache-polaris-0.9.0-incubating/regtests/t_spark_sql/ref/spark_sql_s3_cross_region.sh.ref > !????? > > /tmp/polaris/apache-polaris-0.9.0-incubating/regtests/t_spark_sql/ref/spark_sql_views.sh.ref > !????? /tmp/polaris/apache-polaris-0.9.0-incubating/site/go.sum > !????? > /tmp/polaris/apache-polaris-0.9.0-incubating/site/layouts/robots.txt > !????? > > /tmp/polaris/apache-polaris-0.9.0-incubating/site/static/favicons/favicon.svg > !????? > > /tmp/polaris/apache-polaris-0.9.0-incubating/site/static/img/apache-incubator.svg > !????? > > /tmp/polaris/apache-polaris-0.9.0-incubating/site/static/img/example-workflow.svg > !????? > /tmp/polaris/apache-polaris-0.9.0-incubating/site/static/img/overview.svg > !????? > > /tmp/polaris/apache-polaris-0.9.0-incubating/site/static/img/rbac-example.svg > !????? > /tmp/polaris/apache-polaris-0.9.0-incubating/site/static/img/rbac-model.svg > !????? > > /tmp/polaris/apache-polaris-0.9.0-incubating/site/static/img/sample-catalog-structure.svg > !????? > > /tmp/polaris/apache-polaris-0.9.0-incubating/site/static/img/logos/polaris-catalog-stacked-logo.svg > ``` > > Best, > Kevin Liu > > > > > On Mon, Nov 18, 2024 at 12:15 PM Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: > > > Hi Dmitri > > > > I updated dist with the correct sha512. > > > > I noticed several gradle issues during the release (in signature, > > maven publication, etc). I will create the issues/PRs to fix that with > > the release process documentation. > > > > Regards > > JB > > > > On Mon, Nov 18, 2024 at 3:03 PM Dmitri Bourlatchkov > > <dmitri.bourlatch...@dremio.com.invalid> wrote: > > > > > > I noticed that the apache-polaris-0.9.0-incubating.sha512 file contains > > the > > > right hash, but it's format does not match the output of `sha512sum > > > apache-polaris-0.9.0-incubating.tar.gz` -- files names are not listed > > after > > > hashes... > > > > > > As a result, sha512sum -c apache-polaris-0.9.0-incubating.sha512 > returns > > a > > > formal error. > > > > > > Are we ok with that? > > > > > > For reference, the httpd hashes do list file names: > > > https://downloads.apache.org/httpd/httpd-2.4.62.tar.bz2.sha512 > > > > > > Cheers, > > > Dmitri. > > > > > > On Sun, Nov 17, 2024 at 1:00 AM Jean-Baptiste Onofré <j...@nanthrax.net> > > > wrote: > > > > > > > Hi everyone, > > > > > > > > I propose that we release the following RC as the official Apache > > > > Polaris 0.9.0-incubating release. > > > > > > > > * This corresponds to the tag: apache-polaris-0.9.0-incubating-rc1 > > > > * > > > > > > > https://github.com/apache/polaris/commits/apache-polaris-0.9.0-incubating-rc1 > > > > * > > > > > > > https://github.com/apache/polaris/tree/445c42768d1e3148c912ac5c45ee53036b9ef318 > > > > > > > > The release tarball, signature, and checksums are here: > > > > * > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/polaris/0.9.0-incubating/ > > > > > > > > You can find the KEYS file here: > > > > * https://dist.apache.org/repos/dist/release/incubator/polaris/KEYS > > > > > > > > Convenience binary artifacts are staged on Nexus. The Maven > repository > > URL > > > > is: > > > > * > > > > > > > https://repository.apache.org/content/repositories/orgapachepolaris-1003/ > > > > > > > > Please download, verify, and test. > > > > > > > > Please vote in the next 72 hours. > > > > [ ] +1 Release this as Apache polaris 0.9.0-incubating > > > > [ ] +0 > > > > [ ] -1 Do not release this because... > > > > > > > > Only PPMC members and mentors have binding votes, but other community > > > > members are > > > > encouraged to cast non-binding votes. This vote will pass if there > are > > > > 3 binding +1 votes and more binding +1 votes than -1 votes. > > > > > > > > NB: if this vote passes, a new vote will be started on the Incubator > > > > general mailing > > > > list. > > > > > > > > Thanks > > > > Regards > > > > JB > > > > > > >
