[PR] Unnecessary Object creation when logging InternalSheet.java [poi]

2024-02-16 Thread via GitHub
rh-id opened a new pull request, #590: URL: https://github.com/apache/poi/pull/590 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-

Re: [PR] Unnecessary Object creation when logging InternalSheet.java [poi]

2024-02-16 Thread via GitHub
pjfanning commented on code in PR #590: URL: https://github.com/apache/poi/pull/590#discussion_r1492210329 ## poi/src/main/java/org/apache/poi/hssf/model/InternalSheet.java: ## @@ -541,12 +540,11 @@ public ConditionalFormattingTable getConditionalFormattingTable() { public

Re: [PR] Unnecessary Object creation when logging InternalSheet.java [poi]

2024-02-16 Thread via GitHub
xzel23 commented on code in PR #590: URL: https://github.com/apache/poi/pull/590#discussion_r1492235388 ## poi/src/main/java/org/apache/poi/hssf/model/InternalSheet.java: ## @@ -541,12 +540,11 @@ public ConditionalFormattingTable getConditionalFormattingTable() { public vo

Re: [PR] Unnecessary Object creation when logging InternalSheet.java [poi]

2024-02-16 Thread via GitHub
pjfanning commented on code in PR #590: URL: https://github.com/apache/poi/pull/590#discussion_r1492258847 ## poi/src/main/java/org/apache/poi/hssf/model/InternalSheet.java: ## @@ -541,12 +540,11 @@ public ConditionalFormattingTable getConditionalFormattingTable() { public

Re: [PR] Unnecessary Object creation when logging InternalSheet.java [poi]

2024-02-16 Thread via GitHub
rh-id commented on PR #590: URL: https://github.com/apache/poi/pull/590#issuecomment-1948257293 Hi @pjfanning @xzel23 , Thanks for the review, I had updated the commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Unnecessary Object creation when logging InternalSheet.java [poi]

2024-02-16 Thread via GitHub
xzel23 commented on PR #590: URL: https://github.com/apache/poi/pull/590#issuecomment-1948269233 @pjfanning Looks good to me. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[Bug 68635] New: POI unit tests fail when run under non-US locale

2024-02-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68635 Bug ID: 68635 Summary: POI unit tests fail when run under non-US locale Product: POI Version: unspecified Hardware: PC OS: All Status: NEW Severity: min

[PR] Bump net.bytebuddy:byte-buddy-agent from 1.14.9 to 1.14.12 [poi]

2024-02-16 Thread via GitHub
dependabot[bot] opened a new pull request, #592: URL: https://github.com/apache/poi/pull/592 Bumps [net.bytebuddy:byte-buddy-agent](https://github.com/raphw/byte-buddy) from 1.14.9 to 1.14.12. Release notes Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy:b

[PR] Bump net.bytebuddy:byte-buddy from 1.14.9 to 1.14.12 [poi]

2024-02-16 Thread via GitHub
dependabot[bot] opened a new pull request, #591: URL: https://github.com/apache/poi/pull/591 Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from 1.14.9 to 1.14.12. Release notes Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy:byte-bu

Re: [PR] Bump net.bytebuddy:byte-buddy from 1.14.9 to 1.14.12 [poi]

2024-02-16 Thread via GitHub
asfgit closed pull request #591: Bump net.bytebuddy:byte-buddy from 1.14.9 to 1.14.12 URL: https://github.com/apache/poi/pull/591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Bump net.bytebuddy:byte-buddy-agent from 1.14.9 to 1.14.12 [poi]

2024-02-16 Thread via GitHub
asfgit closed pull request #592: Bump net.bytebuddy:byte-buddy-agent from 1.14.9 to 1.14.12 URL: https://github.com/apache/poi/pull/592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Bump net.bytebuddy:byte-buddy-agent from 1.14.9 to 1.14.12 [poi]

2024-02-16 Thread via GitHub
dependabot[bot] commented on PR #592: URL: https://github.com/apache/poi/pull/592#issuecomment-1948549194 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me kn

Re: [PR] Bump net.bytebuddy:byte-buddy from 1.14.9 to 1.14.12 [poi]

2024-02-16 Thread via GitHub
dependabot[bot] commented on PR #591: URL: https://github.com/apache/poi/pull/591#issuecomment-1948549176 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me kn

Re: [PR] Unnecessary Object creation when logging InternalSheet.java [poi]

2024-02-16 Thread via GitHub
asfgit closed pull request #590: Unnecessary Object creation when logging InternalSheet.java URL: https://github.com/apache/poi/pull/590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Unnecessary Object creation when logging InternalSheet.java [poi]

2024-02-16 Thread via GitHub
pjfanning commented on PR #590: URL: https://github.com/apache/poi/pull/590#issuecomment-1948573311 Thanks @rh-id, @xzel23 - merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Remove unnecessary LOGGER in POIFSDocumentPath.java [poi]

2024-02-16 Thread via GitHub
asfgit closed pull request #588: Remove unnecessary LOGGER in POIFSDocumentPath.java URL: https://github.com/apache/poi/pull/588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Remove unnecessary LOGGER in XSSFBRelation.java [poi]

2024-02-16 Thread via GitHub
asfgit closed pull request #589: Remove unnecessary LOGGER in XSSFBRelation.java URL: https://github.com/apache/poi/pull/589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.