pjfanning commented on code in PR #590:
URL: https://github.com/apache/poi/pull/590#discussion_r1492210329
##########
poi/src/main/java/org/apache/poi/hssf/model/InternalSheet.java:
##########
@@ -541,12 +540,11 @@ public ConditionalFormattingTable
getConditionalFormattingTable() {
public void setDimensions(int firstrow, short firstcol, int lastrow, short
lastcol)
{
LOGGER.atDebug().log("Sheet.setDimensions");
- LOGGER.atDebug().log(() -> new SimpleMessage(
Review Comment:
-1 from me. This lambda function only runs when debug is enabled. Debug is
not normally enabled.
With your change the expensive String concat will always run, regardless of
whether the text needs to be output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
