https://bz.apache.org/bugzilla/show_bug.cgi?id=69714
--- Comment #10 from PJ Fanning ---
I have merged the PR and have tidied up the ThreadLocal to call remove when
nulls are in play.
--
You are receiving this mail because:
You are the assignee for the bug.
-
https://bz.apache.org/bugzilla/show_bug.cgi?id=69714
--- Comment #9 from Attila Kelemen ---
Some notes on your current implementation:
- I cannot restore the strategy of my caller. The simplest change you can do to
allow this is to return the previous strategy in
`setThreadLocalTempFileCreationS
https://bz.apache.org/bugzilla/show_bug.cgi?id=69714
--- Comment #8 from Attila Kelemen ---
My issue with your implementation is that I cannot restore the previous
implementation to avoid changing the strategy to the caller (and also cannot
cleanup garbage manually).
In the mean time I also wrot
https://bz.apache.org/bugzilla/show_bug.cgi?id=69714
--- Comment #7 from PJ Fanning ---
I added some changes to TempFile to allow a thread specific strategy.
https://github.com/apache/poi/commit/9c08d29fcbd0f3f4fec5f27349246bf6a84fe78a
and
https://github.com/apache/poi/commit/66055698623ce2b7ca5e
https://bz.apache.org/bugzilla/show_bug.cgi?id=69714
--- Comment #6 from PJ Fanning ---
Ok. If the change can be kept to your approx 30 lines, I will review it.
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/bugzilla/show_bug.cgi?id=69714
--- Comment #5 from Attila Kelemen ---
In fact, I just checked, it is literally just 30 lines of extra code (pretty
much trivial) containing one extra public method, with 2 modified lines
(replacing `strategy` with `getStrategy()` within `TempF
https://bz.apache.org/bugzilla/show_bug.cgi?id=69714
--- Comment #4 from Attila Kelemen ---
I don't really see how my "middle ground" proposal is a drastic change. It
would just declare a thread local, and if the thread local value is set, then
would use that strategy. That would basically only i
https://bz.apache.org/bugzilla/show_bug.cgi?id=69714
--- Comment #3 from PJ Fanning ---
I am against big new temp file API changes.
You can plug in your own strategy using
https://poi.apache.org/apidocs/dev/org/apache/poi/util/TempFile.html#setTempFileCreationStrategy-org.apache.poi.util.TempFile
https://bz.apache.org/bugzilla/show_bug.cgi?id=69714
--- Comment #2 from Attila Kelemen ---
I think POI's mistaken assumption here is that what uses tmp files and what
doesn't is an implementation detail, but tmp file usage has very important
implications (mainly security and quota) to be just tr
https://bz.apache.org/bugzilla/show_bug.cgi?id=69714
PJ Fanning changed:
What|Removed |Added
OS||All
--- Comment #1 from PJ Fanning ---
I
10 matches
Mail list logo
