https://bz.apache.org/bugzilla/show_bug.cgi?id=69714
--- Comment #8 from Attila Kelemen <attila.keleme...@gmail.com> --- My issue with your implementation is that I cannot restore the previous implementation to avoid changing the strategy to the caller (and also cannot cleanup garbage manually). In the mean time I also wrote my own implementation: https://github.com/apache/poi/pull/825/commits/0d636901adf11cc0cfee8ed9dcdee004cfd11600 The benefit of my implementation are: - Cannot be misused (i.e., cannot forget to restore the strategy). - Doesn't require a cleaner. - Doesn't leave unset garbage after a `ThreadLocal.get` returning null. I only noticed your implementation after I implemented mine. So, I didn't yet rebased mine on top of trunk. If you want to use mine, then you can copy-paste my solution, or just ask me to rebase my changes (whichever is more convenient for you). -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
