Stephen,
Anyhow, changing ordering at this will actually introduce more work.
Sincerely yours,
Ivan Zlenko.
On Mon, 10 Feb 2025 at 17:47, Stephen O'Donnell
wrote:
> Ivan,
>
> Facts beat hand wavy assertions. You are of course wrong, there is a
> pattern in the code, but I was also wrong. The c
Ivan,
Facts beat hand wavy assertions. You are of course wrong, there is a
pattern in the code, but I was also wrong. The code has many more files
with static imports first. I asked some AI to create me a script to check,
and it gave me:
import os
import re
def find_java_files_with_static_impor
Stephen,
Look, it was my first line of thought to come up with a general pattern for
a checkstyle, so it will be easier to change and review.
But after going through the whole Ozone code base and creating 33 branches
with fixes I can safely say - there is no pattern.
Sincerely yours,
Ivan Zlenko.
>From my observation it is 50/50 for Ozone codebase in terms of
static/non-static imports ordering.
I happened to have 9 random files open in Intellij, and checked them. All
had static imports last, and based on my experience on the project over the
last 5 years, statics are almost always last. Po
Sammi,
>From my observation it is 50/50 for Ozone codebase in terms of
static/non-static imports ordering.
As I've said before I've already finished with Ozone checkstyle for all
modules and now waiting on the first to be merged so I can create all
follow up pull requests.
Sincerely yours,
Ivan Z
Ivan,
Thank you for the explanation. I adjusted the intellij configuration
accordingly.
There is one observation. I'm using "IntelliJ IDEA 2022.1.3" which seems
by default to put static imports after normal imports, which is the
opposite order of the new proposal.
If we use the new order, then
Hi, Sammi.
> BTW, I 'm not sure if Intellij has any way to help enforce these rules
so it would be easy to follow them.
It will be straightforward to set up these rules in IntelliJ Idea. Right
now I have changes for all modules in Ozone to make them compliant to the
new checkstyle and all change
Thanks Attila and Ivan working on this improvement.
IIUC, the major enforced rules of imports are
> value="true"/>
>
> value="STATIC###THIRD_PARTY_PACKAGE"/>
>
>
"sortImportsInGroupAlphabetically" and "separateLineBetweenGroups" look
stra
+1.
Thanks @Ivan and @Attila working on this.
On Mon, Feb 10, 2025 at 2:32 PM Attila Doroszlai
wrote:
> Hi Ozone developers,
>
> Ivan Zlenko has started working on standardizing license header and
> the order of imports.
>
> The first PR [1] adds the sample header [2], as well as checkstyle
> r
Hi Ozone developers,
Ivan Zlenko has started working on standardizing license header and
the order of imports.
The first PR [1] adds the sample header [2], as well as checkstyle
rules for these two items. Rules will be initially disabled in all
submodules. The plan is to update submodules gradu
10 matches
Mail list logo
