Thanks Attila and Ivan working on this improvement. IIUC, the major enforced rules of imports are
<module name="CustomImportOrder"> > <property name="sortImportsInGroupAlphabetically" > value="true"/> > <property name="separateLineBetweenGroups" value="true"/> > <property name="customImportOrderRules" > value="STATIC###THIRD_PARTY_PACKAGE"/> > <property name="tokens" value="IMPORT, STATIC_IMPORT, > PACKAGE_DEF"/> > </module> "sortImportsInGroupAlphabetically" and "separateLineBetweenGroups" look straightforward. "customImportOrderRules" and "tokens", can we have a little explanation of the rule here? BTW, I 'm not sure if Intellij has any way to help enforce these rules so it would be easy to follow them. Bests, Sammi On Mon, 10 Feb 2025 at 17:02, Attila Doroszlai <adorosz...@apache.org> wrote: > Hi Ozone developers, > > Ivan Zlenko has started working on standardizing license header and > the order of imports. > > The first PR [1] adds the sample header [2], as well as checkstyle > rules for these two items. Rules will be initially disabled in all > submodules. The plan is to update submodules gradually, one at a > time, fixing existing files and enabling the rules. > > For new files please start using the standard header [2] and import > order (shown in the PR description), even if the rule is still > disabled in the specific module. This will help avoid accidental > violations if PRs are merged concurrently. > > We will help resolve conflicts in open PRs. Please avoid merging PRs > with old CI results. > > thanks, > Attila > > [1] https://github.com/apache/ozone/pull/7836 > [2] > https://github.com/apache/ozone/blob/966145d5e869263d53c516d36a0c02e058fd24b9/hadoop-hdds/dev-support/checkstyle/license.header > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org > For additional commands, e-mail: dev-h...@ozone.apache.org > >
