Re: [VOTE] - Merge HDDS-4440-s3-performance feature branch into master

2022-04-27 Thread Neil Joshi
Thanks everyone, the feature branch merge vote for merging HDDS-4440-s3-performance into the master is complete with vote to merge. In total we have 4 +1 PMC votes and 8 +1 votes in total, (Neil, Michel, Jackson, Mingchao, Bharat, Uma, Sid, Attila) and no 0 or -1 votes. Following this merge, we

Re: [VOTE] - Merge HDDS-4440-s3-performance feature branch into master

2022-04-25 Thread Siddharth Wagle
+1 for the merge. Thanks, Neil for working on this perf improvement feature for Ozone. Best, Sid On Mon, Apr 25, 2022 at 9:00 AM Uma Maheswara Rao Gangumalla < umaganguma...@gmail.com> wrote: > Oh, Looks like Attila covered those comments already. > > Post addressing those. +1 for the branch me

Re: [VOTE] - Merge HDDS-4440-s3-performance feature branch into master

2022-04-25 Thread Uma Maheswara Rao Gangumalla
Oh, Looks like Attila covered those comments already. Post addressing those. +1 for the branch merge. Thanks for all the work here. Regards, Uma On Mon, Apr 25, 2022 at 8:58 AM Uma Maheswara Rao Gangumalla < umaganguma...@gmail.com> wrote: > Hi Neil, > > When I checked the above PR, I noticed

Re: [VOTE] - Merge HDDS-4440-s3-performance feature branch into master

2022-04-25 Thread Uma Maheswara Rao Gangumalla
Hi Neil, When I checked the above PR, I noticed a few checkstyle commits at the end. I am assuming you might know that we can't squash commits for branches as we lose the history of commits. So, those fixes should go as small JIRAs into your branch. Just use the git merge command to merge it to m

Re: [VOTE] - Merge HDDS-4440-s3-performance feature branch into master

2022-04-25 Thread Attila Doroszlai
+1 for the branch merge. There is one item left in the PR (TestOzoneConfigurationFields applied to S3 config). Neil, can you please open a Jira issue for each of the items addressed in the draft PR (excluding merges from master) since it was opened? Those changes would need to be brought into the

Re: [VOTE] - Merge HDDS-4440-s3-performance feature branch into master

2022-04-13 Thread Attila Doroszlai
Thanks to everyone who contributed to this feature. Neil created a draft PR where the code change for this feature branch can be reviewed: https://github.com/apache/ozone/pull/3297 I posted some questions/comments there. > *The vote will run for 7 days, ending on Apr 12 at 8:00 PT.* I'd like to

Re: [VOTE] - Merge HDDS-4440-s3-performance feature branch into master

2022-04-07 Thread Bharat Viswanadham
+1 (binding) Thanks, Bharat On Thu, Apr 7, 2022 at 11:23 AM mingchao zhao wrote: > +1 for merging. Thanks for the work. > > jackson yao 于2022年4月7日周四 17:21写道: > > > thanks for the work! i am +1 for merging(non-binding) > > > > > > > > Michel Sumbul 于2022年4月5日周二 15:25写道: > > > > > +1 (non-bind

Re: [VOTE] - Merge HDDS-4440-s3-performance feature branch into master

2022-04-07 Thread mingchao zhao
+1 for merging. Thanks for the work. jackson yao 于2022年4月7日周四 17:21写道: > thanks for the work! i am +1 for merging(non-binding) > > > > Michel Sumbul 于2022年4月5日周二 15:25写道: > > > +1 (non-binding) > > > > Thanks for the guys! > > > > Le mar. 5 avr. 2022 à 04:49, Neil Joshi a écrit : > > > > > Hi

Re: [VOTE] - Merge HDDS-4440-s3-performance feature branch into master

2022-04-07 Thread jackson yao
thanks for the work! i am +1 for merging(non-binding) Michel Sumbul 于2022年4月5日周二 15:25写道: > +1 (non-binding) > > Thanks for the guys! > > Le mar. 5 avr. 2022 à 04:49, Neil Joshi a écrit : > > > Hi All, > > > > I would like to propose merging the S3g Grpc Persistent Connection > Feature > > br

Re: [VOTE] - Merge HDDS-4440-s3-performance feature branch into master

2022-04-05 Thread Michel Sumbul
+1 (non-binding) Thanks for the guys! Le mar. 5 avr. 2022 à 04:49, Neil Joshi a écrit : > Hi All, > > I would like to propose merging the S3g Grpc Persistent Connection Feature > branch, HDDS-4440-s3-performance, into the Ozone master. This feature > branch brings servicing s3 transactions thr

[VOTE] - Merge HDDS-4440-s3-performance feature branch into master

2022-04-04 Thread Neil Joshi
Hi All, I would like to propose merging the S3g Grpc Persistent Connection Feature branch, HDDS-4440-s3-performance, into the Ozone master. This feature branch brings servicing s3 transactions through the S3 gateway, s3g, over Grpc to the Ozone Manager, om. In a production ready configuration wi