Oh, Looks like Attila covered those comments already. Post addressing those. +1 for the branch merge.
Thanks for all the work here. Regards, Uma On Mon, Apr 25, 2022 at 8:58 AM Uma Maheswara Rao Gangumalla < umaganguma...@gmail.com> wrote: > Hi Neil, > > When I checked the above PR, I noticed a few checkstyle commits at the > end. I am assuming you might know that we can't squash commits for > branches as we lose the history of commits. So, those fixes should go as > small JIRAs into your branch. > > Just use the git merge command to merge it to master. > > Regards, > Uma > > > On Wed, Apr 13, 2022 at 6:38 AM Attila Doroszlai <adorosz...@apache.org> > wrote: > >> Thanks to everyone who contributed to this feature. >> >> Neil created a draft PR where the code change for this feature branch >> can be reviewed: https://github.com/apache/ozone/pull/3297 >> I posted some questions/comments there. >> >> > *The vote will run for 7 days, ending on Apr 12 at 8:00 PT.* >> >> I'd like to extend the voting period by a week due to the upcoming >> holidays. >> >> -Attila >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org >> For additional commands, e-mail: dev-h...@ozone.apache.org >> >>
