Re: [DISCUSS] - Merge Non rolling upgrade branch - 'HDDS-3698-nonrolling-upgrade'

2021-04-22 Thread Rakesh Radhakrishnan
+1 for the merge. Thank you Aravindan for driving this. Sure, we will work together to handle HDDS-2939, integration task. Regards, Rakesh On Mon, Apr 19, 2021 at 10:34 PM Aravindan Vijayan wrote: > Hello all, > > I would like to propose merging the work done for supporting non rolling > upgra

Re: [DISCUSS] - Merge Non rolling upgrade branch - 'HDDS-3698-nonrolling-upgrade'

2021-04-22 Thread Aravindan Vijayan
Thanks for the review Yiqun. The question that you ask is valid. As of now, the OM-SCM compatibility story is still in the works. We are planning to work on it shortly after the branch merge, and should be able to get in for 1.2.0. On Thu, Apr 22, 2021 at 8:44 AM Lin, Yiqun wrote: > +1. > > Tha

Re: [DISCUSS] - Merge Non rolling upgrade branch - 'HDDS-3698-nonrolling-upgrade'

2021-04-22 Thread Aravindan Vijayan
Thank you for reviewing this Marton! The --upgrade flag is needed for the OM since it needs to be brought out of "prepared" state after an upgrade. Right now, there is no need to prepare an SCM, and hence support has not been added for that. Hence, there is no --upgrade flag while starting SCM.

Re: [DISCUSS] - Merge Non rolling upgrade branch - 'HDDS-3698-nonrolling-upgrade'

2021-04-22 Thread Lin, Yiqun
+1. Thanks for the great work on this feature! I have one question for OM - SCM Version compatibility upgrade. Quote from the design doc: >We should not allow a deployment where a finalized version of Ozone manager is >talking to a previous (or pre-finalized) version of SCM. Can I understand

Re: [DISCUSS] - Merge Non rolling upgrade branch - 'HDDS-3698-nonrolling-upgrade'

2021-04-22 Thread Elek, Marton
+1 thanks the work to al the contributors. I am very excited to have this feature as it is required by EC (and some other related task). I am looking forward to try it out. I didn't have time to check the code deeply, but what I have seen earlier about the annotation based approach, is very

Re: [DISCUSS] - Merge Non rolling upgrade branch - 'HDDS-3698-nonrolling-upgrade'

2021-04-21 Thread Vivek Ratnavel
+1 to merge HDDS-3698-nonrolling-upgrade branch into Ozone master. Thanks to everyone who contributed. -Vivek Subramanian On Mon, Apr 19, 2021 at 10:50 AM Siddharth Wagle wrote: > +1 for Upgrade branch merge. > Thank you Aravindan, Ethan, Prashant, and Pifta for actively working on > this impo

Re: [DISCUSS] - Merge Non rolling upgrade branch - 'HDDS-3698-nonrolling-upgrade'

2021-04-19 Thread Siddharth Wagle
+1 for Upgrade branch merge. Thank you Aravindan, Ethan, Prashant, and Pifta for actively working on this important feature for Ozone, and everyone else who contributed with ideas and suggestions. Best, Sid On Mon, Apr 19, 2021 at 10:04 AM Aravindan Vijayan wrote: > Hello all, > > I would like

[DISCUSS] - Merge Non rolling upgrade branch - 'HDDS-3698-nonrolling-upgrade'

2021-04-19 Thread Aravindan Vijayan
Hello all, I would like to propose merging the work done for supporting non rolling upgrades in Ozone (HDDS-3698-nonrolling-upgrade) into the Ozone master branch. As part of the upgrade framework, the following have been added - Ability to create layout features & versions - Ability to fin