+1.
Thanks for the great work on this feature!
I have one question for OM - SCM Version compatibility upgrade.
Quote from the design doc:
>We should not allow a deployment where a finalized version of Ozone manager is
>talking to a previous (or pre-finalized) version of SCM.
Can I understand above as that SCM must be finalized before OM finalized?
If yes, could SCM be downgraded after being finalized? Because there could be
one corner case that after finalized SCM, user doesn't want to continue the
upgrade and try to downgrade due to unexpected reason. If OM downgraded
successfully while SCM could not be downgraded, old OM will talk to the new SCM
version. This should not be expected I think.
On 2021/4/22, 5:42 AM, "Vivek Ratnavel" <vivekratna...@apache.org> wrote:
+1 to merge HDDS-3698-nonrolling-upgrade branch into Ozone master.
Thanks to everyone who contributed.
-Vivek Subramanian
On Mon, Apr 19, 2021 at 10:50 AM Siddharth Wagle
<swa...@cloudera.com.invalid> wrote:
> +1 for Upgrade branch merge.
> Thank you Aravindan, Ethan, Prashant, and Pifta for actively working on
> this important feature for Ozone, and everyone else who contributed
> with ideas and suggestions.
>
> Best,
> Sid
>
>
> On Mon, Apr 19, 2021 at 10:04 AM Aravindan Vijayan
> <avija...@cloudera.com.invalid> wrote:
>
> > Hello all,
> >
> > I would like to propose merging the work done for supporting non rolling
> > upgrades in Ozone (HDDS-3698-nonrolling-upgrade) into the Ozone master
> > branch.
> >
> > As part of the upgrade framework, the following have been added
> >
> > - Ability to create layout features & versions
> > - Ability to finalize and upgrade an Ozone cluster, as well as
> downgrade
> > before finalization.
> > - Ability to add custom actions to be executed as upgrade hooks in
> > different phases.
> > - Ability to 'prepare' an Ozone manager quorum for upgrade.
> >
> > We believe that the branch is ready for merge due to the following
> reasons
> >
> > - We have resolved around 60 JIRAs (including 6 Apache Ratis fixes).
> > There are about 3-4 remaining JIRAs that are currently in progress
(or
> > under review) which are not blockers and are close to completion.
> > - The merge checklist has been looked at and filled in at
> >
> >
>
https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FOZONE%2FNon-Rolling%2BUpgrade%2BFramework%2BMerge%2BChecklist&data=04%7C01%7Cyiqlin%40ebay.com%7C89b86f58a628452052fd08d9050e54c9%7C46326bff992841a0baca17c16c94ea99%7C0%7C1%7C637546381390824151%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=u2TDwqr9oji0axu8ASTtsvRlaEviRp4KUmX4hSTPgXo%3D&reserved=0
> > .
> > - A broad range of test cases have been added including unit tests,
> > integration tests to perform finalization & upgrade, failure
injection
> > testing in HDDS layer finalization and acceptance tests to perform a
> > prepare operation and a docker based upgrade flow from the last
> released
> > version to current.
> > - Sufficient documentation has been added for the design (here
> > <
> >
>
https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fsecure%2Fattachment%2F13023446%2FOzone%2520Non-Rolling%2520Upgrades%2520Doc%2520v1.2%2520%2528Implemented%2520Design%2529.pdf&data=04%7C01%7Cyiqlin%40ebay.com%7C89b86f58a628452052fd08d9050e54c9%7C46326bff992841a0baca17c16c94ea99%7C0%7C1%7C637546381390824151%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=sZ3%2BBCvW6UDk9jQiQkBz5HLi9q5ZfFNdvo8%2FFJqDJ6w%3D&reserved=0
> > >
> > & here
> > <
> >
>
https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fsecure%2Fattachment%2F13015490%2FOM%2520Prepare%2520Upgrade.pdf&data=04%7C01%7Cyiqlin%40ebay.com%7C89b86f58a628452052fd08d9050e54c9%7C46326bff992841a0baca17c16c94ea99%7C0%7C1%7C637546381390824151%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=gmhfRjyCXmVKnRaX6LbS9HIMr2RKyRJgdCXKKRMDL9o%3D&reserved=0
> > >),
> > usage (here
> > <
> >
>
https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fozone%2Fblob%2FHDDS-3698-nonrolling-upgrade%2Fhadoop-hdds%2Fdocs%2Fcontent%2Ffeature%2Fhow-to-do-a-nonrolling-upgrade.md&data=04%7C01%7Cyiqlin%40ebay.com%7C89b86f58a628452052fd08d9050e54c9%7C46326bff992841a0baca17c16c94ea99%7C0%7C1%7C637546381390824151%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=MyqN%2BKdCDBW4tHAQhpTfnMCY8CRrZnCRbYDKFRbNtYE%3D&reserved=0
> > >)
> > and developer primer (here
> > <
> >
>
https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fozone%2Fblob%2FHDDS-3698-nonrolling-upgrade%2Fhadoop-hdds%2Fdocs%2Fcontent%2Fdesign%2Fupgrade-dev-primer.md&data=04%7C01%7Cyiqlin%40ebay.com%7C89b86f58a628452052fd08d9050e54c9%7C46326bff992841a0baca17c16c94ea99%7C0%7C1%7C637546381390834141%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=x%2FTq07heZPTAyiBns0ZbhYpR80Hne5aRqbE1larqFVg%3D&reserved=0
> > >
> > ).
> >
> > There is some work needed to onboard the work done for HDDS-2939 into
the
> > upgrade branch. If that branch is merged first, then the onboarding can
> be
> > done before the upgrade branch merge through a single patch.
> >
> > Please provide your feedback. If there are no objections, I will proceed
> > with starting a vote thread for merging.
> >
> > --
> > Thanks & Regards,
> > Aravindan
> >
>
