Re: [DISCUSS] - Merge FileSystem Optimizations branch HDDS-2939 to master

Hi, Thanks everyone for the useful feedback, comments and contributions. All the points/tasks are addressed now and I'm planning to start a vote thread early next week. Thanks, Rakesh On Tue, May 18, 2021 at 4:08 PM Rakesh Radhakrishnan wrote: > Hi All, > > It seems that the "performance compa

Re: [DISCUSS] - Merge FileSystem Optimizations branch HDDS-2939 to master

Thank you very much @Yiqun for the reply and taking the discussion ahead! Thanks a lot @Marton for the feedback. We were working on the review comments and that caused a delay in my reply. All the points/tasks are addressed and I've updated the wiki page

Re: [DISCUSS] - Merge FileSystem Optimizations branch HDDS-2939 to master

> I am just wondering what is the long-term plan here. Do we plan to handle both prefix/simple code-path with the V1 classes? Or do we plan to keep both of the classes side by side? Do we plan to avoid duplicated code, or it's not possible? And what can we do to minimize the new

Re: [DISCUSS] - Merge FileSystem Optimizations branch HDDS-2939 to master

I strongly recommend for everybody to test the feature and check the code. I tested and -- except some backward compatibility issues like HDDS-5094 -- it worked very well. I also checked the Java code and I am very surprised by the implementation. As far as I understand -- but I can be wr

Re: [DISCUSS] - Merge FileSystem Optimizations branch HDDS-2939 to master

@Marton, [1] backward compatibility: No backward compatibility issues. S3 works well as the feature code sits behind the ozone.om.metadata.layout feature flag. Yes, same normalization behavior as before. Even with feature turned ON the normalization behaviour is the same, as the configuration

Re: [DISCUSS] - Merge FileSystem Optimizations branch HDDS-2939 to master

+1 to merging this feature. Rakesh, I will work with you to onboard this onto upgrades, which is also close to merge. On Fri, Apr 9, 2021 at 8:35 AM Ayush Saxena wrote: > Thanx Rakesh for driving this. > Quickly tried some basic stuff with this. Looks good. > > +1, Good Luck!!! > > -Ayush > > >

Re: [DISCUSS] - Merge FileSystem Optimizations branch HDDS-2939 to master

Thanx Rakesh for driving this. Quickly tried some basic stuff with this. Looks good. +1, Good Luck!!! -Ayush > On 09-Apr-2021, at 2:15 PM, Shashikant Banerjee > wrote: > +1 > > Thanks > Shashi > >> On Fri, Apr 9, 2021 at 1:39 PM Sadanand Shenoy < >> sadanand.shenoy4...@gmail.com> wrote: >>

Re: [DISCUSS] - Merge FileSystem Optimizations branch HDDS-2939 to master

+1 Thanks Shashi On Fri, Apr 9, 2021 at 1:39 PM Sadanand Shenoy < sadanand.shenoy4...@gmail.com> wrote: > +1, Thanks for working on this feature. > > Regards, > Sadanand > > On Thu, Apr 8, 2021, 11:05 PM Rakesh Radhakrishnan > wrote: > > > Thank you very much Yiqun and Marton for the feedback/u

Re: [DISCUSS] - Merge FileSystem Optimizations branch HDDS-2939 to master

+1, Thanks for working on this feature. Regards, Sadanand On Thu, Apr 8, 2021, 11:05 PM Rakesh Radhakrishnan wrote: > Thank you very much Yiqun and Marton for the feedback/useful comments. > Please find my responses below. > > @Yiqun, > As per the discussions, key deletion tasks have been imple

Re: [DISCUSS] - Merge FileSystem Optimizations branch HDDS-2939 to master

Thanks for working on this feature! +1 Regards Lokesh > On 08-Apr-2021, at 11:05 PM, Rakesh Radhakrishnan wrote: > > Thank you very much Yiqun and Marton for the feedback/useful comments. > Please find my responses below. > > @Yiqun, > As per the discussions, key deletion tasks have been impl

Re: [DISCUSS] - Merge FileSystem Optimizations branch HDDS-2939 to master

Thank you very much Yiqun and Marton for the feedback/useful comments. Please find my responses below. @Yiqun, As per the discussions, key deletion tasks have been implemented and the basic functionality of #listKeys works as expected and will be improving it further after merging the feature to m

Re: [DISCUSS] - Merge FileSystem Optimizations branch HDDS-2939 to master

>>> Currently, I see listKey implementation and key deletion lifecycle in FSO hasn't been completed yet. Thanks a lot Yiqun for the great support. Sure, I will focus on these two cases. As we know, basic #listKeys has been supported via HDDS-4683 sub-task and I need to extend it to support #listKe

Re: [DISCUSS] - Merge FileSystem Optimizations branch HDDS-2939 to master

+1 -Prashant > On Apr 5, 2021, at 9:00 AM, Mukul Kumar Singh > wrote: > > +1, This feature will be a great addition to Ozone. > > - Mukul > > On 05/04/21 8:03 pm, Lin, Yiqun wrote: >> +1 for merging to master after resolved current few block subtasks. >> Currently, I see listKey implementat

Re: [DISCUSS] - Merge FileSystem Optimizations branch HDDS-2939 to master

+1, This feature will be a great addition to Ozone. - Mukul On 05/04/21 8:03 pm, Lin, Yiqun wrote: +1 for merging to master after resolved current few block subtasks. Currently, I see listKey implementation and key deletion lifecycle in FSO hasn't been completed yet. On 2021/4/5, 5:49 PM, "

Re: [DISCUSS] - Merge FileSystem Optimizations branch HDDS-2939 to master

+1 for merging to master after resolved current few block subtasks. Currently, I see listKey implementation and key deletion lifecycle in FSO hasn't been completed yet. On 2021/4/5, 5:49 PM, "Rakesh Radhakrishnan" wrote: External Email Hi All, I'm really sorry for the wrong subj

[DISCUSS] - Merge FileSystem Optimizations branch HDDS-2939 to master

Hi All, I'm really sorry for the wrong subject line. It is a [DISCUSS] thread and not a VOTE thread. Please excuse me. Thanks, Rakesh On Mon, Apr 5, 2021 at 3:14 PM Rakesh Radhakrishnan wrote: > Hi All, > > I would like to propose prefix based FileSystem Optimizations (FSO) work > HDDS-2939