probably this should be an autoconf magic but
1) i'm not familiar with autoconf and 2) _np functions
are inheretly non-portable anyway.
Signed-off-by: YAMAMOTO Takashi
---
lib/util.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/lib/util.c b/lib/util.c
index 6a72107..d719cd3 1
> On Wed, Jul 31, 2013 at 11:01:43AM +0900, YAMAMOTO Takashi wrote:
>> probably this should be an autoconf magic but
>> 1) i'm not familiar with autoconf and 2) _np functions
>> are inheretly non-portable anyway.
>>
>> Signed-off-by: YAMAMOTO Takashi
>
looks ok to me.
YAMAMOTO Takashi
> Signed-off-by: Ben Pfaff
> CC: Ed Maste
> CC: YAMAMOTO Takashi
> ---
> lib/netdev-bsd.c | 91
> +-
> 1 file changed, 42 insertions(+), 49 deletions(-)
>
> diff --git a/li
looks ok to me.
YAMAMOTO Takashi
> Signed-off-by: Ben Pfaff
> CC: Ed Maste
> CC: YAMAMOTO Takashi
> ---
> lib/netdev-bsd.c |7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
> index 2e49c94.
> Thanks for this and the other review. Did you try building it? I have
no.
> not build-tested any of the changes in this series outside of a
> GNU/Linux environment.
i can try a build on netbsd more easily if you can provide
a git repo url i can pull from.
YAMAMOTO Takashi
>
&
> On Tue, Aug 06, 2013 at 10:31:57PM +0000, YAMAMOTO Takashi wrote:
>> > not build-tested any of the changes in this series outside of a
>> > GNU/Linux environment.
>>
>> i can try a build on netbsd more easily if you can provide
>> a git repo url i can p
ip.h requires in_systm.h here.
Signed-off-by: YAMAMOTO Takashi
---
lib/bfd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/bfd.c b/lib/bfd.c
index d4ac489..d1b8237 100644
--- a/lib/bfd.c
+++ b/lib/bfd.c
@@ -16,6 +16,7 @@
#include "bfd.h"
#include
+#include
#include
ly.
destroying a rwlock which is currently held is an undefined behaviour.
on NetBSD, pthread_rwlock_destroy fails in that case.
YAMAMOTO Takashi
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
move per-backer wait calls (dpif_wait/udpif_wait) from ofproto_wait
to ofproto_type_wait.
this fixes O(N^2) behaviour (eg. poll slot consumption) for
dpif-netdev where N is the number of bridges.
Signed-off-by: YAMAMOTO Takashi
---
ofproto/ofproto-dpif.c | 4 ++--
1 file changed, 2 insertions
> On Thu, Aug 15, 2013 at 08:25:44PM +0900, YAMAMOTO Takashi wrote:
>> move per-backer wait calls (dpif_wait/udpif_wait) from ofproto_wait
>> to ofproto_type_wait.
>>
>> this fixes O(N^2) behaviour (eg. poll slot consumption) for
>> dpif-netdev where N is the num
is there any reason why ovs-appctl bridge/dump-flows reports
"priority" twice for each flows?
YAMAMOTO Takashi
duration=45786s, priority=32768, n_packets=0, n_bytes=0,
dl_dst=30:31:3a:38:30:3a,dl_type=0x88cc,actions=CONTROLLER:51
table_id=254, duration=45787s, priority=0, n_packets=0,
> On Fri, Aug 16, 2013 at 07:40:20AM +0900, YAMAMOTO Takashi wrote:
>> is there any reason why ovs-appctl bridge/dump-flows reports
>> "priority" twice for each flows?
>
> There are two possibilities. I have not looked to see which is the
> case.
>
> On
fix a bug introduced by commit e1ec7dd4608876283038c417065c4f9978255fa3.
(ofproto-dpif: Implement multi-threaded miss handling.)
Signed-off-by: YAMAMOTO Takashi
---
ofproto/ofproto-dpif-upcall.c | 41 ++---
1 file changed, 22 insertions(+), 19 deletions
this fixes ofp_port_status delivery on a patch port removal.
Signed-off-by: YAMAMOTO Takashi
---
lib/dpif.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/dpif.c b/lib/dpif.c
index 02cc36a..ece5dc0 100644
--- a/lib/dpif.c
+++ b/lib/dpif.c
@@ -536,6 +536,9 @@ dpif_port_del(struct
> On Tue, Aug 27, 2013 at 04:10:03PM +0900, YAMAMOTO Takashi wrote:
>> this fixes ofp_port_status delivery on a patch port removal.
>
> Can you explain further? I don't see any problems with patch port
> removal. Example:
>
> blp@sigse
fix a regression added by commit 89454bf477d1dc95357792677ccbd4d483ab42d8.
"netdev: Fix deadlock when netdev_dump_queues() callback calls into netdev."
Signed-off-by: YAMAMOTO Takashi
---
lib/netdev-bsd.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/
> On Wed, Aug 28, 2013 at 10:38:06AM +0900, YAMAMOTO Takashi wrote:
>> > On Tue, Aug 27, 2013 at 04:10:03PM +0900, YAMAMOTO Takashi wrote:
>> >> this fixes ofp_port_status delivery on a patch port removal.
>> >
>> > Can you explain further? I don'
there's little point to override patch ports, which is implmeneted
purely in our userlang process these days, with a dummy implementation.
this allows testing patch ports in "make sandbox" environment.
Signed-off-by: YAMAMOTO Takashi
---
lib/netdev-dummy.c | 3 +++
1 file change
> On Wed, Aug 28, 2013 at 02:58:02PM +0900, YAMAMOTO Takashi wrote:
>> > On Wed, Aug 28, 2013 at 10:38:06AM +0900, YAMAMOTO Takashi wrote:
>> >> > On Tue, Aug 27, 2013 at 04:10:03PM +0900, YAMAMOTO Takashi wrote:
>> >> >> this fixes ofp
gnal = true;
}
handler->n_upcalls++;
if (handler->need_signal && handler->n_upcalls >= FLOW_MISS_MAX_BATCH) {
handler->need_signal = false;
xpthread_cond_signal(&handler->wake_cond);
}
YAMAMOTO Takashi
> Be more conservative
this patch looks fine and works for me. thanks.
YAMAMOTO Takashi
> Patch ports don't have datapath ports so it doesn't make sense to try to
> call dpif_port_del() on them. If we do try, it will fail, which makes the
> caller think that the port wasn't really dele
> On Fri, Aug 30, 2013 at 12:24:17PM +0900, YAMAMOTO Takashi wrote:
>> > Batching reduces overheads and enables upto 4 times the upcall processing
>> > performance in a specialized test case.
>> >
>> > Signed-off-by: Jarno Rajahalme
>> > ---
&
if a queue length is long (ie. non-0), the consumer thread should
already be busy working on the queue. there's no need to wake it
up repeatedly.
Signed-off-by: YAMAMOTO Takashi
---
ofproto/ofproto-dpif-upcall.c | 32 +---
1 file changed, 21 insertions(+
Commit 31ef9f5178 (timeval: Remove CACHE_TIME scheme.) removed
initialization of a rwlock which is still used for some operations.
This restores it.
---
lib/timeval.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/timeval.c b/lib/timeval.c
index 37b4353..3262397 100644
--- a/lib/timeval.c
plug upcall leak introduced by the commit
"ofproto-dpif-upcall: Forward packets in order of arrival."
(commit 04a19fb8f4b8ba19a9805906aac7b30b65b57206)
Signed-off-by: YAMAMOTO Takashi
---
ofproto/ofproto-dpif-upcall.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/ofpro
> + OFPFC_DELETE_STRICT) != OFPROTO_POSTPONE;
> }
this seems wrong to me. ofproto_delete_flow is used to remove hidden rules.
the new code ends up to use collect_rules_strict which skips hidden rules.
YAMAMOTO Takashi
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
changes from the previous post: rebase.
YAMAMOTO Takashi (1):
ofproto-dpif-upcall: reduce number of wakeup
ofproto/ofproto-dpif-upcall.c | 29 +++--
1 file changed, 19 insertions(+), 10 deletions(-)
--
1.8.3.1
___
dev
-by: YAMAMOTO Takashi
---
ofproto/ofproto.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index f305710..ae39283 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -3490,7 +3490,6 @@ flow_stats_ds(struct rule *rule, struct ds *results
if a queue length is long (ie. non-0), the consumer thread should
already be busy working on the queue. there's no need to wake it
up repeatedly.
Signed-off-by: YAMAMOTO Takashi
---
ofproto/ofproto-dpif-upcall.c | 29 +++--
1 file changed, 19 insertions(+), 10 dele
Signed-off-by: YAMAMOTO Takashi
---
OPENFLOW-1.1+ | 89 +++
1 file changed, 89 insertions(+)
diff --git a/OPENFLOW-1.1+ b/OPENFLOW-1.1+
index 7a75c44..90f811f 100644
--- a/OPENFLOW-1.1+
+++ b/OPENFLOW-1.1+
@@ -168,6 +168,95 @@ didn&#
this was caught by the recent __ARRAY_CHECK stuff.
Signed-off-by: YAMAMOTO Takashi
---
lib/signals.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/signals.c b/lib/signals.c
index f11ed05..27da5d6 100644
--- a/lib/signals.c
+++ b/lib/signals.c
@@ -110,7 +110,7 @@ const
hi,
ovs uses length==4 for the following oxm fields. why?
OXM_OF_IPV6_FLABEL
OXM_OF_MPLS_LABEL
OXM_OF_PBB_ISID
linc uses length==3 for them. it seems like a natural
interpretation of the spec to me.
YAMAMOTO Takashi
___
dev mailing list
> On Tue, Oct 08, 2013 at 02:31:30PM +0900, YAMAMOTO Takashi wrote:
>> ovs uses length==4 for the following oxm fields. why?
>>
>> OXM_OF_IPV6_FLABEL
>
> OXM_OF_IPV6_FLABEL is 4 bytes in the openflow.h header from ONF, so OVS
> has this right.
the header is co
Signed-off-by: YAMAMOTO Takashi
---
OPENFLOW-1.1+ | 9 +
1 file changed, 9 insertions(+)
diff --git a/OPENFLOW-1.1+ b/OPENFLOW-1.1+
index 90f811f..6fabde1 100644
--- a/OPENFLOW-1.1+
+++ b/OPENFLOW-1.1+
@@ -124,6 +124,15 @@ didn't compare the specs carefully yet.)
[optiona
Signed-off-by: YAMAMOTO Takashi
---
tests/ofp-print.at | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/ofp-print.at b/tests/ofp-print.at
index 52b84ef..87d5da8 100644
--- a/tests/ofp-print.at
+++ b/tests/ofp-print.at
@@ -996,6 +996,7 @@ OFPT_TABLE_MOD (OF1.2) (xid=0x2): table_id=2
> On Wed, Oct 09, 2013 at 04:49:06PM +0900, YAMAMOTO Takashi wrote:
>> Signed-off-by: YAMAMOTO Takashi
>
> ...
>
>> + This requires the following.
>> + - Change the default table-miss action (in the absense of table-miss
>> +entry) from p
> On Tue, Oct 15, 2013 at 10:20:04AM +0900, YAMAMOTO Takashi wrote:
>> > On Wed, Oct 09, 2013 at 04:49:06PM +0900, YAMAMOTO Takashi wrote:
>> >> Signed-off-by: YAMAMOTO Takashi
>> >> + This requires the following.
>> >> + - Change
according to the specs, if a packet is not buffered for some reasons,
we should send the entire packet, regardless of max_len.
Signed-off-by: YAMAMOTO Takashi
---
ofproto/connmgr.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/ofproto/connmgr.c b
Signed-off-by: YAMAMOTO Takashi
---
OPENFLOW-1.1+ | 7 +++
1 file changed, 7 insertions(+)
diff --git a/OPENFLOW-1.1+ b/OPENFLOW-1.1+
index 07b2660..4f30520 100644
--- a/OPENFLOW-1.1+
+++ b/OPENFLOW-1.1+
@@ -121,6 +121,13 @@ didn't compare the specs carefully yet.)
[optiona
the existing procfs stuff is not always usable.
stop skipping some relevant tests even if procfs is not available.
Signed-off-by: YAMAMOTO Takashi
---
lib/socket-util.c | 73 +--
python/ovs/socket_util.py | 46
this fixes a test failure with my working directory:
/disks/ea6a5743-ad5f-11e2-9410-08606e7f74e7/git/openvswitch
stop filtering uuid as it's unnecessary for this specific test case.
Signed-off-by: YAMAMOTO Takashi
---
tests/ovsdb-server.at | 2 +-
1 file changed, 1 insertion(+), 1 del
Signed-off-by: YAMAMOTO Takashi
---
tests/test-unix-socket.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/test-unix-socket.py b/tests/test-unix-socket.py
index 5a3f3c0..f55f6c3 100644
--- a/tests/test-unix-socket.py
+++ b/tests/test-unix-socket.py
@@ -40,6 +40,7 @@ def main(argv
the existing procfs stuff is not always usable.
stop skipping some relevant tests even if procfs is not available.
Signed-off-by: YAMAMOTO Takashi
---
lib/socket-util.c | 76 +--
python/ovs/socket_util.py | 46
> On Tue, Oct 15, 2013 at 04:34:18PM -0700, Ben Pfaff wrote:
>> On Tue, Oct 15, 2013 at 11:38:05PM +0900, YAMAMOTO Takashi wrote:
>> > the existing procfs stuff is not always usable.
>> > stop skipping some relevant tests even if procfs is not available.
>> >
As per spec, make packet-in reason for OpenFlow1.3 table-miss flow
entries no_match rather than action.
Signed-off-by: YAMAMOTO Takashi
---
OPENFLOW-1.1+ | 3 ---
include/openflow/openflow-common.h | 5 -
lib/ofp-util.c | 3 +++
ofproto/connmgr.c
comment fixes and cosmetic clean-up.
YAMAMOTO Takashi (3):
ofp-actins: consistently use a helper function
ofputil_match_from_ofp11_match: fix a comment
nx-match: fix comments
lib/nx-match.c| 6 +++---
lib/ofp-actions.c | 2 +-
lib/ofp-util.c| 4 ++--
3 files changed, 6 insertions
Signed-off-by: YAMAMOTO Takashi
---
lib/nx-match.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/nx-match.c b/lib/nx-match.c
index 15143f1..11cbff3 100644
--- a/lib/nx-match.c
+++ b/lib/nx-match.c
@@ -280,8 +280,8 @@ oxm_pull_match__(struct ofpbuf *b, bool strict
Signed-off-by: YAMAMOTO Takashi
---
lib/ofp-util.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 173b534..2bf595a 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -296,8 +296,8 @@ ofputil_pull_ofp11_match(struct ofpbuf *buf
no functional changes.
Signed-off-by: YAMAMOTO Takashi
---
lib/ofp-actions.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index 06f9f6b..d6747b0 100644
--- a/lib/ofp-actions.c
+++ b/lib/ofp-actions.c
@@ -1092,7 +1092,7
> On Wed, Oct 16, 2013 at 05:24:36PM +0900, YAMAMOTO Takashi wrote:
>> As per spec, make packet-in reason for OpenFlow1.3 table-miss flow
>> entries no_match rather than action.
>>
>> Signed-off-by: YAMAMOTO Takashi
>
> Thanks! I really appreciate that you are
> On Thu, Oct 17, 2013 at 02:11:00PM +0900, YAMAMOTO Takashi wrote:
>> > On Wed, Oct 16, 2013 at 05:24:36PM +0900, YAMAMOTO Takashi wrote:
>> >> As per spec, make packet-in reason for OpenFlow1.3 table-miss flow
>> >> entries no_match rather than action.
for longer term, "nested" variants of some ofpact functions
which using ofpbuf->l3 might be desirable.
Signed-off-by: YAMAMOTO Takashi
---
lib/ofp-actions.c | 5 -
lib/ofp-parse.c | 4 +++-
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/lib/ofp-action
ve no workaround. */
> -VLOG_WARN_RL(&rl, "Unix socket name %s is longer than maximum "
> "%d bytes", name, MAX_UN_LEN);
with your new definition of MAX_UN_LEN, this should be %zu.
otherwise looks good to me and worked for me. thanks!
YAMAMOTO Takashi
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
As per spec, make packet-in reason for OpenFlow1.3 table-miss flow
entries no_match rather than action.
Signed-off-by: YAMAMOTO Takashi
---
OPENFLOW-1.1+ | 3 --
include/openflow/openflow-common.h | 5 +-
lib/learn.c| 6 ++-
lib/learning
>> On Thu, Oct 17, 2013 at 02:11:00PM +0900, YAMAMOTO Takashi wrote:
>>> > On Wed, Oct 16, 2013 at 05:24:36PM +0900, YAMAMOTO Takashi wrote:
>>> >> As per spec, make packet-in reason for OpenFlow1.3 table-miss flow
>>> >> entries no_match rather tha
> On Fri, Oct 18, 2013 at 01:41:20PM +0900, YAMAMOTO Takashi wrote:
>> >> On Thu, Oct 17, 2013 at 02:11:00PM +0900, YAMAMOTO Takashi wrote:
>> >>> > On Wed, Oct 16, 2013 at 05:24:36PM +0900, YAMAMOTO Takashi wrote:
>> >>> >> As per spec,
YAMAMOTO Takashi (3):
ofproto: report correct errors for unsupported stats/multipart
messages
ofproto: report multipart buffer overflow
OPENFLOW-1.1+: update multipart stuff
OPENFLOW-1.1+ | 4 +---
lib/ofp-msgs.c| 26 --
lib/ofp-msgs.h| 1
the correct error in that case is OFPERR_OFPBRC_BAD_STAT,
not OFPERR_OFPBRC_BAD_TYPE.
Signed-off-by: YAMAMOTO Takashi
---
lib/ofp-msgs.c| 26 --
lib/ofp-msgs.h| 1 +
ofproto/ofproto.c | 8 ++--
3 files changed, 27 insertions(+), 8 deletions(-)
diff --git a
buffering logic if/when desirable.
Signed-off-by: YAMAMOTO Takashi
---
ofproto/ofproto.c | 4
1 file changed, 4 insertions(+)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index b51b00f..515575e 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -5672,6 +5672,10 @@ handle_
Signed-off-by: YAMAMOTO Takashi
---
OPENFLOW-1.1+ | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/OPENFLOW-1.1+ b/OPENFLOW-1.1+
index 22be72c..82191e1 100644
--- a/OPENFLOW-1.1+
+++ b/OPENFLOW-1.1+
@@ -116,10 +116,8 @@ following additional work. (This is based on the
> On Fri, Oct 18, 2013 at 01:28:44PM +0900, YAMAMOTO Takashi wrote:
>> As per spec, make packet-in reason for OpenFlow1.3 table-miss flow
>> entries no_match rather than action.
>>
>> Signed-off-by: YAMAMOTO Takashi
>
> Thanks a lot for sending a second versi
Signed-off-by: YAMAMOTO Takashi
---
lib/ofp-print.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ofp-print.c b/lib/ofp-print.c
index 6ff6690..e4d0303 100644
--- a/lib/ofp-print.c
+++ b/lib/ofp-print.c
@@ -109,7 +109,7 @@ ofp_print_packet_in(struct ds *string, const
fix a problem introduced by commit cfa955b083c5617212a29a03423e063ff6cb350a.
(connmgr: Fix packet-in reason for OpenFlow1.3 table-miss flow entries.)
ofconn might not be connected here.
in that case ofputil_protocol_to_ofp_version aborts.
Signed-off-by: YAMAMOTO Takashi
---
ofproto/connmgr.c
YAMAMOTO Takashi (2):
connmgr: fix an abort
ofp-print: update a printf format for the recent pin.total_len change
lib/ofp-print.c | 2 +-
ofproto/connmgr.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
--
1.8.3.1
___
dev mailing
the correct error in that case is OFPERR_OFPBRC_BAD_STAT,
not OFPERR_OFPBRC_BAD_TYPE.
currently, the only example of unsupported stats/multipart request is
OFPTYPE_TABLE_FEATURES_STATS_REQUEST.
Signed-off-by: YAMAMOTO Takashi
---
OPENFLOW-1.1+ | 3 ---
lib/ofp-msgs.c| 50
buffering logic if/when desirable.
an option question: what to do for the following messages with the
same xid? especially for the last message which doesn't have the
"more" flag set? it would be neater to detect and drop them.
Signed-off-by: YAMAMOTO Takashi
---
OPENFLO
> On Wed, Oct 23, 2013 at 03:04:21PM +0900, YAMAMOTO Takashi wrote:
>> the correct error in that case is OFPERR_OFPBRC_BAD_STAT,
>> not OFPERR_OFPBRC_BAD_TYPE.
>>
>> Signed-off-by: YAMAMOTO Takashi
>
> If there existed a statistics request that handle_openf
updated after feedbacks from Ben Pfaff.
YAMAMOTO Takashi (2):
ofproto: report correct errors for unsupported stats/multipart
requests
ofproto: report multipart buffer overflow
OPENFLOW-1.1+ | 4 +---
lib/ofp-msgs.c| 50 --
lib/ofp
> On Wed, Oct 23, 2013 at 03:44:50PM +0900, YAMAMOTO Takashi wrote:
>> > On Fri, Oct 18, 2013 at 01:28:44PM +0900, YAMAMOTO Takashi wrote:
>> >> As per spec, make packet-in reason for OpenFlow1.3 table-miss flow
>> >> entries no_match rather than action.
> On Tue, Oct 15, 2013 at 05:12:22PM +0900, YAMAMOTO Takashi wrote:
>> Signed-off-by: YAMAMOTO Takashi
>> ---
>> OPENFLOW-1.1+ | 7 +++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/OPENFLOW-1.1+ b/OPENFLOW-1.1+
>> index 07b2660..4
> On Fri, Nov 01, 2013 at 03:23:10PM +0900, YAMAMOTO Takashi wrote:
>> > On Tue, Oct 15, 2013 at 05:12:22PM +0900, YAMAMOTO Takashi wrote:
>> >> Signed-off-by: YAMAMOTO Takashi
>> >> ---
>> >> OPENFLOW-1.1+ | 7 +++
>> >> 1 file cha
do not report OF1.1 bits (set_dl_src etc) as group features is OF1.2+.
Signed-off-by: YAMAMOTO Takashi
---
ofproto/ofproto.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index b88cd81..28b21ce 100644
--- a
> do not report OF1.1 bits (set_dl_src etc) as group features is OF1.2+.
>
> Signed-off-by: YAMAMOTO Takashi
> ---
> ofproto/ofproto.c | 21 ++---
> 1 file changed, 18 insertions(+), 3 deletions(-)
>
> diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
do not report OF1.1 bits (set_dl_src etc) as group features is OF1.2+.
LINC seems to use 1<<31 for experimenter action type but i failed to
find it in the spec.
Signed-off-by: YAMAMOTO Takashi
---
ofproto/ofproto.c | 20 +---
1 file changed, 17 insertions(+), 3 del
xm_length should be for these properties.
existing implementations seem to vary. LINC always uses 0 and
ofsoftswitch13 uses "normal" value as your patch does. (eg. 6 for eth_dst)
another question is if it should be doubled for the above mentioned
HASMASK=1 case. probably need to ask ONF mem
> +return handle_table_features_stats_request(ofconn, oh);
> +
> +/* FIXME: Change the following once they are implemented: */
> case OFPTYPE_QUEUE_GET_CONFIG_REQUEST:
> return handle_queue_get_config_request(ofconn, oh);
> +/* fallthrough */
this l
6_TYPE,ICMPV6_CODE,IPV6_ND_TARGET,IPV6_ND_SLL,IPV6_ND_TLL,MPLS_LABEL,MPLS_TC,MPLS_BOS,TUNNEL_ID,IPV6_EXTHDR
at least for OFPTFPT_MATCH, HASMASK bit should be dumped as well
because it has a defined meaning. (OpenFlow 1.3.2 p.83)
YAMAMOTO Takashi
_
&= OFPTC_TABLE_MISS_MASK;
> +}
does this mean, call table_get_config only for the first table?
YAMAMOTO Takashi
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
nsigned long long value);
#include
unsigned int
popcount32(uint32_t value);
unsigned int
popcount64(uint64_t value);
DESCRIPTION
The popcount functions returns the number of bits set in value.
YAMAMOTO Takashi
>
> Signed-off-by: Ben Pfaff
> ---
> lib/f
> On Tue, Nov 19, 2013 at 11:20:44AM +0900, YAMAMOTO Takashi wrote:
>> > Having a single function that can do popcount() on any integer type is
>> > easier for callers to get right. The implementation is probably slower
>> > if the caller actually provides a 32-bit
This avoids a conflict with NetBSD's strings.h/libc.
(http://netbsd.gw.com/cgi-bin/man-cgi?popcount++NetBSD-current)
The new name is suggested by Ben Pfaff.
Signed-off-by: YAMAMOTO Takashi
---
lib/flow.c| 5 +++--
lib/util.c| 16
lib/util.h
> On Tue, Nov 19, 2013 at 02:49:53PM +0900, YAMAMOTO Takashi wrote:
>> > On Tue, Nov 19, 2013 at 11:20:44AM +0900, YAMAMOTO Takashi wrote:
>> >> > Having a single function that can do popcount() on any integer type is
>> >> > easier for callers to get rig
revert a mistake in commit 34582733.
("Avoid printf type modifiers not supported by MSVC C runtime library.")
Signed-off-by: YAMAMOTO Takashi
---
lib/util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/util.c b/lib/util.c
index faa2cab..53c3849 100644
--- a/
this is a leftover of commit da4a6191.
("netdev: Globally track port status changes")
Signed-off-by: YAMAMOTO Takashi
---
lib/netdev-bsd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
index 442c384..4a16e5c 100644
--- a/lib/netdev-bsd.c
+++ b/
Signed-off-by: YAMAMOTO Takashi
---
AUTHORS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/AUTHORS b/AUTHORS
index fb204a2..6a56c03 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -112,6 +112,7 @@ Valient Gough vgo...@pobox.com
Vivien Bernet-Rollande v...@soprive.net
Wei
hi,
is anyone working on implementing OF 1.1?
particularly i'm interested in MPLS stuff.
YAMAMOTO Takashi
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
hi,
> On Jun 20, 2011, at 8:36 PM, Ben Pfaff wrote:
>
>> On Tue, Jun 21, 2011 at 12:08:17PM +0900, YAMAMOTO Takashi wrote:
>>> is anyone working on implementing OF 1.1?
>>> particularly i'm interested in MPLS stuff.
>>
>> I don't know anyone w
hi,
> On Jun 21, 2011, at 12:13 AM, YAMAMOTO Takashi wrote:
>
>>> I just wanted to add that OpenFlow 1.1 was a proving ground for a bunch of
>>> new concepts. The ONF, which is now leading the development of the
>>> OpenFlow standard, is working to f
501 - 588 of 588 matches
Mail list logo
