looks ok to me.
YAMAMOTO Takashi
> Signed-off-by: Ben Pfaff <b...@nicira.com>
> CC: Ed Maste <ema...@freebsd.org>
> CC: YAMAMOTO Takashi <y...@mwd.biglobe.ne.jp>
> ---
> lib/netdev-bsd.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
> index 2e49c94..6ff6b3e 100644
> --- a/lib/netdev-bsd.c
> +++ b/lib/netdev-bsd.c
> @@ -1312,12 +1312,9 @@ netdev_bsd_get_next_hop(const struct in_addr *host
> OVS_UNUSED,
> if ((i == RTA_IFP) && sa->sa_family == AF_LINK) {
> const struct sockaddr_dl * const sdl =
> (const struct sockaddr_dl *)sa;
> - const size_t nlen = sdl->sdl_nlen;
> - char * const kernel_name = xmalloc(nlen + 1);
> - const char *name;
> + char *kernel_name;
>
> - memcpy(kernel_name, sdl->sdl_data, nlen);
> - kernel_name[nlen] = 0;
> + kernel_name = xmemdup0(sdl->sdl_data, sdl->sdl_nlen);
> name =
> netdev_bsd_convert_kernel_name_to_ovs_name(kernel_name);
> if (name == NULL) {
> ifname = xstrdup(kernel_name);
> --
> 1.7.10.4
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
