[ovs-dev] [PATCH 3/6] datapath: Account for "vxlan: Eliminate dependency on UDP socket in transmit path"

2015-02-04 Thread Thomas Graf
d-off-by: Tom Herbert Signed-off-by: David S. Miller Upstream: af33c1adae1e ("vxlan: Eliminate dependency on UDP socket in transmit path") Signed-off-by: Thomas Graf Acked-by: Pravin B Shelar --- datapath/linux/compat/include/net/vxlan.h | 12 datapath/linux

[ovs-dev] [PATCH 4/6] datapath: Allow building against 3.19.x

2015-02-04 Thread Thomas Graf
Signed-off-by: Thomas Graf --- FAQ.md | 1 + NEWS | 2 +- acinclude.m4 | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/FAQ.md b/FAQ.md index 02fe2d3..2de4936 100644 --- a/FAQ.md +++ b/FAQ.md @@ -147,6 +147,7 @@ A: The following table lists the Linux kernel

[ovs-dev] [PATCH 6/6] ofproto: Add NXM_NX_TUN_GBP_ID and NXM_NX_TUN_GBP_FLAGS

2015-02-04 Thread Thomas Graf
From: Madhu Challa Introduces two new NXMs to represent VXLAN-GBP [0] fields. actions=load:0x10->NXM_NX_TUN_GBP_ID[],NORMAL tun_gbp_id=0x10,actions=drop This enables existing VXLAN tunnels to carry security label information such as a SELinux context to other network peers. The values are

[ovs-dev] [PATCH 5/6] tunnel: Provide framework for tunnel extensions for VXLAN-GBP and others

2015-02-04 Thread Thomas Graf
Supports a new "exts" field in the tunnel configuration which takes a comma separated list of enabled extensions. The only extension supported so far is GBP but this can be used to enable RCO and possibly others as soon as the OVS datapath supports them. Signed-off-by: Thomas Graf Ack

Re: [ovs-dev] [PATCH] travis: Add 32 bit (-m32) cross-compile build

2015-02-04 Thread Thomas Graf
On 02/04/15 at 09:53am, Ben Pfaff wrote: > On Wed, Feb 04, 2015 at 04:10:59PM +0100, Thomas Graf wrote: > > Inspired by Ben Pfaff's email on 32 bit build environment, this adds a > > 32bit build to the travis build matrix to catch alignment and padding > > issues. > &g

Re: [ovs-dev] [PATCH 2/6] datapath: Support VXLAN Group Policy extension

2015-02-05 Thread Thomas Graf
On 02/04/15 at 03:17pm, Pravin Shelar wrote: > On Wed, Feb 4, 2015 at 7:45 AM, Thomas Graf wrote: > > + > > + flags = TUNNEL_KEY; > > + vxlan_port = vxlan_vport(vport); > > + if (vxlan_port->exts & VXLAN_F_GBP && md->gbp) > > +

Re: [ovs-dev] [ovs-discuss] Open vSwitch STT support

2015-02-05 Thread Thomas Graf
On 02/03/15 at 11:27am, Pravin Shelar wrote: > On Tue, Feb 3, 2015 at 10:19 AM, John W. Linville > wrote: > > Thanks for doing that research for me! :-) You don't see any way to > > work with Dave M. around his objections? > > > > Violating an "upstream first" policy seems like you are making an "

Re: [ovs-dev] [RFC: add openvswitch actions using BPF 1/9] hack: Do not compile datapath

2015-02-05 Thread Thomas Graf
On 02/04/15 at 02:49pm, Andy Zhou wrote: > The OVS eBPF patch sets are developed against master 'net-next' tree, > which is currently targeting for kernel version 3.19. > > The datapath in OVS mater does not currently support 3.19 kernel. > But we should not really using OVS datapath, The changes

Re: [ovs-dev] [RFC: add openvswitch actions using BPF 2/9] odp: add a new ODP action: OVS_ACTION_ATTR_BPF_PROG

2015-02-05 Thread Thomas Graf
On 02/04/15 at 02:49pm, Andy Zhou wrote: > /** > + * struct ovs_action_bpf_prog - %OVS_ACTION_ATTR_BPF_PROG action argument. > + * > + * XXX provides bpf program id and execution context. > + * > + */ > +struct ovs_action_bpf_prog { > + __be32 prog_fd; > + __be32 arg0; > + __be32 arg1

Re: [ovs-dev] [RFC: add openvswitch actions using BPF 2/9] odp: add a new ODP action: OVS_ACTION_ATTR_BPF_PROG

2015-02-05 Thread Thomas Graf
On 02/04/15 at 02:49pm, Andy Zhou wrote: > +struct ovs_action_bpf_prog { > + __be32 prog_fd; > + __be32 arg0; > + __be32 arg1; > +}; Given the 64 bit registers of BPF. Should we have all args in the Netlink message be 64 bit as well? ___ dev

Re: [ovs-dev] [RFC: add openvswitch actions using BPF 5/9] bpf: add the first BPF program.

2015-02-05 Thread Thomas Graf
First of all, I *love* this. I have some questions on versioning of helpers in the kernel. I will put comments in the respective kernel patches directly. On 02/04/15 at 02:49pm, Andy Zhou wrote: > +EXTRA_DIST += $(srcdir)/bpf/ovs-bpf-helpers.h \ > + $(srcdir)/bpf/bpf-shared.h \ > +

Re: [ovs-dev] [RFC: add openvswitch actions using BPF 9/9] ofproto-dpif-xlate: generate BPF output action (Hack)

2015-02-05 Thread Thomas Graf
On 02/04/15 at 02:49pm, Andy Zhou wrote: > This is a hack in xlate code to always generate both BPF output > and the original output action. Since the currnet BPF output 'action' > simply generate a kenrel log message about the output port number. > > With this patch, Every time datapath output a

Re: [ovs-dev] [RFC: add openvswitch actions using BPF 1/2] BPF: add a new BPF program type BPF_PROG_TYPE_OPENVSWITCH

2015-02-05 Thread Thomas Graf
On 02/04/15 at 02:48pm, Andy Zhou wrote: > struct bpf_verifier_ops { > /* return eBPF function prototype for verification */ > - const struct bpf_func_proto *(*get_func_proto)(enum bpf_func_id > func_id); > + const struct bpf_func_proto *(*get_func_proto)(int func_id); This change

Re: [ovs-dev] [RFC: add openvswitch actions using BPF 2/2] openvswitch: implements the BPF_PROG action in datapath

2015-02-05 Thread Thomas Graf
On 02/04/15 at 02:48pm, Andy Zhou wrote: > BPF_PROG action allows an action to be implemented in eBPF language and > downloaded by the userspace at runtime. > > Signed-off-by: Andy Zhou Thanks a lot for putting this together Andy and Joe and everybody else who was involved. This is much further

Re: [ovs-dev] dev question

2015-02-05 Thread Thomas Graf
On 02/05/15 at 07:40pm, Bruce Hartpence wrote: > Good afternoon, > > We have a small IEEE project here that runs a competitor to RSTP. We would > like to try building a module for OVS but are not sure where to start or the > best way to get involved. Any pointers would be appreciated. Resources

Re: [ovs-dev] [PATCH 1/6] datapath: Fix missing symbols when required to use own VXLAN stack

2015-02-05 Thread Thomas Graf
On 02/05/15 at 10:29am, Pravin Shelar wrote: > I pushed this patch to master to fix build failure on few kernels. Thanks ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/6] datapath: Support VXLAN Group Policy extension

2015-02-05 Thread Thomas Graf
On 02/05/15 at 11:58am, Pravin Shelar wrote: > On Thu, Feb 5, 2015 at 2:37 AM, Thomas Graf wrote: > > I kept it because vxlan_sock only holds the receive side flags only > > as masked with VXLAN_F_RCV_FLAGS. GBP is not split into a receive and > > transmit flag so your sugg

Re: [ovs-dev] [PATCH 2/6] datapath: Support VXLAN Group Policy extension

2015-02-06 Thread Thomas Graf
On 02/05/15 at 07:53pm, Pravin Shelar wrote: > On Thu, Feb 5, 2015 at 6:11 PM, Jesse Gross wrote: > > On Thu, Feb 5, 2015 at 6:02 PM, Pravin Shelar wrote: > >> Since it should be possible to configure vxlan tunnel with only > >> REMCSUM_RX or only REMCSUM_TX, I do not think we can store REMCSUM_T

Re: [ovs-dev] [PATCH 4/6] datapath: Allow building against 3.19.x

2015-02-06 Thread Thomas Graf
On 02/06/15 at 11:13am, Pravin Shelar wrote: > On Wed, Feb 4, 2015 at 7:45 AM, Thomas Graf wrote: > > Signed-off-by: Thomas Graf > Acked-by: Pravin B Shelar Thanks. I pushed patch 1-5 to master. ___ dev mailing list dev@openvswi

Re: [ovs-dev] [PATCH 11/13] datapath: Allow building against 3.19.x

2015-02-07 Thread Thomas Graf
On 02/06/15 at 10:28pm, Ben Pfaff wrote: > We already do a ton of kernel module builds in travis, do you mean that > we should do one for every released kernel, or do you mean something > else? I'm primarily thinking of Andy's work to enable runtime CI as well. I think the matrix of stable kernels

Re: [ovs-dev] [PATCH 6/6] ofproto: Add NXM_NX_TUN_GBP_ID and NXM_NX_TUN_GBP_FLAGS

2015-02-11 Thread Thomas Graf
On 02/04/15 at 04:45pm, Thomas Graf wrote: > From: Madhu Challa > > Introduces two new NXMs to represent VXLAN-GBP [0] fields. > > actions=load:0x10->NXM_NX_TUN_GBP_ID[],NORMAL > tun_gbp_id=0x10,actions=drop > > This enables existing VXLAN tunnels to carry securi

Re: [ovs-dev] [PATCH] openvswitch: Add missing initialization in validate_and_copy_set_tun()

2015-02-11 Thread Thomas Graf
Policy extension") > Signed-off-by: Geert Uytterhoeven Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] datapath: vxlan: Only set has-GBP bit in header if any other bits would be set

2015-02-11 Thread Thomas Graf
vxlan: Only set has-GBP bit in header if any other bits would be set This allows for a VXLAN-GBP socket to talk to a Linux VXLAN socket by not setting any of the bits. Signed-off-by: Thomas Graf Signed-off-by: David S. Miller Upstream: db79a621835e ("vxlan: Only se

Re: [ovs-dev] Markdown coding standard

2015-02-12 Thread Thomas Graf
On 02/12/15 at 05:37pm, Finucane, Stephen wrote: > I note that there are no coding standard for Markdown documents. Given this, > I have some questions: > > * What's the expected format for code blocks (multi-line and single-line)? We haven't standardized on anything yet. Is there an exciting

Re: [ovs-dev] [PATCH] datapath: vxlan: Only set has-GBP bit in header if any other bits would be set

2015-02-12 Thread Thomas Graf
On 02/11/15 at 03:58pm, Pravin Shelar wrote: > On Mon, Feb 9, 2015 at 7:54 AM, Thomas Graf wrote: > > vxlan: Only set has-GBP bit in header if any other bits would be set > > > > This allows for a VXLAN-GBP socket to talk to a Linux VXLAN socket by > >

Re: [ovs-dev] [PATCH 11/13] datapath: Allow building against 3.19.x

2015-02-12 Thread Thomas Graf
On 02/12/15 at 01:08pm, Andy Zhou wrote: > I agree. we now have the initial infrastructure to add more tests. > > In the meantime, the infrastructure can also use some improvements. > For example, it does not deal with kernel crash > very well. Any suggestions or past experiences in setting up k

Re: [ovs-dev] [PATCH 6/6] ofproto: Add NXM_NX_TUN_GBP_ID and NXM_NX_TUN_GBP_FLAGS

2015-02-14 Thread Thomas Graf
On 02/13/15 at 01:30pm, Ben Pfaff wrote: > Thanks for being patient with me on this. > > meta-flow.h says that gbp_id is formatted in decimal and gbp_flags in > hex but ofp_print_packet_in() in ofp-print.c uses the opposite > convention. > > I'm sure you can work that out so: > Acked-by: Ben Pfaf

Re: [ovs-dev] [RFC net-next 3/4] openvswitch: Add conntrack action.

2015-02-14 Thread Thomas Graf
On 02/14/15 at 12:13am, Joe Stringer wrote: [..] > +static bool skb_has_valid_nfct(const struct net *net, u16 zone, > +const struct sk_buff *skb) > +{ > + enum ip_conntrack_info ctinfo; > + struct nf_conn *ct = nf_ct_get(skb, &ctinfo); > + > + if (!ct) > +

Re: [ovs-dev] [openstack-dev] [neutron] moving openvswitch ports between namespaces considered harmful

2015-02-15 Thread Thomas Graf
[Copying ovs-dev] On 02/13/15 at 01:47pm, Miguel Ángel Ajo wrote: > Sorry, I forgot about > > 5) If we put all our OVS/OF bridge logic in just one bridge (instead of N: > br-tun, br-int, br-ex, br-xxx), > the performance should be yet higher, since, as far as I understood, > flow rule

Re: [ovs-dev] [openstack-dev] [neutron] moving openvswitch ports between namespaces considered harmful

2015-02-15 Thread Thomas Graf
[Sorry for the resend, I had to subscribe to openstack-dev first, maybe worth removing the subscribe requirement for outsiders] [Copying ovs-dev] On 02/13/15 at 01:47pm, Miguel Ángel Ajo wrote: > Sorry, I forgot about > > 5) If we put all our OVS/OF bridge logic in just one bridge (instead

Re: [ovs-dev] [RFC net-next 3/4] openvswitch: Add conntrack action.

2015-02-15 Thread Thomas Graf
On 02/15/15 at 11:06am, Joe Stringer wrote: > On 15 February 2015 at 07:08, Nicolas Dichtel > wrote: > > Le 15/02/2015 05:47, Joe Stringer a écrit : > >> Right, it was more of a general sanity check which is likely unneeded. > >> I'm not aware of any particular case that this handles. > > > > I a

Re: [ovs-dev] [openstack-dev] [neutron] moving openvswitch ports between namespaces considered harmful

2015-02-16 Thread Thomas Graf
On 02/15/15 at 05:00pm, Kevin Benton wrote: > What is the status of the conntrack integration with respect to > availability in distributions? The lack of state tracking has blocked the > ability for us to get rid of namespaces for the L3 agent (because of SNAT) > and the filtering bridge between t

Re: [ovs-dev] [PATCH] ovsdb-doc: Add license and copyright notice.

2015-02-19 Thread Thomas Graf
On 02/19/15 at 11:10am, Ben Pfaff wrote: > The copyright dates are taken from "git log --follow ovsdb/ovsdb-doc", > considering only Nicira authors' changes. (Only one change was from > a non-Nicira author anyhow.) > > Signed-off-by: Ben

Re: [ovs-dev] [PATCH v2 2/2] [RFC] ovn: Start work on design documentation.

2015-02-19 Thread Thomas Graf
This is a first high level review. I'll be digging into the schema next. On 02/19/15 at 11:16am, Ben Pfaff wrote: > + > + > + The Cloud Management System, as defined above. > + > + > + > + > + The OVN/CMS Plugin is the component of the CMS that > + interfaces to OV

Re: [ovs-dev] [PATCH v2 2/2] [RFC] ovn: Start work on design documentation.

2015-02-19 Thread Thomas Graf
On 02/19/15 at 11:16am, Ben Pfaff wrote: > diff --git a/ovn/ovn-nb.ovsschema b/ovn/ovn-nb.ovsschema > new file mode 100644 > index 000..4c29562 > --- /dev/null > +++ b/ovn/ovn-nb.ovsschema The schema below has some whitespace / tab mixups. [...] > @@ -0,0 +1,63 @@ > +{ > +"name": "OVN_No

Re: [ovs-dev] [PATCH v2 2/2] [RFC] ovn: Start work on design documentation.

2015-02-19 Thread Thomas Graf
On 02/19/15 at 02:36pm, Ben Pfaff wrote: > On Thu, Feb 19, 2015 at 10:20:13PM +0100, Thomas Graf wrote: > > Is this piece CMS specific as well or can we leverage libvirt to > > create some abstraction here and write the vif-id into OVSDB? > > I believe that libvirt a

Re: [ovs-dev] [PATCH net] openvswitch: Fix net exit.

2015-02-19 Thread Thomas Graf
nel panic as follows. > This issue is fixed by detaching all ovs ports from the deleted > namespace at net-exit. [...] > Reported-by: Assaf Muller > Fixes: 46df7b81454("openvswitch: Add support for network namespaces.") > Signed-off-by: Pravi

Re: [ovs-dev] [PATCH 01/14] datapath: Remove compat vxlan_src_port().

2015-02-19 Thread Thomas Graf
> Signed-off-by: Jesse Gross Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 02/14] datapath: Account for "udp: Add udp_sock_create for UDP tunnels to open listener socket"

2015-02-19 Thread Thomas Graf
d > to open the listener port for a UDP tunnel. > > Signed-off-by: Tom Herbert > Signed-off-by: David S. Miller > > Upstream: 8024e028 ("udp: Add udp_sock_create for UDP tunnels to open > listener socket") > S

Re: [ovs-dev] [PATCH 03/14] datapath: Account for "vxlan: Call udp_sock_create"

2015-02-19 Thread Thomas Graf
that the checksum flags are not supported in this backport? Otherwise: Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 04/14] datapath: Use udp_sock_create() for LISP.

2015-02-19 Thread Thomas Graf
On 02/18/15 at 07:02pm, Jesse Gross wrote: > Use the common udp_sock_create() for LISP, similar to what was > done for VXLAN. > > Signed-off-by: Jesse Gross Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch

Re: [ovs-dev] [PATCH 05/14] datapath: Account for "udp: Generic functions to set checksum"

2015-02-19 Thread Thomas Graf
ted in UDP tunnels. > > Signed-off-by: Tom Herbert > Signed-off-by: David S. Miller > > Upstream: af5fcba7 ("udp: Generic functions to set checksum") > Signed-off-by: Jesse Gross Acked-by: Thomas Graf ___ dev mailing l

Re: [ovs-dev] [PATCH 06/14 v2] datapath: Enable OVS GSO to be used up to 3.18 if necessary.

2015-02-20 Thread Thomas Graf
On 02/19/15 at 04:42pm, Pravin Shelar wrote: > Did you considered getting rid of USE_KERNEL_TUNNEL_API and various > kernel version check. And just have one version check of 3.18 kernel > to implement all tunnel backports? > At this point we have most of tunnel code backported (few missing > funct

Re: [ovs-dev] [PATCH v2 1/2] userspace: Replace all uses of strncpy() by ovs_strlcpy().

2015-02-20 Thread Thomas Graf
gt;cr, &match, 0); /* Priority == 0. */ > ovs_refcount_init(&p->ref_cnt); > -strncpy(p->dev_name, dev_name, IFNAMSIZ); > +ovs_strlcpy(p->dev_name, dev_name, IFNAMSIZ); > > classifier_insert(&cls, &p->cr, NULL, 0); > } Nit

Re: [ovs-dev] [PATCH v2 2/2] Makefile: Add rule to check for new uses of strncpy() in userspace.

2015-02-20 Thread Thomas Graf
On 02/20/15 at 11:16am, Ben Pfaff wrote: > This should keep more uses from creeping in again. > > Signed-off-by: Ben Pfaff Nice Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3 1/9] datapath: Enable OVS GSO to be used up to 3.18 if necessary.

2015-02-20 Thread Thomas Graf
ome comments to. In the meantime, here is my: Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3 2/9] datapath: Account for "udp-tunnel: Add a few more UDP tunnel APIs"

2015-02-20 Thread Thomas Graf
Signed-off-by: Andy Zhou > Signed-off-by: David S. Miller > > Upstream: 6a93cc90 ("udp-tunnel: Add a few more UDP tunnel APIs") > Signed-off-by: Jesse Gross Some #ifndef candidates here as well. Acked-by: Thomas Graf ___

Re: [ovs-dev] [PATCH v3 3/9] datapath: Consistently set skb->inner_protocol for tunnels.

2015-02-20 Thread Thomas Graf
by: Jesse Gross Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3 4/9] datapath: Account for "vxlan: Refactor vxlan driver to make use of the common UDP tunnel functions."

2015-02-20 Thread Thomas Graf
er kernels. This restores > the offload support (for both GBP and non-GBP VXLAN). > > Upstream: acbf74a7 ("vxlan: Refactor vxlan driver to make use of the common > UDP tunnel functions.") > Signed-off-by: Jesse Gross Acked-by: Thomas Graf _

Re: [ovs-dev] [PATCH v3 1/9] datapath: Enable OVS GSO to be used up to 3.18 if necessary.

2015-02-20 Thread Thomas Graf
On 02/20/15 at 01:27pm, Jesse Gross wrote: > On Fri, Feb 20, 2015 at 1:11 PM, Thomas Graf wrote: > > This is an extremely nice cleanup overall. > > > > On 02/20/15 at 10:50am, Jesse Gross wrote: > >> +#if LINUX_VERSION_CODE < KERNEL_VERSION(3,9,0) > &g

Re: [ovs-dev] [PATCH v3 5/9] datapath: Use additional common UDP functions for LISP.

2015-02-20 Thread Thomas Graf
On 02/20/15 at 10:50am, Jesse Gross wrote: > LISP can also take advantage of setup_udp_tunnel_sock() and > udp_tunnel_xmit_skb() to increase code reuse. > > Signed-off-by: Jesse Gross Lori should look this over as well but it looks like a straight forward translation to me. Acke

Re: [ovs-dev] [PATCH v3 6/9] datapath: Account for "vlan: introduce *vlan_hwaccel_push_inside helpers"

2015-02-20 Thread Thomas Graf
Shelar > Signed-off-by: David S. Miller > > Upstream: 5968250c ("vlan: introduce *vlan_hwaccel_push_inside helpers") > Signed-off-by: Jesse Gross Noticed that the Geneve hunk of this upstream commit is in the Geneve sync patch of this series. Acked-by: Thomas Graf __

Re: [ovs-dev] [PATCH v3 7/9] datapath: Account for "udp: Do not require sock in udp_tunnel_xmit_skb"

2015-02-20 Thread Thomas Graf
his eliminates the unnecessary dependency > on a UDP socket for UDP tunnel transmit. > > Signed-off-by: Tom Herbert > Signed-off-by: David S. Miller > > Upstream: d998f8ef ("udp: Do not require sock in udp_tunnel_xmit_skb&q

Re: [ovs-dev] [PATCH v3 8/9] datapath: Backport upstream Geneve implementation.

2015-02-20 Thread Thomas Graf
On 02/20/15 at 10:50am, Jesse Gross wrote: > This resolves the differences between the OVS Geneve implementation > and the upstream kernel, particularly in the area of the split > between vport-geneve.c and the generic Geneve data plane. > > Signed-off-by: Jesse Gross Acked-

Re: [ovs-dev] [PATCH v3 9/9] datapath: Account for "openvswitch: Add support for checksums on UDP tunnels."

2015-02-20 Thread Thomas Graf
els.") > Signed-off-by: Jesse Gross Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3 0/9] UDP tunneling backports

2015-02-20 Thread Thomas Graf
On 02/20/15 at 10:50am, Jesse Gross wrote: > This series backports much of the UDP tunnel infrastructure, ultimately > in support of syncing Geneve with upstream and providing outer UDP > checksum support. I reviewed the series although it's not as in-depth as I would have liked. Still wanted to d

Re: [ovs-dev] OVN to-do list

2015-03-02 Thread Thomas Graf
On 02/20/15 at 06:23pm, Jesse Gross wrote: > VXLAN vs. Geneve are pretty much the same for the basic feature set > including hardware offload and ECMP. Obviously Geneve gives you more > space and choice for future extensibility. It's not quite ubiquitous > yet but the next release of Ubuntu will ha

[ovs-dev] [PATCH] travis: Generate new secret key for bu...@openvswitch.org

2015-03-13 Thread Thomas Graf
Signed-off-by: Thomas Graf --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 1838bb2..ffb9744 100644 --- a/.travis.yml +++ b/.travis.yml @@ -25,4 +25,4 @@ script: ./.travis/build.sh $OPTS notifications: email: recipients

Re: [ovs-dev] build mailing list down?

2015-03-13 Thread Thomas Graf
On 03/05/15 at 08:11am, Ben Pfaff wrote: > [moving to ovs-dev, hope that's OK] > > On Thu, Mar 05, 2015 at 03:52:42PM +, Gurucharan Shetty wrote: > > It looks like there have been no emails for a while. > > http://openvswitch.org/pipermail/build/ > > Hmm, looking at travis, there are definite

Re: [ovs-dev] [PATCH] FAQ.md: Add a few more details on how to support a new field.

2015-03-13 Thread Thomas Graf
nderstood only by userspace work too (with a > + performance penalty), so it's reasonable to start development > + without it. Maybe add a reference to the upstream Linux kernel development process as well. Acked-by: Thomas Graf ___ dev mailing l

Re: [ovs-dev] [PATCH] travis: Generate new secret key for bu...@openvswitch.org

2015-03-13 Thread Thomas Graf
On 03/13/15 at 08:55am, Ben Pfaff wrote: > On Fri, Mar 13, 2015 at 03:21:06PM +0100, Thomas Graf wrote: > > > > Signed-off-by: Thomas Graf > > Thanks! > > Acked-by: Ben Pfaff Thanks, pushed. Let's see if it helps.

[ovs-dev] [PATCH] datapath: Turn vports with dependencies into separate modules

2015-03-17 Thread Thomas Graf
lifetime. Allows to remove the error prone maintenance of the global list vport_ops_list. Signed-off-by: Thomas Graf Signed-off-by: David S. Miller Also folds in the follow-up commit 9ba559d9ca3 to turned the non-GPL symbol exports to GPL exports. Exports various backwards

Re: [ovs-dev] [PATCH] include/openflow: Simplify structure checking for OpenFlow headers.

2015-03-17 Thread Thomas Graf
;s quick). > > Signed-off-by: Ben Pfaff Definitely makes sense Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovn: add name column to logical switch table

2015-03-17 Thread Thomas Graf
On 03/17/15 at 05:58pm, Russell Bryant wrote: > + > + > +A name for the logical switch. This name has no special meaning or > purpose > +other than to provide convenience for human interaction with the > ovn-nb > +database. There is no requirement for the name

Re: [ovs-dev] [PATCH] ovn: add name column to logical switch table

2015-03-17 Thread Thomas Graf
On 03/17/15 at 11:27pm, Thomas Graf wrote: > Maybe require the name to be unique like ovsdb bridge names? I realize > it's not needed for technical reasons but it would simplify debugging. > > So maybe replace description with something like this: > Must be unique among

Re: [ovs-dev] [PATCH net-next v3 1/2] openvswitch: add tunnel protocol to sw_flow_key

2015-10-05 Thread Thomas Graf
on with IPv4 ones this won't work anymore). > > The new field was added to a hole in sw_flow_key. > > Signed-off-by: Jiri Benc > Acked-by: Pravin B Shelar Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH net-next] openvswitch: report features supported by the kernel datapath

2015-10-09 Thread Thomas Graf
On 10/08/15 at 03:40pm, Jesse Gross wrote: > On Thu, Oct 8, 2015 at 6:53 AM, Jiri Benc wrote: > > Allow the user space to query what features are supported by the openvswitch > > module. This will be used to allow or disallow certain configurations and/or > > switch between newer and older APIs de

Re: [ovs-dev] [RFC PATCH 2/5] netfilter: Factor out nf_ct_get_info().

2015-10-21 Thread Thomas Graf
On 10/20/15 at 03:20pm, Jarno Rajahalme wrote: > Define a new inline function to map conntrack status to enum > ip_conntrack_info. This removes the need to otherwise duplicate this > code in a later patch. > > Signed-off-by: Jarno Rajahalme LGTM > --- > include/net/netfilter/nf_conntrack.h |

Re: [ovs-dev] [RFC PATCH 5/5] openvswitch: Interface with NAT.

2015-10-21 Thread Thomas Graf
d within the nested > attributes, new (non-committed/non-confirmed) connections are mangled > according to the rest of the nested attributes. > > This work extends on a branch by Thomas Graf at > https://github.com/tgraf/ovs/tree/nat. > > Signed-off-by: Jarno Rajahalme Aw

Re: [ovs-dev] [RFC PATCH 4/5] openvswitch: conntrack netlink API updates.

2015-10-21 Thread Thomas Graf
On 10/21/15 at 12:41pm, Pablo Neira Ayuso wrote: > On Tue, Oct 20, 2015 at 03:20:28PM -0700, Jarno Rajahalme wrote: > > diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c > > index 77850f1..1e6c2ac 100644 > > --- a/net/openvswitch/flow_netlink.c > > +++ b/net/openvswitch/f

Re: [ovs-dev] [RFC PATCH 5/5] openvswitch: Interface with NAT.

2015-10-21 Thread Thomas Graf
On 10/21/15 at 11:34am, Florian Westphal wrote: > Jarno Rajahalme wrote: > > #define OVS_CS_F_REPLY_DIR 0x08 /* Flow is in the reply direction. > > */ > > #define OVS_CS_F_INVALID 0x10 /* Could not track connection. */ > > #define OVS_CS_F_TRACKED 0x20 /* Conntrack

Re: [ovs-dev] [RFC PATCH 5/5] openvswitch: Interface with NAT.

2015-10-21 Thread Thomas Graf
On 10/21/15 at 02:04pm, Jarno Rajahalme wrote: > > > On Oct 21, 2015, at 3:59 AM, Thomas Graf wrote: > > Simplify this with an OVS_NAT_ATTR_FLAGS? > > The use of separate flag attributes was actually intentional, as it makes the > interface easier to understand, and

Re: [ovs-dev] [RFC PATCH 1/5] netfilter: Remove IP_CT_NEW_REPLY definition.

2015-10-21 Thread Thomas Graf
On 10/21/15 at 01:15pm, Jarno Rajahalme wrote: > > > On Oct 21, 2015, at 1:33 AM, Thomas Graf wrote: > > I understand what you are doing here but this is part of the published > > UAPI and removing this might break compilation of a user application > > even if the d

[ovs-dev] [PATCH 1.7] rhel: Automatically start openvswitch service before bringing an ovs interface up or down

2013-01-25 Thread Thomas Graf
This patch modifies the ifup/ifdown scripts to automatically start the openvswitch service before ovs-vsctl is invoked thus not making it mandatory to auto-start openvswitch on boot. Signed-off-by: Thomas Graf --- rhel/etc_sysconfig_network-scripts_ifdown-ovs | 2 ++ rhel/etc_sysconfig_network

[ovs-dev] [PATCH 1.7] rhel: Add OVSREQUIRES to automatically bring up OpenFlow interface dependencies

2013-01-25 Thread Thomas Graf
before the openvswitch service is autostarted. It is also possible to build a chain of bridge dependencies. TYPE=OVSBridge OVSREQURIES="em1" [...] A special UPPEDSTACK var that is passed along avoids getting lost in dependency loops. Signed-off-by: Th

Re: [ovs-dev] [PATCH 1.7] rhel: Add OVSREQUIRES to automatically bring up OpenFlow interface dependencies

2013-01-25 Thread Thomas Graf
On 01/25/2013 06:51 PM, Ben Pfaff wrote: This gets a reject when I apply it (against branch-1.7 or master) because the context line: [ -f /var/lock/subsys/openvswitch ] || /sbin/service openvswitch start is not present in either version. Do you want to first submit a patch to add that line?

[ovs-dev] [PATCH 1.7] linux: Increase accuracy of ingress_policing_rate at low rates

2013-01-25 Thread Thomas Graf
The current method of calculating the ingress policer rate can lead to inaccuracy if ingress_policing_rate is set to a smallish values because the rate is divided by 8 first which causes rounding errors. Signed-off-by: Thomas Graf --- lib/netdev-linux.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [ovs-dev] [PATCH 1.7] rhel: Add OVSREQUIRES to automatically bring up OpenFlow interface dependencies

2013-01-25 Thread Thomas Graf
On 01/25/2013 07:39 PM, Ben Pfaff wrote: I applied both patches to master. You specified 1.7 in the subject lines. Does this mean that you generated them against 1.7 or that you need them applied to branch-1.7? If it's the latter, that you need them in branch-1.7 because that's what you're pla

[ovs-dev] [PATCH net-next 0/6] Open vSwitch updates

2013-03-29 Thread Thomas Graf
A couple of small Open vSwitch fixes and cleanups that accumulated while working on larger pieces. The biggest change is the exposure of to user space to make the Netlink interface available without requiring every appliation to copy the header file from a source tree. Thomas Graf (6

[ovs-dev] [PATCH net-next 2/6] openvswitch: Use nla_memcpy() to memcpy() data from attributes

2013-03-29 Thread Thomas Graf
Less error prone as it takes into account the length of both the destination buffer and the source attribute and documents when data is copied from an attribute. Signed-off-by: Thomas Graf --- net/openvswitch/datapath.c | 2 +- net/openvswitch/flow.c | 2 +- 2 files changed, 2 insertions

[ovs-dev] [PATCH net-next 4/6] openvswitch: Move common genl notify code into ovs_notify()

2013-03-29 Thread Thomas Graf
Signed-off-by: Thomas Graf --- net/openvswitch/datapath.c | 36 1 file changed, 16 insertions(+), 20 deletions(-) diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index 49ee37b..d406503 100644 --- a/net/openvswitch/datapath.c +++ b/net

[ovs-dev] [PATCH net-next 3/6] openvswitch: Refine Netlink message size calculation and kill FLOW_BUFSIZE

2013-03-29 Thread Thomas Graf
. Signed-off-by: Thomas Graf --- net/openvswitch/datapath.c | 76 +++--- net/openvswitch/flow.h | 21 - 2 files changed, 52 insertions(+), 45 deletions(-) diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index bca63c8

[ovs-dev] [PATCH net-next 6/6] openvswitch: Expose to userspace

2013-03-29 Thread Thomas Graf
It contains the public netlink interface bits required by userspace to make use of the interface. Signed-off-by: Thomas Graf --- include/linux/openvswitch.h | 433 + include/uapi/linux/Kbuild| 1 + include/uapi/linux/openvswitch.h | 456

[ovs-dev] [PATCH net-next 5/6] openvswitch: Use ETH_ALEN to define ethernet addresses

2013-03-29 Thread Thomas Graf
Signed-off-by: Thomas Graf --- include/linux/openvswitch.h | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h index 67d6c7b..8b9d721 100644 --- a/include/linux/openvswitch.h +++ b/include/linux/openvswitch.h

[ovs-dev] [PATCH net-next 1/6] openvswitch: Specify the minimal length of OVS_PACKET_ATTR_PACKET in the policy

2013-03-29 Thread Thomas Graf
Specifying the minimal length in the policy makes it reuseable and documents the interface. Signed-off-by: Thomas Graf --- net/openvswitch/datapath.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index 8759265

[ovs-dev] [PATCH net-next] openvswitch: Provide OVS_DP_ATTR_UPCALL_PID in datapath messages

2013-04-02 Thread Thomas Graf
message to gain symmetry between the SET and GET command. Signed-off-by: Thomas Graf --- net/openvswitch/datapath.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index d406503..e9b9469 100644 --- a/net

[ovs-dev] [PATCH net-next] openvswitch: Don't insert empty OVS_VPORT_ATTR_OPTIONS attribute

2013-04-02 Thread Thomas Graf
The port specific options are currently unused resulting in an empty OVS_VPORT_ATTR_OPTIONS nested attribute being inserted into every OVS_VPORT_CMD_GET message. Don't insert OVS_VPORT_ATTR_OPTIONS if no options are present. Signed-off-by: Thomas Graf --- net/openvswitch/vport.c

Re: [ovs-dev] [PATCH net-next] openvswitch: Provide OVS_DP_ATTR_UPCALL_PID in datapath messages

2013-04-03 Thread Thomas Graf
On 04/02/13 at 04:30pm, Jesse Gross wrote: > Can you describe the race condition some more? The kernel doesn't > change the port ID on its own so even needing to request the value > seems rare. The upcall nlport is changeable with OVS_VPORT_CMD_SET and may be received between the OVS_DP_CMD_GET a

[ovs-dev] [PATCH 1.7] datapath: Fix compat layer to get datpath to compile with Red Hat Enterprise Linux 6.4

2013-04-05 Thread Thomas Graf
Not intended to be applied to branch-1.7 since 1.9.x is the new LTS but posted here in case anybody wants to compile the 1.7 datapath on Red Hat Enterprise Linux 6.4 Signed-off-by: Thomas Graf --- acinclude.m4 | 6 ++ datapath/linux/compat/include/linux

[ovs-dev] [PATCH 2/2] datapath: Account for RHEL6.4 backports in compat layer

2013-04-19 Thread Thomas Graf
Explicitly check the availability of several kernel API functions instead of relying on the kernel version to account for Red Hat Enterprise Linux backports. Signed-off-by: Thomas Graf --- acinclude.m4| 7 +++ datapath/linux/compat/include/asm/percpu.h

[ovs-dev] [PATCH 1/2] datapath: Use openvswitch_handle_frame hook in >=RHEL6.4 to live side by side with bridging

2013-04-19 Thread Thomas Graf
S bridge. Signed-off-by: Thomas Graf --- acinclude.m4| 3 +++ datapath/vport-netdev.c | 36 2 files changed, 35 insertions(+), 4 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 911a23d..2703bc4 100644 --- a/acinclude.m4 +++ b/acin

Re: [ovs-dev] [PATCH 2/2] datapath: Account for RHEL6.4 backports in compat layer

2013-04-23 Thread Thomas Graf
On 04/23/2013 10:42 PM, Jesse Gross wrote: On Fri, Apr 19, 2013 at 7:01 AM, Thomas Graf wrote: diff --git a/datapath/linux/compat/include/asm/percpu.h b/datapath/linux/compat/include/asm/percpu.h index 404b937..65bce08 100644 --- a/datapath/linux/compat/include/asm/percpu.h +++ b/datapath

Re: [ovs-dev] [PATCH 2/2] datapath: Account for RHEL6.4 backports in compat layer

2013-04-23 Thread Thomas Graf
On 04/24/2013 12:06 AM, Jesse Gross wrote: OK, thanks. I was about to apply this but it adds a new warning (on a non-RHEL platform): /home/jgross/openvswitch/datapath/linux/netdevice.c:5:13: warning: ‘can_checksum_protocol’ defined but not used [-Wunused-function] This happens since the code in

Re: [ovs-dev] [PATCH 1/2] datapath: Use openvswitch_handle_frame hook in >=RHEL6.4 to live side by side with bridging

2013-04-23 Thread Thomas Graf
On 04/23/2013 10:39 PM, Jesse Gross wrote: On Fri, Apr 19, 2013 at 7:01 AM, Thomas Graf wrote: diff --git a/datapath/vport-netdev.c b/datapath/vport-netdev.c index f8948fa..c0e3c02 100644 --- a/datapath/vport-netdev.c +++ b/datapath/vport-netdev.c @@ -153,10 +161,16 @@ static struct vport

[ovs-dev] [PATCH 0/2 v2] datapath: RHEL6.4 updates

2013-04-25 Thread Thomas Graf
Repost of RHEL6.4 datapath updates. Thomas Graf (2): datapath: Use openvswitch_handle_frame hook in >=RHEL6.4 to live side by side with bridging datapath: Account for RHEL6.4 backports in compat layer acinclude.m4| 10 +++ datapath/linux/com

[ovs-dev] [PATCH 1/2] datapath: Use openvswitch_handle_frame hook in >=RHEL6.4 to live side by side with bridging

2013-04-25 Thread Thomas Graf
S bridge. Signed-off-by: Thomas Graf --- V2: - Use rcu_assign_pointer() to set hook and data pointer acinclude.m4| 3 +++ datapath/vport-netdev.c | 36 2 files changed, 35 insertions(+), 4 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index

[ovs-dev] [PATCH 2/2] datapath: Account for RHEL6.4 backports in compat layer

2013-04-25 Thread Thomas Graf
Explicitly check the availability of several kernel API functions instead of relying on the kernel version to account for Red Hat Enterprise Linux backports. Signed-off-by: Thomas Graf --- V2: - Move can_checksum_protocol() back into #ifdef acinclude.m4| 7

[ovs-dev] [PATCH 1.9 1/2] datapath: Use openvswitch_handle_frame hook in >=RHEL6.4 to live side by side with bridging

2013-04-26 Thread Thomas Graf
S bridge. Signed-off-by: Thomas Graf Signed-off-by: Jesse Gross (cherry picked from commit f285d3e715512571c4b2f92a4d1c65022bbcc9d5) Conflicts: datapath/vport-netdev.c --- acinclude.m4| 3 +++ datapath/vport-netdev.c | 34 ++ 2 files changed, 33 in

[ovs-dev] [PATCH 1.9 0/2] datapath: Backport of RHEL6.4 updates

2013-04-26 Thread Thomas Graf
Backport of RHEL6.4 datapath updates to 1.9 branch Thomas Graf (2): datapath: Use openvswitch_handle_frame hook in >=RHEL6.4 to live side by side with bridging datapath: Account for RHEL6.4 backports in compat layer acinclude.m4| 7 ++ datapath/li

[ovs-dev] [PATCH 1.9 2/2] datapath: Account for RHEL6.4 backports in compat layer

2013-04-26 Thread Thomas Graf
Explicitly check the availability of several kernel API functions instead of relying on the kernel version to account for Red Hat Enterprise Linux backports. Signed-off-by: Thomas Graf Signed-off-by: Jesse Gross (cherry picked from commit 42d5dd9595cce35a8825a20be7d71a3a8f6f5640) Conflicts

<    4   5   6   7   8   9   10   11   >