On 01/06/15 at 11:34am, Andy Zhou wrote:
> We have been think about adding unit tests the kernel module. Any
> plans or objections to develop kmod unit tests on top of this patch?
No objections at all. This is exactly where I want to go with this.
Please go ahead. I have some other things to com
I'd
> appreciate critical review from anyone who does.
>
> Signed-off-by: Ben Pfaff
> Reviewed-by: Flavio Leitner
Looks perfect to me to ensure we are well prepared. We can revise as
needed when we handle the first case.
Acked-by: Thomas Graf
___
On 01/06/15 at 09:29pm, Flavio Leitner wrote:
> There are a couple missing steps needed in order to
> build the Vagrantfile. This patch adds them to the
> INSTALL.md file.
>
> Signed-off-by: Flavio Leitner
Agreed that it's a good idea to mention this requirement.
Should we refer to the "Buildi
On 01/06/15 at 09:45pm, Flavio Leitner wrote:
> On Wednesday, January 07, 2015 12:35:45 AM Thomas Graf wrote:
> > I left this out because other similar sections such as testsuite, ryu,
> > oftest, ... also assume a configured (and built) local source tree.
>
> What about crea
[2] support will be provided in separate patches.
[0] https://tools.ietf.org/html/draft-smith-vxlan-group-policy
[1] https://github.com/tgraf/iproute2/tree/vxlan-gbp
[2] https://github.com/tgraf/ovs/tree/vxlan-gbp
Thomas Graf (6):
vxlan: Allow for VXLAN extensions to be implemented
vxlan: Group Pol
ve parsing behaviour by default but allows
these fields to be used by VXLAN extensions which are explicitly enabled
on the VXLAN socket respectively VXLAN net_device.
Signed-off-by: Thomas Graf
---
drivers/net/vxlan.c | 29 +++--
include/net/vx
A VXLAN net_device looking for an appropriate socket may only
consider a socket which has the exact set of extensions enabled.
If none can be found, a new socket must be created.
The OVS VXLAN port is kept unaware of extensions at this point.
Signed-off-by: Thomas Graf
---
drivers/net/vxlan.c
Due to the complexity of struct vxlanhdr, protect against unwanted
and undesired changes by failing the build if the size of the struct
changes.
Signed-off-by: Thomas Graf
---
drivers/net/vxlan.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
t-mark 0x200
$ iptables -I INPUT -i br0 -m mark --mark 0x200 -j ACCEPT
OVS (patches provided separately):
in_port=1, actions=load:0x200->NXM_NX_TUN_GBP_ID[],NORMAL
[0] https://tools.ietf.org/html/draft-smith-vxlan-group-policy
[1] http://lwn.net/Articles/204905/
Signed-off-by: Th
Netlink attribute
OVS_TUNNEL_KEY_ATTR_VXLAN_OPTS which is mutually exclusive to the
existing OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS.
Signed-off-by: Thomas Graf
---
include/uapi/linux/openvswitch.h | 19 ++
net/openvswitch/flow_netlink.c | 78 +--
net/openvswitch
A subsequent patch will introduce VXLAN options. Rename the existing
GENEVE_TUN_OPTS() to reflect its extended purpose of carrying generic
tunnel metadata options.
Signed-off-by: Thomas Graf
---
net/openvswitch/flow.c | 2 +-
net/openvswitch/flow.h | 14 +++---
net
old __vlan_insert_tag()
v2:
- Improved commit message of patch 2
- New patch to address arg changes to vxlan_sock_add()
Thomas Graf (8):
datapath: Account for rename to vlan_insert_tag_set_proto()
datapath: Add __vlan_insert_tag() compat helper if not available
datapath: move make_writable
__vlan_put_tag() was renamed to vlan_insert_tag_set_proto() with
the argument list kept intact.
Upstream: 62749e ("vlan: rename __vlan_put_tag to vlan_insert_tag_set_proto")
Signed-off-by: Thomas Graf
---
acinclude.m4 | 1 +
datapath
;vlan: introduce __vlan_insert_tag helper which does not
free skb")
Signed-off-by: Thomas Graf
---
acinclude.m4 | 2 ++
datapath/linux/compat/include/linux/if_vlan.h | 29 +++
2 files changed, 31 insertions(+)
diff --git a/acinclude.m4 b/acinc
note that skb_make_writable already exists in net/netfilter/core.c
but does something slightly different.
Upstream: e219512 ("net: move make_writable helper into common code")
Signed-off-by: Thomas Graf
---
acinclude.m4 | 1 +
datapath
8021AD tag to software.
This is not a problem though as it preserves existing behaviour.
Upstream: 93515d53 ("net: move vlan pop/push functions into common code")
Signed-off-by: Thomas Graf
---
acinclude.m4 | 2 +
datapath/actions.c
This stub now allows userspace to see IFLA_INFO_KIND for ovs master and
IFLA_INFO_SLAVE_KIND for slave.
Upstream: 5b9e7e16 ("openvswitch: introduce rtnl ops stub")
Signed-off-by: Thomas Graf
---
datapath/datapath.c | 9 -
datapath/vport-internal_
Signed-off-by: Thomas Graf
---
.travis.yml | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 7056f54..1ffd15a 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -7,16 +7,17 @@ before_install: ./.travis/prepare.sh
env:
- OPTS
s argument.
Upstream: 359a0ea ("vxlan: Add support for UDP checksums (v4 sending, v6 zero
csums)")
Signed-off-by: Thomas Graf
---
datapath/linux/compat/include/net/vxlan.h | 2 +-
datapath/linux/compat/vxlan.c | 2 +-
datapath/vport-vxlan.c| 2 +-
3 files c
g/patch/418756/
Upstream: 8754589 ("net: replace remaining users of arch_fast_hash with jhash")
Signed-off-by: Thomas Graf
---
acinclude.m4 | 1 -
datapath/flow_table.c | 4 +-
datapath/linux/Modules.mk | 4 -
On 01/06/15 at 07:46pm, Tom Herbert wrote:
> On Tue, Jan 6, 2015 at 6:05 PM, Thomas Graf wrote:
> > The VXLAN receive code is currently conservative in what it accepts and
> > will reject any frame that uses any of the reserved VXLAN protocol fields.
> > The VXLAN draft spe
On 01/07/15 at 10:03am, David Laight wrote:
> From: Alexei Starovoitov
> > On Tue, Jan 6, 2015 at 6:05 PM, Thomas Graf wrote:
> > > +struct vxlan_gbp {
> > > +#ifdef __LITTLE_ENDIAN_BITFIELD
> > > + __u8reserved_flags1:3,
> > ...
> &g
On 01/06/15 at 07:37pm, Alexei Starovoitov wrote:
> Even it works ok, I think this struct layout is ugly.
> imo would be much easier to read if you replace
> the whole vxlanhdr with vxlanhdr_gbp
> or split vxlanhdr into two 32-bit structs.
> then __packed hacks won't be needed.
The main reason why
On 01/06/15 at 07:46pm, Pravin Shelar wrote:
> On Tue, Jan 6, 2015 at 6:10 PM, Thomas Graf wrote:
> > __vlan_put_tag() was renamed to vlan_insert_tag_set_proto() with
> > the argument list kept intact.
> >
> > Upstream: 62749e ("vlan: rename __vlan_put_tag t
On 01/07/15 at 12:13pm, Flavio Leitner wrote:
> There are other parts of the document that needs to
> reference some building steps. Instead of copying
> and explaining again, this patch splits the building
> section in three sections that can be referenced.
>
> Signed-off-by: Flavio Leitner
Lo
On 01/07/15 at 08:05am, Tom Herbert wrote:
> Associating a sixteen bit field with security is worrisome, especially
> considering that VXLAN provides no verification for any header fields
> and doesn't even advocate use of outer UDP checksum so the field is
> susceptible to an undetected single bit
On 01/07/15 at 08:56am, Tom Herbert wrote:
> On Wed, Jan 7, 2015 at 8:21 AM, Thomas Graf wrote:
> > If the VNI is not already used for another purpose, yes. The solution
> > as proposed can be integrated into existing VXLAN overlays separated by
> > VNI. It is also compatibl
On 01/07/15 at 02:45pm, Jesse Gross wrote:
> On Tue, Jan 6, 2015 at 6:05 PM, Thomas Graf wrote:
> > A VXLAN net_device looking for an appropriate socket may only
> > consider a socket which has the exact set of extensions enabled.
> > If none can be found, a new socket must b
On 01/07/15 at 02:46pm, Jesse Gross wrote:
> On Tue, Jan 6, 2015 at 6:05 PM, Thomas Graf wrote:
> > A subsequent patch will introduce VXLAN options. Rename the existing
> > GENEVE_TUN_OPTS() to reflect its extended purpose of carrying generic
> > tunnel metadata options.
On 01/07/15 at 02:46pm, Jesse Gross wrote:
> On Tue, Jan 6, 2015 at 6:05 PM, Thomas Graf wrote:
> > The group policy metadata is handled in the same way as Geneve options
> > and transported as binary blob in a new Netlink attribute
> > OVS_TUNNEL_KEY_ATTR_VXLAN_OPTS which
On 01/07/15 at 02:45pm, Jesse Gross wrote:
> My concern is that having multiple (and potentially overlapping)
> extensions is going to make the VXLAN code very messy and hard to
> follow. I think there's already quite a big of complexity there from
> the DOVE extensions (which are basically dead at
On 01/07/15 at 09:32am, Alexei Starovoitov wrote:
> I'm afraid 'union' style with first u8 flags working as selector
> won't work for the case you're describing, but since
> md.gbp = ntohs(vxh->gbp.policy_id);
> 2652: 41 0f b7 55 0a movzwl 0xa(%r13),%edx
> t
On 01/07/15 at 04:02pm, Tom Herbert wrote:
> Do you know how could GPE work with GBP they want to use the same bits
> in header for data? Seems like these are mutually exclusive
> extensions. RCO should be fine with either :-)
Yes, GBP and GPE are mutually exclusive extensions. Although
GPE would
On 01/07/15 at 05:18pm, Jesse Gross wrote:
> On Wed, Jan 7, 2015 at 3:01 PM, Thomas Graf wrote:
> > The encoding will be based on struct ovs_vxlan_opts which is extended
> > as needed by appending new members to the end of the struct. Parsers
> > will look at the provide
around this issue.
> See Install.md for instructions.
>
> Since out of tree builds requires a clean source tree, Vagrantfile can
> not be a generated file. This commit removes Vagrantfile.in, commit
> Vagrantfile instead.
>
> Signed-off-by
this point.
Signed-off-by: Thomas Graf
---
v2:
- Improved commit message, reported by Jesse
drivers/net/vxlan.c | 35 +--
include/net/vxlan.h | 2 +-
net/openvswitch/vport-vxlan.c | 2 +-
3 files changed, 23 insertions(+), 16 deletions(-)
[2] support will be provided in separate patches.
[0] https://tools.ietf.org/html/draft-smith-vxlan-group-policy
[1] https://github.com/tgraf/iproute2/tree/vxlan-gbp
[2] https://github.com/tgraf/ovs/tree/vxlan-gbp
Thomas Graf (6):
vxlan: Allow for VXLAN extensions to be implemented
vxlan: Group Pol
ve parsing behaviour by default but allows
these fields to be used by VXLAN extensions which are explicitly enabled
on the VXLAN socket respectively VXLAN net_device.
Signed-off-by: Thomas Graf
---
v2:
- No change
drivers/net/vxlan.c | 29 +++--
include/net/vx
nlattr_set() is currently hardcoded to two levels of nesting. This change
introduces struct ovs_len_tbl to define minimal length requirements plus
next level nesting tables to traverse the key attributes to arbitary depth.
Signed-off-by: Thomas Graf
---
v2:
- New patch to allow nested Netlink
tf.org/html/draft-smith-vxlan-group-policy
[1] http://lwn.net/Articles/204905/
Signed-off-by: Thomas Graf
---
v2:
- split GBP header definition into separate struct vxlanhdr_gbp as requested
by Alexei
drivers/net/vxlan.c | 161 ++
includ
Also factors out Geneve validation code into a new separate function
validate_and_copy_geneve_opts().
A subsequent patch will introduce VXLAN options. Rename the existing
GENEVE_TUN_OPTS() to reflect its extended purpose of carrying generic
tunnel metadata options.
Signed-off-by: Thomas Graf
implemented mutually exclusive.
Signed-off-by: Thomas Graf
---
v2:
- Addressed Jesse's request to transport VXLAN options as Netlink
attributes instead of a binary blob. Allows a partial transport of
VXLAN extensions. Internally, the datapath continues to use a binary
blob (defined in
On 01/09/15 at 06:31pm, Motonori Shindo wrote:
> The order of execution in Vagrantfile is "outside-in" meaning that
> all commands in outer scope are executed first and then the commands
> in inner scope. Because of this ordering, "configure_ovs" is executed
> before "bootstrap_fedora", resulting i
From: Amit Bose
Cflags in pkg-config files sets the include path to $PREFIX/openflow,
$PREFIX/openvswitch. This makes the including source files use the files
like
include
instead of
include
Signed-off-by: Amit Bose
---
lib/libopenvswitch.pc.in | 2 +-
lib/libsflow.pc.in | 2 +-
of
Installs the kernel-devel package of the currently running kernel and
builds the kmod RPM in the "install_rpm" phase.
Signed-off-by: Thomas Graf
---
Vagrantfile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Vagrantfile b/Vagrantfile
index 82b157c..1cacd3b 10
On 01/09/15 at 09:37am, Alexei Starovoitov wrote:
> On Thu, Jan 8, 2015 at 2:47 PM, Thomas Graf wrote:
> > +
> > +struct vxlan_gbp {
> > +} __packed;
>
> empty struct ? seems unused.
> looks good to me otherwise.
Poor leftover, must feel all lonely there. Thank
On 01/09/15 at 11:10am, Andy Zhou wrote:
> Thomas, Thanks for fixing this.
>
> Acked-by: Andy Zhou
Thanks, pushed to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 01/11/15 at 09:53am, Ben Pfaff wrote:
> On Fri, Jan 09, 2015 at 12:29:48PM +0100, Thomas Graf wrote:
> > From: Amit Bose
> >
> > Cflags in pkg-config files sets the include path to $PREFIX/openflow,
> > $PREFIX/openvswitch. This makes the including source f
nlattr_set() is currently hardcoded to two levels of nesting. This change
introduces struct ovs_len_tbl to define minimal length requirements plus
next level nesting tables to traverse the key attributes to arbitary depth.
Signed-off-by: Thomas Graf
---
v2->v3:
- No change
v1->v2:
- New
[2] support will be provided in separate patches.
[0] https://tools.ietf.org/html/draft-smith-vxlan-group-policy
[1] https://github.com/tgraf/iproute2/tree/vxlan-gbp
[2] https://github.com/tgraf/ovs/tree/vxlan-gbp
Thomas Graf (6):
vxlan: Allow for VXLAN extensions to be implemented
vxlan: Group Pol
implemented mutually exclusive.
Signed-off-by: Thomas Graf
---
v2->v3:
- No change
v1->v2:
- Addressed Jesse's request to transport VXLAN options as Netlink
attributes instead of a binary blob. Allows a partial transport of
VXLAN extensions. Internally, the datapath continues to u
this point.
Signed-off-by: Thomas Graf
---
v2->v3:
- No change
v1->v2:
- Improved commit message, reported by Jesse
drivers/net/vxlan.c | 35 +--
include/net/vxlan.h | 2 +-
net/openvswitch/vport-vxlan.c | 2 +-
3 files changed, 23
Also factors out Geneve validation code into a new separate function
validate_and_copy_geneve_opts().
A subsequent patch will introduce VXLAN options. Rename the existing
GENEVE_TUN_OPTS() to reflect its extended purpose of carrying generic
tunnel metadata options.
Signed-off-by: Thomas Graf
tf.org/html/draft-smith-vxlan-group-policy
[1] http://lwn.net/Articles/204905/
Signed-off-by: Thomas Graf
---
v2->v3:
- Removed empty struct vxlan_gbp as spotted by Alexei
v1->v2:
- split GBP header definition into separate struct vxlanhdr_gbp as requested
by Alexei
ve parsing behaviour by default but allows
these fields to be used by VXLAN extensions which are explicitly enabled
on the VXLAN socket respectively VXLAN net_device.
Signed-off-by: Thomas Graf
---
v2->v3:
- No change
v1->v2:
- No change
drivers/net/vxlan.c | 29 +++---
From: Amit Bose
Signed-off-by: Amit Bose
Signed-off-by: Thomas Graf
---
include/openvswitch/vconn.h | 4 ++--
lib/vconn-provider.h| 10 +-
lib/vconn.c | 34 +-
3 files changed, 24 insertions(+), 24 deletions(-)
diff --git a
On 01/12/15 at 11:23am, Jesse Gross wrote:
> On Mon, Jan 12, 2015 at 4:26 AM, Thomas Graf wrote:
> > diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> > index 4d52aa9..b148739 100644
> > --- a/drivers/net/vxlan.c
> > +++ b/drivers/net/vxlan.c
> > @@ -568,
On 01/12/15 at 02:50pm, Jesse Gross wrote:
> On Mon, Jan 12, 2015 at 2:47 PM, Thomas Graf wrote:
> > On 01/12/15 at 11:23am, Jesse Gross wrote:
> >> On Mon, Jan 12, 2015 at 4:26 AM, Thomas Graf wrote:
> >> > diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
On 01/12/15 at 01:38pm, Jesse Gross wrote:
> On Mon, Jan 12, 2015 at 4:26 AM, Thomas Graf wrote:
> > diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
> > index d1eecf7..8980d32 100644
> > --- a/net/openvswitch/flow_netlink.c
> > +++ b/net
On 01/12/15 at 11:41am, Jesse Gross wrote:
> On Mon, Jan 12, 2015 at 4:26 AM, Thomas Graf wrote:
> > + [OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS] = { .len = OVS_ATTR_NESTED },
> > +};
>
> Geneve isn't really nested - maybe we should break it out into a
> separat
On 01/12/15 at 01:54pm, Jesse Gross wrote:
> On Mon, Jan 12, 2015 at 4:26 AM, Thomas Graf wrote:
> > + if (tb[OVS_VXLAN_EXT_MAX])
> > + opts.gbp = nla_get_u32(tb[OVS_VXLAN_EXT_MAX]);
>
> Shouldn't this be OVS_VXLAN_EXT_GBP instead of OVS_VXLAN_EXT_
On 01/12/15 at 10:14am, Tom Herbert wrote:
> > diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
> > index f7d0d2d..9f07bf5 100644
> > --- a/include/uapi/linux/if_link.h
> > +++ b/include/uapi/linux/if_link.h
> > @@ -370,10 +370,18 @@ enum {
> > IFLA_VXLAN_UDP_CSUM,
>
On 01/12/15 at 06:37pm, Nicolas Dichtel wrote:
> >+if (data[IFLA_VXLAN_EXTENSION])
> >+configure_vxlan_exts(vxlan, data[IFLA_VXLAN_EXTENSION]);
> >+
> Can you also update vxlan_fill_info() so that these new attributes can be
> dumped via netlink?
Sure, will do.
On 01/12/15 at 06:28pm, Tom Herbert wrote:
> On Mon, Jan 12, 2015 at 5:03 PM, Thomas Graf wrote:
> >>
> >> Creating a level of indirection for extensions seems overly
> >> complicated to me. Why not just define IFLA_VXLAN_GBP as just another
> >> enum above
On 01/12/15 at 07:41pm, Ben Pfaff wrote:
> This comes up from time to time.
>
> Signed-off-by: Ben Pfaff
Acked-by: Thomas Graf
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 01/12/15 at 07:54pm, Ben Pfaff wrote:
> On Mon, Jan 12, 2015 at 05:51:23PM +0100, Thomas Graf wrote:
> > From: Amit Bose
> >
> > Signed-off-by: Amit Bose
> > Signed-off-by: Thomas Graf
>
> Acked-by: Ben Pfaff
Thanks, pushed to master.
__
tf.org/html/draft-smith-vxlan-group-policy
[1] http://lwn.net/Articles/204905/
Signed-off-by: Thomas Graf
---
v3->v4:
- Patch 1 was no longer needed due to Tom Herbert's 3bf394 ("vxlan: Improve
support for header flags"). Moved remaining header description to this patch.
-
[2] support will be provided in separate patches.
[0] https://tools.ietf.org/html/draft-smith-vxlan-group-policy
[1] https://github.com/tgraf/iproute2/tree/vxlan-gbp
[2] https://github.com/tgraf/ovs/tree/vxlan-gbp
Thomas Graf (5):
vxlan: Group Policy extension
vxlan: Only bind to sockets with corr
Also factors out Geneve validation code into a new separate function
validate_geneve_opts().
A subsequent patch will introduce VXLAN options. Rename the existing
GENEVE_TUN_OPTS() to reflect its extended purpose of carrying generic
tunnel metadata options.
Signed-off-by: Thomas Graf
---
v3->
nlattr_set() is currently hardcoded to two levels of nesting. This change
introduces struct ovs_len_tbl to define minimal length requirements plus
next level nesting tables to traverse the key attributes to arbitrary depth.
Signed-off-by: Thomas Graf
---
v3->v4:
- No change. The spotted bug
this point.
Signed-off-by: Thomas Graf
---
v3->v4:
- No change
v2->v3:
- No change
v1->v2:
- Improved commit message, reported by Jesse
drivers/net/vxlan.c | 35 +--
include/net/vxlan.h | 2 +-
net/openvswitch/vport-vxlan.c |
implemented mutually exclusive.
Signed-off-by: Thomas Graf
---
v3->v4:
- Fixed OVS_VXLAN_EXT_MAX->OVS_VXLAN_EXT_GBP typo as spotted by Jesse
- Only applied tunnel options if they are of the right type as
suggested by Jesse
v2->v3:
- No change
v1->v2:
- Addressed Jesse's request t
On 01/12/15 at 10:55am, Jesse Gross wrote:
> There are at least two parts to this:
> * Calculating the right MTU for the guest device.
> * Transferring the MTU from the host to the guest.
>
> The first would presumably involve exposing some kind of API that the
> component that does know the rig
On 01/13/15 at 11:29am, Ben Pfaff wrote:
> Open Virtual Network (OVN) Proposed Architecture
>
>
> The Open vSwitch team is pleased to announce OVN, a new subproject in
> development within the Open vSwitch. The full project announcement is
> at Net
On 01/13/15 at 02:15pm, Jesse Gross wrote:
> On Mon, Jan 12, 2015 at 5:02 PM, Thomas Graf wrote:
> > What about if we only apply tun_info->options on Geneve if
> > TUNNEL_GENEVE_OPT is set and vice versa?
>
> That seems nice and simple to me.
Great! I have implemented
Copying ovs-dev mailing list and thus qutoing full message.
On 01/14/15 at 01:14pm, Sander Eikelenboom wrote:
> Hi,
>
> I was testing 3.19-rc4 with openvswitch and encountered the splat below.
What version of OVS are you using? Did this work properly with rc3 or
an older kernel?
> #addr2line -e
On 01/14/15 at 02:03pm, Florian Westphal wrote:
> Thomas Graf wrote:
> > Copying ovs-dev mailing list and thus qutoing full message.
> >
> > On 01/14/15 at 01:14pm, Sander Eikelenboom wrote:
> > > Hi,
> > >
> > > I was testing 3.19-rc4
to grow the range of accepted packet attributes
while maintaining to be binary compatible with existing OVS binaries.
Fixes: 05da589 ("openvswitch: Add support for OVS_FLOW_ATTR_PROBE.")
Reported-by: Sander Eikelenboom
Tracked-down-by: Florian Westphal
Signed-off-by: Thomas Graf
---
to grow the range of accepted packet attributes
while maintaining binary compatibility with existing OVS binaries.
Fixes: 9233ce ("datapath: Add support for OVS_FLOW_ATTR_PROBE.")
Reported-by: Sander Eikelenboom
Signed-off-by: Thomas Graf
---
AUTHORS
On 01/14/15 at 04:21pm, Jorge Nevado wrote:
> Linux cots506 3.12.28-4-default #1 SMP Thu Sep 25 17:02:34 UTC 2014 (9879bd4)
> x86_64 x86_64 x86_64 GNU/Linux
>
> We saw on another post that this situation can happen with kernel 3.14:
> http://openvswitch.org/pipermail/dev/2014-February/036401.html
On 01/14/15 at 03:37pm, David Miller wrote:
> From: Thomas Graf
> Date: Tue, 13 Jan 2015 17:20:41 +0100
>
> > Implements supports for the Group Policy VXLAN extension [0] to provide
> > a lightweight and simple security label mechanism across network peers
> > b
On 01/14/15 at 12:41pm, Jesse Gross wrote:
> On Wed, Jan 14, 2015 at 9:21 AM, Thomas Graf wrote:
> > User space is currently sending a OVS_FLOW_ATTR_PROBE for both flow
> > and packet messages. This leads to an out-of-bounds access in
> > ovs_packet_cmd_execute() becaus
On 01/14/15 at 03:25pm, Jesse Gross wrote:
> On Wed, Jan 14, 2015 at 3:18 PM, Thomas Graf wrote:
> > Thanks! Pushed to master.
>
> I think probably branch-2.3 would be a good idea as well?
Had the same thought. Then noticed that 2.3 doesn't ha
Also factors out Geneve validation code into a new separate function
validate_and_copy_geneve_opts().
A subsequent patch will introduce VXLAN options. Rename the existing
GENEVE_TUN_OPTS() to reflect its extended purpose of carrying generic
tunnel metadata options.
Signed-off-by: Thomas Graf
implemented mutually exclusive.
Signed-off-by: Thomas Graf
---
v4->v5:
- No change
v3->v4:
- Fixed OVS_VXLAN_EXT_MAX->OVS_VXLAN_EXT_GBP typo as spotted by Jesse
- Only applied tunnel options if they are of the right type as
suggested by Jesse
v2->v3:
- No change
v1->v2:
- Ad
nlattr_set() is currently hardcoded to two levels of nesting. This change
introduces struct ovs_len_tbl to define minimal length requirements plus
next level nesting tables to traverse the key attributes to arbitrary depth.
Signed-off-by: Thomas Graf
---
v4->v5:
- No change
v3->v4:
- No
[2] support will be provided in separate patches.
[0] https://tools.ietf.org/html/draft-smith-vxlan-group-policy
[1] https://github.com/tgraf/iproute2/tree/vxlan-gbp
[2] https://github.com/tgraf/ovs/tree/vxlan-gbp
Thomas Graf (5):
vxlan: Group Policy extension
vxlan: Only bind to sockets with corr
this point.
Signed-off-by: Thomas Graf
---
v4->v5:
- No change
v3->v4:
- No change
v2->v3:
- No change
v1->v2:
- Improved commit message, reported by Jesse
drivers/net/vxlan.c | 35 +--
include/net/vxlan.h | 2 +-
net/openvswi
tf.org/html/draft-smith-vxlan-group-policy
[1] http://lwn.net/Articles/204905/
Signed-off-by: Thomas Graf
---
v4->v5:
- Rebased on top of Tom's RCO work
- Dropped IFLA_VXLAN_EXTENSION container attribute and embedded IFLA_VXLAN_GBP
as top level VXLAN attribute like RCO for consistency.
v3
On 01/14/15 at 04:18pm, Tom Herbert wrote:
> > diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> > index 99df0d7..06f7196 100644
> > --- a/drivers/net/vxlan.c
> > +++ b/drivers/net/vxlan.c
> > @@ -126,6 +126,7 @@ struct vxlan_dev {
> > __u8 tos; /* TOS override
On 01/14/15 at 05:08pm, Tom Herbert wrote:
> On Wed, Jan 14, 2015 at 4:23 PM, Thomas Graf wrote:
> > Because we need to compare enabled extensions in vxlan_find_sock() to
> > make sure we are not sharing a VXLAN socket with extensions enabled
> > with a user which d
nlattr_set() is currently hardcoded to two levels of nesting. This change
introduces struct ovs_len_tbl to define minimal length requirements plus
next level nesting tables to traverse the key attributes to arbitrary depth.
Signed-off-by: Thomas Graf
---
v5->v6:
- No change
v4->v5:
- No
extensions at this point.
Signed-off-by: Thomas Graf
---
v5->v6:
- Keep sharing logic but base it off unsharable flags instead of exts
member as suggested by Tom
v4->v5:
- No change
v3->v4:
- No change
v2->v3:
- No change
v1->v2:
- Improved commit message, reported by Jesse
driv
tf.org/html/draft-smith-vxlan-group-policy
[1] http://lwn.net/Articles/204905/
Signed-off-by: Thomas Graf
---
v5->v6:
- Use flags instead of exts member to store enablement of GBP as suggested
by Tom
v4->v5:
- Rebased on top of Tom's RCO work
- Dropped IFLA_VXLAN_EXTENSION contain
Also factors out Geneve validation code into a new separate function
validate_and_copy_geneve_opts().
A subsequent patch will introduce VXLAN options. Rename the existing
GENEVE_TUN_OPTS() to reflect its extended purpose of carrying generic
tunnel metadata options.
Signed-off-by: Thomas Graf
[2] support will be provided in separate patches.
[0] https://tools.ietf.org/html/draft-smith-vxlan-group-policy
[1] https://github.com/tgraf/iproute2/tree/vxlan-gbp
[2] https://github.com/tgraf/ovs/tree/vxlan-gbp
Thomas Graf (5):
vxlan: Group Policy extension
vxlan: Only bind to sockets w
implemented mutually exclusive.
Signed-off-by: Thomas Graf
---
v5->v6:
- No change
v4->v5:
- No change
v3->v4:
- Fixed OVS_VXLAN_EXT_MAX->OVS_VXLAN_EXT_GBP typo as spotted by Jesse
- Only applied tunnel options if they are of the right type as
suggested by Jesse
v2->v3:
- N
On 01/15/15 at 01:28am, Thomas Graf wrote:
> What exactly is the problem of having a distinct bitmap used by
> extensions? It is the least error prone method because it's clear that
> all extensions must match and we don't have to maintain an additional
> bitmask which
On 01/14/15 at 07:06pm, Tom Herbert wrote:
> > +struct vxlan_metadata {
> > + __be32 vni;
> > + u32 gbp;
>
> Should this be __be32 also and use ntohl/htonl when setting to/from skb->mark?
The bitmask is stored in host byte order in vxlan_metadata to be
compatible
On 01/15/15 at 03:36pm, YAMAMOTO Takashi wrote:
> > On Thu, Jan 15, 2015 at 10:38:45AM +0900, YAMAMOTO Takashi wrote:
> >> > ovn-controller
> >> > --
> >>
> >> neutron "ofagent" agent has a similar design to ovn-controller.
> >> you might be able to reuse at least some of code if pytho
601 - 700 of 1023 matches
Mail list logo
