[ovs-dev] [PATCH 0/3] vswitchd: New error column in Interface table to store error condition

2014-04-10 Thread Thomas Graf
An ofport value of -1 already indicates an error occured during configuration but does not provide any details. The now introduced error column allows storing a human readable error string for every failed Interface object. Thomas Graf (3): vlog: Provide convenience macros to additionally store

[ovs-dev] [PATCH 2/3] vswitchd: Add error column to Interface table to store error condition

2014-04-10 Thread Thomas Graf
high level error messages when opening and configuring the netdev are used. Further patches can extend passing the error pointer into the individual netdev implementations to allow for more fine grained error messages to be stored. Signed-off-by: Thomas Graf --- lib/netdev.c

Re: [ovs-dev] [PATCH v2 3/3] datapath: add layer 3 flow/port support

2014-04-11 Thread Thomas Graf
On 03/20/2014 12:37 PM, Lori Jakab wrote: +static int push_eth(struct sk_buff *skb, const struct ovs_action_push_eth *ethh) +{ + int err; + + skb_push(skb, ETH_HLEN); + skb_reset_mac_header(skb); + + err = set_eth_addr(skb, ðh->addresses); + if (unlikely(err)) +

Re: [ovs-dev] [PATCH 2/4] datapath: Add flow mask cache.

2014-04-14 Thread Thomas Graf
On 04/14/2014 08:54 AM, Pravin Shelar wrote: On Wed, Apr 9, 2014 at 4:05 PM, Thomas Graf wrote: I believe skb_get_hash() can be 0 and that would result in mistaking any empty slot to be a cached entry and we would only look at the first flow mask. software skb_get_hash() returns zero for

Re: [ovs-dev] [PATCH 2/4] datapath: Add flow mask cache.

2014-04-14 Thread Thomas Graf
On 04/14/2014 05:59 PM, Pravin Shelar wrote: On Mon, Apr 14, 2014 at 8:19 PM, Thomas Graf wrote: On 04/14/2014 08:54 AM, Pravin Shelar wrote: On Wed, Apr 9, 2014 at 4:05 PM, Thomas Graf wrote: I believe skb_get_hash() can be 0 and that would result in mistaking any empty slot to be a

Re: [ovs-dev] [PATCH V3] Add support for 802.1ad (qinq)

2014-04-14 Thread Thomas Graf
On 04/12/2014 10:09 PM, Thomas F Herbert wrote: diff --git a/lib/packets.c b/lib/packets.c index 6244c3f..385da79 100644 --- a/lib/packets.c +++ b/lib/packets.c @@ -198,8 +198,9 @@ eth_pop_vlan(struct ofpbuf *packet) { struct vlan_eth_header *veh = ofpbuf_l2(packet); -if (veh && ofpb

Re: [ovs-dev] [recirculation 2/3] datapath: add hash action

2014-04-14 Thread Thomas Graf
low.h |2 ++ datapath/flow_netlink.c | 29 - 3 files changed, 49 insertions(+), 1 deletion(-) LGTM otherwise Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 0/2] Minimal version and util headers for library usage

2014-11-24 Thread Thomas Graf
Thomas Graf (2): lib: Add new header to versioning info lib: Add API to set program name and version configure.ac | 1 + include/openvswitch/.gitignore | 1 + include/openvswitch/automake.mk | 4 +++- include/openvswitch/util.h | 31

[ovs-dev] [PATCH 2/2] lib: Add API to set program name and version

2014-11-24 Thread Thomas Graf
Required to have reasonable logging messages. Signed-off-by: Thomas Graf --- include/openvswitch/automake.mk | 1 + include/openvswitch/util.h | 31 +++ lib/unixctl.c | 2 +- lib/util.c | 17 + lib/util.h

[ovs-dev] [PATCH 1/2] lib: Add new header to versioning info

2014-11-24 Thread Thomas Graf
: Thomas Graf --- configure.ac | 1 + include/openvswitch/.gitignore | 1 + include/openvswitch/automake.mk | 3 ++- include/openvswitch/version.h.in | 28 4 files changed, 32 insertions(+), 1 deletion(-) create mode 100644 include/openvswitch

Re: [ovs-dev] [PATCH] datapath/linux: add KCFLAGS var to modules Makefile.main.in

2014-11-25 Thread Thomas Graf
On 11/25/14 at 07:47am, Ben Pfaff wrote: > On Tue, Oct 28, 2014 at 07:51:16AM -0700, Ben Pfaff wrote: > > From: Alexandru Ardelean > > > > This is mostly required because of GCC 4.9 which seems > > to error out with: > > openvswitch/datapath/linux/datapath.c:2108:10: > >error: macro "DA

Re: [ovs-dev] [PATCH] Makefile: Add static check for misuse of LITTLE_ENDIAN and BIG_ENDIAN.

2014-11-25 Thread Thomas Graf
On 11/04/14 at 11:42am, Ben Pfaff wrote: > I've pointed out two misuses of these macros in review in the last week, > by different authors. It's time to make it difficult to screw this up. > > Signed-off-by: Ben Pfaff > --- > Makefile.am | 17 + > 1 file changed, 17 insertions

Re: [ovs-dev] [PATCH] Makefile: Add static check for misuse of LITTLE_ENDIAN and BIG_ENDIAN.

2014-11-25 Thread Thomas Graf
On 11/25/14 at 05:19pm, Thomas Graf wrote: > On 11/04/14 at 11:42am, Ben Pfaff wrote: > > I've pointed out two misuses of these macros in review in the last week, > > by different authors. It's time to make it difficult to screw this up. > > > > Signed-off

Re: [ovs-dev] [PATCH] ovs-vsctl: Prevent creating duplicate VLAN bridges.

2014-11-25 Thread Thomas Graf
ut until now ovs-vsctl did not prevent creating duplicates or > report them. This commit fixes the problem. > > Reported-by: rwxybh > Reported-at: https://github.com/openvswitch/ovs/issues/21 > Signed-off-by: Ben Pfaff Acked-by: Thomas Graf ___

[ovs-dev] [PATCH] datapath: Use ccflags-y instead of deprecated EXTRA_CFLAGS

2014-11-26 Thread Thomas Graf
This allows users to pass in additional compiler flags through the environment variable EXTRA_CFLAGS, e.g. make EXTRA_CFLAGS=-Wno-error=foo V=1 Reported-by: Alexandru Ardelean Signed-off-by: Thomas Graf --- datapath/linux/Kbuild.in | 10 +- 1 file changed, 5 insertions(+), 5

Re: [ovs-dev] [PATCH] datapath/linux: add KCFLAGS var to modules Makefile.main.in

2014-11-26 Thread Thomas Graf
On 11/26/14 at 03:54pm, Alexandru Ardelean wrote: > Back with some findings. > > Could you please take a look at this Makefile ? > https://github.com/openwrt/packages/blob/master/net/openvswitch/Makefile > > This is our package file that wraps the OpenWRT build system around > OpenVSwitch. > Star

[ovs-dev] [PATCH] travis: Extended kernel build matrix

2014-11-27 Thread Thomas Graf
When doing test builds, build against the following kernels: - KERNEL=3.17.4 - KERNEL=3.16.7 - KERNEL=3.14.25 - KERNEL=3.12.33 - KERNEL=3.10.61 - KERNEL=3.4.104 - KERNEL=2.6.32.64 Signed-off-by: Thomas Graf --- .travis.yml | 12 +--- .travis/build.sh | 30

Re: [ovs-dev] [PATCH] datapath: Use ccflags-y instead of deprecated EXTRA_CFLAGS

2014-11-27 Thread Thomas Graf
On 11/26/14 at 12:07pm, Ben Pfaff wrote: > On Wed, Nov 26, 2014 at 03:52:31PM +0100, Thomas Graf wrote: > > This allows users to pass in additional compiler flags through the > > environment variable EXTRA_CFLAGS, e.g. > > > >make EXTRA_CFLAGS=-Wno-error=f

Re: [ovs-dev] [PATCH 1/3] ovs-testcontroller: Fix manpage .so command.

2014-11-27 Thread Thomas Graf
On 11/27/14 at 11:15am, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/3] docs: Add titles to documentation files that lacked them.

2014-11-27 Thread Thomas Graf
Missing S-O-B ;-) Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/3] dist-docs: New utility to generate a documentation bundle for the website.

2014-11-27 Thread Thomas Graf
with that program, but I suspect that it is somewhat different from the > GNU version.) > > The output of this program can already be viewed at: > http://openvswitch.org/support/dist-docs/ > > Signed-off-by: Ben Pfaff Nice Acked-by: Thomas Graf _

Re: [ovs-dev] [PATCH] travis: Extended kernel build matrix

2014-11-27 Thread Thomas Graf
On 11/27/14 at 08:58am, Ben Pfaff wrote: > On Thu, Nov 27, 2014 at 03:55:08PM +0100, Thomas Graf wrote: > > When doing test builds, build against the following kernels: > > - KERNEL=3.17.4 > > - KERNEL=3.16.7 > > - KERNEL=3.14.25 > > - KERNEL=3.12.33 >

[ovs-dev] [PATCH] classifier: Silence sparse warning (sparse bug)

2014-11-28 Thread Thomas Graf
-by: Thomas Graf --- lib/classifier-private.h | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/classifier-private.h b/lib/classifier-private.h index 2fd9411..2522e91 100644 --- a/lib/classifier-private.h +++ b/lib/classifier-private.h @@ -176,12 +176,13

[ovs-dev] [PATCH v2] travis: Extended kernel build matrix

2014-11-28 Thread Thomas Graf
When doing test builds, build against the following kernels: - KERNEL=3.17.4 - KERNEL=3.16.7 - KERNEL=3.14.25 - KERNEL=3.12.33 - KERNEL=3.10.61 - KERNEL=3.4.104 - KERNEL=2.6.32.64 When doing pure kernel test builds, skip compilation of user space bits. Signed-off-by: Thomas Graf

[ovs-dev] [PATCH] travis: Only run testsuite for gcc builds

2014-11-28 Thread Thomas Graf
This reduces the total travis build time significantly. Signed-off-by: Thomas Graf --- .travis/build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis/build.sh b/.travis/build.sh index 6e99c63..990d263 100755 --- a/.travis/build.sh +++ b/.travis/build.sh @@ -80,7

Re: [ovs-dev] [PATCH] travis: Only run testsuite for gcc builds

2014-11-28 Thread Thomas Graf
On 11/28/14 at 11:01am, Flavio Leitner wrote: > On Fri, Nov 28, 2014 at 01:50:02PM +0100, Thomas Graf wrote: > > This reduces the total travis build time significantly. > > > > Signed-off-by: Thomas Graf > > --- > > .travis/build.sh | 2 +- > > 1 f

Re: [ovs-dev] [PATCH] travis: Only run testsuite for gcc builds

2014-11-28 Thread Thomas Graf
On 11/28/14 at 03:58pm, Flavio Leitner wrote: > I don't know travis but I suspect there is no way to pass > extra options like compile this time with gcc and another > time with clang. We could make it depend on $(expr $RANDOM % 2) ;-) ___ dev mailing li

Re: [ovs-dev] [PATCH net] gso: do GSO for local skb with size bigger than MTU

2014-12-01 Thread Thomas Graf
On 11/30/14 at 10:08am, Du, Fan wrote: > >-Original Message- > >From: Jason Wang [mailto:jasow...@redhat.com] > >Sent: Friday, November 28, 2014 3:02 PM > >To: Du, Fan > >Cc: net...@vger.kernel.org; da...@davemloft.net; f...@strlen.de; Du, Fan > >Subject: Re: [PATCH net] gso: do GSO for loc

Re: [ovs-dev] [PATCH net] gso: do GSO for local skb with size bigger than MTU

2014-12-02 Thread Thomas Graf
On 12/02/14 at 01:48pm, Flavio Leitner wrote: > What about containers or any other virtualization environment that > doesn't use Virtio? The host can dictate the MTU in that case for both veth or OVS internal which would be primary container plumbing techniques. ivshmem would need it's own fix. _

Re: [ovs-dev] [PATCH net] gso: do GSO for local skb with size bigger than MTU

2014-12-02 Thread Thomas Graf
On 12/02/14 at 07:34pm, Michael S. Tsirkin wrote: > On Tue, Dec 02, 2014 at 05:09:27PM +0000, Thomas Graf wrote: > > On 12/02/14 at 01:48pm, Flavio Leitner wrote: > > > What about containers or any other virtualization environment that > > > doesn't use Virtio? &

[ovs-dev] [PATCH] doc: Fix up markdown syntax in tutorial/Tutorial.md

2014-12-03 Thread Thomas Graf
Signed-off-by: Thomas Graf --- tutorial/Tutorial.md | 177 ++- 1 file changed, 89 insertions(+), 88 deletions(-) diff --git a/tutorial/Tutorial.md b/tutorial/Tutorial.md index 0cf52fb..d6a963b 100644 --- a/tutorial/Tutorial.md +++ b/tutorial

[ovs-dev] [PATCH 1/4] datapath: Check if nla_is_last() is available in

2014-12-03 Thread Thomas Graf
nla_is_last() is not available in 3.18, it's only in net-next. Convert to grep based to check to account for distribution backports. Fixes: 684b5f ("datapath: Rename last_action() as nla_is_last() and move to netlink.h") Signed-off-by: Thomas Graf --

[ovs-dev] [PATCH 0/4] datapath: Compatibility to 3.18+

2014-12-03 Thread Thomas Graf
Fixes compilation of datapath for both current net and net-next tree. Thomas Graf (4): datapath: Check if nla_is_last() is available in datapath: Mark compatible with kernels up to 3.18.x datapath: Account for rename to vlan_insert_tag_set_proto() datapath: Account for already defined

[ovs-dev] [PATCH 2/4] datapath: Mark compatible with kernels up to 3.18.x

2014-12-03 Thread Thomas Graf
Signed-off-by: Thomas Graf --- NEWS | 1 + acinclude.m4 | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 487b510..f2fceb5 100644 --- a/NEWS +++ b/NEWS @@ -52,6 +52,7 @@ Post-v2.3.0 - Added support for DPDK Tunneling. VXLAN and GRE are

[ovs-dev] [PATCH 3/4] datapath: Account for rename to vlan_insert_tag_set_proto()

2014-12-03 Thread Thomas Graf
__vlan_put_tag() was renamed to vlan_insert_tag_set_proto() with the argument list kept intact. Relates-to: 62749e ("vlan: rename __vlan_put_tag to vlan_insert_tag_set_proto") Signed-off-by: Thomas Graf --- acinclude.m4 | 1 + datapath

[ovs-dev] [PATCH 4/4] datapath: Account for already defined NETIF_F_GSO_ENCAP_ALL

2014-12-03 Thread Thomas Graf
Relates-to: f6eec614 ("openvswitch: Enable tunnel GSO for OVS bridge.") Signed-off-by: Thomas Graf --- datapath/linux/compat/include/linux/netdev_features.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/datapath/linux/compat/include/linux/netdev_features.h b/datapath/li

Re: [ovs-dev] [PATCH net] gso: do GSO for local skb with size bigger than MTU

2014-12-03 Thread Thomas Graf
On 12/03/14 at 11:38am, Jesse Gross wrote: > On Wed, Dec 3, 2014 at 10:38 AM, Michael S. Tsirkin wrote: > > Both approaches seem strange. You are sending 1 packet an hour to > > some destination behind 100 tunnels. Why would you want to > > cut down your MTU for all packets? On the other hand, > >

Re: [ovs-dev] [PATCH net] gso: do GSO for local skb with size bigger than MTU

2014-12-03 Thread Thomas Graf
On 12/03/14 at 02:51pm, Jesse Gross wrote: > My proposal would be something like this: > * For L2, reduce the VM MTU to the lowest common denominator on the segment. > * For L3, use path MTU discovery or fragment inner packet (i.e. > normal routing behavior). > * As a last resort (such as if usi

Re: [ovs-dev] [PATCH net] gso: do GSO for local skb with size bigger than MTU

2014-12-03 Thread Thomas Graf
On 12/03/14 at 04:54pm, Jesse Gross wrote: > I don't think that we actually need a bit. I would expect that ICMP > generation to be coupled with routing (although this requires being > able to know what the ultimate MTU is at the time of routing the inner > packet). If that's the case, you just nee

Re: [ovs-dev] [PATCH net] gso: do GSO for local skb with size bigger than MTU

2014-12-04 Thread Thomas Graf
On 12/03/14 at 05:51pm, Jesse Gross wrote: > I think it depends on where you put the PMTU check. If routing is > happening in OVS where it is decomposed in several discrete actions > like set MAC and decrement TTL then perhaps there is another explicit > action to check the MTU. If it is happening

Re: [ovs-dev] sync-up on conntrack/nfqueue/connmark

2014-12-05 Thread Thomas Graf
On Dec 5, 2014 6:14 PM, "Justin Pettit" wrote: > > [Moving to ovs-dev] > > > On Dec 5, 2014, at 4:41 AM, Thomas Graf wrote: > > > > I have a nfqueue action prototype ready. Waiting on conntrack to get merged. > > Great. As I mentioned, I think we&#

Re: [ovs-dev] [PATCH 1/3] ofp-actions: Update "copy_field" to latest OF1.5 draft.

2014-12-05 Thread Thomas Graf
refully and it looks spotless. Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/3] ofp-actions: Add support for ONF extension actions.

2014-12-05 Thread Thomas Graf
On 11/24/14 at 02:30pm, Ben Pfaff wrote: > Preparation for supporting ONFACT_ET_COPY_FIELD. > > ONF-JIRA: EXT-320 > Signed-off-by: Ben Pfaff Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/3] ofp-actions: Support "copy_field" ONF extension to OpenFlow 1.3.

2014-12-05 Thread Thomas Graf
On 11/24/14 at 02:30pm, Ben Pfaff wrote: > ONF-JIRA: EXT-320 > Signed-off-by: Ben Pfaff Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] sync-up on conntrack/nfqueue/connmark

2014-12-06 Thread Thomas Graf
On 12/05/14 at 04:06pm, Justin Pettit wrote: > On Dec 5, 2014, at 1:02 PM, Thomas Graf wrote: > > > Yes. I plan to send him an updated patch set to see what he thinks of > > > the interface that's there for conntrack and connmark. > > > > Excellent. Did

Re: [ovs-dev] OVS Kernel Datapath development

2014-12-08 Thread Thomas Graf
On 12/07/14 at 08:47pm, Pravin Shelar wrote: > Since the beginning OVS kernel datapath development is primarily done > on external OVS repo. Now we have mostly synced upstream and external > OVS. So we have decided to change this process. New process is as > follows. > > 1. OVS feature development

Re: [ovs-dev] [PATCH] include/openvswitch/util: Add extern "C" { ... }.

2014-12-08 Thread Thomas Graf
On 12/08/14 at 07:19pm, Ben Pfaff wrote: > Requested-by: Alan Shieh > Signed-off-by: Ben Pfaff Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 02/10] lib: Expose SOURCE_LOCATOR as OVS_SOURCE_LOACATOR

2014-12-09 Thread Thomas Graf
Required to expose headers which depend on SOURCE_LOCATOR Signed-off-by: Thomas Graf --- include/openvswitch/util.h | 8 lib/backtrace.h| 4 ++-- lib/hmap.h | 8 lib/latch.h| 2 +- lib/ovs-thread.h | 16

[ovs-dev] [PATCH 01/10] lib: Move compiler.h to

2014-12-09 Thread Thomas Graf
The following macros are renamed to avoid conflicts with other headers: * WARN_UNUSED_RESULT to OVS_WARN_UNUSED_RESULT * PRINTF_FORMAT to OVS_PRINTF_FORMAT * NO_RETURN to OVS_NO_RETURN Signed-off-by: Thomas Graf --- include/openvswitch/automake.mk | 1 + include/openvswitch/compiler.h

[ovs-dev] [PATCH 05/10] lib: Expose SAT_MUT as OVS_SAT_MUL in

2014-12-09 Thread Thomas Graf
Insted of exposing the full sat-math.h API, only the macros used in headers is exposed through Signed-off-by: Thomas Graf --- include/openvswitch/util.h | 6 ++ lib/sat-math.h | 8 ++-- lib/vlog.h | 2 +- 3 files changed, 9 insertions(+), 7 deletions

[ovs-dev] [PATCH 07/10] lib: Expose struct ovs_list definition in

2014-12-09 Thread Thomas Graf
Expose the struct ovs_list definition in . Keep the list access API private for now. Signed-off-by: Thomas Graf --- include/openvswitch/automake.mk | 1 + include/openvswitch/list.h | 27 +++ lib/list.h | 9 + 3 files changed, 29

[ovs-dev] [PATCH 00/10] Expose vlog and vconn in public headers

2014-12-09 Thread Thomas Graf
This series exposes the vlog and vconn API plus all required dependencies. The vconn is only partially usable at this point because ofpbuf cannot be exposed in its current state. A next series will start refactoring of ofpbuf. Thomas Graf (10): lib: Move compiler.h to lib: Expose

[ovs-dev] [PATCH 04/10] lib: Move token-bucket.h to

2014-12-09 Thread Thomas Graf
Signed-off-by: Thomas Graf --- include/openvswitch/automake.mk| 1 + include/openvswitch/token-bucket.h | 42 ++ lib/automake.mk| 1 - lib/token-bucket.c | 2 +- lib/token-bucket.h | 42

[ovs-dev] [PATCH 03/10] lib: Expose ovs_mutex and ovsthread_once in

2014-12-09 Thread Thomas Graf
This picks the ovs_mutex and ovsthread_once API from lib/ovs-thread.h and exposes it in . Signed-off-by: Thomas Graf --- include/openvswitch/automake.mk | 1 + include/openvswitch/thread.h| 137 lib/ovs-thread.h| 112

[ovs-dev] [PATCH 09/10] lib: Move vconn.h to

2014-12-09 Thread Thomas Graf
Also moves definitions for struct vconn and pvconn to the public header. The provider interface is kept private. Signed-off-by: Thomas Graf --- include/openvswitch/automake.mk | 1 + include/openvswitch/vconn.h | 113 lib/automake.mk

[ovs-dev] [PATCH 08/10] lib: Move vlog.h to

2014-12-09 Thread Thomas Graf
A new function vlog_insert_module() is introduced to avoid using list_insert() from the vlog.h header. Signed-off-by: Thomas Graf --- include/openvswitch/automake.mk | 3 +- include/openvswitch/vlog.h | 296 lib/automake.mk | 1

[ovs-dev] [PATCH 10/10] lib: Add test for library usage

2014-12-09 Thread Thomas Graf
This test covers inclusion of public header files and basic usage of the API such as vlog. Signed-off-by: Thomas Graf --- tests/.gitignore | 1 + tests/automake.mk | 6 tests/lib.at | 9 ++ tests/library.at | 4 +++ tests/test-lib.c | 94

Re: [ovs-dev] [PATCH 00/10] Expose vlog and vconn in public headers

2014-12-09 Thread Thomas Graf
On 12/10/14 at 01:29pm, YAMAMOTO Takashi wrote: > > This series exposes the vlog and vconn API plus all required dependencies. > > The vconn is only partially usable at this point because ofpbuf cannot > > be exposed in its current state. A next series will start refactoring of > > ofpbuf. > > can

Re: [ovs-dev] [PATCH 00/10] Expose vlog and vconn in public headers

2014-12-10 Thread Thomas Graf
On 12/10/14 at 02:05pm, YAMAMOTO Takashi wrote: > > On 12/10/14 at 01:29pm, YAMAMOTO Takashi wrote: > >> can you explain your motivation briefly? > > > > The motivation is to end up with a set of header files that have > > clean namespaces so they can be installed on the system and be > > used in

Re: [ovs-dev] [PATCH 0/4] datapath: Compatibility to 3.18+

2014-12-10 Thread Thomas Graf
On 12/09/14 at 05:12pm, Pravin Shelar wrote: > On Wed, Dec 3, 2014 at 4:02 AM, Thomas Graf wrote: > > Fixes compilation of datapath for both current net and net-next tree. > > > > Thomas Graf (4): > > datapath: Check if nla_is_last() is available in > > datap

Re: [ovs-dev] [PATCH 0/4] datapath: Compatibility to 3.18+

2014-12-10 Thread Thomas Graf
On 12/10/14 at 10:29am, Pravin Shelar wrote: > I was referring to vlan patch series merged to net-next ("sched: > introduce vlan action"). We should backport all relevant patches from > the series at once rather than one at a time. Thanks for the explanation. I understand what you mean now. I'll s

Re: [ovs-dev] [PATCH 03/10] lib: Expose ovs_mutex and ovsthread_once in

2014-12-15 Thread Thomas Graf
On 12/11/14 at 06:47pm, Ben Pfaff wrote: > On Tue, Dec 09, 2014 at 07:28:54PM +0100, Thomas Graf wrote: > > This picks the ovs_mutex and ovsthread_once API from lib/ovs-thread.h > > and exposes it in . > > > > Signed-off-by: Thomas Graf > > This adds a plain #

Re: [ovs-dev] [PATCH 07/10] lib: Expose struct ovs_list definition in

2014-12-15 Thread Thomas Graf
On 12/11/14 at 06:51pm, Ben Pfaff wrote: > On Tue, Dec 09, 2014 at 07:28:58PM +0100, Thomas Graf wrote: > > Expose the struct ovs_list definition in . Keep the > > list access API private for now. > > > > Signed-off-by: Thomas Graf > > Should we rename LIST_I

Re: [ovs-dev] [PATCH 00/10] Expose vlog and vconn in public headers

2014-12-15 Thread Thomas Graf
On 12/09/14 at 07:28pm, Thomas Graf wrote: > This series exposes the vlog and vconn API plus all required dependencies. > The vconn is only partially usable at this point because ofpbuf cannot > be exposed in its current state. A next series will start refactoring of > ofpbuf.

Re: [ovs-dev] [PATCH 1/3] ovs-docker: Enhance documentation to handle pre-programmed interfaces.

2014-12-15 Thread Thomas Graf
he same with containers. This commit > provides documentation on one way to achieve it. > > Signed-off-by: Gurucharan Shetty This would have been so much cleaner if the --net=netns: proposal wasn't closed. Acked-by: Thomas Graf __

Re: [ovs-dev] [PATCH 2/3] ovs-docker: Ability to set the default gateway.

2014-12-15 Thread Thomas Graf
le > utility instead of multiple utilities) > > Requested-by: Marvin Pascual > Signed-off-by: Gurucharan Shetty Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/3] ovs-docker: Add the ability to set VLANs.

2014-12-15 Thread Thomas Graf
On 12/12/14 at 01:56am, Gurucharan Shetty wrote: > @@ -155,6 +183,10 @@ Commands: > default gateway for the container. e.g.: > ${UTIL} add-port br-int eth1 c474a0e2830e 192.168.1.2/24 > \ > 192.168.1.1 > + add-vlan BRIDGE INTERFAC

Re: [ovs-dev] [PATCH v2] ovs-docker: Add the ability to set VLANs.

2014-12-15 Thread Thomas Graf
s instead of hypervisors. > > Signed-off-by: Gurucharan Shetty Looks great now. Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/2] route-table-bsd: Update vlog.h inclusion

2014-12-17 Thread Thomas Graf
On 12/17/14 at 08:59am, YAMAMOTO Takashi wrote: > This fixes a build failure introduced by the recent vlog change > commit e6211adce42c28453e0004c7a3e342a3d52bb97d. > ("lib: Move vlog.h to ") > > Signed-off-by: YAMAMOTO Takash

Re: [ovs-dev] [PATCH] revalidator: Don't delete non-existent flow.

2014-12-17 Thread Thomas Graf
off-by: Joe Stringer Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] OVS + BPF, make sense?

2014-12-22 Thread Thomas Graf
Thanks a lot for sharing these minutes. On 12/19/14 at 06:49pm, Andy Zhou wrote: > Possible use cases of BPF in OVS Linux kernel datapath > === > > [...] > > 4. Using BPF to implement overall OVS kernel module functionality > >Alexei likes this approach

[ovs-dev] [PATCH 0/7] Datapath backports to support 3.18.x, net, net-next

2014-12-29 Thread Thomas Graf
This series includes several backports which affect the datapath and brings it closer to upstream. It also allows to build the datapath against current net and net-next kernels. Thomas Graf (7): datapath: Account for rename to vlan_insert_tag_set_proto() datapath: vlan: introduce

[ovs-dev] [PATCH 1/7] datapath: Account for rename to vlan_insert_tag_set_proto()

2014-12-29 Thread Thomas Graf
__vlan_put_tag() was renamed to vlan_insert_tag_set_proto() with the argument list kept intact. Upstream: 62749e ("vlan: rename __vlan_put_tag to vlan_insert_tag_set_proto") Signed-off-by: Thomas Graf --- acinclude.m4 | 1 + datapath

[ovs-dev] [PATCH 3/7] datapath: move make_writable helper into common code

2014-12-29 Thread Thomas Graf
note that skb_make_writable already exists in net/netfilter/core.c but does something slightly different. Upstream: e219512 ("net: move make_writable helper into common code") Signed-off-by: Thomas Graf --- acinclude.m4 | 1 + datapath

[ovs-dev] [PATCH 4/7] datapath: move vlan pop/push functions into common code

2014-12-29 Thread Thomas Graf
8021AD tag to software. This is not a problem though as it preserves existing behaviour. Upstream: 93515d53 ("net: move vlan pop/push functions into common code") Signed-off-by: Thomas Graf --- acinclude.m4 | 2 + datapath/actions.c

[ovs-dev] [PATCH 5/7] datapath: introduce rtnl ops stub

2014-12-29 Thread Thomas Graf
This stub now allows userspace to see IFLA_INFO_KIND for ovs master and IFLA_INFO_SLAVE_KIND for slave. Upstream: 5b9e7e16 ("openvswitch: introduce rtnl ops stub") Signed-off-by: Thomas Graf --- datapath/datapath.c | 9 - datapath/vport-internal_

[ovs-dev] [PATCH 6/7] datapath: replace remaining users of arch_fast_hash with jhash

2014-12-29 Thread Thomas Graf
g/patch/418756/ Upstream: 8754589 ("net: replace remaining users of arch_fast_hash with jhash") Signed-off-by: Thomas Graf --- acinclude.m4 | 1 - datapath/flow_table.c | 4 +- datapath/linux/Modules.mk | 4 -

[ovs-dev] [PATCH 7/7] travis: Update build matrix to include latest stable kernels

2014-12-29 Thread Thomas Graf
Signed-off-by: Thomas Graf --- .travis.yml | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/.travis.yml b/.travis.yml index b91327d..67354c7 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,16 +7,17 @@ before_install: ./.travis/prepare.sh env: - OPTS

Re: [ovs-dev] [PATCH 0/7] Datapath backports to support 3.18.x, net, net-next

2014-12-30 Thread Thomas Graf
On 12/29/14 at 07:15pm, Pravin Shelar wrote: > On Mon, Dec 29, 2014 at 4:19 PM, Thomas Graf wrote: > > This series includes several backports which affect the datapath > > and brings it closer to upstream. It also allows to build the > > datapath against current net

Re: [ovs-dev] [PATCH] ofproto: Omit hidden tables from "next tables".

2015-01-02 Thread Thomas Graf
naldo A. Ferreira" > Signed-off-by: Ben Pfaff LGTM Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 0/7] Datapath backports to support 3.18.x, net, net-next

2015-01-02 Thread Thomas Graf
On 12/31/14 at 01:14pm, Pravin Shelar wrote: > I still do not see it. I'm resending the whole series as v2 with a changed commit message to work around the spam filter. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 1/8] datapath: Account for rename to vlan_insert_tag_set_proto()

2015-01-02 Thread Thomas Graf
__vlan_put_tag() was renamed to vlan_insert_tag_set_proto() with the argument list kept intact. Upstream: 62749e ("vlan: rename __vlan_put_tag to vlan_insert_tag_set_proto") Signed-off-by: Thomas Graf --- acinclude.m4 | 1 + datapath

[ovs-dev] [PATCH 0/7 v2] Datapath backports to support 3.18.x, net, net-next

2015-01-02 Thread Thomas Graf
This series includes several backports which affect the datapath and brings it closer to upstream. It also allows to build the datapath against current net and net-next kernels. v2: - Improved commit message of patch 2 - New patch to address arg changes to vxlan_sock_add() Thomas Graf (8

[ovs-dev] [PATCH 2/8] datapath: Add __vlan_insert_tag() compat helper if not available

2015-01-02 Thread Thomas Graf
;vlan: introduce __vlan_insert_tag helper which does not free skb") Signed-off-by: Thomas Graf --- acinclude.m4 | 2 ++ datapath/linux/compat/include/linux/if_vlan.h | 29 +++ 2 files changed, 31 insertions(+) diff --git a/acinclude.m4 b/acinc

[ovs-dev] [PATCH 3/8] datapath: move make_writable helper into common code

2015-01-02 Thread Thomas Graf
note that skb_make_writable already exists in net/netfilter/core.c but does something slightly different. Upstream: e219512 ("net: move make_writable helper into common code") Signed-off-by: Thomas Graf --- acinclude.m4 | 1 + datapath

[ovs-dev] [PATCH 4/8] datapath: move vlan pop/push functions into common code

2015-01-02 Thread Thomas Graf
8021AD tag to software. This is not a problem though as it preserves existing behaviour. Upstream: 93515d53 ("net: move vlan pop/push functions into common code") Signed-off-by: Thomas Graf --- acinclude.m4 | 2 + datapath/actions.c

[ovs-dev] [PATCH 5/8] datapath: introduce rtnl ops stub

2015-01-02 Thread Thomas Graf
This stub now allows userspace to see IFLA_INFO_KIND for ovs master and IFLA_INFO_SLAVE_KIND for slave. Upstream: 5b9e7e16 ("openvswitch: introduce rtnl ops stub") Signed-off-by: Thomas Graf --- datapath/datapath.c | 9 - datapath/vport-internal_

[ovs-dev] [PATCH 6/8] datapath: replace remaining users of arch_fast_hash with jhash

2015-01-02 Thread Thomas Graf
g/patch/418756/ Upstream: 8754589 ("net: replace remaining users of arch_fast_hash with jhash") Signed-off-by: Thomas Graf --- acinclude.m4 | 1 - datapath/flow_table.c | 4 +- datapath/linux/Modules.mk | 4 -

[ovs-dev] [PATCH 7/8] datapath: Account for new flags args of vxlan_sock_add()

2015-01-02 Thread Thomas Graf
s argument. Upstream: 359a0ea ("vxlan: Add support for UDP checksums (v4 sending, v6 zero csums)") Signed-off-by: Thomas Graf --- datapath/linux/compat/include/net/vxlan.h | 2 +- datapath/linux/compat/vxlan.c | 2 +- datapath/vport-vxlan.c| 2 +- 3 files c

[ovs-dev] [PATCH 8/8] travis: Update build matrix to include latest stable kernels

2015-01-02 Thread Thomas Graf
Signed-off-by: Thomas Graf --- .travis.yml | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/.travis.yml b/.travis.yml index b91327d..67354c7 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,16 +7,17 @@ before_install: ./.travis/prepare.sh env: - OPTS

Re: [ovs-dev] [PATCH net-next] openvswitch: Do not set skb ignore_df

2015-01-02 Thread Thomas Graf
On 01/02/15 at 03:03pm, Jesse Gross wrote: > On Fri, Jan 2, 2015 at 1:27 PM, Pravin B Shelar wrote: > > Tunnel transmit code clear this bit, so setting ignore_df has > > no effect. > > > > Signed-off-by: Pravin B Shelar > > Is it actually right for the bit to be cleared though? As discussed in >

Re: [ovs-dev] [PATCH RFC] SECURITY: New document describing proposed security process for OVS.

2015-01-02 Thread Thomas Graf
On 01/02/15 at 01:44pm, Ben Pfaff wrote: > Open vSwitch needs some kind of process for handling vulnerabilities. So > far, we've been pretty lucky that way, but it can't last forever, and I > think we'll be better off if we have at least the outline of an established > process whenever a significa

Re: [ovs-dev] [PATCH RFC] SECURITY: New document describing proposed security process for OVS.

2015-01-02 Thread Thomas Graf
On 01/02/15 at 03:01pm, Ben Pfaff wrote: > On Fri, Jan 02, 2015 at 11:53:26PM +0100, Thomas Graf wrote: > > Looks great. Do we want to include a couple of examples of what > > would classify as a vulnerability? > > Sure. Some that come randomly to mind: > >

Re: [ovs-dev] [PATCH] travis: support versioning of DPDK and options to specify git repo and tag

2015-01-03 Thread Thomas Graf
and DPDK_GIT to check out the tag "v$DPDK_VER" > from the git repository "$DPDK_GIT": > KERNEL=3.18 DPDK=1 DPDK_VER=1.7.1sp1 > DPDK_GIT=https://github.com/shushen/dpdk > > Signed-off-by: Shu Shen Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] travis: support versioning of DPDK and options to specify git repo and tag

2015-01-05 Thread Thomas Graf
On 01/04/15 at 11:20am, Ben Pfaff wrote: > On Sat, Jan 03, 2015 at 10:53:04AM +0100, Thomas Graf wrote: > > On 01/02/15 at 11:14pm, Shu Shen wrote: > > [...] > > > Signed-off-by: Shu Shen > > > > Acked-by: Thomas Graf > > Fine with me, do

[ovs-dev] [PATCH] vagrant: Provide basic Vagrantfile

2015-01-05 Thread Thomas Graf
Vagrantfile 3. Run `vagrant up` to create & provision the VM 4. Run `vagrant ssh` to log into the VM Signed-off-by: Thomas Graf --- .gitignore | 2 ++ INSTALL.md | 18 ++ Makefile.am| 3 ++- Vagrantfile.in | 30 ++ configure.ac

Re: [ovs-dev] [PATCH] vagrant: Provide basic Vagrantfile

2015-01-05 Thread Thomas Graf
On 01/05/15 at 09:41am, Kyle Mestery wrote: > Would it be useful to also have this run the OVS tests as a part of this > after installing and starting it? We could also make this use a local OVS > repository instead of pulling from master. In this way, this could be a > somewhat self contained vehi

Re: [ovs-dev] [PATCH] vagrant: Provide basic Vagrantfile

2015-01-05 Thread Thomas Graf
On 01/05/15 at 09:58am, Kyle Mestery wrote: > all of this can be added in future patches. > > Acked-by: Kyle Mestery Thanks for the review, pushed to master. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH RFC] SECURITY: New document describing proposed security process for OVS.

2015-01-05 Thread Thomas Graf
On 01/05/15 at 04:23pm, Jiri Benc wrote: > On Fri, 2 Jan 2015 17:57:14 -0800, Ben Pfaff wrote: > > 1) Consider provisions for ensuring privacy and integrity of > > communications around disclosure (eg, use PGP for all comms). > > That never hurts. I'd argue that's not strictly required tho

Re: [ovs-dev] [PATCH 1/8] datapath: Account for rename to vlan_insert_tag_set_proto()

2015-01-06 Thread Thomas Graf
On 01/06/15 at 01:46pm, Pravin Shelar wrote: > On Fri, Jan 2, 2015 at 10:35 AM, Thomas Graf wrote: > > __vlan_put_tag() was renamed to vlan_insert_tag_set_proto() with > > the argument list kept intact. > > > > Upstream: 62749e ("vlan: rename __vlan_put_tag t

<    1   2   3   4   5   6   7   8   9   10   >