Thanks for the comments Miguel. Responses inline.
Ian
> -Original Message-
> From: Miguel Angel Ajo Pelayo [mailto:majop...@redhat.com]
> Sent: Friday, April 15, 2016 9:32 AM
> To: Stokes, Ian
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v1 2/2] netdev-d
> -Original Message-
> From: Mauricio Vasquez B
> [mailto:mauricio.vasquezber...@studenti.polito.it]
> Sent: Friday, May 13, 2016 9:26 PM
> To: dev@openvswitch.org
> Cc: acon...@redhat.com; l...@cn.fujitsu.com; mchand...@suse.de; Stokes,
> Ian; f...@sysclose.org; Tra
Hi All,
Just a gentle reminder for any feedback on this patchset. If people do have
time to review I would really appreciate feedback relating to the use of RCU in
patch 2/2 netdev-dpdk.c: Add ingress-policing functionality.
Thanks
Ian
> -Original Message-
> From: dev [mailto:dev-boun.
Thanks for taking the time to review this Daniele, I will submit a new V3 this
evening with the required changes.
Thanks
Ian
From: Daniele Di Proietto [mailto:diproiet...@ovn.org]
Sent: Tuesday, May 24, 2016 1:42 AM
To: Stokes, Ian
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v2 2/2
> -Original Message-
> From: Daniele Di Proietto [mailto:diproiet...@vmware.com]
> Sent: Tuesday, May 24, 2016 9:39 PM
> To: Stokes, Ian
> Cc: dev@openvswitch.org
> Subject: Re: [PATCH v3 2/2] netdev-dpdk.c: Add ingress-policing
> functionality.
>
> Thanks for
> This patch sets *typep to an empty string instead of letting it
> uninitialized when no QoS configuration is set.
>
> It fixes the following vswitchd crash when no QoS has been set on vhost-
> user interface:
>
> $> ovs-appctl -t ovs-vswitchd qos/show vhost-user1
>
> #0 0x7efcbadf18d7 i
> If no QoS is configured, type value is likely to be an empty string.
>
> This is not an error though, so use the regular command reply function,
> not the error one.
>
> For example, before this patch:
> # ovs-appctl -t ovs-vswitchd qos/show vhost-user1
> QoS not configured on vhost-user1
>
From: Daniele Di Proietto [mailto:diproiet...@ovn.org]
Sent: Friday, August 05, 2016 2:15 AM
To: Stokes, Ian
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v1 1/1] netdev-dpdk: Fix egress policer error
detection bug.
Thanks for the patch, comments inline
2016-08-02 9:37 GMT-07:00 Ian
> On 08/10/2016 11:43 AM, Ilya Maximets wrote:
> > While using QoS with vHost interfaces 'netdev_dpdk_qos_run__()' will
> > free mbufs while executing 'netdev_dpdk_policer_run()'. After that
> > same mbufs will be freed at the end of '__netdev_dpdk_vhost_send()'
> > if 'may_steal == true'. This beh
Hi All,
Just a gentle reminder as regards this patch.
Bhanu has a new documentation patch for INSTALL.DPDK, maybe it should be added
as part of that?
Is there value in back porting this patch to OVS 2.5 though?
Thanks
Ian
> -Original Message-
> From: Stokes, Ian
> Sent: Tues
> -Original Message-
> From: Flavio Leitner [mailto:f...@sysclose.org]
> Sent: Tuesday, February 23, 2016 2:10 AM
> To: Stokes, Ian
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v4] netdev_dpdk.c: Add QoS functionality.
>
> On Fri, 19 Feb 2016 17:
> Hi Ian,
>
> We have gone through both your egress and ingress policing patches. And
> observed that both are two different approaches.
> Instead why don't we extend ingress policing patch to egress policing,
> as the ingress patch is in line with plain OVS kernel policing design.
>
> i.e, Can w
> From: Daniele Di Proietto [mailto:diproiet...@vmware.com]
> Sent: Tuesday, March 01, 2016 10:19 PM
> To: Stokes, Ian; dev@openvswitch.org
> Cc: f...@sysclose.org
> Subject: Re: [PATCH v4] netdev_dpdk.c: Add QoS functionality.
>
> Hi Ian,
>
> I have one comment an
> -Original Message-
> From: Daniele Di Proietto [mailto:diproiet...@vmware.com]
> Sent: Friday, March 04, 2016 12:19 AM
> To: Stokes, Ian
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk.c: Add ingress-
> policing functionality.
>
Hi Mauricio,
This patch is quite useful. Some minor comments inline. I've also tested the
patch and can confirm it works without issue.
Thanks
Ian
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Mauricio
> Vasquez B
> Sent: Monday, March 28, 2016 9:52
> > >71034a0..faf3583 100644
> > >--- a/lib/netdev-dpdk.c
> > >+++ b/lib/netdev-dpdk.c
> > >@@ -53,6 +53,7 @@
> > >
> > > #include "rte_config.h"
> > > #include "rte_mbuf.h"
> > >+#include "rte_meter.h"
> > > #include "rte_virtio_net.h"
> > >
> > > VLOG_DEFINE_THIS_MODULE(dpdk);
> > >@@ -193,6 +194
> -Original Message-
> From: Daniele Di Proietto [mailto:diproiet...@vmware.com]
> Sent: Friday, April 08, 2016 4:44 AM
> To: Stokes, Ian
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk.c: Add ingress-
> policing functionality.
>
> This patch introduces function 'netdev_dpdk_filter_packet_len()' which is
> intended to find and remove all packets with 'pkt_len > max_packet_len'
> from the Tx batch.
>
> It fixes inaccurate counting of 'tx_bytes' in vHost case if there was
> dropped packets and allows to simplify send functio
> 'netdev_dpdk_send__()' function can be greatly simplified by using
> recently introduced 'netdev_dpdk_filter_packet_len()'.
>
Thanks again Ilya, comments inline.
> Signed-off-by: Ilya Maximets
> ---
> lib/netdev-dpdk.c | 46 ++
> 1 file changed, 6 i
> This patch introduces function 'netdev_dpdk_filter_packet_len()' which is
> intended to find and remove all packets with 'pkt_len > max_packet_len'
> from the Tx batch.
>
> It fixes inaccurate counting of 'tx_bytes' in vHost case if there was
> dropped packets and allows to simplify send functio
> 'netdev_dpdk_send__()' function can be greatly simplified by using
> recently introduced 'netdev_dpdk_filter_packet_len()'.
>
> Signed-off-by: Ilya Maximets
> ---
> lib/netdev-dpdk.c | 46 ++
> 1 file changed, 6 insertions(+), 40 deletions(-)
>
Ac
> If NUMA information can't be derived from a vHost User device, only print
> an error if the VHOST_NUMA option is enabled in DPDK. Otherwise 'fail'
> silently.
>
> Fixes: 0a0f39df1d5a ("netdev-dpdk: Add support for DPDK 16.07")
> Signed-off-by: Ciara Loftus
> Reported-by: Ian Stokes
> ---
> a
Hi Kapil,
RSS based on IP is used for dispersing received packets among queues on the NIC
by default.
I haven’t looked into setting this up for specific packet types myself, maybe
someone else on the list can help with that point.
If you looking for a quick guide to test vhost multiqueue with
> qos_conf can be NULL. This can be easily reproduced by setting egress QoS
> on a port:
>
> ```
> ovs-vsctl set port dpdk2 qos=@newqos -- --id=@newqos create qos
> type=egress-policer other-config:cir=4600 other-config:cbs=2048 ```
>
> Reported-by: Ian Stokes
> Fixes: 78bd47cf44a5 ("netdev
> -Original Message-
> From: Gurucharan Shetty [mailto:shet...@nicira.com]
> Sent: Tuesday, June 23, 2015 3:49 PM
> To: dev@openvswitch.org
> Cc: Stokes, Ian; Gurucharan Shetty
> Subject: [PATCH] Add a few OVN files as part of DISTCLEANFILES.
>
> Reported-by: Ian
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di
> Proietto
> Sent: Thursday, July 16, 2015 7:48 PM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [PATCH 1/2] netdev-dpdk: Restore txq/rxq number if
> initialization fails.
>
> netdev_dpdk_set_mul
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di
> Proietto
> Sent: Thursday, July 16, 2015 7:48 PM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [PATCH 2/2] netdev-dpdk: Retry tx/rx queue setup
> until we don't get any failure.
>
> It has been
nal Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Stokes, Ian
> Sent: Friday, July 17, 2015 12:08 PM
> To: Daniele Di Proietto; dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Retry tx/rx queue setup
> until we don
I have re-tested the patch on a number of our systems with the
latest commit on master and I cannot reproduce the error you
mention below.
The only time I have seen that error occur would be if there was
no interface bound to igb_uio driver correctly before calling
"ovs-vsctl add-port br0 dpd
riginal Message-
> > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Luis E
> Pena
> > Sent: Friday, July 24, 2015 5:18 PM
> > To: Stokes, Ian
> > Cc: dev@openvswitch.org<mailto:dev@openvswitch.org>
> > Subject: Re: [ovs-dev] [PATCH
Hi all,
Just wondering what the status of this patch is? Is there any feedback
or queries we can answer to help?
Thanks
Ian
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Traynor,
> Kevin
> Sent: Thursday, July 23, 2015 11:28 AM
> To: Daniele Di Proiet
s
Ian
> -Original Message-
> From: Ethan Jackson [mailto:et...@nicira.com]
> Sent: Wednesday, July 29, 2015 10:13 PM
> To: Stokes, Ian
> Cc: Traynor, Kevin; Daniele Di Proietto; dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Retry tx/rx queue setup
> unti
ble then I can write up a note for theINSTALL.DPDK.md explaining
the issue.
Thanks
Ian
> -Original Message-
> From: Ben Pfaff [mailto:b...@nicira.com]
> Sent: Monday, August 03, 2015 6:11 PM
> To: Ethan Jackson
> Cc: Stokes, Ian; Justin Pettit; Pravin Shelar; Traynor, Kev
No problem,
I've sent a patch to the mailing list with these changes for INSTALL.DPDK.md.
Thanks
Ian
> -Original Message-
> From: Ethan Jackson [mailto:et...@nicira.com]
> Sent: Tuesday, August 04, 2015 10:46 PM
> To: Stokes, Ian
> Cc: Ben Pfaff; Justin Pettit; Pr
ali.bu...@wipro.com [mailto:ravali.bu...@wipro.com]
> Sent: Friday, January 29, 2016 9:22 AM
> To: Stokes, Ian; ravulakollu.ku...@wipro.com; dev@openvswitch.org
> Subject: RE: Does openvswitch with DPDK datapath supports QOS
>
> Hi all,
>
> We could extend the design of ingress poli
ginal Message-
> From: Stokes, Ian
> Sent: Monday, February 01, 2016 8:47 PM
> To: dev@openvswitch.org
> Cc: Stokes, Ian
> Subject: [PATCH v3] netdev_dpdk.c: Add QoS functionality.
>
> This patch provides the modifications required in netdev-dpdk.c and
> vswitch.xml to allo
> -Original Message-
> From: Daniele Di Proietto [mailto:diproiet...@vmware.com]
> Sent: Friday, February 05, 2016 9:45 PM
> To: Ben Pfaff; Stokes, Ian
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.
>
>
>
> -Original Message-
> From: Ben Pfaff [mailto:b...@ovn.org]
> Sent: Friday, February 05, 2016 9:19 PM
> To: Stokes, Ian
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.
>
> On Thu, Feb 04, 2016 at 09:30:59AM
Hi Ilya,
I've submitted a patch for this last week which is waiting on review if you'd
like to provide feedback for it
http://openvswitch.org/pipermail/dev/2016-February/065739.html
Thaks
Ian
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ilya
> Maxi
Thanks for the review Ilya, much appreciated, comments inline.
> Hi.
> There is one issue with patch itself:
> Applying: INSTALL.DPDK: Add notes regarding vhost multiq
> configuration.
> warning: 3 lines add whitespace errors.
>
Noted, I'll clean these up for the v2.
> And one comment
Thanks For the review Flavio, much appreciated, comments inline. I'll re-spin a
new version also.
> -Original Message-
> From: Flavio Leitner [mailto:f...@sysclose.org]
> Sent: Wednesday, February 10, 2016 7:55 PM
> To: Stokes, Ian
> Cc: dev@openvswitch.org
>
Thanks for the review Daniele, comments inline. Will re-spin another version.
> Thanks for the patch and the review.
>
> I agree with everything Flavio pointed out, a few more comments below
>
> On 10/02/2016 11:54, "Flavio Leitner" wrote:
>
> >On Mon, 1 Feb 2016 20:47:25 +
> >Ian Stokes
> On Thu, 11 Feb 2016 12:32:56 +
> "Stokes, Ian" wrote:
>
> > Thanks For the review Flavio, much appreciated, comments inline. I'll
> re-spin a new version also.
>
> Thank you for the patch!
> comments inline.
>
>
> >
> > >
> Hi, Ian.
> I prepared a fix for this problem here:
> http://openvswitch.org/pipermail/dev/2016-February/066066.html
>
> Maybe it will be better than note in documentation.
>
> Best regards, Ilya Maximets.
Thanks for the heads up on this Ilya, am I right in thinking this removes the
need to ca
> -Original Message-
> From: Flavio Leitner [mailto:f...@sysclose.org]
> Sent: Friday, February 12, 2016 1:37 AM
> To: Stokes, Ian
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v2] INSTALL.DPDK: Update details of XL710
> restrictions for DPDK 2.2.
>
> -Original Message-
> From: Flavio Leitner [mailto:f...@sysclose.org]
> Sent: Friday, February 12, 2016 1:47 AM
> To: Stokes, Ian
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] INSTALL.DPDK.md: Correct mergeable
> buffers parameter.
>
> On Wed,
> -Original Message-
> From: Flavio Leitner [mailto:f...@sysclose.org]
> Sent: Friday, February 12, 2016 4:58 AM
> To: Stokes, Ian
> Cc: dev@openvswitch.org; i.maxim...@samsung.com
> Subject: Re: [ovs-dev] [PATCH v2] INSTALL.DPDK: Add notes regarding
> vhost multiq c
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Stokes, Ian
> Sent: Thursday, February 11, 2016 2:42 PM
> To: Flavio Leitner
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.
>
&g
> On Wed, 17 Feb 2016 14:40:26 +
> "Stokes, Ian" wrote:
>
> > > -Original Message-
> > > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Stokes,
> > > Ian
> > > Sent: Thursday, February 11, 2016 2:42 PM
> > >
> -Original Message-
> From: Gurucharan Shetty [mailto:shet...@nicira.com]
> Sent: Thursday, April 23, 2015 3:22 PM
> To: dev@openvswitch.org
> Cc: Stokes, Ian; Gurucharan Shetty
> Subject: [PATCH] testsuite: Don't apply the testsuite.patch on non-
> Windows
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Stokes, Ian
> Sent: Thursday, April 23, 2015 4:51 PM
> To: Gurucharan Shetty; dev@openvswitch.org
> Cc: Gurucharan Shetty
> Subject: Re: [ovs-dev] [PATCH] testsuite: Don't apply t
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of lin
> Sent: Tuesday, March 17, 2015 8:59 AM
> To: Traynor, Kevin; dev@openvswitch.org
> Subject: Re: [ovs-dev] Some questions about DPDK+OVS
>
> Sorry, I shouldn't drop the mailing list.
>
> On Tue, Mar 1
Hi All,
Just wondering if anyone has had time to review this?
Any feedback would be much appreciated.
Thanks
Ian
> -Original Message-
> From: Stokes, Ian
> Sent: Wednesday, September 30, 2015 1:45 PM
> To: dev@openvswitch.org
> Cc: Stokes, Ian
> Subject: [PATCH] netd
Hi Daniele,
Thanks for providing feedback, answers inline.
> -Original Message-
> From: Daniele Di Proietto [mailto:diproiet...@vmware.com]
> Sent: Friday, October 09, 2015 6:53 PM
> To: Stokes, Ian
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] netd
> -Original Message-
> From: Ben Pfaff [mailto:b...@nicira.com]
> Sent: Tuesday, October 13, 2015 5:24 PM
> To: Stokes, Ian
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] netdev_dpdk.c: Add QoS functionality.
>
> On Wed, Sep 30, 2015 at 01:45:15PM
> -Original Message-
> From: Daniele Di Proietto [mailto:diproiet...@vmware.com]
> Sent: Tuesday, October 13, 2015 5:14 PM
> To: Stokes, Ian
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] netdev_dpdk.c: Add QoS functionality.
>
>
>
> On
Hi All,
Just wondering if anyone has input on v2 of the netdev-dpdk QoS patch?
Any feedback would be much appreciated.
Thanks
Ian
> -Original Message-
> From: Stokes, Ian
> Sent: Friday, October 16, 2015 2:28 PM
> To: dev@openvswitch.org
> Cc: Stokes, Ian
>
> -Original Message-
> From: Ben Pfaff [mailto:b...@nicira.com]
> Sent: Wednesday, November 04, 2015 3:55 AM
> To: Stokes, Ian
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v2] netdev_dpdk.c: Add QoS functionality.
>
> On Thu, Oct 22, 2015 at 09:29
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of
> ravulakollu.ku...@wipro.com
> Sent: Thursday, November 26, 2015 1:59 PM
> To: dev@openvswitch.org
> Subject: [ovs-dev] Does openvswitch with DPDK datapath supports QOS
>
> Hello all,
>
> Does openvswitc
> -Original Message-
> From: Flavio Leitner [mailto:f...@sysclose.org]
> Sent: Thursday, November 26, 2015 8:58 PM
> To: Stokes, Ian
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v2] netdev_dpdk.c: Add QoS functionality.
>
>
> Funny, everyone is try
60 matches
Mail list logo
