On Thu, Jun 02, 2016 at 03:01:47PM -0700, pravin shelar wrote:
> On Wed, Jun 1, 2016 at 11:24 PM, Simon Horman
> wrote:
> > * Set skb protocol based on contents of packet. I have observed this is
> > necessary to get actual protocol of a packet when it is injected into an
>
On Tue, Jun 07, 2016 at 03:45:27PM -0700, pravin shelar wrote:
> On Mon, Jun 6, 2016 at 8:08 PM, Simon Horman
> wrote:
> > On Thu, Jun 02, 2016 at 03:01:47PM -0700, pravin shelar wrote:
> >> On Wed, Jun 1, 2016 at 11:24 PM, Simon Horman
> >> wrote:
> >> &g
On Tue, Jun 07, 2016 at 03:45:58PM -0700, pravin shelar wrote:
> On Mon, Jun 6, 2016 at 7:46 PM, Simon Horman
> wrote:
> > On Thu, Jun 02, 2016 at 03:02:18PM -0700, pravin shelar wrote:
> >> On Wed, Jun 1, 2016 at 11:24 PM, Simon Horman
> >> wrote:
[...]
>
[Cc Jiri Benc]
On Sat, Jun 18, 2016 at 06:38:54PM -0700, pravin shelar wrote:
> On Thu, Jun 16, 2016 at 10:53 PM, Simon Horman
> wrote:
> > On Tue, Jun 07, 2016 at 03:45:27PM -0700, pravin shelar wrote:
> >> On Mon, Jun 6, 2016 at 8:08 PM, Simon Horman
> >> wrot
On Tue, Jun 21, 2016 at 09:30:17AM -0700, pravin shelar wrote:
> On Mon, Jun 20, 2016 at 7:25 PM, Simon Horman
> wrote:
> > [Cc Jiri Benc]
> >
> > On Sat, Jun 18, 2016 at 06:38:54PM -0700, pravin shelar wrote:
> >> On Thu, Jun 16, 2016 at 10:53 PM, Simon Horman
&
On Wed, Jun 08, 2016 at 01:10:54PM -0700, Ben Pfaff wrote:
> On Wed, Jun 01, 2016 at 02:04:57PM +0900, Simon Horman wrote:
> > On Tue, May 31, 2016 at 08:20:24PM -0700, Ben Pfaff wrote:
> > > There's a change to tnl_port_show() to "Skip ports with duplicate 'port&#
ayer 3 flow and switching support
Simon Horman (1):
userspace: add non-tap (l3) support to GRE vports
build-aux/extract-ofp-fields | 1 +
datapath/linux/compat/include/linux/openvswitch.h | 17 ++
include/openvswitch/flow.h| 23 ++-
include/open
ions.
Added new prerequisite MFP_ETHERNET for fields MFF_ETH_SRC, MFF_ETH_DST,
MFF_VLAN_TCI, MFF_DL_VLAN, MFF_VLAN_VID and MFF_DL_VLAN_PCP.
L3 packets are differentiated from L2 packets by the
absence of the OVS_KEY_ATTR_ETHERNET attribute in the flow key.
Signed-off-by: Lorand Jakab
Signed-off-by: Simon
that this attribute is only used in userspace as there appears to
be no need for it to be used in the kernel datapath.
It is envisaged that this attribute may be used for other encapsulation
protocols that support both layer3 and layer2 inner-packets.
Signed-off-by: Simon Horman
---
v12
From: Lorand Jakab
These actions will allow L2->L3 and L3->L2 switching, and are supposed
to be added to flows installed in the datapath transparently by
ovs-vswitchd.
Signed-off-by: Lorand Jakab
Signed-off-by: Simon Horman
---
v12 [Simon Horman]
* Rebase
* Provide commit_ether_action(
mailing list as:
"[PATCH v12 0/3] userspace: Support for layer 3 encapsulated packets"
Lorand Jakab (1):
openvswitch: add layer 3 flow/port support
Simon Horman (5):
net: introduce skb_transport_header_was_set()
gre: unset mac header for non-TEB packets received by ip
unset rather than reset mach header for non-TEB packets received by an
ipgre device. This allows skb_transport_header_was_set to be subsequently
used to differentiate TEB and non-TEB packets recieved on an ipgre device.
Signed-off-by: Simon Horman
---
v11
* New patch
---
net/ipv4/ip_gre.c | 2
differentiate such packets from those with an Ethernet header.
Signed-off-by: Simon Horman
---
v11
* New patch
---
include/linux/skbuff.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 638b0e004310..669d63b038f6 100644
--- a/include
Allow push and pop mpls actions to act on layer 3 packets by teaching
them not to access non-existent L2 headers of such packets.
Signed-off-by: Simon Horman
---
v11
* group l2 code in pop_mpls()
v10
* Limit scope of hdr in {push,pop}_mpls()
v9
* New Patch
---
include/uapi/linux/openvswitch.h
This allows GRE tunnels to send and receive both
layer 2 packets (packets with an ethernet header) and
layer 3 packets (packets without an ethernet header).
Signed-off-by: Simon Horman
---
v11
* Make use of skb_mac_header_was_set() to avoid needing to calculate mac_len
v10
* Handle case of l3
implemented by a subsequent patch depends on protocol and
mac_len being set correctly on receive.
Signed-off-by: Simon Horman
---
v11
* Do not set mac_len.
Instead of relying on mac_len follow-up patches now
use skb_unset_mac_header()
v10
* Set mac_len
v9
* New patch
---
net/openvswitch
at is not supported in mainline Linux.
I (Simon) plan to follow up with support for non-TEB GRE ports based on
work by Thomas Morin.
Cc: Thomas Morin
Signed-off-by: Lorand Jakab
Signed-off-by: Simon Horman
---
v11 [Simon Horman]
* Consolidate setting of eth.key in key_extract.
* Limit scope o
On Thu, Jul 07, 2016 at 01:52:47PM -0700, pravin shelar wrote:
> On Wed, Jul 6, 2016 at 10:59 AM, Simon Horman
> wrote:
> > Allow push and pop mpls actions to act on layer 3 packets by teaching
> > them not to access non-existent L2 headers of such packets.
> >
> &g
gned-off-by: Liran Schour
Acked-by: Simon Horman
> ---
> ofproto/ofproto-dpif-xlate.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
> index 1977b6b..655033d 100644
> --- a/ofpro
On Tue, Feb 23, 2016 at 12:26:39AM -0300, Flavio Leitner wrote:
> Fixes: 981cbd52c942 ("ovs-bugtool: Create OVN plugin and add output.")
> Signed-off-by: Flavio Leitner
> ---
> rhel/openvswitch-fedora.spec.in | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Simo
On Mon, Feb 22, 2016 at 10:00:50AM -0800, Ben Pfaff wrote:
> compat.at mixes compatibility for m4sh, which is used by Autoconf and
> Autotest, with compatibility for Autotest. It makes more sense to separate
> them. This moves the Autotest-only compatibility macros into an Autotest
> specific fil
On Tue, Feb 23, 2016 at 10:06:34AM -0500, Russell Bryant wrote:
> On Tue, Feb 23, 2016 at 9:57 AM, Russell Bryant wrote:
>
> >
> > On Mon, Feb 22, 2016 at 10:26 PM, Flavio Leitner wrote:
> >
> >> Fixes: 981cbd52c942 ("ovs-bugtool: Create OVN plugin and add output.")
> >> Signed-off-by: Flavio Le
On Mon, Feb 22, 2016 at 04:03:59PM -0800, Jarno Rajahalme wrote:
> > On Jan 19, 2016, at 10:15 PM, Simon Horman
> > wrote:
> >
> > The motivation is to allow pushing single bytes in
> > a manner to that already used for 16, 32 and 64 bit integers.
> >
> &
On Mon, Feb 22, 2016 at 04:04:42PM -0800, Jarno Rajahalme wrote:
> > On Jan 19, 2016, at 10:15 PM, Simon Horman
> > wrote:
> >
> > Provide leading padding to allow pushing a value to a miniflow where
> > the value is not aligned to 64 bytes and no value has alrea
On Mon, Feb 29, 2016 at 10:17:56AM -0800, Ben Pfaff wrote:
> On Wed, Jan 20, 2016 at 03:14:59PM +0900, Simon Horman wrote:
> > This series implements support for layer 3 ports. By removing the
> > assumption that all packets/flows have Ethernet header, this series adds
> >
On Thu, Feb 25, 2016 at 08:29:53AM -0800, Ben Pfaff wrote:
> On Thu, Feb 25, 2016 at 10:26:28AM +0100, thomas.mo...@orange.com wrote:
> > Sorry to chime in a bit late, but this recirculation performance penalty for
> > the basic/key use-case where OVS receives an IP-in-MPLS frame and forwards
> > i
The bond structure is already zeroed as it is allocated
using xzalloc so there is no need to re-zero the recirc_id field.
Signed-off-by: Simon Horman
---
Found by inspection.
---
ofproto/bond.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/ofproto/bond.c b/ofproto/bond.c
index
; and 'flow del'
> path. The flow key remains mandatory when an action is provided.
>
> Signed-off-by: Samuel Gauthier
Reviewed-by: Simon Horman
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
From: Simon Horman
Currently output of MPLS packets on tunnel vports is not allowed by Open
vSwitch. This is because historically encapsulation was done in such a way
that the inner_protocol field of the skb needed to hold the inner protocol
for both MPLS and tunnel encapsulation in order for
On Tue, Mar 15, 2016 at 11:52:42AM +0900, Simon Horman wrote:
> From: Simon Horman
Sorry, I mixed up my own email address somehow.
I will repost.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
utput MPLS to tunnel vports.
Signed-off-by: Simon Horman
---
* Lightly tested with Geneve, GRE and VXLAN
* Reposted with my desired email for this work
---
net/openvswitch/flow_netlink.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow
On Wed, Mar 16, 2016 at 05:48:23PM +, Shuva Jyoti Kar wrote:
> Hello,
>
> I am trying deletion of an indirect group on ovs2.5 . Now when I try to
> delete the group using the group-id and group-type without the buckets the
> group-deletion fails with an error OFPGMFC_INVALID_GROUP
>
> The O
On Fri, Mar 18, 2016 at 09:45:08AM -0700, Jarno Rajahalme wrote:
> OpenFlow 1.5 spec says: “The group type need not be specified for the delete
> request.”
Thanks Jarno. What I am wondering at this point is what
omitting the group type looks like on the wire.
_
On Mon, Mar 21, 2016 at 10:44:19AM -0700, Jarno Rajahalme wrote:
>
> > On Mar 20, 2016, at 5:21 PM, Simon Horman
> > wrote:
> >
> > On Fri, Mar 18, 2016 at 09:45:08AM -0700, Jarno Rajahalme wrote:
> >> OpenFlow 1.5 spec says: “The group type need not be sp
On Tue, Mar 22, 2016 at 10:48:29AM -0700, Ben Pfaff wrote:
> On Tue, Mar 08, 2016 at 03:08:23PM +0900, Simon Horman wrote:
> > The bond structure is already zeroed as it is allocated
> > using xzalloc so there is no need to re-zero the recirc_id field.
> >
> >
> Best regards,
> Balazs
>
> -Original Message-
> From: discuss [mailto:discuss-boun...@openvswitch.org] On Behalf Of Simon
> Horman
> Sent: 22 March 2016 03:17
> To: Jarno Rajahalme
> Cc: dev@openvswitch.org; disc...@openvswitch.org
> Subject: Re: [ovs-disc
Hi Zoltánm
On Thu, Mar 24, 2016 at 08:28:53AM +, Zoltán Balogh wrote:
> Hi,
>
> The Debian Policy Manual
> (https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Version)
> says that the upstream_version may contain only alphanumerics and the
> characters . + - : ~ (full stop,
5
> > ovn/utilities/ovn-ctl.8
> > ovn/utilities/ovn-nbctl.8
> > ovn/utilities/ovn-sbctl.8
> > --
> > 2.5.5
> >
> >
> Note that this is completely untested.
It looks trivial and correct but just in case:
Tested-by: Simon Horman
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
ainability by special casing set and output actions such
that recirculation may be avoided.
This partially reverts the above mentioned commit. In particular most
of the C code changes outside of do_xlate_actions().
Signed-off-by: Simon Horman
---
* Lightly tested using test-suite portion of
On Wed, Aug 10, 2016 at 10:17:30AM -0700, Joe Stringer wrote:
> On 10 August 2016 at 03:20, Simon Horman wrote:
> > On Tue, Aug 09, 2016 at 08:47:40AM -0700, pravin shelar wrote:
> >> On Mon, Aug 8, 2016 at 8:17 AM, Simon Horman
> >> wrote:
> >> > Light
On Mon, Aug 22, 2016 at 02:47:42PM -0700, Joe Stringer wrote:
> On 22 August 2016 at 04:04, Simon Horman wrote:
> > On Wed, Aug 10, 2016 at 10:17:30AM -0700, Joe Stringer wrote:
> >> On 10 August 2016 at 03:20, Simon Horman
> >> wrote:
> >> > On Tue, A
On Tue, Aug 23, 2016 at 10:51:47AM +0200, Simon Horman wrote:
> On Mon, Aug 22, 2016 at 02:47:42PM -0700, Joe Stringer wrote:
> > On 22 August 2016 at 04:04, Simon Horman wrote:
> > > On Wed, Aug 10, 2016 at 10:17:30AM -0700, Joe Stringer wrote:
> > >> On 10 Augu
On Thu, Aug 25, 2016 at 05:33:57PM -0700, Joe Stringer wrote:
> On 25 August 2016 at 03:08, Simon Horman wrote:
> > Please find my working patch below.
> >
> > From: Simon Horman
> > Subject: [PATCH] system-traffic: Exercise GSO
> >
> > Exercise GSO for:
struct sw_flow_key which
have ovs in their name. Some consideration could be given to:
* Renaming them to make them more generic
* Providing a trimmed-down structure.
* Using an alternate structure
Signed-off-by: Simon Horman
---
include/linux/sw_flow.h | 100
there is some scope to share infrastructure in the kernel.
Simon Horman (12):
sw_flow: make struct sw_flow_key available outside of net/openvswitch/
switchdev: Add Open vSwitch (-like) flow object support
switchdev: Add support for getting port object details
rocker: Add Open vSwitch
switchdev is an appropriate mechanism for programming Open vSwitch (-like)
flows into hardware. The data structures can be tweaked/reworked as needed.
Signed-off-by: Simon Horman
---
include/net/switchdev.h | 39 +++
net/switchdev/switchdev.c | 58
This will be used by a follow-up patch to add Add Open vSwitch (-like) flow
support to the OF-DPA rocker world.
Signed-off-by: Simon Horman
---
drivers/net/ethernet/rocker/rocker.h | 4
drivers/net/ethernet/rocker/rocker_main.c | 15 +++
2 files changed, 19 insertions
in with sufficient
detail to allow it to be looked up and the driver may then fill in other
details of the object.
A follow up patch will prototype using this new SDO to retrieve statistics
for Open vSwitch (-like) flows that have been programmed into hardware.
Signed-off-by: Simon Horman
.
Signed-off-by: Simon Horman
---
drivers/net/ethernet/rocker/rocker_ofdpa.c | 261 +
1 file changed, 261 insertions(+)
diff --git a/drivers/net/ethernet/rocker/rocker_ofdpa.c
b/drivers/net/ethernet/rocker/rocker_ofdpa.c
index fcad907baecf..6669f2ba2f97 100644
--- a
Prototype an implementation of the new switchdev_port_obj_get SDO for the
SWITCHDEV_OBJ_OVS_FLOW object type. This allows retrieval of statistics for
Open vSwitch (-like) flows which have been programmed into hardware.
Signed-off-by: Simon Horman
---
drivers/net/ethernet/rocker/rocker_hw.h
Prototype programming of Open vSwitch (-like) flows into hardware
by implementing SWITCHDEV_OBJ_OVS_FLOW type objects in the
rocker_port_obj_{add,del} SDO, a new object type that
was added by an earlier patch in that forms part of this prototype.
Signed-off-by: Simon Horman
---
drivers/net
Prototype an implementation of the new switchdev_port_obj_get SDO for the
SWITCHDEV_OBJ_OVS_FLOW object type. This allows retrieval of
statistics for Open vSwitch (-like) flows which have been programmed into
hardware.
Signed-off-by: Simon Horman
---
drivers/net/ethernet/rocker/rocker.h
This is in preparation for using key_attrs outside of their current context
to allow quickly checking which attributes are set. This is in turn in
preparation for prototyping programming Open vSwitch (-like) flows into
hardware.
Signed-off-by: Simon Horman
---
net/openvswitch/flow.h
.
Signed-off-by: Simon Horman
---
net/openvswitch/datapath.c | 4 +++-
net/openvswitch/datapath.h | 2 ++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
index 4d67ea856067..365d480031d3 100644
--- a/net/openvswitch/datapath.c
+++ b
) supports tracking tcp_flags and b) by
implication parses L4 headers. If that is a requirement of allowing
Open vSwitch flows to be programmed into hardware, then so be it. But if
it is a hard requirement then it may eliminate some hardware options.
Signed-off-by: Simon Horman
---
include/uapi
-off-by: Simon Horman
---
drivers/net/ethernet/rocker/rocker_ofdpa.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/rocker/rocker_ofdpa.c
b/drivers/net/ethernet/rocker/rocker_ofdpa.c
index 3b441359a3a7..2f20f1ded5bf 100644
--- a/drivers/net/ethernet/rocker/rocker_ofdpa.c
Hi Or,
On Wed, Sep 28, 2016 at 04:54:40PM +0300, Or Gerlitz wrote:
> On Wed, Sep 28, 2016 at 3:42 PM, Simon Horman
> wrote:
>
> > A different approach, not implemented by this patch-set, is for user-space
> > to program flows into hardware by some other means, for examp
On Wed, Oct 12, 2016 at 01:36:44PM -0700, Pravin Shelar wrote:
> Sorry for jumping in a bit late. I have couple of high level comments below.
>
> On Thu, Oct 6, 2016 at 10:10 AM, Rony Efraim wrote:
> > From: Joe Stringer [mailto:j...@ovn.org] Sent: Thursday, October 06, 2016
> > 5:06 AM
...
>
Hi Paul,
thanks for this very interesting work. I hope we can see offload support
present in OvS in the not too distant future.
Looking over the patches I have a few high-level comments:
* Please run the code through ./utilities/checkpatch.py
* Please consider referring to flower or tc-flower in
verting the code changes in this commit
> then running "make check-valgrind" with the test that this commit
> introduces.
>
> Reported-by: Simon Horman
> Signed-off-by: Ben Pfaff
Thanks for following up on this; your patch looks good to me.
Reviewed-by: Simon Horman
On Tue, Jun 23, 2015 at 11:39:45AM -0700, Ben Pfaff wrote:
> On Wed, Jun 17, 2015 at 02:22:32PM +0900, Simon Horman wrote:
> > As per the testcase included in this patch it has been observed
> > that ovs-vswtichd may segfault when deleting a bridge.
> >
> > Analysing
On Fri, Jul 10, 2015 at 04:19:24PM +0200, Thomas Graf wrote:
> From: Pravin Shelar
>
> Removes all of the OVS specific GRE code and makes OVS use a
> GRE net_device.
>
> Signed-off-by: Pravin B Shelar
[snip]
> @@ -115,6 +117,8 @@ static bool log_ecn_error = true;
> module_param(log_ecn_error
zero did
not hit a rule that matches on its type.
Signed-off-by: Simon Horman
---
* Some consideration should be given to examining unwanted side effects
of this change. I feel it is probably safe as the kernel has been doing
this. But nonetheless it is a behavioural change for malformed
On Thu, Aug 06, 2015 at 04:00:36PM -0700, Jesse Gross wrote:
> On Wed, Aug 5, 2015 at 10:20 PM, Simon Horman
> wrote:
> > There appears to be a miss-match between the handling of miss-sized
> > neighbour discovery options in implementation of
> > parse_icmpv6() in user
On Thu, Aug 06, 2015 at 08:27:02PM -0700, Jesse Gross wrote:
> On Thu, Aug 6, 2015 at 7:43 PM, Simon Horman
> wrote:
> > On Thu, Aug 06, 2015 at 04:00:36PM -0700, Jesse Gross wrote:
> >> On Wed, Aug 5, 2015 at 10:20 PM, Simon Horman
> >> wrote:
> >> >
with invalid neighbour discovery options although only the
change around the '(!opt_len || opt_len > *sizep)' conditional is necessary
to achieve that goal.
Signed-off-by: Simon Horman
---
v2
* Harmonise the entire user-space implementation of parse_icmpv6() with
kernel code rather
matching on the IP protocol and IPv6 addresses of packets
with malformed extension headers.
Signed-off-by: Simon Horman
---
* Some consideration should be given to unwanted side effects of this patch
as it affects the handling of malformed packets.
Signed-off-by: Simon Horman
---
net
: Simon Horman
---
utilities/ovs-ctl.in | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in
index 99d789c68b0a..918be2c9c188 100755
--- a/utilities/ovs-ctl.in
+++ b/utilities/ovs-ctl.in
@@ -322,6 +322,12 @@ save_ofports_if_required
On Fri, Aug 21, 2015 at 10:25:22AM -0700, Gurucharan Shetty wrote:
> On Thu, Aug 20, 2015 at 4:45 PM, Simon Horman
> wrote:
> > When called with --delete-bridges saved flows cannot be restored as the
> > bridges to which they belong no longer exist. This results in the f
On Tue, Aug 25, 2015 at 01:42:04PM -0700, Gurucharan Shetty wrote:
> On Mon, Aug 24, 2015 at 5:29 PM, Simon Horman
> wrote:
> > On Fri, Aug 21, 2015 at 10:25:22AM -0700, Gurucharan Shetty wrote:
> >> On Thu, Aug 20, 2015 at 4:45 PM, Simon Horman
> >> wrote:
&g
Hi Pravin,
On Mon, Aug 17, 2015 at 11:33:59AM -0700, Pravin Shelar wrote:
> On Thu, Aug 13, 2015 at 6:30 PM, Simon Horman
> wrote:
> > When an error occurs skipping IPv6 extension headers retain the already
> > parsed IP protocol and IPv6 addresses in the flow. Also assume that
On Fri, Aug 28, 2015 at 11:11:08AM -0700, Pravin Shelar wrote:
[snip]
> Looks good to me.
Thanks, I will make a formal submission of it as v2.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
matching on the IP protocol and IPv6 addresses of packets
with malformed extension headers.
Signed-off-by: Simon Horman
---
v2
* As suggested by Pravin Shelar
- Use new errno for the case handled by this patch in order
to retain the old behaviour if the call to check_header()
in
than all being credited to table 0.
These problems were observed when running make check-ryu
and this patch allows many of its tester.py match checks
to pass.
Signed-off-by: Simon Horman
Reviewed-by: YAMAMOTO Takashi
--
v3
* Add: Reviewed-by: YAMAMOTO Takashi
* Rebase
v2
* Use NULL instead of 0
Add has_recirc field to struct xlate_out. It is set to
true during actions translation if the resulting actions include
a recirc action. It is false otherwise.
This will be used by a subsequent patch that executes
recirc actions for packet out in ovs-vswitchd.
Signed-off-by: Simon Horman
his is in preparation for allowing execution of recirc actions
in ovs-vswitchd.
Signed-off-by: Simon Horman
---
lib/dpif.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/dpif.c b/lib/dpif.c
index 6a67127..026d92f 100644
--- a/lib/dpif.c
+++ b/lib/dpif.c
@@ -1146,12
Rather then prohibiting recirc actions dpif_execute_helper_cb()
deffer their processing by saving the required state.
This is in preparation for allowing execution of recirc actions
in ovs-vswitchd.
Signed-off-by: Simon Horman
---
lib/dpif.c | 37 +++--
lib
ff-by: Simon Horman
---
ofproto/ofproto-dpif.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 7a4f130..7255dda 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -3116,7 +31
If execution is performed using a helper then any recirc actions
encountered may be deferred. This change executes such actions.
Signed-off-by: Simon Horman
---
ofproto/ofproto-dpif.c | 81 +-
1 file changed, 73 insertions(+), 8 deletions(-)
diff
proto: per-table statistics
And the following patch should be reverted
1f8675481e8cc976 "ofproto-dpif-upcall: Fix ovs-vswitchd crash."
To aid review this series and its dependencies are available in git
https://github.com/horms/openvswitch devel/mpls-flow-based-recirculation-v3
This is in preparation for using this value
in ofproto-dpif-xlate.c when composing recirculation
actions added as a result of processing (MPLS) actions.
Signed-off-by: Simon Horman
---
ofproto/bond.c | 1 -
ofproto/ofproto-dpif.h | 3 +++
2 files changed, 3 insertions(+), 1 deletion
There does not seem to be a reason to expose
recirc members in struct xlate_out to move them
to struct xlate_ctx.
Signed-off-by: Simon Horman
---
ofproto/ofproto-dpif-xlate.c | 20
ofproto/ofproto-dpif-xlate.h | 3 ---
2 files changed, 12 insertions(+), 11 deletions
This tests exercises execution of actions in ovs-vswitchd
in the case where a packet is processed due to a packet out message
with an in_port that doesn't exist in the datapath and translation
results in recirc actions due to bonding.
Signed-off-by: Simon Horman
---
tests/ofproto-dpif.at
recirculation to occur.
Signed-off-by: Simon Horman
---
lib/meta-flow.h | 8
1 file changed, 8 insertions(+)
diff --git a/lib/meta-flow.h b/lib/meta-flow.h
index 91dfecd..d02d320 100644
--- a/lib/meta-flow.h
+++ b/lib/meta-flow.h
@@ -89,6 +89,8 @@ enum OVS_PACKED_ENUM mf_field_id
recirculation.
Signed-off-by: Simon Horman
--
v3
* Rebase
* Break back out into separate patch
v2
* Erroneously squashed into "odp-util: Add odp_put_recirc_action() helper"
---
ofproto/bond.c | 2 +-
ofproto/ofproto-dpif.c | 10 ++
ofproto/ofproto-dpif.h | 1 +
3 fil
to be translated.
Signed-off-by: Simon Horman
---
v3
* Rebase
* Add rule_set_recirc_id()
v2
* No change
---
ofproto/ofproto-dpif.c | 47 +++
ofproto/ofproto-dpif.h | 2 ++
2 files changed, 49 insertions(+)
diff --git a/ofproto/ofproto-dpif.c b
This will be used by a subsequent patch to add support for
recirculation for MPLS.
Signed-off-by: Simon Horman
---
ofproto/ofproto-dpif.c | 10 +-
ofproto/ofproto-dpif.h | 2 ++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto
This makes maintaining the controller test slightly easier
by splitting it in two.
Based on a similar patch by Joe Stringer.
Cc: Joe Stringer
Signed-off-by: Simon Horman
--
v3
* Rebase
v2
* No change
v1
* Taken from another patch-set and re-worked
---
tests/ofproto-dpif.at | 353
.
Signed-off-by: Simon Horman
---
v3
* Changes to support recirculation in conjunction with packet_out
have been moved out into separate patches
* Changes to support recirculation with patch_ports have been dropped
- This seems rather had and possibly not very important
* Rework avoiding leaking
With recirculation in place this should be safe.
XXX: What if recirculation is disabled???
Signed-off-by: Simon Horman
---
lib/ofp-actions.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index ce14004..69d6505 100644
--- a/lib/ofp-actions.c
it would be best if ryu-check used ports which were more fully
featured and not special cases.
Thus this patch moves run-ryu to use unix socket backed ports rather than
patch ports.
Signed-off-by: Simon Horman
---
* I believe a more significant problem with the use of patch ports
is that
On Wed, Apr 23, 2014 at 09:36:30AM -0700, Ben Pfaff wrote:
> On Wed, Apr 23, 2014 at 02:06:12PM +0900, Simon Horman wrote:
> > My understanding of the implementation of patch ports is that they
> > are rather special, being handled as a special case inside
> > compose_output_
On Thu, Apr 24, 2014 at 05:57:29PM +0900, YAMAMOTO Takashi wrote:
> hi,
>
> > + * Due to the sample action there may be multiple possible eth types.
> > + * In order to correctly validate actions all possible types are tracked
> > + * and verified. This is done using struct eth_types.
>
> is ther
On Tue, Apr 22, 2014 at 05:54:48PM +0900, Simon Horman wrote:
>
> The motivation of this series is to allow some sequences of actions
> that include MPLS actions to be performed using recirculation.
> Sequences of actions that could not previously be handled.
>
> For examp
a test that passes regardless
of the presence of other patches in the series :(
Could you please take a look at the updated test below?
It should fail without earlier patches in the series.
From: Simon Horman
[PATCH] ofproto-dpif: Bonding with in_port that isn't present in the datapat
On Fri, Apr 25, 2014 at 12:57:20PM -0700, Jesse Gross wrote:
> On Fri, Apr 25, 2014 at 1:06 AM, YAMAMOTO Takashi
> wrote:
> >> On Thu, Apr 24, 2014 at 05:57:29PM +0900, YAMAMOTO Takashi wrote:
> >>> hi,
> >>>
> >>> > + * Due to the sample action there may be multiple possible eth types.
> >>> > +
On Mon, Apr 28, 2014 at 02:37:47PM -0700, Jesse Gross wrote:
> On Mon, Apr 28, 2014 at 12:00 AM, Simon Horman wrote:
> > On Fri, Apr 25, 2014 at 12:57:20PM -0700, Jesse Gross wrote:
> >> On Fri, Apr 25, 2014 at 1:06 AM, YAMAMOTO Takashi
> >> wrote:
> >> &
as for reasons
I don't fully understand packets with the CONTROLLER as the in_port do not
seem to be able to be handled by a normal action. And it it my
understanding that a normal action is needed to forward packets to a bond.
>
> On Sun, Apr 27, 2014 at 6:24 PM, Simon Horman wrote:
On Thu, Apr 24, 2014 at 10:34:15PM -0700, Andy Zhou wrote:
> Bond rebalancing was disabled for bonds not using recirculation. The
> patch fixes this bug.
>
> While fixing the bug, the bond_rebalance() was also restructured
> slightly to move bond related logic back into ofproto/bond.c
>
> Signed-
Thanks.
On Tue, Apr 29, 2014 at 02:30:26AM -0700, Andy Zhou wrote:
> Good catch. Thanks for pointing it out. I will send out patch to fix this.
>
> On Tue, Apr 29, 2014 at 2:14 AM, Simon Horman wrote:
> > On Thu, Apr 24, 2014 at 10:34:15PM -0700, Andy Zhou wrote:
> >&
101 - 200 of 3227 matches
Mail list logo
