On Wed, Apr 23, 2014 at 09:36:30AM -0700, Ben Pfaff wrote: > On Wed, Apr 23, 2014 at 02:06:12PM +0900, Simon Horman wrote: > > My understanding of the implementation of patch ports is that they > > are rather special, being handled as a special case inside > > compose_output_action__() and do not exist in the datapath. > > > > A side effect of the implementation of patch ports (though perhaps not the > > portion mentioned above) is that the OFPUTIL_PC_PORT_DOWN bit may not be > > set via a port mod message. In particular, the call to > > netdev_turn_flags_on() in update_port_config() fails. > > > > There is a test provided by Ryu that test this via port mod and thus fails. > > > > While that test could be modified or the results ignored it seems to me > > that it would be best if ryu-check used ports which were more fully > > featured and not special cases. > > > > Thus this patch moves run-ryu to use unix socket backed ports rather than > > patch ports. > > > > Signed-off-by: Simon Horman <ho...@verge.net.au> > > Applied, thanks. > > The following seemed good rationale so I folded it into the commit message:
Thanks! _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
