FC patch,
>
> 2. connmgr_wants_packet_in_on_miss() was added by Simon. I think this
> function should only check for controller connections. And want to
> confirm
> it with Simon.
>
> 3. unit test 737 corresponds to this: (which is also added by Simon)
>
> 527ae9
On Thu, Aug 14, 2014 at 11:17:30AM -0700, Ben Pfaff wrote:
> The recent mailing list thread about MPLS reminded me that the FAQ needs an
> update.
>
> CC: Simon Horman
> Signed-off-by: Ben Pfaff
Acked-by: Simon Horman
> ---
> FAQ | 14 --
> 1 file cha
Hi,
I have been working with Netronome on examining the possibilities of
providing (richer) load balancing facilities in Open vSwitch.
It seems to us that the current select group provides for some load
balancing functionality. And that in particular the way that it is
implemented in Open vSwitch
On Fri, Aug 22, 2014 at 08:30:08AM -0700, Ben Pfaff wrote:
> On Fri, Aug 22, 2014 at 09:19:41PM +0900, Simon Horman wrote:
> > I have been working with Netronome on examining the possibilities of
> > providing (richer) load balancing facilities in Open vSwitch.
> >
> &
On Wed, Aug 27, 2014 at 09:51:59AM -0700, Ben Pfaff wrote:
> On Wed, Aug 27, 2014 at 10:26:14AM +0900, Simon Horman wrote:
> > On Fri, Aug 22, 2014 at 08:30:08AM -0700, Ben Pfaff wrote:
> > > On Fri, Aug 22, 2014 at 09:19:41PM +0900, Simon Horman wrote:
> > > > I ha
On Wed, Aug 27, 2014 at 03:03:53PM -0500, Jesse Gross wrote:
> On Wed, Aug 27, 2014 at 11:51 AM, Ben Pfaff wrote:
> > On Wed, Aug 27, 2014 at 10:26:14AM +0900, Simon Horman wrote:
> >> On Fri, Aug 22, 2014 at 08:30:08AM -0700, Ben Pfaff wrote:
> >> > On Fri, Au
On Thu, Aug 28, 2014 at 10:11:57AM +0900, Simon Horman wrote:
> On Wed, Aug 27, 2014 at 09:51:59AM -0700, Ben Pfaff wrote:
> > On Wed, Aug 27, 2014 at 10:26:14AM +0900, Simon Horman wrote:
[snip]
> > The proposal seems reasonable on its own but given that EXT-350 allows a
> >
On Thu, Aug 28, 2014 at 10:12:49AM +0900, Simon Horman wrote:
> On Wed, Aug 27, 2014 at 03:03:53PM -0500, Jesse Gross wrote:
> > On Wed, Aug 27, 2014 at 11:51 AM, Ben Pfaff wrote:
> > > On Wed, Aug 27, 2014 at 10:26:14AM +0900, Simon Horman wrote:
> > >> On Fri, Au
On Fri, Aug 29, 2014 at 10:20:55AM -0400, Jamal Hadi Salim wrote:
> On 08/26/14 16:54, Thomas Graf wrote:
> >On 08/26/14 at 01:13pm, Alexei Starovoitov wrote:
> >>I think it's important distinction. In-kernel OVS is not OF.
> >>It's a networking function that has hard-coded packet parser,
> >>N-tup
2014/09/01 21:40 "Thomas Graf" :
>
> On 09/01/14 at 05:10pm, Simon Horman wrote:
> > We are left with two questions for you:
> >
> > 1. Would you look at a proposal (I have some rough code that even works)
> >for a select group action in the datapath
On Tue, Sep 02, 2014 at 09:03:24AM -0700, Ben Pfaff wrote:
> On Mon, Sep 01, 2014 at 04:59:22PM +0900, Simon Horman wrote:
> > On Thu, Aug 28, 2014 at 10:11:57AM +0900, Simon Horman wrote:
> > > On Wed, Aug 27, 2014 at 09:51:59AM -0700, Ben Pfaff wrote:
> > > > On W
On Tue, Sep 02, 2014 at 06:55:14PM -0700, Jesse Gross wrote:
> On Mon, Sep 1, 2014 at 1:10 AM, Simon Horman
> wrote:
> > On Thu, Aug 28, 2014 at 10:12:49AM +0900, Simon Horman wrote:
> >> On Wed, Aug 27, 2014 at 03:03:53PM -0500, Jesse Gross wrote:
> >> > On W
On Tue, Sep 02, 2014 at 07:20:30PM -0700, Pravin Shelar wrote:
> On Tue, Sep 2, 2014 at 6:55 PM, Jesse Gross wrote:
> > On Mon, Sep 1, 2014 at 1:10 AM, Simon Horman
> > wrote:
> >> On Thu, Aug 28, 2014 at 10:12:49AM +0900, Simon Horman wrote:
> >>> On W
On Sat, Aug 23, 2014 at 10:09:13AM -0700, John Fastabend wrote:
>On 08/23/2014 07:51 AM, Thomas Graf wrote:
>>On 08/23/14 at 11:24am, Jiri Pirko wrote:
>>>Sat, Aug 23, 2014 at 12:53:34AM CEST, sfel...@cumulusnetworks.com wrote:
On Aug 22, 2014, at 12:39 PM, John Fastabend
wrote:
[sn
Hi Jiri,
sorry for coming a little late to the party.
I'm very happy to see work in this area.
On Thu, Aug 21, 2014 at 06:19:03PM +0200, Jiri Pirko wrote:
> Benefit from the possibility to work with flows in switch devices and
> use the swdev api to offload flow datapath.
>
> Signed-off-by: Jiri
On Thu, Sep 04, 2014 at 11:09:26AM +0200, Jiri Pirko wrote:
> Thu, Sep 04, 2014 at 11:03:46AM CEST, simon.hor...@netronome.com wrote:
> >On Sat, Aug 23, 2014 at 10:09:13AM -0700, John Fastabend wrote:
> >>On 08/23/2014 07:51 AM, Thomas Graf wrote:
> >>>On 08/23/14 at 11:24am, Jiri Pirko wrote:
> >>
On Thu, Sep 04, 2014 at 11:24:58AM +0200, Jiri Pirko wrote:
> Thu, Sep 04, 2014 at 11:04:49AM CEST, simon.hor...@netronome.com wrote:
> >Hi Jiri,
> >
> >sorry for coming a little late to the party.
> >I'm very happy to see work in this area.
> >
> >On Thu, Aug 21, 2014 at 06:19:03PM +0200, Jiri Pir
On Thu, Sep 04, 2014 at 02:48:37PM +0200, Jiri Pirko wrote:
> Wed, Sep 03, 2014 at 06:37:08PM CEST, john.fastab...@gmail.com wrote:
> >On 09/03/2014 02:24 AM, Jiri Pirko wrote:
> >>Benefit from the possibility to work with flows in switch devices and
> >>use the swdev api to offload flow datapath.
On Thu, Sep 04, 2014 at 09:30:45AM -0700, Scott Feldman wrote:
>
> On Sep 4, 2014, at 2:04 AM, Simon Horman wrote:
>
> >
> >
> > [snip]
> >
> > In relation to ports and datapaths it seems to me that the API that
> > has been developed acco
On Fri, Sep 05, 2014 at 12:02:03AM -0700, Scott Feldman wrote:
>
> On Sep 4, 2014, at 9:08 PM, Simon Horman wrote:
>
> > On Thu, Sep 04, 2014 at 09:30:45AM -0700, Scott Feldman wrote:
> >>
> >> On Sep 4, 2014, at 2:04 AM, Simon Horman
> >&
On Fri, Sep 05, 2014 at 12:07:17PM -0700, Jesse Gross wrote:
> On Thu, Sep 4, 2014 at 12:28 AM, Simon Horman
> wrote:
> > On Tue, Sep 02, 2014 at 07:20:30PM -0700, Pravin Shelar wrote:
> >> On Tue, Sep 2, 2014 at 6:55 PM, Jesse Gross wrote:
> >> > On Mon, Sep
.
Fixes: 83d2b9ba1abc ("net: openvswitch: Support masked set actions.")
Cc: Jarno Rajahalme
Signed-off-by: Simon Horman
---
* Found using tcpdump to examine the checksums of packets.
* I believe a similar fix is required for the user-space implementation
of the datapath. I plan to look
.
A similar fix for the kernel datapath has been accepted into David Miller's
'net' tree as b4f70527f052 ("openvswitch: use flow protocol when
recalculating ipv6 checksums").
Cc: Jarno Rajahalme
Fixes: 6d670e7f0d45 ("lib/odp: Masked set action execution and printing.
.
A similar fix for the kernel datapath has been accepted into David Miller's
'net' tree as b4f70527f052 ("openvswitch: use flow protocol when
recalculating ipv6 checksums").
Cc: Jarno Rajahalme
Fixes: 6d670e7f0d45 ("lib/odp: Masked set action execution and printing.
On Fri, Apr 22, 2016 at 10:10:38AM -0700, Ben Pfaff wrote:
> On Fri, Apr 22, 2016 at 10:22:56PM +1000, Simon Horman wrote:
> > When using masked actions the ipv6_proto field of an action
> > to set IPv6 fields may be zero rather than the prevailing protocol
> > which wi
On Thu, Apr 28, 2016 at 06:09:04PM -0700, Joe Stringer wrote:
> Since commit f2ab1536ddbc ("compat: Backport conntrack strictly to
> v3.10+."), we haven't supported these kernel versions. Remove the old
> code.
>
> Signed-off-by: Joe Str
ions.
Added new prerequisite MFP_ETHERNET for fields MFF_ETH_SRC, MFF_ETH_DST,
MFF_VLAN_TCI, MFF_DL_VLAN, MFF_VLAN_VID and MFF_DL_VLAN_PCP.
Signed-off-by: Lorand Jakab
Signed-off-by: Simon Horman
---
v10 [Simon Horman]
* Ensure that packets sent to controller have an ethernet header
* Avoid popping
OVS_KEY_ATTR_PACKET_ETHERTYPE to indicate network protocol.
Signed-off-by: Lorand Jakab
Signed-off-by: Simon Horman
---
v10 [Simon Horman]
* Update BUILD_BUG_ON() call in ovs_key_attr_size()
* Set packet_ethtype in set_ethertype()
* Do not include zero-value OVS_KEY_ATTR_PACKET_ETHERTYPE
From: Lorand Jakab
These actions will allow L2->L3 and L3->L2 switching, and are supposed
to be added to flows installed in the datapath transparently by
ovs-vswitchd.
Signed-off-by: Lorand Jakab
Signed-off-by: Simon Horman
---
v9 [Simon Horman]
* Rebased
v1 - v8 [Lorand
nd Jakab (3):
userspace: add support for pop_eth and push_eth actions
userspace: add layer 3 flow and switching support
userspace: add layer 3 support to packet metadata
Simon Horman (2):
userspace: extend layer 3 support to cover non-IP packets
userspace: add non-tap (l3) support to GRE v
that this attribute is only used in userspace as there appears to
be no need for it to be used in the kernel datapath.
It is envisaged that this attribute may be used for other encapsulation
protocols that support both layer3 and layer2 inner-packets.
Signed-off-by: Simon Horman
---
v10
* Use a
packets which
are technically layer 2.5 rather than 3 but the distinction seems unimportant
here.
This relies on datapaths setting OVS_KEY_ATTR_PACKET_ETHERTYPE to
the ethernet type corresponding to the protocol of layer 3 packets
on a flow miss.
Signed-off-by: Simon Horman
---
v10
* Delete now
to the dev@openvswitch.org mailing list as:
"[PATCH v10 0/5] userspace: Support for layer 3 encapsulated packets"
Lorand Jakab (1):
openvswitch: add layer 3 flow/port support
Simon Horman (6):
net: add skb_vlan_deaccel helper
openvswitch: set skb protocol when receiving on internal devic
at is not supported in mainline Linux.
I (Simon) plan to follow up with support for non-TEB GRE ports based on
work by Thomas Morin.
Cc: Thomas Morin
Signed-off-by: Lorand Jakab
Signed-off-by: Simon Horman
---
v9 [Simon Horman]
* Rebase
* Minor coding style updates
* Prohibit push/pop MPLS
Allow push and pop mpls actions to act on layer 3 packets by teaching
them not to access non-existent L2 headers of such packets.
Signed-off-by: Simon Horman
---
v9
* New Patch
---
net/openvswitch/actions.c | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
diff
-tap)
GRE tunnels as implemented by a subsequent patch depends on protocol being
set correctly in order to provide the protocol for the inner packet.
Signed-off-by: Simon Horman
---
v9
* New patch
---
net/openvswitch/vport-internal_dev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net
adding a new
one. This is in preparation for a push ethernet header support in Open
vSwitch.
Signed-off-by: Simon Horman
---
v9 [Simon Horman]
* New patch
---
include/linux/skbuff.h | 1 +
net/core/skbuff.c | 50 --
2 files changed, 33
This allows GRE tunnels to send and receive both
layer 2 packets (packets with an ethernet header) and
layer 3 packets (packets without an ethernet header).
Signed-off-by: Simon Horman
---
v9
New Patch
---
include/net/gre.h | 4 ++--
net/ipv4/ip_gre.c | 8
adata,
containing 0 for layer 2 packets and the Ethertype for layer 3 packets.
Signed-off-by: Lorand Jakab
Signed-off-by: Simon Horman
---
v9 [Simon Horman]
* Rebase
v8 [Lorand Jakab]
v7 [Lorand Jakab]
* New patch
---
include/uapi/linux/openvswitch.h | 2 ++
net/openvswitch/datapath.c
packets which
are technically layer 2.5 rather than 3 but the distinction seems unimportant
here.
This sets OVS_KEY_ATTR_PACKET_ETHERTYPE to the ethernet type corresponding
to the protocol of layer 3 packets on a flow miss.
Signed-off-by: Simon Horman
---
v9
* New patch
---
net/openvswitch
On Thu, May 05, 2016 at 10:35:52AM -0700, pravin shelar wrote:
> On Wed, May 4, 2016 at 12:36 AM, Simon Horman
> wrote:
> > Allow push and pop mpls actions to act on layer 3 packets by teaching
> > them not to access non-existent L2 headers of such packets.
> >
> &g
[CC Jiri Benc]
On Thu, May 05, 2016 at 10:37:08AM -0700, pravin shelar wrote:
> On Wed, May 4, 2016 at 12:36 AM, Simon Horman
> wrote:
> > From: Lorand Jakab
> >
> > Implementation of the pop_eth and push_eth actions in the kernel, and
> > layer 3 flow support.
&g
[CC Jiri Benc]
On Thu, May 05, 2016 at 02:45:15PM -0700, pravin shelar wrote:
> On Wed, May 4, 2016 at 12:36 AM, Simon Horman
> wrote:
> > This allows GRE tunnels to send and receive both
> > layer 2 packets (packets with an ethernet header) and
> > layer 3 packets (pac
On Fri, May 06, 2016 at 11:25:14AM +0200, Jiri Benc wrote:
> On Fri, 6 May 2016 14:57:07 +0900, Simon Horman wrote:
> > On Thu, May 05, 2016 at 10:37:08AM -0700, pravin shelar wrote:
> > > On transmit side you are using mac_len to detect l3 packet, why not do
> > > sa
On Fri, May 06, 2016 at 11:35:04AM +0200, Jiri Benc wrote:
> On Wed, 4 May 2016 16:36:30 +0900, Simon Horman wrote:
> > +static int push_eth(struct sk_buff *skb, struct sw_flow_key *key,
> > + const struct ovs_action_push_eth *ethh)
> > +{
> > + i
Hi Jiri,
On Tue, May 10, 2016 at 02:01:06PM +0200, Jiri Benc wrote:
> On Mon, 9 May 2016 17:04:22 +0900, Simon Horman wrote:
> > It seems to be caused by the following:
> >
> > 1. __ipgre_rcv() calls skb_pop_mac_header() which
> >sets skb->mac_header to the s
Hi Jiri,
On Wed, May 11, 2016 at 10:50:09AM +0900, Simon Horman wrote:
[...]
> > > Its possible that I've overlooked something but as things stand I think
> > > things look like this:
> > >
> > > * ovs_flow_key_extract() keys off dev->type and
Hi Jiri,
On Tue, May 10, 2016 at 02:06:18PM +0200, Jiri Benc wrote:
> On Mon, 9 May 2016 17:18:20 +0900, Simon Horman wrote:
> > On Fri, May 06, 2016 at 11:35:04AM +0200, Jiri Benc wrote:
> > > In addition, we should check whether mac_len > 0 and in such case,
> >
On Wed, May 11, 2016 at 04:09:28PM +0200, Jiri Benc wrote:
> On Wed, 11 May 2016 12:06:35 +0900, Simon Horman wrote:
> > Is this close to what you had in mind?
>
> Yes but see below.
>
> > @@ -739,17 +729,17 @@ int ovs_flow_key_extract(const struct ip_tunnel_info
&g
On Tue, May 17, 2016 at 04:43:20PM +0200, Jiri Benc wrote:
> On Thu, 12 May 2016 07:46:52 +0900, Simon Horman wrote:
> > If we can live with a bogus skb->mac_len value that is sufficient for
> > ovs_flow_key_extract.() and set correctly by key_extract() (which happens
>
On Tue, May 17, 2016 at 04:51:08PM +0200, Jiri Benc wrote:
> On Wed, 4 May 2016 16:36:31 +0900, Simon Horman wrote:
> > + /* Packets from user space for execution only have metadata key
> > +* attributes. OVS_KEY_ATTR_PACKET_ETHERTYPE is then used to specify
> > +
On Wed, May 18, 2016 at 05:28:52PM -0700, Ben Pfaff wrote:
> On Wed, May 04, 2016 at 04:34:20PM +0900, Simon Horman wrote:
> > This series implements support for layer 3 encapsulated packets. At the
> > core of this change is removing the assumption that all packets/flows have
>
Hi Jiri,
On Tue, May 17, 2016 at 04:32:50PM +0200, Jiri Benc wrote:
> Looking through the patchset again, this time more deeply. Sorry for
> the delay.
No need to be sorry, good things take time.
> On Wed, 4 May 2016 16:36:30 +0900, Simon Horman wrote:
> > +struct ovs_
On Fri, May 20, 2016 at 10:00:28AM +0200, Jiri Benc wrote:
> On Fri, 20 May 2016 14:29:01 +0900, Simon Horman wrote:
> > The second option does seem rather tempting although I'm not sure
> > that it actually plays out in the access-port scenario at this time.
>
> We supp
On Fri, May 20, 2016 at 05:11:23PM +0900, Simon Horman wrote:
> On Fri, May 20, 2016 at 10:00:28AM +0200, Jiri Benc wrote:
> > On Fri, 20 May 2016 14:29:01 +0900, Simon Horman wrote:
> > > The second option does seem rather tempting although I'm not sure
> > > t
On Fri, May 20, 2016 at 10:39:39AM +0200, Jiri Benc wrote:
> On Fri, 20 May 2016 17:16:13 +0900, Simon Horman wrote:
> > My understanding is that currently OvS handles access ports using a
> > push_vlan action.
>
> When needed (i.e. when the packet goes to a non-access port),
On Fri, May 20, 2016 at 11:20:04AM +0200, Jiri Benc wrote:
> On Fri, 20 May 2016 18:12:05 +0900, Simon Horman wrote:
[...]
> > 3. With regards to the mirroring part of your question, I need to check
> >on that and possibly its broken. But my thinking is that a mirroring
>
Hi Ben,
On Tue, Apr 12, 2016 at 12:39:51PM -0700, Ben Pfaff wrote:
> On Mon, Apr 04, 2016 at 05:16:35PM +0900, Simon Horman wrote:
> > Until 8bf009bf8ab4 ("xlate: Always recirculate after an MPLS POP to a
> > non-MPLS ethertype.") the translation code took some care to
On Mon, May 23, 2016 at 08:56:46PM -0700, Ben Pfaff wrote:
> On Tue, May 24, 2016 at 12:43:59PM +0900, Simon Horman wrote:
> > Hi Ben,
> >
> > On Tue, Apr 12, 2016 at 12:39:51PM -0700, Ben Pfaff wrote:
> > > On Mon, Apr 04, 2016 at 05:16:35PM +0900, Simon Horman wro
ainability by special casing set and output actions such
that recirculation may be avoided.
This partially reverts the above mentioned commit. In particular most
of the C code outside of do_xlate_actions().
Signed-off-by: Simon Horman
---
* Lightly tested using test-suite portion of this
On Tue, May 24, 2016 at 12:36:02PM -0700, Jarno Rajahalme wrote:
> One comment below, otherwise looks good,
>
> Acked-by: Jarno Rajahalme
[...]
> > On May 24, 2016, at 12:29 AM, Simon Horman
> > wrote:
> >
> > Until 8bf009bf8ab4 ("xlate: Always reci
ainability by special casing set and output actions such
that recirculation may be avoided.
This partially reverts the above mentioned commit. In particular most
of the C code outside of do_xlate_actions().
Signed-off-by: Simon Horman
Acked-by: Jarno Rajahalme
---
* Lightly tested using test-sui
On Wed, May 25, 2016 at 10:34:31AM +0900, Simon Horman wrote:
> Until 8bf009bf8ab4 ("xlate: Always recirculate after an MPLS POP to a
> non-MPLS ethertype.") the translation code took some care to only
> recirculate as a result of a pop_mpls action if necessary. This was
>
On Tue, May 31, 2016 at 08:49:56AM -0700, Ben Pfaff wrote:
> On Wed, May 04, 2016 at 04:34:22PM +0900, Simon Horman wrote:
> > From: Lorand Jakab
> >
> > This commit relaxes the assumption that all packets have an Ethernet
> > header, and adds support for layer 3 flows
On Tue, May 31, 2016 at 01:52:55PM -0700, Ben Pfaff wrote:
> On Wed, May 04, 2016 at 04:34:23PM +0900, Simon Horman wrote:
> > From: Lorand Jakab
> >
> > This is needed for sending a packet back to the datapath after a miss
> > upcall was processed. The presence of a
On Tue, May 31, 2016 at 08:20:24PM -0700, Ben Pfaff wrote:
> On Wed, May 04, 2016 at 04:34:25PM +0900, Simon Horman wrote:
> > Add support for layer 3 GRE vports (non-tap aka non-VTEP).
> >
> > This makes use of a vport mode configuration for the existing (tap/VTEP)
> &
.
Signed-off-by: Simon Horman
---
v10 [Simon Horman]
* New patch
---
include/linux/skbuff.h | 1 +
net/core/skbuff.c | 28 +++-
2 files changed, 20 insertions(+), 9 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index ee38a4127475
implemented by a subsequent patch depends on protocol and
mac_len being set correctly on receive.
Signed-off-by: Simon Horman
---
v10
* Set mac_len
v9
* New patch
---
net/openvswitch/vport-internal_dev.c | 4
1 file changed, 4 insertions(+)
diff --git a/net/openvswitch/vport-internal_dev.c
From: Lorand Jakab
These actions will allow L2->L3 and L3->L2 switching, and are supposed
to be added to flows installed in the datapath transparently by
ovs-vswitchd.
Signed-off-by: Lorand Jakab
Signed-off-by: Simon Horman
---
v11 [Simon Horman]
* Omit type field from push_eth action,
mailing list as:
"[PATCH v11 0/5] userspace: Support for layer 3 encapsulated packets"
Changes since the previous posting are noted in the changelogs
of individual patches.
Lorand Jakab (1):
openvswitch: add layer 3 flow/port support
Simon Horman (4):
net: add skb_vlan_ac
ions.
Added new prerequisite MFP_ETHERNET for fields MFF_ETH_SRC, MFF_ETH_DST,
MFF_VLAN_TCI, MFF_DL_VLAN, MFF_VLAN_VID and MFF_DL_VLAN_PCP.
Signed-off-by: Lorand Jakab
Signed-off-by: Simon Horman
Acked-by: Ben Pfaff
---
v11 [Simon Horman]
* Rebase
* Remove spurious duplication of FLOW_MAX_MPLS_LABELS
at is not supported in mainline Linux.
I (Simon) plan to follow up with support for non-TEB GRE ports based on
work by Thomas Morin.
Cc: Thomas Morin
Signed-off-by: Lorand Jakab
Signed-off-by: Simon Horman
---
v10 [Simon Horman]
* Move outermost VLAN into skb metadata in pop_eth and
leave any
ce: add support for pop_eth and push_eth actions
userspace: add layer 3 flow and switching support
userspace: add layer 3 support to packet metadata
Simon Horman (2):
userspace: extend layer 3 support to cover non-IP packets
userspace: add non-tap (l3) support to GRE vports
build-aux
This allows GRE tunnels to send and receive both
layer 2 packets (packets with an ethernet header) and
layer 3 packets (packets without an ethernet header).
Signed-off-by: Simon Horman
---
v10
* Handle case of l3 only packets on vport-netdev
* Use ARPHRD_NONE for ipgre interfaces as per recent
Allow push and pop mpls actions to act on layer 3 packets by teaching
them not to access non-existent L2 headers of such packets.
Signed-off-by: Simon Horman
---
v10
* Limit scope of hdr in {push,pop}_mpls()
v9
* New Patch
---
net/openvswitch/actions.c | 19 ---
1 file changed
packets which
are technically layer 2.5 rather than 3 but the distinction seems unimportant
here.
This relies on datapaths setting OVS_KEY_ATTR_PACKET_ETHERTYPE to
the ethernet type corresponding to the protocol of layer 3 packets
on a flow miss.
Signed-off-by: Simon Horman
Acked-by: Ben Pfaff
OVS_KEY_ATTR_PACKET_ETHERTYPE to indicate network protocol.
Signed-off-by: Lorand Jakab
Signed-off-by: Simon Horman
Acked-by: Ben Pfaff
---
v11 [Simon Horman]
* Do not allow setting of OVS_KEY_ATTR_PACKET_ETHERTYPE field.
This does not seem necessary and is not used at this time.
If it
that this attribute is only used in userspace as there appears to
be no need for it to be used in the kernel datapath.
It is envisaged that this attribute may be used for other encapsulation
protocols that support both layer3 and layer2 inner-packets.
Signed-off-by: Simon Horman
---
v11
On Thu, Jul 07, 2016 at 01:52:25PM -0700, pravin shelar wrote:
> On Wed, Jul 6, 2016 at 10:59 AM, Simon Horman
> wrote:
> > * Set skb protocol based on contents of packet. I have observed this is
> > necessary to get actual protocol of a packet when it is injected into an
>
On Wed, Jul 06, 2016 at 07:58:56PM +0200, Simon Horman wrote:
[snip]
> --- a/lib/odp-util.c
> +++ b/lib/odp-util.c
...
> @@ -4614,14 +4623,38 @@ odp_key_to_pkt_metadata(const struct nlattr *key,
> size_t key_len,
> md->in_port.odp_port = nl_att
Hi Pravin,
On Thu, Jul 07, 2016 at 01:54:15PM -0700, pravin shelar wrote:
> On Wed, Jul 6, 2016 at 10:59 AM, Simon Horman
> wrote:
...
> > diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c
> > index 12e8a8942a42..0001f651c934 100644
> > --- a/n
[CC Jiri Benc for portion regarding GRE]
Hi Pravin,
On Fri, Jul 15, 2016 at 02:07:37PM -0700, pravin shelar wrote:
> On Wed, Jul 13, 2016 at 12:31 AM, Simon Horman
> wrote:
> > Hi Pravin,
> >
> > On Thu, Jul 07, 2016 at 01:54:15PM -0700, pravin shelar wrote:
> >>
Hi Johnson,
On Wed, Jul 13, 2016 at 01:28:48AM +0800, Johnson Li wrote:
> Signed-off-by: Johnson Li
* Regarding the action set (which we discussed briefly off-list):
I think that you need to update ofpacts_execute_action_set(), though
possibly not in this patch, for push/pop_nsh to be usabl
On Mon, Jul 18, 2016 at 06:37:04PM +0800, Yang, Yi wrote:
> On Mon, Jul 18, 2016 at 03:15:13PM +0900, Simon Horman wrote:
> > Hi Johnson,
> >
> > On Wed, Jul 13, 2016 at 01:28:48AM +0800, Johnson Li wrote:
> > > Signed-off-by: Johnson Li
> >
> > * Re
On Mon, Jul 18, 2016 at 03:34:52PM -0700, pravin shelar wrote:
> On Sun, Jul 17, 2016 at 9:50 PM, Simon Horman
> wrote:
> > [CC Jiri Benc for portion regarding GRE]
> >
> > Hi Pravin,
> >
> > On Fri, Jul 15, 2016 at 02:07:37PM -0700, pravin shelar wrote:
&
On Wed, Jul 20, 2016 at 11:06:37AM -0700, pravin shelar wrote:
> On Tue, Jul 19, 2016 at 5:02 PM, Simon Horman
> wrote:
> > On Mon, Jul 18, 2016 at 03:34:52PM -0700, pravin shelar wrote:
> >> On Sun, Jul 17, 2016 at 9:50 PM, Simon Horman
> >> wrote:
> >> &g
Hi Jesse,
On Wed, Jul 13, 2016 at 07:35:59AM -0700, Jesse Gross wrote:
> On Wed, Jul 13, 2016 at 4:04 AM, Brady Allen Johnson
> wrote:
> > I wanted to mention though, currently the type 2 metadata (MD2) isnt a top
> > priority for us. It looks like its already been investigated how to use some
>
On Wed, Jul 13, 2016 at 01:36:30AM +0800, Johnson Li wrote:
> Parse the Network Service Header to fullfill the fields in the
> struct sw_flow_key.
>
> Signed-off-by: Johnson Li
>
> diff --git a/datapath/flow.c b/datapath/flow.c
> index fd09cec..debac6f 100644
> --- a/datapath/flow.c
> +++ b/data
On Wed, Jul 13, 2016 at 01:27:19AM +0800, Johnson Li wrote:
> Signed-off-by: Johnson Li
>
> diff --git a/include/openvswitch/match.h b/include/openvswitch/match.h
> index c955753..4c79da3 100644
> --- a/include/openvswitch/match.h
> +++ b/include/openvswitch/match.h
> @@ -40,6 +40,18 @@ struct ma
On Wed, Jul 13, 2016 at 01:27:53AM +0800, Johnson Li wrote:
> Signed-off-by: Johnson Li
>
> diff --git a/lib/flow.c b/lib/flow.c
> index a4c1215..cdeccfc 100644
> --- a/lib/flow.c
> +++ b/lib/flow.c
> @@ -439,6 +439,46 @@ invalid:
> arp_buf[1] = eth_addr_zero;
> }
>
> +static int
> +parse
On Wed, Jul 13, 2016 at 01:36:14AM +0800, Johnson Li wrote:
> Openvswitch could use the fields of Network Serivce Header(NSH)
> as key to steer traffic to the Virtual Network Functions(VNF).
> The key will contain fields for NSH base header, service path
> header and context header for MD type 1. F
On Mon, Jul 18, 2016 at 08:20:42PM +, Jan Scheurich wrote:
> > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Simon Horman
> > Sent: Monday, 18 July, 2016 14:14
> > >
> > > Simon, very good guide, do push_eth and pop_eth also need to follow
&g
On Mon, Jul 18, 2016 at 11:21:11PM +, Jan Scheurich wrote:
> Hi Johnson,
>
> > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Yang, Yi
> > Sent: Monday, 18 July, 2016 12:37
> >
> > On Mon, Jul 18, 2016 at 03:15:13PM +0900, Simon Horman wrote:
> &
On Mon, Aug 08, 2016 at 05:28:39PM +0200, Jiri Benc wrote:
> On Mon, 8 Aug 2016 17:17:17 +0200, Simon Horman wrote:
> > +bool skb_mac_header_present(struct sk_buff *skb)
> > +{
> > + return skb->dev->type == ARPHRD_ETHER ||
> > + (skb->dev->type
On Tue, Aug 09, 2016 at 08:47:40AM -0700, pravin shelar wrote:
> On Mon, Aug 8, 2016 at 8:17 AM, Simon Horman
> wrote:
...
> > Hi Pravin,
> >
> > I have made an attempt to implement your suggestion to the extent that
> > I understand it. The following is an in
Hi Jan,
On Wed, Aug 10, 2016 at 12:21:08PM +, Jan Scheurich wrote:
> > -Original Message-
> > From: Simon Horman [mailto:simon.hor...@netronome.com]
> > Sent: Wednesday, 10 August, 2016 12:14
> > >
> > > My suggestion for the action set execution
Hi Jan,
On Thu, Aug 11, 2016 at 11:04:22AM +, Jan Scheurich wrote:
> > > [Jan] Should sending a packet after push_nsh to an output port be
> > > allowed in general? For a VXLAN-GPE tunnel port this is OK, but my
> > > expectation was that one must explicitly do push_eth (followed by
> > > set_
Hi Jan,
On Thu, Aug 11, 2016 at 12:58:44PM +, Jan Scheurich wrote:
> Hi Simon
>
> > > The implicit push_eth action introduced by Simon in his L3 tunnel port
> > > patch mainly ensures the presence of the 14 byte MAC header on ports
> > > where this is a must for syntactic interpretation of th
On Thu, Jun 02, 2016 at 03:02:18PM -0700, pravin shelar wrote:
> On Wed, Jun 1, 2016 at 11:24 PM, Simon Horman
> wrote:
[...]
> > diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c
> > index 15f130e4c22b..5567529904fa 100644
> > --- a/net/openvswitch
On Thu, Jun 02, 2016 at 03:02:00PM -0700, pravin shelar wrote:
> On Wed, Jun 1, 2016 at 11:24 PM, Simon Horman
> wrote:
> > Allow push and pop mpls actions to act on layer 3 packets by teaching
> > them not to access non-existent L2 headers of such packets.
> >
> &g
1 - 100 of 3227 matches
Mail list logo
