On Tue, May 31, 2016 at 08:49:56AM -0700, Ben Pfaff wrote:
> On Wed, May 04, 2016 at 04:34:22PM +0900, Simon Horman wrote:
> > From: Lorand Jakab <loja...@cisco.com>
> > 
> > This commit relaxes the assumption that all packets have an Ethernet
> > header, and adds support for layer 3 flows.  For each packet received on
> > the Linux kernel datapath the l2 and l3 members of struct ofpbuf are
> > intialized appropriately, and some functions now expect this (notably
> > flow_extract()), in order to differentiate between layer 2 and layer 3
> > packets.  struct flow has now a new 'base_layer' member, because we
> > cannot assume that a flow has no Ethernet header when eth_src and
> > eth_dst are 0.  For layer 3 packets, the protocol type is still stored
> > in the eth_type member.
> > 
> > Switching L2->L3 and L3->L2 are both implemented by adding the pop_eth
> > and push_eth actions respectively when a transition is detected.  The
> > push_eth action puts 0s on both source and destination MACs.  These
> > addresses can be modified with mod_dl_dst and mod_dl_src actions.
> > 
> > Added new prerequisite MFP_ETHERNET for fields MFF_ETH_SRC, MFF_ETH_DST,
> > MFF_VLAN_TCI, MFF_DL_VLAN, MFF_VLAN_VID and MFF_DL_VLAN_PCP.
> 
> This introduces a duplicate definition of FLOW_MAX_MPLS_LABELS.
> 
> Otherwise it seems ok.
> 
> Acked-by: Ben Pfaff <b...@ovn.org>

Thanks, I have dropped the FLOW_MAX_MPLS_LABELS and added your Ack.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to