Re: [ovs-dev] [PATCH v2] ovn-northd: Handle IPv4 addresses with prefixes in lport port security

2016-04-16 Thread Numan Siddique
On Fri, Apr 15, 2016 at 9:19 PM, Russell Bryant wrote: > > > On Thu, Apr 14, 2016 at 5:22 PM, Ben Pfaff wrote: > >> On Fri, Apr 08, 2016 at 11:21:16PM +0530, Numan Siddique wrote: >> > Initial implementation of port security, missed out this feature. >> > >

[ovs-dev] [PATCH] ovn: Fix the port secuirty test failure by adding a sleep of 2 sec.

2016-04-16 Thread Numan Siddique
Added a sleep of 2 seconds before generating a test packet in ovn.at so that ovn-northd reads the northbound db changes and updates the southbound db. Signed-off-by: Numan Siddique --- tests/ovn.at | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/ovn.at b/tests/ovn.at index 30ca127

[ovs-dev] [PATCH v2 0/1 RFC] ovn: Support native dhcp using 'continuations'

2016-04-18 Thread Numan Siddique
u": "1450", "netmask": "255.255.255.0", "router": "20.0.0.1", "server_mac": "fa:16:3e:3e:b8:8b", "classless_static_route": "{30.0.0.0/24,20.0.0.4, 0.0.0.0/0,20.0.0.1}"

[ovs-dev] [PATCH v2 RFC] ovn: Support native dhcp using 'continuations'

2016-04-18 Thread Numan Siddique
dhcp options set in the 'userdata' and resume the packet. TODO: Test cases and updating the necessary documentation. Signed-off-by: Numan Siddique --- lib/dhcp.h | 13 +++ ovn/controller/lflow.c | 55 ++ ovn/controller/pinctrl.c| 102

Re: [ovs-dev] [PATCH RFC] ovn: distributed logical port for VM metadata access

2016-04-19 Thread Numan Siddique
> > We can use the dhcp-port (and its IP address) for the distributed-port. > > The current native-dhcp proposal > (http://openvswitch.org/pipermail/dev/2016-April/069787.html) > assumes that a dhcp-server ip-address "server_id" is defined on the subnet. > > action=(dhcp_offer(offerip = 10.0.0.2, r

Re: [ovs-dev] [PATCH v2 RFC] ovn: Support native dhcp using 'continuations'

2016-04-20 Thread Numan Siddique
On Thu, Apr 21, 2016 at 4:53 AM, Ramu Ramamurthy wrote: > Tested-by: Ramu Ramamurthy > > Numan, I tested this patch to work on devstack+ovn without the > openstack-plugin, > with manual configuration. > > Notes: > > 1) In ovn/utilities/ovn-nbctl.c, usage() Can you add a help string to > ovn-nbct

[ovs-dev] [PATCH v3 0/2] ovn: Support native DHCP using 'continuations'

2016-04-28 Thread Numan Siddique
t;20.0.0.1", "server_mac": "fa:16:3e:3e:b8:8b", "classless_static_route": "{30.0.0.0/24,20.0.0.4, 0.0.0.0/0,20.0.0.1}"}" * Few other small changes. TODO : * Add a new table in southbound db and store the supported dhcp option names and cod

[ovs-dev] [PATCH v3 1/2] ovn: Support 'dhcp_offer' action in ovn-controller

2016-04-28 Thread Numan Siddique
atch will add logical flows with this action. Signed-Off-by: Numan Siddique --- lib/dhcp.h | 13 ovn/controller/lflow.c | 11 ovn/controller/pinctrl.c | 103 +++- ovn/lib/actions.c| 151

[ovs-dev] [PATCH v3 2/2] ovn: Add logical flows to support native DHCP

2016-04-28 Thread Numan Siddique
at each compute host running ovn-controller. A new table 'Subnet' is added in OVN NB DB to store the DHCP options. A logical flow is added for each logical port to handle DHCP packets using the 'dhcp_offer' action if the CMS has defined DHCP options in the 'Subnet'

Re: [ovs-dev] [PATCH v2 RFC] ovn: Support native dhcp using 'continuations'

2016-05-03 Thread Numan Siddique
On Fri, Apr 22, 2016 at 10:06 PM, Ben Pfaff wrote: > On Mon, Apr 18, 2016 at 10:59:16PM +0530, Numan Siddique wrote: > > To support native dhcp in ovn > > - A new column 'dhcp-options' is added in 'Logical_Switch' north db. > > - A logical flow is a

Re: [ovs-dev] [PATCH v3 2/2] ovn: Add logical flows to support nativeDHCP

2016-05-03 Thread Numan Siddique
On Mon, May 2, 2016 at 9:32 PM, Ryan Moats wrote: > "dev" wrote on 04/28/2016 08:51:41 AM: > > > From: Numan Siddique > > To: ovs dev > > Date: 04/28/2016 08:52 AM > > Subject: [ovs-dev] [PATCH v3 2/2] ovn: Add logical flows to support > &g

Re: [ovs-dev] ovn: Issue in ACL stage when the dhcp reply packet is resumed

2016-05-06 Thread Numan Siddique
tax such as > "output(inport)" to imply that the response is a packet-out to the inport > from which packet came. Suggestion are welcome. > > Thank you, > Babu > > > On Wednesday 13 April 2016 09:23 PM, Numan Siddique wrote: > >> Hi, >> >> I a

[ovs-dev] [PATCH v4 0/2] ovn: Support native DHCP using 'continuations'

2016-05-06 Thread Numan Siddique
quot;mtu": "1450", "netmask": "255.255.255.0", "router": "20.0.0.1", "server_mac": "fa:16:3e:3e:b8:8b", "classless_static_route": "{30.0.0.0/24,20.0.0.4, 0.0.0.0/0,2

[ovs-dev] [PATCH v4 1/2] ovn: Support 'dhcp_offer' action in ovn-controller

2016-05-06 Thread Numan Siddique
atch will add logical flows with this action. Signed-Off-by: Numan Siddique --- lib/dhcp.h | 13 ovn/controller/lflow.c | 11 ovn/controller/pinctrl.c | 103 +++- ovn/lib/actions.c| 151

[ovs-dev] [PATCH v4 2/2] ovn: Add logical flows to support native DHCP

2016-05-06 Thread Numan Siddique
at each compute host running ovn-controller. A new table 'Subnet' is added in OVN NB DB to store the DHCP options. A logical flow is added for each logical port to handle DHCP packets using the 'dhcp_offer' action if the CMS has defined DHCP options in the 'Subnet'

Re: [ovs-dev] ovn: Issue in ACL stage when the dhcp reply packet is resumed

2016-05-09 Thread Numan Siddique
_put(&packet, pin->public.packet, pin->public.packet_len); +pkt_metadata_from_flow(&packet.md, &pin->public.flow_metadata.flow); struct flow headers; flow_extract(&packet, &headers); -- Thanks Numan On Fri, May 6, 2016 at 6:35 PM, Numan Siddique w

Re: [ovs-dev] [PATCH v4 1/2] ovn: Support 'dhcp_offer' action in ovn-controller

2016-05-09 Thread Numan Siddique
> > > > size_t oc_offset = start_controller_op(ctx->ofpacts, >ACTION_OPCODE_DHCP_OFFER, true); > while (!lexer_match(ctx->lexer, LEX_T_RPAREN)) { > if (!parse_dhcp_option(ctx, ctx->ofpacts)) { > return; > } > } >

Re: [ovs-dev] ovn: Issue in ACL stage when the dhcp reply packet is resumed

2016-05-10 Thread Numan Siddique
ould you send a patch formatted by git format-patch with your > Signed-off-by? > > Jarno > > > On May 9, 2016, at 1:55 AM, Numan Siddique wrote: > > > > The below fix is resolving the issue. But I am not sure if that's the > right > > solutio

[ovs-dev] [PATCH] vswitchd: Restore the packet metadata when the packet is resumed

2016-05-10 Thread Numan Siddique
Recirculations due to NXT_RESUME are failing if the packet metadata is not restored prior to the packet execution. Reported-at: http://openvswitch.org/pipermail/dev/2016-May/070723.html Signed-Off-by: Numan Siddique --- ofproto/ofproto-dpif.c | 9 + 1 file changed, 9 insertions(+) diff

[ovs-dev] [PATCH v4 0/2] ovn: Support native DHCP using 'continuations'

2016-05-16 Thread Numan Siddique
"router": "20.0.0.1", "server_mac": "fa:16:3e:3e:b8:8b", "classless_static_route": "{30.0.0.0/24,20.0.0.4, 0.0.0.0/0,20.0.0.1}"}" * Few other small changes. TODO : * Add a new table in southbound db and store the supported dhcp option nam

[ovs-dev] [PATCH v4 2/2] ovn: Add logical flows to support native DHCP

2016-05-16 Thread Numan Siddique
the DHCP request packets using the 'put_dhcp_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCP reponder by sending the DHCP reply back to the inport once the 'put_dhcp_opts' action is applied. Signed-Off-by: Numan Si

[ovs-dev] [PATCH v4 1/2] ovn-controller: Add 'put_dhcp_opts' action in ovn-controller

2016-05-16 Thread Numan Siddique
to popule this table. The next patch will add logical flows with this action. Signed-Off-by: Numan Siddique --- include/openvswitch/meta-flow.h | 12 +++ lib/dhcp.h | 13 +++ ovn/controller/lflow.c | 11 +++ ovn/controller/pinctrl.c| 169

Re: [ovs-dev] [PATCH v4 0/2] ovn: Support native DHCP using 'continuations'

2016-05-16 Thread Numan Siddique
Please ignore this patch set as the version should have been 5 instead of 4. I am sending another one to be consistent with the versions. On Mon, May 16, 2016 at 2:42 PM, Numan Siddique wrote: > v3 -> v4 changes > > > * Addressed the v3 review comments >

[ovs-dev] [PATCH v5 0/2] ovn: Support native DHCP using 'continuations'

2016-05-16 Thread Numan Siddique
"mtu": "1450", "netmask": "255.255.255.0", "router": "20.0.0.1", "server_mac": "fa:16:3e:3e:b8:8b", "classless_static_route": "{30.0.0.0/24,20.0.0.4, 0.0.0.0/0,20.0.0.1}&q

[ovs-dev] [PATCH v5 1/2] ovn-controller: Add 'put_dhcp_opts' action in ovn-controller

2016-05-16 Thread Numan Siddique
to popule this table. The next patch will add logical flows with this action. Signed-Off-by: Numan Siddique --- include/openvswitch/meta-flow.h | 12 +++ lib/dhcp.h | 13 +++ ovn/controller/lflow.c | 11 +++ ovn/controller/pinctrl.c| 169

[ovs-dev] [PATCH v5 2/2] ovn: Add logical flows to support native DHCP

2016-05-16 Thread Numan Siddique
the DHCP request packets using the 'put_dhcp_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCP reponder by sending the DHCP reply back to the inport once the 'put_dhcp_opts' action is applied. Signed-Off-by: Numan Si

Re: [ovs-dev] [PATCH v5 2/2] ovn: Add logical flows to support native DHCP

2016-05-17 Thread Numan Siddique
flow from ovn-northd and let CMS add it. I initially thought its good to take care of it on ovn-northd. But now I am not sure whats the best approach. Please let me know your comments. Thanks Numan ​ > On Mon, May 16, 2016 at 2:23 AM, Numan Siddique > wrote: > > OVN implements

Re: [ovs-dev] [PATCH v4 1/2] ovn: Support 'dhcp_offer' action in ovn-controller

2016-05-17 Thread Numan Siddique
) > > > > A new 'DHCP_Options' table is added in SB DB which stores > > the support DHCP options with DHCP code and type. ovn-northd is > > expected to popule this table. > > > > The next patch will add logical flows with this action. > > >

[ovs-dev] [PATCH v6 0/2] ovn: Support native DHCP using 'continuations'

2016-05-19 Thread Numan Siddique
200", "mtu": "1450", "netmask": "255.255.255.0", "router": "20.0.0.1", "server_mac": "fa:16:3e:3e:b8:8b", "classless_static_route": "{30.0.0.0/24,20.0

[ovs-dev] [PATCH v6 1/2] ovn-controller: Add 'put_dhcp_opts' action in ovn-controller

2016-05-19 Thread Numan Siddique
to popule this table. The next patch will add logical flows with this action. Signed-Off-by: Numan Siddique --- include/openvswitch/meta-flow.h | 12 +++ lib/dhcp.h | 13 +++ ovn/controller/lflow.c | 11 +++ ovn/controller/pinctrl.c| 169

[ovs-dev] [PATCH v6 2/2] ovn: Add logical flows to support native DHCP

2016-05-19 Thread Numan Siddique
the DHCP request packets using the 'put_dhcp_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCP reponder by sending the DHCP reply back to the inport once the 'put_dhcp_opts' action is applied. Signed-Off-by: Numan Si

Re: [ovs-dev] [PATCH] Restrict use of unspecified source addresses

2016-05-19 Thread Numan Siddique
On Wed, May 18, 2016 at 11:26 PM, Dustin Lundquist wrote: > Restrict use of the unspecified source addresses (:: and 0.0.0.0) to > traffic necessary to obtain an IP address. DHCP discovery messages for > the IPv4 case, and ICMP6 types necessary for duplicate address detection > for IPv6. > > This

[ovs-dev] [PATCH v7 0/2] ovn: Support native DHCP using 'continuations'

2016-05-20 Thread Numan Siddique
"server_mac": "fa:16:3e:3e:b8:8a"}" "20.0.0.0/24": "{"server_id": "20.0.0.1", "lease_time": "43200", "mtu": "1450", "netmask": "255.255.255.0", "router&qu

[ovs-dev] [PATCH v7 1/2] ovn-controller: Add 'put_dhcp_opts' action in ovn-controller

2016-05-20 Thread Numan Siddique
to popule this table. The next patch will add logical flows with this action. Signed-Off-by: Numan Siddique --- include/openvswitch/meta-flow.h | 12 +++ lib/dhcp.h | 13 +++ ovn/controller/lflow.c | 11 +++ ovn/controller/pinctrl.c| 169

[ovs-dev] [PATCH v7 2/2] ovn-northd: Add logical flows to support native DHCP

2016-05-20 Thread Numan Siddique
the DHCP request packets using the 'put_dhcp_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCP reponder by sending the DHCP reply back to the inport once the 'put_dhcp_opts' action is applied. Signed-Off-by: Numan Si

Re: [ovs-dev] [PATCH v7 1/2] ovn-controller: Add 'put_dhcp_opts' action in ovn-controller

2016-05-23 Thread Numan Siddique
On Tue, May 24, 2016 at 12:42 AM, Ramu Ramamurthy wrote: > Tested-by: Ramu Ramamurthy > > I tested this patchset to work end-to-end with openstack (with the > corresponding WIP openstack patch). > > > +/* Check that the DHCP Message Type (opt 53) is present or not with > > + * valid valu

[ovs-dev] [PATCH v8 0/2] ovn: Support native DHCP using 'continuations'

2016-05-24 Thread Numan Siddique
;: "43200", "mtu": "1450", "netmask": "255.255.255.0", "router": "20.0.0.1", "server_mac": "fa:16:3e:3e:b8:8b", "classless_static_route": "{30.0.0.0

[ovs-dev] [PATCH v8 1/2] ovn-controller: Add 'put_dhcp_opts' action in ovn-controller

2016-05-24 Thread Numan Siddique
to popule this table. The next patch will add logical flows with this action. Signed-Off-by: Numan Siddique --- include/openvswitch/meta-flow.h | 12 +++ lib/dhcp.h | 13 +++ ovn/controller/lflow.c | 11 +++ ovn/controller/pinctrl.c| 185 +++

[ovs-dev] [PATCH v8 2/2] ovn-northd: Add logical flows to support native DHCP

2016-05-24 Thread Numan Siddique
the DHCP request packets using the 'put_dhcp_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCP reponder by sending the DHCP reply back to the inport once the 'put_dhcp_opts' action is applied. Signed-Off-by: Numan Si

[ovs-dev] [PATCH v9 0/2] ovn: Support native DHCP using 'continuations'

2016-06-03 Thread Numan Siddique
t;{"server_id": "20.0.0.1", "lease_time": "43200", "mtu": "1450", "netmask": "255.255.255.0", "router": "20.0.0.1", "server_mac": "fa:16:3e:3e:b8:8b"

[ovs-dev] [PATCH v9 1/2] ovn-controller: Add 'put_dhcp_opts' action in ovn-controller

2016-06-03 Thread Numan Siddique
to popule this table. The next patch will add logical flows with this action. Signed-Off-by: Numan Siddique --- include/openvswitch/meta-flow.h | 12 +++ lib/dhcp.h | 13 +++ ovn/controller/lflow.c | 11 +++ ovn/controller/pinctrl.c| 188

[ovs-dev] [PATCH v9 2/2] ovn-northd: Add logical flows to support native DHCP

2016-06-03 Thread Numan Siddique
the DHCP request packets using the 'put_dhcp_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCP reponder by sending the DHCP reply back to the inport once the 'put_dhcp_opts' action is applied. Signed-Off-by: Numan Si

[ovs-dev] Resumed IPv6 packets from the controller are getting dropped

2016-06-03 Thread Numan Siddique
Hi, I am working on native DHCPv6 in OVN. During my testing I have noticed that the DHCPv6 reply packets from the ovn-controller are dropped by the kernel for checksum errors. I am not seeing this issue with 4.6 kernels. Figured out that its fixed in the latest kernels and the fix is here [1].

[ovs-dev] [RFC PATCH] ovn: Support native DHCPv6

2016-06-06 Thread Numan Siddique
(if needed) Signed-Off-by: Numan Siddique --- lib/packets.c| 19 lib/packets.h| 2 + ovn/controller/lflow.c | 5 + ovn/controller/pinctrl.c | 265 +++ ovn/lib/actions.c| 106 +++ ovn/lib/ac

[ovs-dev] [PATCH v5] ovn-northd: Add logical flows to support native DHCPv4

2016-07-14 Thread Numan Siddique
ion is applied. Signed-off-by: Numan Siddique Co-authored-by: Ben Pfaff Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.8.xml | 91 +- ovn/northd/ovn-northd.c | 256 +- ovn/ovn-nb.ovsschema | 20 ++- ovn/o

[ovs-dev] [PATCH] ovn: Add 128-bit support for ct_label

2016-07-15 Thread Numan Siddique
To support 128-bits in ct_label, the value of the ct_label is expected as a hex string in the 'ct_commit' action. Added a new accessor in the 'mf_subvalue' struct to access ovs_be128 values. Signed-Off-by: Numan Siddique --- include/openvswitch/meta-flow.h

[ovs-dev] [PATCH v2] ovn: Add 128-bit support for ct_label

2016-07-15 Thread Numan Siddique
To support 128-bits in ct_label, the value of the ct_label is expected as a hex string in the 'ct_commit' action. Added a new accessor in the 'mf_subvalue' struct to access ovs_be128 values. Signed-Off-by: Numan Siddique --- include/openvswitch/meta-flow.h

[ovs-dev] [PATCH v1 0/2] ovn: Support native DHCPv6

2016-07-18 Thread Numan Siddique
This patch set implements native DHCPv6 in OVN. Patch 2 depends on the ovn-northd DHCPv4 patch - https://patchwork.ozlabs.org/patch/648487/ - Numan Siddique (2): ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller ovn-northd: Add logical flows to supp

[ovs-dev] [PATCH v1 1/2] ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller

2016-07-18 Thread Numan Siddique
table. Upcoming patch will add logical flows with this action. Signed-off-by: Numan Siddique --- ovn/controller/lflow.c | 6 + ovn/controller/pinctrl.c | 295 +++ ovn/lib/actions.c| 114 ++ ovn/lib/actions.h| 9 ++ ov

[ovs-dev] [PATCH v1 2/2] ovn-northd: Add logical flows to support DHCPv6

2016-07-18 Thread Numan Siddique
ons to the DHCPv6 request packets using the 'put_dhcpv6_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCPv6 reponder by sending the DHCPv6 reply back to the inport once the 'put_dhcpv6_opts' action is applied. Signed-of

Re: [ovs-dev] [PATCH] ovn: Add 128-bit support for ct_label

2016-07-18 Thread Numan Siddique
On Mon, Jul 18, 2016 at 11:40 PM, Ben Pfaff wrote: > On Fri, Jul 15, 2016 at 08:33:59PM +0530, Numan Siddique wrote: > > To support 128-bits in ct_label, the value of the ct_label is expected > > as a hex string in the 'ct_commit' action. > > > > Added a new

Re: [ovs-dev] [ovs-dev, v23, 2/2] ovn-controller: Add incremental processing to lflow_run and physical_run

2016-07-19 Thread Numan Siddique
On Tue, Jul 19, 2016 at 5:40 PM, Ryan Moats wrote: > Ben Pfaff wrote on 07/19/2016 12:57:23 AM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: dev@openvswitch.org > > Date: 07/19/2016 12:57 AM > > Subject: Re: [ovs-dev, v23, 2/2] ovn-controller: Add incremental > > processing

[ovs-dev] [PATCH v6] ovn-northd: Add logical flows to support native DHCPv4

2016-07-20 Thread Numan Siddique
ion is applied. Signed-off-by: Numan Siddique Co-authored-by: Ben Pfaff Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.8.xml | 91 +- ovn/northd/ovn-northd.c | 256 +- ovn/ovn-nb.ovsschema | 20 ++- ovn/o

[ovs-dev] [PATCH] python: Send old values of the updated cols in notify for update2

2016-07-21 Thread Numan Siddique
r. This patch fixes this issue. It also updates the description of the 'updates' param of the notify function to make it more clear. Fixes: 897c8064 ("python: move Python idl to work with monitor_cond") Signed-off-by: Numan Siddique --- python/ovs/db/idl.py | 19 ++

[ovs-dev] [PATCH v7] ovn-northd: Add logical flows to support native DHCPv4

2016-07-23 Thread Numan Siddique
ion is applied. Signed-off-by: Numan Siddique Co-authored-by: Ben Pfaff Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.8.xml | 91 +- ovn/northd/ovn-northd.c | 256 +- ovn/ovn-nb.ovsschema | 20 ++- ovn/o

Re: [ovs-dev] [PATCH] ovn: remove the dead code.

2016-07-24 Thread Numan Siddique
On Sun, Jul 24, 2016 at 6:26 AM, Ryan Moats wrote: > "dev" wrote on 07/21/2016 05:36:13 AM: > > > From: nickcooper-zhangtonghao > > To: dev@openvswitch.org > > Cc: nickcooper-zhangtonghao > > Date: 07/21/2016 05:36 AM > > Subject: [ovs-dev] [PATCH] ovn: remove the dead code. > > Sent by: "dev"

Re: [ovs-dev] [PATCH] python: Send old values of the updated cols in notify for update2

2016-07-25 Thread Numan Siddique
On Mon, Jul 25, 2016 at 10:10 PM, Russell Bryant wrote: > > On Thu, Jul 21, 2016 at 6:21 AM, Numan Siddique > wrote: > >> When python IDL calls the "notify" function after processing the "update2" >> message from ovsdb-server, it is suppose to send

Re: [ovs-dev] Compiler warnings with gcc 6.1 (On Fedora 24)

2016-07-26 Thread Numan Siddique
On Tue, Jul 26, 2016 at 6:02 PM, Russell Bryant wrote: > > > On Tue, Jul 5, 2016 at 1:10 AM, Numan Siddique > wrote: > >> > >> > >> > >> > OK. >> > >> > If you have time and the inclination, please feel free to experiment

[ovs-dev] [PATCH v2] python: Send old values of the updated cols in notify for update2

2016-07-26 Thread Numan Siddique
r. This patch fixes this issue. It also updates the description of the 'updates' param of the notify function to make it more clear. Fixes: 897c8064 ("python: move Python idl to work with monitor_cond") Signed-off-by: Numan Siddique --- python/ovs/db/

[ovs-dev] [PATCH v2 2/2] ovn-northd: Add logical flows to support DHCPv6

2016-07-26 Thread Numan Siddique
ons to the DHCPv6 request packets using the 'put_dhcpv6_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCPv6 reponder by sending the DHCPv6 reply back to the inport once the 'put_dhcpv6_opts' action is applied. Signed-of

[ovs-dev] [PATCH v2 1/2] ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller

2016-07-26 Thread Numan Siddique
table. Upcoming patch will add logical flows with this action. Signed-off-by: Numan Siddique --- ovn/controller/lflow.c | 7 ++ ovn/controller/pinctrl.c | 295 +++ ovn/lib/actions.c| 114 ++ ovn/lib/actions.h| 9 ++

Re: [ovs-dev] [PATCH v1 1/2] ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller

2016-07-26 Thread Numan Siddique
On Wed, Jul 27, 2016 at 12:01 AM, Ben Pfaff wrote: > On Tue, Jul 19, 2016 at 12:36:43AM +0530, Numan Siddique wrote: > > This patch adds a new OVN action 'put_dhcpv6_opts' to support native > > DHCPv6 in OVN. > > > > ovn-controller parses this action and a

[ovs-dev] [PATCH v2 0/2] ovn: Native DHCPv6 Support

2016-07-26 Thread Numan Siddique
This patch set implements native DHCPv6 in OVN. Patch 2 depends on the ovn-northd DHCPv4 patch - https://patchwork.ozlabs.org/patch/651958/ v1 -> v2 * Resolved the merge conflicts and rebased. ---- Numan Siddique (2): ovn-controller: Add 'put_dhcpv6_opts'

[ovs-dev] [PATCH v1 0/3] ovn: Support native DHCPv4 and DHCPv6 proposal

2016-07-26 Thread Numan Siddique
This patch series support native DHCPv4 and native DHCPv6 in OVN. Patch 1 adds DHCPv4 logical flows in ovn northd. It uses the OVN action "put_dhcp_opts". Patch 2 and 3 adds native DHCPv6 support. -------- Numan Siddique (3): ovn-northd: Add logical flows to support nat

[ovs-dev] [PATCH v1 1/3] ovn-northd: Add logical flows to support native DHCPv4

2016-07-26 Thread Numan Siddique
ion is applied. Signed-off-by: Numan Siddique Co-authored-by: Ben Pfaff Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.8.xml | 91 +- ovn/northd/ovn-northd.c | 256 +- ovn/ovn-nb.ovsschema | 20 ++- ovn/o

[ovs-dev] [PATCH v1 3/3] ovn-northd: Add logical flows to support DHCPv6

2016-07-26 Thread Numan Siddique
ons to the DHCPv6 request packets using the 'put_dhcpv6_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCPv6 reponder by sending the DHCPv6 reply back to the inport once the 'put_dhcpv6_opts' action is applied. Signed-of

[ovs-dev] [PATCH v1 2/3] ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller

2016-07-26 Thread Numan Siddique
table. Upcoming patch will add logical flows with this action. Signed-off-by: Numan Siddique --- ovn/controller/lflow.c | 7 ++ ovn/controller/pinctrl.c | 295 +++ ovn/lib/actions.c| 114 ++ ovn/lib/actions.h| 9 ++

Re: [ovs-dev] [ovs-dev, v2, 2/2] ovn-northd: Add logical flows to support DHCPv6

2016-07-26 Thread Numan Siddique
On Wed, Jul 27, 2016 at 12:08 AM, Ben Pfaff wrote: > On Wed, Jul 27, 2016 at 12:01:06AM +0530, Numan Siddique wrote: > > OVN implements native DHCPv6. DHCPv6 options are stored > > in the 'DHCP_Options' NB table and logical ports refer to this > > table

Re: [ovs-dev] [PATCH v1 1/3] ovn-northd: Add logical flows to support native DHCPv4

2016-07-26 Thread Numan Siddique
This patch has "Tested-by: Ramu Ramamurthy " and "Acked-by: Ramu Ramamurthy " and every time I forget to add this when I resubmit the patch. Ramu - My apologies Thanks Numan On Wed, Jul 27, 2016 at 12:54 AM, Numan Siddique wrote: > OVN implements a native DHCPv4 supp

Re: [ovs-dev] [PATCH v1 2/3] ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller

2016-07-26 Thread Numan Siddique
On Wed, Jul 27, 2016 at 2:07 AM, Ben Pfaff wrote: > On Wed, Jul 27, 2016 at 12:55:00AM +0530, Numan Siddique wrote: > > This patch adds a new OVN action 'put_dhcpv6_opts' to support native > > DHCPv6 in OVN. > > > > ovn-controller parses this action and a

Re: [ovs-dev] [PATCH] ovn-nbctl: Improve usage message.

2016-07-27 Thread Numan Siddique
n\ > - displays the DHCP options of th > DHCP_OPTIONS_UUID\n\ > + displays the DHCP options for > DHCP_OPTIONS_UUID\n\ > \n\ > %s\ > \n\ > Sorry for the typo and incorrect grammar in the original patch Acked-by: Numan Siddi

[ovs-dev] [PATCH v2 0/2] ovn: Support native DHCPv6

2016-07-27 Thread Numan Siddique
Patch 1 of the version 1 of the series is merged. v1 -> v2 patch 1 * Renamed the DHCPv6 option names from caps to lower cases * Updated documentation patch 2 * Addressed the review comments * Updated documentation -- Numan Siddique (2): ovn-controller:

[ovs-dev] [PATCH v2 1/2] ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller

2016-07-27 Thread Numan Siddique
Upcoming patch will add logical flows using this action. Signed-off-by: Numan Siddique --- ovn/controller/lflow.c | 16 ++- ovn/controller/pinctrl.c | 295 +++ ovn/lib/actions.c| 114 ++ ovn/lib/actions.h| 12 ++ ov

[ovs-dev] [PATCH v2 2/2] ovn-northd: Add logical flows to support DHCPv6

2016-07-27 Thread Numan Siddique
ons to the DHCPv6 request packets using the 'put_dhcpv6_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCPv6 reponder by sending the DHCPv6 reply back to the inport once the 'put_dhcpv6_opts' action is applied. Signed-of

[ovs-dev] [PATCH] ovn-controller: Add datapath-type in chassis:external_ids

2016-07-28 Thread Numan Siddique
some actions based on it. One usecase is, OVN neutron plugin can use this information to set the vif_type (ovs or vhostuser) during the port binding. Signed-off-by: Numan Siddique --- ovn/controller/chassis.c | 36 tests/ovn-controller.at | 48

Re: [ovs-dev] [PATCH] ovn-controller: Add datapath-type in chassis:external_ids

2016-07-28 Thread Numan Siddique
On Thu, Jul 28, 2016 at 10:28 PM, Ben Pfaff wrote: > On Thu, Jul 28, 2016 at 08:05:20PM +0530, Numan Siddique wrote: > > This patch reads the external_ids:datapath-type value from the > > Open_vSwitch table if defined and sets it in the > external_ids:datapath-type > > of

[ovs-dev] [PATCH v2] ovn-controller: Add datapath-type in chassis:external_ids

2016-07-29 Thread Numan Siddique
based on it. One usecase is, OVN neutron plugin can use this information to set the vif_type (ovs or vhostuser) during the port binding. Signed-off-by: Numan Siddique --- ovn/controller/chassis.c| 38 ++ ovn/controller/chassis.h| 3 ++- ovn

[ovs-dev] [PATCH v3] ovn-controller: Add datapath-type in chassis:external_ids

2016-07-29 Thread Numan Siddique
based on it. One usecase is, OVN neutron plugin can use this information to set the vif_type (ovs or vhostuser) during the port binding. Signed-off-by: Numan Siddique --- ovn/controller/chassis.c| 38 ++ ovn/controller/chassis.h| 3 ++- ovn

[ovs-dev] [PATCH v4] ovn-controller: Add datapath-type and iface-types in chassis:external_ids

2016-07-30 Thread Numan Siddique
itoring OVN SB DB to determine the datapath type (DPDK or non-DPDK) configured and take some actions based on it. One usecase is, OVN neutron plugin can use this information to set the vif_type (ovs or vhostuser) during the port binding. Signed-off-by: Numan Siddique --- ovn/controller/chass

[ovs-dev] [PATCH v3 0/2] ovn: Support native DHCPv6

2016-07-30 Thread Numan Siddique
v2 -> v3 --- * Rebased the code. * Patch had merge conflict. Resolved it. v1 -> v2 patch 1 * Renamed the DHCPv6 option names from caps to lower cases * Updated documentation patch 2 * Addressed the review comments * Updated documentation -- Numan Si

[ovs-dev] [PATCH v3 2/2] ovn-northd: Add logical flows to support DHCPv6

2016-07-30 Thread Numan Siddique
ons to the DHCPv6 request packets using the 'put_dhcpv6_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCPv6 reponder by sending the DHCPv6 reply back to the inport once the 'put_dhcpv6_opts' action is applied. Signed-of

[ovs-dev] [PATCH v3 1/2] ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller

2016-07-30 Thread Numan Siddique
Upcoming patch will add logical flows using this action. Signed-off-by: Numan Siddique --- include/ovn/actions.h| 12 ++ ovn/controller/lflow.c | 16 ++- ovn/controller/pinctrl.c | 295 +++ ovn/lib/actions.c| 114 ++ ov

[ovs-dev] [PATCH v4 0/2] ovn: Support native DHCPv6

2016-08-01 Thread Numan Siddique
Addressed the review comments * Updated documentation -- Numan Siddique (2): ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller ovn-northd: Add logical flows to support DHCPv6 include/ovn/actions.h | 11 ++ lib/packets.h | 1 + ovn

[ovs-dev] [PATCH v4 2/2] ovn-northd: Add logical flows to support DHCPv6

2016-08-01 Thread Numan Siddique
ons to the DHCPv6 request packets using the 'put_dhcpv6_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCPv6 reponder by sending the DHCPv6 reply back to the inport once the 'put_dhcpv6_opts' action is applied. Signed-of

[ovs-dev] [PATCH v4 1/2] ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller

2016-08-01 Thread Numan Siddique
Upcoming patch will add logical flows using this action. Signed-off-by: Numan Siddique --- include/ovn/actions.h| 11 ++ ovn/controller/lflow.c | 16 ++- ovn/controller/pinctrl.c | 295 +++ ovn/lib/actions.c| 114 ++ ov

[ovs-dev] [PATCH v5 0/2] ovn: Support native DHCPv6

2016-08-04 Thread Numan Siddique
* Updated documentation patch 2 * Addressed the review comments * Updated documentation -- Numan Siddique (2): ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller ovn-northd: Add logical flows to support DHCPv6 include/ovn/actions.h |

[ovs-dev] [PATCH v5 2/2] ovn-northd: Add logical flows to support DHCPv6

2016-08-04 Thread Numan Siddique
ons to the DHCPv6 request packets using the 'put_dhcpv6_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCPv6 reponder by sending the DHCPv6 reply back to the inport once the 'put_dhcpv6_opts' action is applied. Signed-of

[ovs-dev] [PATCH v5 1/2] ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller

2016-08-04 Thread Numan Siddique
Upcoming patch will add logical flows using this action. Signed-off-by: Numan Siddique --- include/ovn/actions.h| 11 ++ ovn/controller/lflow.c | 16 ++- ovn/controller/pinctrl.c | 295 +++ ovn/lib/actions.c| 114 ++ ov

[ovs-dev] [PATCH] ovn-controller: Reset flow processing after (re)connection to switch

2016-08-09 Thread Numan Siddique
alled after the reconnection - the hmap "installed_flows" is not cleared, because of which ofctrl_put skips adding the flows to the switch. This patch fixes the issue and also adds a test case to test this scenario. Signed-off-by: Numan Siddique --- ovn/controller/ofctrl.c | 7 ++

Re: [ovs-dev] [PATCH] ovn-controller: Reset flow processing after (re)connection to switch

2016-08-09 Thread Numan Siddique
On Tue, Aug 9, 2016 at 7:15 PM, Ryan Moats wrote: > "dev" wrote on 08/09/2016 07:19:27 AM: > > > From: Numan Siddique > > To: ovs dev > > Date: 08/09/2016 07:19 AM > > Subject: [ovs-dev] [PATCH] ovn-controller: Reset flow processing > > af

Re: [ovs-dev] [PATCH] ovn-controller: Reset flow processing after (re)connection to switch

2016-08-09 Thread Numan Siddique
On Aug 9, 2016 8:28 PM, "Ryan Moats" wrote: > > Numan Siddique wrote on 08/09/2016 09:39:21 AM: > > > From: Numan Siddique > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: ovs dev > > Date: 08/09/2016 09:39 AM > > Subject: Re: [ovs-dev] [PATCH] ov

Re: [ovs-dev] [PATCH] ovn-controller: Reset flow processing after (re)connection to switch

2016-08-11 Thread Numan Siddique
On Wed, Aug 10, 2016 at 6:07 AM, Numan Siddique wrote: > On Aug 9, 2016 8:28 PM, "Ryan Moats" wrote: > > > > Numan Siddique wrote on 08/09/2016 09:39:21 AM: > > > > > From: Numan Siddique > > > To: Ryan Moats/Omaha/IBM@IBMUS > > > Cc:

[ovs-dev] [PATCH v2] ovn-controller: Reset flow processing after (re)connection to switch

2016-08-11 Thread Numan Siddique
alled after the reconnection - the hmap "installed_flows" is not cleared, because of which ofctrl_put skips adding the flows to the switch. This patch fixes the issue and also adds a test case to test this scenario. Signed-off-by: Numan Siddique --- ovn/controller/ofctrl.c | 7 +++

Re: [ovs-dev] [PATCH v2] ovn-controller: Reset flow processing after (re)connection to switch

2016-08-11 Thread Numan Siddique
On Thu, Aug 11, 2016 at 7:45 PM, Ryan Moats wrote: > "dev" wrote on 08/11/2016 07:21:39 AM: > > > > > Signed-off-by: Numan Siddique > > --- > > This all looks does what it promises, so let's get the immediate > out of the way: > > A

[ovs-dev] [PATCH v10 0/2] ovn: Support native DHCP using 'continuations'

2016-06-06 Thread Numan Siddique
ot;, "lease_time": "43200", "mtu": "1450", "netmask": "255.255.255.0", "router": "20.0.0.1", "server_mac": "fa:16:3e:3e:b8:8b", "classless_static_rou

[ovs-dev] [PATCH v10 1/2] ovn-controller: Add 'put_dhcp_opts' action in ovn-controller

2016-06-06 Thread Numan Siddique
to popule this table. The next patch will add logical flows with this action. Signed-Off-by: Numan Siddique --- include/openvswitch/meta-flow.h | 12 +++ lib/dhcp.h | 13 +++ ovn/controller/lflow.c | 11 +++ ovn/controller/pinctrl.c| 188

[ovs-dev] [PATCH v10 2/2] ovn-northd: Add logical flows to support native DHCP

2016-06-06 Thread Numan Siddique
the DHCP request packets using the 'put_dhcp_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCP reponder by sending the DHCP reply back to the inport once the 'put_dhcp_opts' action is applied. Signed-Off-by: Numan Si

Re: [ovs-dev] [PATCH] [PATCH v3 1/2] ovn-controller: Add 'na' action for ND

2016-06-08 Thread Numan Siddique
> > > --- a/ovn/ovn-sb.xml > +++ b/ovn/ovn-sb.xml > @@ -985,6 +985,55 @@ >Prerequisite: ip4 > > > + > + na{A; action; ... > }; > + > + > + > + > +Temporarily replaces the IPv6 packet being processed by an NA > +

Re: [ovs-dev] [PATCH] [PATCH v3 2/2] ovn: add lflows for 'na' action for ND

2016-06-08 Thread Numan Siddique
This patch fails to apply on the latest master. Thanks Numan On Wed, Jun 8, 2016 at 12:58 PM, Zong Kai LI wrote: > This patch adds some lflows for 'na' action to support ND versus ARP. > > For ovn-northd, it will generate lflows per each IPv6 address on > echo lport, with lport mac and IPv6 ad

Re: [ovs-dev] [PATCH v10 2/2] ovn-northd: Add logical flows to support native DHCP

2016-06-08 Thread Numan Siddique
ptions > that are used when VMs boot. > > On Mon, Jun 6, 2016 at 10:49 PM, Numan Siddique > wrote: > > OVN implements a native DHCP support which caters to the common > > use case of providing an IP address to a booting instance by > > providing stateless replies to DHCP

  1   2   3   >