Re: [ovs-dev] [PATCH] ovn: Update BFD item in the ovn TODO list.

2015-11-23 Thread Kyle Mestery
-* Use BFD as tunnel monitor. > +* Consider the use BFD as tunnel monitor. > > This reads odd to me. Maybe something like this: "Consider the use of BDF as tunnel monitor." With that change: Acked-By: Kyle Mestery > - Both ovn-controller and ovn-contorller-vtep should u

Re: [ovs-dev] [PATCH] ovn: Update BFD item in the ovn TODO list.

2015-11-23 Thread Kyle Mestery
On Mon, Nov 23, 2015 at 12:52 PM, Russell Bryant wrote: > > > On Mon, Nov 23, 2015 at 1:46 PM, Justin Pettit wrote: > >> >> > On Nov 23, 2015, at 10:27 AM, Russell Bryant wrote: >> > >> > On 11/23/2015 11:36 AM, Kyle Mestery wrote: >>

[ovs-dev] [PATCH] datapath: Fix a kernel crash when adding a 2nd VXLAN port with existing UDP port

2013-01-09 Thread Kyle Mestery
When creating a second VXLAN tunnel port with the same UDP port as an existing VXLAN tunnel port, make sure to set *vxport before returning. Fixes a kernel crash. Reported-by: Todd Ruch Signed-off-by: Kyle Mestery --- datapath/vport-vxlan.c | 1 + 1 file changed, 1 insertion(+) diff --git a

[ovs-dev] [PATCH 0/2] Add support for LISP into Open vSwitch

2013-01-22 Thread Kyle Mestery
The following two patches provide support for the LISP tunneling protocol into Open vSwitch. See the latest IETF draft for LISP here: http://tools.ietf.org/html/draft-ietf-lisp-24 Kyle Mestery (1): Add support to the tunneling code for a "pre_tunnel" function. This allows the

[ovs-dev] [PATCH 1/2] datapath: Add pre_tunnel support

2013-01-22 Thread Kyle Mestery
r. Signed-off-by: Kyle Mestery --- datapath/tunnel.c | 5 + datapath/tunnel.h | 7 +++ datapath/vport-capwap.c | 1 + datapath/vport-gre.c| 2 ++ datapath/vport-vxlan.c | 1 + 5 files changed, 16 insertions(+) diff --git a/datapath/tunnel.c b/datapath/tunnel.c ind

[ovs-dev] [PATCH 2/2] datapath: Add support for LISP tunneling

2013-01-22 Thread Kyle Mestery
: Lorand Jakab Signed-off-by: Kyle Mestery --- Makefile.am | 1 + README-lisp | 68 datapath/Modules.mk | 1 + datapath/linux/.gitignore | 1 + datapath/tunnel.h | 1 + datapath/vport-lisp.c | 351

[ovs-dev] [PATCH 0/6] vxlan: Add VXLAN support to flow based tunneling

2013-02-14 Thread Kyle Mestery
With the recent flow based tunneling changes, VXLAN support was broken. These patches address this by enabling VXLAN to work as it did before flow based tunneling was pushed upstream. Kyle Mestery (6): Modify netdev_vport_get_dpif_port() to return a name for VXLAN ports which includes

[ovs-dev] [PATCH 3/6] vxlan: Add utility functions to the simap data structure.

2013-02-14 Thread Kyle Mestery
Add utility functions to the simap structure. These are used by future patches in this seris. The functions added are. Signed-off-by: Kyle Mestery Acked-by: Ethan Jackson --- lib/simap.c | 19 +++ lib/simap.h | 2 ++ 2 files changed, 21 insertions(+) diff --git a/lib/simap.c

[ovs-dev] [PATCH 4/6] vxlan: Change dpif_backer->tnl backer to a "struct simap"

2013-02-14 Thread Kyle Mestery
Move dpif_backer->tnl_backers from a "struct sset" to a "struct simap". Store odp_port in the new map. This will make it easier to access the odp_port for future patches. Signed-off-by: Kyle Mestery Acked-by: Ethan Jackson --- ofproto/ofproto-dpif.c | 19 +++-

[ovs-dev] [PATCH 1/6] vxlan: Update netdev_vport_get_dpif_port() to support VXLAN port names

2013-02-14 Thread Kyle Mestery
Modify netdev_vport_get_dpif_port() to return a name for VXLAN ports which includes the destination UDP port number as a part of the name. Signed-off-by: Kyle Mestery Acked-by: Ethan Jackson --- lib/netdev-vport.c | 36 +--- 1 file changed, 33 insertions(+), 3

[ovs-dev] [PATCH 5/6] vxlan: Update tnl_set_config() to use UDP dst_port to distinguish VXLAN ports

2013-02-14 Thread Kyle Mestery
In tnl_set_config(), when determining if a tunnel port already exists, make sure to also check the destination port. For VXLAN, this can be different and allows multiple VXLAN ports in the datapath to be created. Signed-off-by: Kyle Mestery --- datapath/tunnel.c | 18 -- 1 file

[ovs-dev] [PATCH 6/6] vxlan: Create and delete tnl_backers in type_run()

2013-02-14 Thread Kyle Mestery
Garbage collect tnl_backers during type_run(). Add new tnl_backers if a VXLAN ports UDP port changes. Signed-off-by: Kyle Mestery --- ofproto/ofproto-dpif.c | 118 + 1 file changed, 71 insertions(+), 47 deletions(-) diff --git a/ofproto/ofproto

[ovs-dev] [PATCH 2/6] Modify dpif_linux_port_add() to set the destination port for VXLAN ports.

2013-02-14 Thread Kyle Mestery
Signed-off-by: Kyle Mestery Acked-by: Ethan Jackson --- lib/dpif-linux.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c index b6eba39..34b9532 100644 --- a/lib/dpif-linux.c +++ b/lib/dpif-linux.c @@ -482,12 +482,14 @@ dpif_linux_port_add

[ovs-dev] [PATCH] vxlan: Create and delete tnl_backers in type_run()

2013-02-14 Thread Kyle Mestery
v2 fixes error handling noticed by Ben. --- Garbage collect tnl_backers during type_run(). Add new tnl_backers if a VXLAN ports UDP port changes. Signed-off-by: Kyle Mestery --- ofproto/ofproto-dpif.c | 120 ++--- 1 file changed, 73 insertions(+), 47

[ovs-dev] [vxlan] ofproto: Create and delete tnl_backers in type_run()

2013-02-15 Thread Kyle Mestery
v3 Changes to main loop from Ethan. v2 fixes error handling noticed by Ben. --- Garbage collect tnl_backers during type_run(). Add new tnl_backers if a VXLAN ports UDP port changes. Signed-off-by: Kyle Mestery --- ofproto/ofproto-dpif.c | 107 +++-- 1

[ovs-dev] ovs-dev] [vxlan] ofproto: Create and delete tnl_backers in type_run()

2013-02-15 Thread Kyle Mestery
v3 Changes to main loop from Ethan along with comments from Ben. v2 fixes error handling noticed by Ben. --- Garbage collect tnl_backers during type_run(). Add new tnl_backers if a VXLAN ports UDP port changes. Signed-off-by: Kyle Mestery --- ofproto/ofproto-dpif.c | 108

[ovs-dev] [PATCH 0/1] Unit tests for VXLAN and LISP

2013-02-27 Thread Kyle Mestery
LISP, but otherwise they are the same as the GRE tests. Feedback appreciated. Kyle Mestery (1): Add unit tests for VXLAN and LISP tunnels. tests/automake.mk | 2 + tests/testsuite.at| 2 + tests/tunnel-lisp.at | 351 ++ tests/t

[ovs-dev] [PATCH] tests: Add unit tests for VXLAN and LISP tunnels.

2013-02-27 Thread Kyle Mestery
Signed-off-by: Kyle Mestery --- tests/automake.mk | 2 + tests/testsuite.at| 2 + tests/tunnel-lisp.at | 351 ++ tests/tunnel-vxlan.at | 351 ++ 4 files changed, 706 insertions(+) create

[ovs-dev] [PATCH] documentation: Add instructions on how to run the unit test infrastructure.

2013-02-27 Thread Kyle Mestery
Signed-off-by: Kyle Mestery --- INSTALL | 27 +++ 1 file changed, 27 insertions(+) diff --git a/INSTALL b/INSTALL index 275e86e..d0f85e8 100644 --- a/INSTALL +++ b/INSTALL @@ -341,6 +341,33 @@ also upgrade the database schema: 4. Start the Open vSwitch daemons as

[ovs-dev] [PATCH] tests: Add VXLAN and LISP tunnel tests to the unit test infrastructure.

2013-02-27 Thread Kyle Mestery
Signed-off-by: Kyle Mestery --- tests/tunnel.at | 69 + 1 file changed, 69 insertions(+) diff --git a/tests/tunnel.at b/tests/tunnel.at index 55fd5b3..4486ecc 100644 --- a/tests/tunnel.at +++ b/tests/tunnel.at @@ -310,3 +310,72 @@ AT_CHECK

[ovs-dev] [PATCH] tunnel: Only print non-default UDP dst_port for LISP/VXLAN tunnels

2013-02-28 Thread Kyle Mestery
In get_tunnel_config(), distinguish between VXLAN and LISP when deciding whether or not to print UDP destination port. Only add the UDP destination port for either protocol if it is not the default UDP port. Update the LISP unit test to match the new behavior as well. Signed-off-by: Kyle Mestery

[ovs-dev] [PATCH] Update default VXLAN UDP port to official IANA port

2013-04-26 Thread Kyle Mestery
VXLAN was recently assigned UDP port 4789 by IANA. This updates the OVS VXLAN implementation to reflect the new UDP port number. It also updates the unit test for VXLAN to pass with the change in UDP port number. Cc: Kenneth Duda Signed-off-by: Kyle Mestery --- lib/netdev-vport.c | 2 +- tests

[ovs-dev] [PATCH 1/2] Update the default VXLAN destination UDP port to the IANA assigned port

2013-04-26 Thread Kyle Mestery
VXLAN was recently assigned UDP port 4789 by IANA. This comit updates the OVS VXLAN implementation to reflect the new UDP port number. Cc: Kenneth Duda Signed-off-by: Kyle Mestery --- lib/netdev-vport.c | 2 +- tests/tunnel.at | 2 +- vswitchd/vswitch.xml | 2 +- 3 files changed, 3

[ovs-dev] [PATCH 2/2] Add FAQ entries around the VXLAN support in Open vSwitch.

2013-04-26 Thread Kyle Mestery
Add a section to the FAQ explaining VXLAN with a pointer to the IETF draft. Add sections detailing how much of the VXLAN protocol is currently supported in OVS, along with a section explaining the default UDP port and how to change this when creating VXLAN ports. Signed-off-by: Kyle Mestery

[ovs-dev] [PATCH 1/2] Update the default VXLAN destination UDP port to the IANA assigned port

2013-04-26 Thread Kyle Mestery
VXLAN was recently assigned UDP port 4789 by IANA. This comit updates the OVS VXLAN implementation to reflect the new UDP port number. Cc: Kenneth Duda Signed-off-by: Kyle Mestery --- v2: Add a NEWS entry for the VXLAN destination UDP port change. --- NEWS | 2 ++ lib/netdev

[ovs-dev] [PATCH 2/2] Add FAQ entries around the VXLAN support in Open vSwitch.

2013-04-26 Thread Kyle Mestery
Add a section to the FAQ explaining VXLAN with a pointer to the IETF draft. Add sections detailing how much of the VXLAN protocol is currently supported in OVS, along with a section explaining the default UDP port and how to change this when creating VXLAN ports. Signed-off-by: Kyle Mestery

[ovs-dev] [PATCH 1/2] Update the default VXLAN destination UDP port to the IANA assigned port

2013-04-26 Thread Kyle Mestery
VXLAN was recently assigned UDP port 4789 by IANA. This comit updates the OVS VXLAN implementation to reflect the new UDP port number. Cc: Kenneth Duda Signed-off-by: Kyle Mestery --- v3: Update vswitch XML per comment from Jesse. v2: Add a NEWS entry for the VXLAN destination UDP port change

[ovs-dev] [PATCH 2/2] Add FAQ entries around the VXLAN support in Open vSwitch.

2013-04-26 Thread Kyle Mestery
Add a section to the FAQ explaining VXLAN with a pointer to the IETF draft. Add sections detailing how much of the VXLAN protocol is currently supported in OVS, along with a section explaining the default UDP port and how to change this when creating VXLAN ports. Signed-off-by: Kyle Mestery

[ovs-dev] [PATCH] Allow master to build on Fedora with the recent threading changes

2013-05-06 Thread Kyle Mestery
Signed-off-by: Kyle Mestery --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index bbb6dea..fe3f9c7 100644 --- a/configure.ac +++ b/configure.ac @@ -44,6 +44,7 @@ AC_SYS_LARGEFILE AC_SEARCH_LIBS([pow], [m]) AC_SEARCH_LIBS([clock_gettime], [rt])

[ovs-dev] [PATCH] datapath: Conditionally define skb_unclone in datapath compat code

2013-07-22 Thread Kyle Mestery
Recent versions of Fedora have skb_unclone included in their kernels. This patch adds a conditional check into the compat directory so as not to error out by defining it twice. This allows the latest OVS kernel module to build on Fedora 19. Signed-off-by: Kyle Mestery --- acinclude.m4

[ovs-dev] [PATCH] datapath: Support for Linux kernel 3.9.

2013-07-26 Thread Kyle Mestery
Add support for Linux kernel 3.9. Signed-off-by: Kyle Mestery CC: Pravin B Shelar --- datapath/datapath.c | 4 ++-- datapath/vport-netdev.c | 7 +++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index 4330ce3..e5e0616 100644

[ovs-dev] [PATCH] datapath: Support for Linux kernel 3.9.

2013-07-30 Thread Kyle Mestery
Ensure that in tunnel.c:handle_offloads() we save off skb->cb before calling __skb_gso_segment() and restore it after the return. Signed-off-by: Pravin B Shelar Signed-off-by: Kyle Mestery --- Changes in v2: * No longer save skb->sb in vport_netdev.c:netdev_send(). --- datapath/datapath

[ovs-dev] [PATCH v3] datapath: Support for Linux kernel 3.9.

2013-07-31 Thread Kyle Mestery
In certain cases we need to ensure we save off skb->cb before calling __skb_gso_segment() since in kernels >= 3.9 skb->cb is used by this routine. Signed-off-by: Pravin B Shelar Signed-off-by: Kyle Mestery --- Changes in v3: * Save skb->cb in gso.c:tnl_skb_gso_segment(). * Add

[ovs-dev] [PATCH] package: Make Fedora RPMs build after vtep changes

2013-10-24 Thread Kyle Mestery
Add the appropriate vtep files into the Fedora RPM build to make this work on master again. Signed-off-by: Kyle Mestery --- rhel/openvswitch-fedora.spec.in | 7 +++ 1 file changed, 7 insertions(+) diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in index 27a3b03

[ovs-dev] [PATCH] fedora-build: Remove %{build_number} from the configure line

2013-12-13 Thread Kyle Mestery
Fixes the OVS builds on Fedora, which are currently broken upstream. Signed-off-by: Kyle Mestery --- rhel/openvswitch-fedora.spec.in | 2 +- rhel/openvswitch-kmod-fedora.spec.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/rhel/openvswitch-fedora.spec.in b/rhel

[ovs-dev] [PATCH] Bump up the supported kernel versions to include 3.5.x.

2012-08-07 Thread Kyle Mestery
Signed-off-by: Kyle Mestery --- datapath/datapath.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index 7a7dc4c..e98c84b 100644 --- a/datapath/datapath.c +++ b/datapath/datapath.c @@ -61,8 +61,8 @@ #include "

[ovs-dev] [PATCH 0/1] Start of support for flow-based tunneling

2012-08-13 Thread Kyle Mestery
This patch builds on the first two patches which Simon Horman sent out in May to move Open vSwitch towards flow-based tunneling. This patch simply adds a tun_key, deprecating the tun_id member of the ovs_skb_cb struct. This patch retains compatibilty with existing tunneling, but once the userspace

[ovs-dev] [PATCH 1/1] Add support for tun_key to OVS datapath

2012-08-13 Thread Kyle Mestery
mit the scope and size of this patch. This patch allows all existing tun_id behaviour to still work. However, when the userspace code is updated to make use of the new tun_key, the old behaviour will be deprecated and removed. Signed-off-by: Kyle Mestery Cc: Simon Horman --- datapath/action

[ovs-dev] [PATCH 0/1] Start of support for flow-based tunneling

2012-08-29 Thread Kyle Mestery
This patch builds on the first two patches which Simon Horman sent out in May to move Open vSwitch towards flow-based tunneling. This patch simply adds a tun_key, deprecating the tun_id member of the ovs_skb_cb struct. This patch retains compatibilty with existing tunneling, but once the userspace

[ovs-dev] [PATCH 1/1] Add support for tun_key to OVS datapath

2012-08-29 Thread Kyle Mestery
mit the scope and size of this patch. This patch allows all existing tun_id behaviour to still work. However, when the userspace code is updated to make use of the new tun_key, the old behaviour will be deprecated and removed. Signed-off-by: Kyle Mestery Cc: Simon Horman --- V2: - Fix blank l

[ovs-dev] [PATCH 1/1 V3] Add support for tun_key to OVS datapath

2012-09-04 Thread Kyle Mestery
TUD needs to be disabled for tunneling to work. Signed-off-by: Kyle Mestery Cc: Simon Horman Cc: Jesse Gross --- V3: - Fix issues found during review by Jesse. - Add a NEWS entry around tunnel code no longer assuming symmetric input and output tunnel keys. V2: - Fix blank line addition/removal fo

[ovs-dev] [PATCH 1/1 V4] Add support for tun_key to OVS datapath

2012-09-05 Thread Kyle Mestery
TUD needs to be disabled for tunneling to work. Signed-off-by: Kyle Mestery Cc: Simon Horman Cc: Jesse Gross --- V4: - Address 2 comments from Jesse: - When processing actions, if OVS_CB(skb)->tun_key is NULL, point it at one on the stack temporarily. This goes away when we remove the abil

[ovs-dev] [PATCH 0/2] Add flow-based tunneling support

2012-09-28 Thread Kyle Mestery
userspace code is submitted, this will be deprecated. The second patch makes an attempt at adding the new tun_key structure into the flow matching logic in the kernel. Kyle Mestery (2): This is a first pass at providing a tun_key which can be used as the basis for flow-based tunnelling. The

[ovs-dev] [PATCH 1/2] Add support for tun_key to OVS datapath

2012-09-28 Thread Kyle Mestery
TUD needs to be disabled for tunneling to work. Signed-off-by: Kyle Mestery Cc: Simon Horman Cc: Jesse Gross --- V6: - Address latest round of comments from Jesse. V5: - Address another round of comments from Jesse. V4: - Address 2 comments from Jesse: - When processing actions, if OVS_CB(

[ovs-dev] [PATCH 2/2] Add flow matching for tunnel keys

2012-09-28 Thread Kyle Mestery
w of the method used for adding the matching logic here. The method I've chosen here adds one additional check during flow lookup to see if a tunnel key is set, and if so will add one comparison before matching a flow. If this is deemed suboptimal, I'm open to suggestions around optimiz

[ovs-dev] [PATCH 0/2] Add flow-based tunneling support

2012-10-01 Thread Kyle Mestery
userspace code is submitted, this will be deprecated. The second patch makes an attempt at adding the new tun_key structure into the flow matching logic in the kernel. Kyle Mestery (2): This is a first pass at providing a tun_key which can be used as the basis for flow-based tunnelling. The

[ovs-dev] [PATCH 2/2] Add flow matching for tunnel keys

2012-10-01 Thread Kyle Mestery
ges in favor of using the version from Jesse's changeset. Signed-off-by: Kyle Mestery --- datapath/actions.c | 1 + datapath/datapath.c | 29 ++-- datapath/datapath.h | 1 + datapath/flow.c | 65 + data

[ovs-dev] [PATCH 1/2] Add support for tun_key to OVS datapath

2012-10-01 Thread Kyle Mestery
TUD needs to be disabled for tunneling to work. Signed-off-by: Kyle Mestery Cc: Simon Horman Cc: Jesse Gross --- V5: - Address another round of comments from Jesse. V4: - Address 2 comments from Jesse: - When processing actions, if OVS_CB(skb)->tun_key is NULL, point it at one on the

[ovs-dev] [PATCH] build: Add support for building RPMs for Fedora Linux

2012-10-01 Thread Kyle Mestery
Add RPM specfiles for building OVS for Fedora Linux. This allows users of the upstream project the ability to generate RPMs for their Open vSwitch needs. Signed-off-by: Kyle Mestery --- INSTALL.Fedora | 53 + rhel/.gitignore | 2 + rhel

[ovs-dev] [PATCH] build: Add support for building RPMs for Fedora Linux

2012-10-02 Thread Kyle Mestery
Add RPM specfiles for building OVS for Fedora Linux. This allows users of the upstream project the ability to generate RPMs for their Open vSwitch needs. Signed-off-by: Kyle Mestery V2: - Addressed Ben's comments. - Moved from init.d to systemd, per the official Fedora RPMs. - Some

[ovs-dev] [PATCH 0/2] datapath: Add flow-based tunneling support

2012-10-09 Thread Kyle Mestery
destination IP addresses. I'm sending what I have out now to get some feedback, per discussions on the dev list. Kyle Mestery (2): This is a first pass at providing a tun_key which can be used as the basis for flow-based tunnelling. The tun_key includes and replaces the tun_id in

[ovs-dev] [PATCH 1/2] datapath: Add support for tun_key to Open vSwitch datapath

2012-10-09 Thread Kyle Mestery
TUD needs to be disabled for tunneling to work. Signed-off-by: Kyle Mestery Cc: Simon Horman Cc: Jesse Gross --- V6: - Fix more comments addressed from Jesse. V5: - Address another round of comments from Jesse. V4: - Address 2 comments from Jesse: - When processing actions, if OVS_CB(skb)->tun_

[ovs-dev] [PATCH 2/2] datapath: Add flow matching for tunnel keys

2012-10-09 Thread Kyle Mestery
Move struct ovs_key_ipv4_tunnel to the top of sw_flow_key. Add a new struct ovs_flow_hash, which contains both the key_len and the offset to use when hashing. This allows the outer tunnel to be hashed and used when looking up flows. Signed-off-by: Kyle Mestery --- datapath/actions.c | 1

[ovs-dev] [PATCH] Update INSTALL.Fedora to mention Fedora 17 instead of Fedora 15

2012-10-22 Thread Kyle Mestery
Reflect the fact Fedora RPM support was recently implemented on Fedora 17 instead of Fedora 15. Signed-off-by: Kyle Mestery --- INSTALL.Fedora | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/INSTALL.Fedora b/INSTALL.Fedora index d023127..708cae6 100644 --- a

[ovs-dev] [PATCH] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-13 Thread Kyle Mestery
th multiple VXLAN tunnels between hosts using different UDP port numbers. See the following IETF draft for additional information about VXLAN: http://tools.ietf.org/html/draft-mahalingam-dutt-dcops-vxlan-02 Signed-off-by: Kyle Mestery --- NEWS | 3 + README

[ovs-dev] [PATCH v2] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-16 Thread Kyle Mestery
ingam-dutt-dcops-vxlan-02 Signed-off-by: Kyle Mestery --- NEWS | 3 + README | 2 +- datapath/Modules.mk | 3 +- datapath/linux/.gitignore| 2 + datapath/tunnel.c| 7 + datapath/tunnel.h

[ovs-dev] [PATCH v3] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-19 Thread Kyle Mestery
mation about VXLAN: http://tools.ietf.org/html/draft-mahalingam-dutt-dcops-vxlan-02 Signed-off-by: Kyle Mestery --- NEWS | 3 + README | 2 +- datapath/Modules.mk | 3 +- datapath/linux/.gitignore| 2 + datapath/tunne

[ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-27 Thread Kyle Mestery
ion about VXLAN: http://tools.ietf.org/html/draft-mahalingam-dutt-dcops-vxlan-02 Signed-off-by: Kyle Mestery --- NEWS | 2 + README| 2 +- datapath/Modules.mk | 3 +- datapath/linux/.gitignore | 2 + datapath/tunnel.c

[ovs-dev] [PATCH v5] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-28 Thread Kyle Mestery
ble GRE tunnels. See the following IETF draft for additional information about VXLAN: http://tools.ietf.org/html/draft-mahalingam-dutt-dcops-vxlan-02 Signed-off-by: Kyle Mestery --- NEWS | 3 +- README| 2 +- datapath/Modules.mk | 3 +-

[ovs-dev] [PATCH v6] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-29 Thread Kyle Mestery
IETF draft for additional information about VXLAN: http://tools.ietf.org/html/draft-mahalingam-dutt-dcops-vxlan-02 Signed-off-by: Kyle Mestery --- NEWS | 3 + README| 2 +- datapath/Modules.mk | 3 +- datapath/linux/.gitignore |

[ovs-dev] [PATCH v7] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-12-03 Thread Kyle Mestery
an comparable GRE tunnels. See the following IETF draft for additional information about VXLAN: http://tools.ietf.org/html/draft-mahalingam-dutt-dcops-vxlan-02 Signed-off-by: Kyle Mestery --- NEWS | 3 + README| 2 +- datapath/Modules.mk

[ovs-dev] [PATCH v7] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-12-05 Thread Kyle Mestery
h with multiple VXLAN tunnels between hosts using different UDP port numbers. Performance is on par (though slightly faster) than comparable GRE tunnels. See the following IETF draft for additional information about VXLAN: http://tools.ietf.org/html/draft-mahalingam-dutt-dcops-vxlan-02 Signed-off-b

[ovs-dev] [PATCH v8] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-12-05 Thread Kyle Mestery
h with multiple VXLAN tunnels between hosts using different UDP port numbers. Performance is on par (though slightly faster) than comparable GRE tunnels. See the following IETF draft for additional information about VXLAN: http://tools.ietf.org/html/draft-mahalingam-dutt-dcops-vxlan-02 Signed-off-b

[ovs-dev] [PATCH 1/1] datapath: Add pre_tunnel option to tunneling code

2012-12-07 Thread Kyle Mestery
r. Signed-off-by: Kyle Mestery --- datapath/tunnel.c | 5 + datapath/tunnel.h | 7 +++ datapath/vport-capwap.c | 1 + datapath/vport-gre.c| 2 ++ datapath/vport-vxlan.c | 1 + 5 files changed, 16 insertions(+) diff --git a/datapath/tunnel.c b/datapath/tunnel.c ind

[ovs-dev] [PATCH 0/1] RFC: Add support for pre-tunnel to the datapath

2012-12-07 Thread Kyle Mestery
a.org/wiki/Locator/Identifier_Separation_Protocol Kyle Mestery (1): Add support to the tunneling code for a "pre_tunnel" function. This allows the tunneling code to perform operations on the packet before the outer IP header is added. datapath/tunnel.c | 5

Re: [ovs-dev] VXLAN Patches

2012-02-02 Thread Kyle Mestery
On Feb 2, 2012, at 8:47 PM, Jesse Gross wrote: > On Tue, Jan 31, 2012 at 10:34 AM, kmestery wrote: >> I'm curious what the current state of the VXLAN patches for Open vSwitch is. >> I saw an email from Justin on 1-24-2012 indicating the patches are being >> reworked at this time. I've gone ahead

Re: [ovs-dev] VXLAN Patches

2012-02-04 Thread Kyle Mestery
ee the github reference below). At this point, I was waiting for Jesse to send out his initial thoughts on the initial design before getting started. Will be happy to work with you on this Joseph, lets wait and see Jesse's thoughts before diving in deeper. Thanks, Kyle > On 3 February 2

Re: [ovs-dev] VXLAN Patches

2012-02-06 Thread Kyle Mestery
On Feb 6, 2012, at 3:19 PM, Jesse Gross wrote: > On Sat, Feb 4, 2012 at 6:52 PM, Kyle Mestery wrote: >> On Feb 4, 2012, at 1:14 PM, Joseph Glanville wrote: >>> Hi >>> >>> I ported the aforementioned patches to 1.4 but haven't gotten much >>>

Re: [ovs-dev] VXLAN Patches

2012-02-06 Thread Kyle Mestery
On Feb 6, 2012, at 5:55 PM, Jesse Gross wrote: > On Mon, Feb 6, 2012 at 2:55 PM, Kyle Mestery wrote: >> On Feb 6, 2012, at 3:19 PM, Jesse Gross wrote: >>> When we first implemented tunneling support, all configuration went on >>> the tunnel port itself including IP ad

Re: [ovs-dev] [PATCH] FAQ: Update question about OpenFlow version support.

2013-01-10 Thread Kyle Mestery (kmestery)
m later versions of OpenFlow into Open vSwitch." Otherwise, looks good and should save time in directing folks to an answer for a question popping up recently. Acked-by: Kyle Mestery > - http://openvswitch.org/development/openflow-1-x-plan/ > + Open vSwitch versions 1.10 and late

Re: [ovs-dev] [PATCH] FAQ: Update question about OpenFlow version support.

2013-01-10 Thread Kyle Mestery (kmestery)
On Jan 10, 2013, at 12:46 PM, Ben Pfaff wrote: > On Thu, Jan 10, 2013 at 06:14:34PM +0000, Kyle Mestery (kmestery) wrote: >> That last sentence didn't read right to me. How about something like this? >> >> "Version 1.9 of Open vSwitch includes a number of exten

Re: [ovs-dev] [bug14616 4/5] socket-util: Use CONST_CAST in send_iovec_and_fs().

2013-01-11 Thread Kyle Mestery (kmestery)
On Jan 10, 2013, at 7:23 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff Acked-by: Kyle Mestery ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [bug14616 5/5] worker: Remove unreachable statement.

2013-01-11 Thread Kyle Mestery (kmestery)
On Jan 10, 2013, at 7:23 PM, Ben Pfaff wrote: > Nothing ever breaks out of the loop, so this statement couldn't be reached. > > Signed-off-by: Ben Pfaff Acked-by: Kyle Mestery ___ dev mailing list dev@openvswitch.org http://openvswit

Re: [ovs-dev] [bug14616 3/5] worker: Make worker_request_iovec() verify that it is not being reentered.

2013-01-11 Thread Kyle Mestery (kmestery)
On Jan 10, 2013, at 7:23 PM, Ben Pfaff wrote: > This function cannot easily be reentrant because the inner call would > interrupt and corrupt the data being sent by the outer call. > > Signed-off-by: Ben Pfaff Acked-by: Kyle Mestery ___

Re: [ovs-dev] [PATCH 0/2] Add support for LISP into Open vSwitch

2013-01-24 Thread Kyle Mestery (kmestery)
On Jan 23, 2013, at 12:02 PM, Jesse Gross wrote: > On Tue, Jan 22, 2013 at 10:36 AM, Kyle Mestery wrote: >> The following two patches provide support for the LISP tunneling protocol >> into >> Open vSwitch. See the latest IETF draft for LISP here: >> >> http

Re: [ovs-dev] [PATCH 0/2] Add support for LISP into Open vSwitch

2013-01-25 Thread Kyle Mestery (kmestery)
On Jan 23, 2013, at 12:02 PM, Jesse Gross wrote: > On Tue, Jan 22, 2013 at 10:36 AM, Kyle Mestery wrote: >> The following two patches provide support for the LISP tunneling protocol >> into >> Open vSwitch. See the latest IETF draft for LISP here: >> >> http

Re: [ovs-dev] [PATCH 1/6] datapath: Remove support for Don't Fragment inheritance.

2013-01-27 Thread Kyle Mestery (kmestery)
Looks good to me. Acked-by: Kyle Mestery ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 5/6] datapath: Remove compatibility GRE identifier.

2013-01-27 Thread Kyle Mestery (kmestery)
On Jan 25, 2013, at 5:54 PM, Jesse Gross wrote: > We want to move the GRE vport ID into the upstream range but in > order to ease the transition kept the old ID around for one release. > This removes the old value. > > Signed-off-by: Jesse Gross Looks good. Acked-b

Re: [ovs-dev] [PATCH 3/6] datapath: Remove vport MAC address configuration.

2013-01-27 Thread Kyle Mestery (kmestery)
e purpose of generating path MTU discovery > packets, which has now been removed. Current userspace code already > reflects these changes, so this drops the functionality from the > kernel. > > Signed-off-by: Jesse Gross Looks good. Acked-by: Kyle Mestery

Re: [ovs-dev] [PATCH 2/6] datapath: Remove tunnel path MTU discovery support.

2013-01-27 Thread Kyle Mestery (kmestery)
rnel support to simplify the > code. > > Signed-off-by: Jesse Gross Nice cleanup. Acked-by: Kyle Mestery ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 4/6] datapath: Remove tunnel configuration sequence number.

2013-01-27 Thread Kyle Mestery (kmestery)
removed the sequence number is no > longer necessary. > > Signed-off-by: Jesse Gross Looks good. Acked-by: Kyle Mestery ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 6/6] datapath: Remove kernel patch ports.

2013-01-27 Thread Kyle Mestery (kmestery)
On Jan 25, 2013, at 5:54 PM, Jesse Gross wrote: > Now that userspace implements patch ports completely internally, > it's possible to remove the kernel implementation of them. > > Signed-off-by: Jesse Gross Looks good. Acked

Re: [ovs-dev] [PATCH] ovs-ctl: Update comment.

2013-01-28 Thread Kyle Mestery (kmestery)
On Jan 28, 2013, at 1:00 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff Acked-by: Kyle Mestery ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 0/2] Add support for LISP into Open vSwitch

2013-01-29 Thread Kyle Mestery (kmestery)
On Jan 29, 2013, at 5:19 PM, Jesse Gross wrote: > On Fri, Jan 25, 2013 at 2:13 PM, Kyle Mestery (kmestery) > wrote: >> On Jan 23, 2013, at 12:02 PM, Jesse Gross wrote: >>> On Tue, Jan 22, 2013 at 10:36 AM, Kyle Mestery wrote: >>>> The following two pat

Re: [ovs-dev] [PATCH 0/2] Add support for LISP into Open vSwitch

2013-01-29 Thread Kyle Mestery (kmestery)
On Jan 29, 2013, at 6:47 PM, Jesse Gross wrote: > On Tue, Jan 29, 2013 at 3:27 PM, Kyle Mestery (kmestery) > wrote: >> On Jan 29, 2013, at 5:19 PM, Jesse Gross wrote: >>> The other area that I'm somewhat concerned about is with upstreaming. >>> Once we get OV

Re: [ovs-dev] [PATCH 0/2] Add support for LISP into Open vSwitch

2013-02-01 Thread Kyle Mestery (kmestery)
On Jan 29, 2013, at 9:13 PM, Kyle Mestery (kmestery) wrote: > On Jan 29, 2013, at 6:47 PM, Jesse Gross wrote: >> On Tue, Jan 29, 2013 at 3:27 PM, Kyle Mestery (kmestery) >> wrote: >>> On Jan 29, 2013, at 5:19 PM, Jesse Gross wrote: >>>> The other area that

Re: [ovs-dev] [PATCH 0/2] Add support for LISP into Open vSwitch

2013-02-01 Thread Kyle Mestery (kmestery)
On Feb 1, 2013, at 12:03 PM, Jesse Gross wrote: > On Fri, Feb 1, 2013 at 6:30 AM, Kyle Mestery (kmestery) > wrote: >> On Jan 29, 2013, at 9:13 PM, Kyle Mestery (kmestery) >> wrote: >>> On Jan 29, 2013, at 6:47 PM, Jesse Gross wrote: >>>> On Tue, Jan 29,

Re: [ovs-dev] [PATCH] tunneling: Don't send ICMP messages if no tunnel port is found.

2013-02-01 Thread Kyle Mestery (kmestery)
ovindan > Signed-off-by: Jesse Gross Looks straightforward enough to me, thanks for the nice explanation Jesse. Acked-by: Kyle Mestery ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] FAQ: Add question and answer about PPP.

2013-02-02 Thread Kyle Mestery (kmestery)
On Feb 2, 2013, at 10:53 AM, Ben Pfaff wrote: > We've had this question a few times lately. > > Signed-off-by: Ben Pfaff Looks good to me Ben. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] VXLAN ports not working with latest master

2013-02-03 Thread Kyle Mestery (kmestery)
I'm running with the latest master, and I noticed I can no longer configure VXLAN ports. I'm tracking this down, but wanted to let folks on the list know as well. I am configure my VXLAN port like this: ovs-vsctl add-port br2 vxlan1 -- set interface vxlan1 \ type=vxlan o

Re: [ovs-dev] VXLAN ports not working with latest master

2013-02-03 Thread Kyle Mestery (kmestery)
On Feb 3, 2013, at 8:56 PM, Kyle Mestery (kmestery) wrote: > I'm running with the latest master, and I noticed I can no longer configure > VXLAN ports. I'm tracking this down, but wanted to let folks on the list know > as well. > > I am configure my VXLAN port like th

Re: [ovs-dev] VXLAN ports not working with latest master

2013-02-04 Thread Kyle Mestery (kmestery)
On Feb 4, 2013, at 2:59 PM, Ethan Jackson wrote: >> I figured this out. It looks like the flow based tunneling changes no longer >> propagate the destination UDP port down to VXLAN, which requires it. Because >> of this, the VXLAN vport code in the kernel is returning an error. I'll go >> ahead

Re: [ovs-dev] VXLAN ports not working with latest master

2013-02-06 Thread Kyle Mestery (kmestery)
On Feb 4, 2013, at 3:50 PM, Ethan Jackson wrote: >> Yes, I'd like to help here. Can you shoot me any ideas you may have? >> I've been looking at this in my free time today. Tomorrow I should be >> able to dedicate most of the day to it. > > Ok sounds good. Thanks for taking this on. > Just ge

Re: [ovs-dev] [PATCH] FAQ: Fix typo (doubled "later").

2013-02-06 Thread Kyle Mestery (kmestery)
On Feb 6, 2013, at 11:16 AM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff Looks good Ben. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] VXLAN ports not working with latest master

2013-02-06 Thread Kyle Mestery (kmestery)
On Feb 6, 2013, at 12:57 PM, Ethan Jackson wrote: >> I see an issue right now. It looks like netdev_vport_get_dpif_port() >> currently just returns a const char * by returning a pointer to the dpif_port >> pointer on vport_class. Modifying this behavior to return a dynamic >> name here means we n

Re: [ovs-dev] [PATCH 0/6] vxlan: Add VXLAN support to flow based tunneling

2013-02-14 Thread Kyle Mestery (kmestery)
On Feb 14, 2013, at 8:37 AM, Kyle Mestery wrote: > With the recent flow based tunneling changes, VXLAN support was broken. These > patches address this by enabling VXLAN to work as it did before flow based > tunneling was pushed upstream. > > Kyle Mestery

Re: [ovs-dev] [PATCH 3/6] vxlan: Add utility functions to the simap data structure.

2013-02-14 Thread Kyle Mestery (kmestery)
On Feb 14, 2013, at 11:37 AM, Ben Pfaff wrote: > On Thu, Feb 14, 2013 at 09:37:27AM -0500, Kyle Mestery wrote: >> Add utility functions to the simap structure. These are >> used by future patches in this seris. The functions added are. >> >> Signed-off-by: Kyle

Re: [ovs-dev] [PATCH 1/6] vxlan: Update netdev_vport_get_dpif_port() to support VXLAN port names

2013-02-14 Thread Kyle Mestery (kmestery)
On Feb 14, 2013, at 11:55 AM, Ben Pfaff wrote: > On Thu, Feb 14, 2013 at 09:37:25AM -0500, Kyle Mestery wrote: >> Modify netdev_vport_get_dpif_port() to return a name for >> VXLAN ports which includes the destination UDP port number as a part of the >> name. >> >

Re: [ovs-dev] [PATCH 2/6] Modify dpif_linux_port_add() to set the destination port for VXLAN ports.

2013-02-14 Thread Kyle Mestery (kmestery)
On Feb 14, 2013, at 12:00 PM, Ben Pfaff wrote: > On Thu, Feb 14, 2013 at 09:37:26AM -0500, Kyle Mestery wrote: >> Signed-off-by: Kyle Mestery >> Acked-by: Ethan Jackson > > I'm pretty sure this introduces a memory leak because ofpbuf_init() > allocates data and

Re: [ovs-dev] [PATCH 4/6] vxlan: Change dpif_backer->tnl backer to a "struct simap"

2013-02-14 Thread Kyle Mestery (kmestery)
On Feb 14, 2013, at 12:07 PM, Ben Pfaff wrote: > On Thu, Feb 14, 2013 at 09:37:28AM -0500, Kyle Mestery wrote: >> Move dpif_backer->tnl_backers from a "struct sset" to a >> "struct simap". Store odp_port in the new map. This will make it easier to >

<    1   2   3   4   5   >