Thanks, I applied this to master.
On 23 May 2014 17:01, Alex Wang wrote:
> Acked-by: Alex Wang
>
>
> On Thu, May 22, 2014 at 9:35 PM, Joe Stringer wrote:
>
>> Signed-off-by: Joe Stringer
>> ---
>> ofproto/ofproto-dpif-xlate.c |2 --
>> 1 file cha
This was causing failures in 'make distcleancheck'.
Signed-off-by: Joe Stringer
---
tests/automake.mk |1 +
1 file changed, 1 insertion(+)
diff --git a/tests/automake.mk b/tests/automake.mk
index 9354fad..bf943ce 100644
--- a/tests/automake.mk
+++ b/tests/automake.mk
@@ -19
This was causing failures in 'make distcleancheck'.
Signed-off-by: Joe Stringer
---
datapath/linux/Makefile.main.in |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/datapath/linux/Makefile.main.in b/datapath/linux/Makefile.main.in
index 88f144c..7d18253 10
s create a ukey, allowing the ukey's
mutex to be used as the basis for preventing a flow from being handled
twice. This is expected to cause some minor performance regression for
cases like TCP_CRR, in favour of correctness and readability.
Bug #1252997.
Signed-off-by: Joe Stringer
---
ofprot
Due to the differences between master and branch-2.3 and pressure to get
this out, I've targetted this first at branch-2.3. I intend to prepare an
equivalent patch for master, separately.
On 28 May 2014 13:19, Joe Stringer wrote:
> A series of bugs have been identified recently that ar
Alex Wang wrote:
> Acked-by: Alex Wang
>
>
> For master, I'm about to refactor the datapath so that we never dump
> duplicated flows. So, I think we should consider refactoring master after
> that.
>
>
> Thanks,
> Alex Wang,
>
>
> On Tue, May 27, 2014
ewhere, but perhaps they aren't.
>
> Ethan
>
> On Tue, May 27, 2014 at 7:13 PM, Joe Stringer
> wrote:
> > Thanks for the Ack, I pushed this to branch-2.3.
> >
> > I'd like to send a patch for master anyway, in part so that we ensure to
> > address this (
03:11, Ben Pfaff wrote:
> On Tue, May 27, 2014 at 01:46:59PM +1200, Joe Stringer wrote:
> > This was causing failures in 'make distcleancheck'.
> >
> > Signed-off-by: Joe Stringer
>
> OVSIDL_BUILT is already in EXTRA_DIST. It doesn't make sense
. I sent out a patch:
> http://openvswitch.org/pipermail/dev/2014-May/040737.html
>
> I don't know why you would get different results. Are you running
> distcleancheck separately from distcheck? I've never tried that.
>
> On Wed, May 28, 2014 at 05:34:28PM +1200, Joe St
Looks good to me.
Acked-by: Joe Stringer
On 29 May 2014 05:36, Ben Pfaff wrote:
> Since the initial checkin of the vtep code, the manpage has been both
> distributed and distcleaned. That's contradictory. This commit fixes it.
>
> This commit also moves the vtep manpag
10:13 AM, Ben Pfaff wrote:
> > Ethan, I think you should review this.
> >
> > On Sun, May 18, 2014 at 9:11 PM, Joe Stringer
> wrote:
> >> Signed-off-by: Joe Stringer
> >> ---
> >> utilities/ovs-dev.py | 10 ++
> >> 1 file changed, 10
; >> On my system at leas,t the fact that we pass "-j 8" to make,
> >> automagically causes the tests to run in parallel already. Does that
> >> not work for you?
> >>
> >> Ethan
> >>
> >> On Thu, May 29, 2014 at 10:12 AM, Be
concurrently, which means the flow does not need
to be handled anyway.
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c | 86 ++---
1 file changed, 37 insertions(+), 49 deletions(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto
s create a ukey, allowing the ukey's
mutex to be used as the basis for preventing a flow from being handled
twice. This improves code correctness and readability.
Bug #1252997.
Signed-off-by: Joe Stringer
---
The original version of this patch has been merged to branch-2.3, and
noted a pot
I couldn't measure a difference in TCP_CRR. I dropped that part of the
message from the patch that I sent for master:
http://openvswitch.org/pipermail/dev/2014-May/040863.html
On 28 May 2014 14:33, Joe Stringer wrote:
> Yeah, I'd like to get a gauge of this as well. I'll
s and it's in the datapath
> directory so I'll leave it to Pravin and Jesse.
>
> On Tue, May 27, 2014 at 01:47:00PM +1200, Joe Stringer wrote:
> > This was causing failures in 'make distcleancheck'.
> >
> > Signed-off-by: Joe Stringer
> > ---
&
On 31 May 2014 13:27, Ethan Jackson wrote:
> > I agree with the sentiment that it shouldn't be optional; that was my
> first
> > thought. Although, feedback from V1 was concerned about additional system
> > resources required to run it like that.
> >
> > Perhaps a compromise is to have it configu
On 3 June 2014 08:41, Ethan Jackson wrote:
> The comment over the trylock exceeds the line limit.
>
I'll fix that up.
> I'm not sure if this is the right patch to fix it or not, but I don't
> like how we're overloading the meaning of the 'mark'. I think the
> code would be a lot clearer if we
Sorry, I must have pushed the wrong version. I'll send a patch.
On 3 June 2014 12:19, Jarno Rajahalme wrote:
>
> On Jun 2, 2014, at 4:55 PM, Joe Stringer wrote:
>
> On 3 June 2014 08:41, Ethan Jackson wrote:
>
>> The comment over the trylock exceeds the line limi
Commit acaa8dac490cc6c36026d45f3010ec75f38ee142 (revalidator: Eliminate
duplicate flow handling.) introduced a build error. This fixes the bug.
Reported-by: Jarno Rajahalme
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c |2 +-
1 file changed, 1 insertion(+), 1 deletion
Thanks, applied.
I'll change the way I push to prevent this in future.
On 3 June 2014 12:26, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> On Jun 2, 2014, at 5:23 PM, Joe Stringer wrote:
>
> > Commit acaa8dac490cc6c36026d45f3010ec75f38ee142 (revalidator:
The only user of this function was removed in the previous patch, so
remove it.
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif.c | 12
ofproto/ofproto-provider.h |2 --
ofproto/ofproto.c | 41 -
3 files changed, 55
cratch with the original flow, rather than simply
refreshing the rule that was created during the creation of the xcache.
Bug #1252997.
Reported-by: Scott Hendricks
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-xlate.c | 58 ++
1 file changed, 30 in
On 4 June 2014 05:39, Alex Wang wrote:
> I confirm this patch fix the bug, but have a high level concern,
>
>
> Assume another learnt flow with hard_timeout=10 and was never hit after
> install, now, if there is frequent change to the flow table and
> need_revalidate
> is constantly 'true', this
t; need_revalidate
>> is constantly 'true', this learnt flow will never timeout... since we
>> always
>> redo the flow_mod during revalidation,
>>
>> Let's discuss further on this scenario, I'm thinking about solutions,
>>
>> Thanks,
8];
struct ofputil_flow_mod fm;
struct ofpbuf ofpacts;
On 4 June 2014 10:11, Ben Pfaff wrote:
> On Wed, Jun 04, 2014 at 09:51:16AM +1200, Joe Stringer wrote:
> > On 4 June 2014 05:39, Alex Wang wrote:
> >
> > > I confirm this patch fix the bug, but have a high l
OK, thanks. I'll push this patchset to master and branch-2.3 soon.
On 4 June 2014 10:33, Ben Pfaff wrote:
> On Wed, Jun 04, 2014 at 10:30:13AM +1200, Joe Stringer wrote:
> > Would this incremental alleviate your concerns?
> >
> > diff --git a/ofproto/ofproto-dpif-xlat
Yes, Alex has helped a lot with this. Thanks Alex!
On 4 June 2014 10:36, Ben Pfaff wrote:
> Thank you! Also many thanks to Alex.
>
> On Wed, Jun 04, 2014 at 10:34:44AM +1200, Joe Stringer wrote:
> > OK, thanks. I'll push this patchset to master and branch-2.3 soon.
> &
Thanks, I pushed this series to master and branch-2.3.
On 4 June 2014 10:06, Alex Wang wrote:
> Acked-by: Alex Wang
>
>
> On Tue, Jun 3, 2014 at 2:59 AM, Joe Stringer
> wrote:
>
>> The only user of this function was removed in the previous patch, so
>> remov
.
>
> lock_hmap()
> ukey = ukey_lookup()
> if (!ukey) {
> //create and insert
> } else {
> // trylock
> }
> unlock_hmap()
>
> What do you think?
>
>
>
> On Thu, May 29, 2014 at 6:38 PM, Joe Stringer
> wrote:
> > This patch refactors the co
Signed-off-by: Joe Stringer
---
v3: Don't require users to specify "-k" for searches.
v2: No change.
v1: First post.
---
utilities/ovs-dev.py | 14 ++
1 file changed, 14 insertions(+)
diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py
index 814a9d0..2c3af
Signed-off-by: Joe Stringer
---
v3: Set the default to -j8.
v2: Make it configurable.
v1: First post.
---
utilities/ovs-dev.py |6 ++
1 file changed, 6 insertions(+)
diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py
index 2c3af19..fa74d57 100755
--- a/utilities/ovs-dev.py
+++ b
xlate_cache to attribute stats
when full revalidation is required. Furthermore, rather than deleting
the xcache when revalidating, keep it around.
Signed-off-by: Joe Stringer
---
v2: Don't delete the old xcache when revalidating.
Removed extraneous "ukey->xcache = NULL".
--
concurrently, which means the flow does not need
to be handled anyway.
Signed-off-by: Joe Stringer
---
v2: Make ukey_create() return the ukey locked.
Rearrange the logic in ukey_acquire().
---
ofproto/ofproto-dpif-upcall.c | 95 +++--
1 file changed, 43
Rather than setting and resetting the 'mark' field in the ukey, this
patch introduces a seq to track whether a flow has been seen during the
most recent dump. This tidies the code and simplifies the logic for
detecting when flows are duplicated from the datapath.
Signed-off-by: Jo
014 12:45, Ethan Jackson wrote:
> Sorry to nit pick, but could we change the option name to "--jobs" and
> the abbreviated option to "-j". This is consistent with how make does
> it.
>
> Acked-by: Ethan Jackson
>
>
> On Tue, Jun 3, 2014 at 5:41 PM, Jo
Thanks Pravin, I applied this to master.
On 31 May 2014 07:33, Pravin Shelar wrote:
> On Mon, May 26, 2014 at 6:47 PM, Joe Stringer
> wrote:
> > This was causing failures in 'make distcleancheck'.
> >
> > Signed-off-by: Joe Stringer
&g
Thanks, pushed to master.
On 4 June 2014 12:44, Ethan Jackson wrote:
> Acked-by: Ethan Jackson
>
>
> On Tue, Jun 3, 2014 at 5:41 PM, Joe Stringer
> wrote:
> > Signed-off-by: Joe Stringer
> > ---
> > v3: Don't require users to specify "-k" for
It's unclear why these tests are named "ofproto-if..." unlike all of the
other ofproto-dpif tests. Rename them to be more consistent.
Signed-off-by: Joe Stringer
---
tests/ofproto-dpif.at |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/of
udpif->dump_seq already exists in master, and is changed by the leader
revalidator thread.
On 5 June 2014 06:29, Ethan Jackson wrote:
> Maybe I'm missing something. But I'm not seeing where the dump seq is
> incremented
>
>
> On Tuesday, June 3, 2014, Joe Strin
tats to it rather than fixing it when we
revalidate.
So, I think that the xcache should be used before revalidation, then
cleared/re-built.
On 5 June 2014 06:32, Ethan Jackson wrote:
> Acked
>
>
> On Tuesday, June 3, 2014, Joe Stringer wrote:
>
>> One of the reasons that
xlate_cache to attribute stats
when full revalidation is required, as the statistics belong to the old
ruleset. However, when revalidating, the rules may have changed while
leaving the datapath flows intact, so we still re-create the xcache at
that point.
Signed-off-by: Joe Stringer
---
v3: Clear
Thanks, I applied this to master.
On 4 June 2014 15:26, Simon Horman wrote:
> On Wed, Jun 04, 2014 at 02:54:27PM +1200, Joe Stringer wrote:
> > It's unclear why these tests are named "ofproto-if..." unlike all of the
> > other ofproto-dpif tests. Ren
Thanks, applied to master.
On 5 June 2014 06:26, Ethan Jackson wrote:
> Acked
>
>
> On Tuesday, June 3, 2014, Joe Stringer wrote:
>
>> This patch refactors the code around ukey creation and lookup to
>> simplify the code for callers. A new function ukey_acquire()
Thanks, applied to master.
On 5 June 2014 11:48, Alex Wang wrote:
> Looks good to me,
>
>
> Acked-by: Alex Wang
>
>
> On Wed, Jun 4, 2014 at 3:08 PM, Joe Stringer
> wrote:
>
>> One of the reasons that xlate_cache was introduced was to ensure that
>> st
Recieved a verbal ack, so I applied this to master.
On 5 June 2014 09:26, Joe Stringer wrote:
> udpif->dump_seq already exists in master, and is changed by the leader
> revalidator thread.
>
>
> On 5 June 2014 06:29, Ethan Jackson wrote:
>
>> Maybe I'm missi
This looks good to me, although I'm not too familiar with the code.
Tested-by: Joe Stringer
On 13 June 2014 14:06, Simon Horman wrote:
> dd51dae29bccca3 ("ofproto: Move logic for collecting read-only rules into
> rule_criteria.") modifies modify_flows__ such that the
This allows us to remove some of the sleeps from the testsuite.
Signed-off-by: Joe Stringer
---
There are still two other common cases that require sleeps:
* Waiting for handler threads to create flows.
* Waiting for the log writer to output.
However, this at least removes a few sleeps
revalidation is necessary, and the flow is invalid, then attribute
stats using the old xcache, and do not perform side-effects.
VMware-BZ: #1268574
Reported-by: Len Gao
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c | 10 --
ofproto/ofproto-dpif-xlate.c | 73
.
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c | 31 +--
1 file changed, 13 insertions(+), 18 deletions(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index 281955f..bd5c07a 100644
--- a/ofproto/ofproto-dpif-upcall.c
+++ b
for performing side-effects. Perform side-effects by flow
translation instead.
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index bd5c07a
Hi Ryan, a few broad comments:
Could you split this into two patches, the dpif interface change and the
dpif-netdev implementation change?
I'm a little uneasy about the change to the dpif_flow_dump_next()
interface, just because the size of the output parameter was previously
paired with the outp
LGTM (branches 1.10-.2.0)
Acked-by: Joe Stringer
On 20 June 2014 16:22, Alex Wang wrote:
> This patch adds a new configuration option, "max-idle" to the
> Open_vSwitch "other-config" column. This sets how long datapath flows
> are cached in the datapath before ov
I assume these two backported cleanly? Looks good, not sure if you want to
mention that it's a backport in the commit message.
Acked-by: Joe Stringer
On 20 June 2014 16:23, Alex Wang wrote:
> From: Joe Stringer
>
> This should assist testing of datapath performance, as i
Same comment about the commit message.
Acked-by: Joe Stringer
On 20 June 2014 16:23, Alex Wang wrote:
> From: Joe Stringer
>
> This patch adds a new configuration option, "max-idle" to the
> Open_vSwitch "other-config" column. This sets how long datapath fl
This could cause configuration failure on earlier versions of autoconf.
Reported-by: Lin Shaopeng
Signed-off-by: Joe Stringer
---
tests/ofp-print.at |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/ofp-print.at b/tests/ofp-print.at
index cfb604e..f2b896f 100644
taken into account. However, such information is
unavailable, and would be non-trivial to collect and maintain. So I propose
that this solution as a slightly better effort than what we had previously.
On 16 June 2014 17:09, Joe Stringer wrote:
> Commit a48c85b2d6 (revalidator: Use xcache when re
This reverts commit a48c85b2d672505b89e488d28066538705b94942. The commit
was causing intermittent testsuite failures and unexpected re-install of
stale mac-learning entries.
VMware-BZ: 1268574
Reported-by: Len Gao
Signed-off-by: Joe Stringer
---
I'd like to take another stab at gettin
On second thought, I noticed that this doesn't fix odd behaviour in the
netflow expiration test.
I sent out a patch to revert the original patch:
http://openvswitch.org/pipermail/dev/2014-June/041868.html
On 23 June 2014 18:29, Joe Stringer wrote:
> Alex, could you review this serie
Thanks, I pushed this to master. I'll follow up on the original discussion
in the other thread.
On 24 June 2014 05:35, Alex Wang wrote:
> Acked-by: Alex Wang
>
>
>
> On Mon, Jun 23, 2014 at 12:52 AM, Joe Stringer
> wrote:
>
>> This reverts commit a48c85b2d6725
On 24 June 2014 05:26, Alex Wang wrote:
> (snip)
>
> Totally agree,
>
> So, I'm thinking this solution,
>
> - in revalidate_ukey(), if need_revalidate is set, we always:
> 1. save the current xcache to old_xcache pointers.
> 2. conduct full revalidation (but never push stats during revalidation)
Various recent commits have introduced build failures on FreeBSD. This
patch fixes them.
Signed-off-by: Joe Stringer
---
lib/bfd.c|1 +
lib/netdev-bsd.c |4 +++-
lib/signals.h|1 +
3 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/bfd.c b/lib/bfd.c
index
This allows us to remove some of the sleeps from the testsuite.
Signed-off-by: Joe Stringer
---
v2: Add udpif_run(), manage connection from main thread.
v1: First post.
---
ofproto/ofproto-dpif-upcall.c | 45 +
ofproto/ofproto-dpif-upcall.h |1
Jun 13, 2014 at 05:00:40PM +1200, Joe Stringer wrote:
> > This allows us to remove some of the sleeps from the testsuite.
> >
> > Signed-off-by: Joe Stringer
> > ---
> > There are still two other common cases that require sleeps:
> > * Waiting for handler threads
Thanks, I applied this to master.
On 25 June 2014 06:22, Ben Pfaff wrote:
> On Mon, Jun 23, 2014 at 09:33:56AM +1200, Joe Stringer wrote:
> > This could cause configuration failure on earlier versions of autoconf.
> >
> > Reported-by: Lin Shaopeng
> > Signed-off-by:
These two cases used to be treated differently for IPv4/IPv6, but they
are now identical.
Signed-off-by: Joe Stringer
---
datapath/flow_netlink.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c
index 5a978f0
On 27 June 2014 09:51, Ben Pfaff wrote:
>
> Assuming you did a test build,
>
> Acked-by: Ben Pfaff
>
Yes, I checked again before pushing.
Thanks, applied to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Thanks, also received private ack from Pravin.
I pushed this to master.
On 26 June 2014 21:55, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> On Jun 25, 2014, at 8:24 PM, Joe Stringer wrote:
>
> > These two cases used to be treated differently for IPv4/IPv6, bu
I realised that branch-2.3 also needed this fix, so I also pushed it there.
On 27 June 2014 10:46, Joe Stringer wrote:
> On 27 June 2014 09:51, Ben Pfaff wrote:
>>
>> Assuming you did a test build,
>>
>> Acked-by: Ben Pfaff
>>
>
> Yes, I checked again
Thanks, I pushed this to master.
On 27 June 2014 11:07, Ben Pfaff wrote:
> On Wed, Jun 25, 2014 at 06:02:45PM +1200, Joe Stringer wrote:
> > This allows us to remove some of the sleeps from the testsuite.
> >
> > Signed-off-by: Joe Stringer
> > ---
> > v2: A
.
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c | 39 ++-
1 file changed, 18 insertions(+), 21 deletions(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index 87c2200..f0ddf63 100644
--- a/ofproto/ofproto-dpif-upcall.c
Signed-off-by: Joe Stringer
---
utilities/ovs-dev.py | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py
index 74143ca..91732e1 100755
--- a/utilities/ovs-dev.py
+++ b/utilities/ovs-dev.py
@@ -47,6 +47,14
dev.py conf"
to remove the coverage configuration.
Signed-off-by: Joe Stringer
---
I've uploaded an initial run of the test coverage here for a sample:
http://joestringer.github.io/openvswitch/index.html
If people are interested in having a coverage site like this accessible
all the time,
Is there any chance we could get some unit tests written for IPFIX as part
of this effort?
The netflow tests occasionally help to prevent regressions, so it would be
good to have something similar for IPFIX.
___
dev mailing list
dev@openvswitch.org
http:
we are likely to handle full revalidation, and
attempt that instead.
* Secondly, fall back to the existing flow throughput estimations to
determine whether to revalidate the flow or just delete it.
VMware-BZ: #1271926
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c | 17
Thanks Alex,
I've pushed applied this patch to master and branch-2.3.
On 2 July 2014 16:02, Alex Wang wrote:
> Thanks for the fix,
>
> Acked-by: Alex Wang
>
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
rom keeping incorrect flows in the datapath.
* Secondly, improve the dpif interface and perform flow_get if the flow is
missed and udpif->need_revalidate is set. In this case, perform revalidation
and decide whether to keep or delete the flow.
This may be related to
VMware-BZ: #1271926.
Joe St
This patch adds support for batching flow_get operations to the dpif. As
part of this, it also now allows fetching the mask (this was previously
not possible using a 'get' operation).
Signed-off-by: Joe Stringer
---
lib/dpif-linux.c| 70 +++
such "missed flows" immediately. This patch gives those flows a
chance to be dumped, which should improve jitter/ latency for flows in
this corner case.
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c | 33 +
1 file changed, 21 insertions(+
If the datapath doesn't dump a flow for some reason, and the current
dump is expected to revalidate all flows in the datapath, then perform
revalidation for those flows by fetching them during the sweep phase.
Signed-off-by: Joe Stringer
---
This relies on the mask dumping from the pre
Thanks for the discussion. Given the time constraints, I will prepare a
fresh version for branch-2.3 first, then address the issues on master
separately.
On 3 July 2014 08:56, Ben Pfaff wrote:
> On Wed, Jul 02, 2014 at 08:14:13PM +1200, Joe Stringer wrote:
> > There is no guara
Change the interface to allow implementations to pass back a buffer, and
allow callers to specify which of actions, mask, and stats they wish to
receive. This will be used in the next commit.
Signed-off-by: Joe Stringer
---
lib/dpif-linux.c| 23 +--
lib/dpif-netdev.c
don't revalidate it.
Signed-off-by: Joe Stringer
---
v2: Make the revalidator_sweep__() logic easier to read.
Rebase.
RFC: First post.
---
ofproto/ofproto-dpif-upcall.c | 55 +++--
1 file changed, 42 insertions(+), 13 deletions(-)
diff --git a/ofproto/of
Woops, I forgot to indicate that this series is for branch-2.3.
On 3 July 2014 12:29, Joe Stringer wrote:
> Change the interface to allow implementations to pass back a buffer, and
> allow callers to specify which of actions, mask, and stats they wish to
> receive. This will be us
issed_revalidation(revalidator, ukey))) {
struct dump_op *op = &ops[n_ops++];
dump_op_init(op, ukey->key, ukey->key_len, ukey);
On 3 July 2014 12:29, Joe Stringer wrote:
> If the datapath doesn't dump a flow for some reason, and the current
&
I appreciate the expedient review. This series doesn't actually depend on
the batched flow_get, but this was a starting point/RFC for discussion.
On 3 July 2014 09:24, Ben Pfaff wrote:
> On Wed, Jul 02, 2014 at 08:14:14PM +1200, Joe Stringer wrote:
> > This patch adds suppor
On 3 July 2014 10:30, Ben Pfaff wrote:
> On Wed, Jul 02, 2014 at 08:14:15PM +1200, Joe Stringer wrote:
> > If the datapath doesn't dump a flow for some reason, and the current
> > dump is expected to revalidate all flows in the datapath, then perform
> > revalidation f
Thanks, I pushed this to master.
On 3 July 2014 08:42, Ben Pfaff wrote:
> On Tue, Jul 01, 2014 at 01:54:18PM +1200, Joe Stringer wrote:
> > Commit acaa8dac49 (revalidator: Eliminate duplicate flow handling.)
> > ensured that a ukey will always exist for a given flow, even if it
On 3 July 2014 18:27, Jarno Rajahalme wrote:
>
> On Jul 2, 2014, at 8:22 PM, Joe Stringer wrote:
>
> In dpif_linux_operate__(), I think that it is unnecessary to put
>
> NLM_F_ECHO in the message flags.
>
> I do not think that the code in dpif_linux_operate__() is safe
Occasionally, this test would fail, with some of the ports reporting
"may_enable: false" in the bond/show output. This commit fixes the race
condition by waiting for may_enable to be true for all bond ports.
Signed-off-by: Joe Stringer
---
Running the test in a tight loop could
Thanks for the review,
On 4 July 2014 11:53, Ben Pfaff wrote:
> On Thu, Jul 03, 2014 at 12:29:25PM +1200, Joe Stringer wrote:
> > Change the interface to allow implementations to pass back a buffer, and
> > allow callers to specify which of actions, mask, and stats they wish
Change the interface to allow implementations to pass back a buffer, and
allow callers to specify which of actions, mask, and stats they wish to
receive. This will be used in the next commit.
Signed-off-by: Joe Stringer
---
v3: Set *bufp to NULL before calling ->flow_get().
Allocate
I feel like this is easier to follow if there's only one #ifdef block.
We could combine the blocks and make the two platforms more aligned with
something like this (based against master):
diff --git a/lib/util.c b/lib/util.c
index 4f9b079..c65051d 100644
--- a/lib/util.c
+++ b/lib/util.c
@@ -43,7
Even better. Thanks!
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
I pushed this to master and branch-2.3.
On 8 July 2014 09:53, Joe Stringer wrote:
> Even better. Thanks!
>
> Acked-by: Joe Stringer
>
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Thanks, I adjusted the commit message and pushed to master:
Running the test in a tight loop could cause this test to fail after
about 5 runs, with some of the ports reporting "may_enable: false" in
the "ovs-appctl bond/show" output. This commit fixes the race condition
by waiting
Change the interface to allow implementations to pass back a buffer, and
allow callers to specify which of actions, mask, and stats they wish to
receive. This will be used in the next commit.
Signed-off-by: Joe Stringer
---
v4: Rebase against master.
v3: Set *bufp to NULL before calling
don't revalidate it.
Signed-off-by: Joe Stringer
---
v4: Minor adjustments to base against master.
v3: No change.
v2: Make the revalidator_sweep__() logic easier to read.
Rebase.
RFC: First post.
---
ofproto/ofproto-dpif-upcall.c | 34 +-
1 file changed, 29 insert
for
branch-2.3. Note that I have dropped the flow_get batching code from this
version, as the revalidator code doesn't make use of this feature.
v4: Rebase against master.
v3: Address buffer safety feedback.
v2: Drop batching.
RFC: Initial post.
Joe Stringer (2):
dpif: Support fetching flow
>
> This is for branch-2.3, I think.
>
> Acked-by: Ben Pfaff
>
Yes, thanks. I've pushed this to branch-2.3.
A version of this series for master is available here:
http://mail.openvswitch.org/pipermail/dev/2014-July/042507.html
___
dev mailing list
dev
801 - 900 of 2028 matches
Mail list logo
