Signed-off-by: Joe Stringer
---
datapath/datapath.c | 25 +
datapath/datapath.h | 2 +-
2 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/datapath/datapath.c b/datapath/datapath.c
index ddcd1e5..13b2696 100644
--- a/datapath/datapath.c
+++ b/datapath
From: Alexander Duyck
Replace "ntohs(proto) >= ETH_P_802_3_MIN" w/ eth_proto_is_802_3(proto).
Backport of upstream commit 6713fc9b8fa33444aa000f0f31076f6a859ccb34:
"openvswitch: Use eth_proto_is_802_3"
Signed-off-by: Alexander Duyck
Signed-off-by: David S. Miller
Sign
This series addresses a few low-hanging fruit of stylistic differences between
the ovs tree datapath module and the upstream linux module, and adds support
for Linux 4.1.
Alexander Duyck (1):
datapath: Use eth_proto_is_802_3.
Joe Stringer (5):
datapath: Whitespace fixes.
datapath: Constify
Signed-off-by: Joe Stringer
---
.travis.yml | 1 +
acinclude.m4 | 4 ++--
datapath/datapath.h | 9 ---
datapath/flow.c | 4 +++-
datapath/linux
Backport of upstream commit 2c7a88c252bf3381958cf716f31b6b2e0f2f3fa7:
"etherdev: Fix sparse error, make test usable by other functions"
Signed-off-by: Joe Stringer
---
datapath/linux/compat/include/linux/etherdevice.h | 13 +
1 file changed, 13 insertions(+)
diff --git
Signed-off-by: Joe Stringer
---
datapath/actions.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/datapath/actions.c b/datapath/actions.c
index 6e32c00..41e30e3 100644
--- a/datapath/actions.c
+++ b/datapath/actions.c
@@ -168,10 +168,7 @@ static int pop_mpls(struct
The initial sanity test only checked IPv4 without IP fragments. This patch
adds additional tests using IPv6 and VLANs with IP fragments and expands
the existing test to be more strict.
Signed-off-by: Joe Stringer
CC: Daniele Di Proietto
---
Daniele, these tests are basic sanity checks to
Signed-off-by: Joe Stringer
---
tests/kmod-macros.at | 20
tests/kmod-traffic.at | 49 +
2 files changed, 69 insertions(+)
diff --git a/tests/kmod-macros.at b/tests/kmod-macros.at
index 3487c67..be3c123 100644
--- a/tests
annot remove the openvswitch module. Having the call here prevents
tunnel tests from manually cleaning up their datapath on exit, so this
patch removes it.
Signed-off-by: Joe Stringer
---
tests/kmod-macros.at | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/kmod-macros.at b/tests/kmod-macr
On 30 July 2015 at 11:57, Andy Zhou wrote:
> On Wed, Jul 29, 2015 at 4:52 PM, Joe Stringer wrote:
>> We already queue the removal of the kernel module in OVS_VSWITCHD_START,
>> via an ON_EXIT() call. This redundant removal also doesn't interact very
>> well with usage
On 30 July 2015 at 10:08, Jesse Gross wrote:
> On Wed, Jul 29, 2015 at 12:53 PM, Joe Stringer wrote:
>> Signed-off-by: Joe Stringer
>> ---
>> datapath/datapath.c | 25 +
>> datapath/datapath.h | 2 +-
>> 2 files changed, 14 insert
On 30 July 2015 at 12:24, Jesse Gross wrote:
> On Wed, Jul 29, 2015 at 12:53 PM, Joe Stringer wrote:
>> diff --git a/.travis.yml b/.travis.yml
>> index 70cc14b..f3236db 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -12,6 +12,7 @@ env:
>>- TEST
Thanks Jesse, applied patches 1-5 to master. I'll address your
comments on patch #6 in a new series.
On 29 July 2015 at 12:53, Joe Stringer wrote:
> This series addresses a few low-hanging fruit of stylistic differences between
> the ovs tree datapath module and the upstream linux
On 30 July 2015 at 11:37, Daniele Di Proietto wrote:
> I get a warning in the OVS log that causes this test to fail.
>
> It appears that when br0 is removed (in OVS_KMOD_VSWITCHD_STOP)
> OVS gets a rtnetlink message (because br0 had an address in the
> routing table), but route_table_parse() fails
On 30 July 2015 at 12:02, Andy Zhou wrote:
> On Wed, Jul 29, 2015 at 4:52 PM, Joe Stringer wrote:
>> Signed-off-by: Joe Stringer
>> ---
>> tests/kmod-macros.at | 20
>> tests/kmod-traffic.at | 49 ++
for _Bool, and
> documents all of them.
>
> Reported-by: Joe Stringer
> Signed-off-by: Ben Pfaff
This fixes the build for me. I assume we have a test to determine this
is performing the correct behaviour?
Acked-by: Joe Stringer
___
dev maili
Github also allows you to browse commits by tag, eg:
https://github.com/openvswitch/ovs/commits/v2.3.2
On 3 August 2015 at 09:38, Justin Pettit wrote:
> The best way to see what was fixed is to look at the commit history. Here's
> the github history for branch-2.3:
>
> https://github.c
On 30 July 2015 at 11:21, Daniele Di Proietto wrote:
> Acked-by: Daniele Di Proietto
>
> On 30/07/2015 00:52, "Joe Stringer" wrote:
>
>>The initial sanity test only checked IPv4 without IP fragments. This patch
>>adds additional tests using IPv6 and VLANs w
an not be const.
>
> Signed-off-by: Pravin B Shelar
Acked-by: Joe Stringer
Hrm. I recognised that at least some of these fields were being
written to (hence why some of them are not const); None of the
compilers I used managed to pick up on these.
Is there any way to retain some of these, or ar
Thanks for this Daniele.
A couple of general things:
- "userspace testsuite" as a name, while accurate, is also perhaps
misleading as the unit tests are also userspace tests (and don't
require any special root privileges). I guess this class of tests
should be "system", in which case it would make
On 5 August 2015 at 11:08, Daniele Di Proietto wrote:
>
>
> On 05/08/2015 18:44, "Joe Stringer" wrote:
>
>>Thanks for this Daniele.
>>
>>A couple of general things:
>>- "userspace testsuite" as a name, while accurate, is also perhaps
>
With this full series applied, gcc (Debian 4.9.2-10) 4.9.2:
../lib/classifier-private.h:352:14: warning: crazy programmer
I think this is actually a sparse warning, and I've seen it before but
I have no recollection how we appeased it.
On 5 August 2015 at 10:53, Jarno Rajahalme wrote:
> Struct
'features' is always a valid pointer to something on the stack, so
checking (!features || ...) is the same as checking (false || ...).
Simplify the expression.
Found by MIT STACK undefined behaviour checker.
Signed-off-by: Joe Stringer
---
lib/ofp-print.c | 2 +-
1 file changed, 1
On 5 August 2015 at 10:53, Jarno Rajahalme wrote:
> Signed-off-by: Jarno Rajahalme
> ---
> lib/classifier.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/lib/classifier.c b/lib/classifier.c
> index fc6a1f5..cba80b5 100644
> --- a/lib/classifier.c
> +++ b/lib/cla
On 5 August 2015 at 13:02, Raul Suarez Marin
wrote:
> Hello everyone,
>
> I am developing a new match option in the datapath. I implemented almost
> everything already, but I am missing something and I don't know what nor
> what is next step.
>
> Adding the flow directly to the datapath gives the
at but I'm not able to see it anywhere :(
>
> Thank you for your answer,
>
> Kind regards,
> Raúl
>
> 2015-08-05 22:40 GMT+02:00 Joe Stringer :
>>
>> On 5 August 2015 at 13:02, Raul Suarez Marin
>> wrote:
>> > Hello everyone,
>> >
>&
On 6 August 2015 at 00:54, Ilya Maximets wrote:
> ping.
>
> On 30.07.2015 18:29, Ilya Maximets wrote:
>> In multiqueue mode several pmd threads may process one
>> port, but different queues. Flow doesn't depend on queue.
>>
>> So, while miss upcall processing, all threads (except first
>> for that
On 30 July 2015 at 12:51, Joe Stringer wrote:
> On 30 July 2015 at 11:57, Andy Zhou wrote:
>> On Wed, Jul 29, 2015 at 4:52 PM, Joe Stringer wrote:
>>> We already queue the removal of the kernel module in OVS_VSWITCHD_START,
>>> via an ON_EXIT() call. This redundant re
On 4 August 2015 at 11:00, Daniele Di Proietto wrote:
> This series adds a new testsuite for the userspace datapath that runs
> the already written kmod-sanity tests. The reason for this are
> explained in the 3rd commit message.
>
> The first two commits just move some code (without modifing it)
On 6 August 2015 at 18:37, Andy Zhou wrote:
> On Thu, Aug 6, 2015 at 3:58 PM, Joe Stringer wrote:
>> On 30 July 2015 at 12:51, Joe Stringer wrote:
>>> On 30 July 2015 at 11:57, Andy Zhou wrote:
>>>> On Wed, Jul 29, 2015 at 4:52 PM, Joe Stringer
>>>>
On 7 August 2015 at 11:40, Daniele Di Proietto wrote:
> This series adds a new testsuite for the userspace datapath that runs
> the already written kmod-sanity tests. The reason for this are
> explained in the 3rd commit message.
>
> The testsuite is called `system userspace-testsuite` and can be
Various minor fixups and extensions to the system tests, followed by a basic
tunnel sanity test for vxlan.
Joe Stringer (5):
system-kmod-macros: Fix VSWITCHD_STOP.
system-common-macros: Don't use bash to exec in ns.
system-traffic: Check ping-by-ping output.
system-macros: Create A
ip netns exec $namespace $command doesn't need to use bash to execute
the command. Remove it.
Signed-off-by: Joe Stringer
---
tests/system-common-macros.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at
Rather than saving all of the ping output to a file then checking at the
end, check each ping and fail as soon as there is a connectivity
failure.
Signed-off-by: Joe Stringer
---
tests/system-common-macros.at | 6 ++
tests/system-traffic.at | 44
This was renamed. Surprisingly, the tests still pass without this,
however the extra checks that this command performs were not executed.
Fix the macro definition.
Signed-off-by: Joe Stringer
---
tests/system-kmod-macros.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
the correct datapath type for userspace or kmod tests.
Signed-off-by: Joe Stringer
---
tests/system-common-macros.at| 6 ++
tests/system-kmod-macros.at | 6 +++---
tests/system-userspace-macros.at | 6 +++---
3 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/tests
Signed-off-by: Joe Stringer
---
tests/system-common-macros.at | 38 ++
tests/system-kmod-macros.at | 10 --
tests/system-traffic.at | 38 ++
3 files changed, 84 insertions(+), 2 deletions(-)
diff --git a
gust 2015 at 11:40, Daniele Di Proietto wrote:
> I guess you need this to use quotes("") inside 'command'.
>
> One effect of this change is that if 'command' contains a pipe
> (or &&, or ||) just the first command will be executed inside
> t
to use ADD_BR inside the OVS_TRAFFIC_VSWITCHD_START()
> parameters, but I'm fine with this approach too.
>
> Acked-by: Daniele Di Proietto
>
> On 08/08/2015 00:28, "Joe Stringer" wrote:
>
>>This patch splits ADD_BR into two commands, so they can be used from
dy are AT_CHECK and AT_CHECK_UNQUOTED, and the "UNQUOTED"
> refers to comparison text.
>
> How about this?
>
> # NS_EXEC([namespace], [command])
> #
> # Execute 'command' in 'namespace'
> m4_define([NS_EXEC],
> [ip netns exec $1 sh << NS_E
FWIW the "slice" logic in the for loop is meant to ensure that no
revalidator threads concurrently clean the same map.
There's two cases where the main thread might call into this as well
though, one is when reconfiguring threads (which shouldn't conflict,
because it stops all revalidators first),
On 10 August 2015 at 18:46, Ethan J. Jackson wrote:
> exit:
> -if (ok) {
> +if (result != UKEY_DELETE) {
> ukey->reval_seq = reval_seq;
> }
> -if (netflow && !ok) {
> +if (netflow && result != UKEY_DELETE) {
> netflow_flow_clear(netflow, &flow);
> }
I
On 11 August 2015 at 11:13, Jarno Rajahalme wrote:
>> -if (!keep) {
>> +if (result == UKEY_DELETE) {
>> delete_op_init(udpif, &ops[n_ops++], ukey);
>> +} else if (result == UKEY_MODIFY) {
>> +ofpbuf_delete(ukey->actions);
>> +
On 10 August 2015 at 11:32, Daniele Di Proietto wrote:
> I'm surprised as well that the tests were passing.
>
> Sorry about this and thanks for finding out
>
> Acked-by: Daniele Di Proietto
Thanks, I applied this patch to master.
I plan to revise the later patches to try to handle support detec
Add various minor fixups and improvements to the system tests, and a basic
tunnel sanity test for vxlan.
v2: Applied one patch
Tested series on Ubuntu 14.04.2
Better detection of tool support for tunnels
Joe Stringer (5):
system-common-macros: Allow quotes in NS_EXEC().
system
This allows arbitrary commands to be passed into the NS_EXEC macro to be
executed within a namespace, including commands that have quotes and
commands chained together.
Signed-off-by: Joe Stringer
---
Daniele, thanks for the suggestion, this seems to work pretty well. My
only complaint is that
g the next.
Drop this extra step.
Signed-off-by: Joe Stringer
---
An alternative would be to force test writers to add additional
boilerplate to ensure that they delete addresses from bridges before
calling OVS_VSWITCHD_STOP. This approach seems to be lower maintenance.
---
tests/system-kmod
the correct datapath type for userspace or kmod tests.
Signed-off-by: Joe Stringer
Acked-by: Daniele Di Proietto
---
tests/system-common-macros.at| 6 ++
tests/system-kmod-macros.at | 6 +++---
tests/system-userspace-macros.at | 6 +++---
3 files changed, 12 insertions(+), 6
This test is skipped if the 'ip' command cannot interpret the vxlan 'dstport'
option; this is used as a proxy for detecting native kernel support for this
tunnel type.
Signed-off-by: Joe Stringer
---
This initial sanity test uses a linux device tunnel in combination with an
Rather than saving all of the ping output to a file then checking at the
end, check each ping and fail as soon as there is a connectivity
failure.
Signed-off-by: Joe Stringer
---
tests/system-common-macros.at | 6 ++
tests/system-traffic.at | 44
On 7 August 2015 at 16:57, Jarno Rajahalme wrote:
> Remove unused cls_rule_hash() and minimatch_hash() functions.
>
> Signed-off-by: Jarno Rajahalme
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.or
On 7 August 2015 at 16:57, Jarno Rajahalme wrote:
> mf_value has grown bigger than needed for storing the biggest
> supported prefix (IPv6 address length). Define a new type to be used
> instead of mf_value.
>
> This makes classifier lookups a bit faster.
>
> Signed-off-by: Jarno Rajahalme
> ---
On 7 August 2015 at 16:57, Jarno Rajahalme wrote:
> minimask_hash() can be simplified as each value is known to be non-zero.
>
> Move miniflow_hash() into test-classifier.c as miniflow_hash__() as it
> is no longer needed elsewhere.
>
> Signed-off-by: Jarno Rajahalme
Acke
On 7 August 2015 at 16:57, Jarno Rajahalme wrote:
> Signed-off-by: Jarno Rajahalme
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
\
> +size_t ofs = (OFS); \
> +\
Being a bit pedantic here, but don't we usually use 'size_t' to
indicate a length
On 12 August 2015 at 16:48, Jarno Rajahalme wrote:
>
> On Aug 12, 2015, at 2:18 PM, Joe Stringer wrote:
>
> On 7 August 2015 at 16:57, Jarno Rajahalme wrote:
>
> mf_value has grown bigger than needed for storing the biggest
> supported prefix (IPv6 address length). Define
On 17 August 2015 at 10:22, Daniele Di Proietto wrote:
> The patch looks good to me.
>
> I think that losing some packets when the thread are reconfigured
> is unavoidable, considering that often the NIC must be stopped
> to change the number of rxqs. Does this make sense?
>
> Related to this, I'
On 17 August 2015 at 07:39, Daniele Di Proietto wrote:
> Acked-by: Daniele Di Proietto
Thanks, applied.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 17 August 2015 at 07:38, Daniele Di Proietto wrote:
> Acked-by: Daniele Di Proietto
>
> On 12/08/2015 22:01, "Joe Stringer" wrote:
>
>>This allows arbitrary commands to be passed into the NS_EXEC macro to be
>>executed within a namespace, including comman
Thanks, applied.
On 17 August 2015 at 07:42, Daniele Di Proietto wrote:
> Acked-by: Daniele Di Proietto
>
> On 12/08/2015 22:01, "Joe Stringer" wrote:
>
>>Depending on the kernel in use, manually removing a bridge during
>>OVS_VSWITCHD_STOP can cause the
I renamed the patch to "system-traffic" and applied to master, thanks.
On 17 August 2015 at 07:45, Daniele Di Proietto wrote:
> It works both for userspace and kernel datapath, thanks!
>
> Acked-by: Daniele Di Proietto
>
> On 12/08/2015 22:01, "Joe Stringer&quo
On 12 August 2015 at 14:01, Joe Stringer wrote:
> This patch splits ADD_BR into two commands, so they can be used from
> different contexts:
>
> ADD_BR(...) is a standalone command to add a bridge to OVS, and allows
> additional ovs-vsctl arguments to be passed. It uses _ADD_
On 19 August 2015 at 16:12, Ben Pfaff wrote:
> On Wed, Aug 05, 2015 at 01:31:25PM -0700, Joe Stringer wrote:
>> 'features' is always a valid pointer to something on the stack, so
>> checking (!features || ...) is the same as checking (false || ...).
>> Simplify the
On 26 August 2015 at 09:04, Ben Pfaff wrote:
> On Fri, Aug 21, 2015 at 03:25:18PM -0700, Jarno Rajahalme wrote:
>> Reserve the use of size_t for sizes of objects in bytes.
>>
>> Suggested-by: Joe Stringer
>> Signed-off-by: Jarno Rajahalme
>
> I think that size_
On 28 August 2015 at 09:41, Daniele Di Proietto wrote:
> I've tested it and it appears to correctly keep all the stats.
>
> Two comments inline, otherwise:
>
> Acked-by: Daniele Di Proietto
That could even be... dare I say it... "Tested-by: ..." :-)
In general this patch seems fine. I'm not en
Thanks for working on this, Alex. I've considered implementing an
approach like this before, but haven't had a strong reason to.
On 29 August 2015 at 00:42, Alex Wang wrote:
> This commit adds logic using ovs barrier to allow main thread pause
> all revalidators. This new feature will be used in
stats.
>
> Reported-by: Ilya Maximets
> Signed-off-by: Alex Wang
> Acked-by: Daniele Di Proietto
> Tested-by: Daniele Di Proietto
This looks good to me, so long as we can iron out the issues in patch 1.
Acked-by: Joe Stringer
___
dev m
On 29 August 2015 at 15:24, Alex Wang wrote:
>
>
> On Sat, Aug 29, 2015 at 11:34 AM, Joe Stringer
> wrote:
>>
>> Thanks for working on this, Alex. I've considered implementing an
>> approach like this before, but haven't had a strong reason to.
>>
&
On 29 August 2015 at 17:42, ALeX Wang wrote:
>
>
> On 29 August 2015 at 16:45, Joe Stringer wrote:
>>
>> On 29 August 2015 at 15:24, Alex Wang wrote:
>> >
>> >
>> > On Sat, Aug 29, 2015 at 11:34 AM, Joe Stringer
>> > wrote:
>
Hi Alex, a minor comment, otherwise
On 29 August 2015 at 18:44, Alex Wang wrote:
> This commit adds logic using ovs barrier to allow main thread pause
> all revalidators. This new feature will be used in a later patch.
>
> Signed-off-by: Alex Wang
Acked-by: Joe Stringer
>
On 9 September 2015 at 09:48, Pravin Shelar wrote:
> Are you planning on sending updated version of this patch?
I'm too busy to do it any time soon.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 9 September 2015 at 10:31, Pravin Shelar wrote:
> On Wed, Sep 9, 2015 at 9:51 AM, Joe Stringer wrote:
>> On 9 September 2015 at 09:48, Pravin Shelar wrote:
>>> Are you planning on sending updated version of this patch?
>>
>> I'm too busy to do it any time
On 2 September 2015 at 16:43, Ben Pfaff wrote:
> dnl set up sFlow logging
> -dnl ON_EXIT([kill `cat test-sflow.pid`])
> AT_CHECK([ovstest test-sflow --log-file --detach --no-chdir --pidfile
> 0:127.0.0.1 > sflow.log], [0], [], [ignore])
> AT_CAPTURE_FILE([sflow.log])
> SFLOW_PORT=`parse_liste
On 9 September 2015 at 15:38, Ben Pfaff wrote:
> On Wed, Sep 09, 2015 at 03:36:56PM -0700, Joe Stringer wrote:
>> On 2 September 2015 at 16:43, Ben Pfaff wrote:
>> > dnl set up sFlow logging
>> > -dnl ON_EXIT([kill `cat test-sflow.pid`])
>> > AT_CHECK([ov
The next patch will introduce nested actions with special restrictions.
Refactor the action verification to allow ofpacts_verify() to identify
nesting so that these retrictions may be applied.
Signed-off-by: Joe Stringer
---
lib/ofp-actions.c | 104
This combines a common set of operations into a single command.
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-xlate.c | 42 --
1 file changed, 16 insertions(+), 26 deletions(-)
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif
c testsuite in tests/system-traffic.at.
This series is also available as a pull request, here:
https://github.com/openvswitch/ovs/pull/66
Andy Zhou (1):
dpif-netlink: Allow MRU packet attribute.
Daniele Di Proietto (1):
lib: Introduce ovs_u128_is_zero().
Joe Stringer (6):
ofproto-dpif-xlate: Intr
te=-trk,tcp,action=ct(table=1,zone=9)"
ovs-ofctl add-flow br0 \
"table=1,in_port=2,conn_state=+trk+est-new,tcp,action=1"
ovs-ofctl add-flow br0 \
"table=1,in_port=2,conn_state=+trk-est+new,tcp,action=drop"
Based on original design by Justin Pettit
From: Andy Zhou
User space now may receive re-assembled IP fragments. The user space
netlink handler can now accept packets with the new OVS_PACKET_ATTR_MRU
attribute. This allows the kernel to assemble fragmented packets for the
duration of OpenFlow processing, then re-fragment at output time. M
rel,action=ct(commit),1
Signed-off-by: Joe Stringer
---
datapath/linux/compat/include/linux/openvswitch.h | 3 +
include/sparse/netinet/in.h | 2 +
include/windows/netinet/in.h | 1 +
lib/netlink.c | 11 ++
From: Daniele Di Proietto
is_all_zeros() is quite slow for u128 initialization because:
- It is not inlined
- It checks byte by byte
This commit introduces a new function to perform this function, which
improves performance in the DPDK packet processing path for upcoming
commits that regularly c
On 9 September 2015 at 19:00, Joe Stringer wrote:
>
> This series is also available as a pull request, here:
> https://github.com/openvswitch/ovs/pull/66
My mail client ate patches 4 and 6, due to this one line that's over 1000
characters long. (In the test suite). Suggest using t
On 10 September 2015 at 11:05, Ben Pfaff wrote:
> Who do you think should review this?
I think that either Justin or Jarno should probably review this.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Previously, we had no IPFIX tests in the testsuite. Now we have one.
Signed-off-by: Joe Stringer
---
tests/ofproto-dpif.at | 37 +
1 file changed, 37 insertions(+)
diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
index eb8647b..93ce5df 100644
--- a
ff700) at
pthread_create.c:312
#6 0x7f62688db47d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:111
...
(gdb) p di->bridge_exporter->probability
$2 = 0
Romain and/or Wenyu, do you mind reviewing this series?
Joe Stringer (3):
tests: Add basic IPFIX test.
Rather than describing this intention after the fact, encode this
meaning in the name of a function.
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-ipfix.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto-dpif-ipfix.c b/ofproto/ofproto-dpif
sthread_wrapper (...) at ../lib/ovs-thread.c:340
start_thread (...) at pthread_create.c:312
clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
Signed-off-by: Joe Stringer
---
Given that there's a couple of other places in the IPFIX code that check
the probability before using it, I&#
On 10 September 2015 at 10:07, Ben Pfaff wrote:
> On Wed, Sep 09, 2015 at 07:00:17PM -0700, Joe Stringer wrote:
>> This combines a common set of operations into a single command.
>>
>> Signed-off-by: Joe Stringer
>
> Nice cleanup.
>
> Acke
On 10 September 2015 at 11:01, Ben Pfaff wrote:
> On Wed, Sep 09, 2015 at 07:00:18PM -0700, Joe Stringer wrote:
>> The next patch will introduce nested actions with special restrictions.
>> Refactor the action verification to allow ofpacts_verify() to identify
>> nesting so t
On 10 September 2015 at 19:03, Jarno Rajahalme wrote:
>
>> On Sep 9, 2015, at 7:00 PM, Joe Stringer wrote:
>> @@ -672,6 +705,8 @@ struct ovs_action_push_tnl {
>> * indicate the new packet contents. This could potentially still be
>> * %ETH_P_MPLS if the resulting MP
On 10 September 2015 at 11:05, Ben Pfaff wrote:
> Who do you think should review this?
Jarno and I discussed the OpenFlow interface a little at lunch, would
you mind looking at this particular aspect from an API cleanliness
point of view?
___
dev mailin
On 11 September 2015 at 14:02, Jarno Rajahalme wrote:
>>> - new and reply are mutually exclusive (reply direction is defined as
>>> opposite of the initial +new)
>>
>> Strictly speaking I don't think this is the case. I don't have an
>> example, but it is possible for this to be set in the conntr
On 11 September 2015 at 09:53, Jim Davis wrote:
> Building with the attached random configuration file,
>
> net/built-in.o: In function `ovs_ct_execute':
> (.text+0x10f587): undefined reference to `nf_ct_frag6_gather'
Thanks for the report, I sent a patch:
https://patchwork.ozlabs.org/patch/51703
On 11 September 2015 at 11:11, Romain Lenglet wrote:
> Thanks for doing this!
>
> Acked-by: Romain Lenglet
Thanks, applied to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 11 September 2015 at 11:11, Romain Lenglet wrote:
> LGTM, thanks!
>
> Acked-by: Romain Lenglet
Thanks, applied to master and branch-2.[134].
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 11 September 2015 at 11:12, Romain Lenglet wrote:
> LGTM, thanks!
>
> Acked-by: Romain Lenglet
Thanks, applied to master and branch-2.[134].
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
From: Ben Pfaff
These will be used in an upcoming commit.
This is a backport of master commit c1a29506e854.
Signed-off-by: Ben Pfaff
Acked-by: Jarno Rajahalme
Signed-off-by: Joe Stringer
---
lib/bitmap.c | 44
lib/bitmap.h | 6 ++
2 files
The branch-2.3 backport of master commit eac0dc83c468 missed some
changes required to build on the older codebase. Fix the issue.
Fixes: b2235a2f4d4c ("ovsdb: Update _version more accurately in
transaction commit.")
Signed-off-by: Joe Stringer
---
ovsdb/transaction.c | 4 ++--
1 file
On 11 September 2015 at 14:42, Jarno Rajahalme wrote:
>> diff --git a/tests/system-traffic.at b/tests/system-traffic.at
>> index 7dbed68..de6b016 100644
>> --- a/tests/system-traffic.at
>> +++ b/tests/system-traffic.at
>> @@ -139,3 +139,472 @@ NS_CHECK_EXEC([at_ns0], [ping -s 3200 -q -c 3 -i 0.3
Thanks for catching this. It is also used later on to set xin.may_learn,
does that matter too?
On 19 April 2014 03:22, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> On Apr 17, 2014, at 7:19 PM, YAMAMOTO Takashi
> wrote:
>
> > Catched by "learning action - self-modifying flow with har
601 - 700 of 2028 matches
Mail list logo
