Re: [ovs-dev] [PATCH 0/5] check-kernel: add 802.1ad tests

On 29 July 2016 at 13:11, Eric Garver wrote: > Hi Joe, > > Thanks for providing feedback. > > On Fri, Jul 29, 2016 at 11:14:36AM -0700, Joe Stringer wrote: >> On 28 July 2016 at 10:54, Eric Garver wrote: >> > This series adds 6 test cases to the "check-kernel&q

Re: [ovs-dev] [PATCH 3/5] check-kernel: 802.1ad: Add conntrack ping tests for CVLANs.

On 29 July 2016 at 13:48, Eric Garver wrote: > On Fri, Jul 29, 2016 at 11:34:24AM -0700, Joe Stringer wrote: >> On 29 July 2016 at 11:30, Joe Stringer wrote: >> > On 28 July 2016 at 10:54, Eric Garver wrote: >> >> Signed-off-by: Eric Garver >> > &g

Re: [ovs-dev] [PATCH v2 0/3] datapath: tunneling fixes.

On 26 July 2016 at 15:24, Pravin B Shelar wrote: > First two patches fixes to issues related to geneva and vxlan tunnel. > Third patch is just code improvement. It looks like this patch series introduced breakage for kernels < 3.10 (for branch-2.5): https://travis-ci.org/openvswitch/ovs/builds/14

Re: [ovs-dev] [PATCH 2/6] compat: Simplify inet_fragment backports.

On 1 August 2016 at 10:21, pravin shelar wrote: > On Tue, Jul 12, 2016 at 3:26 PM, Joe Stringer wrote: >> The core fragmentation handling logic is exported on all supported >> kernels, so it's not necessary to backport the latest version of this. >> This greatly

[ovs-dev] [PATCH] compat: Properly handle fragment lru.

assembly.") Signed-off-by: Joe Stringer --- acinclude.m4 | 1 + datapath/linux/compat/include/net/inet_frag.h | 6 ++ datapath/linux/compat/ip_fragment.c | 1 + datapath/linux/compat/nf_conntrack_reasm.c| 1 + 4 files changed, 9 insertions(+)

Re: [ovs-dev] [PATCH 2/6] compat: Simplify inet_fragment backports.

On 1 August 2016 at 13:07, pravin shelar wrote: > On Mon, Aug 1, 2016 at 11:46 AM, Joe Stringer wrote: >> On 1 August 2016 at 10:21, pravin shelar wrote: >>> On Tue, Jul 12, 2016 at 3:26 PM, Joe Stringer wrote: >>>> The core fragmentation handling logi

Re: [ovs-dev] [PATCH 2/6] compat: Simplify inet_fragment backports.

On 1 August 2016 at 13:07, pravin shelar wrote: > On Mon, Aug 1, 2016 at 11:46 AM, Joe Stringer wrote: >> On 1 August 2016 at 10:21, pravin shelar wrote: >>> On Tue, Jul 12, 2016 at 3:26 PM, Joe Stringer wrote: >>>> The core fragmentation handling logi

Re: [ovs-dev] [PATCH branch-2.5] datapath: fix build failure.

27;encapsulation' in struct sk_buff > > Reported-by: Joe Stringer > Signed-off-by: Pravin B Shelar LGTM, assuming you've tested it: Acked-by: Joe Stringer ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] compat: Properly handle fragment lru.

On 1 August 2016 at 14:08, Joe Stringer wrote: > In kernels <=3.16 there is an LRU for managing fragment queues for IPv4 > and IPv6. Because the backport code comes from more recent upstream > versions of Linux, this LRU management was missing from ip_frag_queue() > and nf

Re: [ovs-dev] [PATCH] compat: Properly handle fragment lru.

On 1 August 2016 at 16:52, pravin shelar wrote: > On Mon, Aug 1, 2016 at 2:25 PM, Joe Stringer wrote: >> On 1 August 2016 at 14:08, Joe Stringer wrote: >>> In kernels <=3.16 there is an LRU for managing fragment queues for IPv4 >>> and IPv6. Because the backpo

Re: [ovs-dev] [PATCH 0/6] compat: Fix various fragmentation-related crashes.

On 12 July 2016 at 15:26, Joe Stringer wrote: > This series fixes a couple of crashes that may occur due to the backports of > the inet_fragment.c code from upstream. These are primarily related to cases > where a fragment is received and cached in the OVS fragment handling code >

Re: [ovs-dev] [PATCH] tests: Fix conntrack tests on windows.

have different tables for pre-conntrack and post-conntrack flows. Acked-by: Joe Stringer > --- > tests/ofproto-dpif.at | 263 > +- > 1 file changed, 174 insertions(+), 89 deletions(-) > > diff --git a/tests/ofproto-dpif.at b

Re: [ovs-dev] [PATCH] fedora.spec: Disable rpmbuild unpackaged files check.

On 2 August 2016 at 14:41, William Tu wrote: > Starting with RPM 4.1, rpmbuild will exit if all files in the $RPM_BUILD_ROOT > directory are not found in the %files section, resulting errors below: > RPM build errors: > Installed (but unpackaged) file(s) found: > /usr/include/ovn/actions.h

Re: [ovs-dev] [PATCH] test-netlink-conntrack: Fix sparse warning.

t until e0835a5354ab("Bug 20215: Always undefine > __always_inline before defining it."). > > This commit works around the issue by including a glibc header before a > kernel header. > > Fixes: 2c06d9a927c5("ovstest: Add test-netlink-conntrack command.") > Reported

Re: [ovs-dev] [PATCH] datapath: Remove incorrect WARN_ONCE().

> upcall.") > Suggested-by: Joe Stringer > Signed-off-by: Jarno Rajahalme > Acked-by: Joe Stringer > > Signed-off-by: Jarno Rajahalme Can you get the upstream commit id and add it into the commit message? Thanks. Acked-by: Joe Stringer _

[ovs-dev] [PATCH] ofproto-dpif-xlate: Log flow in XLATE_REPORT().

k is a GCC thing rather than part of the C standard, but it successfully compiles on GCC 6.1.1, Clang 3.8.1, and the compiler that Appveyor CI uses so it seems like it is widely supported. Signed-off-by: Joe Stringer --- ofproto/ofproto-dpif-xlate.c | 21 ++--- 1 file changed, 14

[ovs-dev] [PATCH] system-traffic: Make ping6 vlan test more reliable.

Previously we checked on the underlying interfaces rather than the vlan interfaces to verify whether IPv6 connectivity is available; occasionally this would fail on some systems. Wait on the VLAN IP instead. Signed-off-by: Joe Stringer --- tests/system-traffic.at | 2 +- 1 file changed, 1

Re: [ovs-dev] [PATCH v2 0/5] check-kernel: add 802.1ad tests

Thanks for updating the series. With the incremental patch below this is looking pretty reliable for check-kmod/check-kernel on the platforms I can test on, although there's still some issue with "make check-system-userspace". It seems like the userspace datapath cannot receive double-tagged packe

Re: [ovs-dev] ovs dpdk : userspace connection tracker cannot support L7？

On 2 August 2016 at 19:30, Yangyongqiang (Tony, Shannon) wrote: > Hello, > > We read the connection tracker code, and find this patch can not parse ftp > protocol. > > Whether the userspace connection tracker only has L4 feather or has L7 > feather too ? > > If the ct cannot L7, then ovs dpdk ca

Re: [ovs-dev] 答复: ovs dpdk : userspace connection tracker cannot support L7？

I'm not aware of anyone working on this currently. On 4 August 2016 at 18:20, Yangyongqiang (Tony, Shannon) wrote: > Hi Joe， > Thanks for your reply, this is very helpful. > Is there any body do this now? so we can do it together. > > thanks > > -邮件原

Re: [ovs-dev] [PATCH 1/3] system-userspace-macros: Check the exit code of ethtool.

file. > > Fixes: ddcf96d2dcc1 ("system-tests: Disable offloads in userspace tests.") > Reported-by: Joe Stringer > Signed-off-by: Daniele Di Proietto Thanks, this should make it more obvious when offloads are causing failures. The commit message doesn't really explain why th

Re: [ovs-dev] [PATCH 2/3] system-traffic: Flush conntrack after debug ping6.

t; addresses). > > Fixes: e5cf8cce2759("system-tests: Add ping through conntrack test.") > Reported-by: Joe Stringer > Signed-off-by: Daniele Di Proietto Acked-by: Joe Stringer ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] system-traffic: Make ping6 vlan test more reliable.

On 4 August 2016 at 18:28, Daniele Di Proietto wrote: > LGTM, thanks > > Acked-by: Thanks, applied. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

L3 and L2 GRE tunnels by OvS with both >> > IP-in-MPLS and IP (without MPLS) payloads. >> > >> >> Thanks for testing it. Can you also add those tests to OVS kmod test suite? >> .. > > Sure, I will look into doing that. > Am I correct in thinking Joe St

Re: [ovs-dev] [PATCH v2 0/5] check-kernel: add 802.1ad tests

pport to preserve backwards > compatibility. I'll hold off on sending out another revision until I can > make the necessary test changes to support the feature flag. The feature > flag probably also means additional tests to cover both operating modes. OK, fair enough. Whenever you're

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Log flow in XLATE_REPORT().

On 11 August 2016 at 11:04, Ben Pfaff wrote: > On Thu, Aug 04, 2016 at 02:58:38PM -0700, Joe Stringer wrote: >> To assist debugging pipelines when resubmit resource checks fail, print >> the base_flow from the translation context. This base flow can then be >> used from of

[ovs-dev] [PATCHv2] ofproto-dpif-xlate: Log flow in XLATE_REPORT_ERROR.

To assist debugging pipelines when resubmit resource checks fail, print the base_flow from the translation context. This base flow can then be used from ofproto/trace to figure out which parts of the pipeline lead to this translation error. Signed-off-by: Joe Stringer --- ofproto/ofproto-dpif

Re: [ovs-dev] [PATCH 0/6] Update xenserver scripts for newer python.

On 3 June 2016 at 09:13, Ben Pfaff wrote: > On Mon, May 23, 2016 at 06:20:25PM -0700, Joe Stringer wrote: >> Since commit e23812fc60af ("Increase prerequisite from Python 2.4 to >> Python 2.7.") in OVS v2.5, we have required a newer version of python >> to bui

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: prevent memory leak on log message

On 8 June 2016 at 09:04, Thadeu Lima de Souza Cascardo wrote: > When DPIF does not support UFID (like old kernels), it may print this message > quite frequently, if using an OVS version that does not include the upstream > fix > af50de8 ("ofproto-dpif-upcall: Pass key to dpif_flow_get()."). > > S

Re: [ovs-dev] [PATCH] sparse: Fix conflict between netinet/in.h and linux/in.h

/in.h:84:16: error: redefinition of struct in_addr > > Signed-off-by: Daniele Di Proietto I was noticing these issues too, thanks for fixing them. Tested-by: Joe Stringer ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Bug#826780: Bug#826780: Please package OVS >= 2.6.0.dev1

On 8 June 2016 at 16:40, Ben Pfaff wrote: > On Thu, Jun 09, 2016 at 01:23:12AM +0200, Thomas Goirand wrote: >> Source: openvswitch >> Version: 2.3.0+git20140819-4 >> Severity: normal >> >> Hi, >> >> OpenStack Neutron currently has: >> >> ovs>=2.5.0;python_version=='2.7' # Apache-2.0 >> ovs>=2.6.0.

[ovs-dev] Bug#826780: Bug#826780: Please package OVS >= 2.6.0.dev1

On 9 June 2016 at 08:50, Terry Wilson wrote: > On Thu, Jun 9, 2016 at 3:07 AM, Russell Bryant wrote: >> The real solution to making this less awkward would be to split the Python >> library out of the OVS git tree so that it can be released independently of >> OVS itself. That way a proper veris

Re: [ovs-dev] [PATCH v4 04/17] conntrack: New userspace connection tracker.

h of pretty trivial comments below, but it seems otherwise fine to me. Thanks! Acked-by: Joe Stringer > --- > COPYING | 1 + > debian/copyright.in | 4 + > include/openvswitch/types.h | 4 + > lib/automake.mk | 5 + > lib/conntrac

[ovs-dev] [PATCH] debian: Fix upgrade from OVS-2.5 to newer OVS.

b', which is also in package openvswitch-switch 2.5.0-1 Fix the issue by adding "Replaces" and "Breaks" tags to the new openvswitch-common section of debian/control. Fixes: 0dcc739e7a28 ("debian: Move ovs-lib to openvswitch-common.") Signed-off-by: Joe Stringer -

Re: [ovs-dev] [PATCH] debian: Fix upgrade from OVS-2.5 to newer OVS.

On 17 June 2016 at 12:42, Joe Stringer wrote: > Commit 0dcc739e7a28 ("debian: Move ovs-lib to openvswitch-common.") > shifted a file between debian packages, but didn't update the > destination package annotations to indicate that it replaces a file > from earlier ver

Re: [ovs-dev] [PATCH v2 00/16] datapath: NAT backports

On 17 June 2016 at 18:20, Jarno Rajahalme wrote: > >> On Jun 17, 2016, at 10:47 AM, Jesse Gross > > wrote: >> >> On Tue, Jun 14, 2016 at 3:25 PM, Jarno Rajahalme > > wrote: >>> This series adds the conntrack NAT integration upstreamed in Linux 4.6 >>>

Re: [ovs-dev] [PATCH net-next] openvswitch: Only set mark and labels when commiting a connection.

On 20 June 2016 at 17:19, Jarno Rajahalme wrote: > Only allow setting conntrack mark or labels when the commit flag is > specified. This makes sure we can not set them before the connection > has been persisted, as in that case the mark and labels would be lost > in an event of an userspace upcal

Re: [ovs-dev] [PATCH net v2 1/2] openvswitch: Set mark and labels before confirming.

On 21 June 2016 at 14:59, Jarno Rajahalme wrote: > Set conntrack mark and labels right before committing so that > the initial conntrack NEW event has the mark and labels. > > Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer ___ dev

Re: [ovs-dev] [RFC PATCH net v2 2/2] openvswitch: Only set mark and labels with a commit flag.

On 21 June 2016 at 14:59, Jarno Rajahalme wrote: > Only set conntrack mark or labels when the commit flag is specified. > This makes sure we can not set them before the connection has been > persisted, as in that case the mark and labels would be lost in an > event of an userspace upcall. > > OVS

[ovs-dev] [PATCH 0/4] Fix IP refragmentation in upcall/execute path.

patch 4 ensures that the kernel module tests will now send ip fragments through the upcall/execute path as well as the regular path. Eric W. Biederman (2): datapath: Pass net into ovs_fragment. compat: ipv4: Pass struct net through ip_fragment. Joe Stringer (2): compat: Fix fragmentation issue

[ovs-dev] [PATCH 1/4] datapath: Pass net into ovs_fragment.

y: "Eric W. Biederman" Upstream: c559cd3ad32b ("openvswitch: Pass net into ovs_fragment") Signed-off-by: Joe Stringer --- datapath/actions.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/datapath/actions.c b/datapath/actions.c index 117bdae21b62..7f43

[ovs-dev] [PATCH 3/4] compat: Backport ip_do_fragment().

execute path. VMWare-BZ: #1651589 Fixes: 213e1f54b4b3 ("compat: Wrap IPv4 fragmentation.") Reported-by: Salman Malik Signed-off-by: Joe Stringer --- This patch is verified by running the kernel module test "conntrack - Fragmentation over vxlan". Unfortunately this test has p

[ovs-dev] [PATCH 4/4] system-traffic: Remove basic connectivity tests.

affic hits datapath flows and doesn't test the "execute" path (from userspace to kernel). This can hide some classes of bugs. The first few tests in system-traffic already check the basic sanity of the environment, so these redundant pieces are unnecessary. Remove them. Signed-off-by:

[ovs-dev] [PATCH 2/4] compat: ipv4: Pass struct net through ip_fragment.

From: "Eric W. Biederman" Upstream commit: ipv4: Pass struct net through ip_fragment Signed-off-by: "Eric W. Biederman" Upstream: 694869b3c544 ("ipv4: Pass struct net through ip_fragment") Signed-off-by: Joe Stringer --- acinclude.m4

Re: [ovs-dev] Getting error while configuring OVS 2.5.90(unstable release) with DPDK 16.4

On 23 June 2016 at 05:47, Thiyagu Subramanyam wrote: > Hi All, > > I am trying to use Openvswitch in user space using DPDK. So that i need > to install DPDK first in user space and then to configure OVS with DPDK > which i installed in user space. I am following the INSTALL DPDK.md > document,

[ovs-dev] [PATCH] ovs-bugtool: Port to python3.

) can be replaced with open(). Signed-off-by: Joe Stringer --- utilities/bugtool/ovs-bugtool.in | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/utilities/bugtool/ovs-bugtool.in b/utilities/bugtool/ovs-bugtool.in index cc18285f5759..9e85bc769302 100755 --- a/util

Re: [ovs-dev] [PATCH 2/4] compat: ipv4: Pass struct net through ip_fragment.

On 24 June 2016 at 14:00, Jesse Gross wrote: > On Wed, Jun 22, 2016 at 6:00 PM, Joe Stringer wrote: >> diff --git a/acinclude.m4 b/acinclude.m4 >> index 52d0209ab88a..8760948fcf9b 100644 >> --- a/acinclude.m4 >> +++ b/acinclude.m4 >> @@ -408,7 +408,8 @@

Re: [ovs-dev] [PATCH 3/4] compat: Backport ip_do_fragment().

On 24 June 2016 at 14:33, Jesse Gross wrote: > On Wed, Jun 22, 2016 at 6:00 PM, Joe Stringer wrote: >> diff --git a/datapath/linux/compat/include/net/ip.h >> b/datapath/linux/compat/include/net/ip.h >> index 29a4d43a1151..581e912cf2dd 100644 >> --- a/datapath/li

Re: [ovs-dev] [PATCH v4 05/17] conntrack: Periodically delete expired connections.

expired > connections, it can stop at the first non expired connection. > > Suggested-by: Joe Stringer > Signed-off-by: Daniele Di Proietto > --- > lib/conntrack-other.c | 11 +-- > lib/conntrack-private.h | 21 -- > lib/conntrack-tcp.c | 20 +++--- > li

Re: [ovs-dev] [PATCH v4 11/17] flow: Fill udp_len in flow_compose_l4().

On 10 June 2016 at 15:47, Daniele Di Proietto wrote: > It will be used by connection tracking tests. > > Signed-off-by: Daniele Di Proietto LGTM. A little surprised this isn't part of another patch, is there something particular you want to highlight with this patch?

Re: [ovs-dev] [PATCH v4 12/17] flow: Generate checksum in flow_compose().

On 10 June 2016 at 15:47, Daniele Di Proietto wrote: > This is useful to test the connection tracker, which performs checksum > verification. > > Signed-off-by: Daniele Di Proietto The comment above flow_compose() that says that checksums are missing might do with an update. A

Re: [ovs-dev] [PATCH v4 15/17] system-tests: Add ping through conntrack test.

On 10 June 2016 at 15:47, Daniele Di Proietto wrote: > Signed-off-by: Daniele Di Proietto Thanks, I didn't realise this basic test would actually be really helpful if there's something fundamentally going wrong in a setup. One minor comment below. Acked-by: Joe Stringer >

Re: [ovs-dev] [PATCH v4 16/17] conntrack: Track ICMP type and code.

ly reported the issue? Implementation looks fine to me. I assume the newly introduced tests validate at least the echo request/response paths. Acked-by: Joe Stringer ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v4 17/17] conntrack: Add 'dl_type' parameter to conntrack_execute().

reextract 'dl_type' from the packet, it can be passed as a parameter. > > This change means that we have to complicate sightly test-conntrack to > group the packets by dl_type before passing them to the connection > tracker. > > Signed-off-by: Daniele Di Proietto Min

Re: [ovs-dev] [PATCH v4 05/17] conntrack: Periodically delete expired connections.

On 24 June 2016 at 16:42, Daniele Di Proietto wrote: > Thanks for your comments Joe, replies inline > > > > On 24/06/2016 15:29, "Joe Stringer" wrote: > >>On 10 June 2016 at 15:47, Daniele Di Proietto wrote: >>> This commit adds a thread th

Re: [ovs-dev] [PATCH 0/4] Fix IP refragmentation in upcall/execute path.

On 24 June 2016 at 23:47, Jesse Gross wrote: > On Wed, Jun 22, 2016 at 6:00 PM, Joe Stringer wrote: >> When the backport of ip_do_fragment() was done, it seemed as though the >> upstream version of this function could always be trusted, provided we ensure >> that we ca

Re: [ovs-dev] [PATCH 0/4] Fix IP refragmentation in upcall/execute path.

On 27 June 2016 at 11:28, Joe Stringer wrote: > On 24 June 2016 at 23:47, Jesse Gross wrote: >> On Wed, Jun 22, 2016 at 6:00 PM, Joe Stringer wrote: >>> When the backport of ip_do_fragment() was done, it seemed as though the >>> upstream version of this funct

[ovs-dev] [PATCH] vagrant: Add 'nc' to installed programs.

netcat is used in several tests, but when creating a new vagrant VM we haven't been installing it. Do so. Signed-off-by: Joe Stringer --- Vagrantfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Vagrantfile b/Vagrantfile index 3557095a2c3a..e618f9c1a30c 100644

[ovs-dev] [PATCH] datapath: Drop debug code in handle_fragments().

This piece of debug code was introduced during the backport of conntrack, but is unnecessary and not upstream. Drop it to bring the code more inline with upstream. Reported-by: Jesse Gross Signed-off-by: Joe Stringer --- datapath/conntrack.c | 5 - 1 file changed, 5 deletions(-) diff

Re: [ovs-dev] [PATCH v2 00/16] datapath: NAT backports

On 18 June 2016 at 03:20, Jarno Rajahalme wrote: > >> On Jun 17, 2016, at 10:47 AM, Jesse Gross > > wrote: >> >> On Tue, Jun 14, 2016 at 3:25 PM, Jarno Rajahalme > > wrote: >>> This series adds the conntrack NAT integration upstreamed in Linux 4.6 >>>

Re: [ovs-dev] [PATCH net] openvswitch: fix conntrack netlink event delivery

netlink messages. > > This commit fixes the problem by calling nf_conntrack_confirm all the time, > i.e not only in the commit case. > > Fixes: 7f8a436eaa2c ("openvswitch: Add conntrack action") > CC: Joe Stringer > CC: Justin Pettit > CC: Andy Zhou > CC:

Re: [ovs-dev] [PATCH net v2] openvswitch: fix conntrack netlink event delivery

netlink messages. > > This commit fixes the problem by calling nf_ct_deliver_cached_events in the > non-commit case as well. > > Fixes: 7f8a436eaa2c ("openvswitch: Add conntrack action") > CC: Joe Stringer > CC: Justin Pettit > CC: Andy Zhou > CC: Thomas

Re: [ovs-dev] [PATCH] datapath: Drop debug code in handle_fragments().

On 28 June 2016 at 16:57, Jesse Gross wrote: > On Tue, Jun 28, 2016 at 2:17 AM, Joe Stringer wrote: >> This piece of debug code was introduced during the backport of >> conntrack, but is unnecessary and not upstream. Drop it to bring the >> code more inline with upstre

Re: [ovs-dev] [PATCH] vagrant: Add 'nc' to installed programs.

On 28 June 2016 at 20:41, Andy Zhou wrote: > > > On Tue, Jun 28, 2016 at 2:23 AM, Joe Stringer wrote: >> >> netcat is used in several tests, but when creating a new vagrant VM we >> haven't been installing it. Do so. >> >> Signed-off-by: Joe Stringer

Re: [ovs-dev] [PATCH 1/2] datapath: Set mark and labels before confirming.

onntrack mark and labels right before committing so that > the initial conntrack NEW event has the mark and labels. > > Signed-off-by: Jarno Rajahalme > Acked-by: Joe Stringer > Signed-off-by: David S. Miller > > Signed-off-by: Jarno Rajahalme Looks like a str

Re: [ovs-dev] [PATCH 2/2] datapath: Only set mark and labels with a commit flag.

uires the commit flag to accept setting > ct_mark and/or ct_labels. Validate for this in the kernel API. > > Signed-off-by: Jarno Rajahalme > Signed-off-by: David S. Miller > > Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer

Re: [ovs-dev] [PATCH v2 00/24] datapath: compat: Add support for IPv6 Geneve and VxLAN tunnels.

On 30 June 2016 at 10:06, Pravin B Shelar wrote: > This patch series update OVS compat layer to handle IPv6 UDP based > tunnels. While doing this various fixes and updates to tunnel code > are also brought in. This series sync OVS tunnel compat codebase upto > latest net branch (commit 9a0fee2b552

Re: [ovs-dev] [PATCH] system-traffic: Remove datapath specific tests and macro.

Yes, I plan to take a look. On 2 July 2016 at 06:10, Ben Pfaff wrote: > Joe, are you the right person to review this? > > On Fri, Jul 01, 2016 at 09:45:52AM -0700, William Tu wrote: >> We generally try to keep the testsuite independent of the underlying >> datapath. This patch removes the datapat

Re: [ovs-dev] Stateful Conntrack & NAT Requirements

On 8 July 2016 at 14:07, Guru Shetty wrote: > On 8 July 2016 at 13:46, Arvinderpal Wander wrote: > >> Hi guys, >> >> I wanted to get started with the new CT and NAT functionality. I followed >> the following discussion that was posted earlier: >> >> http://openvswitch.org/pipermail/dev/2016-May/0

[ovs-dev] [PATCH] system-traffic: Use NC_EOF_OPT in truncate tests.

netcat that do not do this (for example, those used by Debian and Ubuntu by default). For these alternative implementations, we provide $NC_EOF_OPT to ensure that netcat simply sends the packet then returns immediately. Signed-off-by: Joe Stringer --- tests/system-traffic.at | 14 +++--- 1

Re: [ovs-dev] [PATCH] system-traffic: Use NC_EOF_OPT in truncate tests.

; >> >> >> >> On Mon, Jul 11, 2016 at 11:28 AM, Guru Shetty wrote: >> >> >> >>> On 11 July 2016 at 10:29, Joe Stringer wrote: >> >>> >> >>> > NC_EOF_OPT should always be passed to netcat in system-traffic tests >

Re: [ovs-dev] [OVN] Applying ACL changes to existing connections

On 19 February 2016 at 06:53, Russell Bryant wrote: > On 02/18/2016 07:37 PM, Joe Stringer wrote: >> On 17 February 2016 at 18:12, Justin Pettit wrote: >>> >>>> On Feb 5, 2016, at 1:30 PM, Russell Bryant wrote: >>>> >>>> >>>> Th

Re: [ovs-dev] [OVN] Applying ACL changes to existing connections

On 22 February 2016 at 17:32, Russell Bryant wrote: > > > On Mon, Feb 22, 2016 at 7:25 PM, Joe Stringer wrote: >> >> On 19 February 2016 at 06:53, Russell Bryant wrote: >> > On 02/18/2016 07:37 PM, Joe Stringer wrote: >> >> On 17 February 2016 at 18:1

[ovs-dev] [PATCH] ovs-ofctl.8: Clarify conntrack documentation.

Signed-off-by: Joe Stringer --- utilities/ovs-ofctl.8.in | 41 - 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in index 981e60acec92..1b280efde6bd 100644 --- a/utilities/ovs-ofctl.8.in

Re: [ovs-dev] [PATCH] ovs-ofctl.8: Clarify conntrack documentation.

On 23 February 2016 at 13:31, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme Thanks, applied to master and branch-2.5. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/2] datapath: Remove OVS_FRAGMENT_BACKPORT

On 19 February 2016 at 16:03, Pravin B Shelar wrote: > @@ -119,25 +119,9 @@ static inline int rpl_ip_do_fragment(struct sock *sk, > struct sk_buff *skb, > int rpl_ip_defrag(struct sk_buff *skb, u32 user); > #define ip_defrag rpl_ip_defrag > > +#endif /* HAVE_CORRECT_MRU_HANDLING */ > int __ini

Re: [ovs-dev] [PATCH 1/2] datapath: Drop support for kernel older than 3.10

On 23 February 2016 at 17:06, Jesse Gross wrote: > On Fri, Feb 19, 2016 at 4:03 PM, Pravin B Shelar wrote: >> Currently OVS out of tree datapath supports a large number of kernel >> versions. From 2.6.32 to 4.3 and various distribution-specific >> kernels. But at this point major features are onl

Re: [ovs-dev] [PATCH 1/2] ovsdb: fix a typo in ovs-vswitchd.conf.db(5).

On 24 February 2016 at 13:27, Andy Zhou wrote: > Signed-off-by: Andy Zhou Acked-by: Joe Stringer ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] system-traffic.at: skip tests if veth not supported.

On 25 February 2016 at 06:15, Ilya Maximets wrote: > This prevents failure of test scenarios 'make check-kernel' > and 'make check-system-userspace' if creation of veth pairs is not > supported by kernel (or module isn't loaded). > > Signed-off-by: Ilya Maximets All of the tests require support

Re: [ovs-dev] [PATCH] dpif-netdev: Fix double inclusion of cmap.h

On 24 February 2016 at 23:51, Ilya Maximets wrote: > Also, all headers sorted lexicographically. > > Fixes: 9f361d6b29fb ("dpif-netdev: Use cmap instead of hmap.") > Signed-off-by: Ilya Maximets Typically the "Fixes:" tag is used for bugs, to help us determine which releases have the problem so

Re: [ovs-dev] [PATCH] dpif-netdev: Fix double inclusion of cmap.h

On 25 February 2016 at 21:35, Ilya Maximets wrote: > On 26.02.2016 03:11, Joe Stringer wrote: >> On 24 February 2016 at 23:51, Ilya Maximets wrote: >>> Also, all headers sorted lexicographically. >>> >>> Fixes: 9f361d6b29fb ("dpif-netdev: Use cmap i

Re: [ovs-dev] [PATCH 3/3] testsuite: Add delay after ovs-vswitchd killing.

On 26 February 2016 at 03:57, Ilya Maximets wrote: > Fixes failure of test due to not yet fully destroyed ports from > previous test if ovs-vswitchd was killed. > > Example: > > netdev_linux|WARN|br0: creating tap device failed: Device or resource busy > bridge|WARN|could not open network device b

Re: [ovs-dev] [PATCH 2/2] Prepare for 2.5.1.

On 24 February 2016 at 04:29, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- > NEWS | 4 > configure.ac | 2 +- > debian/changelog | 7 +++ > 3 files changed, 12 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS > index d3757d7..54483a8 100644 > --- a/

[ovs-dev] [PATCH 3/4] ofp-actions: Prevent integer overflow in decode.

When decoding a variable-length action, if the length of the action exceeds the length storable in a uint16_t then something has gone terribly wrong. Assert that this is not the case. Signed-off-by: Joe Stringer --- lib/ofp-actions.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion

[ovs-dev] [PATCH 4/4] ofpbuf: Use ptrdiff_t for pointer delta.

Signed-off-by: Joe Stringer --- lib/ofpbuf.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/ofpbuf.c b/lib/ofpbuf.c index a3c4da4bcbbe..02c9d15f82bf 100644 --- a/lib/ofpbuf.c +++ b/lib/ofpbuf.c @@ -183,8 +183,7 @@ ofpbuf_clone_with_headroom(const struct ofpbuf

[ovs-dev] [PATCH 2/4] ofp-actions: Fix use-after-free in bundle action.

715 Fixes: f25d0cf3c366 ("Introduce ofpacts, an abstraction of OpenFlow actions.") Signed-off-by: Joe Stringer --- lib/ofp-actions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index ae961f6cc5bb..fe1424f137a1 100644 --- a/lib/ofp-

[ovs-dev] [PATCH 1/4] tests: Add bundle action test with buffer realloc.

F0711: ofp_to_string__ (ofp-print.c:3220) by 0x4F0D98: ofp_to_string (ofp-print.c:3453) by 0x5486B3: do_recv (vconn.c:644) by 0x548498: vconn_recv (vconn.c:598) by 0x524582: rconn_recv (rconn.c:703) by 0x45DA61: ofconn_run (connmgr.c:1370) Signed-off-by: Joe Stringer --- tests/bundle.a

Re: [ovs-dev] [PATCH 2/3] ovn: Add ct_commit(ct_mark=INTEGER); action.

On 3 March 2016 at 05:40, Russell Bryant wrote: > On Wed, Mar 2, 2016 at 8:31 PM, Han Zhou wrote: > >> >> >> On Wed, Mar 2, 2016 at 1:43 PM, Russell Bryant wrote: >> > >> > Update the "ct_commit;" logical flow action to optionally take a >> > parameter, setting the value of "ct_mark" to a 32-bit

Re: [ovs-dev] [PATCH 2/4] ofp-actions: Fix use-after-free in bundle action.

On 3 March 2016 at 00:22, Joe Stringer wrote: > If the actions list in an incoming flow mod is long enough, and there is > a bundle() action with 3 or more slaves, then it is possible for a > reallocation to occur after placing the ofpact_bundle into the ofpacts > buffer, while appe

Re: [ovs-dev] [PATCH 1/4] tests: Add bundle action test with buffer realloc.

On 3 March 2016 at 00:22, Joe Stringer wrote: > Add a test which causes internal reallocation of the ofpacts buffer, > followed by a large bundle action which should cause a subsequent > reallocation while decoding slave ports. Running this test under > valgrind reveals the issue bel

Re: [ovs-dev] [PATCH 3/4] ofp-actions: Prevent integer overflow in decode.

On 3 March 2016 at 00:22, Joe Stringer wrote: > When decoding a variable-length action, if the length of the action > exceeds the length storable in a uint16_t then something has gone > terribly wrong. Assert that this is not the case. > > Signed-off-by: Joe Stringer With Jarno&#

Re: [ovs-dev] [PATCH 4/4] ofpbuf: Use ptrdiff_t for pointer delta.

On 3 March 2016 at 13:27, Jarno Rajahalme wrote: > For the series: > > Acked-by: Jarno Rajahalme > > While looking at lib/ofpbuf.c, I noticed a bug for which I’ll send a separate > patch. > > Jarno Thanks, I applied the series to master. ___ dev mai

Re: [ovs-dev] [PATCH] ofpbuf: Fix use-after-free in bundle parse.

On 4 March 2016 at 18:00, William Tu wrote: > Address pointed by bundle could be obsolete/free'd when > realloc, called from ofpbuf_put_zero(), returns new address. > Reported by Valgrind 367: ovs-ofctl parse-flows (NXM) > > Invalid write of size 4 > bundle_parse__ (bundle.c:200) > bundle_

Re: [ovs-dev] [PATCH 2/2] ofpbuf: Fix setting of 'msg' in ofpbuf_clone_with_headroom()

irely straightforward to see, but I think that if the ptrdiff_t is unsigned and the new buffer is actually allocated earlier in memory than the old buffer, then the offset is really wrong. This change should stand alone from cosmetic fixes. That said, I completely agree with those chan

Re: [ovs-dev] [PATCH 2/4] ofp-actions: Fix use-after-free in bundle action.

On 5 March 2016 at 09:13, William Tu wrote: > Hi Joe, > > On Thu, Mar 3, 2016 at 12:22 AM, Joe Stringer wrote: >> >> If the actions list in an incoming flow mod is long enough, and there is >> a bundle() action with 3 or more slaves, then it is possible for a >>

Re: [ovs-dev] [PATCH] ofpbuf: Fix use-after-free in bundle parse.

nto ofpbuf_put_zero, which frees the memory pointed by > bundle. > > Regards, > William > > On Fri, Mar 4, 2016 at 6:12 PM, Joe Stringer wrote: >> >> On 4 March 2016 at 18:00, William Tu wrote: >> > Address pointed by bundle could be obsolete/free'd when

Re: [ovs-dev] [CudaMailTagged] [PATCH] ofp-util: Fix use-after-free in group append.

On 4 March 2016 at 15:18, William Tu wrote: > It is possible for ofpbuf_put() to realloc a newly allocated address, > casuing the previously referenced pointer, ogds, points to old/free'd > address. The issue is generated by forcing ofpbuf_put() to use newly > allocated buffer and valgrind reports

[ovs-dev] [PATCH] nx-match: Fix use-after-free parsing matches.

pbuf.c:414) nx_match_from_string_raw (nx-match.c:1488) nx_match_from_string (nx-match.c:1538) ofctl_parse_nxm__ (ovs-ofctl.c:3325) Reported-by: William Tu Signed-off-by: Joe Stringer --- lib/nx-match.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/nx-mat

Re: [ovs-dev] [PATCH] nx-match: Fix use-after-free.

On 4 March 2016 at 17:35, William Tu wrote: > Address pointed by header_ptr might be free'd due to realloc > happened at ofpbuf_put_uninit() and ofpbuf_put_hex(). Reported > by valgrind 379: check TCP flags expression in OXM and NXM. > > Invalid write of size 4 > nx_match_from_string_raw (nx-m

Re: [ovs-dev] [PATCH 1/4] tests: Add bundle action test with buffer realloc.

On 5 March 2016 at 11:26, Ben Pfaff wrote: > On Thu, Mar 03, 2016 at 09:22:48PM +1300, Joe Stringer wrote: >> Add a test which causes internal reallocation of the ofpacts buffer, >> followed by a large bundle action which should cause a subsequent >> reallocation while

<    1   2   3   4   5   6   7   8   9   10   >