On 30 June 2016 at 10:06, Pravin B Shelar <pshe...@ovn.org> wrote:
> This patch series update OVS compat layer to handle IPv6 UDP based
> tunnels. While doing this various fixes and updates to tunnel code
> are also brought in. This series sync OVS tunnel compat codebase upto
> latest net branch (commit 9a0fee2b552b1235fb1706ae1fc664ae74573be8).
>
> v1-v2:
> Broken down patched to better align the patches with upstream commit.
> There is still patch 14 which has code from multiple commits.
> I can break it down further if it help in review process.

I did a brief look across this and ran the kernel module testsuite
using "vagrant up", which found that the iptunnel backports are not
consistently applied. On kernel-4.2 that comes with the current
vagrant box, when loading the module, I see:

[ 1547.247471] openvswitch: Unknown symbol ovs_iptunnel_handle_offloads (err 0)
[ 1547.247839] openvswitch: Unknown symbol rpl_iptunnel_xmit (err 0)

It looks like the datapath/linux/compat/ip_tunnels_core.c checks are
still using version 3.18, but the corresponding headers are redefining
the functions for all pre-4.7 kernels. I also noticed that the
iptunnel_xmit() changes that you made in kernel-4.5 timeframe around
stats are not in the backport. Perhaps this is because you intended to
use the upstream version for these kernels?
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to