, which is
raised when flow setup is complete. By checking this flag before
attempting to perform a trylock(), we can reduce lock contention between
handler and revalidator threads.
Signed-off-by: Joe Stringer
---
v5: No change.
v4: Use atomic_read_relaxed().
v2-v3: No change.
---
ofproto/of
en we have generated the same UID hash for two different
flows, and we should log a warning.
Signed-off-by: Joe Stringer
---
v5: Compare flow keys rather than hashes of flow keys.
v4: Initial post.
---
ofproto/ofproto-dpif-upcall.c | 38 --
1 file change
We previously counted flows that have been installed during the current
dump as duplicates, rather than recognising them as new flows. This
patch separates the counters out for these two cases.
Signed-off-by: Joe Stringer
---
v5: No change.
v4: Initial post.
---
ofproto/ofproto-dpif-upcall.c
Thanks for the fix, I pushed this to master.
On 13 September 2014 05:35, Daniele Di Proietto
wrote:
> --enable-dummy was useless anyway for ovsdb-server. Now it is an error to
> pass
> it.
>
> Signed-off-by: Daniele Di Proietto
> ---
> utilities/ovs-dev.py | 4 ++--
> 1 file changed, 2 inserti
Although I reviewed and applied #1, I'll leave this one up to Ethan as it's
more relevant to his other proposed changes.
On 13 September 2014 05:35, Daniele Di Proietto
wrote:
> If 'configure' with clang fails (this can happen for example if it doesn't
> support all the cflags), simply skip it
>
Bump. Any chance of some feedback?
On 15 September 2014 14:25, Joe Stringer wrote:
> Patches #1-4 have been reviewed and Ack'd by Ben, which I have held out
> from
> pushing upstream as they are only useful with the rest of the series. The
> remaining patches are yet to be r
k support.")
Fixes: 9daf23484fb1 ("Add connection tracking label support.")
Signed-off-by: Joe Stringer
---
lib/util.h | 11 +++
ofproto/ofproto-dpif-xlate.c | 27 ---
tests/system-traffic.at | 38 ++
Make the ct_mark netlink serialization more consistent with the way that
ct_label is serialized.
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-xlate.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto
On 14 April 2016 at 10:08, Ben Pfaff wrote:
> On Mon, Apr 04, 2016 at 02:56:03PM -0700, Joe Stringer wrote:
>> Previously, whenever a set_field() action was executed, the entire field
>> would become masked and the entire field replaced, regardless of the
>> mask speci
On 14 April 2016 at 10:09, Ben Pfaff wrote:
> On Mon, Apr 04, 2016 at 02:56:04PM -0700, Joe Stringer wrote:
>> These have been supported all along, but the documentation neglected to
>> mention the fact.
>>
>> Signed-off-by: Joe Stringer
>
> Acked-by: Ben Pfaf
reeBSD.
>
> These definitions will be used by a future commit.
>
> Signed-off-by: Daniele Di Proietto
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
}
> +}
> +}
> +
> +bool
> +parse_ipv6_ext_hdrs(const void **datap, size_t *sizep, uint8_t *nw_proto,
> +uint8_t *nw_frag)
> +{
> +return parse_ipv6_ext_hdrs__(datap, sizep, nw_proto, nw_frag);
> +}
> +
I couldn't tell any difference between parse_ipv6_ext_hdrs() and
parse_ipv6_ext_hdrs__(); are they both necessary?
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 15 April 2016 at 17:02, Daniele Di Proietto wrote:
> The function simply returns the ethernet type of the packet (after
> eventually discarding the VLAN tag). It will be used by a following
> commit.
>
> Signed-off-by: Daniele Di Proietto
> ---
> lib/flow.c | 14 --
> lib/flow.h
On 15 April 2016 at 17:02, Daniele Di Proietto wrote:
> This commit adds the conntrack module.
>
> It is a connection tracker that resides entirely in userspace. Its
> primary user will be the dpif-netdev datapath.
>
> The module main goal is to provide conntrack_execute(), which offers a
> conve
On 15 April 2016 at 17:02, Daniele Di Proietto wrote:
> Signed-off-by: Daniele Di Proietto
Looks like this can be combined with patch #11 (to plumb it up through appctl).
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
h
On 15 April 2016 at 17:02, Daniele Di Proietto wrote:
> Signed-off-by: Daniele Di Proietto
> +static void
> +conn_key_to_tuple(const struct conn_key *key, struct ct_dpif_tuple *tuple)
> +{
> +if (key->dl_type == htons(ETH_TYPE_IP)) {
> +tuple->l3_type = AF_INET;
> +} else if (k
On 15 April 2016 at 17:02, Daniele Di Proietto wrote:
> This commit implements the OVS_ACTION_ATTR_CT action in dpif-netdev.
>
> To allow ofproto-dpif to detect the conntrack feature, flow_put will not
> discard anymore flows with ct_* fields set. We still shouldn't allow
> flows with NAT bits set
On 15 April 2016 at 17:02, Daniele Di Proietto wrote:
> Signed-off-by: Daniele Di Proietto
Could be combined with the earlier patch that provides the actual
implementation?
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinf
this simply fixes the userspace
testsuite when running on newer kernels today, so we could apply this
independently of the rest of the series.
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
to the more complex configurations in the existing tests. This
is a step in the right direction.
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
datapath, so it seems fine to skip the conntrack-related ones. I
wouldn't mind seeing a basic sanity test that sends packets between
the local stack and another namespace, though - which would run for
both testsuites, and both with IPv4 and IPv6 traffic.
A few comments on the comments
On 19 April 2016 at 16:53, Joe Stringer wrote:
> On 15 April 2016 at 17:02, Daniele Di Proietto wrote:
>> The userspace connection tracker doesn't support ALGs, frag reassembly
>> or NAT yet, so skip those tests.
>>
>> Also, connection tracking state input from a
Signed-off-by: Joe Stringer
---
tests/system-common-macros.at | 4
tests/system-traffic.at | 41 +
2 files changed, 45 insertions(+)
diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at
index 92569f9c4fcf..1b9b5c1e9f15
Signed-off-by: Joe Stringer
---
tests/system-common-macros.at | 4
tests/system-traffic.at | 41 +
2 files changed, 45 insertions(+)
diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at
index 1b9b5c1e9f15..2116f1e31357
On 20 April 2016 at 16:07, Joe Stringer wrote:
> Signed-off-by: Joe Stringer
> ---
> +dnl Set up tunnel endpoints on OVS outside the namespace and with a native
> +dnl linux device inside the namespace.
> +ADD_OVS_TUNNEL([gre], [br0], [at_gre0], [172.31.1.1],
ested using kmod tests on Ubuntu 3.13.0-24, 4.2.0-35, and RHEL 3.10.0-327
kernels, plus build tests for vanilla kernels on Travis:
https://travis-ci.org/joestringer/openvswitch/builds/124819321
Joe Stringer (5):
compat: ipv6: Pass struct net into nf_ct_frag6_gather.
compat: nf_defrag_ipv6: avoid
ree clone
operations")
Reported-by: Valdis Kletnieks
Tested-by: Valdis Kletnieks
Signed-off-by: Florian Westphal
Signed-off-by: Pablo Neira Ayuso
Upstream: e97ac12859db ("netfilter: ipv6: nf_defrag: fix NULL deref panic")
Signed-off-by: Joe Stringer
---
datapa
: 029f7f3b8701 ("netfilter: ipv6: nf_defrag: avoid/free clone
operations")
Reported-by: Daniele Di Proietto
Signed-off-by: Joe Stringer
Signed-off-by: David S. Miller
Upstream: f0cbf9f67273 ("openvswitch: Orphan skbs before IPv6 defrag")
Signed-off-by: Joe Stringer
Signed-off-by: Pablo Neira Ayuso
Upstream: daaa7d647f81 ("netfilter: ipv6: avoid nf_iterate recursion")
Signed-off-by: Joe Stringer
---
datapath/conntrack.c | 11 ++--
.../include/net/netfilter/ipv6/nf_defrag_ipv6.h| 3 +-
datapath/linux/compat/nf_conntra
penvswitch doesn't need any additional skb_morph magic anymore to deal
with this situation so just remove that.
A followup patch can then also remove the NF_HOOK (re)invocation in
the ipv6 netfilter defrag hook.
Cc: Joe Stringer
Signed-off-by: Florian Westphal
Signe
eira Ayuso
Signed-off-by: David S. Miller
Upstream: b72775977c39 ("ipv6: Pass struct net into nf_ct_frag6_gather")
Signed-off-by: Joe Stringer
---
datapath/conntrack.c | 2 +-
datapath/linux/compat/include/net/netfilter/ipv6/nf_defrag_ipv6.h | 3
This was missed before somehow, which would cause the test to fail
(rather than being skipped) if iproute2 didn't support setting the
vxlan dstport on the kernel tunnel device.
Signed-off-by: Joe Stringer
---
tests/system-traffic.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On 21 April 2016 at 17:10, Daniele Di Proietto wrote:
> Acked-by: Daniele Di Proietto
>
>
> On 21/04/2016 13:29, "Joe Stringer" wrote:
>
>>On 20 April 2016 at 16:07, Joe Stringer wrote:
>>> Signed-off-by: Joe Stringer
>>> ---
>>
>>
On 21 April 2016 at 17:07, Daniele Di Proietto wrote:
> Thanks for fixing this
>
> Acked-by: Daniele Di Proietto
Thanks, applied to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 22 April 2016 at 08:37, Ben Pfaff wrote:
> On Fri, Apr 15, 2016 at 11:36:04AM -0700, Joe Stringer wrote:
>> When translating multiple ct actions in a row which include modification
>> of ct_mark or ct_labels, these fields could be incorrectly translated
>> into datapath
On 21 April 2016 at 17:11, Daniele Di Proietto wrote:
> Thanks for adding this tests!
>
> Acked-by: Daniele Di Proietto
Thanks for the review! Applied to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 22 April 2016 at 08:40, Ben Pfaff wrote:
> On Fri, Apr 15, 2016 at 11:36:05AM -0700, Joe Stringer wrote:
>> Make the ct_mark netlink serialization more consistent with the way that
>> ct_label is serialized.
>>
>> Signed-off-by: Joe Stringer
>
> This is nice,
:120)
Signed-off-by: Joe Stringer
---
lib/ofp-actions.c | 1 +
tests/ofproto-dpif.at | 10 ++
2 files changed, 11 insertions(+)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index 39b6fbca531e..10ef3ea808fd 100644
--- a/lib/ofp-actions.c
+++ b/lib/ofp-actions.c
@@ -4
Signed-off-by: Joe Stringer
---
FAQ.md | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/FAQ.md b/FAQ.md
index 28680d69bd3a..0df6d072e177 100644
--- a/FAQ.md
+++ b/FAQ.md
@@ -204,6 +204,7 @@ Tunnel - Geneve | 3.18 | YES |
YES| NO
Linux kernel support for features in out-of-tree module no longer depend
on particular versions, as we only support kernels 3.10-4.3; Connection
tracking status has changed recently; and NAT is a brand new feature
with only support in the latest unreleased Linux kernel version.
Signed-off-by: Joe
On 26 April 2016 at 19:51, Jesse Gross wrote:
> On Thu, Apr 21, 2016 at 2:07 PM, Joe Stringer wrote:
>> This short series addresses some of the netfilter/defrag-related changes
>> recently upstream and backports the equivalent fixes to our compat code.
>> The last two
On 26 April 2016 at 19:44, Jesse Gross wrote:
> On Thu, Apr 21, 2016 at 2:07 PM, Joe Stringer wrote:
>> diff --git
>> a/datapath/linux/compat/include/net/netfilter/ipv6/nf_defrag_ipv6.h
>> b/datapath/linux/compat/include/net/netfilter/ipv6/nf_defrag_ipv6.h
>> index
On 26 April 2016 at 18:45, Jesse Gross wrote:
> On Thu, Apr 21, 2016 at 2:07 PM, Joe Stringer wrote:
>> Upstream commit:
>> openvswitch: Orphan skbs before IPv6 defrag
>>
>> This is the IPv6 counterpart to commit 8282f27449bf ("inet: frag: Always
>
On 28 April 2016 at 17:17, Joe Stringer wrote:
> On 26 April 2016 at 19:44, Jesse Gross wrote:
>> On Thu, Apr 21, 2016 at 2:07 PM, Joe Stringer wrote:
>>> diff --git
>>> a/datapath/linux/compat/include/net/netfilter/ipv6/nf_defrag_ipv6.h
>>> b/datapath/lin
Since commit f2ab1536ddbc ("compat: Backport conntrack strictly to
v3.10+."), we haven't supported these kernel versions. Remove the old
code.
Signed-off-by: Joe Stringer
---
datapath/linux/compat/skbuff-openvswitch.c | 6 --
1 file changed, 6 deletions(-)
diff --git a
On 28 April 2016 at 18:29, Ansis Atteka wrote:
> On 28 April 2016 at 14:13, Joe Stringer wrote:
>> When decoding the 'note' action, variable-length data could be pushed to
>> a buffer immediately prior to calling ofpact_finish_NOTE(). The
>> ofpbuf_put() could ca
On 2 May 2016 at 09:04, Darrell Ball wrote:
> On Mon, May 2, 2016 at 8:39 AM, William Tu wrote:
>
>> Hi Darrel,
>>
>> # Delete namespaces from the running OS
m4_define([DEL_NAMESPACES],
[m4_foreach([ns], [$@],
- [ip netns del ns
-])
+ [if
tuple
implementations to ensure gre (and any similar protocols) can get this
right.
Signed-off-by: "Eric W. Biederman"
Signed-off-by: Pablo Neira Ayuso
Upstream: a31f1adc0948 ("netfilter: nf_conntrack: Add a struct net
parameter to l4_pkt_to_tuple")
Signed-off-by: Joe
upstream prior
to the NAT series.
- Added a final patch to document the defrag backport strategy in v4 and v6.
- Fixed upstream commit references to use the correct IDs.
v1:
- Initial Post
Joe Stringer (9):
compat: Add a struct net parameter to l4_pkt_to_tuple.
compat: ipv4: Pass struct net into
penvswitch doesn't need any additional skb_morph magic anymore to deal
with this situation so just remove that.
A followup patch can then also remove the NF_HOOK (re)invocation in
the ipv6 netfilter defrag hook.
Cc: Joe Stringer
Signed-off-by: Florian Westphal
Signe
o ip_defrag and
ip_check_defrag")
Signed-off-by: Joe Stringer
---
v2: Initial Post.
---
acinclude.m4 | 2 ++
datapath/conntrack.c | 2 +-
datapath/linux/compat/include/net/ip.h | 8 ++--
datapath/linux/compat/ip_fragment.c| 3 +--
4 files ch
: 029f7f3b8701 ("netfilter: ipv6: nf_defrag: avoid/free clone
operations")
Reported-by: Daniele Di Proietto
Signed-off-by: Joe Stringer
Signed-off-by: David S. Miller
Upstream: 49e261a8a21e ("openvswitch: Orphan skbs before IPv6 defrag")
Signed-off-by: Joe Stringer
eira Ayuso
Signed-off-by: David S. Miller
Upstream: b72775977c39 ("ipv6: Pass struct net into nf_ct_frag6_gather")
Signed-off-by: Joe Stringer
---
v2: No changes.
v1: Initial Post.
---
datapath/conntrack.c | 2 +-
datapath/linux/compat/includ
ree clone
operations")
Reported-by: Valdis Kletnieks
Tested-by: Valdis Kletnieks
Signed-off-by: Florian Westphal
Signed-off-by: Pablo Neira Ayuso
Upstream: e97ac12859db ("netfilter: ipv6: nf_defrag: fix NULL deref panic")
Signed-off-by: Joe Stringer
Signed-off-by: Pablo Neira Ayuso
Upstream: daaa7d647f81 ("netfilter: ipv6: avoid nf_iterate recursion")
Signed-off-by: Joe Stringer
---
v2: No changes.
v1: Initial Post.
---
datapath/conntrack.c | 11 ++--
.../include/net/netfilter/ipv6/nf_defrag_ipv6
Document how the IP(6) defrag backport works, and do minor style cleanups.
Signed-off-by: Joe Stringer
---
v2: Initial Post.
---
datapath/linux/compat/include/net/ip.h| 7 +++
.../linux/compat/include/net/netfilter/ipv6/nf_defrag_ipv6.h | 11 +--
2 files
taching helpers to ct action")
Fixes: 2f3ab9f9fc23 ("openvswitch: Fix helper reference leak")
Signed-off-by: Joe Stringer
Signed-off-by: David S. Miller
Upstream: 90c7afc96cbb ("openvswitch: Fix template leak in error cases.")
Fixes: 11251c170d92 ("datapath: A
On 2 May 2016 at 00:28, Simon Horman wrote:
> On Thu, Apr 28, 2016 at 06:09:04PM -0700, Joe Stringer wrote:
>> Since commit f2ab1536ddbc ("compat: Backport conntrack strictly to
>> v3.10+."), we haven't supported these kernel versions. Remove the old
>> cod
On 2 May 2016 at 11:29, Ryan Moats wrote:
> "dev" wrote on 04/28/2016 04:39:09 PM:
>
>> From: Joe Stringer
>> To: dev@openvswitch.org
>> Date: 04/28/2016 04:39 PM
>> Subject: [ovs-dev] [PATCH 2/2] FAQ: Update feature table.
>> Sent by: "dev&
On 2 May 2016 at 11:29, Ryan Moats wrote:
> "dev" wrote on 04/28/2016 04:39:08 PM:
>
>> From: Joe Stringer
>> To: dev@openvswitch.org
>> Date: 04/28/2016 04:39 PM
>> Subject: [ovs-dev] [PATCH 1/2] FAQ: Shift IPFIX into the feature
>> support tabl
On 2 May 2016 at 13:05, Jesse Gross wrote:
> On Mon, May 2, 2016 at 11:19 AM, Joe Stringer wrote:
>> This series backports the netfilter/defrag-related changes made recently
>> upstream to our compat code, which should bring conntrack.c up-to-date just
>> prior to the
On 2 May 2016 at 16:57, Darrell Ball wrote:
>
>
> On Mon, May 2, 2016 at 11:12 AM, Joe Stringer wrote:
>>
>> On 2 May 2016 at 09:04, Darrell Ball wrote:
>> > On Mon, May 2, 2016 at 8:39 AM, William Tu wrote:
>> >
>> >> Hi Darrel,
&
These have existed largely since v2.6.22, so it's well overdue.
Signed-off-by: Joe Stringer
---
acinclude.m4 | 4 --
datapath/linux/Modules.mk| 7 ---
datapath/linux/compat/include/linux/icmp.h | 13 --
datapath/linux/compat/in
These pieces #if on kernel versions which are not supported since commit
f2ab1536ddbc ("compat: Backport conntrack strictly to v3.10+.")
Signed-off-by: Joe Stringer
---
acinclude.m4 | 1 -
datapath/linux/compat/includ
On 3 May 2016 at 03:54, Pablo Neira Ayuso wrote:
> If the protocol is not natively supported, this assigns generic protocol
> tracker so we can always assume a valid pointer after these calls.
>
> Signed-off-by: Pablo Neira Ayuso
Thanks for the cleanup.
Acked-by:
The make check-kmod target would previously attempt to only remove the
openvswitch module, which would fail if any vport modules were loaded.
Remove those modules too, to allow the target to proceed.
Signed-off-by: Joe Stringer
---
tests/automake.mk | 2 +-
1 file changed, 1 insertion(+), 1
On 2 May 2016 at 18:22, Jesse Gross wrote:
> On Mon, May 2, 2016 at 5:47 PM, Joe Stringer wrote:
>> These pieces #if on kernel versions which are not supported since commit
>> f2ab1536ddbc ("compat: Backport conntrack strictly to v3.10+.")
>>
>> Signed-off-
On 2 May 2016 at 18:23, Jesse Gross wrote:
> On Mon, May 2, 2016 at 5:47 PM, Joe Stringer wrote:
>> These have existed largely since v2.6.22, so it's well overdue.
>>
>> Signed-off-by: Joe Stringer
>
> Acked-by: Jesse Gross
Thanks, applied.
___
On 4 May 2016 at 11:29, Andy Zhou wrote:
>
>
> On Tue, May 3, 2016 at 3:44 PM, Joe Stringer wrote:
>>
>> The make check-kmod target would previously attempt to only remove the
>> openvswitch module, which would fail if any vport modules were loaded.
>> Remov
by
using the OVS_WAIT_UNTIL() macros to ensure connectivity is established before
attempting to perform testing.
Joe Stringer (4):
system-traffic: Drop auto ct helpers in namespaces.
system-traffic: Update tests in flat tables.
system-traffic: Wait for IPv6 connectivity.
system-traffic
waiting until IPv6 or FTP
connectivity are ready. This speeds the testsuite up by a couple of
percent.
Signed-off-by: Joe Stringer
---
tests/system-traffic.at | 50 +
1 file changed, 34 insertions(+), 16 deletions(-)
diff --git a/tests/system
A few of the earlier tests were written with all flows in a single flat
table. While this is a possible way to write your flows to use
connection tracking, it's easier to understand if the processing
proceeds forward from one table to the next. Update these tests.
Signed-off-by: Joe Str
Automatic helper assignment in conntrack can trigger an upstream bug
where namespace deletion followed by immediate unload of conntrack
helper modules may cause kernel crashes. Disable automatic helper
assignment within created namespaces to avoid this issue.
Signed-off-by: Joe Stringer
Some FTP tests had intermittent failures because the FTP daemons
might not load before the testsuite script iterated to running the
client. Add checks after launching FTP daemons to make these tests more
resilient.
Signed-off-by: Joe Stringer
---
tests/system-traffic.at | 5 +
1 file
On 6 May 2016 at 05:22, Sheroo Pratap wrote:
> Thanks Justin for quick response and clarifications.
>
> As suggested by Joe, i checked out OVS master and tried to build OVS in
> upstream kernel it successfully installed and working fine (Thanks again
> all).
>
> below are the steps i have follow
Is the below testsuite failure on anyone's radar? It seems to be
failing maybe 30% of the time on Travis. Travis is known to run the
tests on heavily loaded systems and as such is likely to randomly
reorder thread execution which increases the likelihood of race
conditions causing testsuite failure
n May 4, 2016, at 6:01 PM, Joe Stringer wrote:
>>
>> A few of the earlier tests were written with all flows in a single flat
>> table. While this is a possible way to write your flows to use
>> connection tracking, it's easier to understand if the processing
>> pro
On 5 May 2016 at 13:05, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
Thanks, applied.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 5 May 2016 at 13:04, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
Thanks, applied.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 5 May 2016 at 12:54, Jarno Rajahalme wrote:
> Thanks for figuring this out, Joe!
>
> Acked-by: Jarno Rajahalme
No problem, thanks for looking the series over. I applied this to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/
with 128-bit values, modify the other utility
> functions to do the same.
>
> Signed-off-by: Justin Pettit
Seems reasonable to me.
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 10 May 2016 at 10:37, pravin shelar wrote:
> On Fri, May 6, 2016 at 9:23 AM, Ben Pfaff wrote:
>> On Mon, Apr 25, 2016 at 03:58:33PM -0700, Pravin B Shelar wrote:
>>> The neighbor entry expiry is only checked in dpif-poll
>>> event handler, But in absence of any event we could keep
>>> using ar
rs on
recirculation.")
Reported-by: Sairam Venugopal
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index f62f46b8e337..52c42ab41a47 100644
-
60:9: note: expanded from macro 'ovs_mutex_lock'
ovs_mutex_lock_at(mutex, OVS_SOURCE_LOCATOR)
^
Fixes: d6e3feb57c44 ("Add support for extended netdev statistics based on RFC
2819.")
Signed-off-by: Joe Stringer
---
lib/netdev-dpdk.c | 1 +
1 file changed, 1 inse
On 11 May 2016 at 10:46, Pravin B Shelar wrote:
> Sort the list of arp entries to get predictable output.
>
> Signed-off-by: Pravin B Shelar
Thanks for the fix.
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvs
On 10 May 2016 at 16:00, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> It seems to me that the UFID is still passed down alongside the key, assuming
> that is ok.
It seems that the proper way is to only pass it down if
flow->ufid_present is true. I amended that and pushed to master and
llow in-place modifications of datapath flows.")
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index 0543c78e8790..2280e240ee76 100644
--- a/ofproto/ofp
On 12 May 2016 at 17:32, Daniele Di Proietto wrote:
> Thanks for fixing this!
>
> Acked-by: Daniele Di Proietto
Thanks, applied.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Signed-off-by: Joe Stringer
---
utilities/ovs-dev.py | 54 +++-
1 file changed, 28 insertions(+), 26 deletions(-)
diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py
index 524f574ff092..0ba4280a8ddf 100755
--- a/utilities/ovs-dev.py
+++ b
Adapt to python-2.6+, including support for 3.
Signed-off-by: Joe Stringer
---
utilities/ovs-dev.py | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py
index 0ba4280a8ddf..40cd43e14730 100755
--- a/utilities/ovs-dev.py
+++ b
executes an OpenFlow packet-out.
Fixes: e4e74c3a2b9a ("dpif-netdev: Purge all ukeys when reconfigure pmd.")
Fixes: 623540e4617e ("dpif-netdev: Streamline miss handling.")
Reported-by: William Tu
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c | 3 +++
1 file c
Hi William, could you try this fix? (I'm getting hard failures on
those OVN tests on my dev box, likely something unrelated..)
http://patchwork.ozlabs.org/patch/622833/
On 14 May 2016 at 17:13, William Tu wrote:
> Hi Ben,
>
> Thanks, I applied diff below. Unfortunately it makes no difference.
>
On 22 April 2016 at 17:45, Ben Pfaff wrote:
> @@ -5086,7 +5083,9 @@ xlate_actions(struct xlate_in *xin, struct xlate_out
> *xout)
> .xbridge = xbridge,
> .stack = OFPBUF_STUB_INITIALIZER(stack_stub),
> .rule = xin->rule,
> -.wc = xin->wc ? xin->wc : &scratch_wc,
On 10 May 2016 at 01:59, Sheroo Pratap wrote:
> Thanks Joe,
>
> I tried to add flows for NAT using below commands
>
> ovs-ofctl add-flow br0
> "in_port=1,ip,action=ct(commit,nat(src=192.168.56.103-192.168.56.115)),2"
> ovs-ofctl add-flow br0 "in_port=2,ct_state=-trk,ip,action=ct(table=0,nat)"
> ov
On 14 May 2016 at 21:41, Ben Pfaff wrote:
> On Fri, May 13, 2016 at 02:17:12PM -0700, Joe Stringer wrote:
>> As per the delete_op_init{,__}() functions, the UFID should only be
>> passed down if ukey->ufid_present is set. Otherwise it is possible to
>> request a flow m
Thanks, this fixes the issue for me.
Acked-by: Joe Stringer
As a side note for anyone interested, with a little git config item:
[pretty]
fixes = Fixes: %h (\"%s\")
Plus a simple bash function:
https://github.com/joestringer/config/blob/e66ccc6be698b25237e3e21d4b25ecf168bc9e98/.bashr
tialization for
> ‘(anonymous).masks.vlan_tci’)
>
> Reported-by: Joe Stringer
> Reported-at: https://travis-ci.org/openvswitch/ovs/builds/130256491
> Signed-off-by: Ben Pfaff
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
On 17 May 2016 at 19:02, Ben Pfaff wrote:
> On Tue, May 17, 2016 at 06:34:27PM -0700, Joe Stringer wrote:
>> On 17 May 2016 at 16:29, Ben Pfaff wrote:
>> > Without this change, GCC 4.6 reports:
>> >
>> > ofproto/ofproto-dpif-xlate.c: In function ‘xlate_actions
On 18 May 2016 at 05:26, Russell Bryant wrote:
>
>
> On Tue, May 17, 2016 at 11:21 PM, Ben Pfaff wrote:
>>
>> Do you want to add this script to FLAKE8_PYFILES so that the pep8ness
>> doesn't accidentally get broken later?
>>
>> I didn't read the patches.
>
>
> The changes look fine to me other th
Signed-off-by: Joe Stringer
---
INSTALL.md | 88 +-
1 file changed, 76 insertions(+), 12 deletions(-)
diff --git a/INSTALL.md b/INSTALL.md
index 5b37786d973d..82f5188eacb8 100644
--- a/INSTALL.md
+++ b/INSTALL.md
@@ -101,6 +101,14
101 - 200 of 2028 matches
Mail list logo
