On 14 May 2016 at 21:41, Ben Pfaff <b...@ovn.org> wrote:
> On Fri, May 13, 2016 at 02:17:12PM -0700, Joe Stringer wrote:
>> As per the delete_op_init{,__}() functions, the UFID should only be
>> passed down if ukey->ufid_present is set. Otherwise it is possible to
>> request a flow modification only using a UFID in a datapath that doesn't
>> support UFID, which will fail.
>>
>> Fixes: 43b2f131a229 ("ofproto: Allow in-place modifications of datapath
>> flows.")
>> Signed-off-by: Joe Stringer <j...@ovn.org>
>
> ...
>
>> - op->dop.u.flow_put.ufid = &ukey->ufid;
>> + op->dop.u.flow_put.ufid = ukey->ufid_present ? &ukey->ufid: NULL;
>
> Usually we'd put a space before the colon.
>
> Acked-by: Ben Pfaff <b...@ovn.org>
Thanks, I made this amendment and applied the patch to master and branch-2.5.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
