Re: [ovs-dev] [PATCH] datapath: do not add Geneve attributes if vport does not exist

2014-07-28 Thread Jesse Gross
On Tue, Jul 22, 2014 at 9:34 AM, Jesse Gross wrote: > On Mon, Jul 21, 2014 at 5:11 PM, Ansis Atteka wrote: >> On Thu, Jul 17, 2014 at 4:08 PM, Jesse Gross wrote: >>> One thing that I worry about is that this has the possibility to >>> change how the flow is reported

Re: [ovs-dev] [PATCH] datapath-windows: Fix compilation for kernel module.

2014-07-30 Thread Jesse Gross
On Wed, Jul 30, 2014 at 4:58 AM, Saurabh Shah wrote: > diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h > index 271a14e..9f94138 100644 > --- a/include/linux/openvswitch.h > +++ b/include/linux/openvswitch.h > @@ -40,8 +40,10 @@ > #ifndef _LINUX_OPENVSWITCH_H > #define _LIN

Re: [ovs-dev] [PATCH] datapath-windows: Fix compilation for kernel module.

2014-07-30 Thread Jesse Gross
On Wed, Jul 30, 2014 at 12:32 PM, Saurabh Shah wrote: > > >> -Original Message----- >> From: Jesse Gross [mailto:je...@nicira.com] >> Sent: Wednesday, July 30, 2014 12:28 PM >> To: Saurabh Shah >> Cc: dev@openvswitch.org >> Subject: Re: [ovs-dev] [PA

Re: [ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-07-31 Thread Jesse Gross
On Fri, Jun 27, 2014 at 6:21 AM, Lorand Jakab wrote: > Implementation of the pop_eth and push_eth actions in the kernel, and > layer 3 flow support. > > Signed-off-by: Lorand Jakab Thank you for your patience on this. > diff --git a/datapath/actions.c b/datapath/actions.c > index cb26ad5..20c66

Re: [ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-07-31 Thread Jesse Gross
On Thu, Jul 31, 2014 at 5:45 AM, Lori Jakab wrote: > On 7/31/14, 10:09 AM, Jesse Gross wrote: >> On Fri, Jun 27, 2014 at 6:21 AM, Lorand Jakab wrote: >>> diff --git a/datapath/actions.c b/datapath/actions.c >>> index cb26ad5..20c66f5 100644 >>> --- a/d

Re: [ovs-dev] [PATCHv3] datapath: do not use vport type to determine presence of Geneve attributes

2014-08-01 Thread Jesse Gross
On Tue, Jul 29, 2014 at 5:11 PM, Ansis Atteka wrote: > diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c > index e1eadbb..41199ff 100644 > --- a/datapath/flow_netlink.c > +++ b/datapath/flow_netlink.c > @@ -1051,10 +1052,7 @@ int ovs_nla_put_flow(struct datapath *dp, const struct > s

Re: [ovs-dev] [PATCHv4] datapath: do not use vport type to determine presence of Geneve attributes

2014-08-01 Thread Jesse Gross
t; [] ? __sb_end_write+0x31/0x60 > [] ? touch_atime+0x10f/0x140 > [] ? pipe_read+0x371/0x400 > [] SYSC_sendto+0x121/0x1c0 > [] ? vtime_account_user+0x54/0x60 > [] ? syscall_trace_enter+0x145/0x250 > [] SyS_sendto+0xe/0x10 > [] tracesys+0xe1/0xe6 > > Signed-Off-By: Ansis At

Re: [ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-08-01 Thread Jesse Gross
On Fri, Aug 1, 2014 at 3:19 PM, Lori Jakab wrote: > On 8/1/14, 3:25 AM, Jesse Gross wrote: >> >> On Thu, Jul 31, 2014 at 5:45 AM, Lori Jakab wrote: >>> >>> On 7/31/14, 10:09 AM, Jesse Gross wrote: >>>> >>>> On Fri, Jun 27, 2014 at 6:21 A

Re: [ovs-dev] [PATCH 2/3] Do not seemingly #include Linux-specific headers on other platforms.

2014-08-01 Thread Jesse Gross
On Thu, Jul 31, 2014 at 7:52 PM, Ben Pfaff wrote: > On Mon, Jun 23, 2014 at 03:39:32PM -0700, Jesse Gross wrote: >> On Fri, Jun 13, 2014 at 3:28 PM, Ben Pfaff wrote: >> > Until now, the OVS source tree has had a whole maze of header files that >> > make "#include

Re: [ovs-dev] [PATCH] ofproto-dpif: Use DPIF_FP_CREATE but not DPIF_FP_MODIFY.

2014-08-04 Thread Jesse Gross
g" level (see > flow_message_log_level()), effectively suppressing the logging in normal > circumstances. > > It appears that in practice ofproto-dpif doesn't actually ever need to > modify flows in the datapath, only create and delete them, so this > shouldn't cause problems. >

Re: [ovs-dev] [PATCH v2 0/2] Make better from userspace

2014-08-04 Thread Jesse Gross
a problem in the future though.) Acked-by: Jesse Gross The only minor suggestion that I have is make the notice about odp-netlink.h being a generated file more prominent. On my editor it blends in with the copyright message so some extra blank lines in between the two would lik

Re: [ovs-dev] [PATCH] ofproto-dpif: Use DPIF_FP_CREATE but not DPIF_FP_MODIFY.

2014-08-04 Thread Jesse Gross
On Mon, Aug 4, 2014 at 10:50 AM, Ben Pfaff wrote: > On Mon, Aug 04, 2014 at 10:15:17AM -0700, Jesse Gross wrote: >> On Fri, Aug 1, 2014 at 5:22 PM, Ben Pfaff wrote: >> > A dpif reports EEXIST if a flow put operation that should create a new flow >> > instead attempts

Re: [ovs-dev] [PATCH v7] Extend OVS IPFIX exporter to export tunnel headers

2014-08-05 Thread Jesse Gross
On Tue, Aug 5, 2014 at 10:05 AM, Ben Pfaff wrote: > Why is Geneve restricted to a 24-bit key? The VNI in Geneve (as separate from the options) is 24 bit. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 8/8] datapath: Allow masks for set actions.

2014-08-05 Thread Jesse Gross
On Fri, Jul 18, 2014 at 8:15 AM, Jarno Rajahalme wrote: > On May 8, 2014, at 1:27 PM, Jesse Gross wrote: > >> On Fri, Apr 11, 2014 at 4:29 PM, Jarno Rajahalme >> wrote: >>> Masked set action allows more megaflow wildcarding. Masked set action >>> is now s

Re: [ovs-dev] [PATCH 4/6] dpif: Meter framework.

2014-08-05 Thread Jesse Gross
On Tue, Aug 5, 2014 at 4:38 PM, Jarno Rajahalme wrote: > diff --git a/datapath/linux/compat/include/linux/openvswitch.h > b/datapath/linux/compat/include/linux/openvswitch.h > index 271a14e..64761b4 100644 > --- a/datapath/linux/compat/include/linux/openvswitch.h > +++ b/datapath/linux/compat/inc

Re: [ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-08-05 Thread Jesse Gross
On Tue, Aug 5, 2014 at 1:45 PM, Lori Jakab wrote: > Hi Jesse, > > I'll be on vacation starting tomorrow, it looks like this won't be merged > for at least another two weeks. Have a nice vacation. Sorry that we couldn't get this in before you leave. > On 8/2/14, 4:1

Re: [ovs-dev] [PATCH 4/6] dpif: Meter framework.

2014-08-06 Thread Jesse Gross
On Wed, Aug 6, 2014 at 9:23 AM, Jarno Rajahalme wrote: > >> On Aug 5, 2014, at 6:19 PM, Jesse Gross wrote: >> >>> On Tue, Aug 5, 2014 at 4:38 PM, Jarno Rajahalme >>> wrote: >>> diff --git a/datapath/linux/compat/include/linux/openvswitch.h

Re: [ovs-dev] [PATCH] datapath: Refactor action alloc and copy api.

2014-08-07 Thread Jesse Gross
On Thu, Aug 7, 2014 at 12:51 PM, Pravin B Shelar wrote: > There are two separate API to allocate and copy actions list. Anytime > OVS needs to copy action list, it needs to call both functions. > Following patch moves action allocation to copy function to avoid > code duplication. > > Signed-off-b

Re: [ovs-dev] [PATCH] datapath: Avoid using stack larger than 1024.

2014-08-07 Thread Jesse Gross
-larger-than=] > } > > Following patch introduced the factoring back. > > CC: Jesse Gross > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] odp-netlink.h: Autogenerate a version of odp-netlink for windows kernel.

2014-08-08 Thread Jesse Gross
On Fri, Aug 8, 2014 at 11:09 AM, Ben Pfaff wrote: > On Fri, Aug 08, 2014 at 06:03:38PM +, Samuel Ghinet wrote: >> [QUOTE]If the transformation scripts become hard to maintain, we'll do >> something else.[/QUOTE] >> The script method still doesn't sound awesome. >> >> let's see... can we enclos

Re: [ovs-dev] [PATCH v2 8/8] datapath: Allow masks for set actions.

2014-08-08 Thread Jesse Gross
On Fri, Aug 8, 2014 at 1:28 PM, Jarno Rajahalme wrote: > On Aug 5, 2014, at 10:57 AM, Jesse Gross wrote: > >> On Fri, Jul 18, 2014 at 8:15 AM, Jarno Rajahalme >> wrote: >>> On May 8, 2014, at 1:27 PM, Jesse Gross wrote: >> One difficulty that comes to mind

Re: [ovs-dev] [PATCH v3 5/6] datapath/flow_netlink: Validate IPv6 flow key and mask values.

2014-08-08 Thread Jesse Gross
ut a htonl on the constant instead, since the compiler can do it for us. Otherwise, this looks fine: Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3 4/6] datapath/actions: Mark recalculate_csum as likely in set_ipv6_addr().

2014-08-08 Thread Jesse Gross
be marked as 'likely'. > > Signed-off-by: Jarno Rajahalme Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v4 1/4] lib/odp: Masked set action execution and printing.

2014-08-11 Thread Jesse Gross
On Mon, Aug 11, 2014 at 9:14 AM, Jarno Rajahalme wrote: > diff --git a/tests/odp.at b/tests/odp.at > index e725f70..58e3ff1 100644 > --- a/tests/odp.at > +++ b/tests/odp.at +set(ipv4(src=35.8.2.41/255.255.255.255,dst=172.16.0.20/255.255.255.255,proto=5/0xff,tos=0x80/0,ttl=128/0xff,frag=no/0xff)) >

Re: [ovs-dev] [PATCH v4 4/4] datapath: Allow masks for set actions.

2014-08-11 Thread Jesse Gross
On Mon, Aug 11, 2014 at 9:15 AM, Jarno Rajahalme wrote: > Masked set action allows more megaflow wildcarding. Masked set action > is now supported for all writeable key types, except for the tunnel > key. > > The set tunnel action is an exception as any input tunnel info is > cleared before actio

Re: [ovs-dev] [PATCH v2 4/6] dpif: Meter framework.

2014-08-13 Thread Jesse Gross
On Wed, Aug 13, 2014 at 12:43 PM, Pravin Shelar wrote: > On Wed, Aug 13, 2014 at 9:25 AM, Ben Pfaff wrote: >> On Mon, Aug 11, 2014 at 02:37:45PM -0700, Jarno Rajahalme wrote: >>> Add DPIF-level infrastructure for meters. Allow meter_set to modify >>> the meter configuration (e.g. set the burst s

Re: [ovs-dev] [PATCH] FAQ: Mention kernel support for MPLS in Open vSwitch 2.4.

2014-08-14 Thread Jesse Gross
On Thu, Aug 14, 2014 at 11:17 AM, Ben Pfaff wrote: > The recent mailing list thread about MPLS reminded me that the FAQ needs an > update. > > CC: Simon Horman > Signed-off-by: Ben Pfaff Acked-by: Jesse Gross ___ dev mailing list dev@

[ovs-dev] [PATCH] datapath: Fix checksum calculation when modifying ICMPv6 packets.

2014-08-15 Thread Jesse Gross
Shrader Signed-off-by: Jesse Gross --- datapath/actions.c | 8 ++-- lib/packets.c | 5 + 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/datapath/actions.c b/datapath/actions.c index b16e0b2..713a45d 100644 --- a/datapath/actions.c +++ b/datapath/actions.c @@ -383,11

Re: [ovs-dev] [ovs-discuss] Checksum incorrect when rewriting icmpv6 packet

2014-08-15 Thread Jesse Gross
On Fri, Aug 15, 2014 at 9:44 AM, Ben Pfaff wrote: > [adding Jesse and ovs-dev] > > On Thu, Aug 14, 2014 at 11:03:52AM -0400, Neal Shrader wrote: >> I came across an issue today what I was attempting to modify the source >> ipv6 address of a router advertisement generated from a local server. The

Re: [ovs-dev] [PATCH] datapath: remove flow member from struct ovs_skb_cb

2014-08-24 Thread Jesse Gross
On Thu, Aug 21, 2014 at 12:25 PM, Lorand Jakab wrote: > struct ovs_skb_cb is full on kernels < 3.11 due to compatibility code. > This patch removes the 'flow' member in order to make room for data > needed by layer 3 flow/port support that will be added in an upcoming > patch. The 'flow' memeber

Re: [ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-08-24 Thread Jesse Gross
On Thu, Aug 21, 2014 at 12:24 PM, Lori Jakab wrote: > On 8/6/14 4:37 AM, Jesse Gross wrote: >> Besides the fact that it would be nice to unify things, I'm not sure >> that it is actually correct to pull off VLAN, MPLS, etc. tags that we >> don't understand. Pres

Re: [ovs-dev] [PATCH v4 1/4] lib/odp: Masked set action execution and printing.

2014-08-25 Thread Jesse Gross
On Mon, Aug 25, 2014 at 7:19 PM, Jarno Rajahalme wrote: > > On Aug 11, 2014, at 3:46 PM, Jesse Gross wrote: > >> On Mon, Aug 11, 2014 at 9:14 AM, Jarno Rajahalme >> wrote: >>> diff --git a/tests/odp.at b/tests/odp.at >>> index e725f70..58e3ff1 100644

Re: [ovs-dev] [RFC] Proposal for enhanced select groups

2014-08-27 Thread Jesse Gross
On Wed, Aug 27, 2014 at 11:51 AM, Ben Pfaff wrote: > On Wed, Aug 27, 2014 at 10:26:14AM +0900, Simon Horman wrote: >> On Fri, Aug 22, 2014 at 08:30:08AM -0700, Ben Pfaff wrote: >> > On Fri, Aug 22, 2014 at 09:19:41PM +0900, Simon Horman wrote: >> What we would like to do is to provide something ge

Re: [ovs-dev] [PATCH] datapath: Fix checksum calculation when modifying ICMPv6 packets.

2014-08-29 Thread Jesse Gross
On Fri, Aug 15, 2014 at 11:18 AM, Jesse Gross wrote: > The checksum of ICMPv6 packets uses the IP pseudoheader as part of > the calculation, unlike ICMP in IPv4. This was not implemented, > which means that modifying the IP addresses of an ICMPv6 packet > would cause the checksum to

Re: [ovs-dev] [PATCH] datapath: Always initialize fix_segment for GSO packet.

2014-08-29 Thread Jesse Gross
On Thu, Aug 28, 2014 at 11:30 AM, Pravin B Shelar wrote: > OVS tunnel compat code depends on this function pointer to > handle GSO packet. Currently we do not initialize for all > GRE GSO packets. Following patch fixes that. > > Signed-off-by: Pravin B Shelar Acked-

Re: [ovs-dev] [PATCH] datapath: Fix checksum calculation when modifying ICMPv6 packets.

2014-08-29 Thread Jesse Gross
On Fri, Aug 29, 2014 at 12:38 PM, Pravin Shelar wrote: > On Fri, Aug 15, 2014 at 11:18 AM, Jesse Gross wrote: >> The checksum of ICMPv6 packets uses the IP pseudoheader as part of >> the calculation, unlike ICMP in IPv4. This was not implemented, >> which means that modifyin

[ovs-dev] [PATCH] packet: Fix sparse warnings ICMPv6.

2014-09-02 Thread Jesse Gross
The system defined ICMPv6 header doesn't have sparse annotation, so this adds a definition so that endianness can be checked. Reported-by: Alex Wang Signed-off-by: Jesse Gross --- lib/packets.c | 5 +++-- lib/packets.h | 9 + 2 files changed, 12 insertions(+), 2 deletions(-)

Re: [ovs-dev] [PATCH] packets: Suppress sparse warning.

2014-09-02 Thread Jesse Gross
On Tue, Sep 2, 2014 at 6:36 PM, Ethan Jackson wrote: > warning: incorrect type in argument 1 (different base types) > expected restricted ovs_be16 [usertype] old_csum > got unsigned short [unsigned] [usertype] icmp6_cksum > > Signed-off-by: Ethan Jackson I actually just sent out a patch

Re: [ovs-dev] [PATCH] packet: Fix sparse warnings ICMPv6.

2014-09-02 Thread Jesse Gross
On Tue, Sep 2, 2014 at 6:23 PM, Ben Pfaff wrote: > On Tue, Sep 02, 2014 at 06:00:08PM -0700, Jesse Gross wrote: >> The system defined ICMPv6 header doesn't have sparse annotation, >> so this adds a definition so that endianness can be checked. >> >> Reported-by: Al

Re: [ovs-dev] [RFC] Proposal for enhanced select groups

2014-09-02 Thread Jesse Gross
On Mon, Sep 1, 2014 at 1:10 AM, Simon Horman wrote: > On Thu, Aug 28, 2014 at 10:12:49AM +0900, Simon Horman wrote: >> On Wed, Aug 27, 2014 at 03:03:53PM -0500, Jesse Gross wrote: >> > On Wed, Aug 27, 2014 at 11:51 AM, Ben Pfaff wrote: >> > > On Wed, Aug 27, 2

Re: [ovs-dev] [PATCH] packet: Fix sparse warnings ICMPv6.

2014-09-02 Thread Jesse Gross
On Tue, Sep 2, 2014 at 8:51 PM, Ben Pfaff wrote: > On Tue, Sep 02, 2014 at 06:43:31PM -0700, Jesse Gross wrote: >> On Tue, Sep 2, 2014 at 6:23 PM, Ben Pfaff wrote: >> > On Tue, Sep 02, 2014 at 06:00:08PM -0700, Jesse Gross wrote: >> >> The system defined ICM

Re: [ovs-dev] [RFC] Proposal for enhanced select groups

2014-09-05 Thread Jesse Gross
On Thu, Sep 4, 2014 at 12:28 AM, Simon Horman wrote: > On Tue, Sep 02, 2014 at 07:20:30PM -0700, Pravin Shelar wrote: >> On Tue, Sep 2, 2014 at 6:55 PM, Jesse Gross wrote: >> > On Mon, Sep 1, 2014 at 1:10 AM, Simon Horman >> > wrote: >> >> On Thu, Aug 28,

Re: [ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-09-11 Thread Jesse Gross
On Mon, Sep 8, 2014 at 5:43 AM, Lori Jakab wrote: > On 8/25/14 3:33 AM, Jesse Gross wrote: >> >> On Thu, Aug 21, 2014 at 12:24 PM, Lori Jakab wrote: >>> >>> On 8/6/14 4:37 AM, Jesse Gross wrote: >>>> >>>> Besides the fact that it wo

Re: [ovs-dev] [RFC] Proposal for enhanced select groups

2014-09-11 Thread Jesse Gross
On Sun, Sep 7, 2014 at 7:18 PM, Simon Horman wrote: > On Fri, Sep 05, 2014 at 12:07:17PM -0700, Jesse Gross wrote: >> On Thu, Sep 4, 2014 at 12:28 AM, Simon Horman >> wrote: >> > On Tue, Sep 02, 2014 at 07:20:30PM -0700, Pravin Shelar wrote: >> >> On Tue,

Re: [ovs-dev] [PATCH v2] tunneling: Improving tunneling performance using DPDK Rx checksum offloading feature.

2016-04-14 Thread Jesse Gross
On Wed, Apr 13, 2016 at 7:42 AM, Sugesh Chandran wrote: > Optimizing tunneling performance in userspace datapath by offloading the > rx checksum validation on tunnel packets to the NIC when it is supported. > > This patch improves the bidirectional VxLAN tunneling performance by 8% and > decapsula

Re: [ovs-dev] ipv6 tunneling support question for branch-2.5

2016-04-14 Thread Jesse Gross
On Wed, Apr 13, 2016 at 9:26 AM, Richukov Kes wrote: > Hi, > > We are researching with IPv6 tunneling support on openvswitch. We can only > use a released version of openvswitch (not the experimental > master branch). We saw that IPv6 tunnel creation fails in branch-2.5, which > dates back to a

Re: [ovs-dev] ipv6 tunneling support question for branch-2.5

2016-04-14 Thread Jesse Gross
On Thu, Apr 14, 2016 at 6:25 PM, Richukov Kes wrote: > > Dear Jesse, > > Thank you for the kind response. Would you mind advising us on a couple of > more things: > 1. When can we expect the next ovs release? Will it be in the next couple > of months? > 2. Would you kindly shed some light on what

Re: [ovs-dev] [PATCH v2] tunneling: Improving tunneling performance using DPDK Rx checksum offloading feature.

2016-04-15 Thread Jesse Gross
On Fri, Apr 15, 2016 at 3:04 AM, Chandran, Sugesh wrote: >> -Original Message- >> From: pravin shelar [mailto:pshe...@ovn.org] >> Sent: Thursday, April 14, 2016 5:59 PM >> To: Chandran, Sugesh >> Cc: ovs dev >> Subject: Re: [ovs-dev] [PATCH v2] tunneling: Improving tunneling >> performan

Re: [ovs-dev] [PATCH 3/3] datapath-windows: Removed always true condition in VXLAN

2016-04-15 Thread Jesse Gross
On Fri, Apr 15, 2016 at 10:27 AM, Nithin Raju wrote: > Paul, > If you are sure that tunKey->tunnelId will always be set, it would be a > good idea to mark .optional as FALSE in definition of > nlFlowTunnelKeyPolicy. For tunnels in general, the key won't always be present. (GRE is an example of wh

Re: [ovs-dev] [PATCH] Update relevant artifacts to add support for DPDK 16.04.

2016-04-15 Thread Jesse Gross
On Fri, Apr 15, 2016 at 2:33 AM, Panu Matilainen wrote: > On 04/13/2016 07:21 PM, Traynor, Kevin wrote: >>> >>> -Original Message- >>> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Panu >>> Matilainen >>> Sent: Wednesday, April 13, 2016 8:50 AM >>> To: Weglicki, MichalX ; dev

Re: [ovs-dev] [PATCH 3/3] datapath-windows: Removed always true condition in VXLAN

2016-04-15 Thread Jesse Gross
On Fri, Apr 15, 2016 at 10:56 AM, Nithin Raju wrote: > -Original Message- > From: Jesse Gross > Date: Friday, April 15, 2016 at 10:40 AM > To: Nithin Raju > Cc: Paul Boca , "dev@openvswitch.org" > > Subject: Re: [ovs-dev] [PATCH 3/3] datapath-windows: Rem

Re: [ovs-dev] [RFC PATCH] create vxlan device using rtnetlink interface

2016-04-15 Thread Jesse Gross
On Fri, Apr 15, 2016 at 2:30 PM, Thadeu Lima de Souza Cascardo wrote: > Hi, this is an RFC patch (could probably be 2 patches - more below), that > creates VXLAN devices in userspace and adds them as netdev vports, instead of > using the vxlan vport code. > > The reason for this change is that it

Re: [ovs-dev] [PATCH v2] tunneling: Improving tunneling performance using DPDK Rx checksum offloading feature.

2016-04-18 Thread Jesse Gross
On Mon, Apr 18, 2016 at 2:12 AM, Chandran, Sugesh wrote: >> -Original Message- >> From: Jesse Gross [mailto:je...@kernel.org] >> Sent: Friday, April 15, 2016 5:04 PM >> To: Chandran, Sugesh >> Cc: pravin shelar ; ovs dev >> Subject: Re: [ovs-

Re: [ovs-dev] [RFC PATCH] create vxlan device using rtnetlink interface

2016-04-18 Thread Jesse Gross
On Mon, Apr 18, 2016 at 3:27 AM, Jiri Benc wrote: > On Fri, 15 Apr 2016 20:36:51 -0700, Jesse Gross wrote: >> I'm not too excited about this. It seems like it would be a regression >> - currently OVSDB allows remote creation of tunnels, so it seems like >> this would b

Re: [ovs-dev] [PATCH] Add VxLAN-GBP support for user space data path

2016-04-19 Thread Jesse Gross
On Tue, Apr 19, 2016 at 3:20 AM, Johnson.Li wrote: > diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c > index e398562..e6b35ed 100644 > --- a/lib/netdev-vport.c > +++ b/lib/netdev-vport.c > @@ -1297,10 +1298,16 @@ netdev_vxlan_pop_header(struct dp_packet *packet) > return EINVAL; >

Re: [ovs-dev] [RFC PATCH] create vxlan device using rtnetlink interface

2016-04-19 Thread Jesse Gross
On Mon, Apr 18, 2016 at 2:57 AM, Thadeu Lima de Souza Cascardo wrote: > On Fri, Apr 15, 2016 at 08:36:51PM -0700, Jesse Gross wrote: >> On Fri, Apr 15, 2016 at 2:30 PM, Thadeu Lima de Souza Cascardo >> wrote: >> > Hi, this is an RFC patch (could probably be 2 pat

Re: [ovs-dev] [RFC PATCH] create vxlan device using rtnetlink interface

2016-04-20 Thread Jesse Gross
On Wed, Apr 20, 2016 at 4:00 AM, Thadeu Lima de Souza Cascardo wrote: > On Tue, Apr 19, 2016 at 04:25:32PM -0700, Jesse Gross wrote: >> On Mon, Apr 18, 2016 at 2:57 AM, Thadeu Lima de Souza Cascardo >> wrote: >> > On Fri, Apr 15, 2016 at 08:36:51PM -0700, Jesse Gross wro

Re: [ovs-dev] [PATCH v2] Add VxLAN-GBP support for user space data path

2016-04-20 Thread Jesse Gross
On Wed, Apr 20, 2016 at 12:39 AM, Johnson.Li wrote: > From: Johnson Li > > In user space, only standard VxLAN was support. This patch will > add the VxLAN-GBP support for the user space data path. > > How to use: > 1> Create VxLAN port with GBP extension > $ovs-vsctl add-port br-int vxlan0 -- s

Re: [ovs-dev] [PATCH v2] Add VxLAN-GBP support for user space data path

2016-04-20 Thread Jesse Gross
On Wed, Apr 20, 2016 at 6:10 PM, Li, Johnson wrote: >> -Original Message- >> From: Jesse Gross [mailto:je...@kernel.org] >> Sent: Thursday, April 21, 2016 4:23 AM >> To: Li, Johnson >> Cc: ovs dev >> Subject: Re: [ovs-dev] [PATCH v2] Add VxLAN-GBP

Re: [ovs-dev] [PATCH v3] Add VxLAN-GBP support for user space data path

2016-04-21 Thread Jesse Gross
On Wed, Apr 20, 2016 at 11:43 PM, Johnson.Li wrote: > From: Johnson Li > > In user space, only standard VxLAN was support. This patch will > add the VxLAN-GBP support for the user space data path. > > How to use: > 1> Create VxLAN port with GBP extension > $ovs-vsctl add-port br-int vxlan0 -- s

Re: [ovs-dev] [RFC PATCH] create vxlan device using rtnetlink interface

2016-04-21 Thread Jesse Gross
On Thu, Apr 21, 2016 at 9:43 AM, Thadeu Lima de Souza Cascardo wrote: > On Wed, Apr 20, 2016 at 11:38:31AM -0700, Jesse Gross wrote: >> One minor comment that I noticed on the patch itself - I don't know if >> the port mapping functions are handling IPsec variants of tunnels

Re: [ovs-dev] [PATCH v3] Add VxLAN-GBP support for user space data path

2016-04-21 Thread Jesse Gross
On Thu, Apr 21, 2016 at 6:03 PM, Li, Johnson wrote: >> -Original Message- >> From: Jesse Gross [mailto:je...@kernel.org] >> Sent: Friday, April 22, 2016 12:44 AM >> To: Li, Johnson >> Cc: ovs dev >> Subject: Re: [ovs-dev] [PATCH v3] Add VxLAN-GBP

Re: [ovs-dev] [PATCH] datapath: Fix datapath build on Centos 6.5 (2.6.31-431) kernels

2016-04-22 Thread Jesse Gross
On Thu, Apr 21, 2016 at 8:01 PM, Wanlong Gao wrote: > The build was failing with following error: > > > CC [M] /home/sabyasse/Linux/src/sandbox/ovs_v1/datapath/linux/vport.o > /home/sabyasse/Linux/src/sandbox/ovs_v1/datapath/linux/vport.c: In > function ‘ovs_vport_get_stats’: > /home/sabya

Re: [ovs-dev] [PATCH] datapath: Fix datapath build on Centos 6.5 (2.6.31-431) kernels

2016-04-26 Thread Jesse Gross
On Sat, Apr 23, 2016 at 5:52 PM, Wanlong Gao wrote: > The following error is caused by the undefined dev_get_stats64() of kernel > v2.6.32-431. The HAVE_RTNL_LINK_STATS64 does not work because this series > kernel have the "struct rtnl_link_stats64" but neither have 64bit > dev_get_stats() nor dev

Re: [ovs-dev] [PATCH v2] stt: linearize for CONFIG_SLUB case

2016-04-26 Thread Jesse Gross
On Mon, Apr 25, 2016 at 2:35 PM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat/stt.c > index eb397e8..a1b309a 100644 > --- a/datapath/linux/compat/stt.c > +++ b/datapath/linux/compat/stt.c > +static int coalesce_skb(struct sk_buff **headp) > +{ > +

Re: [ovs-dev] [PATCH 5/5] datapath: Orphan skbs before IPv6 defrag

2016-04-26 Thread Jesse Gross
On Thu, Apr 21, 2016 at 2:07 PM, Joe Stringer wrote: > Upstream commit: > openvswitch: Orphan skbs before IPv6 defrag > > This is the IPv6 counterpart to commit 8282f27449bf ("inet: frag: Always > orphan skbs inside ip_defrag()"). > > Prior to commit 029f7f3b8701 ("netfilter: ipv6:

Re: [ovs-dev] [PATCH 2/5] compat: nf_defrag_ipv6: avoid/free clone operations.

2016-04-26 Thread Jesse Gross
On Thu, Apr 21, 2016 at 2:07 PM, Joe Stringer wrote: > diff --git > a/datapath/linux/compat/include/net/netfilter/ipv6/nf_defrag_ipv6.h > b/datapath/linux/compat/include/net/netfilter/ipv6/nf_defrag_ipv6.h > index fe99ced37227..a3b86dab2c9c 100644 > --- a/datapath/linux/compat/include/net/netfil

Re: [ovs-dev] [PATCH 0/5] Backport nf_defrag_ipv6 changes.

2016-04-26 Thread Jesse Gross
On Thu, Apr 21, 2016 at 2:07 PM, Joe Stringer wrote: > This short series addresses some of the netfilter/defrag-related changes > recently upstream and backports the equivalent fixes to our compat code. > The last two patches address bugs introduced from the second patch, I've > left them as separ

Re: [ovs-dev] [PATCH v3] stt: linearize for CONFIG_SLUB case

2016-04-27 Thread Jesse Gross
; > OVS branch TCP Host0 Host1 > versionGbps CPU% CPU% > - > 2.59.4 272 315 > > master + 9.4 230 285 > patch > > Tested-By: Vasmi Abi

Re: [ovs-dev] [PATCH v2] tunneling: Improving tunneling performance using DPDK Rx checksum offloading feature.

2016-04-28 Thread Jesse Gross
hen to proceed with this patch. > > Regards > _Sugesh > >> -Original Message- >> From: Chandran, Sugesh >> Sent: Monday, April 18, 2016 10:12 AM >> To: Jesse Gross >> Cc: pravin shelar ; ovs dev >> Subject: RE: [ovs-dev] [PATCH v2] tunne

Re: [ovs-dev] [PATCH 2/5] compat: nf_defrag_ipv6: avoid/free clone operations.

2016-04-28 Thread Jesse Gross
On Thu, Apr 28, 2016 at 5:17 PM, Joe Stringer wrote: > On 26 April 2016 at 19:44, Jesse Gross wrote: >> On Thu, Apr 21, 2016 at 2:07 PM, Joe Stringer wrote: >>> diff --git >>> a/datapath/linux/compat/include/net/netfilter/ipv6/nf_defrag_ipv6.h >>> b/datapat

Re: [ovs-dev] [PATCH 2/5] compat: nf_defrag_ipv6: avoid/free clone operations.

2016-04-28 Thread Jesse Gross
On Thu, Apr 28, 2016 at 5:35 PM, Joe Stringer wrote: > On 28 April 2016 at 17:17, Joe Stringer wrote: >> On 26 April 2016 at 19:44, Jesse Gross wrote: >>> On Thu, Apr 21, 2016 at 2:07 PM, Joe Stringer wrote: >>>> diff --git >>>> a/datapa

Re: [ovs-dev] [PATCHv2 0/9] Backport ovs-conntrack changes.

2016-05-02 Thread Jesse Gross
penvswitch/builds/127290050 Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/2] compat: Remove unused ipv[46] backports.

2016-05-02 Thread Jesse Gross
On Mon, May 2, 2016 at 5:47 PM, Joe Stringer wrote: > These pieces #if on kernel versions which are not supported since commit > f2ab1536ddbc ("compat: Backport conntrack strictly to v3.10+.") > > Signed-off-by: Joe Stringer

Re: [ovs-dev] [PATCH 2/2] compat: Remove skbuff header helper backports.

2016-05-02 Thread Jesse Gross
On Mon, May 2, 2016 at 5:47 PM, Joe Stringer wrote: > These have existed largely since v2.6.22, so it's well overdue. > > Signed-off-by: Joe Stringer Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswit

Re: [ovs-dev] [PATCH v2] tunneling: Improving tunneling performance using DPDK Rx checksum offloading feature.

2016-05-04 Thread Jesse Gross
On Wed, May 4, 2016 at 8:58 AM, Chandran, Sugesh wrote: >> -Original Message- >> From: Jesse Gross [mailto:je...@kernel.org] >> Sent: Thursday, April 28, 2016 4:41 PM >> To: Chandran, Sugesh >> Cc: pravin shelar ; ovs dev >> Subject: Re: [ovs-

Re: [ovs-dev] [PATCH v2] tunneling: Improving tunneling performance using DPDK Rx checksum offloading feature.

2016-05-05 Thread Jesse Gross
On Thu, May 5, 2016 at 1:26 AM, Chandran, Sugesh wrote: >> -Original Message- >> From: Jesse Gross [mailto:je...@kernel.org] >> Sent: Wednesday, May 4, 2016 10:06 PM >> To: Chandran, Sugesh >> Cc: pravin shelar ; ovs dev >> Subject: Re: [ovs-

Re: [ovs-dev] [PATCH v2] tunneling: Improving tunneling performance using DPDK Rx checksum offloading feature.

2016-05-06 Thread Jesse Gross
On Fri, May 6, 2016 at 1:13 AM, Chandran, Sugesh wrote: >> -Original Message- >> From: Jesse Gross [mailto:je...@kernel.org] >> Sent: Friday, May 6, 2016 1:58 AM >> To: Chandran, Sugesh >> Cc: pravin shelar ; ovs dev >> Subject: Re: [ovs-dev] [PATC

Re: [ovs-dev] [PATCH v2 01/15] netdev-vport: Factor-out tunnel Push-pop code into separate module.

2016-05-06 Thread Jesse Gross
On Thu, Apr 21, 2016 at 6:54 PM, Pravin B Shelar wrote: > diff --git a/lib/netdev-native-tnl.h b/lib/netdev-native-tnl.h > new file mode 100644 > index 000..5173b10 > --- /dev/null > +++ b/lib/netdev-native-tnl.h > +static inline bool > +is_header_ipv6(const void *header) > +{ > +const str

Re: [ovs-dev] [PATCH v2 02/15] netdev: Return number of packet from netdev_pop_header()

2016-05-06 Thread Jesse Gross
On Thu, Apr 21, 2016 at 6:54 PM, Pravin B Shelar wrote: > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c > index 1e8a37c..5dcb862 100644 > --- a/lib/dpif-netdev.c > +++ b/lib/dpif-netdev.c > case OVS_ACTION_ATTR_OUTPUT: > @@ -3775,8 +3774,12 @@ dp_execute_cb(void *aux_, struct dp_packet *

Re: [ovs-dev] [PATCH v2 04/15] dp-packet: use packet reset function.

2016-05-06 Thread Jesse Gross
On Thu, Apr 21, 2016 at 6:54 PM, Pravin B Shelar wrote: > Signed-off-by: Pravin B Shelar > --- > lib/dp-packet.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Jesse Gross ___ dev mailing list dev@openvswi

Re: [ovs-dev] [PATCH v2 05/15] dpif-netdev: rename packet_batch

2016-05-06 Thread Jesse Gross
On Thu, Apr 21, 2016 at 6:54 PM, Pravin B Shelar wrote: > Next patch introduces new structure named packet_batch. So > I am renaming it to packet_batch_per_flow. > This does not change any functionality. > > Signed-off-by: Pravin B Shelar Acked-

Re: [ovs-dev] [PATCH v2 06/15] dpif-netdev: create batch object

2016-05-06 Thread Jesse Gross
_batch_delete() - we have several similar instances of this. Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 07/15] dpif-netdev: Refactor fast path process function.

2016-05-06 Thread Jesse Gross
lost_cnt) It might be nice to make the function name a little more specific about what type of packet is being handled - handle_packet_upcall() for example. Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 08/15] dpif-netdev: Refactor userspace action

2016-05-06 Thread Jesse Gross
On Thu, Apr 21, 2016 at 6:54 PM, Pravin B Shelar wrote: > Large segment support need to use this refactored function to > send individual segments. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswi

Re: [ovs-dev] [PATCH v2 10/15] netdev-vport: Introduce ip_build_header()

2016-05-06 Thread Jesse Gross
On Thu, Apr 21, 2016 at 6:54 PM, Pravin B Shelar wrote: > diff --git a/lib/netdev-native-tnl.h b/lib/netdev-native-tnl.h > index dbe6bd0..a0dfa8c 100644 > --- a/lib/netdev-native-tnl.h > +++ b/lib/netdev-native-tnl.h > @@ -82,6 +82,31 @@ ipv6_hdr(void *eth) > return (void *)((char *)eth + siz

Re: [ovs-dev] [PATCH v2 11/15] tunnel: Add IP ECN related functions.

2016-05-06 Thread Jesse Gross
On Thu, Apr 21, 2016 at 6:54 PM, Pravin B Shelar wrote: > Set and get functions for IP explicit congestion notification flag. > These function would be used by STT reassembly code. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___

Re: [ovs-dev] [PATCH v2 12/15] tnl-ports: Handle STT ports.

2016-05-06 Thread Jesse Gross
On Thu, Apr 21, 2016 at 6:54 PM, Pravin B Shelar wrote: > STT uses TCP port so we need to filter traffic on basis of TCP > port numbers. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswi

Re: [ovs-dev] [PATCH v2] tunneling: Improving tunneling performance using DPDK Rx checksum offloading feature.

2016-05-10 Thread Jesse Gross
On Tue, May 10, 2016 at 3:26 AM, Chandran, Sugesh wrote: >> -Original Message- >> From: Jesse Gross [mailto:je...@kernel.org] >> Sent: Friday, May 6, 2016 5:00 PM >> To: Chandran, Sugesh >> Cc: pravin shelar ; ovs dev >> Subject: Re: [ovs-dev] [PATC

Re: [ovs-dev] [PATCH v2] acinclude.m4: Fix skb_get_hash function detection

2016-05-10 Thread Jesse Gross
On Tue, May 10, 2016 at 1:21 AM, Markos Chandras wrote: > Commit e2f3178f0582 ("datapath: Add support for kernel 3.14.") added > support for 3.14 kernels and a new OVS_GREP_IFELSE check for the > "skg_get_hash" function in the process. "skb_get_hash" was introduced > in the Linux kernel commit 395

Re: [ovs-dev] [PATCH v2] tunneling: Improving tunneling performance using DPDK Rx checksum offloading feature.

2016-05-12 Thread Jesse Gross
On Thu, May 12, 2016 at 11:18 AM, pravin shelar wrote: > On Tue, May 10, 2016 at 6:31 PM, Jesse Gross wrote: >> I'm a little bit torn as to whether we should apply your rx checksum >> offload patch in the meantime while we wait for DPDK to offer the new >> API. It

Re: [ovs-dev] [PATCH v2] acinclude.m4: Fix skb_get_hash function detection

2016-05-16 Thread Jesse Gross
On Wed, May 11, 2016 at 12:44 AM, Markos Chandras wrote: > On 05/11/2016 02:41 AM, Jesse Gross wrote: >> On Tue, May 10, 2016 at 1:21 AM, Markos Chandras wrote: >>> Commit e2f3178f0582 ("datapath: Add support for kernel 3.14.") added >>> support for 3.14 ke

Re: [ovs-dev] [PATCH v2] tunneling: Improving tunneling performance using DPDK Rx checksum offloading feature.

2016-05-16 Thread Jesse Gross
6 2:38 AM >>> To: pravin shelar >>> Cc: ovs dev >>> Subject: Re: [ovs-dev] [PATCH v2] tunneling: Improving tunneling >>> performance using DPDK Rx checksum offloading feature. >>> >>> 2016-05-12 13:40 GMT-07:00 pravin shelar : >>> >&g

Re: [ovs-dev] [PATCH v3 01/17] netdev-vport: Factor-out tunnel Push-pop code into separate module.

2016-05-17 Thread Jesse Gross
On Tue, May 10, 2016 at 10:30 AM, Pravin B Shelar wrote: > It is better to move tunnel push-pop action specific functions into > separate module. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswi

Re: [ovs-dev] [PATCH v3 02/17] netdev: Return number of packet from netdev_pop_header()

2016-05-17 Thread Jesse Gross
is number of packet parameter > as a reference. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3 07/17] dpif-netdev: Fix memory leak in tunnel header pop action.

2016-05-17 Thread Jesse Gross
On Tue, May 10, 2016 at 10:30 AM, Pravin B Shelar wrote: > The tunnel header pop action can leak batch of packet > in case of error. Following patch fixex the error code path. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___

Re: [ovs-dev] [PATCH v3 08/17] dpif-netdev: Fix memory leak in tunnel header push action.

2016-05-17 Thread Jesse Gross
On Tue, May 10, 2016 at 10:30 AM, Pravin B Shelar wrote: > in case of error from netdev_push_header() batch of packets was not > freed. Following patch fixes this issue. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev

Re: [ovs-dev] [PATCH v3 12/17] netdev-vport: Introduce ip_build_header()

2016-05-17 Thread Jesse Gross
On Tue, May 10, 2016 at 10:30 AM, Pravin B Shelar wrote: > This function can be used to build varius tunnel headers. "various" > diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c > index 2e181f2..375713a 100644 > --- a/lib/netdev-native-tnl.c > +++ b/lib/netdev-native-tnl.c > +eth_b

Re: [ovs-dev] [PATCH] Add Geneve support on Windows datapath.

2016-05-17 Thread Jesse Gross
On Tue, May 17, 2016 at 5:02 PM, Yin Lin wrote: > diff --git a/datapath-windows/ovsext/Geneve.c > b/datapath-windows/ovsext/Geneve.c > new file mode 100644 > index 000..d3eed86 > --- /dev/null > +++ b/datapath-windows/ovsext/Geneve.c > +NDIS_STATUS OvsEncapGeneve(POVS_VPORT_ENTRY vport, > +

Re: [ovs-dev] [PATCH] Add Geneve support on Windows datapath.

2016-05-17 Thread Jesse Gross
On Tue, May 17, 2016 at 8:10 PM, Yin Lin wrote: > Thanks Jesse so much for the reviewing the patch! This is my first attempt to > contribute to the ovs community and your prompt reply gave me so much > encouragement and inspiration. Welcome! > I am not sure why Windows kernel doesn't compute U

  1   2   3   4   5   6   7   8   9   10   >