On Tue, Sep 2, 2014 at 8:51 PM, Ben Pfaff <b...@nicira.com> wrote: > On Tue, Sep 02, 2014 at 06:43:31PM -0700, Jesse Gross wrote: >> On Tue, Sep 2, 2014 at 6:23 PM, Ben Pfaff <b...@nicira.com> wrote: >> > On Tue, Sep 02, 2014 at 06:00:08PM -0700, Jesse Gross wrote: >> >> The system defined ICMPv6 header doesn't have sparse annotation, >> >> so this adds a definition so that endianness can be checked. >> >> >> >> Reported-by: Alex Wang <al...@nicira.com> >> >> Signed-off-by: Jesse Gross <je...@nicira.com> >> > >> > In some cases we've avoided warnings on system types by replacing that >> > type in a header in include/sparse. Did you consider that approach >> > here? >> >> I thought about it but didn't go that direction since I think that we >> might want to add more members similar to what was done for ICMP for >> IPv4 (although it isn't actually needed yet). But it could go either >> way. > > OK, that's fine with me now that I know you were aware of the > possibility.
Alex told me that he was happy with the patch and it fixed the problem for him, so I pushed this. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
