[ovs-dev] [PATCH] ovn-tutorial: Update expected output from show commands

Highlighted requirement on how a fresh sandbox is expected before doing each of the tutorial sections. Also added some mentioning of the gdb flags available for debugging ovn programs. Signed-off-by: Flavio Fernandes --- tutorial/OVN-Tutorial.md | 171

[ovs-dev] [PATCH] ovn-tutorial: Update expected output from show commands

fresh sandbox. Flavio Fernandes (1): ovn-tutorial: Update expected output from show commands tutorial/OVN-Tutorial.md | 171 +-- 1 file changed, 121 insertions(+), 50 deletions(-) -- 1.9.1 ___ dev mailing

[ovs-dev] [PATCH 2/3] ovn test: remove check for non-existing bridge in hv3

In OVN vtep test, the network topology is like this: hv1---\ >-- [net1] <-- vtep --> [net2] <-- hv3 hv2---/ The logical switch lsw0 created in this test has no logical port corresponding to hv3, so that hypervisor does not have any bridges created by OVN. With this test change, we ar

[ovs-dev] [PATCH 0/3] Minor ovn test fixes

Fixing some issues I found in the ovn test suite. Among them, I found a 'show br-int' that was not needed, and some consistency in how ovs-ofctl is invoked. Flavio Fernandes (3): ovn test: improve vtep test description and fix typo ovn test: remove check for non-existing bridge in

[ovs-dev] [PATCH 1/3] ovn test: improve vtep test description and fix typo

- Add vtep as keyword and in description of test 2028 - Fix minor typo: 'information' --- tests/ovn.at | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index cc5c468..75f7441 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -774,7 +774,7 @@ test_a

[ovs-dev] [PATCH 3/3] ovn test: add '-O OpenFlow13' to ovs-ofctl

Make test calls to ovs-ofctl in test use the protocol parameter '-O OpenFlow13', so it is consistent with the existing dump-flows invocations. --- tests/ovn.at | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 1127cea..e6ac1d7 100644 -

[ovs-dev] [PATCH v2 2/3] ovn test: remove check for non-existing bridge in hv3

t change, we are replacing the 'show br-int' with a check to ensure that 'br-int' is not present. The improper check for br-int in hv3 appears to have been inadvertently merged via this commit: https://github.com/openvswitch/ovs/commit/8dab1022 Changes v1->v2: * Add S

[ovs-dev] [PATCH v2 3/3] ovn test: add '-O OpenFlow13' to ovs-ofctl

Make test calls to ovs-ofctl in test use the protocol parameter '-O OpenFlow13', so it is consistent with the existing dump-flows invocations. Changes v1->v2: * Add Signed-off-by Signed-off-by: Flavio Fernandes --- tests/ovn.at | 10 +- 1 file changed, 5 insertions(+)

[ovs-dev] [PATCH v2 1/3] ovn test: improve vtep test description and fix typo

- Add vtep as keyword and in description of test 2028 - Fix minor typo: 'information' Changes v1->v2: * Add Signed-off-by Signed-off-by: Flavio Fernandes --- tests/ovn.at | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index cc5

[ovs-dev] [PATCH v2 0/3] Minor ovn test fixes

Fixing some issues I found in the ovn test suite. Among them, I found a 'show br-int' that was not needed, and some consistency in how ovs-ofctl is invoked. Changes v1->v2: * Add Signed-off-by Flavio Fernandes (3): ovn test: improve vtep test description and fix typo ovn test:

[ovs-dev] [PATCH] tests: enable color output for unit tests, if available

Reference thread in mailing list: http://openvswitch.org/pipermail/discuss/2016-May/021339.html Signed-off-by: Flavio Fernandes --- tests/system-kmod-testsuite.at | 2 ++ tests/system-userspace-testsuite.at | 2 ++ tests/testsuite.at | 2 ++ 3 files changed, 6 insertions

[ovs-dev] [PATCH] ovn-northd: logical router icmp response should not care about inport

] vm should be able to ping , even though it is an address of a subnet that can only be reached through L3 routing. Reference to the mailing list thread: http://openvswitch.org/pipermail/discuss/2016-May/021172.html Signed-off-by: Flavio Fernandes --- TO BE IMPLEMENTED: Unit tests

[ovs-dev] [PATCH v2] ovn-northd: logical router icmp response should not care about inport

& ... <= priority 90 "ip.ttl > 1 && (ip4.dst == "IP_FMT" || ip4.dst == "IP_FMT") && ... <= priority 90-X Signed-off-by: Flavio Fernandes --- ovn/northd/ovn-northd.c | 8 ++- tests/ovn.at| 173

[ovs-dev] [PATCH v3] ovn-northd: logical router icmp response should not care about inport

ip4.dst == "IP_FMT") && " ... "!(inport != %s && ip.ttl == {0,1}) && (ip4.dst == "IP_FMT" || ip4.dst == "IP_FMT") && " ... "(inport == %s || !(ip.ttl == {0, 1})) && (ip4.dst == "IP_FMT" || ip4.dst

[ovs-dev] [PATCH v4] ovn-northd: logical router icmp response should not care about inport

review feedback from Russell Bryant - Fix comment section on how vm can ping ip2.2 Changes v3->v4: - Rebase - Resolve open discussion on ttl: it is a non-issue Thanks Ben P and Darrell B! Ref: http://openvswitch.org/pipermail/dev/2016-May/071773.html Signed-off-by: Flavio

[ovs-dev] [PATCH v5] ovn-northd: logical router icmp response should not care about inport

base - Fix typos and inconsistencies in ovn icmp test Signed-off-by: Flavio Fernandes --- ovn/northd/ovn-northd.c | 9 ++- tests/ovn.at| 175 2 files changed, 181 insertions(+), 3 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/ov

Re: [ovs-dev] [ovs-dev,ovn-controller] Physical: persist tunnels

render ovn-controller in compute nodes to peg the cpu at 100% before the changes. More info on _easily_ deploying this cluster is available here: https://github.com/flavio-fernandes/just-ovn-nodes/blob/master/README.md > [1] http://openvswitch.org/pipermail/dev/2016-July/076058.html > >

[ovs-dev] [PATCH] ovn-northd: no logical router icmp response for directed broadcasts

/021619.html This is a proposal for using choice B in the mail discussion; where icmp queries to broadcast are simply not responded by the logical router. Signed-off-by: Flavio Fernandes --- ovn/northd/ovn-northd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ovn/northd

[ovs-dev] [PATCH] ovn-northd: fix logical router icmp response for directed broadcasts

may be no real concern for a potential DOS attack scenario. Signed-off-by: Flavio Fernandes --- ovn/northd/ovn-northd.c | 28 +--- tests/ovn.at| 39 +++ 2 files changed, 52 insertions(+), 15 deletions(-) diff --git a/ovn

[ovs-dev] [PATCH v2] ovn-northd: no logical router icmp response for directed broadcasts

broadcast are simply not responded by the logical router. Reported-at: http://openvswitch.org/pipermail/discuss/2016-June/021619.html Signed-off-by: Flavio Fernandes --- Changes v1->v2: - Rebase - Use Reported-at label for proper referencing ovn/northd/ovn-northd.c | 5 ++--- 1 file changed

[ovs-dev] [PATCH v3] ovn-northd: no logical router icmp response for directed broadcasts

broadcast are simply not responded by the logical router. Reported-at: http://openvswitch.org/pipermail/discuss/2016-June/021619.html Signed-off-by: Flavio Fernandes --- Changes v1->v2: - Rebase. - Use Reported-at label for proper referencing. Changes v2->v3: - Rebase. - Update documentat

[ovs-dev] [PATCH] ofproto-dpif.at: Fix typo

Nitpick: correct spelling of the word 'dropped' The typo appears to have been introduced in this changeset: http://openvswitch.org/pipermail/dev/2014-March/037433.html Signed-off-by: Flavio Fernandes --- tests/ofproto-dpif.at | 8 1 file changed, 4 insertions(+), 4 deletion

Re: [ovs-dev] [PATCH 1/3] OVN-Tutorial: Replace example with ASCII quotes.

> On Aug 22, 2016, at 2:39 PM, Lance Richardson wrote: > >> From: "Justin Pettit" >> To: dev@openvswitch.org >> Sent: Thursday, August 11, 2016 2:09:12 AM >> Subject: [ovs-dev] [PATCH 1/3] OVN-Tutorial: Replace example with ASCII >> quotes. >> >> The "--ovn" argument for SANDBOXFLAGS use

[ovs-dev] [PATCH] ovn: Replace tabs with spaces and clean up alignment in unit tests.

Signed-off-by: Flavio Fernandes --- tests/ovn.at | 154 +-- 1 file changed, 77 insertions(+), 77 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 216bb07..e4f6c30 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -18,9 +18,9

[ovs-dev] [PATCH v1] ovn: ensure datapath removal is proper

Adding a unit test in ovn.at, to exercise the cleanup of OF rules related to a logical datapath, when a logical switch is removed. Reported-by: Guru Shetty Reported-at: http://openvswitch.org/pipermail/discuss/2016-August/022478.html Signed-off-by: Flavio Fernandes --- NOTE: This test is

[ovs-dev] [PATCH v2] ovn: Replace tabs with spaces and clean up alignment in unit tests.

Signed-off-by: Flavio Fernandes --- v1->v2: fix indentation issues introduced in v1 tests/ovn.at | 154 +-- 1 file changed, 77 insertions(+), 77 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 216bb07..902f121 100644 --

[ovs-dev] [PATCH v3] ovn: Replace tabs with spaces and clean up alignment in unit tests.

Signed-off-by: Flavio Fernandes --- v1->v2: fix indentation issues introduced in v1 v2->v3: fix indentation issue introduced in v1 tests/ovn.at | 154 +-- 1 file changed, 77 insertions(+), 77 deletions(-) diff --git a/tests/ovn.at b

[ovs-dev] [PATCH v4] ovn: Replace tabs with spaces and clean up alignment in unit tests.

Signed-off-by: Flavio Fernandes --- v1->v2: fix indentation issues introduced in v1 v2->v3: noop :P v3->v4: fix indentation issue introduced in v1, this time for real tests/ovn.at | 154 +-- 1 file changed, 77 insertions(+), 77

[ovs-dev] [PATCH] ovn-trace: add generated files to .gitignore.

Signed-off-by: Flavio Fernandes --- ovn/utilities/.gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ovn/utilities/.gitignore b/ovn/utilities/.gitignore index 5832b6c..2c06825 100644 --- a/ovn/utilities/.gitignore +++ b/ovn/utilities/.gitignore @@ -3,3 +3,5 @@ /ovn-nbctl.8 /ovn

[ovs-dev] [PATCH v5] ovn: Replace tabs with spaces and clean up alignment in unit tests.

Signed-off-by: Flavio Fernandes --- v1->v2: fix indentation issues introduced in v1 v2->v3: noop :P v3->v4: fix indentation issue introduced in v1, this time for real v4->v5: fix yet another -- and hopefully final?!? -- round of indentation issues tests/

Re: [ovs-dev] [RFC] ovn: minimize the impact of a compromised chassis

> On Aug 23, 2016, at 5:34 PM, Darrell Ball wrote: > > On Tue, Aug 23, 2016 at 2:20 PM, Russell Bryant > wrote: > >> >> >> On Tue, Aug 23, 2016 at 5:05 PM, Darrell Ball wrote: >> >>> >>> >>> On Mon, Aug 22, 2016 at 1:08 PM, Lance Richardson >>> wrote: >>> >>>

[ovs-dev] [PATCH v6] ovn: Replace tabs with spaces and clean up alignment in unit tests.

Signed-off-by: Flavio Fernandes --- v1->v2: fix indentation issues introduced in v1 v2->v3: noop :P v3->v4: fix indentation issue introduced in v1, this time for real v4->v5: fix yet another -- and hopefully final?!? -- round of indentation issues v5->v6: fix space character add

Re: [ovs-dev] [PATCH v4] ovn-controller: Back out incremental processing

of OF flows, > logical ports, multicast groups, all_lports, local and patched > datapaths > > [1] http://openvswitch.org/pipermail/dev/2016-August/078272.html > > Signed-off-by: Ryan Moats > Co-authored-by: Guru Shetty Acked-by: Flavio Fernandes Tested-by: Flavio Fernandes &

Re: [ovs-dev] [PATCH] Close memory leak when processing S_TLV_TABLE_REQUESTED.

t; by 0x406C8F: main (ovn-controller.c:439) > > Signed-off-by: Ryan Moats Acked-by: Flavio Fernandes > --- > ovn/controller/ofctrl.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/ovn/controller/ofctrl.c b/ovn/controller/ofctrl.c > index d8e111d..0493e0d

Re: [ovs-dev] [PATCH] Fix leak in patched_datapaths processing.

> On Sep 1, 2016, at 10:29 AM, Ryan Moats wrote: > > When unpersisting patch_datapaths, missed that the key field > needed to be freed to avoid a memory leak. This patch fixes > same. > > Signed-off-by: Ryan Moats Acked-by: Flavio Fernandes > --- > ovn/cont

Re: [ovs-dev] [PATCH] Fix leak in patched_datapaths processing.

> On Sep 1, 2016, at 12:43 PM, Ben Pfaff wrote: > > On Thu, Sep 01, 2016 at 09:29:24AM -0500, Ryan Moats wrote: >> When unpersisting patch_datapaths, missed that the key field >> needed to be freed to avoid a memory leak. This patch fixes >> same. >> >> Signed-off-by: Ryan Moats > > I don't

Re: [ovs-dev] ovn-controller: Fix leak in patched_datapaths processing.

> On Sep 1, 2016, at 12:42 PM, Ben Pfaff wrote: > > Nothing freed 'key', which was dynamically allocated. This commit changes > 'key' so that it is no longer dynamically allocated. > > Reported-by: Ryan Moats > Signed-off-by: Ben Pfaff Acked-by: F

Re: [ovs-dev] [PATCH] ovn-controller: Fix memory leak in recv_S_TLV_TABLE_REQUESTED().

makes it possible to catch all paths out of the function so that 'reply' > can be freed in one place. > +1 for moving it into a function and calling "ofputil_uninit_tlv_table(&reply.mappings);" in a single place! > Reported-by: Ryan Moats > Signed-off-by: Be

[ovs-dev] [PATCH v2] ovn: ensure datapath removal is proper

Adding a unit test in ovn.at, to exercise the cleanup of OF rules related to a logical datapath, when a logical switch is removed. Reported-by: Guru Shetty Reported-at: http://openvswitch.org/pipermail/discuss/2016-August/022478.html Signed-off-by: Flavio Fernandes --- v1->v2: rebase and ens

Re: [ovs-dev] [PATCH v2] ovn: ensure datapath removal is proper

> On Sep 8, 2016, at 4:31 PM, Russell Bryant wrote: > > > > On Thu, Sep 8, 2016 at 3:13 PM, Flavio Fernandes wrote: > Adding a unit test in ovn.at, to exercise the cleanup of > OF rules related to a logical datapath, when a logical > switch is removed. >

[ovs-dev] [PATCH v3] ovn: ensure datapath removal is proper

Adding a unit test in ovn.at, to exercise the cleanup of OF rules related to a logical datapath, when a logical switch is removed. Reported-by: Guru Shetty Reported-at: http://openvswitch.org/pipermail/discuss/2016-August/022478.html Signed-off-by: Flavio Fernandes --- v1->v2: rebase and ens

Re: [ovs-dev] [PATCH] ofctrl: Fix logic for mff_ovn_geneve.

> On Sep 9, 2016, at 8:38 AM, Gurucharan Shetty wrote: > > Fixes: 7fa39c6b9376e99 ("Fix memory leak in recv_S_TLV_TABLE_REQUESTED().") > Signed-off-by: Gurucharan Shetty Acked-by: Flavio Fernandes > --- > ovn/controller/ofctrl.c | 2 +- > 1 file chan

Re: [ovs-dev] [PATCH 3/3] ovsdb: Fix replication memory leak.

> Fixes: 60e0cd041958 ("ovsdb: Replication usability improvements") > Signed-off-by: Joe Stringer Acked-by: Flavio Fernandes > --- > This also affects branch-2.6. > --- > ovsdb/replication.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/ovsdb/

[ovs-dev] [PATCH v0] lib: Create $(sysconfdir)/openvswitch upon install

-September/TBD.html Fixes: f973f2af2fd4 ("Make the location of the database separately configurable.") Signed-off-by: Flavio Fernandes --- lib/automake.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/automake.mk b/lib/automake.mk index b00e90f..e9d508a 100644 --- a/lib/a

[ovs-dev] [PATCH v1] lib: Create $(sysconfdir)/openvswitch upon install

scuss/2016-September/022673.html Fixes: f973f2af2fd4 ("Make the location of the database separately configurable.") Signed-off-by: Flavio Fernandes --- v0->v1: fix Reported-at tag lib/automake.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/automake.mk b/lib/automake.mk index

[ovs-dev] [PATCH v4] ovn: ensure datapath removal is proper

Adding a unit test in ovn.at, to exercise the cleanup of OF rules related to a logical datapath, when a logical switch is removed. Reported-by: Guru Shetty Reported-at: http://openvswitch.org/pipermail/discuss/2016-August/022478.html Signed-off-by: Flavio Fernandes --- v1->v2: rebase and ens

Re: [ovs-dev] [PATCH v9] ovn-nbctl: Add LB commands.

> On Sep 29, 2016, at 5:43 AM, nickcooper-zhangtonghao > wrote: > > This patch provides the command line to create a load balancer. > You can create a load balancer independently and add it to multiple > switches or routers. A single load balancer can have multiple vips. > Add a name column for

Re: [ovs-dev] [PATCH 1/3] tests: Use standard -q option to grep in place of GNU --quiet extension.

> On Sep 29, 2016, at 5:41 PM, Ben Pfaff wrote: > > Reported-by: Stuart Cardall > Reported-at: > http://openvswitch.org/pipermail/discuss/2016-September/022803.html > Signed-off-by: Ben Pfaff Acked-by: Flavio Fernandes > --- > AUTHORS | 1 + > tests/ovn.at

[ovs-dev] [PATCH v1] debian: Include ovn-trace in ovn-common package

Include the ovn-trace binary and it's man page in ovn-common package Fixes: 4acd1e87a8bf ("ovn-trace: New utility.") Fixes: f448e5a4bb1f ("rhel: Include ovn-trace in ovn-common package") Signed-off-by: Flavio Fernandes --- debian/ovn-common.install | 1 + debian/ovn

[ovs-dev] [PATCH] ovn: fix ovn-northd leak in build_acls

Avoid leak due to missing ds_destroy in build_acl for non-stateful drop action. Found via inspection. I do not know that this fixes a common leak. Signed-off-by: Flavio Fernandes --- ovn/northd/ovn-northd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ovn/northd/ovn-northd.c b/ovn

Re: [ovs-dev] [PATCH 3/3] ovn.at: Fix races

On Thu, Nov 26, 2015 at 4:41 AM, YAMAMOTO Takashi wrote: > These tests are racy as nothing prevents packet re-ordering. > Fix them by sorting outputs before comparing. > > Signed-off-by: YAMAMOTO Takashi > Reviewed-by: Flavio Fernandes

Re: [ovs-dev] [PATCH 3/3] ovn.at: Fix races

On Wed, Dec 2, 2015 at 11:03 PM, Takashi Yamamoto wrote: > hi, > > On Thu, Dec 3, 2015 at 3:26 AM, Flavio Fernandes > wrote: > > On Thu, Nov 26, 2015 at 4:41 AM, YAMAMOTO Takashi > > > wrote: > > > >> These tests are racy as nothing prevents packet re-