Sorry for the late reply. I missed this sub-thread somehow.
On Thu, Jul 14, 2016 at 09:38:09AM +0800, Xiao Liang wrote:
> As far as I know, Eric and Tom are working on the kernel patch set and
> would submit a new version to net-next. Kernel patches usually go to
> netdev first and then backported
On Sun, Jul 03, 2016 at 08:47:06AM +0800, Xiao Liang wrote:
> diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
> index 997cc15..d8eac93 100644
> --- a/lib/ofp-actions.c
> +++ b/lib/ofp-actions.c
> @@ -1653,21 +1654,19 @@ parse_PUSH_VLAN(char *arg, struct ofpbuf *ofpacts,
> return error;
#x27;s most recent series and my yet
to be posted kernel series.
Eric Garver (5):
check-kernel: Add macros to check for and test 802.1ad.
check-kernel: 802.1ad: Add datapath ping tests for CVLANs.
check-kernel: 802.1ad: Add conntrack ping tests for CVLANs.
check-kernel: 802.1ad: Add push/pop
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 63 +
1 file changed, 63 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 1cdc2d2e0f4e..4f72292e5490 100644
--- a/tests/system-traffic.at
+++ b/tests/system
Test case to push and pop outer 802.1ad tag between two "customer"
bridges.
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 54 +
1 file changed, 54 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffi
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 106
1 file changed, 106 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 4f72292e5490..817eca1d5fea 100644
--- a/tests/system-traffic.at
+++ b/tests
Add macros OVS_CHECK_8021AD(), ADD_SVLAN() and ADD_CVLAN().
Signed-off-by: Eric Garver
---
tests/system-common-macros.at | 29 -
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at
index
Test case for dot1q-tunnel between two "customer" bridges.
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 45 +
1 file changed, 45 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 3b51d0f91607..d2
Hi Joe,
Thanks for providing feedback.
On Fri, Jul 29, 2016 at 11:14:36AM -0700, Joe Stringer wrote:
> On 28 July 2016 at 10:54, Eric Garver wrote:
> > This series adds 6 test cases to the "check-kernel" make target for
> > 802.1ad. It is meant as a counterpart to t
On Fri, Jul 29, 2016 at 11:17:03AM -0700, Joe Stringer wrote:
> On 28 July 2016 at 10:54, Eric Garver wrote:
> > Add macros OVS_CHECK_8021AD(), ADD_SVLAN() and ADD_CVLAN().
> >
> > Signed-off-by: Eric Garver
> > ---
> > tests/system-common-macros.at | 29 +++
On Fri, Jul 29, 2016 at 11:26:30AM -0700, Joe Stringer wrote:
> On 28 July 2016 at 10:54, Eric Garver wrote:
> > Signed-off-by: Eric Garver
>
> Hmm, on my Ubuntu 14.04 setup these tests fail with kernel 3.13.0-91,
> bupass with kernel 3.19.0-58, but not 3.13.0-91. I guess
On Fri, Jul 29, 2016 at 11:34:24AM -0700, Joe Stringer wrote:
> On 29 July 2016 at 11:30, Joe Stringer wrote:
> > On 28 July 2016 at 10:54, Eric Garver wrote:
> >> Signed-off-by: Eric Garver
> >
> > Can you describe your setup? (distro, kernel)
RHEL-7.2
Upstream
On Fri, Jul 29, 2016 at 01:50:58PM -0700, Joe Stringer wrote:
> On 29 July 2016 at 13:11, Eric Garver wrote:
> > Hi Joe,
> >
> > Thanks for providing feedback.
> >
> > On Fri, Jul 29, 2016 at 11:14:36AM -0700, Joe Stringer wrote:
> >> On 28 July 2016
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 63 +
1 file changed, 63 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 1cdc2d2e0f4e..4f72292e5490 100644
--- a/tests/system-traffic.at
+++ b/tests/system
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 106
1 file changed, 106 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 4f72292e5490..817eca1d5fea 100644
--- a/tests/system-traffic.at
+++ b/tests
Test case for dot1q-tunnel between two "customer" bridges.
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 45 +
1 file changed, 45 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 3b51d0f91607..d2
#x27;s most recent series and my yet
to be posted kernel series.
Update v2:
- Properly skip tests on older versions of OVS and kernel
- Set CVLAN mtu to 1496 to allow tests to pass on older kernels
Eric Garver (5):
check-kernel: Add macros to check for and test 802.1ad.
check-kernel: 802.1ad
Add macros OVS_CHECK_8021AD(), ADD_SVLAN() and ADD_CVLAN().
Signed-off-by: Eric Garver
---
tests/system-common-macros.at | 30 +-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at
index
Test case to push and pop outer 802.1ad tag between two "customer"
bridges.
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 54 +
1 file changed, 54 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffi
On Sun, Jul 31, 2016 at 08:22:47AM +0800, Xiao Liang wrote:
> Thanks! I'm working on code changes according to your comments. I
> think we need more discussion about the ethertype matching. Please see
> inline.
Can we reach an agreement on the ethertype matching? It has implications
on the kernel
>
> NS_CHECK_EXEC([at_ns0], [ping6 -q -c 3 -i 0.3 -w 2 fc00:1::2 |
> FORMAT_PING], [0], [dnl
> 3 packets transmitted, 3 received, 0% packet loss, time 0ms
>
>
>
> On 2 August 2016 at 08:20, Eric Garver wrote:
> > This series adds 6 test cases to the "chec
Hi,
See two replies below.
Thanks again!
On Fri, Aug 05, 2016 at 10:03:24AM -0400, Eric Garver wrote:
> Joe,
>
> Thanks for further review. I'll add the changes you have below to the
> series.
>
> I'll take a look at the "check-system-userspace" failur
On Wed, Aug 10, 2016 at 04:54:08PM -0700, Joe Stringer wrote:
> On 10 August 2016 at 14:55, Eric Garver wrote:
> > Hi,
> >
> > See two replies below.
> >
> > Thanks again!
> >
> > On Fri, Aug 05, 2016 at 10:03:24AM -0400, Eric Garver wrote:
> >&
Hi Xiao,
Thanks for the series. One patch comment below.
General comments:
1) Various places use VLAN_CFI to indicate presence of a VLAN tag
(many checks for tci != 0, because CFI bit set). Since we're now
tracking the TPID would it be more appropriate to instead us
On Sat, Aug 06, 2016 at 08:04:44PM -0700, Ben Pfaff wrote:
> On Sun, Aug 07, 2016 at 10:54:00AM +0800, Xiao Liang wrote:
> > On Thu, Aug 4, 2016 at 6:07 AM, Ben Pfaff wrote:
> > > Thanks for the replies, I have some further responses below.
> > >
> > > On Sun, Jul 31, 2016 at 08:22:47AM +0800, Xia
On Fri, Aug 19, 2016 at 01:24:10PM -0700, Ben Pfaff wrote:
> On Fri, Aug 19, 2016 at 04:19:31PM -0400, Eric Garver wrote:
> > On Sat, Aug 06, 2016 at 08:04:44PM -0700, Ben Pfaff wrote:
> > > On Sun, Aug 07, 2016 at 10:54:00AM +0800, Xiao Liang wrote:
> > > > On Th
Subject: Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ
> > tunneling)
> >
> > On Fri, Aug 19, 2016 at 04:42:18PM -0400, Eric Garver wrote:
> > > On Fri, Aug 19, 2016 at 01:24:10PM -0700, Ben Pfaff wrote:
> > > > On Fri, Aug 19, 2016 at 04:19:
From: Thomas F Herbert
openvswitch: Add support for 8021.AD
Change the description of the VLAN tpid field.
Signed-off-by: Thomas F Herbert
---
include/uapi/linux/openvswitch.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/linux/openvswitch.
. This patch series has been tested using the most recent version of
userspace (v3) and tests (v2).
v21 changes:
- Fix (and simplify) netlink attribute parsing
- re-add handling of truncated VLAN tags
- fix if/else dangling assignment in {push,pop}_vlan()
- simplify parse_vlan()
Eric
Signed-off-by: Eric Garver
---
include/linux/if_vlan.h | 33 +++--
1 file changed, 23 insertions(+), 10 deletions(-)
diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
index 49d4aef1f789..3319d97d789d 100644
--- a/include/linux/if_vlan.h
+++ b/include
F Herbert's original v20 patch. I made some
small clean ups and bug fixes.
Signed-off-by: Thomas F Herbert
Signed-off-by: Eric Garver
---
net/openvswitch/actions.c | 16 +--
net/openvswitch/flow.c | 64
net/openvswitch/flow.h | 8 +-
net/openvs
With 802.1ad support these are parsed and set upfront by
parse_vlan_from_nlattrs() before ovs_key_from_nlattrs() is ever called.
As such we should never see a VLAN attribute in ovs_key_from_nlattrs().
Signed-off-by: Eric Garver
---
net/openvswitch/flow_netlink.c | 19 +--
1 file
On Fri, Sep 02, 2016 at 02:42:41PM -0700, pravin shelar wrote:
> On Thu, Sep 1, 2016 at 1:45 PM, Eric Garver wrote:
> > With 802.1ad support these are parsed and set upfront by
> > parse_vlan_from_nlattrs() before ovs_key_from_nlattrs() is ever called.
> > As such we sh
Pravin,
Thanks for the feedback. Some replies below.
Thanks.
Eric.
On Fri, Sep 02, 2016 at 02:42:30PM -0700, pravin shelar wrote:
> On Thu, Sep 1, 2016 at 1:45 PM, Eric Garver wrote:
> > Add support for 802.1ad including the ability to push and pop double
> > tagged vlans.
On Sun, Sep 04, 2016 at 01:05:46PM +0200, Jiri Benc wrote:
> On Sat, 3 Sep 2016 13:30:12 -0400, Eric Garver wrote:
> > Would a BUG_ON(!(encap && in_encap)) be better?
>
> Please don't crash the kernel for something that could very well
> continue without problem
From: Thomas F Herbert
openvswitch: Add support for 8021.AD
Change the description of the VLAN tpid field.
Signed-off-by: Thomas F Herbert
---
include/uapi/linux/openvswitch.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/linux/openvswitch.
Signed-off-by: Eric Garver
---
include/linux/if_vlan.h | 33 +++--
1 file changed, 23 insertions(+), 10 deletions(-)
diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
index 49d4aef1f789..3319d97d789d 100644
--- a/include/linux/if_vlan.h
+++ b/include
F Herbert's original v20 patch. I made some
small clean ups and bug fixes.
Signed-off-by: Thomas F Herbert
Signed-off-by: Eric Garver
---
net/openvswitch/actions.c | 16 ++-
net/openvswitch/flow.c | 65 ++---
net/openvswitch/flow.h | 8 +-
net/openvs
- fix if/else dangling assignment in {push,pop}_vlan()
- simplify parse_vlan()
Eric Garver (2):
vlan: Check for vlan ethernet types for 8021.q or 802.1ad
openvswitch: 802.1AD Flow handling, actions, vlan parsing, netlink
attributes
Thomas F Herbert (1):
openvswitch: 802.1ad uapi
Add macros OVS_CHECK_8021AD(), ADD_SVLAN() and ADD_CVLAN().
Signed-off-by: Eric Garver
---
tests/system-common-macros.at | 32 +++-
1 file changed, 31 insertions(+), 1 deletion(-)
diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at
index
0 tag test.
- Specify cvlans for dot1q-tunnel test and verify other VLANs filtered
- Drop CVLAN MTU to 1492, SVLAN to 1496
- Fix passing sed filters for userspace datapath tests.
v2:
- Properly skip tests on older versions of OVS and kernel
- Set CVLAN mtu to 1496 to allow tests to pass on older ker
Passing sed arguments to OVS_TRAFFIC_VSWITCHD_STOP() was being ignored
for check-system-userspace. This is useful to selective ignore log
messages.
Signed-off-by: Eric Garver
---
tests/system-userspace-macros.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/system
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 62 +
1 file changed, 62 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 4dabd90356a1..83c7b8a2f4e5 100644
--- a/tests/system-traffic.at
+++ b/tests/system
Verify that vlan_limit works as expected and preserves legacy dl_type
matching behavior.
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 35 +++
1 file changed, 35 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index
Test case for dot1q-tunnel between two "customer" bridges.
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 63 +
1 file changed, 63 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index ce
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 107
1 file changed, 107 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 83c7b8a2f4e5..bb0cb02804f9 100644
--- a/tests/system-traffic.at
+++ b/tests
Two test cases to push and pop an outer tag between two "customer"
bridges. One to push/pop 0x88a8. One to push/pop a second 0x8100.
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 112
1 file changed, 112 insertions(+)
di
On Thu, Sep 22, 2016 at 06:48:09PM -0700, Joe Stringer wrote:
> On 14 September 2016 at 17:26, Eric Garver wrote:
> > Signed-off-by: Eric Garver
>
> Hi Eric,
>
> I tried this series again on a variety of kernels and these initial
> ping over cvlan tests are failing fo
42AM -0400, Eric Garver wrote:
> On Thu, Sep 22, 2016 at 06:48:09PM -0700, Joe Stringer wrote:
> > On 14 September 2016 at 17:26, Eric Garver wrote:
> > > Signed-off-by: Eric Garver
> >
> > Hi Eric,
> >
> > I tried this series again on a variety of ker
t use TP_STATUS_VLAN_TPID_VALID,
which is kernels < 3.14.
Signed-off-by: Eric Garver
---
lib/netdev-linux.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index ef8471995a3d..0f929c9cfc3b 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev
Test case for dot1q-tunnel between two "customer" bridges.
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 63 +
1 file changed, 63 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 4d
Passing sed arguments to OVS_TRAFFIC_VSWITCHD_STOP() was being ignored
for check-system-userspace. This is useful to selective ignore log
messages.
Signed-off-by: Eric Garver
---
tests/system-userspace-macros.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/system
Verify that vlan_limit works as expected and preserves legacy dl_type
matching behavior.
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 36
1 file changed, 36 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index
N MTU to 1492, SVLAN to 1496
- Fix passing sed filters for userspace datapath tests.
v2:
- Properly skip tests on older versions of OVS and kernel
- Set CVLAN mtu to 1496 to allow tests to pass on older kernels
Eric Garver (7):
system-userspace-macros: allow passing sed args to
OVS_TRAFFIC_VSW
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 107
1 file changed, 107 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 83c7b8a2f4e5..bb0cb02804f9 100644
--- a/tests/system-traffic.at
+++ b/tests
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 62 +
1 file changed, 62 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 4dabd90356a1..83c7b8a2f4e5 100644
--- a/tests/system-traffic.at
+++ b/tests/system
Add macros OVS_CHECK_8021AD(), ADD_SVLAN() and ADD_CVLAN().
Signed-off-by: Eric Garver
---
tests/system-common-macros.at | 32 +++-
1 file changed, 31 insertions(+), 1 deletion(-)
diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at
index
Two test cases to push and pop an outer tag between two "customer"
bridges. One to push/pop 0x88a8. One to push/pop a second 0x8100.
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 112
1 file changed, 112 insertions(+)
di
On Mon, Sep 26, 2016 at 11:52:22AM +0100, Dermot Tynan wrote:
> In order to support VLAN transparency for Helion VMs, we've successfully
> back-ported Xiao Liang's QinQ patches to OvS 2.5 and we are now extensively
> testing this code against our Helion OpenStack (HOS) 4.0 release.We'll also
> begi
On Mon, Oct 03, 2016 at 01:16:55PM -0700, Ben Pfaff wrote:
> On Fri, Sep 23, 2016 at 03:15:27PM -0400, Eric Garver wrote:
> > We need to check if a packet is double tagged. If so make sure to push
> > 0x88a8 instead of 0x8100. Without this a simple port redirect of 802.1ad
>
t use TP_STATUS_VLAN_TPID_VALID,
which is kernels < 3.14.
Signed-off-by: Eric Garver
---
v2:
- move double tag check to after retval length check
- variable renames
---
lib/netdev-linux.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux
On Mon, Oct 17, 2016 at 05:17:44PM -0700, Joe Stringer wrote:
> On 23 September 2016 at 12:16, Eric Garver wrote:
> > This series adds 802.1ad test cases for the check-* make targets. It is
> > meant as a counterpart to the 802.1ad work currently going on and being
> > disc
Hi Ben and Xiao,
One comment below.
On Mon, Oct 17, 2016 at 11:15:28AM +0800, Xiao Liang wrote:
> Hi Ben,
>
> Please see inline.
>
> And another question:
> In datapath/README.md:
> - If the userspace flow key includes more fields than the
> kernel's, for example if userspace decoded an I
63 matches
Mail list logo
