Re: [ovs-dev] [PATCH] datapath: Kernel flow metadata parsing should be less restrictive

2011-11-09 Thread Ansis Atteka
On Tue, Nov 8, 2011 at 4:02 PM, Jesse Gross wrote: > On Tue, Nov 8, 2011 at 3:11 PM, Ansis Atteka wrote: > > The function flow_metadata_from_nlattrs() is very restrictive > > about the ordering and type of metadata attributes that it receives. > > T

[ovs-dev] [PATCH] datapath: Kernel flow metadata parsing should be less restrictive

2011-11-09 Thread Ansis Atteka
. Issue #8167 Signed-off-by: Ansis Atteka --- datapath/flow.c | 41 + 1 files changed, 17 insertions(+), 24 deletions(-) diff --git a/datapath/flow.c b/datapath/flow.c index 2dc87ae..75de5fa 100644 --- a/datapath/flow.c +++ b/datapath/flow.c @@ -1166,43

Re: [ovs-dev] [PATCH] ovs-test: A new tool that allows to diagnose connectivity and performance issues

2011-11-10 Thread Ansis Atteka
On Tue, Nov 1, 2011 at 11:18 AM, Ben Pfaff wrote: > On Mon, Oct 31, 2011 at 04:38:51PM -0700, Ansis Atteka wrote: > > This tool will be a replacement for the current ovs-vlan-test > > utility. Besides from connectivity issues it will also be able > > to detect performance r

Re: [ovs-dev] [PATCH] docs: Always build ovs-vswitchd.conf.db.5 in srcdir.

2011-11-11 Thread Ansis Atteka
in the srcdir as part of > the distribution). > > Reported-by: Ansis Atteka > --- > vswitchd/automake.mk |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/vswitchd/automake.mk b/vswitchd/automake.mk > index 804cf58..8319c93 100644 > -

[ovs-dev] [PATCH] ovs-test: A new tool that allows to diagnose connectivity and performance issues

2011-11-14 Thread Ansis Atteka
This tool will be a replacement for the current ovs-vlan-test utility. Besides from connectivity issues it will also be able to detect performance related issues in Open vSwitch setups. Currently it uses UDP and TCP protocols for stressing. Issue #6976 --- Makefile.am |2

Re: [ovs-dev] [PATCH] ovs-test: A new tool that allows to diagnose connectivity and performance issues

2011-11-15 Thread Ansis Atteka
On Tue, Nov 15, 2011 at 9:21 AM, Jesse Gross wrote: > On Mon, Nov 14, 2011 at 5:14 PM, Ansis Atteka wrote: > > +print ("UDP test from %s:%u to %s:%u with target bandwidth %s" % > > +(sender[0], sender[1],

[ovs-dev] [PATCH] packaging: Fix Xen and RH packaging error that was introduced with ovs-test utility

2011-11-18 Thread Ansis Atteka
My previous ovs-test utility commit broke Xen and RH packaging. This commit will address this issue by not including any ovs-test related files into those two packages. --- rhel/openvswitch.spec.in |2 ++ xenserver/openvswitch-xen.spec |2 ++ 2 files changed, 4 insertions(+), 0 delet

Re: [ovs-dev] [PATCH] packaging: Fix Xen and RH packaging error that was introduced with ovs-test utility

2011-11-18 Thread Ansis Atteka
2011 at 1:46 PM, Ethan Jackson wrote: > > On Fri, Nov 18, 2011 at 01:34:36PM -0800, Ansis Atteka wrote: > >> My previous ovs-test utility commit broke Xen and RH packaging. > >> This commit will address this issue by not including any ovs-test > related > >> f

Re: [ovs-dev] [PATCH] utilities: Update gitignore.

2011-11-21 Thread Ansis Atteka
Looks good. It seems that I forgot to add my generated files to .gitignore. Thanks, Ansis On Mon, Nov 21, 2011 at 10:39 AM, Ethan Jackson wrote: > --- > utilities/.gitignore |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/utilities/.gitignore b/utilities/.gitigno

[ovs-dev] [PATCH] ovs-dpctl: allow ovs-dpctl to fallback from ovs_datapath to odp_datapath Netlink Family

2011-12-01 Thread Ansis Atteka
Some while ago Netlink Family names were changed from ODP_* to OVS_*. This leaded to upgrade related issues when the new ovs-dpctl wanted to remove existing datapaths from the old kernel module by using 'ovs_datapath' instead of 'odp_datapath' name. Issue #8548 --- include/linux/openvswitch.h |

Re: [ovs-dev] [PATCH] ovs-dpctl: allow ovs-dpctl to fallback from ovs_datapath to odp_datapath Netlink Family

2011-12-02 Thread Ansis Atteka
On Fri, Dec 2, 2011 at 9:55 AM, Ben Pfaff wrote: > On Thu, Dec 01, 2011 at 07:55:21PM -0800, Ansis Atteka wrote: > > Some while ago Netlink Family names were changed from ODP_* > > to OVS_*. This leaded to upgrade related issues when the new ovs-dpctl > > wanted to remove ex

[ovs-dev] [PATCH] packaging: allow smooth upgrade between kernel modules that use ODP_ and OVS_ Netlink family names

2011-12-02 Thread Ansis Atteka
Some while ago Netlink Family names were changed from ODP_* to OVS_*. This leaded to upgrade related issues when the new ovs-dpctl wanted to remove existing datapaths from the old kernel module by using 'ovs_datapath' instead of 'odp_datapath' name. This patch allows package preinst scipts to take

Re: [ovs-dev] [flow-stats 06/14] packets: New function eth_from_hex().

2011-12-14 Thread Ansis Atteka
On Thu, Dec 8, 2011 at 2:01 PM, Ben Pfaff wrote: > An upcoming commit will add another user. > --- > lib/packets.c | 25 + > lib/packets.h |2 ++ > ofproto/ofproto-dpif.c | 12 > 3 files changed, 31 insertions(+), 8 deletions(-) > >

[ovs-dev] [PATCH] vswitchd: In-band rules for Controller are missing after executing force-reload-kmod command

2011-12-19 Thread Ansis Atteka
Controller in-band rules are not added. This commit fixes this limitation and allows vswitchd to add Controller in-band rules even if there are no routes in the kernel routing table. Issue: #8625 Signed-off-by: Ansis Atteka --- ofproto/connmgr.c |8 +--- 1 files changed, 5 insertions(+), 3

Re: [ovs-dev] [PATCH] vswitchd: In-band rules for Controller are missing after executing force-reload-kmod command

2011-12-19 Thread Ansis Atteka
On Mon, Dec 19, 2011 at 1:37 PM, Ben Pfaff wrote: > On Mon, Dec 19, 2011 at 01:29:37PM -0800, Ansis Atteka wrote: > > In current implementation vswitchd adds Controller in-band rules only if > there is a route in > > kernel routing table that might route traffic to the Contr

[ovs-dev] [PATCH] vswitchd: In-band rules for Controller are missing after executing force-reload-kmod command

2011-12-19 Thread Ansis Atteka
Controller in-band rules are not added. This commit fixes this limitation and allows vswitchd to add Controller in-band rules even if there are no routes in the kernel routing table. Issue: #8625 Signed-off-by: Ansis Atteka --- lib/stream.c | 22 +- lib/stream.h |7

Re: [ovs-dev] [PATCH] vswitchd: In-band rules for Controller are missing after executing force-reload-kmod command

2011-12-19 Thread Ansis Atteka
I just realized that I forgot to limit line length for the commit message as Ethan suggested. I did that in my local repo. On Mon, Dec 19, 2011 at 4:01 PM, Ansis Atteka wrote: > In current implementation vswitchd adds Controller in-band rules only if > there is a route in > kernel rout

Re: [ovs-dev] [PATCH] vswitchd: In-band rules for Controller are missing after executing force-reload-kmod command

2011-12-19 Thread Ansis Atteka
Thanks. Pushed to the master. On Mon, Dec 19, 2011 at 4:04 PM, Ben Pfaff wrote: > On Mon, Dec 19, 2011 at 04:01:23PM -0800, Ansis Atteka wrote: > > In current implementation vswitchd adds Controller in-band rules only if > there is a route in > > kernel routing table that m

Re: [ovs-dev] compiler warnings

2011-12-20 Thread Ansis Atteka
Ok. But would you mind if I would change the OVS_ENABLE_WERROR default behavior to "yes"? Thanks, Ansis On Tue, Dec 20, 2011 at 11:21 AM, Ben Pfaff wrote: > I'm getting the following warnings on master, would you mind fixing > these? > > ../ofproto/connmgr.c: In function 'update_in_band_remotes

[ovs-dev] [PATCH] vswitchd: fix "imlicit declaration of function" build warning.

2011-12-21 Thread Ansis Atteka
Included stream.h header file for connmgr.c and bridge.c files. Signed-off-by: Ansis Atteka Reported-by: Ben Pfaff --- ofproto/connmgr.c |1 + vswitchd/bridge.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/ofproto/connmgr.c b/ofproto/connmgr.c index 1c55b67

Re: [ovs-dev] [PATCH] vswitchd: fix "imlicit declaration of function" build warning.

2011-12-21 Thread Ansis Atteka
Thanks. I fixed subject line and pushed to the master. On Wed, Dec 21, 2011 at 10:05 AM, Ben Pfaff wrote: > On Wed, Dec 21, 2011 at 10:04:03AM -0800, Ansis Atteka wrote: > > Included stream.h header file for connmgr.c and bridge.c files. > > > > Signed-off-by: Ansis Atteka

[ovs-dev] [PATCH] packaging: Do not automatically restart user-space on upgrade

2012-01-13 Thread Ansis Atteka
This will make Debian upgrade consistent with Xenserver and RH where user must manually run force-reload-kmod command after the upgrade. Issue: 9128 Signed-off-by: Ansis Atteka Reported-by: Michael Kruze --- debian/openvswitch-switch.postinst |6 ++ debian/rules

Re: [ovs-dev] [PATCH] ovs-vsctl: Document a pitfall of the syntax for maps.

2012-01-13 Thread Ansis Atteka
Looks, good but given example expands to "other-config=0=x other-config=1=y" instead of "other-config=0=x other-config=0=y" , right? On Fri, Jan 13, 2012 at 3:10 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > utilities/ovs-vsctl.8.in |6 -- > 1 files changed, 4 insertions(+),

Re: [ovs-dev] [PATCH] packaging: Do not automatically restart user-space on upgrade

2012-01-16 Thread Ansis Atteka
gt; fi See other comments below. On Mon, Jan 16, 2012 at 10:36 AM, Ben Pfaff wrote: > On Fri, Jan 13, 2012 at 11:40:50AM -0800, Ansis Atteka wrote: > > This will make Debian upgrade consistent with Xenserver > > and RH where user must manually run force-reload-kmod > > command

[ovs-dev] [PATCH] packaging: Do not automatically restart user-space on upgrade from 1.3

2012-01-18 Thread Ansis Atteka
This will print a warning and avoid user-space restart if system already had 1.3 or older OVS installed. This is a workaround for a bug where older kernel modules could not communicate with newer user-space. Issue: 9128 Signed-off-by: Ansis Atteka Reported-by: Michael Kruze --- debian

Re: [ovs-dev] [PATCH] packaging: Do not automatically restart user-space on upgrade from 1.3

2012-01-18 Thread Ansis Atteka
On Wed, Jan 18, 2012 at 2:59 PM, Ben Pfaff wrote: > On Wed, Jan 18, 2012 at 02:43:30PM -0800, Ansis Atteka wrote: > > This will print a warning and avoid user-space restart > > if system already had 1.3 or older OVS installed. This is > > a workaround for a bug where older

[ovs-dev] [PATCH] packaging: Do not automatically restart user-space on upgrade from 1.3

2012-01-18 Thread Ansis Atteka
This will print a warning and avoid user-space restart if system already had 1.3 or older OVS installed. This is a workaround for a bug where older kernel modules could not communicate with newer user-space. Issue: 9128 Signed-off-by: Ansis Atteka Reported-by: Michael Kruze --- debian

Re: [ovs-dev] [PATCH] packaging: Do not automatically restart user-space on upgrade from 1.3

2012-01-18 Thread Ansis Atteka
On Wed, Jan 18, 2012 at 3:44 PM, Ben Pfaff wrote: > On Wed, Jan 18, 2012 at 03:39:06PM -0800, Ansis Atteka wrote: > > But can I assume that it is safe to hardcode in postinst the > > /etc/init.d/openvswitch-switch path? I guess that the debhelper > > gets it from ./config

Re: [ovs-dev] [PATCH 3/3] debian: Install self-signed certificates.

2012-02-17 Thread Ansis Atteka
On Fri, Feb 17, 2012 at 3:41 PM, Gurucharan Shetty wrote: > Install self-signed certificates in /etc/openvswitch using the > ovs-pki utility. > > Bug #9063. > > Signed-off-by: Gurucharan Shetty > --- > debian/openvswitch-switch.postinst |7 +++ > debian/openvswitch-switch.postrm |3

Re: [ovs-dev] [PATCH RFC] configure: make name openvswitch_mod configurable

2012-03-02 Thread Ansis Atteka
On Thu, Mar 1, 2012 at 9:28 PM, Chris Wright wrote: > This is just an RFC, partly because it ignores datapath/ so you could > build a module that the runtime can't install. Now that the ovs datapath > is upstream and named simply openvswitch, tools like ovs-ctl fail to > function w/ the native d

<    1   2   3   4   5