On Wed, Jan 18, 2012 at 2:59 PM, Ben Pfaff <b...@nicira.com> wrote: > On Wed, Jan 18, 2012 at 02:43:30PM -0800, Ansis Atteka wrote: > > This will print a warning and avoid user-space restart > > if system already had 1.3 or older OVS installed. This is > > a workaround for a bug where older kernel modules could not > > communicate with newer user-space. > > > > Issue: 9128 > > > > Signed-off-by: Ansis Atteka <aatt...@nicira.com> > > Reported-by: Michael Kruze <mkr...@nicira.com> > > This seems like a reasonable solution. Thank you. > > Please put "" around $2 here: > Ok
> > > + if dpkg --compare-versions $2 lt 1.4; then > > Please spell Open vSwitch with a space: > Ok > > + printf "\nThere is an upgrade bug from pre-1.4 OpenvSwitch. As > a\n" > > + printf "workaround you must manually run force-reload-kmod > command\n" > > + printf "or reboot system to finish the upgrade.\n\n" > > + exit 0 > > + fi > > +fi > > I'm nervous about calling "exit 0" here. This will skip not just > restarting the daemon but anything else that debhelper adds. Currently that's just update-rc.d but who knows what it might be in > the future? So I think it would be better to change the > dh_installinit invocation to use --no-start and then add our own code > to postinst to do the restart when it is appropriate. > A good point. But can I assume that it is safe to hardcode in postinst the /etc/init.d/openvswitch-switch path? I guess that the debhelper gets it from ./configure, right? Will look into this... > Thanks, > > Ben. >
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
