Re: [ovs-dev] [PATCH] ovs-vsctl: Try connecting only once for active connections by default.

2013-03-15 Thread Ansis Atteka
On Fri, Mar 15, 2013 at 4:14 PM, Ben Pfaff wrote: > On Fri, Mar 15, 2013 at 02:46:05PM -0700, Ansis Atteka wrote: >> On Fri, Mar 15, 2013 at 1:37 PM, Ben Pfaff wrote: >> > Until now, ovs-vsctl has kept trying to the database server until it >> > succeeded or the

Re: [ovs-dev] [PATCH] ipsec: unset IPSEC_MARK flag from skb_mark after tunnel packet is decapsulated

2013-03-18 Thread Ansis Atteka
On Fri, Mar 15, 2013 at 3:27 PM, Jesse Gross wrote: > On Fri, Mar 15, 2013 at 2:10 PM, Ansis Atteka wrote: >> On Thu, Mar 14, 2013 at 4:23 PM, Jesse Gross wrote: >>> On Thu, Mar 14, 2013 at 2:27 PM, Ansis Atteka wrote: >>>> After tunnel packet is unencapsulated w

Re: [ovs-dev] [PATCH] ovs-vsctl: Try connecting only once for active connections by default.

2013-03-18 Thread Ansis Atteka
On Mon, Mar 18, 2013 at 10:26 AM, Ben Pfaff wrote: > On Fri, Mar 15, 2013 at 04:13:37PM -0700, Ansis Atteka wrote: >> I saw few other occurrences where ovs-vsctl is being called with >> --timeout, Though, I am not sure how safe or necessary it would be to >> remove --timeo

Re: [ovs-dev] [PATCH 1/3] ovs-bugtool: Add iptables output for all tables.

2013-03-25 Thread Ansis Atteka
On Mon, Mar 25, 2013 at 10:56 AM, Gurucharan Shetty wrote: > Currently we list all the rules only from the 'filter' table. > Include the rules from all the other tables too. > > Signed-off-by: Gurucharan Shetty > --- > utilities/bugtool/ovs-bugtool.in |3 ++- > 1 file changed, 2 insertions(+

Re: [ovs-dev] [PATCH 3/3] xenserver: Add information about some bugtool scripts.

2013-03-25 Thread Ansis Atteka
On Mon, Mar 25, 2013 at 10:56 AM, Gurucharan Shetty wrote: > The README file in xenserver directory currently misses information > about a few bugtool scripts. Add them. > > Signed-off-by: Gurucharan Shetty > --- > xenserver/README | 18 +- > 1 file changed, 17 insertions(+), 1

Re: [ovs-dev] [PATCH 2/3] ovs-bugtool: Add ovs-appctl dpif commands to debug bundle.

2013-03-25 Thread Ansis Atteka
On Mon, Mar 25, 2013 at 10:56 AM, Gurucharan Shetty wrote: > With single datapath, 'ovs-dpctl dump-flows ' dumps datapath flows for > all the userspace bridges in a system. It can get a little harder > to figure out the datapath flows belonging to a particular userspace > bridge. > > This patch ad

Re: [ovs-dev] [PATCH] lacp: Stop time to avoid dependency on real time in negotiation test.

2013-03-28 Thread Ansis Atteka
On Thu, Mar 28, 2013 at 11:47 AM, Ben Pfaff wrote: > Commit f3103dfa00d (lacp.at: Change timing of lacp - negotiation test) > fixed test failures for the lacp negotiation test on some systems, but > made it crop up on others where it hadn't appeared before. > > My guess is that this commit is the

Re: [ovs-dev] [bug15983 2/4] ovsdb-server: Add commands for adding and removing remotes at runtime.

2013-04-10 Thread Ansis Atteka
On Wed, Apr 10, 2013 at 10:35 AM, Ben Pfaff wrote: > This will make it possible, in later commits, to make ovsdb-server connect > to OVS managers only after ovs-vswitchd has completed its initial > configuration. > > Signed-off-by: Ben Pfaff > --- > ovsdb/ovsdb-server.1.in | 28 ++

Re: [ovs-dev] [bug15983 1/4] sset: New function sset_sort().

2013-04-10 Thread Ansis Atteka
On Wed, Apr 10, 2013 at 10:35 AM, Ben Pfaff wrote: > This will have its first caller in an upcoming commit. > > Signed-off-by: Ben Pfaff > --- > lib/sset.c | 36 +++- > lib/sset.h |4 +++- > 2 files changed, 38 insertions(+), 2 deletions(-) > Looks good to

Re: [ovs-dev] [bug15983 3/4] ovs-ctl: Connect to remote OVSDB managers only after ovs-vswitchd starts.

2013-04-10 Thread Ansis Atteka
On Wed, Apr 10, 2013 at 10:35 AM, Ben Pfaff wrote: > Until now, ovs-ctl has started ovsdb-server with the full set of remote > managers configured. This means that ovsdb-server immediately connects to > these managers, before ovs-vswitchd even starts. Because the Open vSwitch > schema has sever

Re: [ovs-dev] [bug15983 4/4] bridge: Only complete daemonization after db commits initial config.

2013-04-10 Thread Ansis Atteka
Looks good to me. One thing I noticed - if you will try to add invalid remote from "db:", then parse_db_column() might fail and call ovs_fatal(). Seems a little harsh... On Wed, Apr 10, 2013 at 10:35 AM, Ben Pfaff wrote: > An earlier commit changed the Open vSwitch startup scripts so that they

Re: [ovs-dev] [bug15983 2/4] ovsdb-server: Add commands for adding and removing remotes at runtime.

2013-04-10 Thread Ansis Atteka
On Wed, Apr 10, 2013 at 3:19 PM, Ben Pfaff wrote: > On Wed, Apr 10, 2013 at 12:25:14PM -0700, Ansis Atteka wrote: > > On Wed, Apr 10, 2013 at 10:35 AM, Ben Pfaff wrote: > > > > > This will make it possible, in later commits, to make ovsdb-server > connect > >

Re: [ovs-dev] [bug15983 v2 0/5] Start up more gracefully

2013-04-10 Thread Ansis Atteka
For all these 5 patches: Acked-by: Ansis Atteka On Wed, Apr 10, 2013 at 4:25 PM, Ben Pfaff wrote: > v1->v2: Don't exit with a fatal error if one "add-remote"s an invalid > remote. > > Ben Pfaff (5): > sset: New function sset_sort(). > ovsdb-server:

[ovs-dev] [PATCH] netlink-socket: Don't bother logging SO_RCVBUFFORCE failure

2013-04-11 Thread Ansis Atteka
This patch fixes tests when they are run with "fakeroot debian/rules binary" command. The problem was that under fakeroot setsockopt() call could still return EPERM and lead to a warning message being logged. Signed-off-by: Ansis Atteka --- lib/netlink-socket.c |2 +- 1 file

Re: [ovs-dev] [PATCH] netlink-socket: Don't bother logging SO_RCVBUFFORCE failure

2013-04-11 Thread Ansis Atteka
On Thu, Apr 11, 2013 at 12:46 PM, Ben Pfaff wrote: > On Thu, Apr 11, 2013 at 12:45:15PM -0700, Ansis Atteka wrote: > > This patch fixes tests when they are run with "fakeroot debian/rules > binary" > > command. > > > > The problem was that under faker

Re: [ovs-dev] [PATCH] bridge: Complete initial configuration even with empty database.

2013-04-11 Thread Ansis Atteka
If ovsdb-server is not running and I try to start single ovs-vswitchd instance without any init scripts, then I am still seeing 100% CPU utilization and multiple ovs-vswitchd instances in "ps" output. Still trying to understand what is going on... aatteka@aatteka-MacBookPro:~/openvswitch$ ps -Af |

Re: [ovs-dev] [PATCH] memory: Avoid 100% CPU when there is nothing to report.

2013-04-11 Thread Ansis Atteka
On Thu, Apr 11, 2013 at 3:05 PM, Ben Pfaff wrote: > Commit b9de4087685 (memory: Avoid an empty log message if there's nothing > to log.) introduced a 100% CPU usage condition when there is nothing to > log. This fixes the problem. > > Reported-by: Ansis Atteka > S

Re: [ovs-dev] [PATCH] bridge: Complete initial configuration even with empty database.

2013-04-11 Thread Ansis Atteka
Acked-by: Ansis Atteka Thanks for fixing the other bug too. On Thu, Apr 11, 2013 at 3:06 PM, Ben Pfaff wrote: > I think that is an unrelated problem. I sent out a fix: > http://openvswitch.org/pipermail/dev/2013-April/026581.html > > On Thu, Apr 11, 2013 at 02:46:28PM

Re: [ovs-dev] [PATCH] tests: Add test for ovs-vswitchd regression with empty db.

2013-04-12 Thread Ansis Atteka
Looks good to me. On Thu, Apr 11, 2013 at 2:10 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > tests/automake.mk |1 + > tests/ovs-vswitchd.at | 27 +++ > tests/testsuite.at|3 ++- > 3 files changed, 30 insertions(+), 1 deletions(-) > create

Re: [ovs-dev] [PATCH] list: Style fixes.

2013-04-15 Thread Ansis Atteka
Looks good. On Mon, Apr 15, 2013 at 2:48 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/list.c |8 +--- > 1 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/lib/list.c b/lib/list.c > index fd06b81..227546e 100644 > --- a/lib/list.c > +++ b/lib/list.c > @@ -

Re: [ovs-dev] [PATCH] bridge: Report PID of yielding process when multiple instances run.

2013-04-25 Thread Ansis Atteka
Looks good to me. On Mon, Apr 8, 2013 at 10:51 AM, Justin Pettit wrote: > Normally, the daemon code will detect when multiple instances are run > and print the conflicting PID. However, if ovs-vswitchd is not run in > daemon mode or the pidfile is removed, a database lock is checked. The > me

Re: [ovs-dev] issue in launching vm on openvswitch bridge

2013-05-01 Thread Ansis Atteka
On Tue, Apr 30, 2013 at 11:27 PM, freak 62 wrote: > Hi all, > > > I am using Ubuntu 12.10. I am trying to launch VM on the bridge of > OVS. > Can I do that with virt-manager ? or Is there any other way?? > Virt-manager is one of the UI applications that use libvirt. If I recall correctly

Re: [ovs-dev] [threads 12/17] odp-util: Avoid returning static data in ovs_key_attr_to_string().

2013-06-07 Thread Ansis Atteka
On Wed, Jun 5, 2013 at 1:05 PM, Ben Pfaff wrote: > Returning a static data buffer makes code more brittle and definitely > not thread-safe, so this commit switches to using a caller-provided > buffer instead. > > Signed-off-by: Ben Pfaff > > A

Re: [ovs-dev] [PATCH] ofp-actions: Add comments to struct ofpact_learn_spec.

2013-06-07 Thread Ansis Atteka
Acked-by: Ansis Atteka On Fri, Jun 7, 2013 at 10:14 AM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/ofp-actions.h | 12 ++-- > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/lib/ofp-actions.h b/lib/ofp-actions.h > index 9a

Re: [ovs-dev] [threads 02/17] process: Remove process_run(), process_run_capture(), and related code.

2013-06-10 Thread Ansis Atteka
Acked-by: Ansis Atteka On Wed, Jun 5, 2013 at 1:05 PM, Ben Pfaff wrote: > They are unused. > > Signed-off-by: Ben Pfaff > --- > lib/process.c | 227 > - > lib/process.h |8 -- > 2 files changed, 0 inse

Re: [ovs-dev] [PATCH v2 1/2] ofp-util: New function ofputil_port_to_string().

2013-06-24 Thread Ansis Atteka
On Wed, Jun 12, 2013 at 11:38 AM, Ben Pfaff wrote: > This function is more convenient than ofputil_format_port() when a "struct > ds" is not already in use. This commit converts one caller for which this > was already true, and the following commit will add another. > > Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH v2 2/2] ofproto-dpif: Make "fdb/show" report OpenFlow port numbers.

2013-06-24 Thread Ansis Atteka
On Wed, Jun 12, 2013 at 11:38 AM, Ben Pfaff wrote: > Users are more likely to be able to reasonably interpret OpenFlow port > numbers than datapath port numbers. > > This issue has existed since at least 2011 but only recently has it been > possible for OpenFlow and datapath port numbers to diffe

Re: [ovs-dev] [threads 09/11] Use random_*() instead of rand(), for thread safety.

2013-06-24 Thread Ansis Atteka
On Wed, Jun 19, 2013 at 1:17 PM, Ben Pfaff wrote: > None of these test programs are threaded, but has little cost and means > that "grep" doesn't turn up any instances of these thread-unsafe functions > in our tree. > > Signed-off-by: Ben Pfaff > --- > tests/test-classifier.c | 25 +++

Re: [ovs-dev] [threads 08/11] random: Make thread-safe.

2013-06-24 Thread Ansis Atteka
On Wed, Jun 19, 2013 at 1:17 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/random.c | 26 +- > 1 files changed, 17 insertions(+), 9 deletions(-) > > diff --git a/lib/random.c b/lib/random.c > index 45d428c..2572c1e 100644 > --- a/lib/random.c > +++ b/lib/

Re: [ovs-dev] [threads 08/11] random: Make thread-safe.

2013-06-25 Thread Ansis Atteka
On Mon, Jun 24, 2013 at 10:03 PM, Ben Pfaff wrote: > On Mon, Jun 24, 2013 at 03:50:45PM -0700, Ansis Atteka wrote: > > On Wed, Jun 19, 2013 at 1:17 PM, Ben Pfaff wrote: > > > > > Signed-off-by: Ben Pfaff > > > --- > > > lib/random.c | 26 +++

Re: [ovs-dev] [threads v2 03/13] netlink-socket: Make thread-safe.

2013-07-17 Thread Ansis Atteka
On Fri, Jul 12, 2013 at 2:54 PM, Ben Pfaff wrote: > The uses of vlog in this module are not thread-safe, because vlog itself > is not yet thread-safe. > > Signed-off-by: Ben Pfaff > --- > lib/netlink-socket.c | 24 +++- > lib/netlink-socket.h |6 ++ > 2 files chang

Re: [ovs-dev] [threads v2 02/13] netlink-socket: Simplify use of transactions and dumps.

2013-07-17 Thread Ansis Atteka
On Fri, Jul 12, 2013 at 2:54 PM, Ben Pfaff wrote: > This disentangles "struct nl_dump" from "struct nl_sock", clearing the way > to make the use of either one thread-safe in an obviously correct manner. > > Signed-off-by: Ben Pfaff > --- > lib/dpif-linux.c | 20 ++--- > lib/netdev-linux.c

Re: [ovs-dev] [threads v2 03/13] netlink-socket: Make thread-safe.

2013-07-17 Thread Ansis Atteka
On Wed, Jul 17, 2013 at 5:03 PM, Ansis Atteka wrote: > > > > On Fri, Jul 12, 2013 at 2:54 PM, Ben Pfaff wrote: > >> The uses of vlog in this module are not thread-safe, because vlog itself >> is not yet thread-safe. >> >> Signed-off-by: Ben Pfaff

Re: [ovs-dev] [netdev 25/27] netdev-vport: Make netdev_vport_patch_peer() return a malloc()'d string.

2013-08-07 Thread Ansis Atteka
Looks good to me On Thu, Aug 1, 2013 at 2:29 PM, Ben Pfaff wrote: > When threading comes into the picture there arises the possibility of a > race between netdev_vport_patch_peer()'s caller using the returned string > and another caller changing the peer. It is safer to return a copy. > > Signe

Re: [ovs-dev] [netdev 21/27] netdev-dummy: Use netdev_get_devices() instead of a local shash.

2013-08-08 Thread Ansis Atteka
Looks good to me. On Thu, Aug 1, 2013 at 2:29 PM, Ben Pfaff wrote: > When an upcoming commit introduces thread safety into the netdev API, this > allows netdev-dummy to avoid adding more internal locking by taking > advantage of netdev_get_devices() refcounting. > > Signed-off-by: Ben Pfaff >

Re: [ovs-dev] [PATCH] ovsdb: Clear 'bfd_status' when bfd is disabled.

2013-09-11 Thread Ansis Atteka
This looks reasonable to me. One comment above. On Wed, Sep 11, 2013 at 4:39 PM, Alex Wang wrote: > This commit makes ovsdb clear the 'bfd_status' column > when bfd is disabled. > > Reported-by: Ansis Atteka > Signed-off-by: Alex Wang > --- > vswitchd/bridge.c

Re: [ovs-dev] [PATCH 1/2] vswitchd: Clear bfd_status column when bfd is disabled.

2013-09-12 Thread Ansis Atteka
On Wed, Sep 11, 2013 at 5:19 PM, Alex Wang wrote: > This commit makes vswitchd clear the 'bfd_status' column > in ovsdb when bfd is disabled. > > Reported-by: Ansis Atteka > Signed-off-by: Alex Wang > --- > vswitchd/bridge.c |5 +++-- > 1 file cha

Re: [ovs-dev] [PATCH 2/2] bridge.c: Always call smap_destroy() after smap_init()

2013-09-12 Thread Ansis Atteka
modified to allocate dynamic memory. > > Reported-by: Ansis Atteka > Signed-off-by: Alex Wang > --- > vswitchd/bridge.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks good to me. We usually do not specify in subject line "bridge.c:...". Instead we s

Re: [ovs-dev] [PATCH V2 2/2] bridge: Always call smap_destroy() after smap_init()

2013-09-12 Thread Ansis Atteka
to allocate dynamic memory. > > Reported-by: Ansis Atteka > Signed-off-by: Alex Wang > > --- > > v1 -> v2: > - refine commit log title. > > --- > Looks good to me. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] ovsdb-doc: generate vswitch.[pic|gv] files only if dot tool is available

2013-10-14 Thread Ansis Atteka
repository. After this patch ovs-vswitchd.conf.db.5 will simply not have a dot diagram, if dot was not present at the time when Open vSwitch was built. Signed-off-by: Ansis Atteka --- .gitignore | 2 ++ vswitchd/automake.mk | 19 +-- vswitchd/vswitch.gv | 40

Re: [ovs-dev] [PATCH] ovsdb-doc: generate vswitch.[pic|gv] files only if dot tool is available

2013-10-14 Thread Ansis Atteka
On 14 October 2013 15:55, Ansis Atteka wrote: > These are auto-generated files, so it would be better not to keep them > inside Open vSwitch repository. > > Behaviour before this patch was that if dot tool was not present on > the system, then ovs-vswitchd.conf.db.5 would have use

[ovs-dev] [PATCHv2] ovsdb-doc: generate vswitch.[pic|gv] files only if dot tool is available

2013-10-14 Thread Ansis Atteka
repository. After this patch ovs-vswitchd.conf.db.5 will simply not have a dot diagram, if dot was not present at the time when Open vSwitch was built. Signed-off-by: Ansis Atteka --- vswitchd/.gitignore | 2 ++ vswitchd/automake.mk | 20 +-- vswitchd/vswitch.gv | 40

Re: [ovs-dev] [PATCHv2] ovsdb-doc: generate vswitch.[pic|gv] files only if dot tool is available

2013-10-15 Thread Ansis Atteka
On Mon, Oct 14, 2013 at 9:20 PM, Ben Pfaff wrote: > On Mon, Oct 14, 2013 at 05:56:40PM -0700, Ansis Atteka wrote: >> These are auto-generated files, so it would be better not to keep them >> inside Open vSwitch repository. >> >> Behaviour before this patch was that if

[ovs-dev] [PATCHv3] ovsdb-doc: generate vswitch.[pic|gv] files only if dot tool is available

2013-10-15 Thread Ansis Atteka
repository. After this patch ovs-vswitchd.conf.db.5 will simply not have a dot diagram, if dot was not present at the time when Open vSwitch was built. Signed-off-by: Ansis Atteka --- INSTALL | 5 ++- INSTALL.RHEL | 2 +- debian/control | 2 +- vswitchd/.gitignore | 2

Re: [ovs-dev] [PATCHv2] ovsdb-doc: generate vswitch.[pic|gv] files only if dot tool is available

2013-10-15 Thread Ansis Atteka
On Tue, Oct 15, 2013 at 1:32 PM, Ben Pfaff wrote: > On Tue, Oct 15, 2013 at 01:25:47PM -0700, Ansis Atteka wrote: >> On Mon, Oct 14, 2013 at 9:20 PM, Ben Pfaff wrote: >> > On Mon, Oct 14, 2013 at 05:56:40PM -0700, Ansis Atteka wrote: >> > Presumably we should add a R

[ovs-dev] [PATCHv4] ovsdb-doc: generate vswitch.[pic|gv] files only if dot tool is available

2013-10-16 Thread Ansis Atteka
repository. After this patch ovs-vswitchd.conf.db.5 will simply not have a dot diagram, if dot was not present at the time when Open vSwitch was built. Signed-off-by: Ansis Atteka --- INSTALL| 5 +- INSTALL.RHEL | 2 +- NEWS

Re: [ovs-dev] [PATCHv3] ovsdb-doc: generate vswitch.[pic|gv] files only if dot tool is available

2013-10-16 Thread Ansis Atteka
On Tue, Oct 15, 2013 at 2:49 PM, Ben Pfaff wrote: > On Tue, Oct 15, 2013 at 02:38:11PM -0700, Ansis Atteka wrote: >> These are auto-generated files, so it would be better not to keep them >> inside Open vSwitch repository. >> >> Behaviour before this patch was that if

Re: [ovs-dev] [PATCHv4] ovsdb-doc: generate vswitch.[pic|gv] files only if dot tool is available

2013-10-17 Thread Ansis Atteka
"make distcheck" passed. Thanks for review. I pushed this to master branch. On Thu, Oct 17, 2013 at 9:16 AM, Ben Pfaff wrote: > On Wed, Oct 16, 2013 at 11:33:50AM -0700, Ansis Atteka wrote: >> These are auto-generated files, so it would be better not to keep them >

Re: [ovs-dev] xenserver build failures

2013-10-17 Thread Ansis Atteka
On Thu, Oct 17, 2013 at 3:21 PM, Ben Pfaff wrote: > Builds for xenserver are failing now because xenserver doesn't have the > uuid.py module (it uses a too-old python): > >File "./ovsdb/ovsdb-doc", line 12, in ? > import ovs.db.schema >File > "/usr/src/redhat/BUILD/openvs

Re: [ovs-dev] xenserver build failures

2013-10-17 Thread Ansis Atteka
On Thu, Oct 17, 2013 at 6:19 PM, Ansis Atteka wrote: > On Thu, Oct 17, 2013 at 3:21 PM, Ben Pfaff wrote: >> Builds for xenserver are failing now because xenserver doesn't have the >> uuid.py module (it uses a too-old python): >> >>File

Re: [ovs-dev] [PATCH] rhel: Add VTEP packaging.

2013-10-17 Thread Ansis Atteka
Looks good to me. On Thu, Oct 17, 2013 at 7:42 PM, Justin Pettit wrote: > Add VTEP files so RHEL build doesn't fail. > > Bug #20487 > > Signed-off-by: Justin Pettit > --- > rhel/openvswitch.spec.in |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/rhel/openvswitc

Re: [ovs-dev] [PATCH] xenserver: Add VTEP packaging.

2013-10-17 Thread Ansis Atteka
Looks good to me. On Thu, Oct 17, 2013 at 7:46 PM, Justin Pettit wrote: > Add VTEP files so XenServer build doesn't fail. > > Signed-off-by: Justin Pettit > --- > xenserver/openvswitch-xen.spec.in |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/xenserver/openvs

[ovs-dev] [PATCH] configure: check for uuid python module

2013-10-17 Thread Ansis Atteka
l uses old python 2.4 and hence does not have uuid). After this commit ./configure will check whether uuid module is present and, if it isn't, then it will add python/compat to the PYTHONPATH. Signed-Off-By: Ansis Atteka Issue: 20476 --- Makefile.am | 7 +++ configure.ac

Re: [ovs-dev] [PATCH] configure: check for uuid python module

2013-10-18 Thread Ansis Atteka
On Thu, Oct 17, 2013 at 10:07 PM, Ben Pfaff wrote: > On Thu, Oct 17, 2013 at 10:02:30PM -0700, Ansis Atteka wrote: >> After introducing commit a5ae88ff8a276e86c842ac102145432662bf711a >> "ovsdb-doc: generate vswitch.[pic|gv] files only if dot tool is >> available&q

[ovs-dev] [PATCH] tests: use full table names in ovs-vsctl commands

2013-10-24 Thread Ansis Atteka
It is more obvious to figure out what exactly test is doing if ovs-vsctl commands contain full table names. Signed-off-by: Ansis Atteka --- tests/ovs-vsctl.at | 70 +++--- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/tests/ovs

Re: [ovs-dev] [PATCH] tests: use full table names in ovs-vsctl commands

2013-10-25 Thread Ansis Atteka
On Thu, Oct 24, 2013 at 7:59 PM, Ben Pfaff wrote: > On Thu, Oct 24, 2013 at 06:27:10PM -0700, Ansis Atteka wrote: >> It is more obvious to figure out what exactly test is doing >> if ovs-vsctl commands contain full table names. >> >> Signed-off-by: Ansis Atteka >

Re: [ovs-dev] [debian 7/9] util: New function follow_symlinks().

2012-08-01 Thread Ansis Atteka
On Wed, Aug 1, 2012 at 10:11 AM, Ben Pfaff wrote: > On Tue, Jul 31, 2012 at 10:06:33AM -0700, Ansis Atteka wrote: > > On Mon, Jul 30, 2012 at 3:18 PM, Ben Pfaff wrote: > > > > > It will acquire its first user in an upcoming commit. > > &g

Re: [ovs-dev] [debian 7/9] util: New function follow_symlinks().

2012-08-01 Thread Ansis Atteka
On Wed, Aug 1, 2012 at 10:53 AM, Ben Pfaff wrote: > On Wed, Aug 01, 2012 at 10:32:59AM -0700, Ansis Atteka wrote: > > On Wed, Aug 1, 2012 at 10:11 AM, Ben Pfaff wrote: > > > > > On Tue, Jul 31, 2012 at 10:06:33AM -0700, Ansis Atteka wrote: > > > > On Mon

Re: [ovs-dev] [PATCH] dirs: dbdir default must be based on sysconfdir.

2012-08-02 Thread Ansis Atteka
On Wed, Aug 1, 2012 at 11:23 PM, Ben Pfaff wrote: > Some in-tree and out-of-tree code sets the OVS_SYSCONFDIR environment > variable to control where /etc files go (mostly for test purposes). When > the database directory (dbdir) was split off from the sysconfdir, the > configure-time default co

Re: [ovs-dev] [PATCH v2] dirs: dbdir default must be based on sysconfdir.

2012-08-02 Thread Ansis Atteka
On Thu, Aug 2, 2012 at 2:13 PM, Ben Pfaff wrote: > Some in-tree and out-of-tree code sets the OVS_SYSCONFDIR environment > variable to control where /etc files go (mostly for test purposes). When > the database directory (dbdir) was split off from the sysconfdir, the > configure-time default con

Re: [ovs-dev] [PATCH v2] dirs: dbdir default must be based on sysconfdir.

2012-08-02 Thread Ansis Atteka
On Thu, Aug 2, 2012 at 4:05 PM, Ben Pfaff wrote: > On Thu, Aug 02, 2012 at 03:51:05PM -0700, Ansis Atteka wrote: > > On Thu, Aug 2, 2012 at 2:13 PM, Ben Pfaff wrote: > > > > > Some in-tree and out-of-tree code sets the OVS_SYSCONFDIR environment > > > variab

Re: [ovs-dev] [PATCH v2] dirs: dbdir default must be based on sysconfdir.

2012-08-02 Thread Ansis Atteka
On Thu, Aug 2, 2012 at 5:06 PM, Ben Pfaff wrote: > On Thu, Aug 02, 2012 at 04:57:25PM -0700, Ansis Atteka wrote: > > > From: Ben Pfaff > > > Date: Thu, 2 Aug 2012 16:01:49 -0700 > > > Subject: [PATCH] dirs: dbdir default must be based on sysconfdir. > > >

[ovs-dev] [PATCH] stp: port_no counter is off by one

2012-08-21 Thread Ansis Atteka
This counter was off by one, because port_num should be less than STP_MAX_PORTS. This caused an assert hit later in stp_get_port(). Issue: 13059 Signed-off-by: Ansis Atteka Reported-by: Ram Jothikumar --- vswitchd/bridge.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [ovs-dev] [PATCH] stp: port_no counter is off by one

2012-08-21 Thread Ansis Atteka
Thanks pushed to branch-1.8 and master. On Tue, Aug 21, 2012 at 5:06 PM, Ethan Jackson wrote: > Acked-by: Ethan Jackson > > > On Tue, Aug 21, 2012 at 5:01 PM, Ansis Atteka wrote: >> This counter was off by one, because port_num >> should be less than STP_MAX_PORTS. >

Re: [ovs-dev] [PATCH] stp: port_no counter is off by one

2012-08-22 Thread Ansis Atteka
And also branches 1.[7654] On Tue, Aug 21, 2012 at 5:14 PM, Ansis Atteka wrote: > Thanks pushed to branch-1.8 and master. > > On Tue, Aug 21, 2012 at 5:06 PM, Ethan Jackson wrote: >> Acked-by: Ethan Jackson >> >> >> On Tue, Aug 21, 2012 at 5:01 PM, Ansis Atteka

Re: [ovs-dev] [PATCH] dpif-linux: Report packet loss as WARN instead of ERR.

2012-09-05 Thread Ansis Atteka
On Wed, Sep 5, 2012 at 11:04 AM, Ben Pfaff wrote: > Packet loss is recoverable so it doesn't warrant an ERR. > > Bug #12920. > Reported-by: Scott Hendricks > Signed-off-by: Ben Pfaff > --- > lib/dpif-linux.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/dp

Re: [ovs-dev] [PATCH 1/3] reconnect: Rename reconnect_received() to reconnect_activity().

2012-09-05 Thread Ansis Atteka
On Tue, Sep 4, 2012 at 2:56 PM, Ben Pfaff wrote: > On Wed, Aug 08, 2012 at 04:14:50PM -0700, Ben Pfaff wrote: >> Receiving data is not the only reasonable way to verify that a connection >> is up. For example, on a TCP connection, receiving an acknowledgment that >> the remote side has accepted d

Re: [ovs-dev] [PATCH 1/3] reconnect: Rename reconnect_received() to reconnect_activity().

2012-09-05 Thread Ansis Atteka
On Wed, Sep 5, 2012 at 1:34 PM, Ben Pfaff wrote: > On Wed, Sep 05, 2012 at 01:01:58PM -0700, Ansis Atteka wrote: >> On Tue, Sep 4, 2012 at 2:56 PM, Ben Pfaff wrote: >> > On Wed, Aug 08, 2012 at 04:14:50PM -0700, Ben Pfaff wrote: >> >> Receiving data is not the only

Re: [ovs-dev] [PATCH 2/3] jsonrpc: Treat draining data from send queue as activity.

2012-09-05 Thread Ansis Atteka
On Wed, Aug 8, 2012 at 4:14 PM, Ben Pfaff wrote: > Until now, the jsonrpc module has used messages received from the > remote peer as the sole means to determine that the JSON-RPC > connection is up. This could in theory interact badly with a > remote peer that stops reading and processing messag

Re: [ovs-dev] [PATCH 2/3] jsonrpc: Treat draining data from send queue as activity.

2012-09-06 Thread Ansis Atteka
On Thu, Sep 6, 2012 at 7:49 AM, Ben Pfaff wrote: > On Wed, Sep 05, 2012 at 11:48:26PM -0700, Ansis Atteka wrote: >> On Wed, Aug 8, 2012 at 4:14 PM, Ben Pfaff wrote: >> > Until now, the jsonrpc module has used messages received from the >> > remote peer as the sole

Re: [ovs-dev] [PATCH 3/3] jsonrpc: Treat receiving part of a message as activity.

2012-09-06 Thread Ansis Atteka
On Wed, Aug 8, 2012 at 4:14 PM, Ben Pfaff wrote: > Until now, the jsonrpc code has only counted receiving a full JSON-RPC > messages as activity. This could theoretically time out, then, while a > very long message is in transit or if a slow link is involved. This commit > changes this code to c

[ovs-dev] [PATCH] netdev-vport: Disable Path MTU Discovery by default

2012-10-22 Thread Ansis Atteka
This patch changes the default path MTU discovery value to disabled. Signed-off-by: Ansis Atteka --- lib/netdev-vport.c | 10 +- vswitchd/vswitch.xml |2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c index 621abd1

[ovs-dev] [PATCHv2] netdev-vport: Disable Path MTU Discovery by default

2012-10-25 Thread Ansis Atteka
In near future we will switch to the flow-based tunneling and drop path MTU discovery support. This patch prepares for that by changing the default PMTUD value from 'enabled' to 'disabled'. Signed-off-by: Ansis Atteka --- NEWS |1 + lib/net

Re: [ovs-dev] [PATCHv2] netdev-vport: Disable Path MTU Discovery by default

2012-10-25 Thread Ansis Atteka
On Thu, Oct 25, 2012 at 6:22 PM, Ben Pfaff wrote: > On Thu, Oct 25, 2012 at 02:50:10PM +0300, Ansis Atteka wrote: >> In near future we will switch to the flow-based tunneling and drop path >> MTU discovery support. This patch prepares for that by changing the default >> PMTU

Re: [ovs-dev] [PATCHv2] netdev-vport: Disable Path MTU Discovery by default

2012-10-25 Thread Ansis Atteka
On Thu, Oct 25, 2012 at 9:24 PM, Jesse Gross wrote: > On Thu, Oct 25, 2012 at 4:50 AM, Ansis Atteka wrote: >> In near future we will switch to the flow-based tunneling and drop path >> MTU discovery support. This patch prepares for that by changing the default >> PMTUD va

[ovs-dev] [PATCH] datapath: add ipv6 'set' action

2012-10-28 Thread Ansis Atteka
This patch adds ipv6 set action functionality. It allows to change traffic class, flow label, hop-limit, ipv6 source and destination address fields. Signed-off-by: Ansis Atteka --- datapath/actions.c | 83 datapath/compat.h | 23

[ovs-dev] [PATCH] netdev-vport: Warn users that pmtud is deprecated

2012-10-29 Thread Ansis Atteka
This is a complementary patch to the other one I sent out previously. The pupose of it is to make it more obvious that tunnel pmtud is deprecated and will be removed soon. Requested-by: Jesse Gross Signed-off-by: Ansis Atteka --- NEWS |4 +++- lib/netdev-vport.c |4

Re: [ovs-dev] [PATCH] netdev-vport: Warn users that pmtud is deprecated

2012-10-30 Thread Ansis Atteka
On Mon, Oct 29, 2012 at 8:33 PM, Jesse Gross wrote: > On Mon, Oct 29, 2012 at 9:22 AM, Ansis Atteka wrote: >> This is a complementary patch to the other one I sent out previously. >> The pupose of it is to make it more obvious that tunnel pmtud is >> deprecated and

Re: [ovs-dev] [PATCH] datapath: add ipv6 'set' action

2012-11-04 Thread Ansis Atteka
On Tue, Oct 30, 2012 at 1:11 AM, Jesse Gross wrote: > On Sun, Oct 28, 2012 at 2:21 PM, Ansis Atteka wrote: >> This patch adds ipv6 set action functionality. It allows to change >> traffic class, flow label, hop-limit, ipv6 source and destination >> address fields. >&

Re: [ovs-dev] [PATCH] datapath: add ipv6 'set' action

2012-11-05 Thread Ansis Atteka
On Mon, Nov 5, 2012 at 8:58 PM, Jesse Gross wrote: > On Sun, Nov 4, 2012 at 7:44 AM, Ansis Atteka wrote: >> On Tue, Oct 30, 2012 at 1:11 AM, Jesse Gross wrote: >>> On Sun, Oct 28, 2012 at 2:21 PM, Ansis Atteka wrote: >>>> diff --git a/datapath/actions.c b/datapat

[ovs-dev] [PATCH 1/2] datapath: Add ipv6_find_hdr() compatibility function.

2012-11-06 Thread Ansis Atteka
s function will need to be customized so that it would skip all routing headers, where segements_left is equal to 0. Signed-off-by: Ansis Atteka --- datapath/linux/compat/exthdrs_core.c | 102 ++ datapath/linux/compat/include/net/ipv6.h | 11 2 files ch

[ovs-dev] [PATCH 2/2] datapath: improve ipv6_find_hdr() function for IPv6 'set' action

2012-11-06 Thread Ansis Atteka
This patch prepares ipv6_find_hdr() function so that it could be able to skip routing headers, where segements_left is 0. This is required for us to handle multiple routing header case correctly. Signed-off-by: Ansis Atteka --- datapath/linux/compat/exthdrs_core.c | 41

Re: [ovs-dev] [PATCH 2/2] datapath: improve ipv6_find_hdr() function for IPv6 'set' action

2012-11-06 Thread Ansis Atteka
On Tue, Nov 6, 2012 at 8:19 PM, Ben Pfaff wrote: > On Tue, Nov 06, 2012 at 10:16:47AM -0800, Jesse Gross wrote: >> On Tue, Nov 6, 2012 at 7:25 AM, Ansis Atteka wrote: >> >> > This patch prepares ipv6_find_hdr() function so that it could be >> > able to skip rout

Re: [ovs-dev] [PATCH 2/2] datapath: improve ipv6_find_hdr() function for IPv6 'set' action

2012-11-06 Thread Ansis Atteka
On Tue, Nov 6, 2012 at 8:26 PM, Ben Pfaff wrote: > On Tue, Nov 06, 2012 at 08:25:41PM +0200, Ansis Atteka wrote: >> On Tue, Nov 6, 2012 at 8:19 PM, Ben Pfaff wrote: >> > On Tue, Nov 06, 2012 at 10:16:47AM -0800, Jesse Gross wrote: >> >> On Tue, Nov 6, 2012 a

[ovs-dev] [PATCHv2 1/4] datapath: Add ipv6_find_hdr() compatibility function.

2012-11-06 Thread Ansis Atteka
s function will need to be customized so that it would skip all routing headers, where segements_left is equal to 0. Signed-off-by: Ansis Atteka --- datapath/linux/compat/exthdrs_core.c | 104 ++ datapath/linux/compat/include/net/ipv6.h | 11 2 files ch

[ovs-dev] [PATCHv2 2/4] datapath: improve ipv6_find_hdr() function for IPv6 'set' action

2012-11-06 Thread Ansis Atteka
This patch prepares ipv6_find_hdr() function so that it could be able to skip routing headers, where segements_left is 0. This is required for us to handle multiple routing header case correctly. Signed-off-by: Ansis Atteka --- datapath/linux/compat/exthdrs_core.c | 31

Re: [ovs-dev] [PATCH] datapath: add ipv6 'set' action

2012-11-07 Thread Ansis Atteka
On Tue, Oct 30, 2012 at 1:11 AM, Jesse Gross wrote: > On Sun, Oct 28, 2012 at 2:21 PM, Ansis Atteka wrote: >> This patch adds ipv6 set action functionality. It allows to change >> traffic class, flow label, hop-limit, ipv6 source and destination >> address fields. >&

[ovs-dev] [PATCHv2 1/2] sparse: Add ip6_rthdr struct to the ip6.h

2012-11-08 Thread Ansis Atteka
Signed-off-by: Ansis Atteka --- include/sparse/netinet/ip6.h |7 +++ 1 file changed, 7 insertions(+) diff --git a/include/sparse/netinet/ip6.h b/include/sparse/netinet/ip6.h index ca80c97..d2a54de 100644 --- a/include/sparse/netinet/ip6.h +++ b/include/sparse/netinet/ip6.h @@ -44,6

[ovs-dev] [PATCHv2 2/2] datapath: add ipv6 'set' action

2012-11-08 Thread Ansis Atteka
This patch adds ipv6 set action functionality. It allows to change traffic class, flow label, hop-limit, ipv6 source and destination address fields. Signed-off-by: Ansis Atteka --- NEWS|1 + datapath/actions.c | 90 + datapath/checksum.h | 23

Re: [ovs-dev] [PATCHv2 2/2] datapath: add ipv6 'set' action

2012-11-09 Thread Ansis Atteka
On Fri, Nov 9, 2012 at 3:30 AM, Jesse Gross wrote: > On Thu, Nov 8, 2012 at 5:14 AM, Ansis Atteka wrote: >> >> diff --git a/datapath/actions.c b/datapath/actions.c >> index 8ec692d..317aa4a 100644 >> --- a/datapath/actions.c >> +++ b/datapath/actions.c >

[ovs-dev] [PATCHv3 2/2] datapath: add ipv6 'set' action

2012-11-10 Thread Ansis Atteka
This patch adds ipv6 set action functionality. It allows to change traffic class, flow label, hop-limit, ipv6 source and destination address fields. Signed-off-by: Ansis Atteka --- NEWS|1 + datapath/actions.c | 94 +++ datapath/checksum.h

Re: [ovs-dev] [PATCHv3 2/2] datapath: add ipv6 'set' action

2012-11-13 Thread Ansis Atteka
On Mon, Nov 12, 2012 at 10:52 PM, Jesse Gross wrote: > On Sat, Nov 10, 2012 at 4:34 AM, Ansis Atteka wrote: >> >> This patch adds ipv6 set action functionality. It allows to change >> traffic class, flow label, hop-limit, ipv6 source and destination >> address fields.

[ovs-dev] [PATCH] datapath: add skb mark matching and set action

2012-11-13 Thread Ansis Atteka
This patch adds support for skb mark matching and set action. Signed-off-by: Ansis Atteka --- datapath/actions.c |4 datapath/datapath.c |1 + datapath/flow.c | 15 +++ datapath/flow.h |6 -- include/linux/openvswitch.h

Re: [ovs-dev] [PATCH] datapath: add skb mark matching and set action

2012-11-13 Thread Ansis Atteka
On Tue, Nov 13, 2012 at 8:05 PM, Ben Pfaff wrote: > On Tue, Nov 13, 2012 at 07:52:47PM +0200, Ansis Atteka wrote: >> This patch adds support for skb mark matching and set action. >> >> Signed-off-by: Ansis Atteka > > Are there any common use cases for skb marking in

Re: [ovs-dev] [PATCH] datapath: add skb mark matching and set action

2012-11-14 Thread Ansis Atteka
On Tue, Nov 13, 2012 at 11:55 PM, Jesse Gross wrote: > On Tue, Nov 13, 2012 at 9:52 AM, Ansis Atteka wrote: >> >> diff --git a/datapath/datapath.c b/datapath/datapath.c >> index e359ac0..44828c6 100644 >> --- a/datapath/datapath.c >> +++ b/datapath/datapath.c

Re: [ovs-dev] [PATCH] datapath: add skb mark matching and set action

2012-11-15 Thread Ansis Atteka
On Wed, Nov 14, 2012 at 1:48 AM, Jesse Gross wrote: > On Tue, Nov 13, 2012 at 9:52 AM, Ansis Atteka wrote: >> >> diff --git a/datapath/actions.c b/datapath/actions.c >> index 76c9823..5da4b74 100644 >> --- a/datapath/actions.c >> +++ b/datapath/actions.c &

[ovs-dev] [PATCHv2] datapath: add skb mark matching and set action

2012-11-15 Thread Ansis Atteka
This patch adds support for skb mark matching and set action. Signed-off-by: Ansis Atteka --- datapath/actions.c |4 datapath/compat.h | 33 + datapath/datapath.c |7 +++ datapath/flow.c | 15

[ovs-dev] [PATCHv3] datapath: add skb mark matching and set action

2012-11-17 Thread Ansis Atteka
This patch adds support for skb mark matching and set action. Signed-off-by: Ansis Atteka --- datapath/actions.c |4 datapath/compat.h | 33 + datapath/datapath.c |8 datapath/flow.c | 24

[ovs-dev] [PATCH] ovs-appctl: fix help message for ofporot/trace command

2012-11-20 Thread Ansis Atteka
The usage message for this command was wrong, because it did not specify priority as one of its arguments. Signed-off-by: Ansis Atteka --- ofproto/ofproto-dpif.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 45527e3

Re: [ovs-dev] [PATCH] bridge: Fix typo in comment.

2012-11-20 Thread Ansis Atteka
On Tue, Nov 20, 2012 at 1:09 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > vswitchd/bridge.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c > index 8f16432..998ea81 100644 > --- a/vswitchd/bridge.c > +++ b/vswitchd/b

<    1   2   3   4   5   >