On Tue, Oct 15, 2013 at 2:49 PM, Ben Pfaff <b...@nicira.com> wrote:
> On Tue, Oct 15, 2013 at 02:38:11PM -0700, Ansis Atteka wrote:
>> These are auto-generated files, so it would be better not to keep them
>> inside Open vSwitch repository.
>>
>> Behaviour before this patch was that if dot tool was not present on
>> the system, then ovs-vswitchd.conf.db.5 would have used pre-generated
>> vswitch.pic file that was already checked in the git repository. After
>> this patch ovs-vswitchd.conf.db.5 will simply not have a dot diagram,
>> if dot was not present at the time when Open vSwitch was built.
>>
>> Signed-off-by: Ansis Atteka <aatt...@nicira.com>
>
> Let's add an item to NEWS, also.
>
> automake.mk still has a few unwanted references to $(srcdir). When we
> were distributing these files and checking them in, we wanted them in
> the source directory, but now they should go in the build directory
> (since they are not source). So $(srcdir)/vswitchd/vswitch.pic and
> $(srcdir)/vswitchd/vswitch.gv should lose the $(srcdir)/ prefix. (We
> still need it on actual source files that aren't moving around.)
>
> Actually it seems like we should no longer distribute
> vswitchd/ovs-vswitchd.conf.db.5 as part of the srcdir either. It
> depends on vswitchd.pic, which we aren't distributing, which means
> that the manpage will always need to be rebuilt.
I addressed this in PATCHv4. Thanks!
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
