[ovs-dev] [PATCHv3] datapath: do not use vport type to determine presence of Geneve attributes

2014-07-29 Thread Ansis Atteka
/0xc0 [] ? __sb_end_write+0x31/0x60 [] ? touch_atime+0x10f/0x140 [] ? pipe_read+0x371/0x400 [] SYSC_sendto+0x121/0x1c0 [] ? vtime_account_user+0x54/0x60 [] ? syscall_trace_enter+0x145/0x250 [] SyS_sendto+0xe/0x10 [] tracesys+0xe1/0xe6 Signed-Off-By: Ansis Atteka --- datapath/flow_netlink.c

Re: [ovs-dev] [PATCH] datapath: do not add Geneve attributes if vport does not exist

2014-07-29 Thread Ansis Atteka
On Mon, Jul 28, 2014 at 7:54 PM, Jesse Gross wrote: > On Tue, Jul 22, 2014 at 9:34 AM, Jesse Gross wrote: >> On Mon, Jul 21, 2014 at 5:11 PM, Ansis Atteka wrote: >>> On Thu, Jul 17, 2014 at 4:08 PM, Jesse Gross wrote: >>>> One thing that I worry about is th

Re: [ovs-dev] [PATCH] tests: Turn off appctl poll_loop logging for long output.

2014-07-30 Thread Ansis Atteka
On Tue, Jul 29, 2014 at 9:54 AM, Ben Pfaff wrote: > One of the VMware internal autobuilder builds failed due to extraneous > logging in these tests of the form: > >2014-07-28T21:11:07Z|1|poll_loop|INFO|wakeup due to [POLLIN] on fd 3 >(...) at lib/stream-fd-unix.c:124 (93% CPU usage) >

Re: [ovs-dev] [PATCH v2 1/2] ovs-appctl: Add logging options.

2014-08-01 Thread Ansis Atteka
On Thu, Jul 31, 2014 at 3:11 PM, Ben Pfaff wrote: > Normally I would also add documentation for the logging options to the > ovs-appctl manpage, but I am concerned that in this case it would actually > make the manpage confusing, because one of the main purposes of ovs-appctl > is to modify the lo

[ovs-dev] [PATCHv4] datapath: do not use vport type to determine presence of Geneve attributes

2014-08-01 Thread Ansis Atteka
/0xc0 [] ? __sb_end_write+0x31/0x60 [] ? touch_atime+0x10f/0x140 [] ? pipe_read+0x371/0x400 [] SYSC_sendto+0x121/0x1c0 [] ? vtime_account_user+0x54/0x60 [] ? syscall_trace_enter+0x145/0x250 [] SyS_sendto+0xe/0x10 [] tracesys+0xe1/0xe6 Signed-Off-By: Ansis Atteka --- datapath/flow_netlink.c

Re: [ovs-dev] [PATCHv3] datapath: do not use vport type to determine presence of Geneve attributes

2014-08-01 Thread Ansis Atteka
On Fri, Aug 1, 2014 at 10:56 AM, Jesse Gross wrote: > On Tue, Jul 29, 2014 at 5:11 PM, Ansis Atteka wrote: >> diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c >> index e1eadbb..41199ff 100644 >> --- a/datapath/flow_netlink.c >> +++ b/datapath/flow_netli

Re: [ovs-dev] [PATCHv4] datapath: do not use vport type to determine presence of Geneve attributes

2014-08-01 Thread Ansis Atteka
On Fri, Aug 1, 2014 at 2:46 PM, Jesse Gross wrote: > On Fri, Aug 1, 2014 at 2:26 PM, Ansis Atteka wrote: >> This patch fixes following kernel crash that could happen, if geneve >> vport was not added yet, but revalidator thread attempted to dump flows. >> To reproduce: >

Re: [ovs-dev] [PATCH v3 1/2] ovs-appctl: Add logging options.

2014-08-04 Thread Ansis Atteka
+-- > 1 file changed, 13 insertions(+), 2 deletions(-) > Acked-by: Ansis Atteka ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3 2/2] tests: Turn off appctl poll_loop logging for long output.

2014-08-04 Thread Ansis Atteka
(93% CPU usage) > > I think this must be because these tests have tons of output and so on a > loaded machine it can take some CPU to pull it down. We don't want to fail > for that reason, so disable this logging. > > Signed-off-

Re: [ovs-dev] [PATCH] ofp-actions: Fix use-after-free in decode_NOTE.

2016-04-28 Thread Ansis Atteka
On 28 April 2016 at 14:13, Joe Stringer wrote: > When decoding the 'note' action, variable-length data could be pushed to > a buffer immediately prior to calling ofpact_finish_NOTE(). The > ofpbuf_put() could cause reallocation, in which case the finish call > could access freed memory. Fix the is

Re: [ovs-dev] [PATCH] ofp-actions: Fix use-after-free in decode_NOTE.

2016-04-29 Thread Ansis Atteka
On 29 April 2016 at 09:53, William Tu wrote: > Looks good to me. > >> I had to stop and think a little bit about the ofpact_finish() >> function's API. It gives freedom to its caller to specify whatever it >> wants as second 'ofpact' argument. However, at the end of the day >> ofpact_finish() asse

Re: [ovs-dev] [PATCH v4 1/2] ovn: Support 'dhcp_offer' action in ovn-controller

2016-05-16 Thread Ansis Atteka
On 6 May 2016 at 07:46, Numan Siddique wrote: > This patch adds a new OVN action 'dhcp_offer' to support native > DHCP in OVN. > > 'dhcp_offer' takes the DHCP options as input params. > Eg. dhcp_offer(offerip = 10.0.0.4, router = 10.0.0.1, >netmask = 255.255.255.0, lease_time = 360

Re: [ovs-dev] [PATCH v2 2/2] netdev-dpdk: Support user-defined socket attribs

2016-05-30 Thread Ansis Atteka
On Mon, May 30, 2016 at 12:29 AM, Christian Ehrhardt wrote: > On Tue, May 24, 2016 at 4:10 PM, Aaron Conole wrote: > >> Daniele Di Proietto writes: >> >> > Hi Aaron, >> > >> > I'm still a little bit nervous about calling chown on a (partially) >> > user controlled file name. >> >> I agree, that

Re: [ovs-dev] [libvirt] [PATCH v2 2/2] netdev-dpdk: Support user-defined socket attribs

2016-05-31 Thread Ansis Atteka
On 31 May 2016 at 09:36, Daniel P. Berrange wrote: > On Mon, May 30, 2016 at 01:27:46PM -0700, Ansis Atteka wrote: > > On Mon, May 30, 2016 at 12:29 AM, Christian Ehrhardt > > wrote: > > > On Tue, May 24, 2016 at 4:10 PM, Aaron Conole > wrote: > > >

Re: [ovs-dev] [libvirt] [PATCH v2 2/2] netdev-dpdk: Support user-defined socket attribs

2016-05-31 Thread Ansis Atteka
On 31 May 2016 at 10:59, Ansis Atteka wrote: > > > On 31 May 2016 at 09:36, Daniel P. Berrange wrote: > >> On Mon, May 30, 2016 at 01:27:46PM -0700, Ansis Atteka wrote: >> > On Mon, May 30, 2016 at 12:29 AM, Christian Ehrhardt >> > wrote: >> > &g

Re: [ovs-dev] [PATCH v2 0/2] vhost-user: Add the ability to control ownership/permissions

2016-06-01 Thread Ansis Atteka
On 20 May 2016 at 13:32, Aaron Conole wrote: > Currently, when using Open vSwitch with DPDK and qemu guests, the > recommended > method for joining the guests is via the dpdkvhostuser interface. This > interface uses Unix Domain sockets to communicate. When these sockets are > created, they inher

Re: [ovs-dev] [PATCH v2 0/2] vhost-user: Add the ability to control ownership/permissions

2016-06-02 Thread Ansis Atteka
On 1 June 2016 at 12:51, Aaron Conole wrote: > Ansis Atteka writes: > > > On 20 May 2016 at 13:32, Aaron Conole wrote: > > > >> Currently, when using Open vSwitch with DPDK and qemu guests, the > >> recommended > >> method for joining the gu

[ovs-dev] [PATCH] bridge: allow OVS to connect to Unix Domain Sockets outside its run directory

2016-06-02 Thread Ansis Atteka
Before this patch OVS refused to connect to a local controller that had its Unix Domain Socket outside Open vSwitch run directory (e.g. outside '/var/run/openvswitch/'). After this patch this restriction imposed by Open vSwitch itself is abandoned and OVS should be able to connect to controller's

[ovs-dev] [PATCH 1/2] IPsec: refactor out some code in OVS_MONITOR_IPSEC_START macro

2016-07-13 Thread Ansis Atteka
This OVS_MONITOR_IPSEC_START macro will be helpful in the next patch where it will be used also from tests/tunnel.at file to test that skb marking happens correctly. Otherwise, without ovs-monitor-ipsec running the ovs-vswitchd would refuse to configure ipsec_XXX tunnels. Signed-off-by: Ansis

[ovs-dev] [PATCH 2/2] tunneling: get skb marking to work properly with tunnels

2016-07-13 Thread Ansis Atteka
patch also adds anti-regression tests to prevent such breakages in the future. Signed-off-by: Ansis Atteka VMware-BZ: #1653178 --- ofproto/tunnel.c | 4 +- tests/tunnel.at | 120 +++ 2 files changed, 122 insertions(+), 2 deletions(-) di

[ovs-dev] [PATCHv2 1/2] IPsec: refactor out some code in OVS_MONITOR_IPSEC_START macro

2016-07-19 Thread Ansis Atteka
This OVS_MONITOR_IPSEC_START macro will be helpful in the next patch where it will be used also from tests/tunnel.at file to test that skb marking happens correctly. Otherwise, without ovs-monitor-ipsec running the ovs-vswitchd would refuse to configure ipsec_XXX tunnels. Signed-off-by: Ansis

[ovs-dev] [PATCHv2 2/2] tunneling: get skb marking to work properly with tunnels

2016-07-19 Thread Ansis Atteka
patch also adds anti-regression tests to prevent such breakages in the future. Signed-off-by: Ansis Atteka VMware-BZ: #1653178 --- ofproto/tunnel.c | 3 +- tests/tunnel.at | 120 +++ 2 files changed, 122 insertions(+), 1 deletion(-) di

Re: [ovs-dev] [PATCH 2/2] tunneling: get skb marking to work properly with tunnels

2016-07-19 Thread Ansis Atteka
On 14 July 2016 at 02:22, Jarno Rajahalme wrote: > > > On Jul 13, 2016, at 9:01 PM, Ansis Atteka wrote: > > > > There are two issues that this patch fixes: > > 1. it was impossible to set skb mark at all through > > NXM_NX_PKT_MARK register for tunnel pack

Re: [ovs-dev] [PATCHv2 2/2] tunneling: get skb marking to work properly with tunnels

2016-07-21 Thread Ansis Atteka
On Jul 21, 2016 2:08 PM, "Jarno Rajahalme" wrote: > > Looks good to me: > > Acked-by: Jarno Rajahalme > Thanks. Can you also review patch 1/2? > > On Jul 19, 2016, at 2:25 PM, Ansis Atteka wrote: > > > > There are two issues that this patch fixes:

Re: [ovs-dev] [PATCH] bridge: allow OVS to connect to Unix Domain Sockets outside its run directory

2016-06-08 Thread Ansis Atteka
On 8 June 2016 at 14:02, Ben Pfaff wrote: > On Thu, Jun 02, 2016 at 07:47:33PM -0700, Ansis Atteka wrote: > > Before this patch OVS refused to connect to a local controller that > > had its Unix Domain Socket outside Open vSwitch run directory (e.g. > > outside

Re: [ovs-dev] [PATCH] bridge: allow OVS to connect to Unix Domain Sockets outside its run directory

2016-06-08 Thread Ansis Atteka
On 8 June 2016 at 16:45, Ansis Atteka wrote: > > > On 8 June 2016 at 14:02, Ben Pfaff wrote: > >> On Thu, Jun 02, 2016 at 07:47:33PM -0700, Ansis Atteka wrote: >> > Before this patch OVS refused to connect to a local controller that >> > had its Unix Do

Re: [ovs-dev] [PATCH v2 2/2] netdev-dpdk: Support user-defined socket attribs

2016-06-10 Thread Ansis Atteka
On 10 June 2016 at 10:51, Aaron Conole wrote: > Aaron Conole writes: > > > Christian Ehrhardt writes: > > > >> On Tue, May 24, 2016 at 4:10 PM, Aaron Conole > wrote: > >> > >>> Daniele Di Proietto writes: > >>> > >>> > Hi Aaron, > >>> > > >>> > I'm still a little bit nervous about calling cho

Re: [ovs-dev] [PATCH v2 2/2] netdev-dpdk: Support user-defined socket attribs

2016-06-13 Thread Ansis Atteka
On 13 June 2016 at 14:36, Aaron Conole wrote: > Daniele Di Proietto writes: > > > On 10/06/2016 10:51, "Aaron Conole" wrote: > > > >>Aaron Conole writes: > >> > >>> Christian Ehrhardt writes: > >>> > On Tue, May 24, 2016 at 4:10 PM, Aaron Conole > wrote: > > > Daniele Di Proiet

[ovs-dev] [PATCH] bridge: allow OVS to interact with controller through sockets outside run dir

2016-06-20 Thread Ansis Atteka
because perhaps OVSDB manager is running on the same host as OVS. Signed-off-by: Ansis Atteka VMware-BZ: #1525857 --- lib/daemon.c | 14 ++ lib/daemon.h | 14 ++ utilities/ovs-ctl.in | 18 +++--- vswitchd/bridge.c| 5 +++-- 4 files changed

Re: [ovs-dev] [PATCH] bridge: allow OVS to connect to Unix Domain Sockets outside its run directory

2016-06-20 Thread Ansis Atteka
On 8 June 2016 at 17:17, Ansis Atteka wrote: > > > On 8 June 2016 at 16:45, Ansis Atteka wrote: > >> >> >> On 8 June 2016 at 14:02, Ben Pfaff wrote: >> >>> On Thu, Jun 02, 2016 at 07:47:33PM -0700, Ansis Atteka wrote: >>> > Before thi

[ovs-dev] [PATCH] rhel: Fix RHEL package build breakage

2016-06-23 Thread Ansis Atteka
This patch fixes following error: error: Installed (but unpackaged) file(s) found: /usr/bin/ovs-tcpdump /usr/share/man/man8/ovs-tcpdump.8.gz Signed-off-by: Ansis Atteka --- rhel/openvswitch.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rhel/openvswitch.spec.in b/rhel

Re: [ovs-dev] [PATCH] rhel: Fix RHEL package build breakage

2016-06-24 Thread Ansis Atteka
On 24 June 2016 at 13:00, Russell Bryant wrote: > On Thu, Jun 23, 2016 at 10:04 PM, Ansis Atteka wrote: > > > This patch fixes following error: > > > > error: Installed (but unpackaged) file(s) found: > >/usr/bin/ovs-tcpdump > >/usr/share/man/man8/ov

[ovs-dev] [PATCHv2] bridge: allow OVS to interact with controller through sockets outside run dir

2016-06-25 Thread Ansis Atteka
to disable self-confinement for other things like DPDK vhost-user sockets or anything else that is specifiable in OVSDB with full path. Signed-off-by: Ansis Atteka VMware-BZ: #1525857 --- NEWS | 2 ++ lib/daemon-syn.man | 1 + lib/daemon.c | 14 ++ lib/daemon

Re: [ovs-dev] [PATCH] bridge: allow OVS to interact with controller through sockets outside run dir

2016-06-25 Thread Ansis Atteka
On 22 June 2016 at 15:44, Ben Pfaff wrote: > On Mon, Jun 20, 2016 at 02:19:40PM -0700, Ansis Atteka wrote: > > Currently Open vSwitch is unable to create or connect to Unix Domain > > Sockets outside designated 'run' directory, because of fear of potential > >

[ovs-dev] [PATCHv3] bridge: allow OVS to interact with controller through sockets outside run dir

2016-06-27 Thread Ansis Atteka
to disable self-confinement for other things like DPDK vhost-user sockets or anything else that is specifiable in OVSDB with full path. Signed-off-by: Ansis Atteka VMware-BZ: #1525857 --- NEWS | 2 ++ lib/daemon-syn.man | 1 + lib/daemon.c | 22 +

Re: [ovs-dev] [PATCHv2] bridge: allow OVS to interact with controller through sockets outside run dir

2016-06-27 Thread Ansis Atteka
On 27 June 2016 at 11:37, Jesse Gross wrote: > On Sat, Jun 25, 2016 at 4:38 PM, Ansis Atteka wrote: > > diff --git a/lib/daemon.h b/lib/daemon.h > > index 4990415..742f382 100644 > > --- a/lib/daemon.h > > +++ b/lib/daemon.h > [...] > > +extern bool self_c

Re: [ovs-dev] [PATCHv3] bridge: allow OVS to interact with controller through sockets outside run dir

2016-06-27 Thread Ansis Atteka
On 27 June 2016 at 19:52, Jesse Gross wrote: > On Mon, Jun 27, 2016 at 7:20 PM, Ansis Atteka wrote: > > Currently Open vSwitch is unable to create or connect to Unix Domain > > Sockets outside designated 'run' directory, because of fear of potential > > remote

[ovs-dev] [PATCH] bridge: fix windows build

2016-06-29 Thread Ansis Atteka
Patch 81d2f75c (bridge: allow OVS to interact with controller through sockets outside run dir) broke windows build. This patch fixes that. Signed-off-by: Ansis Atteka --- lib/daemon.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/daemon.h b/lib/daemon.h index b035055

Re: [ovs-dev] [PATCH] bridge: fix windows build

2016-06-29 Thread Ansis Atteka
On 29 June 2016 at 18:24, Sairam Venugopal wrote: > Thanks for fixing this. I just sent out a patch for fixing the same. > > Acked-by: Sairam Venugopal > Thanks, for review. I pushed it. Sorry for wasting your cycles on this. > > > > On 6/29/16, 6:16 PM, "Ans

Re: [ovs-dev] [PATCH v2 2/2] netdev-dpdk: Support user-defined socket attribs

2016-07-06 Thread Ansis Atteka
On Wed, Jul 6, 2016 at 7:24 AM, Aaron Conole wrote: > Aaron Conole writes: > >> Daniele Di Proietto writes: >> >>> On 10/06/2016 10:51, "Aaron Conole" wrote: >>> Aaron Conole writes: > Christian Ehrhardt writes: > >> On Tue, May 24, 2016 at 4:10 PM, Aaron Conole wrote: >

Re: [ovs-dev] [PATCH] rhel: provide our own SELinux custom policy package

2016-02-26 Thread Ansis Atteka
On 22 February 2016 at 20:18, Flavio Leitner wrote: > On Mon, 15 Feb 2016 17:40:25 -0800 > Ansis Atteka wrote: > > > From: Ansis Atteka > > > > CentOS, RHEL and Fedora distributions ship with their own Open vSwitch > > SELinux policy that is too strict

Re: [ovs-dev] fedora: include ovs-save file in the rpm package

2016-02-26 Thread Ansis Atteka
On 23 February 2016 at 13:15, Ben Pfaff wrote: > On Sat, Feb 13, 2016 at 01:56:01PM -0800, Ansis Atteka wrote: > > Otherwise, "ovs-ctl force-reload-kmod ..." command fails with: > > > > Detected internal interfaces: br-int p1[ OK ] > >

Re: [ovs-dev] [PATCH] ovs-save: Handle MTU changes correctly.

2016-04-11 Thread Ansis Atteka
On Mon, Apr 11, 2016 at 8:27 AM, Gurucharan Shetty wrote: > The following command on ubuntu 12.04 returns null: > expr "mtu 1500" : '.*mtu \([0-9]+\)' > > But the following works correctly: > expr "mtu 1500" : '.*mtu \([0-9]\+\)' > > I am not sure about the portability implications as there > seem

[ovs-dev] [PATCH] ipsec: Do not allow ipsec_gre tunnel traffic to exit unencrypted

2016-08-29 Thread Ansis Atteka
) Signed-off-by: Ansis Atteka Reported-by: Steffen Birkeland --- debian/control | 1 + debian/ovs-monitor-ipsec | 16 ++-- tests/ofproto-macros.at | 7 +++ 3 files changed, 22 insertions(+), 2 deletions(-) diff --git a/debian/control b/debian/control index 480ff5c

Re: [ovs-dev] [PATCH] ipsec: Do not allow ipsec_gre tunnel traffic to exit unencrypted

2016-09-01 Thread Ansis Atteka
On 30 August 2016 at 02:21, Jesse Gross wrote: > On Mon, Aug 29, 2016 at 11:57 AM, Ansis Atteka wrote: > > If ipsec_gre tunnel configuration is changed in OVSDB, > > then GRE packets may sometimes exit unencrypted until > > per-tunnel IPsec policies are installed by ovs-mon

Re: [ovs-dev] [PATCH] openvswitch: Allow external IPsec tunnel management.

2016-09-22 Thread Ansis Atteka
On 20 September 2016 at 20:52, Pravin B Shelar wrote: > OVS IPsec tunnel support has issues: > 1. It only works for GRE. 2. only works on Debian. 3. It does not allow user to match on packet-mark >on packet received on tunnel ports. > Therefore following patch provide alternative to com

Re: [ovs-dev] [PATCH] ovs-lib: Fix SELinux contexts for created dirs.

2016-09-22 Thread Ansis Atteka
restorecon' is unavailable, this should be a no-op. > > VMware-BZ: #1732672 > > Signed-off-by: Joe Stringer Acked-by: Ansis Atteka I could give Tested-by, but only in 12 hours, if you are willing to wait. One thing that caught my attention is that "restorecon -R /" may t

Re: [ovs-dev] [PATCHv2] ovs-lib: Fix SELinux contexts for created dirs.

2016-09-23 Thread Ansis Atteka
restorecon' is unavailable, this should be a no-op. > > VMware-BZ: #1732672 > > Signed-off-by: Joe Stringer > Acked-by: Ansis Atteka > Thanks for taking care of this. I just did a basic test and I think your V2 patch is a good enhancement. > --- > v2: Only restore context

Re: [ovs-dev] [PATCH] openvswitch: Allow external IPsec tunnel management.

2016-09-23 Thread Ansis Atteka
On Fri, Sep 23, 2016 at 1:12 AM, pravin shelar wrote: > On Thu, Sep 22, 2016 at 11:59 AM, Ansis Atteka wrote: >> >> >> On 20 September 2016 at 20:52, Pravin B Shelar wrote: >>> >>> OVS IPsec tunnel support has issues: >>> 1. It only works for GRE

Re: [ovs-dev] [PATCH] openvswitch: deprecates support for IPsec tunnel port.

2016-09-23 Thread Ansis Atteka
switch.xml b/vswitchd/vswitch.xml > index e73023d..6381cc8 100644 > --- a/vswitchd/vswitch.xml > +++ b/vswitchd/vswitch.xml > @@ -2008,6 +2008,9 @@ > > An Ethernet over RFC 2890 Generic Routing Encapsulation over > IPv4/IPv6 > IPsec tun

Re: [ovs-dev] [PATCH] openvswitch: Allow external IPsec tunnel management.

2016-09-26 Thread Ansis Atteka
tor-ipsec.at Assuming you were able to build all other debian packages with "fakeroot debian/rules binary" after removing and editing those files, then Acked-by: Ansis Atteka Let me know, if you want me to independently verify that as well? > > > diff --git a/NEWS b/NEWS >

Re: [ovs-dev] GRE over IPsec on CentOS

2016-09-27 Thread Ansis Atteka
On Sep 26, 2016 7:02 PM, wrote: > > Hi all , > > I have been trying to test IPSEC over GRE on Centos7.3 . I am able to test on ubuntu14.04 . The ovs-monitor-ipsec daemon never was packaged (ie had *.rpm package) for CentOS. Just for debain/ubuntu. However, now we just removed debian package as w

Re: [ovs-dev] [ovsdb join 0/5] ovsdb join

2015-06-21 Thread Ansis Atteka
On 15 June 2015 at 19:35, Andy Zhou wrote: > OVSDB can be more flexible by supporting multiple schemas. Those multiple > schemas can be taken > from different releases, or on different feature sets. If the schema > tables don't overlap, > or for tables do overlap, but columns are not in conflict,

Re: [ovs-dev] [ovsdb join 2/5] ovsdb: add supporting functions for schemata

2015-06-21 Thread Ansis Atteka
On 15 June 2015 at 19:35, Andy Zhou wrote: > Add functions to support dealing with multiple schemas as a set. These It seems that you are not using plural form of "schema" consistently (i.e. in the actual code you are using "schemata"). Take a look here[ http://english.stackexchange.com/questio

Re: [ovs-dev] [ovsdb join 3/5] ovsdb: Add logic for parsing schema filenames from string

2015-06-21 Thread Ansis Atteka
On 15 June 2015 at 19:35, Andy Zhou wrote: > Any ovsdb programs that accepts a single schema file name will be > extended to accepts multiple file names. This patch implements the > s/to accepts/to accept > file name parsing logic for future patches. > > Signed-off-by: Andy Zhou > --- > ovsdb/

Re: [ovs-dev] [ovsdb join 4/5] ovsdb: expand ovsdb-tool to support multiple schemas

2015-06-21 Thread Ansis Atteka
On 15 June 2015 at 19:35, Andy Zhou wrote: > ovsdb-tool now accepts multiple schema files for all applicable options. If these schema can be joined together without compatibility error, > s/schema/[schemas|schemata] > the joined schema will be used as the runtime DB schema. > > When storing joi

Re: [ovs-dev] [ovsdb join 5/5] tests: add ovsdb-tool join schema tests

2015-06-22 Thread Ansis Atteka
On 15 June 2015 at 19:35, Andy Zhou wrote: > Add unit tests for ovsdb-tools that deals with multiple schemas. > > Signed-off-by: Andy Zhou > --- > tests/ovsdb-tool.at | 152 > > 1 file changed, 152 insertions(+) > This series don't address t

Re: [ovs-dev] [ovsdb join 2/5] ovsdb: add supporting functions for schemata

2015-06-22 Thread Ansis Atteka
On 22 June 2015 at 13:00, Andy Zhou wrote: > On Sun, Jun 21, 2015 at 1:29 PM, Ansis Atteka > wrote: > > > > > > On 15 June 2015 at 19:35, Andy Zhou wrote: > >> > >> Add functions to support dealing with multiple schemas as a set. These > > > &

Re: [ovs-dev] [ovsdb join 2/5] ovsdb: add supporting functions for schemata

2015-06-22 Thread Ansis Atteka
On 22 June 2015 at 13:31, Ansis Atteka wrote: > > > On 22 June 2015 at 13:00, Andy Zhou wrote: > >> On Sun, Jun 21, 2015 at 1:29 PM, Ansis Atteka >> wrote: >> > >> > >> > On 15 June 2015 at 19:35, Andy Zhou wrote: >> >> >&g

[ovs-dev] [PATCHv2 2/2] vlog: add "vlog/list-pattern" command

2015-06-25 Thread Ansis Atteka
This patch allows to query logging format at the runtime for each destination with "vlog/list-pattern" command. Signed-Off-By: Ansis Atteka --- NEWS | 2 ++ include/openvswitch/vlog.h | 1 + lib/vlog-unixctl.man | 3 +++ lib/vlog.c

[ovs-dev] [PATCHv2 1/2] vlog: abstract out interface to syslog daemon

2015-06-25 Thread Ansis Atteka
uses hardcoded syslog message parser when it received messages over /dev/log UNIX domain socket. Solution to those two issues would be to use the newly introduced --syslog-method=udp:127.0.0.1:514 command line argument when starting OVS. Signed-Off-By: Ansis Atteka --- NEWS

Re: [ovs-dev] [PATCHv2 1/2] vlog: abstract out interface to syslog daemon

2015-06-27 Thread Ansis Atteka
Thanks for review, Ben. I addressed your comments and pushed this. On Fri, Jun 26, 2015 at 3:57 PM, Ben Pfaff wrote: > On Thu, Jun 25, 2015 at 12:54:22PM -0700, Ansis Atteka wrote: >> This patch helps to address two issues that are present on Ubuntu >> 15.04 (and most lik

Re: [ovs-dev] [PATCHv2 2/2] vlog: add "vlog/list-pattern" command

2015-06-27 Thread Ansis Atteka
I pushed this patch to with changes you suggested. Thanks for review! On Fri, Jun 26, 2015 at 3:59 PM, Ben Pfaff wrote: > On Thu, Jun 25, 2015 at 12:54:23PM -0700, Ansis Atteka wrote: >> This patch allows to query logging format at the runtime for each destination >> with &qu

Re: [ovs-dev] [PATCH v2] Undefined symbol make_unix_socket

2015-07-06 Thread Ansis Atteka
On Wed, Jul 1, 2015 at 1:20 PM, Ben Pfaff wrote: > On Wed, Jul 01, 2015 at 07:01:44PM +, Alin Serdean wrote: >> syslog_direct_create defined in (lib/syslog-direct.c) uses make_unix_socket >> which is currently undefined on the windows build. >> >> We either can remove the new file from the cha

Re: [ovs-dev] [PATCH 3/3] ovsdb-server: support --user option

2015-09-07 Thread Ansis Atteka
Thanks, Andy, for working on this! On 3 September 2015 at 16:33, Andy Zhou wrote: > Add support for running ovsdb-server as a non-root user, specified > by the --user option. If specified, all I/O access and all > sub-processes will be perfromed as the new user. > > VMware-BZ: #1499254 > Signed

Re: [ovs-dev] [PATCH 1/3] lib: add function to switch daemon user at run time

2015-09-07 Thread Ansis Atteka
There are trailing white space characters: Applying: lib: add function to switch daemon user at run time /home/aatteka/Git/ovs/.git/rebase-apply/patch:109: trailing whitespace. { warning: 1 line adds whitespace errors. Applying: lib: Add --user for daemon Applying: ovsdb-server: support --user opt

Re: [ovs-dev] [PATCH 2/3] lib: Add --user for daemon

2015-09-07 Thread Ansis Atteka
On 3 September 2015 at 16:33, Andy Zhou wrote: > Allow daemon running as root to accept --user option, that accepts > "user:group" string as input. Performs sanity check on the input, > and store the converted uid and gid. > > daemon_become_new_user() needs to be called to make the actual > switc

Re: [ovs-dev] [PATCH 2/3] lib: Add --user for daemon

2015-09-08 Thread Ansis Atteka
On 8 September 2015 at 13:09, Andy Zhou wrote: > On Mon, Sep 7, 2015 at 5:39 PM, Ansis Atteka > wrote: > > > > > > On 3 September 2015 at 16:33, Andy Zhou wrote: > >> > >> Allow daemon running as root to accept --user option, that accepts > >

Re: [ovs-dev] Bug#701760: [PATCH] debian: Stop openvswitch after VMs managed by libvirt.

2014-05-22 Thread Ansis Atteka
I haven't looked into Debian, but I have Ubuntu 14.04 with libvirt 1.2.1: aatteka@aatteka-MacBookPro:~$ service libvirt-bin Usage: /etc/init.d/libvirt-bin COMMAND aatteka@aatteka-MacBookPro:~$ service libvirt-guests libvirt-guests: unrecognized service As you can see from output above my Ubuntu sy

[ovs-dev] [PATCH] process: block signals while spawning child processes

2014-05-27 Thread Ansis Atteka
SIGTERM. Also, since parent process never reads data from this pipe, then this bug would make parent process to consume 100% CPU by immediately waking up from the event loop. This patch will help to avoid this problem by blocking signals until child closes all its file descriptors. Signed-off-by: Ansis

[ovs-dev] [PATCHv2] process: block signals while spawning child processes

2014-05-28 Thread Ansis Atteka
SIGTERM. Also, since parent process never reads data from this pipe, then this bug would make parent process to consume 100% CPU by immediately waking up from the event loop. This patch will help to avoid this problem by blocking signals until child closes all its file descriptors. Signed-off-by: Ansis

Re: [ovs-dev] [PATCH] process: block signals while spawning child processes

2014-05-28 Thread Ansis Atteka
On Tue, May 27, 2014 at 12:52 PM, Ben Pfaff wrote: > On Tue, May 27, 2014 at 12:32:50PM -0700, Ansis Atteka wrote: >> Between fork() and execvp() calls in the process_start() >> function both child and parent processes share the same >> file descriptors. This means tha

Re: [ovs-dev] [PATCH] process: block signals while spawning child processes

2014-05-28 Thread Ansis Atteka
On Wed, May 28, 2014 at 2:53 PM, Ben Pfaff wrote: > On Wed, May 28, 2014 at 02:47:21PM -0700, Ansis Atteka wrote: >> Just curious. Do you think it would make sense to use ppoll() or >> signal_fd() instead of "self pipe trick" to handle signals? Not sure >> about

[ovs-dev] [PATCHv3] process: block signals while spawning child processes

2014-05-29 Thread Ansis Atteka
SIGTERM. Also, since parent process never reads data from this pipe, then this bug would make parent process to consume 100% CPU by immediately waking up from the event loop. This patch will help to avoid this problem by blocking signals until child closes all its file descriptors. Signed-off-by: Ansis

Re: [ovs-dev] [PATCHv2] process: block signals while spawning child processes

2014-05-29 Thread Ansis Atteka
On Wed, May 28, 2014 at 2:46 PM, Ben Pfaff wrote: > On Wed, May 28, 2014 at 02:40:23PM -0700, Ansis Atteka wrote: >> Between fork() and execvp() calls in the process_start() >> function both child and parent processes share the same >> file descriptors. This means tha

[ovs-dev] [PATCH] util: create a copy of program_name

2014-06-28 Thread Ansis Atteka
undefined if source and target buffers overlap. Signed-off-by: Ansis Atteka --- lib/util.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/util.c b/lib/util.c index 01ba6bc..74845dc 100644 --- a/lib/util.c +++ b/lib/util.c @@ -455,6 +455,10 @@ void set_progr

[ovs-dev] [PATCH] daemon: restart child process if it died before signaling its readiness

2014-06-29 Thread Ansis Atteka
persistent programming error. To reproduce use following script: while : ; do kill -SIGSEGV `cat /var/run/openvswitch/ovs-vswitchd.pid`; done Signed-Off-By: Ansis Atteka Issue: 1273550 --- lib/daemon-unix.c | 63 --- 1 file changed, 41

Re: [ovs-dev] [PATCH] util: create a copy of program_name

2014-07-03 Thread Ansis Atteka
On Thu, Jul 3, 2014 at 12:57 PM, Ben Pfaff wrote: > On Sat, Jun 28, 2014 at 02:03:15PM -0700, Ansis Atteka wrote: >> From: Ansis >> >> Commit 8a9562 ("dpif-netdev: Add DPDK netdev.") reversed sequence >> in which set_program_name() and proctitle_init() functi

[ovs-dev] [PATCH] util: fix compile warnings

2014-07-04 Thread Ansis Atteka
C90 forbids mixed declarations and code [-Werror=declaration-after-statement] (affected only branch-2.3 that is C90 compliant and not the master) Reported-By: Joe Stringer Reported-By: Lorand Jakab Signed-Off-By: Ansis Atteka --- lib/util.c | 11 +++ lib/util.h | 2 +- 2 fil

Re: [ovs-dev] [PATCH] util: create a copy of program_name

2014-07-04 Thread Ansis Atteka
I sent a patch for review. There is actually another warning present only on branch-2.3. On Thu, Jul 3, 2014 at 11:06 PM, Lori Jakab wrote: > On 7/4/14, 12:51 AM, Ansis Atteka wrote: >> >> On Thu, Jul 3, 2014 at 12:57 PM, Ben Pfaff wrote: >>> >>> On Sat, Jun 28

Re: [ovs-dev] [PATCH] util: fix compile warnings

2014-07-07 Thread Ansis Atteka
present in master though. On Mon, Jul 7, 2014 at 8:09 AM, Ben Pfaff wrote: > On Fri, Jul 04, 2014 at 12:33:03PM -0700, Ansis Atteka wrote: >> This patch fixes two compile warnings introduced by commit >> 64b73291 ("util: create a copy of program_name"): >> 1.

Re: [ovs-dev] [PATCH] util: fix compile warnings

2014-07-07 Thread Ansis Atteka
On Sun, Jul 6, 2014 at 3:37 PM, Joe Stringer wrote: > I feel like this is easier to follow if there's only one #ifdef block. Thanks for pointing this out. This can actually be factorized out even more by taking out free(program_name) out of both #ifdefs. Will send v2 patch soon. > > We could comb

[ovs-dev] [PATCHv2] util: fix compile warnings

2014-07-07 Thread Ansis Atteka
C90 forbids mixed declarations and code [-Werror=declaration-after-statement] (affected only branch-2.3 that is C90 compliant and not the master) Reported-By: Joe Stringer Reported-By: Lorand Jakab Signed-Off-By: Ansis Atteka --- lib/util.c | 14 ++ lib/util.h |2 +- 2 fil

[ovs-dev] [PATCHv2] daemon: restart child process if it died before signaling its readiness

2014-07-07 Thread Ansis Atteka
or system error. To reproduce use following script: while : ; do kill -SIGSEGV `cat /var/run/openvswitch/ovs-vswitchd.pid`; done Signed-Off-By: Ansis Atteka VMware-BZ: 1273550 --- lib/daemon-unix.c | 63 ++--- 1 file changed, 41 insertions

Re: [ovs-dev] [PATCH] daemon: restart child process if it died before signaling its readiness

2014-07-07 Thread Ansis Atteka
On Thu, Jul 3, 2014 at 1:23 PM, Ben Pfaff wrote: > On Sun, Jun 29, 2014 at 08:37:25PM -0700, Ansis Atteka wrote: >> From: Ansis > > Fix up the patch author? > >> The child process (the one being monitored) could die before it was able >> to call fork_notify_startup(

Re: [ovs-dev] [PATCH] tests: Fix "megaflow disabled" test.

2014-07-07 Thread Ansis Atteka
fproto-dpif.at |4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Acked-by: Ansis Atteka ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCHv2] daemon: restart child process if it died before signaling its readiness

2014-07-10 Thread Ansis Atteka
On Thu, Jul 10, 2014 at 10:39 AM, Ben Pfaff wrote: > On Mon, Jul 07, 2014 at 05:38:47PM -0700, Ansis Atteka wrote: >> The child process (the one being monitored) could die before it was able >> to call fork_notify_startup() function. If such situation arises, then >> pa

[ovs-dev] [PATCH] datapath: do not add Geneve attributes if vport does not exist

2014-07-17 Thread Ansis Atteka
[] ? __sb_end_write+0x31/0x60 [] ? touch_atime+0x10f/0x140 [] ? pipe_read+0x371/0x400 [] SYSC_sendto+0x121/0x1c0 [] ? vtime_account_user+0x54/0x60 [] ? syscall_trace_enter+0x145/0x250 [] SyS_sendto+0xe/0x10 [] tracesys+0xe1/0xe6 Signed-Off-By: Ansis Atteka --- datapath/flow_netlink.c |2 +- 1 file

[ovs-dev] [PATCHv2] datapath: do not add Geneve attributes if vport does not exist

2014-07-21 Thread Ansis Atteka
[] ? __sb_end_write+0x31/0x60 [] ? touch_atime+0x10f/0x140 [] ? pipe_read+0x371/0x400 [] SYSC_sendto+0x121/0x1c0 [] ? vtime_account_user+0x54/0x60 [] ? syscall_trace_enter+0x145/0x250 [] SyS_sendto+0xe/0x10 [] tracesys+0xe1/0xe6 Signed-Off-By: Ansis Atteka --- datapath/flow_netlink.c | 14

Re: [ovs-dev] [PATCH] datapath: do not add Geneve attributes if vport does not exist

2014-07-21 Thread Ansis Atteka
On Thu, Jul 17, 2014 at 4:08 PM, Jesse Gross wrote: > On Thu, Jul 17, 2014 at 3:46 PM, Ansis Atteka wrote: >> diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c >> index 5f975a1..a4108c0 100644 >> --- a/datapath/flow_netlink.c >> +++ b/datapath/flow_netl

Re: [ovs-dev] [rhel --user v2 7/7] rhel: run daemons as the ovs user

2015-12-21 Thread Ansis Atteka
On 27 November 2015 at 05:35, Flavio Leitner wrote: > On Fri, Nov 20, 2015 at 03:33:20AM -0800, Andy Zhou wrote: > > Make RHEL systemd distributions start OVS and OVN daemons under user > > ovs. The 'ovs' user and group will be created at the openvswitch RPM > > installtion time. > > > Hi Flavio.

Re: [ovs-dev] [rhel --user v2 7/7] rhel: run daemons as the ovs user

2015-12-21 Thread Ansis Atteka
On 21 December 2015 at 15:46, Ansis Atteka wrote: > > > On 27 November 2015 at 05:35, Flavio Leitner wrote: > >> On Fri, Nov 20, 2015 at 03:33:20AM -0800, Andy Zhou wrote: >> > Make RHEL systemd distributions start OVS and OVN daemons under user >> > o

[ovs-dev] [PATCH] debian: Remove old PKI directory migration code

2015-12-22 Thread Ansis Atteka
would be, if someone would be upgrading from Open vSwitch 1.3 or older version directly to 2.5 without using any intermediary upgrade releases. Signed-Off-By: Ansis Atteka --- debian/openvswitch-pki.postinst| 8 debian/openvswitch-pki.postrm | 5 - debian

Re: [ovs-dev] [PATCH] debian: Remove old PKI directory migration code

2015-12-23 Thread Ansis Atteka
On 22 December 2015 at 22:11, Ben Pfaff wrote: > On Tue, Dec 22, 2015 at 06:41:35PM -0800, Ansis Atteka wrote: > > Open vSwitch 1.3 and older was creating certificates and private > > key in /usr/share/openvswitch/pki. However, since PKI directory > > is mutable, then this

Re: [ovs-dev] [PATCH] ovs-vsctl: add caller information by appending comment

2016-01-04 Thread Ansis Atteka
On Wed, Dec 23, 2015 at 9:41 AM, Ben Pfaff wrote: > I think maybe you misinterpreted what I meant when I said "every > caller". When I said that, I meant "every program that invokes > ovs-vsctl", not the entire call stack. William came to me to discuss this approach, If we both understood it cor

Re: [ovs-dev] [PATCH] ovs-vsctl: add caller information by appending comment

2016-01-04 Thread Ansis Atteka
On 4 January 2016 at 10:18, Ben Pfaff wrote: > On Mon, Jan 04, 2016 at 09:36:34AM -0800, Ansis Atteka wrote: > > On Wed, Dec 23, 2015 at 9:41 AM, Ben Pfaff wrote: > > > I think maybe you misinterpreted what I meant when I said "every > > > caller". When I s

[ovs-dev] [PATCH] rhel: provide our own SELinux custom policy package

2016-01-19 Thread Ansis Atteka
enied I did not test all Open vSwitch features so there still could be some OVS configuration that would get "Permission denied" errors. Since, Open vSwitch daemons on Ubuntu 15.10 by default run under "unconfined" SELinux domain, then there is no need to create a similar debia

[ovs-dev] [PATCHv2 branch2-4] rhel: provide our own SELinux custom policy package

2016-01-20 Thread Ansis Atteka
an package for Ubuntu, because it works on default Ubuntu installation. Signed-Off-By: Ansis Atteka --- INSTALL.SELinux.md | 133 +++ Makefile.am | 2 + README.md| 2 + rhel/.gitignore

Re: [ovs-dev] [PATCHv2 branch2-4] rhel: provide our own SELinux custom policy package

2016-01-20 Thread Ansis Atteka
On 20 January 2016 at 15:36, Ben Pfaff wrote: > On Wed, Jan 20, 2016 at 03:34:49PM -0800, Ben Pfaff wrote: > > On Wed, Jan 20, 2016 at 02:59:03PM -0800, Ansis Atteka wrote: > > > CentOS, RHEL and Fedora distributions ship with their own Open vSwitch > > > SELinux po

Re: [ovs-dev] [PATCHv2 branch2-4] rhel: provide our own SELinux custom policy package

2016-01-20 Thread Ansis Atteka
On 20 January 2016 at 16:13, Ansis Atteka wrote: > > > On 20 January 2016 at 15:36, Ben Pfaff wrote: > >> On Wed, Jan 20, 2016 at 03:34:49PM -0800, Ben Pfaff wrote: >> > On Wed, Jan 20, 2016 at 02:59:03PM -0800, Ansis Atteka wrote: >> > > CentOS, RHEL a

  1   2   3   4   5   >