On Wed, Jul 1, 2015 at 1:20 PM, Ben Pfaff <b...@nicira.com> wrote:
> On Wed, Jul 01, 2015 at 07:01:44PM +0000, Alin Serdean wrote:
>> syslog_direct_create defined in (lib/syslog-direct.c) uses make_unix_socket
>> which is currently undefined on the windows build.
>>
>> We either can remove the new file from the chain but this patch proposes
>> to define a wrapper to make_unix_socket in which we return EINVAL.
>>
>> This will avoid this kind of problems in the future.
>>
>> Signed-off-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com>
>> Acked-by: Eitan Eliahu <elia...@vmware.com>
>
> It might be better to just not build syslog-direct at all on Windows,
> since it's never going to do anything useful there (as far as I know).
>
> Ansis, what do you think?

In theory syslog-direct could still be used for logging over UDP
sockets. Though I am not familiar if any daemons on Windows could
actually make use of that.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to