Hi Guru,
Will take a look into it.
Alin.
-Mesaj original-
De la: Gurucharan Shetty [mailto:shet...@nicira.com]
Trimis: Saturday, July 11, 2015 9:08 AM
Către: Eitan Eliahu
Cc: Alin Serdean; Nithin Raju; dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH v2] dpif_probe_feature not
Acked-by: Alin Gabriel Serdean
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis
Trimis: Friday, July 10, 2015 11:48 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH] datapath-windows: Fixed spelling errors in OVS
Solved some spelling
Just one small nit think you need to rebase. Could not apply the patch on
master.
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Alin Serdean
Trimis: Monday, July 13, 2015 2:19 PM
Către: Sorin Vinturis; dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH
The patch is valid from the windows datapath point of view:
Acked-by: Alin Gabriel Serdean
I was planning to send a patch on master to disable DPIF_FP_PROBE in the
windows datapath, if you wish we could put it on top of 2.4 and completely
ditch the special case in userspace for windows.
Alin.
warning C4098: 'dpif_netlink_init_flow_del' : 'void' function returning a value
Signed-off-by: Alin Gabriel Serdean
---
lib/dpif-netlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
index 6838def..3650682 100644
--- a/lib/dpif-
A packet which will hit that specific flow will only be sent out encapsulated
with the first tunnelling information.
This patch saves the initial packet vport, source port and NIC index for
further use of the currently implemented pipeline and ignores the latter if it
is the last tunnelling port.
If we have a flow rule in the following form:
actions=strip_vlan,set_tunnel:0x3e9,15,16,17 (Where port 15, 16 and 17 are
VXLAN tunnels with different tunnelling information)
A packet which will hit that specific flow will only be sent out encapsulated
with the first tunnelling information.
This
+1
-Mesaj original-
De la: Ben Pfaff [mailto:b...@nicira.com]
Trimis: Monday, July 13, 2015 6:16 PM
Către: Alin Serdean
Cc: Gurucharan Shetty; dev
Subiect: Re: [ovs-dev] [PATCH] dpif-netlink: Suppress DPIF_FP_PROBE here
instead of in ofproto-dpif.
On Mon, Jul 13, 2015 at 02:03:58PM
Beside the update to ovsDatapathSetPolicy, the rest of changes are cosmetic,
to clarify the fact that when parsing netlink attributes the flow policy array
size should be used.
This patch also initialize all netlink attributes before parsing them.
Signed-off-by: Alin Gabriel Serdean
---
datapat
Update netlink attribute parsing to use the array size of the
appropriate policy.
Alin Gabriel Serdean (4):
datapath-windows: Update datapath policy
datapath-windows: Update flow policies
datapath-windows: Update packet policies
datapath-windows: Update vport policies
datapath-windows/ov
Update netlink attribute parsing to use the appropriate policy array size.
This patch also initialize all netlink attributes before parsing them.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Vport.c | 109 ++--
1 file changed, 39 insertions
Update netlink attribute parsing to use the appropriate policy array size.
Return NL_ERROR_NOENT which is the equivalent ENOENT if we failed
to install, modify or get a flow.
This patch also initialize all netlink attributes before parsing them.
Clean-up: remove some dead code.
Signed-off-by: A
Update netlink attribute parsing to use the appropriate policy array size.
This patch also initialize all netlink attributes before parsing them.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/User.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
di
Use tunnel key information on the IP header preceding the VXLAN header.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Vxlan.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/datapath-windows/ovsext/Vxlan.c b/datapath-windows/ovsext/Vxlan.c
inde
This patch surpresses flow attribute probing in the windows datapath.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Flow.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c
index 3a6c788..
Oops...
You're right Eitan, I will add a separate variable for it and respin the patch.
Alin.
-Mesaj original-
De la: Eitan Eliahu [mailto:elia...@vmware.com]
Trimis: Monday, July 13, 2015 7:42 PM
Către: Alin Serdean; dev@openvswitch.org
Subiect: RE: [PATCH] datapath-windows: U
Use tunnel key information on the IP header preceding the VXLAN header.
Signed-off-by: Alin Gabriel Serdean
---
v2: use separate variable to store the number of transmitted bytes
---
datapath-windows/ovsext/Vxlan.c | 13 -
datapath-windows/ovsext/Vxlan.h | 1 +
2 files changed, 9 in
Release the switch context dispatch lock after all possible processing
is done over the vport.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Vport.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/V
This patch sets additional information about the driver used by various
applications.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/.gitignore|1 +
datapath-windows/ovsext/ovsext.rc | 104 ++-
datapath-windows/ovsext/ovsext.vcxproj |1 +
datapath-windows/ovse
I am biased about the patch since this patch is already in:
https://github.com/openvswitch/ovs/commit/216e1c149a5c6d83884db447e16d30e063e1275d
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ben Pfaff
Trimis: Monday, July 13, 2015 8:54 PM
Către: Sorin Vint
Acked-by: Alin Gabriel Serdean
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis
Trimis: Friday, July 10, 2015 11:27 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when cleaning up the
VXLAN tunnel
Wh
Sorry forgot to mention in the commit notes, yes please apply it on 2.4 as well.
Alin
-Mesaj original-
De la: Ben Pfaff [mailto:b...@nicira.com]
Trimis: Wednesday, July 15, 2015 8:42 PM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH v2] datapath-windows
Sorry forgot to mention in the commit notes, yes please apply it on 2.4 as well.
Alin.
-Mesaj original-
De la: Ben Pfaff [mailto:b...@nicira.com]
Trimis: Wednesday, July 15, 2015 8:46 PM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] datapath-windows: update
Hi Jarno,
This is breaking the windows build
(https://ci.appveyor.com/project/blp/ovs/build/1.0.459):
lib/classifier.c(1355) : error C2229: struct '' has an illegal
zero-sized array.
The problem is the following
(https://msdn.microsoft.com/en-us/library/0scy7z2d.aspx ):
https://github.com/open
If we have a flow rule in the following form:
actions=strip_vlan,set_tunnel:0x3e9,15,16,17 (Where port 15, 16 and 17 are
VXLAN tunnels with different tunnelling information)
A packet which will hit that specific flow will only be sent out encapsulated
with the first tunnelling information.
This
Alin.
-Mesaj original-
De la: Ben Pfaff [mailto:b...@nicira.com]
Trimis: Thursday, July 16, 2015 10:27 AM
Către: Alin Serdean
Cc: Jarno Rajahalme; dev@openvswitch.org
Subiect: Re: [ovs-dev] [RFC PATCH v2 3/7] flow: Always inline miniflows.
On Thu, Jul 16, 2015 at 01:35:14AM +, Alin Se
output1.
The same calls will be done for output2 but in this case we lost the original
srcVportNo.
I hope it makes sense.
Alin.
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Thursday, August 27, 2015 10:44 PM
Către: Alin Serdean
Cc: dev@openvswitch.org
Sub
https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/Actions.c#L995
).
Alin.
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Friday, August 28, 2015 12:24 AM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH v4] datapath-windows
Change variable name from nlAttrs to flowAttrs.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Flow.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c
index 8117cf7..58bdd42 100644
---
1_0_2a version not available for download.
Signed-off-by: Alin Gabriel Serdean
---
appveyor.yml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/appveyor.yml b/appveyor.yml
index 370de3f..d3d87b3 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -15,9 +15,9 @@ init:
I would like mine better just for the variable name.
Alin.
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Saturday, August 29, 2015 12:10 AM
Către: Ben Pfaff
Cc: Alin Serdean ; dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] datapatb-windows: unbreak hyperv
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis
Trimis: Tuesday, September 1, 2015 3:16 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH] datapath-windows: Proper cleanup in case of driver
init failure
Sign
I forgot to add you in the chain Ben. Sorry. Next time will let you know as
well.
Frequency is ok IMO.
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ben Pfaff
Trimis: Tuesday, September 1, 2015 11:37 PM
Către: Nithin Raju
Cc: dev@openvswitch.org
Subie
If we have a flow rule of the following form:
actions=strip_vlan,set_tunnel:0x3e9,15,16,17 (Where port 15, 16 and 17 are
VXLAN OF ports with different tunnelling information)
Current implementation is that if a packet will hit that specific flow,
only one packet will be sent out with the first t
Currently when running the vswitch daemon we get a lot of messages of the
form:
2015-09-10T23:04:21Z|07255|dpif(revalidator11)|WARN|system@ovs-system: failed
to flow_del (Invalid argument).
The userspace expects after sending a delete flow command, to receive the flow
key of the deleted flow.
Cur
Windows does not support VXLAN hardware offloading.
Currently we do not compute IP/TCP/UDP checksums for the inner packet. This
patch computes the checksums mentioned above in regards with the enabled
settings.
i.e. if IP checksum offloading is enabled for the inner packet we compute it.
The same
Add NETLINK defines for MSVC compiling
Signed-off-by: Alin Gabriel Serdean
---
lib/netlink.h | 32
1 file changed, 32 insertions(+)
diff --git a/lib/netlink.h b/lib/netlink.h
index f9234da..c46a5d0 100644
--- a/lib/netlink.h
+++ b/lib/netlink.h
@@ -214,4 +214,3
Add the NETLINK and DPIF objects to the openvswitch archive for windows.
Signed-off-by: Alin Gabriel Serdean
---
lib/automake.mk | 17 +
1 file changed, 17 insertions(+)
diff --git a/lib/automake.mk b/lib/automake.mk
index 0997df5..d93e9af 100644
--- a/lib/automake.mk
+++ b/lib
Bypass epoll_ctl, epoll_create and epoll_wait functions on MSVC.
Signed-off-by: Alin Gabriel Serdean
---
lib/dpif-linux.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c
index bc284ab..7cf6eff 100644
--- a/lib/dpif-linux.c
+++ b/lib/dpif-
Do not bypass dpif_linux_class for the creation of dpif_class when compiling
with MSVC. This will allow the code behind dpif-linux interface to run.
Signed-off-by: Alin Gabriel Serdean
---
lib/dpif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dpif.c b/lib/dpif.c
inde
Do not bypass the register of the netdev_linux_class, netdev_internal_class,
netdev_tap_class and netdev_vport_tunnel_register when compiling
with MSVC. This will allow the code behind netdev-linux interface to run.
Signed-off-by: Alin Gabriel Serdean
---
lib/netdev.c | 2 +-
1 file changed, 1
Change the vlandev_get_class to vlandev_linux_class instead of
vlandev_stub_class when compiling with MSVC.
This will allow the code behind dpifnetdev-linuxlinux interface to run.
Signed-off-by: Alin Gabriel Serdean
---
lib/vlandev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
di
Change the defines NLMSG_ALIGNTO and NLA_ALIGNTO defines to 0.
Change the macros NLA_ALIGN and NLMSG_ALIGN to SIZE.
Signed-off-by: Alin Gabriel Serdean
---
lib/netlink-protocol.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/lib/netlink-protocol.h b/lib/netlink-protocol.h
ind
Bypass ALIGNED_CAST on CMSG_DATA when compiling on MSVC. Ignore the code
behind netdev_linux_rxq_drain as well.
Signed-off-by: Alin Gabriel Serdean
---
lib/netdev-linux.c | 4
1 file changed, 4 insertions(+)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index 1780639..1b2196f 100644
Ignore HAVE_NETLINK macro when compiling with MSVC this will allow the
inclusion of the netlink-socket.h.
Signed-off-by: Alin Gabriel Serdean
---
lib/netlink-socket.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/netlink-socket.h b/lib/netlink-socket.h
index 8ac201a..2b28131 100644
-
Change the size of the padding to 0 in the function nl_msg_put_uninit.
Signed-off-by: Alin Gabriel Serdean
---
lib/netlink.c | 4
1 file changed, 4 insertions(+)
diff --git a/lib/netlink.c b/lib/netlink.c
index c08a557..17a8885 100644
--- a/lib/netlink.c
+++ b/lib/netlink.c
@@ -174,7 +174,
Add the newly created headers in include/windows/* to
include/windows/automake.mk.
Signed-off-by: Alin Gabriel Serdean
---
include/windows/automake.mk | 15 +++
1 file changed, 15 insertions(+)
diff --git a/include/windows/automake.mk b/include/windows/automake.mk
index 4d5a42c..464
Adding CreateFile, WriteFile, ReadFile and CloseHandle instead of linux
counterparts when compiling netlink-socket.c with MSVC. Also add socket pid
generation function that will later on will be needed in the kernel
extension.
Signed-off-by: Alin Gabriel Serdean
---
lib/netlink-socket.c | 149 ++
Add headers structures, typedefs and defines needed to compile the files
lib/dpif-linux.c, lib/dpif.c, lib/netdev-linux.c, lib/netdev.c,
lib/netlink-socket.c, lib/netlink.c and lib/vlandev.c.
Signed-off-by: Alin Gabriel Serdean
---
include/windows/linux/ethtool.h| 100
include/w
Add the structure sockaddr_nl to netlink-protocol.h for MSVC. Also remove
some warnings in netlink-socket.c when using MSVC.
Signed-off-by: Alin Gabriel Serdean
---
lib/netlink-protocol.h | 10 ++
lib/netlink-socket.c | 4 ++--
2 files changed, 12 insertions(+), 2 deletions(-)
diff -
Add defines needed to compile netlink-socket.c and netlink.c.
Add wrappers for the functions sendmsg and recvmsg. They can also be added to
another file instead of defining them inlined.
Add a wrapper and the functionality behind it for syconf.
Add the newly created files to the noinst_HEADERS i
For our kernel extension we do not take into consideration the padding
thus remove it.
Add MAX_LINKS define needed for nl_pool.
Add NETLINK_ROUTE needed to compile rtnetlink-link.
Signed-off-by: Alin Gabriel Serdean
---
lib/netlink-protocol.h | 14 ++
lib/netlink.c | 4 ++
Bypass the error compilation when compiling under MSVC.
Signed-off-by: Alin Gabriel Serdean
---
lib/netlink-socket.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/netlink-socket.h b/lib/netlink-socket.h
index d53db4e..2b9ec52 100644
--- a/lib/netlink-socket.h
+++ b/lib/netlink-socket
Add the structure sockaddr_nl to netlink-socket.c when compiling under
MSVC.
Add two functions set_sock_pid_in_kernel and portid_next. This will allow
the channel identification for the kernel extension to send back messages.
Replace send with WriteFile equivalent and ignore nl_sock_drain for the
Add netlink related files to the windows build.
Signed-off-by: Alin Gabriel Serdean
---
lib/automake.mk | 13 +
1 file changed, 13 insertions(+)
diff --git a/lib/automake.mk b/lib/automake.mk
index 0997df5..deaf0fc 100644
--- a/lib/automake.mk
+++ b/lib/automake.mk
@@ -319,6 +319,1
1:38 AM
To: Alin Serdean
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 03/14] Ignore epoll specific functions in case of
MSVC
On Fri, Jul 11, 2014 at 01:01:26AM +, Alin Serdean wrote:
> Bypass epoll_ctl, epoll_create and epoll_wait functions on MSVC.
>
> Signed-off-by: Ali
You are right it will fit into a more broader view.
We will also make changes to the kernel extension to accommodate the padding.
Kind Regards,
Alin.
From: Ben Pfaff [b...@nicira.com]
Sent: Tuesday, July 22, 2014 9:07 PM
To: Alin Serdean
Cc: dev
You are right Ben I will #ifndef out the local variables and change the code to
be inline with the coding style.
Kind Regards,
Alin.
From: Ben Pfaff [b...@nicira.com]
Sent: Tuesday, July 22, 2014 9:14 PM
To: Alin Serdean
Cc: dev@openvswitch.org
Subject
...@nicira.com]
Sent: Tuesday, July 22, 2014 9:05 PM
To: Alin Serdean
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 1/5] Add defines, enums and headers for MSVC
On Thu, Jul 17, 2014 at 07:33:03PM +, Alin Serdean wrote:
> Add defines needed to compile netlink-socket.c and netlin
I can change the filename after the patch gets merged no problem :).
Thank you,
Alin.
-Mesaj original-
De la: Ben Pfaff [mailto:b...@nicira.com]
Trimis: Wednesday, September 17, 2014 11:38 PM
Către: Eitan Eliahu
Cc: Alin Serdean; Nithin Raju; dev@openvswitch.org
Subiect: Re: [ovs-dev
Did a full clone->autoreconf->make->make check under Linux did not see any
issues.
Alin.
-Mesaj original-
De la: Eitan Eliahu [mailto:elia...@vmware.com]
Trimis: Wednesday, September 17, 2014 1:47 PM
Către: Ben Pfaff
Cc: Alin Serdean; Nithin Raju; dev@openvswitch.org
Subiect:
I will rebase and also the filename change in V2.
-Mesaj original-
De la: Ben Pfaff [mailto:b...@nicira.com]
Trimis: Wednesday, September 17, 2014 2:06 PM
Către: Alin Serdean
Cc: Eitan Eliahu; 'Nithin Raju'; dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] Changes needed for
original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Wednesday, September 17, 2014 3:16 PM
Către: Alin Serdean
Cc: Eitan Eliahu; Ben Pfaff; dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] Changes needed for dpif-linux to compile under
MSVC
On Sep 17, 2014, at 1:11 PM, Alin
Ok will update it to dpif_netlink_vport*.
-Mesaj original-
De la: Ben Pfaff [mailto:b...@nicira.com]
Trimis: Wednesday, September 17, 2014 3:37 PM
Către: Alin Serdean
Cc: Nithin Raju; Eitan Eliahu; dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] Changes needed for dpif-linux to
Unfortunately there some special characters in dpif-linux.c
that do not allow me to send the patch normally.
Trying via attachment.
Short description:
The patch contains the necessary modifications to compile and also to run
under MSVC.
Added the files to the build system and also changed dpif_
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: Samuel Ghinet
Trimis: Tuesday, September 23, 2014 3:46 PM
Către: dev@openvswitch.org
Cc: nit...@vmware.com; Ankur Sharma; ssaur...@vmware.com; Alin Serdean;
elia...@vmware.com
Subiect: [PATCH v2] datapath-windows: fix
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: Samuel Ghinet
Trimis: Wednesday, September 24, 2014 5:01 PM
Către: dev@openvswitch.org
Cc: Alin Serdean; nit...@vmware.com; ssaur...@vmware.com; elia...@vmware.com;
Ankur Sharma; kg...@vmware.com
Subiect: [PATCH v3] datapath
Some minor formatting issues.
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: Samuel Ghinet
Trimis: Wednesday, September 24, 2014 6:41 PM
Către: dev@openvswitch.org
Cc: Alin Serdean; elia...@vmware.com; nit...@vmware.com; ssaur...@vmware.com;
Ankur Sharma; kg...@vmware.com
Hi Eitan,
1. Git apply whitespaces
$ git apply ovs-dev-datapath-windows-Event-read-handler.patch
ovs-dev-datapath-windows-Event-read-handler.patch:108: trailing whitespace.
* Utility function to fill up information about the state of a port in a reply
ovs-dev-datapath-windows-Event-read-handler.p
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Wednesday, September 24, 2014 10:16 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v1 01/10] datapath-windows: move OVS_MESSAGE to
Netlink.h
Moved the
Hi Ankur,
As Eitan was mentioning drop:
nlMsg->nlmsgLen = NLMSG_ALIGN(NlBufSize(nlBuf));
I see you declaring the following structure but never used:
/* Structure to hold arguments needed by NlFillOvsMsg */
typedef struct _NL_FILL_ARGS {
UINT16 nlmsgType;
UINT8 genlCmd;
UINT8 vers
Think it would be a good idea to inline the functions.
Also maybe add asserts to nla.
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Wednesday, September 24, 2014 10:16 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v1 03/10
Maybe drop ret because it is confusing.
return TRUE;
//goto done;
...
return TRUE;
done:
return FALSE;
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Wednesday, September 24, 2014 10:16 AM
Către: dev@openvswitch.org
Subie
Sounds good to me.
Alin.
-Mesaj original-
De la: Ankur Sharma [mailto:ankursha...@vmware.com]
Trimis: Thursday, September 25, 2014 4:24 AM
Către: Alin Serdean; dev@openvswitch.org
Subiect: RE: [ovs-dev] [PATCH v1 03/10] datapath-windows/Netlink: Added
NlAttrLen API
Hi Alin,
Yes Eitan
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Wednesday, September 24, 2014 10:16 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v1 05/10] datapath-windows/Netlink: Fixed
NlAttrParseNested
NlAttr
$ git apply
ovs-dev-v1-06-10-datapath-windows-Flow.c-Basic-support-for-add-flow..patch
ovs-dev-v1-06-10-datapath-windows-Flow.c-Basic-support-for-add-flow..patch:12:
trailing whitespace.
{ .cmd = OVS_FLOW_CMD_NEW,
warning: 1 line adds whitespace errors.
Acked-by: Alin Gabriel Se
In OvsFlowNlNewCmdHandler you could drop the following commented lines:
NTSTATUS rc = STATUS_SUCCESS;
POVS_MESSAGE msgIn = (POVS_MESSAGE)usrParamsCtx->inputBuffer;
POVS_MESSAGE msgOut = (POVS_MESSAGE)usrParamsCtx->outputBuffer;
PNL_MSG_HDR nlMsgHdr = &(msgIn->nlMsg);
PGENL_MSG_H
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Wednesday, September 24, 2014 10:16 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v1 08/10] datapath-windows/Flow.c: FLOW_SET command
handler.
Regis
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Wednesday, September 24, 2014 10:16 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v1 09/10] datapath-windows/Flow.c: FLOW_DEL command
handler.
Regis
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Wednesday, September 24, 2014 10:16 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v1 10/10] datapath-windows/Flow.c: DEL_FLOWS command
handler.
Add
Just forgot the following:
$ git apply
ovs-dev-v1-10-10-datapath-windows-Flow.c-DEL_FLOWS-command-handler..patch
ovs-dev-v1-10-10-datapath-windows-Flow.c-DEL_FLOWS-command-handler..patch:20:
trailing whitespace.
if ((genlMsgHdr->cmd == OVS_FLOW_CMD_DEL) &&
warning: 1 line adds whitespace err
Tested-by: Alin Gabriel Serdean
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: Sorin Vinturis
Trimis: Wednesday, September 24, 2014 12:43 PM
Către: dev@openvswitch.org
Cc: Alin Serdean; nit...@vmware.com; Sorin Vinturis
Subiect: [PATCH] datapath-windows: Missed packets are
Tested-by: Alin Gabriel Serdean
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: Samuel Ghinet
Trimis: Thursday, September 25, 2014 2:44 AM
Către: dev@openvswitch.org
Cc: Alin Serdean; nit...@vmware.com; elia...@vmware.com; Ankur Sharma;
ssaur...@vmware.com
Subiect: [PATCH v3
1. ovs-dev-v1-datapath-windows-Event-read-handler.patch:12: new blank line at
EOF.
+
warning: 1 line adds whitespace errors.
2. OvsPostEvent adds elements to the queue can you please find a similar name
for OvsRemoveEventEntry
3. Really don't like that we have to push in:
+#pragma warning( pus
-Mesaj original-
De la: Eitan Eliahu [mailto:elia...@vmware.com]
Trimis: Thursday, September 25, 2014 7:48 AM
Către: Alin Serdean; dev@openvswitch.org
Subiect: RE: [ovs-dev] [PATCH v1] datapath-windows Event read handler
Alin, this warning is used to warn about constant in a condition
It was not guarded until now so was wondering why guard it now :), unless that
you want to use this as a mark for later on.
Alin.
De la: Eitan Eliahu [mailto:elia...@vmware.com]
Trimis: Thursday, September 25, 2014 8:34 AM
Către: Alin Serdean; dev@openvswitch.org
Subiect: RE: [ovs-dev] [PATCH
None what so ever. Was just wondering if there was a hidden meaning to it that
I missed :).
Alin.
De la: Eitan Eliahu [mailto:elia...@vmware.com]
Trimis: Thursday, September 25, 2014 8:41 AM
Către: Alin Serdean; dev@openvswitch.org
Subiect: RE: [ovs-dev] [PATCH v1] datapath-windows Event read
The following script leverage's the advantages of WMI infrastructure
offered in Hyper-V.
This scripts allows the user to change the
Msvm_EthernetPortAllocationSettingData property of a VM network adapter
connected to a Hyper-V Virtual Switch.
Usage:
import-module .\OVS.psm1
$vnic = Get-VMNetworkA
:35 AM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] WMI Script that updates Hyper-V friendly port
names
On Sep 24, 2014, at 11:18 PM, Alin Serdean
wrote:
> The following script leverage's the advantages of WMI infrastructure
> offered in Hyper-V.
>
Hello Nithin,
I will update the documentation as soon as I can. Also I need to add the
visualddk flag explanation.
Thanks,
Alin.
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Saturday, September 27, 2014 5:16 AM
Către: Alin Serdean
Cc: dev@openvswitch.org
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Eitan Eliahu
Trimis: Saturday, September 27, 2014 11:39 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v4] datapath-windows Event read handler
The Read event handler is ex
Tested under Release/Debug.
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Monday, September 29, 2014 8:17 PM
Către: Ankur Sharma
Cc:
Subiect: Re: [ovs-dev] [PATCH v1] datapath-windows: Build fix.
On Sep 29
Hi Nithin,
We used a modified version of netdev-windows.
Alin.
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Tuesday, September 30, 2014 6:09 PM
Către: Samuel Ghinet
Cc: dev@openvswitch.org; Alin Serdean; Eitan Eliahu; Ankur Sharma
Subiect: Re: [PATCH 14/14
Hi Eitan,
In the last IRC discussion it was settled that Nithin and Ankur will check in
the netdev code. I can add patches over or suggestion.
Thanks,
Alin.
-Mesaj original-
De la: Eitan Eliahu [mailto:elia...@vmware.com]
Trimis: Tuesday, September 30, 2014 7:12 PM
Către: Alin Serdean
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis
Trimis: Thursday, October 2, 2014 11:53 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v2] datapath-windows: Incorrect assumption of the IRQL
Acquiring a spi
Waiting for the respin.
Just a couple of more remarks.
ovs-dev-v1-3-5-datapath-windows-Flow-Dump-handler.patch:50: trailing whitespace.
{ .cmd = OVS_FLOW_CMD_GET,
ovs-dev-v1-3-5-datapath-windows-Flow-Dump-handler.patch:52: trailing whitespace.
.supportedDevOp = OVS_TRANSA
Acked-by: Alin Gabriel Serdean
Tested-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Sunday, October 5, 2014 1:10 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 2/7 v2] lib/netlink-socket.c: add support f
Acked-by: Alin Gabriel Serdean
Tested-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Sunday, October 5, 2014 1:10 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 1/7 v2] OvsDpInterfaceExt.h: add support for
Acked-by: Alin Gabriel Serdean
Tested-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Sunday, October 5, 2014 1:10 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 3/7 v2] add lib/netdev-windows.c
In this pa
Acked-by: Alin Gabriel Serdean
Tested-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Sunday, October 5, 2014 1:10 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 7/7 v2] datapath-windows: implementation of
401 - 500 of 799 matches
Mail list logo
