Re: [ovs-dev] releasing 2.6: branch Aug 1, release Sep 15

2016-07-26 Thread Gray, Mark D
> -Original Message- > From: Daniele Di Proietto [mailto:diproiet...@vmware.com] > Sent: Monday, July 25, 2016 6:07 PM > To: Ben Pfaff ; Gray, Mark D ; > Pravin Shelar > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] releasing 2.6: branch Aug 1, release Sep 15 > > > > > > > On 25

Re: [ovs-dev] [PATCH] Windows: daemon-windows lockfile

2016-07-26 Thread Paul Boca
Thanks for this! Acked-by: Paul Boca > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean > Sent: Tuesday, July 26, 2016 12:58 AM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH] Windows: daemon-windows lockfile > > _get_osfhandle returns

Re: [ovs-dev] [PATCH] ovn: don't create the "" patch port.

2016-07-26 Thread nickcooper-zhangtonghao
ovn-northd: create patch ports when necessary. If the logical router ports without 'peer' or the port named peer is not created, it is unnecessary to insert the ports into the southbound Port_Binding table. Similarly, if logical switch ports of type 'router' don't contain 'router-port' value, the

[ovs-dev] [PATCH] INSTALL.DPDK: Remove the experimental tag for OVS DPDK

2016-07-26 Thread Bhanuprakash Bodireddy
The DPDK support of OVS was considered experimental as it had few shortcomings that prevented it from being easily deployed and used. Also there were few gaps to be filled to tag it "production-ready". Community has made significant contributions to improve OVS DPDK. This commit removes experiment

Re: [ovs-dev] [PATCH] INSTALL.DPDK: Remove the experimental tag for OVS DPDK

2016-07-26 Thread Bodireddy, Bhanuprakash
Hi (Apologies if top posting is inappropriate), Would like to receive your feedback on removing the "experimental" tag to OVS DPDK. The Community made significant contributions to OVS DPDK since this post last August (http://openvswitch.org/pipermail/dev/2015-August/058814.html). Regards,

[ovs-dev] Attached Image

2016-07-26 Thread dev
** The information in this email is confidential and may be privileged. If you are not the intended recipient, please destroy this message and notify the sender immediately. ***

[ovs-dev] Attached Image

2016-07-26 Thread dev
** The information in this email is confidential and may be privileged. If you are not the intended recipient, please destroy this message and notify the sender immediately. ***

[ovs-dev] [PATCH] ovn-controller: update_ct_zone operates always on empty set

2016-07-26 Thread bschanmu
From: Babu Shanmugam Commit 263064a (Convert binding_run to incremental processing.) removed the usage of all_lports from binding_run, but it is infact used in the context of the caller, especially by update_ct_zones(). Without this change, update_ct_zones operates on an empty set always. Sig

[ovs-dev] [PATCH v4] netdev-dpdk: Set pmd thread priority

2016-07-26 Thread Bhanuprakash Bodireddy
Set the DPDK pmd thread scheduling policy to SCHED_RR and static priority to highest priority value of the policy. This is to deal with pmd thread starvation case where another cpu hogging process can get scheduled/affinitized on to the same core the pmd thread is running there by significantly imp

Re: [ovs-dev] [PATCH v3] netdev-dpdk: Set pmd thread priority

2016-07-26 Thread Bodireddy, Bhanuprakash
Thanks Mark and Daniele, My comments inline. > >I agree with Mark's comments, other than that this looks good to me. >If you agree with the comments would you mind sending an updates version? I have sent out V4 with the changes suggested by Mark. >> >>    * In the absence of pmd-cpu-mask, one pm

[ovs-dev] 0CB6130AE0B1B574

2016-07-26 Thread dev
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH V8 00/17] Fix and enable Python tests on Windows

2016-07-26 Thread Paul Boca
This series of patches ports the python damons to Windows and fixes the tests to work on Windows. There are still some python tests that fail on Windows, from which some are failing on Linux too. The patches in this series are dependent and are related to python tests on Windows. V2: Fixes more po

[ovs-dev] [PATCH V8 01/17] python tests: Implemented signal.alarm for Windows

2016-07-26 Thread Paul Boca
signal.alarm is not available in Windows and would trigger an exception when called. Implemented this to mentain compatibility between Windows and Linux for python tests. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: Code styling changes V4: No changes V5:

[ovs-dev] [PATCH V8 02/17] python tests: Register signal handlers only on supported types on Windows

2016-07-26 Thread Paul Boca
SIGHUP and SIGALRM are not available on Windows. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: Fixed Python function inet_open_active, treat WSAEWOULDBLOCK error as EINPROGRESS on Windows V3: No changes V4: No changes V5: No changes V6: No changes V7: Simplified the

[ovs-dev] [PATCH V8 05/17] python tests: Added fcntl module for Windows

2016-07-26 Thread Paul Boca
This is needed for lockf function used to lock the PID file on Windows. ioctl and fcntl functions are not implemented at this time because they are not used by any script. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No chang

[ovs-dev] [PATCH V8 03/17] python tests: Fixed ctl file name for Windows

2016-07-26 Thread Paul Boca
On Windows the CTL filename doesn't contain the pid of the process. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: Fixed flake8 errors. Addressed changes required by review. V8: Fixed small alignem

[ovs-dev] [PATCH V8 04/17] python tests: Fixed unixctl python tests for Windows

2016-07-26 Thread Paul Boca
For bogus pid file path, use a windows-like file path. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: No changes --- tests/unixctl-py.at | 12 +--- 1 file changed, 9 inserti

[ovs-dev] [PATCH V8 07/17] python tests: Skip TCP6 idl tests on Windows

2016-07-26 Thread Paul Boca
The IPPROTO_IPV6 is not defined on Python for Windows because of compatibility with older Windows versions. Here is this issue discussed:https://bugs.python.org/issue6926 Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No change

[ovs-dev] [PATCH V8 08/17] python tests: Skip python tests on Windows where POSIX pid is used

2016-07-26 Thread Paul Boca
There is a difference between POSIX pid and Windows pid, not all the time are equal. On Windows when a python script is started, a sh command is triggered as the parent for script. So when we try to get the daemon pid with 'echo $!', this will get the pid of sh not of python.exe as expected. Als

[ovs-dev] [PATCH V8 10/17] python tests: Fixed abs_file_name function for Windows

2016-07-26 Thread Paul Boca
On windows a path containint ':' is considered an absolute path. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: No changes --- python/ovs/util.py | 6 -- 1 file changed, 4 inser

[ovs-dev] [PATCH V8 06/17] python tests: Skip IPsec test on Windows

2016-07-26 Thread Paul Boca
IPsec is not used on Windows yet, and the services used by this test are non-existent on Windows. Also the paths in the test do not exist on Windows. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: Updated commit

[ovs-dev] [PATCH V8 09/17] python tests: Fixed OSError not iterable on Windows

2016-07-26 Thread Paul Boca
On Windows if this exception is triggered then it will raise an exception while in the exception handler. Signed-off-by: Paul-Daniel Boca --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: Added comment when using OSError on Windows --- python/ovs/

[ovs-dev] [PATCH V8 12/17] python tests: Ported Python daemon to Windows

2016-07-26 Thread Paul Boca
Used subprocess.Popen instead os.fork (not implemented on windows) and repaced of os.pipe with Windows pipes. To be able to identify the child process I added an extra parameter to daemon process '--pipe-handle', this parameter also contains the parent Windows pipe handle, used by the child to sig

[ovs-dev] [PATCH V8 14/17] at tests: Allow Python tests to be run on Windows

2016-07-26 Thread Paul Boca
This patch removes the code which disables Python tests to be run on Windows. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: No changes --- test

[ovs-dev] [PATCH V8 11/17] python tests: Ported UNIX sockets to Windows

2016-07-26 Thread Paul Boca
AF_UNIX sockets are not supported on Windows. Instead of an AF_UNIX socket use localhost tcp connections to communicate between components. This makes the python sockets compatible with the ones used in Windows applications. In case the socket returns WSAEWOULDBLOCK, it is replaced by EAGAIN error

[ovs-dev] [PATCH V8 12/17] python tests: Prepare porting Python daemon on Windows

2016-07-26 Thread Paul Boca
Renamed daemon.py to daemon_unix.py and implemented a wrapper over it. Signed-off-by: Paul-Daniel Boca --- V8: Initial commit. --- python/automake.mk| 1 + python/ovs/daemon.py | 489 ++ python/ovs/daemon_unix.py | 530 ++

[ovs-dev] [PATCH V8 15/17] python tests: Ignore stderr output

2016-07-26 Thread Paul Boca
test-unixctl.py and test-vlog.py outputs on stderr and on Windows stderr is not overriden by every AT_CHECK call, the logs are only apended to the file and subsequent AT_CHECKs get errors from previous call. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V

[ovs-dev] [PATCH V8 16/17] python tests: Skip ovn-controller-vtep tests on Windows

2016-07-26 Thread Paul Boca
The tests are not intended to run on Windows. Until now they were skipped based on $HAVE_PYTHON only. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V4: No changes V5: No changes V6: No changes V7: Removed Python check on running this test V8: No changes --

[ovs-dev] [PATCH V8 17/17] tests: Skip vlog tests that try to move opened file

2016-07-26 Thread Paul Boca
On Windows if a file is opened by an application for writing, we cannot move it until all handles to that file are closed. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V4: No changes V5: No changes V6: Removed code that disables 'vlog/close' tests. V7: Sm

Re: [ovs-dev] [PATCH V8 00/17] Fix and enable Python tests on Windows

2016-07-26 Thread Paul Boca
I will resend this series once again. I made a small mistake: " [PATCH V8 12/17] python tests: Ported Python daemon to Windows" should be 13/17. Thanks! > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Paul Boca > Sent: Tuesday, July 26, 2016 2:50 PM > T

[ovs-dev] [PATCH V9 00/17] Fix and enable Python tests on Windows

2016-07-26 Thread Paul Boca
This series of patches ports the python damons to Windows and fixes the tests to work on Windows. There are still some python tests that fail on Windows, from which some are failing on Linux too. The patches in this series are dependent and are related to python tests on Windows. V2: Fixes more po

[ovs-dev] [PATCH V9 01/17] python tests: Implemented signal.alarm for Windows

2016-07-26 Thread Paul Boca
signal.alarm is not available in Windows and would trigger an exception when called. Implemented this to mentain compatibility between Windows and Linux for python tests. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: Code styling changes V4: No changes V5:

[ovs-dev] [PATCH V9 02/17] python tests: Register signal handlers only on supported types on Windows

2016-07-26 Thread Paul Boca
SIGHUP and SIGALRM are not available on Windows. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: Fixed Python function inet_open_active, treat WSAEWOULDBLOCK error as EINPROGRESS on Windows V3: No changes V4: No changes V5: No changes V6: No changes V7: Simplified the

[ovs-dev] [PATCH V9 03/17] python tests: Fixed ctl file name for Windows

2016-07-26 Thread Paul Boca
On Windows the CTL filename doesn't contain the pid of the process. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: Fixed flake8 errors. Addressed changes required by review. V8: Fixed small alignem

[ovs-dev] [PATCH V9 05/17] python tests: Added fcntl module for Windows

2016-07-26 Thread Paul Boca
This is needed for lockf function used to lock the PID file on Windows. ioctl and fcntl functions are not implemented at this time because they are not used by any script. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No chang

[ovs-dev] [PATCH V9 06/17] python tests: Skip IPsec test on Windows

2016-07-26 Thread Paul Boca
IPsec is not used on Windows yet, and the services used by this test are non-existent on Windows. Also the paths in the test do not exist on Windows. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: Updated commit

[ovs-dev] [PATCH V9 04/17] python tests: Fixed unixctl python tests for Windows

2016-07-26 Thread Paul Boca
For bogus pid file path, use a windows-like file path. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: No changes V9: No changes --- tests/unixctl-py.at | 12 +--- 1 file cha

[ovs-dev] [PATCH V9 07/17] python tests: Skip TCP6 idl tests on Windows

2016-07-26 Thread Paul Boca
The IPPROTO_IPV6 is not defined on Python for Windows because of compatibility with older Windows versions. Here is this issue discussed:https://bugs.python.org/issue6926 Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No change

[ovs-dev] [PATCH V9 08/17] python tests: Skip python tests on Windows where POSIX pid is used

2016-07-26 Thread Paul Boca
There is a difference between POSIX pid and Windows pid, not all the time are equal. On Windows when a python script is started, a sh command is triggered as the parent for script. So when we try to get the daemon pid with 'echo $!', this will get the pid of sh not of python.exe as expected. Als

[ovs-dev] [PATCH V9 09/17] python tests: Fixed OSError not iterable on Windows

2016-07-26 Thread Paul Boca
On Windows if this exception is triggered then it will raise an exception while in the exception handler. Signed-off-by: Paul-Daniel Boca --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: Added comment when using OSError on Windows V9: No changes -

[ovs-dev] [PATCH V9 10/17] python tests: Fixed abs_file_name function for Windows

2016-07-26 Thread Paul Boca
On windows a path containint ':' is considered an absolute path. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: No changes V9: No changes --- python/ovs/util.py | 6 -- 1 file c

[ovs-dev] [PATCH V9 11/17] python tests: Ported UNIX sockets to Windows

2016-07-26 Thread Paul Boca
AF_UNIX sockets are not supported on Windows. Instead of an AF_UNIX socket use localhost tcp connections to communicate between components. This makes the python sockets compatible with the ones used in Windows applications. In case the socket returns WSAEWOULDBLOCK, it is replaced by EAGAIN error

[ovs-dev] [PATCH V9 12/17] python tests: Prepare porting Python daemon on Windows

2016-07-26 Thread Paul Boca
Renamed daemon.py to daemon_unix.py and implemented a wrapper over it. Signed-off-by: Paul-Daniel Boca --- V8: Initial commit. V9: No changes --- python/automake.mk| 1 + python/ovs/daemon.py | 489 ++ python/ovs/daemon_unix.py | 530 +++

[ovs-dev] [PATCH V9 15/17] python tests: Ignore stderr output

2016-07-26 Thread Paul Boca
test-unixctl.py and test-vlog.py outputs on stderr and on Windows stderr is not overriden by every AT_CHECK call, the logs are only apended to the file and subsequent AT_CHECKs get errors from previous call. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V

[ovs-dev] [PATCH V9 14/17] at tests: Allow Python tests to be run on Windows

2016-07-26 Thread Paul Boca
This patch removes the code which disables Python tests to be run on Windows. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: No changes V9: No ch

[ovs-dev] [PATCH V9 13/17] python tests: Ported Python daemon to Windows

2016-07-26 Thread Paul Boca
Used subprocess.Popen instead os.fork (not implemented on windows) and repaced of os.pipe with Windows pipes. To be able to identify the child process I added an extra parameter to daemon process '--pipe-handle', this parameter also contains the parent Windows pipe handle, used by the child to sig

[ovs-dev] [PATCH V9 17/17] tests: Skip vlog tests that try to move opened file

2016-07-26 Thread Paul Boca
On Windows if a file is opened by an application for writing, we cannot move it until all handles to that file are closed. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V4: No changes V5: No changes V6: Removed code that disables 'vlog/close' tests. V7: Sm

[ovs-dev] [PATCH V9 16/17] python tests: Skip ovn-controller-vtep tests on Windows

2016-07-26 Thread Paul Boca
The tests are not intended to run on Windows. Until now they were skipped based on $HAVE_PYTHON only. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V4: No changes V5: No changes V6: No changes V7: Removed Python check on running this test V8: No changes V9

Re: [ovs-dev] [PATCH v4] netdev-dpdk: Set pmd thread priority

2016-07-26 Thread Kavanagh, Mark B
> >Set the DPDK pmd thread scheduling policy to SCHED_RR and static >priority to highest priority value of the policy. This is to deal with >pmd thread starvation case where another cpu hogging process can get >scheduled/affinitized on to the same core the pmd thread is running >there by significa

[ovs-dev] [PATCH] ovn: Support for GARP for NAT IPs via localnet

2016-07-26 Thread Chandra S Vejendla
In cases where a DNAT IP is moved to a new router or the SNAT IP is reused with a new mac address, the NAT IPs become unreachable because the external switches/routers have stale ARP entries. This commit aims to fix the problem by sending GARPs for NAT IPs via locanet A new options key "nat-addres

Re: [ovs-dev] [PATCH V9 09/17] python tests: Fixed OSError not iterable on Windows

2016-07-26 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca > Trimis: Tuesday, July 26, 2016 3:01 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH V9 09/17] python tests: Fixed OSError not iterable > on Windows > > O

Re: [ovs-dev] [PATCH V9 12/17] python tests: Prepare porting Python daemon on Windows

2016-07-26 Thread Alin Serdean
LGTM. Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca > Trimis: Tuesday, July 26, 2016 3:03 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH V9 12/17] python tests: Prepare porting Python > daemon on Window

Re: [ovs-dev] [PATCH V9 13/17] python tests: Ported Python daemon to Windows

2016-07-26 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca > Trimis: Tuesday, July 26, 2016 3:03 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH V9 13/17] python tests: Ported Python daemon to > Windows > > Used su

Re: [ovs-dev] Compiler warnings with gcc 6.1 (On Fedora 24)

2016-07-26 Thread Russell Bryant
On Tue, Jul 5, 2016 at 1:10 AM, Numan Siddique wrote: > > > > > > > > OK. > > > > If you have time and the inclination, please feel free to experiment a > > bit with the definition of BUILD_ASSERT_TYPE to see if you can make it > > work without warnings. > > > > ​Thanks for the pointers. I will g

Re: [ovs-dev] Compiler warnings with gcc 6.1 (On Fedora 24)

2016-07-26 Thread Numan Siddique
On Tue, Jul 26, 2016 at 6:02 PM, Russell Bryant wrote: > > > On Tue, Jul 5, 2016 at 1:10 AM, Numan Siddique > wrote: > >> > >> > >> > >> > OK. >> > >> > If you have time and the inclination, please feel free to experiment a >> > bit with the definition of BUILD_ASSERT_TYPE to see if you can make

[ovs-dev] 8CAD0FC547614CE6

2016-07-26 Thread dev
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] list of activities

2016-07-26 Thread Amelia Barrera
Hello, Attached is the list of activities to help you arrange for the coming presentation. Please read it carefully and write to me if you have any concern. Best regards, Amelia Barrera ACAL Security-ID: cbdb7a10fab1f177f55ba41653128ee2d0d3a90aa14b __

Re: [ovs-dev] [PATCH v2 3/7] datapath-windows: Define new multicast conntrack events and netlink protocol

2016-07-26 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam > Venugopal > Trimis: Tuesday, July 26, 2016 3:05 AM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH v2 3/7] datapath-windows: Define new multicast > conntrack ev

[ovs-dev] list of activities

2016-07-26 Thread Francesco Erickson
Hello, Attached is the list of activities to help you arrange for the coming presentation. Please read it carefully and write to me if you have any concern. Cheers, Francesco Erickson 24/7 GAMING GROUP HLDGS PLC Security-ID: a2b6f7f18f8ade887ae40157c84b5b5335bce6abf642 _

Re: [ovs-dev] [PATCH v2 6/7] datapath-windows: Update OvsReadEventCmdHandler in Datapath.c to support different events

2016-07-26 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam > Venugopal > Trimis: Tuesday, July 26, 2016 3:05 AM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH v2 6/7] datapath-windows: Update > OvsReadEventCmdHandler in

Re: [ovs-dev] [PATCH v2 5/7] datapath-windows: Add support for multiple event queue in Event.c

2016-07-26 Thread Alin Serdean
I wanted to ask you about OvsWaitEventIoctl lock but you fixed in 5/7 Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam > Venugopal > Trimis: Tuesday, July 26, 2016 3:05 AM > Către: dev@openvswitch.org > Subiect: [ovs-dev

Re: [ovs-dev] [PATCH v2 5/7] datapath-windows: Add support for multiple event queue in Event.c

2016-07-26 Thread Alin Serdean
> -Mesaj original- > De la: Alin Serdean > Trimis: Tuesday, July 26, 2016 4:08 PM > Către: 'Sairam Venugopal' ; dev@openvswitch.org > Subiect: RE: [ovs-dev] [PATCH v2 5/7] datapath-windows: Add support for > multiple event queue in Event.c > > I wanted to ask you about OvsWaitEventIoctl lo

Re: [ovs-dev] [PATCH v2 2/7] datapath-windows: Fix bugs in Event.c around subscribe and lock

2016-07-26 Thread Alin Serdean
I wanted to ask you about OvsWaitEventIoctl lock but you fixed in 5/7 Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam > Venugopal > Trimis: Tuesday, July 26, 2016 3:05 AM > Către: dev@openvswitch.org > Subiect: [ovs-dev

[ovs-dev] [PATCH] netdev-provider: fix comments for netdev_rxq_recv

2016-07-26 Thread Mark Kavanagh
Commit 64839cf43 applies batch objects to netdev-providers, but some comments were not updated accordingly. Fix these: - replace 'pkts' with 'batch' - replace '*cnt' with 'batch->count' - replace MAX_RX_BATCH with NETDEV_MAX_BURST - remove superfluous whitespace Signed-off-by: Mark Kav

Re: [ovs-dev] [PATCH v3 1/3] bridge: Pass interface's configuration to datapath.

2016-07-26 Thread Ilya Maximets
On 26.07.2016 04:45, Daniele Di Proietto wrote: > Thanks for the patch > > It looks good to me, a few minor comments inline > > > On 15/07/2016 04:54, "Ilya Maximets" wrote: > >> This commit adds functionality to pass value of 'other_config' column >> of 'Interface' table to datapath. >> >> Th

[ovs-dev] 13150E3848149399

2016-07-26 Thread dev
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3 3/3] dpif-netdev: Introduce pmd-rxq-affinity.

2016-07-26 Thread Ilya Maximets
On 26.07.2016 04:46, Daniele Di Proietto wrote: > Thanks for the patch. > > I haven't been able to apply this without the XPS patch. That was the original idea. Using of this patch with current tx queue management may lead to performance issues on multiqueue configurations. > This looks like a p

[ovs-dev] list of activities

2016-07-26 Thread Ruth Christensen
Hello, Attached is the list of activities to help you arrange for the coming presentation. Please read it carefully and write to me if you have any concern. Kindest regards, Ruth Christensen DAIRY FARM INTERNATIONAL HLDGS Security-ID: b198dc5a4cabb3a1a735c62065cc10cc426d8bd47379 ___

[ovs-dev] list of activities

2016-07-26 Thread Justine Jimenez
Hello, Attached is the list of activities to help you arrange for the coming presentation. Please read it carefully and write to me if you have any concern. Kindest regards, Justine Jimenez Tamar.com Security-ID: 00628183c98c487a94464ba9c20d85050fdef0bdb038 _

Re: [ovs-dev] [PATCH] Windows: daemon-windows lockfile

2016-07-26 Thread Guru Shetty
On 25 July 2016 at 14:58, Alin Serdean wrote: > _get_osfhandle returns an errno value not a GetLastErrorValue. > (https://msdn.microsoft.com/en-us/library/ks2530z6(v=vs.120).aspx) > > Signed-off-by: Alin Gabriel Serdean > Thank you. Applied to master. > --- > lib/daemon-windows.c | 2 +- > 1

Re: [ovs-dev] [RFC 4/5] dpctl: uses open_type when calling netdev_open

2016-07-26 Thread Thadeu Lima de Souza Cascardo
On Mon, Jul 25, 2016 at 11:03:29AM -0700, Daniele Di Proietto wrote: > 2016-07-25 9:57 GMT-07:00 Thadeu Lima de Souza Cascardo >: > > > On Fri, Jul 22, 2016 at 02:49:39PM -0700, Daniele Di Proietto wrote: > > > I would prefer if dpctl kept using the datapath types. The translation > > > from dat

Re: [ovs-dev] [RFC 0/5] netdev_open conflicting types

2016-07-26 Thread Thadeu Lima de Souza Cascardo
On Mon, Jul 25, 2016 at 02:12:52PM -0300, Thadeu Lima de Souza Cascardo wrote: > On Fri, Jul 22, 2016 at 01:10:33PM -0700, Ben Pfaff wrote: > > On Mon, Jul 18, 2016 at 02:00:20PM -0300, Thadeu Lima de Souza Cascardo > > wrote: > > > This series is a proposal to fix some users of netdev_open and >

Re: [ovs-dev] [PATCH 1/3] datapath: compat: fix udp checksum calculation

2016-07-26 Thread Jesse Gross
On Mon, Jul 25, 2016 at 5:49 PM, Pravin B Shelar wrote: > In upstream linux kernel networking stack udp_set_csum() is called > with only udp header applied but in case of compat layer it can > be called with IP header. So following patch take the offset into > account. > > Signed-off-by: Pravin B

Re: [ovs-dev] [PATCH] netdev-provider: fix comments for netdev_rxq_recv

2016-07-26 Thread William Tu
Hi Mark, Thanks for fixing them! looks good to me. Signed-off-by: William Tu On Tue, Jul 26, 2016 at 6:19 AM, Mark Kavanagh wrote: > Commit 64839cf43 applies batch objects to netdev-providers, but > some comments were not updated accordingly. Fix these: >- replace 'pkts' with 'batch' >

[ovs-dev] [PATCH v2 3/4] windows: document multiple NIC support setup

2016-07-26 Thread Alin Serdean
This patch updates the documentation in how to set up OVS with multiple NICs. Signed-off-by: Alin Gabriel Serdean --- v2: Rebase --- INSTALL.Windows.md | 70 +++--- 1 file changed, 67 insertions(+), 3 deletions(-) diff --git a/INSTALL.Windows.md b

[ovs-dev] [PATCH v2 1/4] windows: Add internal switch port per OVS bridge

2016-07-26 Thread Alin Serdean
This patch updates the following commands in the vswitch: ovs-vsctl add-br br-test ovs-vsctl del-br br-test ovs-vsctl add-br br-test: This command will now create an internal port on the MSFT virtual switch using the WMI interface from Msvm_VirtualEthernetSwitchManagementService leveraging

[ovs-dev] [PATCH v2 4/4] datapath-windows: Fix VPORT when it is allocated by OVS

2016-07-26 Thread Alin Serdean
When an OID for an exeternal NIC create is done first try to find it by its friendly name. Also when an OID NIC delete is requested only remove it from the hyper-v hash array not from both. Some parts of the code have been cleaned since they are not used anymore. Signed-off-by: Alin Gabriel Serde

[ovs-dev] [PATCH v2 2/4] datapath-windows: Add multiple switch internal ports

2016-07-26 Thread Alin Serdean
This patch adds multiple internal ports support to the windows datapath. All tunnels types have been updated to accommodate this new functionality. Signed-off-by: Alin Gabriel Serdean Co-authored-by: Sorin Vinturis --- v2: Rebase --- datapath-windows/ovsext/Actions.c | 41 +- datapath-windows

[ovs-dev] [PATCH v2 2/4] netdev-dpdk: Consistent naming for vhost functions

2016-07-26 Thread Ciara Loftus
A mix of vhost_user_ and vhost_ is used when naming vhost functions. The 'user_' has been dropped for consistency. Also remove empty 'vhost_user_class_init' function. Signed-off-by: Ciara Loftus Acked-by: Daniele Di Proietto --- lib/netdev-dpdk.c | 25 - 1 file changed,

[ovs-dev] [PATCH v2 4/4] netdev-dpdk: Add vhost-user 'get_features' & 'get_status' functions

2016-07-26 Thread Ciara Loftus
Implementations for the netdev functions 'get_features' and 'get_status' are now available for vhost-user thanks to the addition of the vHost PMD. Signed-off-by: Ciara Loftus --- lib/netdev-dpdk.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/lib/n

[ovs-dev] [PATCH v2 1/4] netdev-dpdk: Remove dpdkvhostcuse ports

2016-07-26 Thread Ciara Loftus
This commit removes the 'dpdkvhostcuse' port type from the userspace datapath. vhost-cuse ports are quickly becoming obsolete as the vhost-user port type begins to support a greater feature-set thanks to the addition of things like vhost-user multiqueue and potential upcoming features like vhost-us

[ovs-dev] [PATCH v2 0/4] Remove vHost Cuse and Add vHost User PMD

2016-07-26 Thread Ciara Loftus
Previous: http://openvswitch.org/pipermail/dev/2016-July/075371.html The patchset combines two previously independent sets: 1. netdev-dpdk: Remove dpdkvhostcuse ports (v1) http://openvswitch.org/pipermail/dev/2016-July/074696.html 2. vHost PMD (v3) http://openvswitch.org/pipermail/dev/2016-May/070

[ovs-dev] [PATCH v2 3/4] netdev-dpdk: Add vHost User PMD

2016-07-26 Thread Ciara Loftus
DPDK 16.04 introduces the vHost PMD which allows 'dpdkvhostuser' ports to be controlled by the librte_ether API, like physical 'dpdk' ports and IVSHM 'dpdkr' ports. This commit integrates this PMD into OVS and removes direct calls to the librte_vhost DPDK library. This commit removes extended stat

Re: [ovs-dev] [PATCH 3/4] netdev-dpdk: Add vHost User PMD

2016-07-26 Thread Loftus, Ciara
> Subject: Re: [ovs-dev] [PATCH 3/4] netdev-dpdk: Add vHost User PMD > > Thanks for the patch > This needs a little bit of rebasing, I did it myself to review, but it'd be > nice to > have an updated version. I've submitted a new set here: http://openvswitch.org/pipermail/dev/2016-July/076245.h

Re: [ovs-dev] [PATCH] JSON serialization via Python's json lib

2016-07-26 Thread Ben Pfaff
On Mon, Jul 25, 2016 at 07:17:11PM -0500, Terry Wilson wrote: > There is no particularly good reason to use our own Python JSON > serialization implementation when serialization can be done faster > with Python's built-in JSON library. > > A few tests were changed due to Python's default JSON libr

Re: [ovs-dev] [PATCH 3/3] datapath: compat: simplify ip_local_out().

2016-07-26 Thread Jesse Gross
On Mon, Jul 25, 2016 at 5:49 PM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c > index 8368c6a..de9c8e1 100644 > --- a/datapath/linux/compat/gso.c > +++ b/datapath/linux/compat/gso.c > @@ -286,17 +282,15 @@ int rpl_ip_local_out(struct net *net, str

Re: [ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-07-26 Thread Loftus, Ciara
> 2016-07-19 2:53 GMT-07:00 Loftus, Ciara : > > > > The idea looks very good to me, thanks for working on it. > > Very high level comments: > Hi Daniele thanks for looking at this. > > > > > Do we need to be limited to pci devices?  Perhaps we can accept the same > > string as rte_eth_dev_attach()

Re: [ovs-dev] [PATCH 2/3] datapath: compat: unset skb encapsulation bit

2016-07-26 Thread Jesse Gross
On Mon, Jul 25, 2016 at 5:49 PM, Pravin B Shelar wrote: > OVS compat layer can handle tunnel GSO packets. but it does > keep skb encapsulation on for packet handled in GSO. This can > confuse some NIC drivers. I have seen this issue on intel devices: > > i40e :42:00.0: TX driver issue detect

Re: [ovs-dev] [PATCH] flow: Verify that tot_len >= ip_len in miniflow_extract().

2016-07-26 Thread Ben Pfaff
On Sat, Jul 23, 2016 at 02:29:35AM -0300, Flavio Leitner wrote: > On Fri, Jul 22, 2016 at 04:43:50PM -0700, Ben Pfaff wrote: > > miniflow_extract() uses the following quantities when it examines an IPv4 > > header: > > > > size, the number of bytes from the start of the IPv4 header onward > >

[ovs-dev] [PATCH] rhel: Add support for DPDK Bond

2016-07-26 Thread Flavio Leitner
The current ifcfg file lacks support for OVS DPDK Bond. Signed-off-by: Flavio Leitner --- rhel/README.RHEL| 20 +--- rhel/etc_sysconfig_network-scripts_ifup-ovs | 9 + 2 files changed, 26 insertions(+), 3 deletions(-) diff --git a/rhel/README

Re: [ovs-dev] [PATCH v2] ovn-northd: Combine two NAT loops into one.

2016-07-26 Thread Ben Pfaff
On Wed, Jul 13, 2016 at 04:20:36AM -0700, Gurucharan Shetty wrote: > Signed-off-by: Gurucharan Shetty > --- > ovn/northd/ovn-northd.c | 47 ++- > 1 file changed, 14 insertions(+), 33 deletions(-) > > diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ov

Re: [ovs-dev] [PATCH 1/3] datapath: compat: fix udp checksum calculation

2016-07-26 Thread pravin shelar
On Tue, Jul 26, 2016 at 8:30 AM, Jesse Gross wrote: > On Mon, Jul 25, 2016 at 5:49 PM, Pravin B Shelar wrote: >> In upstream linux kernel networking stack udp_set_csum() is called >> with only udp header applied but in case of compat layer it can >> be called with IP header. So following patch ta

Re: [ovs-dev] [PATCH 3/3] datapath: compat: simplify ip_local_out().

2016-07-26 Thread pravin shelar
On Tue, Jul 26, 2016 at 9:23 AM, Jesse Gross wrote: > On Mon, Jul 25, 2016 at 5:49 PM, Pravin B Shelar wrote: >> diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c >> index 8368c6a..de9c8e1 100644 >> --- a/datapath/linux/compat/gso.c >> +++ b/datapath/linux/compat/gso.c >> @@

Re: [ovs-dev] [PATCH] rhel: Add support for DPDK Bond

2016-07-26 Thread Aaron Conole
Flavio Leitner writes: > The current ifcfg file lacks support for OVS DPDK Bond. > > Signed-off-by: Flavio Leitner > --- > rhel/README.RHEL| 20 +--- > rhel/etc_sysconfig_network-scripts_ifup-ovs | 9 + > 2 files changed, 26 insertions(+), 3

Re: [ovs-dev] [PATCH] ovsdb: Weak references performance fix

2016-07-26 Thread Ben Pfaff
That's a great explanation. I understand better now. Thank you. On Fri, Jul 08, 2016 at 08:34:46PM +, Rodriguez Betancourt, Esteban wrote: > Thanks for the comments, I'm going to send soon a new patch with the > suggestions > applied. > > About how the patch works: > The first attempt to s

Re: [ovs-dev] [PATCH v3] ovsdb: Weak references performance fix

2016-07-26 Thread Ben Pfaff
On Wed, Jul 13, 2016 at 05:28:51PM +, Rodriguez Betancourt, Esteban wrote: > Prevents the cloning of rows with outgoing or > incoming weak references when those rows aren't > being modified. > > It improves the OVSDB Server performance when > many rows with weak references are involved > in a

Re: [ovs-dev] [PATCH] rhel: Add support for DPDK Bond

2016-07-26 Thread Flavio Leitner
On Tue, Jul 26, 2016 at 01:35:58PM -0400, Aaron Conole wrote: > Flavio Leitner writes: > > > The current ifcfg file lacks support for OVS DPDK Bond. > > > > Signed-off-by: Flavio Leitner > > --- > > rhel/README.RHEL| 20 +--- > > rhel/etc_sysconfig_ne

[ovs-dev] [PATCH v2] rhel: Add support for DPDK Bond

2016-07-26 Thread Flavio Leitner
The current ifcfg file lacks support for OVS DPDK Bond. Reviewed-by: Aaron Conole Signed-off-by: Flavio Leitner --- rhel/README.RHEL| 19 --- rhel/etc_sysconfig_network-scripts_ifup-ovs | 9 + 2 files changed, 25 insertions(+), 3 deletions(-)

Re: [ovs-dev] [PATCH v18 1/9] Change encaps_run to work incrementally

2016-07-26 Thread Jesse Gross
On Tue, Jun 7, 2016 at 11:52 AM, Ryan Moats wrote: > As a side effect, tunnel context is persisted. > > Signed-off-by: Ryan Moats When I was working on something else in this area, I noticed what appear to be some regressions as a result of this change. The one that I actually noticed from test

Re: [ovs-dev] [PATCH 2/3] datapath: compat: unset skb encapsulation bit

2016-07-26 Thread pravin shelar
On Tue, Jul 26, 2016 at 10:06 AM, Jesse Gross wrote: > On Mon, Jul 25, 2016 at 5:49 PM, Pravin B Shelar wrote: >> OVS compat layer can handle tunnel GSO packets. but it does >> keep skb encapsulation on for packet handled in GSO. This can >> confuse some NIC drivers. I have seen this issue on int

  1   2   3   >