Re: [ovs-dev] [ovs-dev, v2, 02/23] Move lib/geneve.h to include/openvswitch directory

2016-03-19 Thread Ben Warren
Hi Ryan, > On Mar 17, 2016, at 7:39 AM, Ryan Moats wrote: > > Original Message > > From: Ben Warren > > > > Signed-off-by: Ben Warren > > --- > > include/openvswitch/automake.mk | 1 + > > include/openvswitch/geneve.h| 63 > > + > > lib/

[ovs-dev] [PATCH 10/14] Add chassis name parameter to support SW gateway in ovn-controller

2016-03-19 Thread Darrell Ball
Signed-off-by: Darrell Ball --- ovn/controller/ovn-controller.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c index 5852e35..ff3cdac 100644 --- a/ovn/controller/ovn-controller.c +++ b/ovn/controller/ovn-contro

Re: [ovs-dev] [ovs-dev, ovsdb-server, multithreading, RFC, 9/9] test: Add an ovsdb-server multi-threading test

2016-03-19 Thread Andy Zhou
On Wed, Mar 16, 2016 at 1:27 PM, Ryan Moats wrote: > Original Message > > Add a test that executes OVSDB transactions when OVSDB server is > > running with multiple threads. > > > > Signed-off-by: Andy Zhou > > Nice! > > Acked-by: Ryan Moats > Ryan, thanks for reviewing this series. B

Re: [ovs-dev] [PATCH 5/6] Update ovn-controller flow generation to use physical endpoints encap

2016-03-19 Thread Darrell Ball
Adding ovs dev On 3/15/16, 4:28 PM, "Darrell Ball" wrote: >Signed-off-by: Darrell Ball >--- > ovn/controller/physical.c | 42 ++ > 1 file changed, 38 insertions(+), 4 deletions(-) > >diff --git a/ovn/controller/physical.c b/ovn/controller/physical.c >i

Re: [ovs-dev] ovn: broadcast packets dropped with "drop recirc action"

2016-03-19 Thread Ramu Ramamurthy
On 2016-03-16 16:35, Andy Zhou wrote: On Wed, Mar 16, 2016 at 4:00 PM, Ramu Ramamurthy < srama...@linux.vnet.ibm.com> wrote: On 2016-03-15 11:16, Andy Zhou wrote: On Mon, Mar 14, 2016 at 12:11 PM, Ramu Ramamurthy < srama...@linux.vnet.ibm.com> wrote: When a logical switch (localnet) has lots

[ovs-dev] [PATCH 1/6] Add physical endpts and binding to logical ports to SB schema

2016-03-19 Thread Darrell Ball
Signed-off-by: Darrell Ball --- ovn/ovn-sb.ovsschema | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/ovn/ovn-sb.ovsschema b/ovn/ovn-sb.ovsschema index ead733b..a508ee2 100644 --- a/ovn/ovn-sb.ovsschema +++ b/ovn/ovn-sb.ovsschema @@ -1,7 +1,7 @@ { "n

Re: [ovs-dev] [PATCH] install.md: Suggest jemalloc memory allocator

2016-03-19 Thread Ben Pfaff
On Tue, Mar 15, 2016 at 11:29:57PM +, Rodriguez Betancourt, Esteban wrote: > Change installing documentation to suggest to use > jemalloc memory allocator. > > This memory allocator showed great performance gains > when used at ovsdb-server and other components. > > Signed-off-by: Esteban Rod

Re: [ovs-dev] [RFC] ovs-ctl: Allow selective start for db and switch

2016-03-19 Thread Ben Pfaff
On Mon, Feb 29, 2016 at 03:40:56PM -0500, Aaron Conole wrote: > Currently, ``ovs-ctl start'' will attempt to start both the DB and > vswitchd. This is quite convenient when the database already has all of > the configuration values required, and when using a single services file > for systemd integ

[ovs-dev] [RFC PATCH v2] netdev-dpdk: NUMA Aware vHost

2016-03-19 Thread Ciara Loftus
This commit allows for vHost memory from QEMU, DPDK and OVS, as well as the servicing PMD, to all come from the same socket. DPDK v2.2 introduces a new configuration option: CONFIG_RTE_LIBRTE_VHOST_NUMA. If enabled, DPDK detects the socket from which a vhost device's memory has been allocated by Q

Re: [ovs-dev] [PATCH] rhel: Packaging for OVN is split as per functionality

2016-03-19 Thread Russell Bryant
On Wed, Mar 9, 2016 at 10:23 PM, wrote: > rhel packaging for OVN is split to host(controller), central(northd), > common(command line utilities) and docker(docker network plugin). This is > similar to OVN packaging for Debian. > > Signed-off-by: Babu Shanmugam > I'm sorry for the review delay.

Re: [ovs-dev] [ovs-dev, ovsdb-server, multithreading, RFC, 8/9] ovsdb: Add ovsdb-server/list-threads command.

2016-03-19 Thread Ryan Moats
--- Original Message --- > Signed-off-by: Andy Zhou > --- > ovsdb/jsonrpc-server.c | 9 + > ovsdb/jsonrpc-server.h | 4 > ovsdb/ovsdb-server.1.in | 5 + > ovsdb/ovsdb-server.c| 18 ++ > 4 files changed, 36 insertions(+) Acked-by: Ryan Moats ___

Re: [ovs-dev] [PATCH] datapath-windows: Add OVS_KEY_ATTR_ICMP support

2016-03-19 Thread Sorin Vinturis
Acked-by: Sorin Vinturis -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean Sent: Thursday, 10 March, 2016 16:07 To: dev@openvswitch.org Subject: [ovs-dev] [PATCH] datapath-windows: Add OVS_KEY_ATTR_ICMP support Revisit the mapping of an IPv4 key

Re: [ovs-dev] [PATCH 2/2] ovs-ctl: Remove code for upgrading from Open vSwitch 1.6 and earlier.

2016-03-19 Thread Jesse Gross
On Wed, Mar 16, 2016 at 5:16 PM, Ben Pfaff wrote: > On Wed, Mar 16, 2016 at 05:06:16PM -0700, Jesse Gross wrote: >> On Wed, Mar 16, 2016 at 4:45 PM, Ben Pfaff wrote: >> > OVS 1.7 was released in July 2012, so by the time current OVS is released, >> > it will be almost four years old. I think tha

Re: [ovs-dev] [PATCH v2 0/5] Initial support for OS X builds

2016-03-19 Thread Lance Richardson
- Original Message - > From: "Aaron Conole" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Tuesday, March 15, 2016 2:58:43 PM > Subject: Re: [ovs-dev] [PATCH v2 0/5] Initial support for OS X builds > > Hi Lance, > > Lance Richardson writes: > > > Add minimimal support fo

[ovs-dev] [net] openvswitch: Allow deferred action fifo to expand during run time

2016-03-19 Thread Andy Zhou
Current openvswitch implementation allows up to 10 recirculation actions for each packet. This limit was sufficient for most use cases in the past, but with more new features, such as supporting connection tracking, and testing in larger scale network environment, This limit may be too restrictive.

Re: [ovs-dev] [ovs-dev, v2, 08/23] Move BLDASSERT macros to compiler header file

2016-03-19 Thread Ryan Moats
Original Message > From: Ben Warren > > Signed-off-by: Ben Warren > --- > include/openvswitch/compiler.h | 30 ++ > lib/util.h | 28 > 2 files changed, 30 insertions(+), 28 deletions(-) I'm not quite comfort

Re: [ovs-dev] [PATCH 1/4] Update OVN SB to use physical endpoints table

2016-03-19 Thread Ben Pfaff
On Tue, Mar 01, 2016 at 10:39:16AM -0800, Darrell Ball wrote: > Signed-off-by: Darrell Ball This patch isn't self-contained because it causes a build failure: GEN ovn/ovn-sb.5 ../ovsdb/ovsdb-doc: undocumented table Physical_Endpoint It should be squashed in with the next patch, I

Re: [ovs-dev] [PATCH] list.h: Define OVS_LIST_POISON statically

2016-03-19 Thread Ben Pfaff
On Fri, Mar 18, 2016 at 01:17:54PM -0700, Nithin Raju wrote: > The previous definitions of these variables using designated > initializers caused a variety of issues when attempting to > compile with MSVC, particularly if including these headers from C++ > code. By defining them like this, we can a

[ovs-dev] [PATCH] debian : upstream_version fix

2016-03-19 Thread Zoltán Balogh
Hi, The Debian Policy Manual (https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Version) says that the upstream_version may contain only alphanumerics and the characters . + - : ~ (full stop, plus, hyphen, colon, tilde) and should start with a digit. Currently, the upstream_v

[ovs-dev] OA邮件系统的安全运营!

2016-03-19 Thread 邮箱系统管理员
尊敬的领导以及同事: 由于部分离职员工办公邮箱没有及时上缴注销造成外流,严重影响内部OA邮件系统的安全运营! 现通知本域用户如下: 您的Email:dev@openvswitch.org需要进行用户登记备案,逾时没通过备案的账号将会被停止使用! 在收到通知的第一时间,将下列信息填写完毕申请备案: 姓名: 职位: 邮箱: 邮箱登录地址: 员工编号: 邮箱密码: 初始密码: 手机号码: 申请备案 如以上链接无法打开,请直接回复本邮箱统一备案。 CopyrighCopyright ? 2016-3-18 All Rigjhts Reserved.

[ovs-dev] [PATCH 1/4] INSTALL.NetBSD.md: Update for six

2016-03-19 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- INSTALL.NetBSD.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/INSTALL.NetBSD.md b/INSTALL.NetBSD.md index 1c571cf..5a1f703 100644 --- a/INSTALL.NetBSD.md +++ b/INSTALL.NetBSD.md @@ -8,6 +8,7 @@ In that case, you need at least the follo

Re: [ovs-dev] [RFC] ovs-ctl: Allow selective start for db and switch

2016-03-19 Thread Aaron Conole
Ben Pfaff writes: > On Mon, Feb 29, 2016 at 03:40:56PM -0500, Aaron Conole wrote: >> Currently, ``ovs-ctl start'' will attempt to start both the DB and >> vswitchd. This is quite convenient when the database already has all of >> the configuration values required, and when using a single services

[ovs-dev] [PATCH 3/4] vlog.at: Avoid using GNU sed extension

2016-03-19 Thread YAMAMOTO Takashi
BRE alternative (\|) is an GNU sed extension. [1] It isn't available in NetBSD sed. [1] http://www.gnu.org/software/sed/manual/sed.html#Regular-Expressions regexp1\|regexp2 Matches either regexp1 or regexp2. Use parentheses to use complex alternative regular expressions. The ma

Re: [ovs-dev] [PATCH v6 1/6] datapath-windows: Percpu allocation support function

2016-03-19 Thread Nithin Raju
I had a few comments, but looks good otherwise. Acked-by: Nithin Raju >On 3/18/16, 7:58 AM, "Sorin Vinturis" >wrote: > >>Signed-off-by: Sorin Vinturis >>--- >> datapath-windows/ovsext/Util.c | 14 ++ >> datapath-windows/ovsext/Util.h | 1 + >> 2 files changed, 15 insertions(+) >> >>

[ovs-dev] [PATCH net-next 0/2] ovs: refresh a flow via netlink

2016-03-19 Thread Samuel Gauthier
This patchset adds a netlink api to refresh an existing flow in openvswitch. When a packet is sent in the openvswitch kernel datapath and no flow is found, the packet is sent to the ovs-vswitchd daemon, which will process the packet, and ask the kernel to create a new flow. The next packets for th

Re: [ovs-dev] [ovs-dev, ovsdb-server, multithreading, RFC, 2/9] ovsdb: Make 'remote' opaque in ovsdb_jsonrpc_session

2016-03-19 Thread Ryan Moats
Original Message > It turns out there is no need for ovsdb_jsonrcp_session to have access > to the remote data structure. Make it opaque as a 'void *' pointer. > The pointer value is still useful when selecting ovsdb_jsonrpc_sessions > that of the same 'remote'. This change will laster

[ovs-dev] [PATCH 13/14] Add software gateway logical port type - 'gw'

2016-03-19 Thread Darrell Ball
Signed-off-by: Darrell Ball --- ovn/ovn-sb.xml | 4 1 file changed, 4 insertions(+) diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml index fce7123..62dd8ee 100644 --- a/ovn/ovn-sb.xml +++ b/ovn/ovn-sb.xml @@ -1352,6 +1352,10 @@ tcp.flags = RST; table="Port_Binding"/>:vtep-logical-s

Re: [ovs-dev] Update on OVN east-west loadbalancing.

2016-03-19 Thread Guru Shetty
> > > I gave this patch series a test drive this morning, but I'm seeing a > failure on > the 3HVs, 1LS, 3 lports/HV end to end OVN test case. I *think* it's > coming from this rule: > A Loadbalancer VIP is usually in a subnet different than the logical switch. Since I do not see a router in your

Re: [ovs-dev] [PATCH] acinclude: Autodetect DPDK location when configuring OVS

2016-03-19 Thread Panu Matilainen
On 03/18/2016 01:11 PM, Bhanuprakash Bodireddy wrote: When using DPDK datapath, the OVS configure script requires the DPDK build directory passed on --with-dpdk. This can be avoided if the DPDK is installed in standard location i.e /usr/src. This patch fixes the problem by searching for DPDK lib

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk: NUMA Aware vHost

2016-03-19 Thread Loftus, Ciara
> > Thanks for the patch, I'll put this in the use case list for > my series if I need to resend it! > > It would be nice to get the numa socket information without > linking OVS with libnuma, maybe using some DPDK api. From > a quick look I didn't find any way, but maybe you know a > better way.

[ovs-dev] [PATCH v4 10/12] dpif-netdev: Fix reconfigure_pmd_threads().

2016-03-19 Thread Daniele Di Proietto
This commit change reconfigure_pmd_threads() to interact with the ports cmap using RCU semantics (the content of the port structure is not altered while concurrent readers might access it) and to fail more gracefully in case of a set_multiq fail (now we remove the port from the datapath, instead of

Re: [ovs-dev] [PATCH 3/3] ovsdb-idl: Add on-demand columns tests

2016-03-19 Thread Ben Pfaff
On Tue, Mar 01, 2016 at 05:42:31PM +, Arguello, Sebastian wrote: > Add tests for the OVSDB IDL on-demand column mode. > > This commit includes three tests to verify the correct functionality > of the on-demand fetching at row, column, and table level. > > Co-Authored-By: Randall Esquivel > C

Re: [ovs-dev] [PATCH net-next 0/2] ovs: refresh a flow via netlink

2016-03-19 Thread Jesse Gross
On Thu, Mar 17, 2016 at 9:24 AM, Samuel Gauthier wrote: > 2016-03-17 0:23 GMT+01:00 Jesse Gross : >> On Wed, Mar 16, 2016 at 8:07 AM, Samuel Gauthier >> wrote: >>> This patchset adds a netlink api to refresh an existing flow in >>> openvswitch. >>> >>> When a packet is sent in the openvswitch ker

[ovs-dev] [PATCH 6/6] Update localnet ovn test to use physical endpoints

2016-03-19 Thread Darrell Ball
Signed-off-by: Darrell Ball --- tests/ovn.at | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/ovn.at b/tests/ovn.at index 689e544..dac36c8 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -840,12 +840,15 @@ for i in 1 2; do if test $j -le 2; then ovn-nbctl lport

[ovs-dev] [PATCH 0/2] doc: Refactor DPDK install guide

2016-03-19 Thread Bhanuprakash Bodireddy
This patchset refactors the present INSTALL.DPDK.md guide. The INSTALL guide is split in to two documents named INSTALL.DPDK and INSTALL.DPDK-ADVANCED. The former document is simplified with emphasis on installation, basic testcases and targets novice users. Sections related to system configuratio

[ovs-dev] [PATCH net-next 1/2] ovs: split ovs_flow_stats_update into skb and stats

2016-03-19 Thread Samuel Gauthier
The function to update statistics takes a skbuff as parameter. It would be handy to have the statistics update part in one function, and the skbuff part in another one. The next commit will make use of the new ovs_flow_stats_update function. Signed-off-by: Samuel Gauthier --- net/openvswitch/da

[ovs-dev] [PATCH 1/2] ovs-ctl: Remove code for upgrading from Open vSwitch 1.9 and earlier.

2016-03-19 Thread Ben Pfaff
OVS 1.10 was released in May 2013, so by the time current OVS is released, it will be about three years old. I think that this is long enough to remove special upgrade code from the startup scripts. Signed-off-by: Ben Pfaff --- utilities/ovs-ctl.in | 43 +

Re: [ovs-dev] [PATCH net-next 0/2] ovs: refresh a flow via netlink

2016-03-19 Thread David Miller
From: Samuel Gauthier Date: Wed, 16 Mar 2016 16:07:50 +0100 > This patchset adds a netlink api to refresh an existing flow in > openvswitch. This is too late for net-next, please resubmit this after the merge window. Thanks. ___ dev mailing list dev@o

Re: [ovs-dev] [PATCH] ovn: Update the test case for localnet port.

2016-03-19 Thread Han Zhou
On Tue, Mar 15, 2016 at 11:29 PM, Russell Bryant wrote: > > > On Sun, Mar 13, 2016 at 4:53 PM, Han Zhou wrote: > >> Localnet port is now able to connect vif ports on different HVs. >> Change the test case accordingly. >> >> Signed-off-by: Han Zhou >> > > I wonder if we should still test the old

Re: [ovs-dev] [RFC 0/8] OVN east-west loadbalancing.

2016-03-19 Thread Ben Pfaff
On Sun, Feb 28, 2016 at 10:33:16PM -0800, Gurucharan Shetty wrote: > This series adds support for OVN loadbalancing. This is very > lightly tested (with a very simple OVN topology of 1 router > and 2 lswitches), but the patches are far enough to get any > early feedback. > > The patches were teste

Re: [ovs-dev] ovn: broadcast packets dropped with "drop recirc action"

2016-03-19 Thread Ramu Ramamurthy
On 2016-03-15 11:16, Andy Zhou wrote: On Mon, Mar 14, 2016 at 12:11 PM, Ramu Ramamurthy < srama...@linux.vnet.ibm.com> wrote: When a logical switch (localnet) has lots of ports on a hypervisor, I find that broadcast packets from one of the ports is only forwarded to a subset of the other port

Re: [ovs-dev] [PATCH] openvswitch: call only into reachable nf-nat code

2016-03-19 Thread Arnd Bergmann
On Wednesday 16 March 2016 14:25:36 Pablo Neira Ayuso wrote: > Not related with this patch, just a side note/recommendation. > > I understand this code just got into tree, and that this needs a bit > work/iterations but this thing above is ugly, I wonder if there is a > better way to avoid this. >

Re: [ovs-dev] [ovs-dev, monitor_cond, V5, 00/18] ovsdb: create column index mapping between ovsdb row to monitor row

2016-03-19 Thread Ryan Moats
When I tried to apply these patches, they didn't go in clean, and when I tried to look up the dependent patch sets, the list was rather unmanageable. Would it be possible to get a rebase of this on top of the current master so that it is easier to see what the unmerged patches are that this depen

[ovs-dev] [PATCH 2/4] ovs_strerror, ovs_format_message: Always use "Success" for errno 0

2016-03-19 Thread YAMAMOTO Takashi
So that testsuite can compare log messages including the string. Signed-off-by: YAMAMOTO Takashi --- lib/util.c | 20 tests/ofproto-macros.at | 1 - 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/lib/util.c b/lib/util.c index f06dee5..36abeed 10

[ovs-dev] Deletion of Indirect Groups on Ovs2.5

2016-03-19 Thread Shuva Jyoti Kar
Hello, I am trying deletion of an indirect group on ovs2.5 . Now when I try to delete the group using the group-id and group-type without the buckets the group-deletion fails with an error OFPGMFC_INVALID_GROUP The Openflow 1.3.5 spec says that "If a delete request includes some buckets in th

Re: [ovs-dev] [ovs-dev, v2, 06/23] Move lib/dynamic-string.h to include/openvswitch directory

2016-03-19 Thread Ryan Moats
Original Message > From: Ben Warren > > Signed-off-by: Ben Warren > --- [snip] > diff --git a/ovn/controller/lflow.c b/ovn/controller/lflow.c > index 33dca9b..f72aeca 100644 > --- a/ovn/controller/lflow.c > +++ b/ovn/controller/lflow.c > @@ -15,7 +15,7 @@ > > #include > #inc

Re: [ovs-dev] [ovs-dev, v4, 1/3] system-traffic.at: Skip tests if namespaces or veths aren't supported.

2016-03-19 Thread Ryan Moats
Original Message > This prevents failure of test scenarios 'make check-kernel' > and 'make check-system-userspace' if creation of veth pairs or > network namespaces is not supported by kernel (or module isn't loaded). > > Signed-off-by: Ilya Maximets > --- > tests/system-common-macros.

Re: [ovs-dev] [PATCH] lib/util.c: Optimise bitwise_rscan.

2016-03-19 Thread Han Zhou
On Wed, Mar 16, 2016 at 10:03 PM, Ben Pfaff wrote: > On Wed, Mar 16, 2016 at 08:55:35PM -0700, Han Zhou wrote: > > bitwise_rscan() is found to be hot spot in ovn-controller during OVN > > scalability tests. It is triggered by lflow_run() when processing > > lflow updates from SB ovsdb. The perf r

Re: [ovs-dev] [PATCH v2 0/5] Initial support for OS X builds

2016-03-19 Thread Aaron Conole
Lance Richardson writes: > - Original Message - >> From: "Aaron Conole" >> To: "Lance Richardson" >> Cc: dev@openvswitch.org >> Sent: Tuesday, March 15, 2016 2:58:43 PM >> Subject: Re: [ovs-dev] [PATCH v2 0/5] Initial support for OS X builds >> >> Hi Lance, >> >> Lance Richardson wri

Re: [ovs-dev] Discontiguous bit mask in Megaflow

2016-03-19 Thread Peng He
Hi, Ben, I am not sure if this is a bug, but I think it probably is as the bit mask is not discontiguous, it can not reserve enough bits for a megaflow? Or this is intended to cache as less bits as possible? (a feature?) At 2016-03-18 23:38:04, "Ben Pfaff" wrote: >On Fri, Mar 18,

Re: [ovs-dev] [RFC PATCH linux-next] ovs: internal_set_rx_headroom() can be static

2016-03-19 Thread David Miller
From: kbuild test robot Date: Sat, 19 Mar 2016 00:54:50 +0800 > Signed-off-by: Fengguang Wu Looks good, applied, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] openvswitch: call only into reachable nf-nat code

2016-03-19 Thread Pablo Neira Ayuso
On Wed, Mar 16, 2016 at 01:47:13PM +0100, Arnd Bergmann wrote: > The openvswitch code has gained support for calling into the > nf-nat-ipv4/ipv6 modules, however those can be loadable modules > in a configuration in which openvswitch is built-in, leading > to link errors: > > net/built-in.o: In fu

Re: [ovs-dev] [net] openvswitch: Allow deferred action fifo to expand during run time

2016-03-19 Thread David Miller
From: Andy Zhou Date: Thu, 17 Mar 2016 21:32:13 -0700 > Current openvswitch implementation allows up to 10 recirculation actions > for each packet. This limit was sufficient for most use cases in the > past, but with more new features, such as supporting connection > tracking, and testing in larg

[ovs-dev] [patch v2] openvswitch: using a bit shift as a mask

2016-03-19 Thread Dan Carpenter
The original condition is never true. We want to test if BIT(0) is set but the code is ANDing with zero. Fixes: 05752523e565 ('openvswitch: Interface with NAT.') Signed-off-by: Dan Carpenter --- v2: use test_bit() instead diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c in

[ovs-dev] [PATCH v4 06/12] dpif-netdev: Wait an RCU grace period before freeing ports.

2016-03-19 Thread Daniele Di Proietto
The dpif-netdev datapath keeps ports in a cmap which is written only by the main thread (holding port_mutex), but which is read concurrently by many threads (most notably the pmd threads). When removing ports from the datapath we should postpone the deletion, otherwise another thread might access

Re: [ovs-dev] [PATCH v3 0/7] Add color output to `ovs-ofctl dump-flows` command

2016-03-19 Thread Ben Pfaff
On Wed, Mar 02, 2016 at 03:56:15PM +0100, Quentin Monnet wrote: > Proposal: add an option to ovs-ofctl utility so as to obtain colorized output > in tty, for easier reading. Currently, only the dump-flows command supports > colors. Thanks! I applied all of these patches to master. I folded in a

Re: [ovs-dev] [RFC PATCH] tunneling: Improving vxlan performance using DPDK flow director feature.

2016-03-19 Thread Chandran, Sugesh
Hi, This patch proposes an approach that uses Flow director feature on the Intel Fortville NICs to boost the VxLAN tunneling performance. In our testing we verified that the VxLAN performance is almost doubled with this patch. The solution programs the NIC to report the flow ID along with the V

[ovs-dev] [PATCH 07/14] Add flow support for gateway patch ports in ovn-controller

2016-03-19 Thread Darrell Ball
Signed-off-by: Darrell Ball --- ovn/controller/physical.c | 5 + 1 file changed, 5 insertions(+) diff --git a/ovn/controller/physical.c b/ovn/controller/physical.c index 5156a9b..5ed5f8e 100644 --- a/ovn/controller/physical.c +++ b/ovn/controller/physical.c @@ -169,6 +169,8 @@ physical_run(s

Re: [ovs-dev] [ovs-dev, monitor_cond, V5, 00/18] ovsdb: create column index mapping between ovsdb row to monitor row

2016-03-19 Thread Liran Schour
Ryan Moats/Omaha/IBM wrote on 18/03/2016 05:48:04 PM: > When I tried to apply these patches, they didn't go in clean, and > when I tried to look up the dependent patch sets, > the list was rather unmanageable. > > Would it be possible to get a rebase of this on top of the current > master so t

[ovs-dev] [PATCH v4 09/12] dpif-netdev: Document locking discipline for non_pmd_mutex.

2016-03-19 Thread Daniele Di Proietto
This just documents what the current code already assumes. Signed-off-by: Daniele Di Proietto --- lib/dpif-netdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 0268b9b..597e1d7 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -184,6 +1

Re: [ovs-dev] [PATCH 2/2] ovs-ctl: Remove code for upgrading from Open vSwitch 1.6 and earlier.

2016-03-19 Thread Jesse Gross
On Wed, Mar 16, 2016 at 4:45 PM, Ben Pfaff wrote: > OVS 1.7 was released in July 2012, so by the time current OVS is released, > it will be almost four years old. I think that this is long enough to > remove special upgrade code. > > Signed-off-by: Ben Pfaff Acked-by: Jesse Gross It's almost

[ovs-dev] [RFC PATCH v2] NUMA Aware vHost

2016-03-19 Thread Ciara Loftus
This RFC patch makes use of the CONFIG_RTE_LIBRTE_VHOST_NUMA option available in DPDK v2.2 that relocates vhost device memory managed by DPDK to the same NUMA node that QEMU device memory is located on. In OVS, now the mempool and PMD servicing the port are attempted to be relocated to this NUMA no

[ovs-dev] [PATCH] list.h: Define OVS_LIST_POISON statically

2016-03-19 Thread Nithin Raju
The previous definitions of these variables using designated initializers caused a variety of issues when attempting to compile with MSVC, particularly if including these headers from C++ code. By defining them like this, we can appease MSVC and keep the definitions the same on all platforms. Sugg

Re: [ovs-dev] [PATCH v3 02/11] dpif-netdev: Keep count of elements in port->rxq[].

2016-03-19 Thread Ilya Maximets
IMHO, it's confusing to have so many similar variables in all structures. Without this patch we already have: netdev->n_rxq netdev_dpdk->requested_n_rxq netdev_dpdk->real_n_rxq Another ways to get same variable: netdev_dpdk->up.n_rxq Plus, all netdev* variables are named in a complete chaos: 'ne

Re: [ovs-dev] [PATCH v4 01/12] netdev-dpdk: Consistent variable naming.

2016-03-19 Thread Ilya Maximets
On 17.03.2016 02:39, Daniele Di Proietto wrote: > In different functions we use different variable names ('netdev_', 'netdev', > 'dev', 'vhost_dev', ...) for the same objects. > > This commit changes the code to comply with the following convention: > > 'struct netdev':'netdev' > 'struct netdev_d

Re: [ovs-dev] Update on OVN east-west loadbalancing.

2016-03-19 Thread Ben Pfaff
On Wed, Mar 16, 2016 at 11:47:21AM -0600, Ryan Moats wrote: > > "dev" wrote on 03/14/2016 01:01:16 PM: > > > From: Ryan Moats/Omaha/IBM@IBMUS > > To: Ben Pfaff > > Cc: ovs dev , Guru Shetty > > Date: 03/14/2016 01:01 PM > > Subject: Re: [ovs-dev] [RFC 0/8] OVN east-west loadbalancing. > > Sent

Re: [ovs-dev] [RFC] ovs-ctl: Allow selective start for db and switch

2016-03-19 Thread Ben Pfaff
On Thu, Mar 17, 2016 at 09:54:14AM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > On Mon, Feb 29, 2016 at 03:40:56PM -0500, Aaron Conole wrote: > >> Currently, ``ovs-ctl start'' will attempt to start both the DB and > >> vswitchd. This is quite convenient when the database already has all of >

[ovs-dev] [PATCH v4 02/12] dpif-netdev: Proper error handling in do_add_port().

2016-03-19 Thread Daniele Di Proietto
This fixes multiple error path mistakes in do_add_port, none of which has been a problem in practice so far. This change will make it easier for a following commit to return in case of error. Also, this removes an unneeded special case for tunnel ports. Signed-off-by: Daniele Di Proietto --- li

Re: [ovs-dev] [PATCH] datapath-windows: Fix OVS_KEY_ATTR_ICMPV6 support

2016-03-19 Thread Sorin Vinturis
Acked-by: Sorin Vinturis -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean Sent: Thursday, 10 March, 2016 16:13 To: dev@openvswitch.org Subject: [ovs-dev] [PATCH] datapath-windows: Fix OVS_KEY_ATTR_ICMPV6 support This patch applies the conversion

[ovs-dev] [PATCH v6 5/6] datapath-windows: Extract flow metadata in execute cmd handler.

2016-03-19 Thread Sorin Vinturis
Signed-off-by: Sorin Vinturis Acked-by: Sairam Venugopal --- datapath-windows/ovsext/DpInternal.h | 1 + datapath-windows/ovsext/Flow.c | 17 + datapath-windows/ovsext/Flow.h | 2 ++ datapath-windows/ovsext/User.c | 7 +++ 4 files changed, 27 insertions(+

Re: [ovs-dev] [PATCH] rhel: Don't package ovs-testcontroller with ovn.

2016-03-19 Thread Ben Pfaff
On Wed, Mar 16, 2016 at 07:16:46PM -0700, Russell Bryant wrote: > This was a mistake. ovs-testcontroller was duplicated in the ovn > package. It's already in the main openvswitch package, where it > belongs. > > Signed-off-by: Russell Bryant > --- > rhel/openvswitch-fedora.spec.in | 1 - > 1 f

[ovs-dev] [PATCH] valgrind: Parse the summary of valgrind results.

2016-03-19 Thread William Tu
For target 'check-valgrind', add '-' before $(SHELL) so that even if test case fails, the make continues executing and reports total errors. The additional option --errors-for-leak-kinds=definite will consider valgrind's definite memory leaks as errors and show at the last line of valgrind.* as "ER

Re: [ovs-dev] [PATCH v4 0/4] Support native dhcp in ovn controller

2016-03-19 Thread Numan Siddique
On 03/16/2016 10:44 PM, Russell Bryant wrote: > It could also be this: > > dhcp_offer(offer_ip=10.0.0.3, netmask=255.255.255.0, mtu=1300, > dns={8.8.8.8, 7.7.7.7}); Thanks. This seems better to me. Regards Numan ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH] NEWS: Add 2.5.0 release date.

2016-03-19 Thread Ben Pfaff
On Wed, Mar 16, 2016 at 01:32:10PM -0700, Russell Bryant wrote: > OVS 2.5.0 was released. The date was updated in branch-2.5, but not > master. > > Signed-off-by: Russell Bryant Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://open

[ovs-dev] [ovs-dev, ovsdb-server, multithreading, RFC, 7/9] ovsdb: Add --max-num-threads commad line option

2016-03-19 Thread Ryan Moats
--- Original Message --- > > See ovsdb-server.1.in changes for details. > > Signed-off-by: Andy Zhou > --- > NEWS| 4 > ovsdb/ovsdb-server.1.in | 6 ++ > ovsdb/ovsdb-server.c| 55 ++ +-- > 3 files changed, 54 insertio

[ovs-dev] World biggest FDA store

2016-03-19 Thread Rhea
96 World biggest FDA shop p{margin:10px 0;padding:0;} table{border-collapse:collapse;} h1,h2,h3,h4,h5,h6{display:block;margin:0;padding:0;} img,a img{border:0;height:auto;outline:none;text-decoration:none;} body,#bodyTable,#bodyCell{height:100%;margin:0;padding:0;width:100%;} #outlo

Re: [ovs-dev] [ovs-dev, ovsdb-server, multithreading, RFC, 6/9] ovsdb: Add IPC messages for thread communication

2016-03-19 Thread Ryan Moats
Original Message > Add a command queue for the main thread to pass commands to the > sessions thread. > > Defined an implemented a set of IPC messages for creating, > closing and managing jsonrpc sessions from the main process to jsonrpc > sessions threads. > > Add a doorbell mechanism f

[ovs-dev] [RFC PATCH linux-next] ovs: internal_set_rx_headroom() can be static

2016-03-19 Thread kbuild test robot
Signed-off-by: Fengguang Wu --- vport-internal_dev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c index 83a5534..7c8b90b 100644 --- a/net/openvswitch/vport-internal_dev.c +++ b/net/openvswitch/

Re: [ovs-dev] [patch v2] openvswitch: using a bit shift as a mask

2016-03-19 Thread Dan Carpenter
It doesn't make sense to apply my patch. Can you please send your patch but give me a Reported-by: tag? regards, dan carpenter ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [ovs-dev, ovsdb-server, multithreading, RFC, 5/9] ovsdb: Add a 'big lock' to serialize all OVSDB operations

2016-03-19 Thread Ryan Moats
Original Message > Add a global lock to serialize all OVSDB operations. It is a simple > locking scheme to implement and to reason about correctness, without > much changes to core of OVSDB implementation. > > Signed-off-by: Andy Zhou Acked-by: Ryan Moats _

Re: [ovs-dev] [PATCH v3 10/11] netdev: Add reconfigure request mechanism.

2016-03-19 Thread Daniele Di Proietto
On 16/03/2016 06:12, "Ilya Maximets" wrote: >On 16.03.2016 01:30, Daniele Di Proietto wrote: >> A netdev provider, especially a PMD provider (like netdev DPDK) might >> not be able to change some of its parameters (such as MTU, or number of >> queues) without stopping everything and restarting.

Re: [ovs-dev] [PATCH] ofproto-dpif : propagate may_enable flag as link aliveness

2016-03-19 Thread Ben Pfaff
OK, now I understand. I see why the LIVE bit change gets sent when the port gets enabled as a result of port carrier status going up or down. It's because ofproto-dpif will report the port as changed via port_poll(), and thus ofproto_run() will pass it to process_port_change(). But the other rea

Re: [ovs-dev] How to define enum raw constants for two new vendor actions

2016-03-19 Thread Ben Pfaff
You didn't mention that part. It makes a difference. It's deceptive to use the name OFPAT_ENCAP_GTP because the OFPAT_ prefix implies that this is a standard action. Please choose your own prefix. On Thu, Mar 17, 2016 at 05:30:26PM +0530, Ajmer Singh wrote: > Hi Ben, > > This new "ENCAP_GTP" a

Re: [ovs-dev] [RFC PATCH] tunneling: Improving vxlan performance using DPDK flow director feature.

2016-03-19 Thread Jesse Gross
On Thu, Mar 17, 2016 at 3:43 PM, Chandran, Sugesh wrote: > Hi, > > This patch proposes an approach that uses Flow director feature on the Intel > Fortville NICs to boost the VxLAN tunneling performance. In our testing we > verified that the VxLAN performance is almost doubled with this patch. >

[ovs-dev] no OVN meeting in IRC tomorrow (March 17)

2016-03-19 Thread Ben Pfaff
We're having an in-person OVN meeting at VMware on Thursday and I imagine that most regular attendees will be at that meeting. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 00/10] PMD Testsuite.

2016-03-19 Thread Ilya Maximets
On 18.03.2016 05:13, Daniele Di Proietto wrote: > I'd be happy to merge the pmd tests with their requirements. > > I think we can convert a few tests (~10 or something) to be run with pmds > and non-pmd datapaths (using an approach similar to d13c05eef713, maybe). > I would still prefer avoiding a

Re: [ovs-dev] [PATCH 1/2] ovs-ctl: Remove code for upgrading from Open vSwitch 1.9 and earlier.

2016-03-19 Thread Ben Pfaff
On Wed, Mar 16, 2016 at 06:06:06PM -0700, Jesse Gross wrote: > On Wed, Mar 16, 2016 at 4:45 PM, Ben Pfaff wrote: > > diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in > > index 0082bed..c1fdd1a 100755 > > --- a/utilities/ovs-ctl.in > > +++ b/utilities/ovs-ctl.in > > -save_ofports_if_require

[ovs-dev] [PATCH 2/6] Add physical endpts and binding to logical ports to SB schema doc

2016-03-19 Thread Darrell Ball
Signed-off-by: Darrell Ball --- ovn/ovn-sb.xml | 68 ++ 1 file changed, 68 insertions(+) diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml index d62f1e4..fce7123 100644 --- a/ovn/ovn-sb.xml +++ b/ovn/ovn-sb.xml @@ -1168,6 +1168,66 @@ tcp.flags =

Re: [ovs-dev] Deletion of Indirect Groups on Ovs2.5

2016-03-19 Thread Shuva Jyoti Kar
Thanks Simon. Yes my understanding was also the same. It would be great that instead of throwing up on the group type, ignore it if present On Fri, Mar 18, 2016 at 8:10 AM, Simon Horman mailto:simon.hor...@netronome.com>> wrote: On Wed, Mar 16, 2016 at 05:48:23PM +, Shuva Jyoti Kar wrote:

Re: [ovs-dev] [PATCH 01/10] netdev: New field 'is_pmd' in netdev_class.

2016-03-19 Thread Daniele Di Proietto
Thanks for the patch, I had almost the exact same change in one of my local branches! Applied to master On 14/03/2016 08:18, "Ilya Maximets" wrote: >Made to simplify creation of derived classes. > >Signed-off-by: Ilya Maximets >--- > lib/netdev-bsd.c | 1 + > lib/netdev-dpdk.c | 1 +

Re: [ovs-dev] [PATCH 00/10] PMD Testsuite.

2016-03-19 Thread Daniele Di Proietto
I'd be happy to merge the pmd tests with their requirements. I think we can convert a few tests (~10 or something) to be run with pmds and non-pmd datapaths (using an approach similar to d13c05eef713, maybe). I would still prefer avoiding adding 500 tests, even though we found one bug with them.

[ovs-dev] [ovs-dev, v4, 3/3] tests/automake.mk: Prohibition of parallel system-traffic test execution.

2016-03-19 Thread Ryan Moats
Original Message > 'make check-system-userspace', 'make check-kernel' and 'make check-kmod' > work with real environment and can not be run in parallel mode. > > To prevent violation of the system environment force '-j1' option for > this targets. > > Signed-off-by: Ilya Maximets Acked

Re: [ovs-dev] [PATCH v2] openvswitch: call only into reachable nf-nat code

2016-03-19 Thread David Miller
From: Arnd Bergmann Date: Fri, 18 Mar 2016 14:33:45 +0100 > The openvswitch code has gained support for calling into the > nf-nat-ipv4/ipv6 modules, however those can be loadable modules > in a configuration in which openvswitch is built-in, leading > to link errors: > > net/built-in.o: In funct

[ovs-dev] [PATCH 12/14] Add software gateway logical port type - 'gw'

2016-03-19 Thread Darrell Ball
Signed-off-by: Darrell Ball --- ovn/ovn-nb.xml | 4 1 file changed, 4 insertions(+) diff --git a/ovn/ovn-nb.xml b/ovn/ovn-nb.xml index 5c8e942..3f056ed 100644 --- a/ovn/ovn-nb.xml +++ b/ovn/ovn-nb.xml @@ -138,6 +138,10 @@ A port to a logical switch on a VTEP gateway

[ovs-dev] Update on OVN east-west loadbalancing.

2016-03-19 Thread Ryan Moats
"dev" wrote on 03/14/2016 01:01:16 PM: > From: Ryan Moats/Omaha/IBM@IBMUS > To: Ben Pfaff > Cc: ovs dev , Guru Shetty > Date: 03/14/2016 01:01 PM > Subject: Re: [ovs-dev] [RFC 0/8] OVN east-west loadbalancing. > Sent by: "dev" > > "dev" wrote on 03/14/2016 12:57:10 PM: > > > From: Ben Pfaff

Re: [ovs-dev] [PATCH v3 10/11] netdev: Add reconfigure request mechanism.

2016-03-19 Thread Daniele Di Proietto
On 16/03/2016 06:12, "Ilya Maximets" wrote: >On 16.03.2016 01:30, Daniele Di Proietto wrote: >> A netdev provider, especially a PMD provider (like netdev DPDK) might >> not be able to change some of its parameters (such as MTU, or number of >> queues) without stopping everything and restarting.

Re: [ovs-dev] [ovs-dev, ovsdb-server, multithreading, RFC, 1/9] ovsdb: Do not group sessions by remote.

2016-03-19 Thread Ryan Moats
Andy Zhou wrote on 03/16/2016 02:43:40 PM: > From: Andy Zhou > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev > Date: 03/16/2016 02:44 PM > Subject: Re: [ovs-dev] [ovs-dev, ovsdb-server, multithreading, RFC, > 1/9] ovsdb: Do not group sessions by remote. > > On Wed, Mar 16, 2016 at 11:43 AM, Rya

[ovs-dev] [PATCH] openvswitch: reduce padding in struct sw_flow_key

2016-03-19 Thread Arnd Bergmann
It's been a while since the last time sw_flow_key was made smaller in 1139e241ec43 ("openvswitch: Compact sw_flow_key."), and it has seen five patches adding new members since then. With the current linux-next kernel and gcc-6.0 on ARM, this has tipped us slightly over the stack frame warning limi

Re: [ovs-dev] Discontiguous bit mask in Megaflow

2016-03-19 Thread Ben Pfaff
It's not a bug. I think that you should read our research paper from NSDI 2015. It explains how OVS megaflows work: http://openvswitch.org/support/papers/nsdi2015.pdf On Sat, Mar 19, 2016 at 05:21:00PM +0800, Peng He wrote: > Hi, Ben, > I am not sure if this is a bug, but I think i

Re: [ovs-dev] [PATCH] ofp-actions: Fix use-after-free with ofpact_finish().

2016-03-19 Thread Ben Pfaff
On Mon, Mar 07, 2016 at 03:36:37PM -0800, Joe Stringer wrote: > ofpact_finish() may now reallocate the buffer it is passed, but not all > callers updated their local pointers to the current action in the > buffer. This could potentially lead to several use-after-free bugs. > > Update ofpact_finish

  1   2   3   >