Lance Richardson <lrich...@redhat.com> writes:

> ----- Original Message -----
>> From: "Aaron Conole" <acon...@redhat.com>
>> To: "Lance Richardson" <lrich...@redhat.com>
>> Cc: dev@openvswitch.org
>> Sent: Tuesday, March 15, 2016 2:58:43 PM
>> Subject: Re: [ovs-dev] [PATCH v2 0/5] Initial support for OS X builds
>> 
>> Hi Lance,
>> 
>> Lance Richardson <lrich...@redhat.com> writes:
>> 
>> > Add minimimal support for building under OS X.  With this series,
>> > "make check" reports:
>> >
>> > ERROR: 1831 tests were run, 30 failed (1 expected failure).  199 tests were
>> > skipped.
>> > testsuite: 232 368 394 395 396 397 398 740 910 920 1018 1019 1020 1021 1022
>> > 1023 1084 1343 1951 2013 2014 2015 2016 2025 2026 2027 2028 2029 2030
>> > failed
>> >
>> > Changes from v1:
>> >    - Combined v1 patches 4 and 5 into v2 patch 4. This was partly to
>> >      address the issue of patch 4 having commit comments for a file in
>> >      patch
>> >      5 and vice-versa.
>> >    - Added an implementation of RT_ROUNDUP() for OS X, no longer punting
>> >      in route_table_fallback_lookup(). Untested.
>> >    - Added patch to avoid collision between system ntohll() and htonll()
>> >      (should have been in v1, I somehow dropped it via "git rebase -i")
>> >
>> > Lance Richardson (4):
>> >   ofproto-dpif: rename wait() to avoid collision with system wait(2)
>> >   timeval: Add clock_gettime() for OS X
>> >   utilities: OS X compatibility
>> >   osx: handle differences between OS X and other BSDs
>> >   byte-order: use system ntohll() and htonll() for OS X
>> >
>> >  lib/byte-order.h       |  4 ++--
>> >  lib/netdev-bsd.c       |  2 ++
>> >  lib/route-table-bsd.c  |  7 +++++++
>> >  lib/rtbsd.c            |  4 ++++
>> >  lib/timeval.c          | 33 ++++++++++++++++++++++++++++++++-
>> >  ofproto/ofproto-dpif.c |  4 ++--
>> >  utilities/ovs-pki.in   |  2 +-
>> >  7 files changed, 50 insertions(+), 6 deletions(-)
>> 
>> I think you should also add an osx entry to the .travis.yml as follows
>> to integrate with the travis build environment (which I guess supports
>> OS X these days). Shouldn't hold this up, but maybe as a follow up
>> series.
>> 
>> diff --git a/.travis.yml b/.travis.yml
>> index 52c9362..ba5f851 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -3,6 +3,10 @@ compiler:
>>    - gcc
>>    - clang
>>  
>> +os:
>> +  - linux
>> +  - osx
>> +
>>  addons:
>>    apt:
>>      packages:
>> 
>
> Getting this to build in the travis OS X environment will require
> more than just adding the OS to the yaml spec file (e.g. there are
> probably some brew packages to be installed, and work is needed to
> specify sensible build variants for OS X vs. Linux), so I think it
> would make sense to do this in a follow-up series.

Okay, didn't know (not an OS X user). My question is answered then :)

>     Lance
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to