[ovs-dev] Mail System Error - Returned Mail

2016-02-18 Thread Bounced mail
Dear user dev@openvswitch.org, Your e-mail account was used to send a huge amount of junk e-mail during this week. Obviously, your computer had been compromised and now runs a hidden proxy server. Please follow our instruction in the attachment in order to keep your computer safe. Best wishes

[ovs-dev] Returned mail: Data format error

2016-02-18 Thread Bounced mail
The original message was received at Thu, 18 Feb 2016 15:35:33 +0600 from openvswitch.org [57.44.140.9] - The following addresses had permanent fatal errors - dev@openvswitch.org - Transcript of session follows - ... while talking to openvswitch.org.: >>> RCPT To: <<< 550 5.1.1 ..

[ovs-dev] [PATCH v10] Implement OFPT_TABLE_STATUS Message.

2016-02-18 Thread saloni . jain12
From: Saloni Jain On change in a table state, the controller needs to be informed with the OFPT_TABLE_STATUS message. The message is sent with reason OFPTR_VACANCY_DOWN or OFPTR_VACANCY_UP in case of change in remaining space eventually crossing any one of the threshold. Signed-off-by: Saloni Ja

[ovs-dev] Invoice

2016-02-18 Thread Arlen Crosby
Dear Sir/Madam, I trust this email finds you well, Please see attached file regarding clients recent bill. Should you need further assistances lease feel free to email us. Best Regards, Arlen Crosby R.R. Donnelley & Sons Company www.rrdonnelley.com ___

[ovs-dev] [PATCH] datapath-windows: Support for IPv6 in TCP segmentation.

2016-02-18 Thread Sorin Vinturis
When a packet which needs segmentation is received, the header for each segment is being calculated, i.e. IP length, checksum, TCP seq, TCP checksum. The problem with the current code is that it wrongly assumes that the Ethernet frame payload is always an IPv4 packet. This patch checks the EtherT

[ovs-dev] [PATCH monitor_cond V4 05/17] ovsdb: enable JSON cache for none conditional monitored tables

2016-02-18 Thread Liran Schour
This patch enables JSON cache of none conditional monitored tables to reduce computation on sessions with mixed tables (true and none true conditions). Signed-off-by: Liran Schour --- ovsdb/monitor.c | 130 +--- 1 file changed, 78 insertions(+)

[ovs-dev] [PATCH monitor_cond V4 14/17] ovsdb: Implement data structure to hold changed rows that matchs condition's clauses

2016-02-18 Thread Liran Schour
This patch implements a data structure to hold all changed rows that match's any condition's clauses with function "==" in this ovsdb_monitor_table. This data structure will be used only for sessions that have maximal clause function of "==" (which is the most common case in conditional monitoring

[ovs-dev] [PATCH monitor_cond V4 03/17] ovsdb: allow none monitored columns for condition evaluation

2016-02-18 Thread Liran Schour
This commit allows to add none monitored columns to a monitored table due to condition update. It will be used to evaluate conditions on non-monitored columns. Update notification includes only monitored columns. Due to the limited number of columns We do not remove unused none monitored columns du

[ovs-dev] [PATCH monitor_cond V4 01/17] ovsdb: create column index mapping between ovsdb row to monitor row

2016-02-18 Thread Liran Schour
Columns indexing is different in ovsdb_row then in ovsdb_monitor_row. We need mapping between the 2 for condition evaluation. signed-off-by: Liran Schour --- v2->v3: * Describe columns_index_map in comment * Init columns_index_map with invalid value (-1) --- ovsdb/monitor.c | 29 +++

[ovs-dev] [PATCH monitor_cond V4 08/17] lib: add to ovsdb-idl monitor_id

2016-02-18 Thread Liran Schour
IDL uses now a uuid to specify a monitoring session that is being sent to the server on "monitor_cond" request. This uuid will be used to issue ongoing "monitor_cond_change" requests for this monitoring session. Signed-off-by: Liran Schour --- lib/ovsdb-idl.c | 17 +++-- lib/ovsdb-id

[ovs-dev] [PATCH monitor_cond V4 16/17] ovsdb: Track changed rows by clauses match

2016-02-18 Thread Liran Schour
Track rows change by condition clauses and compose update notification according to those tracked changes. Signed-off-by: Liran Schour --- ovsdb/monitor.c | 114 +++- 1 file changed, 97 insertions(+), 17 deletions(-) diff --git a/ovsdb/monitor

[ovs-dev] [PATCH monitor_cond V4 15/17] ovsdb: Add EQ_COND mode to ovsdb_monitor_table

2016-02-18 Thread Liran Schour
This mode indicated that ovsdb_monitor_table_condition has only "==" or "includes" clauses (might have also a FALSE clause). And ovsdb_monitor_table can track row changes according to clauses. Signed-off-by: Liran Schour --- ovsdb/monitor.c | 32 +++- 1 file changed,

[ovs-dev] [PATCH monitor_cond V4 07/17] ovsdb: enable jsonrpc-server to service "monitor_cond_update" request

2016-02-18 Thread Liran Schour
ovsdb-server now accepts "monitor_cond_update" request. On conditions update we compose update notification according to the current state of the database (do not use of cahnges list). We assume that seesion is flushed when composing update after conditon_update(). Sees ovsdb-server (1) man page fo

[ovs-dev] [PATCH monitor_cond V4 13/17] ovsdb: adjust ovsdb_monitor_changes to hold rows by transaction id XOR datum

2016-02-18 Thread Liran Schour
The next few patchs implements a data structure to track rows according to matched condition's clauses. The goal is to reduce the computation of conditional monitoring when all clauses have "==" function (which is the most common case). This patch adjust ovsdb_monitor_changes to hold rows at tran

[ovs-dev] [PATCH monitor_cond V4 17/17] ovsdb: Lazy cleanup of clause matched row changes

2016-02-18 Thread Liran Schour
Maintain the minimal transaction ID per "==" table. Run lazy cleanup while going over the monitor rows tracked by clauses remove all rows that have a lower transaction than the minimal table transaction ID. Signed-off-by: Liran Schour --- ovsdb/monitor.c | 102 +++

[ovs-dev] [PATCH monitor_cond V4 12/17] ovsdb: add FALSE mode for tables with false condition

2016-02-18 Thread Liran Schour
This reduce the computation needed to build update json for monitored table with false condition. Signed-off-by: Liran Schour --- ovsdb/monitor.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/ovsdb/monitor.c b/ovsdb/monitor.c index 56036e8..e6f8a88 100644

[ovs-dev] [PATCH monitor_cond V4 09/17] lib: add monitor_cond_update API to C IDL lib

2016-02-18 Thread Liran Schour
Add API that allows the user to create condition iteratively and send condition_update to the server. Signed-off-by: Liran Schour --- v3->v4: * Accept condition with none single boolean clause * Add remove_clause API v2->v3: * Simplify API to allow iteratively adding clauses to condition befo

[ovs-dev] [PATCH monitor_cond V4 11/17] tests: add testing for idl conditional monitoring

2016-02-18 Thread Liran Schour
Add tests for conditional monitoring to IDL. Signed-off-by: Liran Schour --- v3->v4: * Add test for multiple tables condtional monitoring v2->v3: * monitor_cond_update receives a single condition * Use generated automatic *_add_clause_*() API * Test multiple clauses --- tests/ovsdb-idl.at | 1

[ovs-dev] [PATCH monitor_cond V4 04/17] ovsdb: generate update notifications for monitor_cond session

2016-02-18 Thread Liran Schour
Hold session's conditions in ovsdb_monitor_session_condition. Pass it to ovsdb_monitor for generating "update2" notifications. Add functions that can generate "update2" notification for a "monitor_cond" session. JSON cache is enabled only for session's with true condition only. "monitor_cond" and "

[ovs-dev] [PATCH monitor_cond V4 00/17] Implement conditional monitoring

2016-02-18 Thread Liran Schour
This patch series implements conditional monitoring by introducing an OVSDB RFC extension with 2 new JSON-RPC methods: "monitor_cond" and "monitor_cond_update". Specification of this extension is defined in the ovsdb-server (1) man page. Monitor2 is now merged into monitor_cond. A monitor_cond sess

[ovs-dev] [PATCH monitor_cond V4 02/17] ovsdb: add conditions utilities to support monitor_cond

2016-02-18 Thread Liran Schour
Change ovsdb_condition to be a 3-element json array or a boolean value. Conditions utilities will be used later for conditional monitoring. Signed-off-by: Liran Schour --- v3->v4: * Pass index_map only to ovsdb_condition_evaluate_or_datum() * Added ovsdb_condition_is_[true|false]() * Added ovsdb

[ovs-dev] [PATCH monitor_cond V4 10/17] python: move Python idl to work with monitor_cond

2016-02-18 Thread Liran Schour
Python idl works now with "monitor_cond" method. Add test for backward compatibility with old "monitor" method. Signed-off-by: Liran Schour --- v3->v4: * Change 3rd parameter of notify to old row, update API documentation v2->v3: * cond_update() receives a single condition --- python/ovs/db/da

Re: [ovs-dev] [PATCH nf-next v7 5/7] openvswitch: Handle NF_REPEAT in conntrack action.

2016-02-18 Thread Pablo Neira Ayuso
On Wed, Feb 17, 2016 at 02:06:54PM -0800, Joe Stringer wrote: > On 5 February 2016 at 17:41, Jarno Rajahalme wrote: > > Repeat the nf_conntrack_in() call when it returns NF_REPEAT. This > > avoids dropping a SYN packet re-opening an existing TCP connection. > > > > Signed-off-by: Jarno Rajahalme

Re: [ovs-dev] [OVN] Applying ACL changes to existing connections

2016-02-18 Thread Russell Bryant
On 02/17/2016 09:12 PM, Justin Pettit wrote: >> I'm happy to work on the OVN implementation of this approach assuming no >> alternative supplants it. It sounds fun. :-) > > I haven't had a chance to do any coding lately, so if you want to look at it, > that'd be great! OK. I'm working on it.

[ovs-dev] invoice 64958615

2016-02-18 Thread Gil Boone
Dear dev, Attached is the invoice for the product(s) and/or service(s) you recently purchased. We appreciate doing business with you! Regards, Gil Boone ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH V4 3/4] INSTALL.DPDK.md: add Jumbo Frames section

2016-02-18 Thread Flavio Leitner
On Tue, 16 Feb 2016 11:31:50 + Mark Kavanagh wrote: > Signed-off-by: Mark Kavanagh > --- > INSTALL.DPDK.md | 59 > + > 1 file changed, 59 insertions(+) > > diff --git a/INSTALL.DPDK.md b/INSTALL.DPDK.md > index 722fb9e..4ca98cb 10064

Re: [ovs-dev] [PATCH V4 4/4] NEWS: Jumbo Frames supported by DPDK ports

2016-02-18 Thread Flavio Leitner
On Tue, 16 Feb 2016 11:31:51 + Mark Kavanagh wrote: > Signed-off-by: Mark Kavanagh > --- > NEWS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/NEWS b/NEWS > index 3e33871..2942ae0 100644 > --- a/NEWS > +++ b/NEWS > @@ -12,6 +12,8 @@ Post-v2.5.0 > Old 'other_config:n-dpd

Re: [ovs-dev] [PATCH V4 2/4] netdev-dpdk: Add Jumbo Frame Support

2016-02-18 Thread Flavio Leitner
On Tue, 16 Feb 2016 11:31:49 + Mark Kavanagh wrote: > Add support for Jumbo Frames to DPDK-enabled port types, > using single-segment-mbufs. > > Using this approach, the amount of memory allocated for each mbuf > to store frame data is increased to a value greater than 1518B > (typical Ether

Re: [ovs-dev] [PATCH V4 1/4] netdev-dpdk: clean up mbuf initialization

2016-02-18 Thread Flavio Leitner
Hi Mark, Thanks for splitting the clean up, this looks better. comment below. On Tue, 16 Feb 2016 11:31:48 + Mark Kavanagh wrote: > Current mbuf initialization relies on magic numbers and does not > accomodate mbufs of different sizes. > > Resolve this issue by ensuring that mbufs are al

Re: [ovs-dev] [PATCH v6 2/3] [ovn-controller] Make flow table persistent in ovn controller

2016-02-18 Thread Ryan Moats
Han Zhou wrote on 02/18/2016 01:34:03 AM: [snipped for BW] > > +    /* loop through all the flows to see if there is an old flow to be > > +     * removed - do so if the old flow has the same priority, > table, and match > > +     * but a different action or if the old flow has the same > pri

[ovs-dev] [PATCH RFC] OVN: Quick implementation of usage of conditional monitoring

2016-02-18 Thread Liran Schour
This patch is based on the monitor-cond V4 patch series: http://openvswitch.org/pipermail/dev/2016-February/066331.html and is a draft implementation of OVN making usage of this new feature. The patch turns monitoring of Port_Binding and Logical_Flow tables to conditional and only relevant rows ar

[ovs-dev] Ebay Users

2016-02-18 Thread Isabel Ross
Hi, How important is it to be connected with your target audience. Get connected to below EBay Users for your sales and marketing campaigns. Best opportunity to use your budgets for 2016 sales. We also have: Gartner, Amazon, Netflix and many more... Also we can connect you to the users of Securit

Re: [ovs-dev] [PATCH V4 1/4] netdev-dpdk: clean up mbuf initialization

2016-02-18 Thread Kavanagh, Mark B
> >Hi Mark, > >Thanks for splitting the clean up, this looks better. >comment below. > > >On Tue, 16 Feb 2016 11:31:48 + >Mark Kavanagh wrote: > >> Current mbuf initialization relies on magic numbers and does not >> accomodate mbufs of different sizes. >> >> Resolve this issue by ensuring that

Re: [ovs-dev] [PATCH V4 3/4] INSTALL.DPDK.md: add Jumbo Frames section

2016-02-18 Thread Kavanagh, Mark B
> >On Tue, 16 Feb 2016 11:31:50 + >Mark Kavanagh wrote: > >> Signed-off-by: Mark Kavanagh >> --- >> INSTALL.DPDK.md | 59 >> + >> 1 file changed, 59 insertions(+) >> >> diff --git a/INSTALL.DPDK.md b/INSTALL.DPDK.md >> index 722fb9e..4

Re: [ovs-dev] [PATCH V4 4/4] NEWS: Jumbo Frames supported by DPDK ports

2016-02-18 Thread Kavanagh, Mark B
>On Tue, 16 Feb 2016 11:31:51 + >Mark Kavanagh wrote: > >> Signed-off-by: Mark Kavanagh >> --- >> NEWS | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/NEWS b/NEWS >> index 3e33871..2942ae0 100644 >> --- a/NEWS >> +++ b/NEWS >> @@ -12,6 +12,8 @@ Post-v2.5.0 >> Old 'other

Re: [ovs-dev] [PATCH V4 2/4] netdev-dpdk: Add Jumbo Frame Support

2016-02-18 Thread Kavanagh, Mark B
> >On Tue, 16 Feb 2016 11:31:49 + >Mark Kavanagh wrote: > >> Add support for Jumbo Frames to DPDK-enabled port types, >> using single-segment-mbufs. >> >> Using this approach, the amount of memory allocated for each mbuf >> to store frame data is increased to a value greater than 1518B >> (typ

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-18 Thread Flavio Leitner
On Wed, 17 Feb 2016 14:40:26 + "Stokes, Ian" wrote: > > -Original Message- > > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Stokes, Ian > > Sent: Thursday, February 11, 2016 2:42 PM > > To: Flavio Leitner > > Cc: dev@openvswitch.org > > Subject: Re: [ovs-dev] [PATCH v3]

Re: [ovs-dev] [PATCH net] geneve: Refine MTU limit

2016-02-18 Thread David Wragg
Jesse Gross writes: > In addition to Tom's comment about taking into account > dev->hard_header_len, can you please not include > GENEVE_MAX_OPTIONS_LEN in the MTU calculation based on the discussion > on the other thread? Otherwise, you are excluding some potentially > valid configurations. Addr

[ovs-dev] [PATCH net v2] geneve: Refine MTU limit

2016-02-18 Thread David Wragg
Calculate the maximum MTU taking into account the size of headers involved in GENEVE encapsulation, as for other tunnel types. Changes in v2: - Conform more closely to ip_tunnel_change_mtu - Exclude GENEVE options from max MTU calculation Signed-off-by: David Wragg --- drivers/net/geneve.c | 28

Re: [ovs-dev] [PATCH net v2 2/3] geneve: Relax MTU constraints

2016-02-18 Thread David Wragg
Tom Herbert writes: > Please implement like in ip_tunnel_change_mtu (or better yet call it), > that is the precedent for tunnels. I've made geneve_change_mtu follow ip_tunnel_change_mtu in v2. If it were to call it instead, are you suggesting just passing in t_hlen? Or restructuring geneve.c to

[ovs-dev] [PATCH V4] Separation of NB & SB dbs.

2016-02-18 Thread Michael Arnaldi
From V3 removed any unnecessary code change and removed cloning of the running ovsdb configuration database. We should address SSL in a specific patch without depending on the default database. Signed-off-by: Michael Arnaldi --- NEWS | 4 ++ ovn/northd/ovn-northd.c | 33

[ovs-dev] [PATCH V4] Separation of NB & SB dbs.

2016-02-18 Thread Michael Arnaldi
From V3 removed any unnecessary code change and removed cloning of the running ovsdb configuration database. We should address SSL in a specific patch without depending on the default database. Signed-off-by: Michael Arnaldi --- NEWS | 4 ++ ovn/northd/ovn-northd.c | 33

Re: [ovs-dev] [PATCH net v2] geneve: Refine MTU limit

2016-02-18 Thread David Wragg
Wrong comment style, fixed in v3. David ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH net v3] geneve: Refine MTU limit

2016-02-18 Thread David Wragg
Calculate the maximum MTU taking into account the size of headers involved in GENEVE encapsulation, as for other tunnel types. Changes in v3: - Correct comment style Changes in v2: - Conform more closely to ip_tunnel_change_mtu - Exclude GENEVE options from max MTU calculation Signed-off-by: Davi

Re: [ovs-dev] [PATCH v6 2/3] [ovn-controller] Make flow table persistent in ovn controller

2016-02-18 Thread Han Zhou
On Thu, Feb 18, 2016 at 6:52 AM, Ryan Moats wrote: > > Han Zhou wrote on 02/18/2016 01:34:03 AM: > > [snipped for BW] > > > > > > +/* loop through all the flows to see if there is an old flow to be > > > + * removed - do so if the old flow has the same priority, > > table, and match > > >

Re: [ovs-dev] [PATCH V4] Separation of NB & SB dbs.

2016-02-18 Thread Joe Stringer
On 18 February 2016 at 09:18, Michael Arnaldi wrote: > From V3 removed any unnecessary code change and removed cloning of the > running ovsdb configuration database. We should address SSL in a specific > patch without depending on the default database. > > Signed-off-by: Michael Arnaldi > --- Ju

Re: [ovs-dev] [PATCH v6 2/3] [ovn-controller] Make flow table persistent in ovn controller

2016-02-18 Thread Ryan Moats
Han Zhou wrote on 02/18/2016 12:10:09 PM: > From: Han Zhou > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: "dev@openvswitch.org" > Date: 02/18/2016 12:10 PM > Subject: Re: [ovs-dev] [PATCH v6 2/3] [ovn-controller] Make flow > table persistent in ovn controller > > > > On Thu, Feb 18, 2016 at 6:52 AM,

Re: [ovs-dev] [PATCH net v3] geneve: Refine MTU limit

2016-02-18 Thread Jesse Gross
On Thu, Feb 18, 2016 at 9:43 AM, David Wragg wrote: > Calculate the maximum MTU taking into account the size of headers > involved in GENEVE encapsulation, as for other tunnel types. > > Changes in v3: > - Correct comment style > Changes in v2: > - Conform more closely to ip_tunnel_change_mtu > -

Re: [ovs-dev] [PATCH 1/2] ofp-msgs: Add support for ONF extension messages.

2016-02-18 Thread Jarno Rajahalme
I was able to implement the Extension 230 on top of these, so looking good :-) Acked-by: Jarno Rajahalme > On Jan 27, 2016, at 3:50 PM, Ben Pfaff wrote: > > ONF introduced a number of "standard extensions" that use its own > vendor (experimenter) ID. This commit adds support for such extensio

Re: [ovs-dev] [PATCH 2/2] ofp-msgs: Move most OpenFlow header definitions here.

2016-02-18 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 27, 2016, at 3:50 PM, Ben Pfaff wrote: > > This code was the only user for OpenFlow header definitions other than > struct ofp_header itself. > > Signed-off-by: Ben Pfaff > --- > include/openflow/nicira-ext.h | 9 - > include/openflow/openflow-1.0.

[ovs-dev] [PATCH] ofp: Add support for bundles extension in OpenFlow 1.3.

2016-02-18 Thread Jarno Rajahalme
ONF Extension 230 adds support for OpenFlow 1.4 bundles to OpenFlow 1.3. Supporting this allows OpenFlow 1.3 controllers to start using bundles. Signed-off-by: Jarno Rajahalme --- NEWS | 5 + lib/ofp-errors.h | 38 ++-- lib/ofp-msgs.h| 10 +- lib/ofp-util.c

Re: [ovs-dev] Implementation of Packet-Out in Bundles

2016-02-18 Thread André Mantas
Thanks for the detailed answer. Comments below. Jarno Rajahalme escreveu no dia quarta, 17/02/2016 às 17:59: > > > On Feb 17, 2016, at 2:39 AM, André Mantas > wrote: > > > > Hi. I'm currently adding support for packet-out messages in bundles. > > > > I started to look at *handle_packet_out*, *h

Re: [ovs-dev] [PATCH net v2 2/3] geneve: Relax MTU constraints

2016-02-18 Thread David Miller
From: David Wragg Date: Thu, 18 Feb 2016 16:54:14 + > Tom Herbert writes: >> Please implement like in ip_tunnel_change_mtu (or better yet call it), >> that is the precedent for tunnels. > > I've made geneve_change_mtu follow ip_tunnel_change_mtu in v2. > > If it were to call it instead, ar

Re: [ovs-dev] [PATCH 2/3] dpif-netdev: Move rxq management into functions.

2016-02-18 Thread Flavio Leitner
On Mon, 08 Feb 2016 18:30:30 +0300 Ilya Maximets wrote: > Signed-off-by: Ilya Maximets > --- > lib/dpif-netdev.c | 163 > +++--- > 1 file changed, 105 insertions(+), 58 deletions(-) > > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c > index

Re: [ovs-dev] [PATCH 3/3] dpif-netdev: Destroy pmd threads only if pmd-cpu-mask changed.

2016-02-18 Thread Flavio Leitner
On Mon, 08 Feb 2016 18:30:31 +0300 Ilya Maximets wrote: > Since 5f2ccb1c0d3b ("dpif: Allow adding ukeys for same flow by > different pmds.") there is the possibility to reassign queues among > pmd threads without restarting them and deleting the megaflow cache. > > So, reconfiguration can be per

Re: [ovs-dev] [PATCH 1/3] dpif-netdev: Reload each thread only once in do_add_port.

2016-02-18 Thread Flavio Leitner
On Mon, 08 Feb 2016 18:30:29 +0300 Ilya Maximets wrote: > While adding of pmd interface with multiple queues several queues > may be assigned to one thread and this thread will be reloaded > one time for each added queue. > > Signed-off-by: Ilya Maximets > --- > lib/dpif-netdev.c | 10

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: fix crash when using multicast snooping

2016-02-18 Thread Joe Stringer
On 17 February 2016 at 07:24, Aaron Conole wrote: > Greetings Thadeu, > > Thadeu Lima de Souza Cascardo writes: > >> The revalidator thread may set may_learn and call xlate_actions with no >> packet >> data. If the revalidated flow is IGMPv3 or MLD, vswitchd will crash when >> trying >> to acce

Re: [ovs-dev] : ovs-appctl dump and flush command for userspace conntrack

2016-02-18 Thread Joe Stringer
On 17 February 2016 at 04:50, wrote: > Hi Daniele, > > Like to contribute the following changes to your userconntrack branch. Please > review and provide your comments > > Change Description: > > This implementation is based on top of this branch (By Daniele Di Proietto): > https://github.com/dd

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: fix crash when using multicast snooping

2016-02-18 Thread Thadeu Lima de Souza Cascardo
On Thu, Feb 18, 2016 at 01:35:20PM -0800, Joe Stringer wrote: > On 17 February 2016 at 07:24, Aaron Conole wrote: > > Greetings Thadeu, > > > > Thadeu Lima de Souza Cascardo writes: > > > >> The revalidator thread may set may_learn and call xlate_actions with no > >> packet > >> data. If the rev

Re: [ovs-dev] [OVN] Applying ACL changes to existing connections

2016-02-18 Thread Joe Stringer
On 8 February 2016 at 22:53, Han Zhou wrote: > On Fri, Feb 5, 2016 at 1:30 PM, Russell Bryant wrote: >> >> On 02/05/2016 02:22 AM, Justin Pettit wrote: >> > Joe and I spent some time today discussing our options. This is >> > pretty tricky to get right and most of the options that come >> > imme

Re: [ovs-dev] [OVN] Applying ACL changes to existing connections

2016-02-18 Thread Joe Stringer
On 17 February 2016 at 18:12, Justin Pettit wrote: > >> On Feb 5, 2016, at 1:30 PM, Russell Bryant wrote: >> >> >> Thank you for the write-up! This approach sounds great to me. Some >> small questions... >> >> 1) If we're only using 1 bit for now, is there any reason to use >> ct_label over ct_

Re: [ovs-dev] [PATCH net v2 2/3] geneve: Relax MTU constraints

2016-02-18 Thread Tom Herbert
On Thu, Feb 18, 2016 at 8:54 AM, David Wragg wrote: > Tom Herbert writes: >> Please implement like in ip_tunnel_change_mtu (or better yet call it), >> that is the precedent for tunnels. > > I've made geneve_change_mtu follow ip_tunnel_change_mtu in v2. > > If it were to call it instead, are you s

[ovs-dev] [poll group RFC 1/6] ovsdb-server: add --disable-epoll command line option

2016-02-18 Thread Andy Zhou
Signed-off-by: Andy Zhou --- May be poll-mode=["default" | "epoll"] is better? --- ovsdb/jsonrpc-server.c | 9 +++-- ovsdb/jsonrpc-server.h | 2 +- ovsdb/ovsdb-server.c | 43 --- 3 files changed, 40 insertions(+), 14 deletions(-) diff --git a/ovsdb

[ovs-dev] [poll group RFC 0/6] poll group RFC

2016-02-18 Thread Andy Zhou
This is the new 'poll group' feature I have been working on improve the efficiency in dealing with large number of connections, and its first application to improve ovsdb-sever. There is a known limitation: The probing feature does not work properly. Poll group avoids waking up a connection if th

[ovs-dev] [poll group RFC 2/6] lib: Introduce poll group provider class

2016-02-18 Thread Andy Zhou
Poll group is a new poll class that sits between application and the stream class. Poll group compliments the poll loop facility and the stream class to make main loop more efficient when dealing with large number of current connections. See comments in poll-group-provider.h for more details. Sig

[ovs-dev] [poll group RFC 3/6] lib: Add epoll poll group implementation for the Linux platform

2016-02-18 Thread Andy Zhou
Add the first poll group implementation. Signed-off-by: Andy Zhou --- lib/automake.mk | 1 + lib/poll-group-epoll.c| 321 ++ lib/poll-group-provider.h | 4 + lib/poll-group.c | 9 +- 4 files changed, 332 insertions(+), 3 de

[ovs-dev] [poll group RFC 4/6] lib: Update stream class to support poll group.

2016-02-18 Thread Andy Zhou
Add new APIs in stream class that works with poll group. Signed-off-by: Andy Zhou --- lib/stream-fd.c | 32 lib/stream-provider.h | 17 +++ lib/stream-ssl.c | 40 - lib/stream-tcp.c | 3 ++ lib/stream-unix.c | 3 ++ lib/s

[ovs-dev] [poll group RFC 6/6] ovsdb: Change jsonrpc server to make use of poll group

2016-02-18 Thread Andy Zhou
When enabled, jsonrpc server creates a poll group for all jsonrpc sessions it created. Signed-off-by: Andy Zhou --- ovsdb/jsonrpc-server.c | 67 ++ 1 file changed, 62 insertions(+), 5 deletions(-) diff --git a/ovsdb/jsonrpc-server.c b/ovsdb/jsonrp

[ovs-dev] [poll group RFC 5/6] lib: Add poll group support in jsonrpc library.

2016-02-18 Thread Andy Zhou
Signed-off-by: Andy Zhou --- lib/jsonrpc.c | 74 +++ lib/jsonrpc.h | 7 ++ 2 files changed, 77 insertions(+), 4 deletions(-) diff --git a/lib/jsonrpc.c b/lib/jsonrpc.c index 35428a6..e8ea8b4 100644 --- a/lib/jsonrpc.c +++ b/lib/jsonrpc

Re: [ovs-dev] [PATCH v3 5/7] ofproto-dpif-xlate: Break recirculation

2016-02-18 Thread Ben Pfaff
On Wed, Feb 10, 2016 at 03:27:53PM -0800, Jarno Rajahalme wrote: > With one question below: > > Acked-by: Jarno Rajahalme Thanks. > > On Feb 9, 2016, at 10:10 PM, Ben Pfaff wrote: > > > > In my opinion, this is less confusing in multiple ways. I now understand > > the code better myself. > >

Re: [ovs-dev] [PATCH v3 7/7] Implement "closures".

2016-02-18 Thread Ben Pfaff
On Thu, Feb 11, 2016 at 12:00:46PM -0800, Jarno Rajahalme wrote: > With the (few) comments below: > > Acked-by: Jarno Rajahalme Thanks. I'm going to post a v4 of this series in a few minutes. It has major revisions, so only some of these comments are relevant now. However, important ones are,