On 18 February 2016 at 09:18, Michael Arnaldi <arnaldimich...@gmail.com> wrote:
> From V3 removed any unnecessary code change and removed cloning of the
> running ovsdb configuration database. We should address SSL in a specific
> patch without depending on the default database.
>
> Signed-off-by: Michael Arnaldi <michael.arna...@mymoneyex.com>
> ---
Just a quick comment regarding patch style, the description above the
"---" will end up in the git repository, so it is useful for later
reference to have a description of what the patch is intended to
achieve ("why"), and perhaps any other context (eg usage) that might
be relevant to someone who doesn't have any context.
For changes between versions of the patches, it is better to place
below the "---". (Which will be dropped automatically by git-am).
Later on, people trying to figure out the motivation for this patch
don't care what the difference is compared with the previous
iteration. They're more interested in what the difference is compared
to the previous state of the codebase in git and why it was done.
There's a brief description of good commit style here:
https://github.com/torvalds/subsurface/blob/master/README#L88
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
