[ovs-dev] OVN - L3 Design

2015-07-08 Thread Gal Sagie
Hello Everyone, I wanted us to start discussing and describing the changes required for the NB/SB schema to support L3 and to hopefully get some visibility into some of the ideas to actually implement it. First, i think everyone would love to hear if there are any plans or any first ideas regardi

Re: [ovs-dev] [PATCH] Add 'name' field to Logical Router

2015-07-08 Thread Russell Bryant
On 07/08/2015 02:44 AM, Gal Sagie wrote: > Adding a name identifier will increase convinence > for Openstack (or Other CMS) that want to identify > the logical router (or store the CMS id in the router name) > > Signed-off-by: Gal Sagie > Signed-off-by: Gal Sagie This seems reasonable to me. I

Re: [ovs-dev] [RFC] ovn: physical network integraiton (WIP)

2015-07-08 Thread Russell Bryant
On 07/07/2015 06:06 PM, Salvatore Orlando wrote: > Reading your post and the associated patch it seems that you're treating > the physical network as a logical port from a pipeline perspective but > exposing it as a logical switch attribute from a NB DB perspective. Is > that correct? Yes, that's

Re: [ovs-dev] [PATCH 1/2] debian: wrap-and-sort

2015-07-08 Thread Ben Pfaff
On Tue, Jul 07, 2015 at 04:04:42PM +0100, James Page wrote: > Wrap long lines and sort items in the Debian packaging files. > > Signed-off-by: James Page Thanks! Applied to master. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailma

Re: [ovs-dev] [PATCH] Add 'flow_hash_symmetric_l3l4' (with/without UDP ports included) to provide symmetric hashes over packet fields excluding the L2 headers that the default 'flow_hash_symmetric_l4'

2015-07-08 Thread Ben Pfaff
Thanks! I made stylistic fixes, expanded the documentation, and applied this to the master branch. By the way, this is the kind of contribution that is particularly valuable from my point of view (once I get to understand it) because it's something that the most prolific OVS contributors probably

Re: [ovs-dev] [PATCH RFC] ofproto-dpif-upcall: Increment dump_seq before instead of after dump.

2015-07-08 Thread Joe Stringer
On 7 July 2015 at 21:42, Ben Pfaff wrote: > On Tue, Jul 07, 2015 at 08:13:58PM -0700, Joe Stringer wrote: >> On 6 July 2015 at 22:20, Ben Pfaff wrote: >> > When process_upcall() passes a miss upcall to upcall_xlate(), the new >> > ukey's dump_seq member is initialized from the current dump_seq.

[ovs-dev] [v2 2/2] ovsdb: Add per transaction commit instruction counter

2015-07-08 Thread Andy Zhou
Measure user space only instruction counters for commit each transaction. This measurement is mainly useful for tuning OVSDB internal implementation, such as how OVSDB scales over number of client connections. A simple usage example: ovs-appctl -t ovsdb-server ovsdb-server/perf-counters-clear ovs

[ovs-dev] [v2 1/2] perf-counter: simplify the performance macro

2015-07-08 Thread Andy Zhou
Replace the original PERF_FUNCTION_BEGIN and PERF_FUNCTION_END pair with a single PERF macro. This design is also more flexible, removing the restriction of have only one measurement per function. The next patch will make use of this macro. Signed-off-by: Andy Zhou --- v1 -> v2: Drop perf-coun

Re: [ovs-dev] [PATCH v1] ofproto: Implement OF1.4 Set/Get asynchronous configuration messages.

2015-07-08 Thread Ben Pfaff
On Tue, Jul 07, 2015 at 01:17:36PM +0530, niti1...@gmail.com wrote: > From: Niti > > This patch adds support for Openflow1.4 set/get asynchronous configuration > messages. OpenVSwitch already supports set/get asynchronous configuration > messages for Openflow1.3. In this patch OFPT_SET_ASYNC_CONF

Re: [ovs-dev] Openflow 1.4 - Vacancy Events

2015-07-08 Thread Ben Pfaff
On Tue, Jul 07, 2015 at 04:05:14PM +0530, Saloni Jain wrote: > I want to implement and contribute Vacancy Events (EXT-192), Openflow 1.4 > feature to OpenVSwitch.  > If anybody has already started working on it then please let us know. Your own colleague Shashwat Srivastava started on this last

Re: [ovs-dev] [PATCH RFC] ofproto-dpif-upcall: Increment dump_seq before instead of after dump.

2015-07-08 Thread Ben Pfaff
On Wed, Jul 08, 2015 at 01:12:26PM -0700, Joe Stringer wrote: > On 7 July 2015 at 21:42, Ben Pfaff wrote: > > On Tue, Jul 07, 2015 at 08:13:58PM -0700, Joe Stringer wrote: > >> On 6 July 2015 at 22:20, Ben Pfaff wrote: > >> > When process_upcall() passes a miss upcall to upcall_xlate(), the new >

Re: [ovs-dev] [PATCH RFC] ofproto-dpif-upcall: Increment dump_seq before instead of after dump.

2015-07-08 Thread Joe Stringer
On 8 July 2015 at 17:10, Ben Pfaff wrote: > On Wed, Jul 08, 2015 at 01:12:26PM -0700, Joe Stringer wrote: >> On 7 July 2015 at 21:42, Ben Pfaff wrote: >> > On Tue, Jul 07, 2015 at 08:13:58PM -0700, Joe Stringer wrote: >> >> On 6 July 2015 at 22:20, Ben Pfaff wrote: >> >> > When process_upcall()

Re: [ovs-dev] [PATCH] Add 'flow_hash_symmetric_l3l4' (with/without UDP ports included) to provide symmetric hashes over packet fields excluding the L2 headers that the default 'flow_hash_symmetric_l4'

2015-07-08 Thread Jeroen van Bemmel
You're very welcome - and who knows, you may find yourself in a situation where you will need these options. Always good to give users a choice We really should add some test cases for this - I managed to run 'make check' on a regular Ubuntu server just now, must have had something to do with my V

Re: [ovs-dev] [PATCH 1/3] db-ctl-base: fix a few typos

2015-07-08 Thread Alex Wang
Acked-by: Alex Wang On Tue, Jul 7, 2015 at 8:07 PM, Andy Zhou wrote: > Minor typo and style fixes. > > Signed-off-by: Andy Zhou > --- > lib/db-ctl-base.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/db-ctl-base.h b/lib/db-ctl-base.h > index ba177f2..f14d2

Re: [ovs-dev] [PATCH 2/3] db-ctl-base: Do not expose get_table() API

2015-07-08 Thread Alex Wang
On Tue, Jul 7, 2015 at 8:08 PM, Andy Zhou wrote: > Both get_table() and set_cloum() APIs are mostly used within db-ctl-base > library. This patch makes both private to the library. > > Add a new ctl_set_colum() API for library client. > > The changes are cleanups. No functional changes. > > Signe

Re: [ovs-dev] Openflow 1.4 - Vacancy Events

2015-07-08 Thread Saloni Jain
Hi Ben, Thanks for the reply.  I have talked to Shashwat regarding implementation of Vacancy Events, I will be contributing vacancy events feature to OVS.  Thanks and Regards, Saloni Jain Tata Consultancy Services Mailto: saloni.j...@tcs.com Website: http://www.tcs.com __