On 07/08/2015 02:44 AM, Gal Sagie wrote:
> Adding a name identifier will increase convinence
> for Openstack (or Other CMS) that want to identify
> the logical router (or store the CMS id in the router name)
> 
> Signed-off-by: Gal Sagie <gal.sa...@gmail.com>
> Signed-off-by: Gal Sagie <gal.sa...@huawei.com>

This seems reasonable to me.  It seems odd to have two s-o-b headers,
though.  Maybe pick one?

Acked-by: Russell Bryant <rbry...@redhat.com>

> ---
>  ovn/ovn-nb.ovsschema | 1 +
>  ovn/ovn-nb.xml       | 9 +++++++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/ovn/ovn-nb.ovsschema b/ovn/ovn-nb.ovsschema
> index 782e0f2..8fe378a 100644
> --- a/ovn/ovn-nb.ovsschema
> +++ b/ovn/ovn-nb.ovsschema
> @@ -59,6 +59,7 @@
>              "isRoot": false},
>          "Logical_Router": {
>              "columns": {
> +                "name": {"type": "string"},
>                  "ports": {"type": {"key": {"type": "uuid",
>                                             "refTable": "Logical_Router_Port",
>                                             "refType": "weak"},
> diff --git a/ovn/ovn-nb.xml b/ovn/ovn-nb.xml
> index cafba14..266e6a4 100644
> --- a/ovn/ovn-nb.xml
> +++ b/ovn/ovn-nb.xml
> @@ -266,6 +266,15 @@
>        Each row represents one L3 logical router.
>      </p>
>  
> +    <column name="name">
> +      <p>
> +        A name for the logical router.  This name has no special meaning or 
> purpose
> +        other than to provide convenience for human interaction with the 
> ovn-nb
> +        database.  There is no requirement for the name to be unique.  The
> +        logical router's UUID should be used as the unique identifier.
> +      </p>
> +    </column>
> +
>      <column name="ports">
>        The router's ports.  This is a set of weak references, so a <ref
>        table="Logical_Switch"/> must also refer to any given <ref
> 


-- 
Russell Bryant
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to