On Mon, Jun 22, 2015 at 5:21 PM, Alin Serdean
wrote:
> I could send another patch with the following:
> -tskill $i
> +taskkill //PID $i //F >/dev/null
>
> Alin.
Your current patch is something that I think we should apply because
from Windows' persp
I applied this patch as-is. We still need to figure out the issue around tskill.
On Tue, Jun 23, 2015 at 7:05 AM, Gurucharan Shetty wrote:
> On Mon, Jun 22, 2015 at 5:21 PM, Alin Serdean
> wrote:
>> I could send another patch with the following:
>> -tskill $i
>> +
On Mon, Jun 22, 2015 at 3:45 PM, Alin Serdean
wrote:
> In case the ovsdb-server failed to start, the defined service was not
> properly cleaned.
>
> Add a run-if-false command in case the service failed to start.
>
> Signed-off-by: Alin Gabriel Serdean
Applied, thanks.
> ---
> tests/daemon.at |
On Mon, Jun 22, 2015 at 3:45 PM, Alin Serdean
wrote:
> Describe explictly where to add the pthread library to the PATH variable.
>
> In case the pthread library directory was added to the user PATH variable
> the service failed to start.
>
> Signed-off-by: Alin Gabriel Serdean
> ---
> INSTALL.Wi
Extend bfd to save wall clock time of the last flap in bfd_forwarding__,
and display it throught bfd/show. This information is also exported out
to ovsdb in bfd_get_status.
Signed-off-by: Sabyasachi Sengupta
diff --git a/lib/bfd.c b/lib/bfd.c
index 92fdbd8..c8122b0 100644
--- a/lib/bfd.c
On Thu, Jun 11, 2015 at 07:37:02PM -0700, Alex Wang wrote:
> This commit adds improvement to 'show' command logic and allows it
> to print key->table_ref maps. The direct effect can be observed
> from the tests/vtep-ctl.at change. The improvement will also be
> used in the ovn-sbctl implementatio
Reported-by: Ian Stokes
Signed-off-by: Gurucharan Shetty
---
ovn/automake.mk|1 +
ovn/controller/automake.mk |1 +
ovn/utilities/automake.mk |3 +++
utilities/automake.mk |2 ++
4 files changed, 7 insertions(+)
diff --git a/ovn/automake.mk b/ovn/automake.mk
ind
On 06/23/2015 10:49 AM, Gurucharan Shetty wrote:
> Reported-by: Ian Stokes
> Signed-off-by: Gurucharan Shetty
> ---
> ovn/automake.mk|1 +
> ovn/controller/automake.mk |1 +
> ovn/utilities/automake.mk |3 +++
> utilities/automake.mk |2 ++
> 4 files changed, 7
> -Original Message-
> From: Gurucharan Shetty [mailto:shet...@nicira.com]
> Sent: Tuesday, June 23, 2015 3:49 PM
> To: dev@openvswitch.org
> Cc: Stokes, Ian; Gurucharan Shetty
> Subject: [PATCH] Add a few OVN files as part of DISTCLEANFILES.
>
> Reported-by: Ian Stokes
> Signed-off-by:
Thank you Russell and Ian.
I applied this to master.
On Tue, Jun 23, 2015 at 9:30 AM, Stokes, Ian wrote:
>
>
>> -Original Message-
>> From: Gurucharan Shetty [mailto:shet...@nicira.com]
>> Sent: Tuesday, June 23, 2015 3:49 PM
>> To: dev@openvswitch.org
>> Cc: Stokes, Ian; Gurucharan Shett
Thx a lot for the review!
Applied series to master,
On Tue, Jun 23, 2015 at 8:44 AM, Ben Pfaff wrote:
> On Thu, Jun 11, 2015 at 07:37:02PM -0700, Alex Wang wrote:
> > This commit adds improvement to 'show' command logic and allows it
> > to print key->table_ref maps. The direct effect can be o
Thanks for the reviews. I applied these to master.
On Mon, Jun 22, 2015 at 11:13:39PM -0700, Alex Wang wrote:
> Thx for the explanation,
>
> Looks good to me,
>
> On Mon, Jun 22, 2015 at 3:06 PM, Ben Pfaff wrote:
>
> > On Mon, Jun 22, 2015 at 10:50:55AM -0700, Alex Wang wrote:
> > > On Wed, J
I'd appreciate a review for this because I'd like to get it into OVS
2.4. The "conjunction match" feature is new in 2.4 and I'd like to have
it have this feature there.
On Mon, Jun 15, 2015 at 01:58:32PM -0700, Ben Pfaff wrote:
> It doesn't make sense to mix "conjunction" actions with most other
While working on OpenStack Neutron integration for OVN, I came across a small
feature gap. The Neutron API supports setting a port as administratively down.
One way to implement that would be to delete ports from OVN while
administratively down. However, it seemed to me that it would be nice to k
This patch adds support for getting and setting the 'enabled' column
for logical ports using ovn-nbctl.
Signed-off-by: Russell Bryant
---
ovn/ovn-nbctl.8.xml | 13
ovn/ovn-nbctl.c | 59 +
2 files changed, 72 insertions(+)
diff
This patch adds a new column to the Logical_Port table of the
OVN_Northbound database called 'enabled'. The purpose is to allow a
port to be administratively enabled or disabled. It is sometimes
useful to keep a port and its related configuration, but temporarily
disable it, which means no traffi
V11: Add inner tpid to flow key. Fix separate inner encap attribute
when parsing netlink attributes. Merge 2 patches to consolidate
qinq changes.
V10: Implement reviewer comments: Consolidate vlan parsing functions.
Splits netlink parsing and flow conversion into a separate patch. Uses
double enca
openvswitch: Add support for 8021.AD
Change the description of the VLAN tpid field.
Signed-off-by: Thomas F Herbert
---
include/uapi/linux/openvswitch.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/op
Signed-off-by: Thomas F Herbert
---
include/linux/if_vlan.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
index 920e445..3713454 100644
--- a/include/linux/if_vlan.h
+++ b/include/linux/if_vlan.h
@@ -627,5 +627,14 @@ static inline n
Add support for 802.1ad including the ability to push and pop double
tagged vlans. Add support for 802.1ad to netlink parsing and flow
conversion. Uses double nested encap attributes to represent double
tagged vlan. Inner TPID encoded along with ctci in nested attributes.
Signed-off-by: Thomas F H
From: "Thomas F. Herbert"
Version 11: Encode inner tpid in with customer tci into netlink
in inner encapsulation. Some cleanup in code and comments. The patch
adding 802.1ad support functions, which is already merged is removed
from this series. This patch accompanies V11 kernel module patch
subm
From: "Thomas F. Herbert"
Netlink parsing and flow key conversion. Netlink attribute encoding is done
with double encap attributes. Netlink attributes for 802.1ad look like
the following:
eth_type(0x88a8),vlan(vid=100),encap(eth_type(0x8100), vlan(vid=200),
encap(eth_type(0x0800)
From: "Thomas F. Herbert"
The flow structure is updated to hold the customer tci.
Flow key extraction is changed to add support for ctci and both TPIDs.
Parsing to support pushing and popping with both single and double
tagged vlans. In response to reviewers comments on V6, all changes
affected b
Groups were not destroyed until after lots of other important bridge
data had been destroyed, including the connection manager. There was an
indirect dependency on the connection manager for bridge destruction
because destroying a group also destroys all of the flows that reference
the group, whic
From: "Thomas F. Herbert"
Signed-off-by: Thomas F Herbert
---
NEWS | 2 ++
utilities/ovs-ofctl.8.in | 3 +--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index a0664dc..581da59 100644
--- a/NEWS
+++ b/NEWS
@@ -7,6 +7,8 @@ Post-v2.4.0
v2.4.0 -
On Wed, Jun 17, 2015 at 02:22:32PM +0900, Simon Horman wrote:
> As per the testcase included in this patch it has been observed
> that ovs-vswtichd may segfault when deleting a bridge.
>
> Analysing the output of valgrind and gdb it appears that
> this is caused by the connmgr of a ofproto being a
Do you two have an opinion on this? If DPDK support is pretty solid now
then it makes sense to apply this to master and backport it to
branch-2.4.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
From: "Thomas F. Herbert"
This test tests the user space actions for 802.1q and 802.1ad.
Signed-off-by: Thomas F Herbert
Signed-off-by: Dave Benson
---
tests/ofproto-dpif.at | 40
1 file changed, 40 insertions(+)
diff --git a/tests/ofproto-dpif.at b/t
Hello.
On 06/23/2015 09:26 PM, Thomas F Herbert wrote:
Signed-off-by: Thomas F Herbert
[...]
diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
index 920e445..3713454 100644
--- a/include/linux/if_vlan.h
+++ b/include/linux/if_vlan.h
@@ -627,5 +627,14 @@ static inline netdev_fea
On 6/17/15 2:41 PM, Flavio Leitner wrote:
Signed-off-by: Flavio Leitner
---
INSTALL.DPDK.md | 3 ---
1 file changed, 3 deletions(-)
It looks like a good time to promote DPDK support before
2.4 is branched off.
What do you think?
+1
diff --git a/INSTALL.DPDK.md b/INSTALL.DPDK.md
On Tue, Jun 23, 2015 at 12:02:44AM +, Nithin Raju wrote:
> > On Jun 22, 2015, at 10:58 AM, Sorin Vinturis
> > wrote:
> >
> > Hi Nithin,
> >
> > I didn't thought about your idea. I have added instrumentation code in
> > order to force the EEXIST error and test the patch and the code perform
> On Jun 23, 2015, at 11:46 AM, Ben Pfaff wrote:
>
> On Tue, Jun 23, 2015 at 12:02:44AM +, Nithin Raju wrote:
>>> On Jun 22, 2015, at 10:58 AM, Sorin Vinturis
>>> wrote:
>>>
>>> Hi Nithin,
>>>
>>> I didn't thought about your idea. I have added instrumentation code in
>>> order to force t
On 6/23/15 2:43 PM, Sergei Shtylyov wrote:
Hello.
On 06/23/2015 09:26 PM, Thomas F Herbert wrote:
Signed-off-by: Thomas F Herbert
[...]
diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
index 920e445..3713454 100644
--- a/include/linux/if_vlan.h
+++ b/include/linux/if_vlan.h
@
On 06/23/2015 02:22 PM, Russell Bryant wrote:
> While working on OpenStack Neutron integration for OVN, I came across a small
> feature gap. The Neutron API supports setting a port as administratively
> down.
> One way to implement that would be to delete ports from OVN while
> administratively d
Should I take that as a positive review?
On Fri, Jun 19, 2015 at 06:51:17AM +, Nithin Raju wrote:
> Thanks Alin.
>
> > On Jun 18, 2015, at 2:00 PM, Alin Serdean
> > wrote:
> >
> > Delete internal port
> > Test connectivity
> > Add internal port
> > Test connectivity
> >
> > Delete externa
On Thu, Jun 18, 2015 at 09:05:32PM +, Nithin Raju wrote:
> > On Jun 18, 2015, at 1:57 PM, Alin Serdean
> > wrote:
> >
> > I have no issue with it if it is tested.
> >
> > Yes Nithin you are right we agreed that you will work on it but it was in
> > the backlog for some time and it is a sho
Oh I see there's a v2.
On Tue, Jun 23, 2015 at 12:40:32PM -0700, Ben Pfaff wrote:
> Should I take that as a positive review?
>
> On Fri, Jun 19, 2015 at 06:51:17AM +, Nithin Raju wrote:
> > Thanks Alin.
> >
> > > On Jun 18, 2015, at 2:00 PM, Alin Serdean
> > > wrote:
> > >
> > > Delete in
On Thu, Jun 18, 2015 at 02:31:18PM -0700, Shashank Shanbhag wrote:
> From: Shashank Shanbhag
>
> Fix replace-flows and diff-flows to modify/diff flows in multiple tables.
> Add a --tables(-T) option that allows the user to specify a comma-separated
> list of table indexes to replace/diff.
> Fix r
On Thu, Jun 18, 2015 at 02:39:07PM -0700, Shashank Shanbhag wrote:
> You also suggested that we move to using an array rather than a hash.
> http://openvswitch.org/pipermail/dev/2015-June/055998.html
>
> An array of 255 pointers to classifiers would lead to 2040 bytes (64-bit
> system). I'd like t
On Fri, Jun 19, 2015 at 05:32:06PM -0700, Romain Lenglet wrote:
>
> On June 18, 2015 at 2:39:31 PM, Shashank Shanbhag
> (shashank.shanb...@gmail.com(mailto:shashank.shanb...@gmail.com)) wrote:
>
> > Hi Ben,
> >
> > Please review when you get a chance. We would really like this to be in the
>
Use IPv6 internally for storing multicast addresses. IPv4 addresses are
translated to their IPv4-mapped equivalent.
Signed-off-by: Thadeu Lima de Souza Cascardo
---
lib/mcast-snooping.c | 69 +++-
lib/mcast-snooping.h | 24 +++
Identation was one extra level at ofproto_unixctl_mcast_snooping_show.
Signed-off-by: Thadeu Lima de Souza Cascardo
---
ofproto/ofproto-dpif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 05a80b7..04f6229 100644
--- a/o
Add support for MLDv1 and MLDv2. The behavior is not that different from
IGMP. Packets to all-hosts address and queries are always flooded,
reports go to routers, routers are added when a query is observed, and
all MLD packets go through slow path.
Signed-off-by: Thadeu Lima de Souza Cascardo
---
Ben,
Thanks for taking a look. I’ll move to using an array, and will send out the
patch as soon as possible.
Shashank
On Jun 23, 2015, at 12:58 PM, Ben Pfaff wrote:
> On Thu, Jun 18, 2015 at 02:39:07PM -0700, Shashank Shanbhag wrote:
>> You also suggested that we move to using an array rathe
> On Jun 23, 2015, at 12:42 PM, Ben Pfaff wrote:
>
> On Thu, Jun 18, 2015 at 09:05:32PM +, Nithin Raju wrote:
>>> On Jun 18, 2015, at 1:57 PM, Alin Serdean
>>> wrote:
>>>
>>> I have no issue with it if it is tested.
>>>
>>> Yes Nithin you are right we agreed that you will work on it but i
On Mon, Jun 22, 2015 at 02:34:07PM -0400, Russell Bryant wrote:
> On 06/15/2015 08:00 PM, Ben Pfaff wrote:
> > On Wed, Jun 10, 2015 at 03:13:54PM -0400, Russell Bryant wrote:
> >> Provider Networks
> >> =
> >>
> >> OpenStack Neutron currently has a feature referred to as "provider
>
On 06/23/2015 04:17 PM, Ben Pfaff wrote:
> On Mon, Jun 22, 2015 at 02:34:07PM -0400, Russell Bryant wrote:
>> On 06/15/2015 08:00 PM, Ben Pfaff wrote:
>>> On Wed, Jun 10, 2015 at 03:13:54PM -0400, Russell Bryant wrote:
Provider Networks
=
OpenStack Neutron curren
On Tue, Jun 23, 2015 at 04:54:20PM -0400, Russell Bryant wrote:
> On 06/23/2015 04:17 PM, Ben Pfaff wrote:
> > On Mon, Jun 22, 2015 at 02:34:07PM -0400, Russell Bryant wrote:
> >> On 06/15/2015 08:00 PM, Ben Pfaff wrote:
> >>> On Wed, Jun 10, 2015 at 03:13:54PM -0400, Russell Bryant wrote:
> P
On 06/23/2015 05:10 PM, Ben Pfaff wrote:
> On Tue, Jun 23, 2015 at 04:54:20PM -0400, Russell Bryant wrote:
>> On 06/23/2015 04:17 PM, Ben Pfaff wrote:
>>> On Mon, Jun 22, 2015 at 02:34:07PM -0400, Russell Bryant wrote:
On 06/15/2015 08:00 PM, Ben Pfaff wrote:
> On Wed, Jun 10, 2015 at 03:1
On Mon, Jun 22, 2015 at 8:08 PM, Pravin Shelar wrote:
> On Fri, Jun 19, 2015 at 11:24 AM, Daniele Di Proietto
> wrote:
>>
>>
>> On 18/06/2015 23:57, "Traynor, Kevin" wrote:
>>
>>>
>>>
-Original Message-
>>>
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di
I'm afraid I have to start bike shedding on this thread too.
Apparently that's what I do best.
More inline,
Salvatore
On 23 June 2015 at 23:23, Russell Bryant wrote:
> On 06/23/2015 05:10 PM, Ben Pfaff wrote:
> > On Tue, Jun 23, 2015 at 04:54:20PM -0400, Russell Bryant wrote:
> >> On 06/23/2015
On Tue, Jun 23, 2015 at 11:58:25PM +0200, Salvatore Orlando wrote:
> I'm afraid I have to start bike shedding on this thread too.
> Apparently that's what I do best.
These are important clarifications, not bikeshedding.
More below (with lots of trimming and reflowing for clarity):
> On 06/23/201
On Tue, Jun 23, 2015 at 11:42:15AM -0700, Ben Pfaff wrote:
> Do you two have an opinion on this? If DPDK support is pretty solid now
> then it makes sense to apply this to master and backport it to
> branch-2.4.
Daniele, what is your opinion?
___
dev ma
How about the following:
Before running the unit tests make sure to add the pthread libraries to your
PATH environment variable.
One of the unit tests starts Open vSwitch as a system wide service. This
test expects the pthread libraries path to be in the Windows' SYSTEM PATH
environment variable.
Think I found why tskill is missing on my system. It is part of the role remote
desktop services role https://technet.microsoft.com/en-us/library/cc725766.aspx
while taskkill is part of the default installation.
Theoretically taskkill with option /f
"Specifies that processes be forcefully termi
On Tue, Jun 23, 2015 at 11:42 AM, Ben Pfaff wrote:
> Do you two have an opinion on this? If DPDK support is pretty solid now
> then it makes sense to apply this to master and backport it to
> branch-2.4.
Personally I would like to have better testing with vhost, tunneling
and PMD thread manageme
On Tue, Jun 23, 2015 at 2:51 PM, Jesse Gross wrote:
> On Mon, Jun 22, 2015 at 8:08 PM, Pravin Shelar wrote:
>> On Fri, Jun 19, 2015 at 11:24 AM, Daniele Di Proietto
>> wrote:
>>>
>>>
>>> On 18/06/2015 23:57, "Traynor, Kevin" wrote:
>>>
> -Original Message-
> From:
On Tue, Jun 23, 2015 at 7:06 PM, Pravin Shelar wrote:
> On Tue, Jun 23, 2015 at 2:51 PM, Jesse Gross wrote:
>> On Mon, Jun 22, 2015 at 8:08 PM, Pravin Shelar wrote:
>>> On Fri, Jun 19, 2015 at 11:24 AM, Daniele Di Proietto
>>> wrote:
On 18/06/2015 23:57, "Traynor, Kevin" wrote:
On Tue, Jun 23, 2015 at 7:09 PM, Jesse Gross wrote:
> On Tue, Jun 23, 2015 at 7:06 PM, Pravin Shelar wrote:
>> On Tue, Jun 23, 2015 at 2:51 PM, Jesse Gross wrote:
>>> On Mon, Jun 22, 2015 at 8:08 PM, Pravin Shelar wrote:
On Fri, Jun 19, 2015 at 11:24 AM, Daniele Di Proietto
wrote:
>>
On Tue, Jun 23, 2015 at 7:22 PM, Pravin Shelar wrote:
> On Tue, Jun 23, 2015 at 7:09 PM, Jesse Gross wrote:
>> On Tue, Jun 23, 2015 at 7:06 PM, Pravin Shelar wrote:
>>> On Tue, Jun 23, 2015 at 2:51 PM, Jesse Gross wrote:
On Mon, Jun 22, 2015 at 8:08 PM, Pravin Shelar wrote:
> On Fri,
60 matches
Mail list logo
